- 23 Jan, 2020 40 commits
-
-
Avi Drissman authored
MAC_OS_X_VERSION_10_12 is true if Chromium is being built with the macOS 10.12 SDK or newer, as it’s been since mid 2017. MAC_OS_X_VERSION_10_12 is not a runtime check for macOS 10.12 and cannot be used as such. Bug: 1044838 Change-Id: Ia8e40d0f3aab0405e423847dcf9ea1ea2f535091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016846 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#734617}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/9ad78aa7dba2..a4f9acedf3c0 git log 9ad78aa7dba2..a4f9acedf3c0 --date=short --first-parent --format='%ad %ae %s' 2020-01-23 rharrison@google.com Big cleanup to normalize API behaviour (#967) Created with: gclient setdep -r src/third_party/shaderc/src@a4f9acedf3c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I63e1ccddd1831d15caec16c72b2b74b6a666e984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017653Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734616}
-
Manu Cornet authored
Split out some helper classes into their own files in the process: HotseatStateWatcher, OverviewAnimationWaiter, ShelfLayoutManagerTestBase. This is a pure (albeit large) refactoring and does not modify any of the actual test semantics. Change-Id: Ica79e3dcead839daa83022de329b5aca8f636c40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015672 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#734615}
-
Sebastien Lalancette authored
I apparently misunderstood how the test expectations framework works. Follow-up from: https://chromium-review.googlesource.com/c/chromium/src/+/2016857 TBR=chenwilliam@chromium.org Change-Id: I23d99c45c172cd6849b02b33313c7a0c3e4c033f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015431 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#734614}
-
behdad authored
The reporters which caused no damage (Impl or Main) are terminated and will not be reported to the compositor latency metrics. Bug: chromium:1030304 Cq-Depend: chromium:1961074 Change-Id: I8cc4afe4b00f86b9f4893347d6ef76d8bf0126ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992345Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#734613}
-
Avi Drissman authored
BUG=1044828 Change-Id: Ifdbd3a894fe2bf35e784e59620bedcc4063da35b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017044 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
kylechar authored
ContextFactoryObserver is just a wrapper around ContextLostObserver at this point. Switch SurfaceTreeHost so it's a ContextLostObserver. Keep the existing behaviour of posting a new task to handle context lost. This used to happen before ContextFactoryObservers were notified, but now it happens in SurfaceTreeHost::OnContextLost(). TEST=Verified arc++ apps recover after GPU crash on nocturne. Bug: 947279 Change-Id: I0cc9513ee8df252f0143f9c9af12eac84a39eadb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003470Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#734611}
-
Avery Musbach authored
Test: ash_unittests All/SplitViewOverviewSessionInClamshellTestMultiDisplayOnly.DragAndDropIntoAnotherOverviewGrid/0 Test: ash_unittests All/SplitViewOverviewSessionInClamshellTestMultiDisplayOnly.OverviewWidgetStackingOrderWithMultiDisplayDragging/0 Bug: 961170 Change-Id: I56862dfd8094b72ce0abf07a855d058be3d3c3da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008237 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#734610}
-
Mike Reed authored
Very mechanical change: - MScalar --> Scalar - some conversion helpers just not needed: e.g. float_to_scalar Change-Id: I38104e07e8cbef0eba641cdf54fb77858691bc2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013861Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#734609}
-
Yuly Novikov authored
Slight update to MSVC - VS version from 16.3.1 to 16.4.3 as a side effect. Other components kept at the old versions: Windows SDK 10.0.18362 Debuggers 10.0.17763 d3dcompiler_47.dll 10.0.17134 Packaging was done on a Windows Server 2019 VM, cleanly created for this purpose. The package was created by downloading VS Professional 2019 installer from https://visualstudio.microsoft.com/downloads/ and then running the installer like this: $ PATH_TO_INSTALLER.EXE ^ --add Microsoft.VisualStudio.Workload.NativeDesktop ^ --add Microsoft.VisualStudio.Component.VC.ATLMFC ^ --add Microsoft.VisualStudio.Component.VC.Tools.ARM64 ^ --add Microsoft.VisualStudio.Component.VC.MFC.ARM64 ^ --includeRecommended --passive The 10.0.18362.0 SDK was installed by this as well. Then Add or Remove Programs was used to modify the 10.0.18362.0 SDK to add the Debuggers package. Then the packaging script was run like this: python depot_tools\win_toolchain\package_from_installed.py 2019 -w 10.0.18362.0 Since the new d3dcompiler_47.dll uses the UCRT and we want to avoid shipping that the final packaging step was to unzip the package, copy over the two copies of that DLL from win_sdk\Redist, replace the Debuggers directory with the 10.0.17763 SDK, and then repackage the toolchain with: > python package_from_installed.py --repackage=<full-path-to-toolchain-dir> UWP support was previously added to package_from_installed.py in http://crrev.com/c/2007881 and http://crrev.com/c/2013579 Bug: 1032635 Change-Id: I85313de0529aa7591e5066bc697c640c5dc52463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015984Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#734608}
-
Jay Harris authored
This is needed for the upcoming file handling origin trial, which will store state in the operating system, which needs to be cleaned up when the trial expires. WIP CL for the file handling origin trial: https://crrev.com/c/1940001 Bug: 1028448 Change-Id: I3bc8b5cdb786ef17bc8a0360f99d7b07d0cfd4b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010604Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#734607}
-
Scott Violet authored
BUG=1033924 TEST=weblayer_support_instrumentation_test_apk BrowserFragmentLifecycleTest.restoresPreviousSession Change-Id: I8f74fda02ff0170c55fe3351153d8180362c9a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015726Reviewed-by:Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#734606}
-
Avi Drissman authored
MAC_OS_X_VERSION_10_12 is true if Chromium is being built with the macOS 10.12 SDK or newer, as it’s been since mid 2017. MAC_OS_X_VERSION_10_12 is not a runtime check for macOS 10.12 and cannot be used as such. Bug: 1044838, 992915 Change-Id: I28e00f3786831e8899eef917cb5eda3d031e1a2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016847 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Tricia Crichton authored
During ConnectIfNecessary, ChromeDriver will not wait for response to commands issued to DevTools. The first command can take very long to return when running in a debug build. This cl mimics the ways that other initialization commands are sent. Bug: 1040589 Change-Id: I4ca2fc090700f346a29d7b4a2708f486c8cbe847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015359Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#734604}
-
David Black authored
Existing feature implementation has been stable for a long time and probably no longer needs a kill switch. We can reuse the flag for upcoming experimentation but removing completely in this CL as the flag will be re-defined in the same file as all other Assistant feature flags. Bug: b:148219866 Change-Id: If8e3bca7f141b06c822ae4a8d75bb940c4c37b8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017666Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#734603}
-
Clark DuVall authored
This creates the permissions component, and moves in PermissionRequest, PermissionRequestID, and PermissionResult. Most of the changes in //chrome were performed with sed: - change includes of moved classes from chrome/browser/permissions to components/permissions - add permissions:: namespace on moved classes Bug: 1025609 Change-Id: Id13b874e84b9fadf96b228154091c5cc0b8f0121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015763Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#734602}
-
Ryan Sturm authored
This feature allows us to experiment on Google without possibly creating issues with non-Google DSEs. This will hopefully prevent problems or regressions with other search engines. Bug: 1036489 Change-Id: I499b580b1bc0a2d25bed1c8727ba8b36ef6259b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013748 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#734601}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=eugenebut@chromium.org Bug: 1042208 Change-Id: I2ac990201f0de9332a204023c8ad2ebbf18a9407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017347 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#734600}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c040c8f85051..e386b83c7d0a git log c040c8f85051..e386b83c7d0a --date=short --first-parent --format='%ad %ae %s' 2020-01-23 thestig@chromium.org Roll third_party/freetype/src/ 50b013871..e5038be70 (2 commits) 2020-01-23 maawas@microsoft.com Adding password form flag for text fields in fpdf_annot.h 2020-01-23 tsepez@chromium.org Avoid casting CXFA_FFListBox to CXFA_FFComboBox. 2020-01-23 maawas@microsoft.com Move get form field logic to common method in fpdf_annot.h 2020-01-23 nigi@chromium.org Add a pixel test with invalid bfranges inside ToUnicode map. Created with: gclient setdep -r src/third_party/pdfium@e386b83c7d0a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1021762,chromium:1043508 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I1f35a228e82af5e7b7169f2f5e7d07b891d6a5b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017655Reviewed-by:
-
Dan H authored
This reverts commit ef75a2f4. Reason for revert: The reland wasn't intended to be submitted yet. Original change's description: > Reland "Standardize feed android resources" > > This reverts commit 807fab79. > > Reason for revert: Culprit was errorprone update this morning, which happened after trybot runs for this CL. > > Original change's description: > > Revert "Standardize feed android resources" > > > > This reverts commit 0e853eb9. > > > > Reason for revert: Suspect culprit for build failure > > > > Sample failure: > > https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/8660 > > > > Original change's description: > > > Standardize feed android resources > > > > > > - Restructure to match chrome/browser/java/res > > > - Replace strings with references to existing .grd strings > > > - I kept Piet resources separate, since piet may eventually be moved into > > > a different library. > > > - Move feed/library sources into chrome_java > > > > > > Strings changed: > > > snackbar_fetch_no_new_suggestions -> ntp_suggestions_fetch_no_new_suggestions > > > snackbar_fetch_failed -> ntp_suggestions_fetch_failed > > > snackbar_default_action -> undo > > > > > > It looks like chromium's strings are translated to more languages, so > > > this might provide better localization. Some of these strings are > > > translated differently between feed and zine. > > > > > > Bug: 1024945 > > > Change-Id: If9862a4965756e28ba812bf315556d6b8db09e62 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956275 > > > Reviewed-by: David Trainor <dtrainor@chromium.org> > > > Reviewed-by: Peter Wen <wnwen@chromium.org> > > > Reviewed-by: Theresa <twellington@chromium.org> > > > Reviewed-by: Carlos Knippschild <carlosk@chromium.org> > > > Commit-Queue: Dan H <harringtond@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#734575} > > > > TBR=wnwen@chromium.org,dtrainor@chromium.org,twellington@chromium.org,govind@chromium.org,megjablon@chromium.org,carlosk@chromium.org,harringtond@chromium.org > > > > Change-Id: I3c14db8a0c67bf5b784955df6241443489b5b8af > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1024945 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015411 > > Reviewed-by: Sebastien Lalancette <seblalancette@chromium.org> > > Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#734596} > > TBR=wnwen@chromium.org,dtrainor@chromium.org,twellington@chromium.org,govind@chromium.org,megjablon@chromium.org,carlosk@chromium.org,seblalancette@chromium.org,harringtond@chromium.org > > Change-Id: Ie6d83d3cf8d802a70cc73e4a24b0872d3b04ae17 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1024945 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017944 > Reviewed-by: Dan H <harringtond@chromium.org> > Commit-Queue: Dan H <harringtond@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734597} TBR=wnwen@chromium.org,dtrainor@chromium.org,twellington@chromium.org,govind@chromium.org,megjablon@chromium.org,carlosk@chromium.org,seblalancette@chromium.org,harringtond@chromium.org Change-Id: I8151ab3fe16c219f2d9c3295a7d7b6c0c7d69731 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1024945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017946Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#734598}
-
Dan H authored
This reverts commit 807fab79. Reason for revert: Culprit was errorprone update this morning, which happened after trybot runs for this CL. Original change's description: > Revert "Standardize feed android resources" > > This reverts commit 0e853eb9. > > Reason for revert: Suspect culprit for build failure > > Sample failure: > https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/8660 > > Original change's description: > > Standardize feed android resources > > > > - Restructure to match chrome/browser/java/res > > - Replace strings with references to existing .grd strings > > - I kept Piet resources separate, since piet may eventually be moved into > > a different library. > > - Move feed/library sources into chrome_java > > > > Strings changed: > > snackbar_fetch_no_new_suggestions -> ntp_suggestions_fetch_no_new_suggestions > > snackbar_fetch_failed -> ntp_suggestions_fetch_failed > > snackbar_default_action -> undo > > > > It looks like chromium's strings are translated to more languages, so > > this might provide better localization. Some of these strings are > > translated differently between feed and zine. > > > > Bug: 1024945 > > Change-Id: If9862a4965756e28ba812bf315556d6b8db09e62 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956275 > > Reviewed-by: David Trainor <dtrainor@chromium.org> > > Reviewed-by: Peter Wen <wnwen@chromium.org> > > Reviewed-by: Theresa <twellington@chromium.org> > > Reviewed-by: Carlos Knippschild <carlosk@chromium.org> > > Commit-Queue: Dan H <harringtond@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#734575} > > TBR=wnwen@chromium.org,dtrainor@chromium.org,twellington@chromium.org,govind@chromium.org,megjablon@chromium.org,carlosk@chromium.org,harringtond@chromium.org > > Change-Id: I3c14db8a0c67bf5b784955df6241443489b5b8af > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1024945 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015411 > Reviewed-by: Sebastien Lalancette <seblalancette@chromium.org> > Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734596} TBR=wnwen@chromium.org,dtrainor@chromium.org,twellington@chromium.org,govind@chromium.org,megjablon@chromium.org,carlosk@chromium.org,seblalancette@chromium.org,harringtond@chromium.org Change-Id: Ie6d83d3cf8d802a70cc73e4a24b0872d3b04ae17 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1024945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017944Reviewed-by:
-
Sebastien Lalancette authored
This reverts commit 0e853eb9. Reason for revert: Suspect culprit for build failure Sample failure: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/8660 Original change's description: > Standardize feed android resources > > - Restructure to match chrome/browser/java/res > - Replace strings with references to existing .grd strings > - I kept Piet resources separate, since piet may eventually be moved into > a different library. > - Move feed/library sources into chrome_java > > Strings changed: > snackbar_fetch_no_new_suggestions -> ntp_suggestions_fetch_no_new_suggestions > snackbar_fetch_failed -> ntp_suggestions_fetch_failed > snackbar_default_action -> undo > > It looks like chromium's strings are translated to more languages, so > this might provide better localization. Some of these strings are > translated differently between feed and zine. > > Bug: 1024945 > Change-Id: If9862a4965756e28ba812bf315556d6b8db09e62 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956275 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Peter Wen <wnwen@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Carlos Knippschild <carlosk@chromium.org> > Commit-Queue: Dan H <harringtond@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734575} TBR=wnwen@chromium.org,dtrainor@chromium.org,twellington@chromium.org,govind@chromium.org,megjablon@chromium.org,carlosk@chromium.org,harringtond@chromium.org Change-Id: I3c14db8a0c67bf5b784955df6241443489b5b8af No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1024945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015411Reviewed-by:
-
rbpotter authored
Autogenerate Polymer 3 versions of CrScrollableBehavior and its tests. This will be used by the chrome://settings page in future. Bug: 1042558 Change-Id: I13d0a675f2f11cd3ff31a6c9c57948a3e9ad386b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014146Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#734595}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=sczs@chromium.org Bug: 1042208 Change-Id: Ibd527aec0c2d739bb73ff4d4d6d65cc5e2452ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017323 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#734594}
-
Sebastien Lalancette authored
Change-Id: Icb43c0914edbae4d6920aefd3e0b36b6bf574429 Adding all bugs that pointed to these flaky tests. When fixing a flaky test, don't revert this change. Simple re-enable the stable test by removing the individual line from TestExpectations. Using chenwilliam as TBR as most of these tests are devtools related. TBR=chenwilliam@chromium.org Bug: 1043396 Bug: 1043381 Bug: 1043356 Bug: 1043354 Bug: 1043350 Bug: 1043310 Bug: 1043285 Bug: 1043398 Bug: 1043434 Bug: 1043449 Bug: 1043453 Bug: 1043454 Bug: 1043463 Bug: 1043488 Bug: 1043785 Bug: 1043792 Bug: 1043796 Bug: 1043893 Bug: 1043920 Bug: 1044350 Bug: 1044414 Bug: 1044415 Bug: 1044424 Bug: 1044425 Bug: 1044429 Bug: 1044430 Bug: 1044433 Bug: 1044454 Bug: 1044459 Bug: 1044505 Bug: 1044506 Bug: 1044516 Bug: 1044518 Bug: 1044519 Bug: 1044534 Bug: 1044538 Bug: 1044544 Bug: 1044545 Bug: 1044546 Bug: 1044561 Bug: 1044562 Bug: 1044563 Bug: 1044805 Bug: 1044822 Bug: 1044823 Bug: 1044825 Bug: 1044829 Bug: 1044830 Bug: 1043847 Bug: 1043901 Bug: 1044569 Bug: 1044535 Bug: 1044496 Bug: 1044418 Change-Id: Icb43c0914edbae4d6920aefd3e0b36b6bf574429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016857 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
-
Gabriel Charette authored
R=fdoray@chromium.org, robliao@chromium.org, skyostil@chromium.org Bug: None Change-Id: I4db3f25779387307f85d01cff2f9dd1d53b08051 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015180Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#734592}
-
Devlin Cronin authored
Instead of passing BucketMapper as a raw pointer and then taking ownership by wrapping it in a unique_ptr, pass it in as a unique_ptr directly. Bug: None Change-Id: I3357fe432651c9dcd7884d6f6d7e76040c70d806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015631Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#734591}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=sczs@chromium.org Bug: 1042208 Change-Id: I7d260c4e46fdfdcf445ee7a748250f41568c30a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017485 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
John Abd-El-Malek authored
This closely matches Android Download Manager's UI with the exception of skipping the "% downloaded" part since it seemed redundant with the progress bar. The embedder can disable the UI if they choose. The few UI strings need to be translated. The button strings can be reused from Chrome, but we need to figure out what the rest of the text should say and add translations if they're not shared. Bug: 1025603 Change-Id: I61ba3b821c417de13191a67a85487b61b5f9c86f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002980Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#734589}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=sczs@chromium.org Bug: 1042208 Change-Id: I5fe3c2717a2c4493756176dc5d2443ab87efd342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015253 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Sebastien Lalancette authored
This reverts commit 95d61b40. Reason for revert: This change introduced flakiness, as identified by Findit. Bug: 1045112 TBR=avi@chromium.org Original change's description: > Revert "Revert "Enable system perfetto producer on all posix builds."" > > This reverts commit 92ff17fd. > > Reason for revert: Keep SMB around forever. > > TBR=avi@chromium.org > > Change-Id: Ifc811f7aa420dc63a80dc62cb292c16e5fd40bb3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014930 > Reviewed-by: Stephen Nusko <nuskos@chromium.org> > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Commit-Queue: Stephen Nusko <nuskos@chromium.org> > Auto-Submit: Stephen Nusko <nuskos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734465} TBR=avi@chromium.org,eseckler@chromium.org,findit-for-me@appspot.gserviceaccount.com,nuskos@chromium.org Change-Id: I0110f5bdd18c1789c635bf13a4c483e9c39502dc No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015409Reviewed-by:
-
Chris Harrelson authored
In such cases, the chosen anchor may change arbitrarily. Bug: 924256 Change-Id: I3f304450c59bc3e27b93089469d6fbee68a166e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008617Reviewed-by:
Nick Burris <nburris@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#734586}
-
Will Cassella authored
Clangd generates error messages for any files that include 'third_party/blink/renderer/core/style/computed_style_constants.h' due to it using the `|` operator between two instances of `InternalGridAutoFlowAlgorithm` and `InternalGridAutoFlowDirection`. Super annoying, so this CL explicitly casts them to integers to fix that. Change-Id: I79cc9f263ebfb8bd8ee5902741e857dac77138d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015550Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#734585}
-
Takumi Fujimoto authored
Set the expiry date of all the Media Router metrics to be a year from now, so that we wouldn't be getting pinged throughout the year for expiries. We expect all the metrics to be relevant for some time -- none of the metrics are only for components that we're retiring, like the extension Cast MRP. Bug: 1037602 Change-Id: I3ca59f3eaa9924f0beb24f817715b0d6f31c9eef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012907Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#734584}
-
llin@chromium.org authored
Histogram recorded to understand user clicks with result type and duration between result fetch finish and user clicks: * QuickAnswers.Click (enum="QuickAnswersResultType") * QuickAnswers.Click.Duration - Aggregated duration across result types * QuickAnswers.Click.Duration.[result type] - Duration for each result type The result type is something like "UnitConversion". Bug: 1044413 Test: Manual Change-Id: I8fa8e9852400bf4945a576639724a3479488bdae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969744Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#734583}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b04d7c55bff1..e504fd6a5f25 git log b04d7c55bff1..e504fd6a5f25 --date=short --first-parent --format='%ad %ae %s' 2020-01-23 aerotwist@chromium.org [Global] Updates refs to SDK.consoleModel 2020-01-23 almuthanna@chromium.org Remove tests that access private attributes 2020-01-23 aerotwist@chromium.org [Global] Update refs to UI.inspectorView Created with: gclient setdep -r src/third_party/devtools-frontend/src@e504fd6a5f25 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8206933368b7411155750c9d3956f086fda20462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016336Reviewed-by:
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=sczs@chromium.org Bug: 1042208 Change-Id: Iaf4eb9527cdb075ddf9074e6efd7dfd7213cb9c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014979 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Ian Struiksma authored
A few other autofill tests that weren't explicitly called out in the initial bug have the same issue it seems, so filtering these out as well: AutofillRestrictUnownedFieldsTest AutofillCreditCardInteractiveTest AutofillInteractiveIsolationTest AutofillInteractiveTestWithHistogramTester Bug: 967588 Change-Id: I4bdace0563dbc80c492cf16bd7c6b370eb27c727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016341 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#734580}
-
Brian Sheedy authored
This reverts commit e3ada6ea. Reason for revert: Workaround does not fully work. Original change's description: > Switch CrOS expectation to retry > > Switches the expectation for > conformance/textures/misc/texture-size-limit.html from "Skip" to > "RetryOnFailure", as the issue the test was causing for subsequent tests > has been worked around. > > TBR=ynovikov@chromium.org > > Bug: 1043953 > Change-Id: Iff573b37d981c8777e8373ebd8fd025ee2beac3a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015982 > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734330} TBR=ynovikov@chromium.org,bsheedy@chromium.org Change-Id: I4e41b33af4b79527e729306ef699edbd83e08a9b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1043953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017089Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#734579}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d4101efae107..00bf4462314d Created with: gclient setdep -r src-internal@00bf4462314d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: If71a52b448f35f9b90e1fb6d6b7e9cd3b9e8dbdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016333Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734578}
-
