GitLab

Add APIs
- WebFrame::brandColor() to get the brand color.
- WebFrameClinet::didChangeBrandColor to notify the brand color change.

BUG=383941

Intent to implement and ship link
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/nzRY-h_-_ig

Review URL: https://codereview.chromium.org/329943004

git-svn-id: svn://svn.chromium.org/blink/trunk@176142 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=176121

BUG=383495
TBR=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/333973002

git-svn-id: svn://svn.chromium.org/blink/trunk@176139 bbb929c8-8fbe-4397-9dbb-9b2b20218538

squashing layer state. This is no longer necessary after crrev.com/311813005.

BUG=

Review URL: https://codereview.chromium.org/331563005

git-svn-id: svn://svn.chromium.org/blink/trunk@176138 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a speculative fix for the flakiness we are seeing on the
textPath-change-reference2.svg test[1]. The failure is not reproducable
locally but appears as if runTest() is never called. This patch
refactors the test to not depend on runTest().

In addition, the test ids have been refactored to be understandable.

[1] http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&showAllRuns=true&showExpectations=true&tests=svg%2Fcustom%2FtextPath-change-reference2.svg

BUG=384566
TBR=dpranke

Review URL: https://codereview.chromium.org/333063003

git-svn-id: svn://svn.chromium.org/blink/trunk@176137 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Cleaned up style of translatez-removed.html while updating it.

Review URL: https://codereview.chromium.org/324363003

git-svn-id: svn://svn.chromium.org/blink/trunk@176136 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We'd miss any output between the last poll and the end of
the process.

Also, print out the log lines so that you can see them when
looking at the local log.

BUG=382248

Review URL: https://codereview.chromium.org/327633003

git-svn-id: svn://svn.chromium.org/blink/trunk@176135 bbb929c8-8fbe-4397-9dbb-9b2b20218538

SystemParametersInfo will fail if we've disconnected win32k
via the sandbox on Win8+. So, just default to nicer font
settings for now, since we know the OS supports them.

BUG=365160

Review URL: https://codereview.chromium.org/331843004

git-svn-id: svn://svn.chromium.org/blink/trunk@176134 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intent-to-ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/Ae18uqxjzp8/C4K_J1xpnGwJ

BUG=140205

Review URL: https://codereview.chromium.org/330873002

git-svn-id: svn://svn.chromium.org/blink/trunk@176133 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- mark crypto/rsassa-pkcs1-v1_5-generate-key.html as flaky timeout
- mark svg/custom/textPath-change-reference2.svg as flaky failure
- mark inspector/console/console-viewport-selection.html as flaky (Fix FlakyTest entry)
- virtual/gpu/fast/canvas/canvas-draw-canvas-on-canvas-shadow.html is no longer failing

TBR=schenney@chromium.org

Review URL: https://codereview.chromium.org/331843006

git-svn-id: svn://svn.chromium.org/blink/trunk@176132 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The test now appears to time out periodically (i.e., it's not flaky).
Reverting.

Original description:
> Crash test case:
> 1. Open page with javascript
> 2. Add breakpoint
> 3. Stop on breakpoint
> 4. Use live edit and save script
> The test worked for Chromium revision until May 30.

TBR=kostyatinskiy@google.com
BUG=none

Review URL: https://codereview.chromium.org/331853007

git-svn-id: svn://svn.chromium.org/blink/trunk@176131 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Changes to the compositing path meant the toggle of an iframe to having
a self-painting layer wasn't getting updated.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/330283008

git-svn-id: svn://svn.chromium.org/blink/trunk@176130 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Break Android build, clearly it was a typo.

BUG=357163

Review URL: https://codereview.chromium.org/333943002

git-svn-id: svn://svn.chromium.org/blink/trunk@176129 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This makes RLC::applyUpdateLayerCompositingStateChickenEggHacks
issue a repaint when a RenderLayer gains or loses a CLM.

Review URL: https://codereview.chromium.org/336493004

git-svn-id: svn://svn.chromium.org/blink/trunk@176128 bbb929c8-8fbe-4397-9dbb-9b2b20218538

What this update type actually does is update the geometry of all the
composited layer mappings that have dirty geometry. Rather than naming the
value for its caller, we should name the value for its effect.

R=vollick@chromium.org

Review URL: https://codereview.chromium.org/334973002

git-svn-id: svn://svn.chromium.org/blink/trunk@176127 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Removing "using" declarations that import names in the C++ Standard library. (https://codereview.chromium.org/329183002/)

Reason for revert:
This patch is causing failures on the Chromium Linux Tsan v2 bot: http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Builder%20(TSan%20v2)

The problem is that std::abs(int) is found in <cstdlib> but we apparently only include <cmath> everywhere. So the compiler only knows about std::abs(float) and variants.

You can probably fix this by including <cstdlib> in the places where you use std::abs.

Original issue's description:
> Removing "using" declarations that import names in the C++ Standard library.
> 
> This is as per the the coding guidelines for blink, which disallows the
> use of "using" declarations of any kind to import names in the standard
> template library.
> 
> BUG=NONE
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176032

TBR=tkent@chromium.org,ch.dumez@samsung.com,sunil.ratnu@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=NONE

Review URL: https://codereview.chromium.org/330933002

git-svn-id: svn://svn.chromium.org/blink/trunk@176125 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=None

Review URL: https://codereview.chromium.org/338523004

git-svn-id: svn://svn.chromium.org/blink/trunk@176124 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add missing null check in PageSerializer::serializeCSSStyleSheet() for
importRule->styleSheet(). CSSImportRule::styleSheet() can return null but
the function it is being passed to expects a non-null pointer.

Also update PageSerializer::serializeCSSStyleSheet() to take its CSSStyleSheet
argument by reference, instead of pointer to make it obvious to the caller
that passing null is not OK.

R=morrita@chromium.org

Review URL: https://codereview.chromium.org/332573003

git-svn-id: svn://svn.chromium.org/blink/trunk@176123 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The legacy implementation of FETurbulence actually never generated
tile-able noise. The algorithmic problem was fixed in Skia
(https://codereview.chromium.org/332523006/), but Blink was also not
passing the tile size (filter primitive subregion) to the turbulence
shader. This change fixes the latter (small) problem.

BUG=383495
R=fmalita

Review URL: https://codereview.chromium.org/333783002

git-svn-id: svn://svn.chromium.org/blink/trunk@176121 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ASSERT_ENABLED doens't have more not double negatives.

Note the #ifndef ASSERT_DISABLED in DatabaseThread.cpp was always compiled out
because ASSERT_DISABLED was always defined to be either 0 or 1.

Review URL: https://codereview.chromium.org/331793004

git-svn-id: svn://svn.chromium.org/blink/trunk@176120 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This function is iterating the stacking tree. It needs to ensure that the
stacking tree is up-to-date.

TBR=esprehn@chromium.org

Review URL: https://codereview.chromium.org/331923002

git-svn-id: svn://svn.chromium.org/blink/trunk@176119 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Styles are un-applied when an import with the style is removed.
The style however should be re-applied when the import is inserted back to the tree.

BUG=381052
R=dglazkov@chromium.org
TEST=import-readd*

Review URL: https://codereview.chromium.org/331763002

git-svn-id: svn://svn.chromium.org/blink/trunk@176117 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Update SelectorQuery constructor to adopt CSSSelectorList object instead of
copying it. This CL adds a adopt(CSSSelectorList&) factory function to
SelectorQuery class to make this behavior obvious.

Copying a CSSSelectorList is relatively expensive and it should therefore be
avoided when possible.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/330713003

git-svn-id: svn://svn.chromium.org/blink/trunk@176116 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently WebSocketChannel has methods subprotocol and extensions.
But they can be available only after the connection is established and
they don't change once set. Futhermore, there is didConnect notification
in WebSocketChannelClient.
This CL removes subprotocol and extensions from WebSocketChannel and
add them as WebSocketChannelClient::didConnect parameters.

BUG=384238
R=tyoshino

Review URL: https://codereview.chromium.org/334873002

git-svn-id: svn://svn.chromium.org/blink/trunk@176115 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* TreeScopeEventContext
 Move to Oilpan heap.
* WindowEvnetContext
 Declare as STACK_ALLOCATED(), and remove Persistent<>s.
* EventPath
 Eliminate raw pointers.

BUG=

Review URL: https://codereview.chromium.org/336463002

git-svn-id: svn://svn.chromium.org/blink/trunk@176114 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Strongly keep track of the current target.

For tidiness, also trace the 'parent' back reference on the XHR progress
event throttling part object.

R=zerny@chromium.org,ager@chromium.org
BUG=340522

Review URL: https://codereview.chromium.org/330273002

git-svn-id: svn://svn.chromium.org/blink/trunk@176112 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Cause of a flaky ASAN use-after-poison in media/video-frame-accurate-seek.html

R=ager@chromium.org, haraken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/333813004

git-svn-id: svn://svn.chromium.org/blink/trunk@176111 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When conservatively tracing ListHashSets we can end up tracing the
ListHashSet itself where the ListHashSet backing has been marked
and is on the marking stack for later tracing. Therefore, the
asserts that the backing has already been fully traced if the
backing is marked when we trace the ListHashSet is invalid.

R=erik.corry@gmail.com, oilpan-reviews@chromium.org
BUG=375669

Review URL: https://codereview.chromium.org/336693007

git-svn-id: svn://svn.chromium.org/blink/trunk@176110 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since this field is always set to true before being used only in WebURLLoaderImpl, this CL removes it entirely.

BUG=376025

Review URL: https://codereview.chromium.org/316353004

git-svn-id: svn://svn.chromium.org/blink/trunk@176109 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=176090

BUG=382872
TBR=ed@opera.com

Review URL: https://codereview.chromium.org/333873002

git-svn-id: svn://svn.chromium.org/blink/trunk@176108 bbb929c8-8fbe-4397-9dbb-9b2b20218538

HTML spec update:
http://html5.org/tools/web-apps-tracker?from=8674&to=8675

BUG=332066

Review URL: https://codereview.chromium.org/329103003

git-svn-id: svn://svn.chromium.org/blink/trunk@176107 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In GraphicsContextState::copy we use placement-new to overwrite the current
object. We need to first call the object's destructor though to not leak any
memory.

BUG=383548

Review URL: https://codereview.chromium.org/335613002

git-svn-id: svn://svn.chromium.org/blink/trunk@176106 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Modules tests have been placed in top of LayoutTests. So, this cl moves navigatorcontentutils
to top of LayoutTests.

BUG=none

Review URL: https://codereview.chromium.org/335783003

git-svn-id: svn://svn.chromium.org/blink/trunk@176105 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=383749
TEST=none

Review URL: https://codereview.chromium.org/330763002

git-svn-id: svn://svn.chromium.org/blink/trunk@176103 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This fixes the flaky crash in screen_orientation/page-visibility.html

The willBeDestroyed callback of GeolocationController has not been called in either build since r175404.

In addition LocalFrame supplements receive an explicit callback when the LocalHost is torn down in order to perform coordinated cleanup. This callback can be removed again once LocalFrame is moved to the heap and it again dies together with its supplements.

R=ager@chromium.org, tkent@chromium.org
BUG=

Review URL: https://codereview.chromium.org/335573004

git-svn-id: svn://svn.chromium.org/blink/trunk@176102 bbb929c8-8fbe-4397-9dbb-9b2b20218538

1. Open page with javascript
2. Add breakpoint
3. Stop on breakpoint
4. Use live edit and save script
The test worked for Chromium revision until May 30.

Review URL: https://codereview.chromium.org/329533002

git-svn-id: svn://svn.chromium.org/blink/trunk@176101 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/336693006

git-svn-id: svn://svn.chromium.org/blink/trunk@176100 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://src.chromium.org/viewvc/blink?view=rev&revision=174436

r174436 was introduced to improve the performance, but
introduced some regressions for shadow styling.

Added a layout test based on the report in issue 383366
to prevent the same regression again.

BUG=383366, 372083
TEST=pass all layout tests.

Review URL: https://codereview.chromium.org/323423008

git-svn-id: svn://svn.chromium.org/blink/trunk@176099 bbb929c8-8fbe-4397-9dbb-9b2b20218538

wrap() is called only when we fail to get a wrapper from DOMDataStore. In other words, wrap() is called only when a wrapper is created. This is a slow path, so we don't need to inline the function.

This reduces the binary size of Linux Release from 135279744 byte to 135230832 byte (saving 50 KB).

Review URL: https://codereview.chromium.org/331593006

git-svn-id: svn://svn.chromium.org/blink/trunk@176098 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL removes binary size by 43 KB (Linux Release). I don't see any regression with this CL in Dromaeo.

Review URL: https://codereview.chromium.org/332973002

git-svn-id: svn://svn.chromium.org/blink/trunk@176097 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL moves off the contents of V8XXX::domTemplate from V8XXX.cpp to V8DOMConfiguration.cpp. By doing this, we can decrease the binary size by 60 KB.

Review URL: https://codereview.chromium.org/336653004

git-svn-id: svn://svn.chromium.org/blink/trunk@176096 bbb929c8-8fbe-4397-9dbb-9b2b20218538