- 19 Oct, 2020 40 commits
-
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/89042538376b..7156d3e3140b 2020-10-19 dsinclair@chromium.org [wgsl-reader] Add parsing of named structs. 2020-10-19 dsinclair@chromium.org Roll Tint dependencies If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: dsinclair@google.com Change-Id: I00a603b6f01a65c5bc522d8bec8b0d9c82b718b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485591Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818543}
-
Austin Eng authored
Dawn is not supported on Win7. The tests were inadvertently enabled in https://chromium-review.googlesource.com/c/chromium/src/+/2480584 which changed test set up. Now, the TestGPUServiceHolder is not created at all on unsupported platforms. Use it as a signal to skip the test. Tbr: cwallez@chromium.org Bug: 1139941 Change-Id: I68b4fcf733ca83978b544f7d065866760fc056db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485674Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#818542}
-
Wei Li authored
This CL renames set_callback() member functions in a few classes including Button, Link, Combobox, EditableCombobox, to SetCallback(). This prepares to make callbacks in these classes into properties, so they could be used for builder too. Bug: 938501 Change-Id: I46c3058dc324d2b4235120d493566d7c1fb2c9ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476974 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#818541}
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 88-4277.0-1602498827-benchmark-88.0.4294.0-r1 to 88-4280.20-1603100572-benchmark-88.0.4296.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I67eee7b21d8f9d10b00bbfd458831c297ec7d1a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485115Reviewed-by:
-
Alexander Surkov authored
Bug: 1133330 Change-Id: I187c8c14ad14a5f36b939556d41940e0acbd3374 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481349Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#818539}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bb82eeb03d64..ec6bccd90081 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC lanwei@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1139314 Tbr: lanwei@google.com Change-Id: Ied676f0cd838ed99c05c082ed8610061364c3c33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485613Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818538}
-
David Jacobo authored
This CL gets rid of the unused flag kAppRuntimePerormanceStatistics, this feature has been enabled by default for a while, there is no way to toggle this flag via chrome://flags anymore so it should be safe to remove. Bug: None Test: Build. Change-Id: I79e90d2eb45559e4910b25282819d562ad074cb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466867Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#818537}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7bce5fed..375e574d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib21b9b7fabd8a739bdb3484bd302651f7d821ba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485752Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818536}
-
Sigurdur Asgeirsson authored
R=asvitkine@chromium.org, chromium-metrics-reviews@google.com Bug: 1089602 Change-Id: I76015e47077e8ee14fdd8a915009cf21c10d08b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485294 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#818535}
-
Yue Zhang authored
To build the TabGridDialog show/hide animation, we create an animation card view that looks very similar to a GridTabSwitcher card view. However, when trying to clone the layout of the GridTabSwitcher card view, we missed out the padding setup for the favicon which leads to some visual misbehavior for the animation. This CL fixes this issue by making the padding of the favicon in animation card view same as that of GridTabSwitcher card view (https://source.chromium.org/chromium/chromium/src/+/master:chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGridViewBinder.java;l=142;drc=6fd9af2e6b5ed2f65a762090823ddf8c09e95ae4;bpv=1;bpt=0) Bug: 1136328 Change-Id: Ibf2ce5d8dbd3bc4dfa9505812b9795dae5fde602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460249 Auto-Submit: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#818534}
-
Elly Fong-Jones authored
This test has is flaky when run on devices that have a real wifi or cellular connection, because in that situation, the call to SimulateNetworkChange() can cause an arbitrary number of real calls to GetCurrentSignalStrengthWithThrottling(). This change de-flakes the test in that situation by: 1) Delaying constructing the HistogramTester, to avoid counting those calls, and 2) Advancing the fake time the test uses at the start of the test, so that the NetworkQualityEstimator under test is never in its timeout period when the test starts This change does not re-enable the test on Android yet, since it seems to be still flaky there for unclear reasons. Bug: 1133439,1130720 Change-Id: I152f43f9c66ccef29060c48201fb7b4e8868fafe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476812Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#817719} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485194 Cr-Commit-Position: refs/heads/master@{#818533}
-
Shengfa Lin authored
For some RTL page with 0 document.documentElement.scrollLeft and non 0 document.body.scrollLeft, we should not take the document.body.scrollLeft to calculate DevTools page.capturescreenshot depending on doctype. Instead, we can use window.pageXOffset and pageYOffset that should work with any doctype. Bug: chromedriver:3625 Change-Id: I38a06b854d26d6039c89b74d89509ef39a9bc18d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482048Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#818532}
-
Peng Huang authored
Bug: 1135727 Change-Id: I92ec9961066d4d27f12f4a5d9cd92e27d7e00e8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485633 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#818531}
-
Xing Liu authored
The top level reading list folder is not editable/movable. The reading list articles is editable since we need to support move and delete for them. Test is adjusted to ensure no overflow menu is shown for the reading list folder. Also this CL is needed for a following CL to adjust positioning logic. Bug: 1139070 Change-Id: Ia09626c4568fe1e90612256da53176a90fc19c5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481959 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#818530}
-
Xiaoqian Dai authored
Please refer to https://carbon.googleplex.com/cros-ux/pages/screen-capture/motion#647b61a3-343c-448d-8c9b-f289d357c615 for the spec (search for "Screen record countdown"). Not covered in this CL: - stop-recording shelf item animation Bug: 1126669 Change-Id: I747f7df5f51677ef263921f5f00aa56f540b023b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463646Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#818529}
-
Dave Tapuska authored
The RenderWidgetFullscreenPepper was removed but the IPC was left around. BUG=1134674 Change-Id: I19a7a16049ac50b852647abb0930b35e07472a2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485534Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#818528}
-
Adam Langley authored
Previously only the nonce from the BLE advert was fed into the HKDF to generate the handshake pre-shared key. With this change, the full plaintext of the advert is included. This might be useful if, say, the routing ID or other fields added to the advert in the future, have entropy. Since this is now used in the PSK, the explicit authentication of the EID can be dropped. BUG=1002262 Change-Id: I1bbaa7545de9787ccb8642a5ca1b24db20718d17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466675 Auto-Submit: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#818527}
-
Roberto Moura authored
Bug: 1137983 Change-Id: Id17b3fce32c49dc540bf6699de8dcb19753d93ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475879Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Auto-Submit: Roberto Moura <mouraroberto@google.com> Cr-Commit-Position: refs/heads/master@{#818526}
-
mark a. foltz authored
When the native Cast MRP was disabled, the FixProviderId() hack was mapping all Chromecast media sources to ProviderId::EXTENSION, which is not expected by RecordPresentationRequestUrlBySink. This patch records the histogram before invoking FixProviderId(). It also restores the unittest for RecordPresentationRequestUrlBySink, which was deleted in http://crrev.com/c/2405519 Bug: 1112866 Change-Id: Iff2ea815c18458d6dcccb00974524c0ad382d461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468788 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#818525}
-
Devlin Cronin authored
Now lint_test_expectations.py is happy. NOTRY=True TBR=lanwei@chromium.org Bug: None Change-Id: I8a943dcabf9cc4b69d940595fad1caa32e3e154d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485437Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#818524}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ica1f1c09a42b193577bcf1796ea660cf5eeb1c6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485171Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#818523}
-
ziyangch authored
Tthe item is removed in eureka-internal/466958 Bug: Internal b/169779668 Test: Locally build. Change-Id: I5e3dfd5f5a4c00cbf0f856d431d22dd4263b9719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469141Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Ziyang Cheng <ziyangch@chromium.org> Cr-Commit-Position: refs/heads/master@{#818522}
-
Owen Min authored
Add a new enum field PartialReportType for ChromeDesktopReportRequest and ChromeOsUserReportRequest. It's used to indicate that the report doesn't contain all information but only extension request. It's the same change as cl 337368623. Bug: 1137964 Change-Id: I15a0055437049df073476a9dd89198c503704e65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481243Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#818521}
-
Christian Biesinger authored
Now that the spec seems to have stabilized, remove .tentative from the testcase names. R=ikilpatrick@chromium.org, mstensho@chromium.org Bug: 1045668 Change-Id: I99f916c87ea51c617e86c079301163ae30327083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485571 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#818520}
-
Peng Huang authored
SkaOutputSurfaceImpl defers draw until SwapBuffers. However SKiaRenderer may issue other GPU tasks between Draw and SwapBuffers for example: ScheduleOveralys(), ScheduleOutputSurfaceAsOverlay(), etc. Those tasks will be executed before drawing task. It may causes problems. Fix the issue by en-queuing all GPU tasks, and then defer and execute them in order. Bug: 1139697 Change-Id: I3e29fe6f60efd3f393b2bcc3ac4d536a305838f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482882 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#818519}
-
Lan Wei authored
This reverts commit 0c9cf96c. Reason for revert: SigninToUserProfileSwitchTest.LoginAsNewUser fails on Linux ChromiumOS MSan Tests https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests Original change's description: > oobe a11y: Add a test to verify profile switch during user login. > > Profile switches between signin and user during the login. Accessibility > manager should correctly switch the profile. > > Also reeanbled OobeSpokenFeedbackTest on MSAN. It's already filtered out > by chromeos.msan.browser_tests.oobe_(positive|negative).filter files. > > Bug: 1108996 > Change-Id: Ic586f7172e26bd965c42a9a566005fd872a69697 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474696 > Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817861} TBR=dtseng@chromium.org,rsorokin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1108996 Change-Id: Id4858df82ccefccb59265feaee160ea783b62798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485773Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#818518}
-
Dylan Cutler authored
RestrictedCookieManager::SetCanonicalCookie(). This is part of a cleanup effort of cookie code to make CanonicalCookie's bare constructor private since it does no validation and its use should be discouraged. CanonicalCookie::FromStorage is a factory method meant for creating new CanonicalCookies from those which have already entered the user agent storage, so it is the appropriate method for this use case IIUC. Bug: 1102874 Change-Id: I6f25554bff6cffe9427564135116e60af4306c31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485292Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#818517}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/97cf11a427e8..954fbcfe8ee7 2020-10-19 ahassani@chromium.org auto_updater: Change the implementation of is_au_endtoendtest 2020-10-19 ahassani@chromium.org auto_updater_transfer: Deprecate fixing payload properties file 2020-10-16 cjmcdonald@chromium.org uprev_lib: Add function to uprev cros-workon package to specific version 2020-10-16 cjmcdonald@chromium.org portage_testables: Let test Packages define arbitrary variables 2020-10-16 cjmcdonald@chromium.org uprev_lib: Refactor UprevResult to contain list of modified files 2020-10-16 cjmcdonald@chromium.org service/packages.py: Move uprev_ebuild function to uprev_lib 2020-10-16 ahassani@chromium.org auto_updater: Remove LabTransfer If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I9182ee93628b95249470c4d5c1727258260ce38c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485431Reviewed-by:
-
Caitlin Fischer authored
Bug: 1126640, 1140075 Change-Id: I3deae9ec9a2c8d39b6eda2bc5affa286bae35418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485516 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#818515}
-
Cathy Li authored
Negative margins are generally discouraged. We use a TouchDelegate instead to increase the size of the touchable area surrounding the icon. We also add a padding-based animation to transition between the borderless "on" state and the bordered "off" state Bug: 1123996, 1135402, b/167409361 Change-Id: Ie51d4af5ed014d69d07981d486addd0a4643b76a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451399 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#818514}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I7a90ba53350d9f49a125c76bc3b03e5aad3ce8d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484265Reviewed-by:
-
chrome://usb-internalsdpapad authored
This is in preparation of migrating chrome://usb-internals to use JS modules. Moving the tests to their own file is necessary to allow the test file itself to become a JS module, so that it can be loaded with chrome://usb-internals/test_loader.html?module=usb_inernals_test.js in a follow up CL. Bug: 1139849 Change-Id: I3172dbe3c9138aa6956dc345b219a7798517fb43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484309Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#818512}
-
Devlin authored
This reverts commit c007dfe1. Reason for revert: RegisterProtocolHandlerAndServiceWorkerInterceptor.DoNotRegisterFetchListener is very flaky on mac (and possibly elsewhere). Sample failure: [ RUN ] RegisterProtocolHandlerAndServiceWorkerInterceptor.DoNotRegisterFetchListener [23479:30231:1019/055809.421386:WARNING:notification_platform_bridge_mac.mm(374)] AlertNotificationService: XPC connection invalidated. [23479:775:1019/055809.917320:ERROR:device_event_log_impl.cc(211)] [05:58:09.906] FIDO: touch_id_context.mm:127 Touch ID authenticator unavailable because keychain-access-group entitlement is missing or incorrect [23479:96771:1019/055810.044487:WARNING:embedded_test_server.cc(667)] Request not handled. Returning 404: /favicon.ico [23479:775:1019/055810.218450:INFO:CONSOLE(0)] "Failed to launch 'web+html:path' because the scheme does not have a registered handler.", source: (0) ../../content/public/test/browser_test_base.cc:702: Failure Failed RunLoop::Run() timed out. Stack trace: 0 browser_tests 0x0000000110d3e9c2 _ZN4base8internal7InvokerINS0_9BindStateIZNS_4test20ScopedRunLoopTimeoutC1ERKNS_8LocationENS_9TimeDeltaENS_17RepeatingCallbackIFNSt3__112basic_stringIcNSA_11char_traitsIcEENSA_9allocatorIcEEEEvEEEE3$_0JS5_SI_EEEFvvEE3RunEPNS0_13BindStateBaseE + 290 1 browser_tests 0x0000000110c5916f base::(anonymous namespace)::OnRunLoopTimeout(base::RunLoop*, base::OnceCallback<void ()>) + 31 2 browser_tests 0x0000000110c5a1a3 base::internal::Invoker<base::internal::BindState<void (*)(base::RunLoop*, base::OnceCallback<void ()>), base::internal::UnretainedWrapper<base::RunLoop>, base::RepeatingCallback<void ()> >, void ()>::RunOnce(base::internal::BindStateBase*) + 67 3 browser_tests 0x000000010cf23a83 void base::internal::CancelableCallbackImpl<base::OnceCallback<void ()> >::ForwardOnce<>() + 35 4 browser_tests 0x000000010cf23b34 base::internal::Invoker<base::internal::BindState<void (base::internal::CancelableCallbackImpl<base::OnceCallback<void ()> >::*)(), base::WeakPtr<base::internal::CancelableCallbackImpl<base::OnceCallback<void ()> > > >, void ()>::RunOnce(base::internal::BindStateBase*) + 148 5 browser_tests 0x0000000110c7a946 base::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 310 6 browser_tests 0x0000000110c8fb55 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::sequence_manager::LazyNow*) + 405 7 browser_tests 0x0000000110c8f858 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() + 168 8 browser_tests 0x0000000110ce29a1 ___ZN4base24MessagePumpCFRunLoopBase13RunWorkSourceEPv_block_invoke + 49 9 browser_tests 0x0000000110cdb662 base::mac::CallWithEHFrame(void () block_pointer) + 10 10 browser_tests 0x0000000110ce223f base::MessagePumpCFRunLoopBase::RunWorkSource(void*) + 63 11 CoreFoundation 0x00007fff38600884 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 Original change's description: > Make custom protocol handlers work with service workers' fetch event > > When a service worker intercepts a page that is later registered as a > handler for a custom scheme via navigator.registerProtocolHandler, and > if one clicks a link with this custom scheme, then the service worker > is only able to intercept the page after reload. This CL fixes that > bug by allowing the service worker to intercept the page after > registering the custom scheme. > > A new browser unit test is added to verify this fix. This also makes > the following manual WPT tests pass (*): > protocol-handler-fragment-manual.https.html > protocol-handler-path-manual.https.html > protocol-handler-query-manual.https.html > > (*) https://w3c-test.org/html/webappapis/system-state-and-capabilities/the-navigator-object/ > > Bug: 522370 > Change-Id: I95eda9025885838665e9735ac9f47a3d65d89aa8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379672 > Commit-Queue: Frédéric Wang <fwang@igalia.com> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818416} TBR=falken@chromium.org,fwang@igalia.com,dominickn@chromium.org Change-Id: I026705f0116f3e0d684c8b1d80847aec85ec36db No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 522370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485837Reviewed-by:
-
Jesse Doherty authored
Change-Id: I7afb93cd9c03195ff9de7f383e65e5ea69ff1c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472958Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#818510}
-
spdonghao authored
Bug: 1136599 Change-Id: If780a0d396724dd3551987534cfdacce27cc8f1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482202 Commit-Queue: Hao Dong <spdonghao@chromium.org> Reviewed-by:
-
Justin Cohen authored
Bug: 1139891 Change-Id: I004ba7508671f405ea414c74bc20a65a9ec08be2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484263 Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#818508}
-
Viktor Semeniuk authored
This change adds username input validation. If the new username is already used for the same website username input will be highlighted and Done button will be disabled. Bug: 1137475 Change-Id: I1fa661b99f4d0f14805b13d0b4cf6ca0e8a2f16c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463235 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#818507}
-
Peter Kasting authored
Bug: 772945 Change-Id: I225930af5f4d6c8974ca0c151281565c5e587539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485434 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#818506}
-
Hiroshige Hayashizaki authored
Reflecting https://github.com/whatwg/html/pull/3656 (i.e. the credentials mode of https://html.spec.whatwg.org/C/#default-classic-script-fetch-options was changed to same-origin). This CL affects credentials mode used in dynamic import() executed from: - setTimeout("import()") on Window Note: this CL changes the credentials mode used in this case to same-origin, but actually it should be plumbed from initiating scripts (crbug.com/1133238). - javascript: URL - Scripts in isolated worlds Bug: 1114988, 1133238 Change-Id: I87c7083bce99276e6de05745f79bf4e2a0ba6de6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409895 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#818505}
-
Robbie Gibson authored
It is unclear why the CHECK in MakeThreadSafe is getting hit, but this should prevent that. This case should be caught by the existing if (!optional_image) checks, but apparently is not. Bug: 1136759 Change-Id: Ia38f25df99c0f39fcdc002bb78ec447fdc4e58cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484701 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#818504}
-
