- 06 Oct, 2020 40 commits
-
-
mark a. foltz authored
It's possible for the extension ID to be unset on the EventPageRequestManager while requests are incoming for the event page. In that case, avoid calling into extensions::ProcessManager to wake the event page with an empty extension ID. Bug: 1105702 Change-Id: I9017c0c6af7697fb0ac3d82fcb4e49d261993884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446712Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#814331}
-
Daniele Castagna authored
UI resources are rastered in sRGB, if the screen has a different color space, a color conversion step will be added to the fragment shader. This CL creates UI resources directly in the color space used by the final compositing step, so that the conversion can be skipped. Bug: 1129243 Change-Id: Ia9659cbb993ebb16097079daf6c7e67aecf0525f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441932 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#814330}
-
Matt Wolenetz authored
Replaces remaining direct usage of the attached HTMLMediaElement from MediaSource and SourceBuffer, relying instead on the attachment to moderate that communication. Specifically, this change: * Adds attachment helpers to enable SourceBuffers to create their audio and video tracklist members, including a same-thread attachment implementation. Cross-thread attachment implementation of this is deferred until TrackListBase and TrackBase can be owned off the main thread (in a worker thread), and until they can function without themselves directly accessing an HTMLMediaElement. * Removes superfluous usage in SourceBuffer of `source_->MediaElement()` in DCHECKs; other DCHECKs already suffice. * Removes MediaSource::MediaElement() and `attached_element_`. Removes their superfluous implementation and usage from MediaSource. * Fixes outdated assumptions in various DCHECKs that all attachments use a tracer. Only same-thread attachments use a tracer. BUG=878133 Change-Id: I346b320804a0ffbf731788b7ea7c344588f660b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439677 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#814329}
-
Tom Anderson authored
This is in preparation for removing Xlib error functions. BUG=1066670 R=sky Change-Id: I495065cabcefff11dc63fb282dc0af1bdcf41342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443790Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#814328}
-
Mike Wasserman authored
A speculative fix for flakiness in the Accept test fixture. Await getScreens() and then await the permission status. That should run permission context logic before checks. Bug: 1134240 Test: No WindowPlacementPermissionContextTest flakes Change-Id: I21f1e4b2019112d79adf28d8609728fdbe5eaf4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446844 Auto-Submit: Michael Wasserman <msw@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#814327}
-
Sreerenj Balachandran authored
This is a workaround to match with iHD media driver that shifts the quantization values by 50 while encoding. https://github.com/intel/media-driver/blob/master/media_driver/linux/common/codec/ddi/media_ddi_encode_jpeg.cpp#L694 The patch ensures the shifted value in the middleware generated packed header. Linux media stack test cases claiming to have a significant psnr improvement in Y plane (41.27 to 48.31) with this quirk. BUG=None TEST=./jpeg_encode_accelerator_unittest Change-Id: Ie2316cce2b5c86fefeb3879872c881868687011b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446208 Commit-Queue: Sreerenj Balachandran <sreerenj.balachandran@intel.com> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#814326}
-
George Steel authored
This updates the name to reflect the fact that the function now returns multiple true values indicating which size axis (width/height) the transform depends on. This is a pure refactor follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/2422088 requested by vollick@. Change-Id: I2649186d9378bc34faa59f9866f6dcf049493a9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453590 Commit-Queue: George Steel <gtsteel@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#814325}
-
Leonid Baraz authored
Remove immediate Status returning, make fully asynchronous. Bug: None Change-Id: I6d8619e5a90641b645f6109a6a6e7db42e16aced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453489 Auto-Submit: Leonid Baraz <lbaraz@chromium.org> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#814324}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/10071897de1e..9a64fc651dfe 2020-10-06 wolfi@chromium.org [frame details] Make report field values copyable If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1093247 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie85418d79b0fa025cf693490bb19ea8e29288fa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453609Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814323}
-
Dominique Fauteux-Chapleau authored
TBR=alexmos@chromium.org Bug: 1135595, 1010119 Change-Id: I709eb629f6781529a523f52c6a414052804ccf4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453429Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#814322}
-
Siyu An authored
The issue is the offer data is only updated when relaunch (or when personal_data_manager::refresh() is invoked) and not updated when new offer reaches client. The reason is: The full sync flow should be: 1. Offer sync bridge receive the data and populates to autofill table if found difference. 2. Notify UI sequence (personal data manager) about the change. 3. Personal data manager sends query to autofill webdata service to get data from autofill table. 4. Personal data manager gets notified by OnWebDataServiceRequestDone and refreshes local cache. 5. Autofill Offer Manager being a personal data manager observer gets notified. 6. Autofill Offer manager updates eligible domain calling UpdateEligibleMerchantDomains. Previously I thought the OnWebDataServiceRequestDone would be automatically invoked when the sync is finished, so we miss step 2 and 3. Here in this CL fix it. Bug: 1112095 Change-Id: I38ac61f3d5608eec1c8ac92538e457e566b3f538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444454Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#814321}
-
dpapad authored
In this CL ignoring 'tap' listeners residing in CrOS only code, or code that is about to be removed soon. Bug: 812035 Change-Id: I31e32b29908c25675a430bcaa0c30d6b7d1f7ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446021 Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#814320}
-
Peter Varga authored
Make it static otherwise its memory address might change between IsAppContainerEnabled() calls and would break pointer-based identity lookup. R=forshaw@chromium.org Change-Id: I775dca403a317c32ced5bd998c152849ca0413a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449471Reviewed-by:
James Forshaw <forshaw@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#814319}
-
Aya ElAttar authored
- Changed MockClipboardDlpController to be created via unique_ptr instead of calling Init & Delete in every test. - This is to be consistent with FakeDlpController in ClipboardHistory browsertests. Change-Id: I46a38bababf6b003c8edee5cefbcaf39d29efe15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450320 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#814318}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: Ie0bee9e12430577ed050d6dd1d75468395c59d99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445551 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#814317}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: I3b18cbad0acec25f6662e1e142225b46aac99614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445871 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#814316}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: If292e7c9a584afabfa11ca4484f330ae767eaa72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443289Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#814315}
-
Kai Ninomiya authored
TBR: jdarpinian@chromium.org Bug: 1135372 Change-Id: I60e715580de1559e3102a5e40acbfbaf9a30a140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450846 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#814314}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3453f745f068..0faa4a3d2e56 2020-10-06 lexa.knyazev@gmail.com Add BlendIntegerTest.MRT 2020-10-06 liaoyuke@chromium.org Rename ui/ozone/ozone.gni to build/config/ozone.gni 2020-10-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from f15133788010 to 63cc22d645ba (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1129223 Tbr: timvp@google.com Change-Id: I90c37b302ce6536bda1f5de7cbfc8169abfad323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453010Reviewed-by:
-
Changwan Ryu authored
These were frequently used debugging messages when investigating magnifier and selection handle issues, so adding the code controlled by a hard-coded flag. Bug: 1134492 Change-Id: I801492d1a47089247237d459ae33acc53bd9eb41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453789Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#814312}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: I3fd2472d406d5feda55646c3a119014db8912b19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445615 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#814311}
-
Owen Min authored
Support PolicyService::onPolicyUpdate event in Java. Same as other functions, only Chrome policies are supported. Other changes: 1) Implement PolicyMap.equals() 2) Use ObserverList instead of Set to manage PolicyService's observers. Bug: 1127469 Change-Id: I40c6958e87c746aa40afec306ee632bba52183f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446639 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#814310}
-
Thomas Lukaszewicz authored
This is a reland of 635cbc1a Change: Added missing variable initialization. Original change's description: > Views: Add BoxLayoutView > > This CL adds class member getters and setters to the BoxLayout class > where needed for the BoxLayoutView properties. Adds a TODO to ensure > layout is invalidated when these members are set. > > Bug: None > Change-Id: I13d73c75ca93f9de391b46c7241682ee7ced9a89 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434561 > Reviewed-by: Wei Li <weili@chromium.org> > Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813351} Bug: None Change-Id: I850dfcc06c75bd49073e6aa0d0cc51471d5ebbb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451554Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#814309}
-
Lu Huang authored
design doc: https://docs.google.com/document/d/19dGklalQTRtRrG3PKrVbDRmYPLHGLnsGEwUaed7sAFQ/edit?usp=sharing design overview cl: https://chromium-review.googlesource.com/c/chromium/src/+/2393252 Chrome status: https://www.chromestatus.com/feature/5739732661174272 Bug: 1072058 Change-Id: I6ef280af95514e0ac1abfacdcf6b113ee7b7af57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444439 Commit-Queue: Lu Huang <luhua@microsoft.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#814308}
-
Sean Kau authored
ChromeOS printing team has enough data. It's pretty much always 1. Bug: 1089320 Change-Id: I9683a47aed3f183d401ffe56ec21a7bb965abbcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447229 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#814307}
-
Kyle Shimabukuro authored
Adds the ability to clear all notifications. The chrome precondition state reset in Tast does not clear notifications which is causing issues with the test ui.QuickSettingsMicGainSlider. We can call the function added here during the state reset to clean up notifications that other tests may have left behind. BUG=chromium:1131698 TEST=Manually created some notifications by taking screenshots and downloading files, and manually called the api to clear the notifications. Change-Id: I7e0995a0d99ebcf54ba7a59d986de19e848daeb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442648 Commit-Queue: Kyle Shimabukuro <kyleshima@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#814306}
-
Yuke Liao authored
ui/ozone/ozone.gni was moved to build/config/ozone.gni, however, it turns out that ozone.gni depends on ozone_extra.gni, so this CL moves ui/ozone/ozone_extra.gni to build/config/ozone_extra.gni in order to keep build/config self-contained. Bug: 1129223 Change-Id: I0b67cbd41d7b402dfd595204a3a599053c83ba77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451872 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#814305}
-
Sebastien Lalancette authored
Moving some of the logic that used to live in utils into a new handler class. This class will be used to receive asynchronous JavaScript responses in a subsequent CL, hence the requirement to use an instance rather than utility functions. Bug: 1099268 Change-Id: I6752d1532bc5e64d40f327b7506e298d136e78a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446816 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#814304}
-
Maksim Sisov authored
In case of Ozone, we support more types. Bug: 1134495 Change-Id: I9712931545c8b70a1a0357d5b119b8c9a7c08c4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443650Reviewed-by:
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metatada from OWNERS files for //styleguide. Bug: 1113033 Change-Id: Ia223073dc571c11b1bc55eeaba7e8a9d738de16d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451392Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Mugdha Lakhani authored
Add a BackgroundSync delegate to let components embedder customize the logic in components/background_sync. Use this delegate to customize UKM logging logic, and remove the dependency on UkmBackgroundService from BackgroundSyncControllerImpl, which will eventually be moved to components. background_sync_metrics* will be moved to components/ in a follow-up CL. Bug: 1087486 Change-Id: Ia6221f9db842ba8a2da90a1ef3fe721bc113b858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443089Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#814301}
-
Moe Ahmadi authored
- zero-prefix suggestions on the NTP (Omnibox and Realbox) have been launched in M84 and enabled by default in M86 (crrev.com/c/2175138) - zero-prefix suggestions on SERP are no longer pursued. Fixed: 1134782 Change-Id: Ie9a074dc1306371173d34f8200b55686df153751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446461 Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#814300}
-
George Steel authored
This is to prepare for using DependsOnBoxSize for invalidation of compositor animations, allowing width and height changes to be propagated separately. This is to enable acceleration of percent- containing transform. See design doc https://docs.google.com/document/d/1zgr5CHRMpvlqodn1e0eM9J3MjL2eEMfAHrHsZUK7gMM/ Bug: 389359 Change-Id: I2bf30bdd51b048bc6f1d330e4159c72c36a5f5ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422088Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#814299}
-
Xinghui Lu authored
Bug: 1130728 Change-Id: I9549b464abedb6e06b706a2923ccf613a99f02ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434884Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#814298}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //sql. Bug: 1113033 Change-Id: I7fa2ca83ea5d961bea8d257c4919b035f9e6fe6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451394 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
mark a. foltz authored
This adds an OWNERS file for this folder for consistency with other Android code that supports Cast features. Change-Id: I7da7aac04b56c493cf78be47afdfc2e47604682e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441528Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#814296}
-
Aaron Leventhal authored
When adding children, make sure we only add aria-owned children to the owning nodes. This avoids a common crash in chrome://bookmarks that has a confusing crash stack. In order to do this, when ComputeAccessibilityIsIgnored() is called, the relation cache must already be updated with the knowledge that the object is owned. Do not ever allow owned objects to ever have a "not included in tree" parent. Therefore, they can never be added as second line children via the recursion in InsertChild(). Also re-remove WalkAllDescendants(), which was it was recently re-added as a band-aid for the chrome://bookmarks crashes. Without this change, removing WalkAllDescendants() causes assertions in AXTreeSerializer, when aria-owns points to an unincluded node, that the same object is being added twice. Finally, add better logging and DCHECKs that will help diagnose issues more quickly. TBR=dmazzoni@chromium.org Bug: 1100968, 1131848 Change-Id: I79d785bc725989a53274a14f6bded5dbdaa7e21d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451507Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#814295}
-
Nohemi Fernandez authored
The current approach does not allow a developer to change the icon image when another image has already been set. Bug: 1125631 Change-Id: I2665b3ffdd66f666b9fe86821ba4fa04d6708ed0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445417 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
-
John Lee authored
This CL adds a new component <cr-menu-selector> that takes in a set of elements that have a role of 'menuitem' and manages focus between the items as the user uses arrow, Home, and End keys. The first menuitem is the only menuitem that is focusable using the Tab key, allowing users to easily skip over the menu to the main content area of a page. This follows the accessibility guidelines set for navigation drawers. This element will also be used on the History page's menu. Bug: 1110405 Change-Id: I1d644959412d5c19f324d75336bd0e9a08ce7ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436706Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#814293}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: I64955cac925925260dd5876ce7a46fda82ba24e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445472 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#814292}
-
