- 01 Oct, 2018 40 commits
-
-
Karan Bhatia authored
BUG=696822 Change-Id: I77b3ed6aba80cf1c41e27148b560fbe7094fb19e Reviewed-on: https://chromium-review.googlesource.com/1222158Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#595618}
-
Nico Weber authored
The tests seem to pass now. Bug: 630357,845389 Change-Id: I7e74c1a41f578dc70866d533742e36bafb787f63 Reviewed-on: https://chromium-review.googlesource.com/1251327Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#595617}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/3448987ab20a..2beb5c9f91e7 $ git log 3448987ab..2beb5c9f9 --date=short --no-merges --format='%ad %ae %s' 2018-09-28 jingning Remove deprecated get_arf_buffer_indices() 2018-09-28 jingning Remove deprecated arf_update_index from GF_GROUP 2018-09-27 paulwilkins Fix minor bug in calculation of max arf group length. 2018-09-28 paulwilkins Adjustment of GOP intra factor for multi-layer. 2018-09-25 huisu Add ml_var_partition experiment 2018-09-28 paulwilkins Revert "Merge "Adapt GOP size threshold to the allowed layer depth"" 2018-09-27 jingning Add MID_OVERLAY_UPDATE frame type 2018-09-27 jingning Refactor gf_overlay frame type update 2018-09-27 huisu Fix a loophole in nonrd_pick_partition() 2018-09-27 jingning Remove deprecated variables from GF_GROUP structure 2018-09-27 jingning Remove unused for-loop in multi-layer arf bit allocation 2018-09-26 jingning Adapt GOP size threshold to the allowed layer depth 2018-09-26 angiebird Add vpx_clear_system_state to new mv search func 2018-09-26 angiebird Change mv color to red 2018-09-26 johann.koenig add cfi sanitizer 2018-09-26 johann.koenig CONFIG_WEBM_IO: include webmids.h 2018-09-25 angiebird Call vp9_full_pixel_diamond_new in tpl mv search 2018-09-25 angiebird Add vp9_full_pixel_diamond_new 2018-09-24 angiebird Add vp9_refining_search_sad_new 2018-09-24 angiebird Add vp9_diamond_search_sad_new (...) Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: I0dc3ae4855a3faaa94086bfa9e4a5cb022f09689 Reviewed-on: https://chromium-review.googlesource.com/1254753Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#595616}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/2b4d11c0f133..ce342184e625 git log 2b4d11c0f133..ce342184e625 --date=short --no-merges --format='%ad %ae %s' 2018-10-01 thestig@chromium.org Update some third_party/base headers. 2018-10-01 thestig@chromium.org Make header guards consistent in third_party/base/*.h. 2018-10-01 thestig@chromium.org Fix #include ordering / formatting. 2018-10-01 thestig@chromium.org Initialize more CXFA_Node members in the header. 2018-10-01 thestig@chromium.org Remove some "exceptions" from reedsolomon code. 2018-10-01 thestig@chromium.org Use size_t and FX_ArraySize() for some arrays. 2018-10-01 rharrison@chromium.org Add XFA JPG pixel test 2018-10-01 rharrison@chromium.org Add XFA GIF pixel test Created with: gclient setdep -r src/third_party/pdfium@ce342184e625 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: If39e1827d0a99dc2b2e7d1701ecbfa4e617f7417 Reviewed-on: https://chromium-review.googlesource.com/1255302Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595615}
-
Andrew Grieve authored
Regressed in recent commit: d0567449 Bug: 890360 Change-Id: I1589295c40eff98a6255d9dd01ad9c2a66817dc4 Reviewed-on: https://chromium-review.googlesource.com/1255888Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#595614}
-
Kevin Strohbehn authored
Bug: 885232 Change-Id: I08943ff79a7dfae036acb8842bc67e8fe90c2999 Reviewed-on: https://chromium-review.googlesource.com/1253073Reviewed-by:
Weidong Guo <weidongg@chromium.org> Commit-Queue: Kevin Strohbehn <ginko@google.com> Cr-Commit-Position: refs/heads/master@{#595613}
-
Joone Hur authored
Here is the call stack when the crash happens: (chrome - scoped_refptr.h: 191) libgtkui::SelectFileDialogImplGTK::OnFileChooserDestroyThunk(_GtkWidget*, void*) (chrome - select_file_dialog_impl_gtk.cc: 98) libgtkui::SelectFileDialogImplGTK::~SelectFileDialogImplGTK() (chrome - select_file_dialog_impl_gtk.cc: 89) <name omitted> (chrome - ref_counted.h: 414) DownloadFilePicker::~DownloadFilePicker() (chrome - select_file_dialog_impl_gtk.cc: 284) libgtkui::SelectFileDialogImplGTK::FileSelected(_GtkWidget*, base::FilePath const&) A dialog is destroyed in FileSelected(), but it seems that the same dialog is destroyed again in OnFileChooserDestroy. BUG=880073 Change-Id: I1f47bbc26b4af81b4c73d7cf03ac684edc4f97fd Reviewed-on: https://chromium-review.googlesource.com/1256020 Commit-Queue: Joone Hur <joone.hur@intel.com> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#595612}
-
Kevin Marshall authored
This resolves the connection error log spam seen in suites like content_unittests. Change-Id: I26d1959b9be67247af10c454b21159755b68eb72 Reviewed-on: https://chromium-review.googlesource.com/1256019 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#595611}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5ddbdbf70c50..624fbdcf55b0 git log 5ddbdbf70c50..624fbdcf55b0 --date=short --no-merges --format='%ad %ae %s' 2018-10-01 oetuaho@nvidia.com Refactor CompileProgram utility 2018-10-01 thakis@chromium.org Remove an exit-time destructor from a frequently-included header. 2018-10-01 geofflang@chromium.org Vulkan: Implement robustness extensions. 2018-10-01 jmadill@chromium.org Vulkan: Record blit commands inside blit methods. 2018-10-01 geofflang@chromium.org Reland "D3D11: Resolve multisampled EGL surfaces at eglSwapBuffers" 2018-10-01 jmadill@chromium.org Vulkan: Use copyImageDataToBuffer in Texture mipmap gen. 2018-10-01 syoussefi@google.com Vulkan: Add support for VkPipelineCache Created with: gclient setdep -r src/third_party/angle@624fbdcf55b0 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:887403 TBR=cwallez@chromium.org Change-Id: If26142dca4cbbae4598e48f346fbc5b3d0b4af1f Reviewed-on: https://chromium-review.googlesource.com/1255508Reviewed-by:
-
Xiaohan Wang authored
This makes it easy to organize the doc and find files. This CL does minimal reordering of the files listed in the current README, with some rough grouping. It is expected that we'll improve the structure of the file gradually over time. Bug: 818048 Change-Id: I8f19fa388d6cd599fc32824b91d184bd49b2767a Reviewed-on: https://chromium-review.googlesource.com/1253207Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#595609}
-
Jinsuk Kim authored
Lazy init (https://crrev.com/578223) doesn't work for TextSuggestionHost whose UI gets triggered by native from Blink. It expects the related components (java TextSuggestionHost and blink::mojom::TextSuggestionHost) to be ready before it makes the first call. This CL initializes the objects in eager fashion. Bug: 884214 Change-Id: I1ef96d7d617a1fb745f2652a7e1f94e5d9406a24 Reviewed-on: https://chromium-review.googlesource.com/1253312Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#595608}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 49993008. With Chromium commits locally applied on WPT: 92605c16 "[Unified Plan] Remote MediaStreamTracks should be muted by default." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25734 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: msisov@igalia.com: external/wpt/webvtt timvolodine@chromium.org, reillyg@chromium.org: external/wpt/orientation-event NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I21f8093510ab47bb9505f3e3058b47ff94fb63ab Reviewed-on: https://chromium-review.googlesource.com/1255153 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#595607}
-
Andrey Kosyakov authored
The default for 3rd-party cookies in content shell has been changes from "deny" to "allow" by https://chromium-review.googlesource.com/1196547 However, we still reset it to "deny" when resetting the TestRunner between tests, which causes inconsistent behavior for tests that depend on default value. Bug: 890000 Change-Id: If85535e617eb884e5fdd64c928d558f9fa84bb29 Reviewed-on: https://chromium-review.googlesource.com/1250165Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#595606}
-
Justin DeWitt authored
* If no catalog is present, requests one from the network and displays default images. When request finishes, updates the category images. * Updates category images right away if not requesting from the network. * Fixes the query in GetCatalogTask so that if there is no "current" catalog, it will use the "downloading" catalog instead. Bug: 867488 Change-Id: Ic307f77a4b3ae2ededa711f619059b1aed562012 Reviewed-on: https://chromium-review.googlesource.com/1252908 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#595605}
-
Scott Violet authored
The client area insets of a top-level need to be propagated to the ClientSurfaceEmbedder. BUG=869501 TEST=covered by tests Change-Id: Id5aca98e46d596e8e43c7ea71150f59a0db638da Reviewed-on: https://chromium-review.googlesource.com/1252145 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#595604}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d46dfc57..6d7c52f8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I27de39197801350ac95f29ef306811de43cfe3b4 Reviewed-on: https://chromium-review.googlesource.com/1254381Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595603}
-
Pedro Amaral authored
This reverts commit a55d47e1. Reason for revert: The breakage that caused this revert was only present on the M70 branch and never happened on master. It was due to this CL referring to a drawable that was renamed in M71. This CL uses the new name so it broke the M70 build when it was cherry picked. Original change's description: > Revert "Horizontal tab switcher use tab toggle" > > This reverts commit 61bed816. > > Reason for revert: Broke [Build Non-Channel Targets] build step > > Original change's description: > > Horizontal tab switcher use tab toggle > > > > Replace the HTS Incognito Button with a toggle. > > > > Bug: 851166 > > Change-Id: I5c431abb508930ee1a9a24792f2299ea08d944cf > > Reviewed-on: https://chromium-review.googlesource.com/1246453 > > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> > > Commit-Queue: Pedro Amaral <amaralp@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#594780} > > TBR=yusufo@chromium.org,amaralp@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 851166 > Bug: 890673 > Change-Id: I3631d88c29bd950beea9280e97e0ff50ed332bc8 > Reviewed-on: https://chromium-review.googlesource.com/1253741 > Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org> > Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595411} TBR=yusufo@chromium.org,tobiasjs@chromium.org,amaralp@chromium.org Change-Id: Iaee562d9f3c393480028749e265550b84cad4ae1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 851166, 890673 Reviewed-on: https://chromium-review.googlesource.com/1256104Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#595602}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ac93684421fa..69f64b270397 git log ac93684421fa..69f64b270397 --date=short --no-merges --format='%ad %ae %s' 2018-10-01 oysteine@google.com Allow bindId for separate begin/end slices as well 2018-10-01 simonhatch@chromium.org Dashboard - Create histograms per bot for alert statistics 2018-10-01 cbruni@chromium.org [pinpoint] Redirect to raw results.html on job completion 2018-10-01 pasko@chromium.org Avoid running Android background jobs Created with: gclient setdep -r src/third_party/catapult@69f64b270397 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:890025,chromium:876233,chromium:890424,chromium:881384 TBR=sullivan@chromium.org Change-Id: I3fa5e360f1c7c98152f5078c58d9d41e34b66ebc Reviewed-on: https://chromium-review.googlesource.com/1254685Reviewed-by:
-
Tom Anderson authored
BUG=737995,881371 TBR=pkasting Change-Id: Ifd8b41626747ae8e52fd7db67e86af5d87b9994f Reviewed-on: https://chromium-review.googlesource.com/1255594Reviewed-by:
-
Vladimir Levin authored
This patch adds code to skip subtree walk if it was forced for a reason that is blocked for isolation. R=chrishtr@chromium.org, pdr@chromium.org, wangxianzhu@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I80b0010bbda722d03a07e4293d13e494b5da53e1 Reviewed-on: https://chromium-review.googlesource.com/1252941 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#595599}
-
Ryan Sturm authored
When a preview is client blacklisted, this should be reported to the Data reduction proxy pageload metrics pingback. However, the boolean for this is not properly copied before content moves the navigation data cross thread. This is resulting in never reporting the client blacklist blocking the optimization. Another bool (offline_preview_used) is also not copied, but it is only used on the IO thread currently, so there is not functional bug. Bug: 890983 Change-Id: I6fafaa91d875b590ee5c5c725bc6f487e63395c4 Reviewed-on: https://chromium-review.googlesource.com/1255889Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#595598}
-
Achuith Bhandarkar authored
* Get rid of #define OS_CHROMEOS * Stop using GetActiveUserProfile. * Separators between functions * Remove ctors and DISALLOW_COPY_AND_ASSIGN for conciseness. * Consistency in declarations. * Consistency in use of DVLOG * Match order of functions in header and cc. * Remove kOnlyAvailableOnChromeOSError BUG=None TEST=browser tests, vm_sanity Change-Id: I0b6900886642479a84c70387c69042c51b9ad5ea Reviewed-on: https://chromium-review.googlesource.com/1251261Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#595597}
-
Sahel Sharify authored
This cl converts middleClickAutoscroll.js and the middle click autoscroll layout tests that are using it to use gpu benchmarking. Bug: 875945 Change-Id: Ic5acb4367dd406de3e5897063bfe6b1b44e7daa6 Reviewed-on: https://chromium-review.googlesource.com/1251901Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#595596}
-
Brian White authored
Try to narrow down where the ranges are getting corrupted by verifying the internal checksum in places. Bug: 836238 Change-Id: I05493e86d74c820c6dfe2dbe30759c04cdfb3f28 Reviewed-on: https://chromium-review.googlesource.com/1255322Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#595595}
-
Min Qin authored
SystemNetworkContextManager already takes a PrefService in its ctor. As a memeber variable of SystemNetworkContextManager, ProxyConfigMonitor should do the same. This CL also fixes an issue that ProxyServiceFactory is using BrowserThread::UI to create the system proxy service. It is possible that BrowserThread is not created if ServiceManager is started alone. Switching to use base::ThreadTaskRunnerHandle::Get() instead. BUG=866028 Change-Id: I6a33310e94a6050ca0bd22bdd716660aea790b58 Reviewed-on: https://chromium-review.googlesource.com/1255144Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#595594}
-
David Trainor authored
Two files were redundantly listed in base/BUILD.gn which caused a compile error. NOTRY=true No-trying because this is blocking junit test compilation and has (should have) no effect on the mac builder. Change-Id: I98da40cfa877a3665a03cf4f879dd228574392ec Reviewed-on: https://chromium-review.googlesource.com/1255049 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#595593}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8dfa5c869e08..1b448050d611 Created with: gclient setdep -r src-internal@1b448050d611 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9f0de92dc70411b48d98df5b7345b27d7c25ceef Reviewed-on: https://chromium-review.googlesource.com/1255562Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595592}
-
Shimi Zhang authored
There is no need to keep this function since printing/units.h has such conversion already. R=thestig Bug: None Change-Id: Ib6164b40d5f8a6b812b7ebc2f81942403eb3926a Reviewed-on: https://chromium-review.googlesource.com/1255604Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#595591}
-
Tsuyoshi Horo authored
Bug: 890199 Change-Id: Idd9d01735d1a922692de63fc7b99e1154b13e7e9 Reviewed-on: https://chromium-review.googlesource.com/1250764Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#595590}
-
Joshua Bell authored
As a follow on to https://crrev.com/c/1248328, wrap conversions between base::Time and the particular format used for persistence in the quota database (int64_t) in methods, instead of inlining the conversion steps at every point. Bug: 889242 Change-Id: I8d5b7b6a6e7bf9ccf507cd8c3ad750dae9e30206 Reviewed-on: https://chromium-review.googlesource.com/1254744 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#595589}
-
Weidong Guo authored
Changes: Make app list respect work area instead of display bounds. Bug: 889334 Change-Id: I861b2d652ce432dbccb16f36b90aae6cc90e328b Reviewed-on: https://chromium-review.googlesource.com/1255583 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#595588}
-
Eric Stevenson authored
This CL introduces the badging api. The badging API will eventually allow developers to set and clear badges for installed PWAs. Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Fw764MVF5nI Explainer: https://github.com/WICG/badging/blob/master/explainer.md Bug: 719176 Change-Id: I68aa5a9310469bd3a38b1029f2141be335121b06 Reviewed-on: https://chromium-review.googlesource.com/1166603Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#595587}
-
Raymond Toy authored
It is valid to set the buffer attribute more than once. As resolved in https://github.com/WebAudio/web-audio-api/issues/1762, setting the buffer more than once is allowed. This is a revert (mostly) of https://chromium-review.googlesource.com/c/chromium/src/+/1077713 Bug: 882211 Test: the-convolvernode-interface/convolver-setBuffer-already-has-value.html Change-Id: Ie7f170883e6a6b2bfa7f14d89c74b72eebde3dac Reviewed-on: https://chromium-review.googlesource.com/1249275Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#595586}
-
gogerald authored
src/chrome/test:browser_tests will be added later on Desktop since it is not available on Android (crbug.com/611756). Bug: 806868 Change-Id: I1f0896057d3a3608ff72e1205c4c4f372ea56c71 Reviewed-on: https://chromium-review.googlesource.com/1239440Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#595585}
-
Kristi Park authored
Before: https://screenshot.googleplex.com/VTEZEnvP8Ac.png After: https://screenshot.googleplex.com/QpJWqkymMe8.png Bug: 879502 Change-Id: I4a37757b19297c3507b55d8506446dd1f58ecbc5 Reviewed-on: https://chromium-review.googlesource.com/1252854 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#595584}
-
Yue Cen authored
Bug: 881083 Change-Id: Ia8aa5753b1170983b0081c7de85c4b197743f7a6 Reviewed-on: https://chromium-review.googlesource.com/1253066 Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#595583}
-
David Roger authored
This CL clears all Chrome authentication tokens when the user clears their cookie, except in one edge case: when the user is clearing both their cookie and their synced data at the same time, the token for the Sync account is not deleted, because it would prevent the data to be correctly deleted on the Sync server. The UI of the "Clear Browsing Data" dialog will be updated in a followup CL, to surface this behavior change to the user. Bug: 889137 Change-Id: I495a57b52a39832c30474973b4619de646a79bc3 Reviewed-on: https://chromium-review.googlesource.com/1250966Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#595582}
-
Mihai Sardarescu authored
When DICE is disabled or DICE fix auth error is enabled, the token service should only manage the token of the primary account. This means that token service should clear all tokens from DB in these modes to avoid leaving tokens on disk when the user changes from DICE disabled to DICE enabled modes. The change in crypauth service is needed as to avoid an assumption that pref changes can only happen after primary account was set. This is not the case in browser tests. Bug: 890758 Change-Id: I63a8ae3ac0f00271c0031cd090d1cf9dad50905c Reviewed-on: https://chromium-review.googlesource.com/1254210Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#595581}
-
Robert Ogden authored
If the user has IPH_DemoMode set in their about:flags, the previews IPH may appear even if the page is not a preview. This CL puts in a small check to ensure this can't happen. Bug: 886949 Change-Id: Ib0af8adcdefef0dba7dd8441d1a0d0189ea2581b Reviewed-on: https://chromium-review.googlesource.com/1255422Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#595580}
-
Tommy Steimel authored
This CL updates the styling for the volume slider for larger videos. Bug: 890092 Change-Id: I1b410b7318f10247457c46cadbbb081801e19acf Reviewed-on: https://chromium-review.googlesource.com/1250206Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#595579}
-
