GitLab

On Japanese locale Android which has Motoya Maruberi
as the system default font (up until 5.1), the font
fallback path mistakenly picked up ".notdef" glyph
for   (U+00A0).

This happened because in the fallback path it still
ended up in looking up non-existent glyph in the same
font file and fell back to the "missingGlyphData".

This is because Blink looks up the glyph in
normalized codepoint (for U+00A0, normalized to U+0020)
but still it tries to look up the original codepoint.

This bug was exposed by the following change, to make
not to normalize   to space before looking up glyph.
https://codereview.chromium.org/705163003

BUG=454108

Review URL: https://codereview.chromium.org/1317833003

git-svn-id: svn://svn.chromium.org/blink/trunk@201348 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/1323433002

git-svn-id: svn://svn.chromium.org/blink/trunk@201347 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This was made non-refcounted class in https://crrev.com/1190133002,
but looks like this could cause crashes in some corner cases.

To be more specific:
FrameLoaderClientImpl::dispatchDidFinishDocumentLoad() calls
WebFrameClient callback first and then WebView callback next, but
if the loader is deleted in the first callback an attempt to call the
second callback on a member variable would crash.

We could probably avoid this crash without making the loader class
ref-counted again, but for now I would like to fix the crash by simply
reverting some of the changes that're causing the crash.

BUG=524694

Review URL: https://codereview.chromium.org/1322523002

git-svn-id: svn://svn.chromium.org/blink/trunk@201346 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201327

BUG=67587
TBR=xlai@chromium.org

Review URL: https://codereview.chromium.org/1313183005 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201345 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201329

BUG=515771
TBR=robhogan@gmail.com

Review URL: https://codereview.chromium.org/1322583003 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201344 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=525824
TBR=xlai@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1318903006 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201343 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=525702

Review URL: https://codereview.chromium.org/1307223003

git-svn-id: svn://svn.chromium.org/blink/trunk@201342 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=503399

Review URL: https://codereview.chromium.org/1317863004

git-svn-id: svn://svn.chromium.org/blink/trunk@201341 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since everyone has shipped this unprefixed for a long time now,
don't bother falling back to the prefixed versions in tests.

R=dgrogan@chromium.org

Review URL: https://codereview.chromium.org/1317593005

git-svn-id: svn://svn.chromium.org/blink/trunk@201340 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These suites runs about 1000 layout tests as smoking tests for
spv2.

BUG=524134

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201328

R=chrishtr@chromium.org, joelo@chromium.org

Review URL: https://codereview.chromium.org/1307293002 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201339 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Having ScriptedIdleTaskController and its auxillary object keep a reference
to a document's DocumentLoadTiming part object is unnecessary as the deadlines
do not have to be translated wrt a Document's baseline reference time.

R=sami, rmcilroy
BUG=

Review URL: https://codereview.chromium.org/1316323002

git-svn-id: svn://svn.chromium.org/blink/trunk@201338 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reland of place pinch scrollbars with regular scrollbars. (patchset #1 id:1 of https://codereview.chromium.org/1318603005/ )

Reason for revert:
After discussion with samuong@, the original patch should be OK to reland as is and https://codereview.chromium.org/1317153002 is an appropriate fix for the crasher.

Original issue's description:
> Revert of Replace pinch scrollbars with regular scrollbars. (patchset #10 id:180001 of https://codereview.chromium.org/1308053003/ )
> 
> Reason for revert:
> Introduced ChromeDriver devtools mobile emulation crash https://code.google.com/p/chromedriver/issues/detail?id=1205
> 
> Original issue's description:
> > Replace pinch scrollbars with regular scrollbars.
> > 
> > This patch makes the visual-viewport-managed scrollbars exclusive to
> > Android and improves normal scrollbars to be usable during pinch as follows:
> > 
> > 1. Attach the scrollbar layers to the visual viewport, so they're always
> >    onscreen as you zoom in (as already shipped on Mac).
> > 2. Set the container layer to the inner clip layer, so that the size and
> >    position of the thumb reflects the sum of the two viewports,
> >    instead of just the layout viewport.
> > 
> > Note that result of these changes is visually indistiguishable at
> > minimum page scale.  It only improves the behavior when zoomed in.
> > 
> > BUG=523056
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201285
> 
> TBR=rbyers@chromium.org,skobes@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=523056
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201333

TBR=rbyers@chromium.org,skobes@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=523056

Review URL: https://codereview.chromium.org/1305223004

git-svn-id: svn://svn.chromium.org/blink/trunk@201337 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts commit e43a87f1b1012746a95937f546f723f7737a46b1.

BUG=525772
TBR=wangxianzhu@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1308953005 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201336 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=295792

Review URL: https://codereview.chromium.org/1318853003

git-svn-id: svn://svn.chromium.org/blink/trunk@201335 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201287

BUG=524547
TBR=chrishtr@chromium.org

Review URL: https://codereview.chromium.org/1317143003 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201334 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Replace pinch scrollbars with regular scrollbars. (patchset #10 id:180001 of https://codereview.chromium.org/1308053003/ )

Reason for revert:
Introduced ChromeDriver devtools mobile emulation crash https://code.google.com/p/chromedriver/issues/detail?id=1205

Original issue's description:
> Replace pinch scrollbars with regular scrollbars.
> 
> This patch makes the visual-viewport-managed scrollbars exclusive to
> Android and improves normal scrollbars to be usable during pinch as follows:
> 
> 1. Attach the scrollbar layers to the visual viewport, so they're always
>    onscreen as you zoom in (as already shipped on Mac).
> 2. Set the container layer to the inner clip layer, so that the size and
>    position of the thumb reflects the sum of the two viewports,
>    instead of just the layout viewport.
> 
> Note that result of these changes is visually indistiguishable at
> minimum page scale.  It only improves the behavior when zoomed in.
> 
> BUG=523056
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201285

TBR=rbyers@chromium.org,skobes@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=523056

Review URL: https://codereview.chromium.org/1318603005

git-svn-id: svn://svn.chromium.org/blink/trunk@201333 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=525377

Review URL: https://codereview.chromium.org/1314393003

git-svn-id: svn://svn.chromium.org/blink/trunk@201332 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none

Review URL: https://codereview.chromium.org/1316033003

git-svn-id: svn://svn.chromium.org/blink/trunk@201331 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This series of CLs fixes WebCallback parameter types used in BackgroundSync.

 - WebSyncRegistration* (ownership transferred)
  => PassOwnPtr<WebServiceWorkerResponse>
 - bool* (ownership transferred)
  => bool
 - WebVector<WebSyncRegstration*>* (ownership transferred)
  => const WebVector<WebSyncRegistration*>&
 - WebPermissionStatus* (ownership transferred)
  => WebPermissionStatus
 - WebSyncError* (ownership transferred)
  => const WebSyncError&

1/4: https://codereview.chromium.org/1309143002/
2/4: https://codereview.chromium.org/1311053002/
3/4: https://codereview.chromium.org/1308273002/
4/4: https://codereview.chromium.org/1308283002/

BUG=493531

Review URL: https://codereview.chromium.org/1308283002

git-svn-id: svn://svn.chromium.org/blink/trunk@201330 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In https://codereview.chromium.org/1065563005 we started allowing whitespace
inside anonymous table cells. We're only interested in anonymous table cells
that were generated to contain non-table-part content. If the anonymous cell
was generated to contain a form element with display:table-cell, for example, then
that is not a situation where we want to treat any whitespace before and
after the form element as renderable.
 
BUG=515771

Review URL: https://codereview.chromium.org/1280123004

git-svn-id: svn://svn.chromium.org/blink/trunk@201329 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These suites runs about 1000 layout tests as smoking tests for
spv2.

BUG=524134

Review URL: https://codereview.chromium.org/1307293002

git-svn-id: svn://svn.chromium.org/blink/trunk@201328 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Changes include:
(1) HTMLCanvasElement: 

The toBlob function is implemented in a similar fashion as the existing toDataURL function, taking in parameters like mimeType and qualityArgument. It has an additional argument FileCallback which accepts user-defined callback function.

(2) ImageDataBuffer:

encodeImage is made public.

(3) File:

A new create factory method is added to allow HTMLCanvasElement to create a new File object using the blob data. File object is a subtype of Blob object; it has two additional attributes -- name, last modification time -- as compared to Blob. We use empty string and current time to fill in these two attributes; FF creates the latter attribute in the same way.

(4) FileCallback: 

Moved from module/ to core/. 



BUG=67587

Review URL: https://codereview.chromium.org/1257253004

git-svn-id: svn://svn.chromium.org/blink/trunk@201327 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch refactors ObjectPainter::paintOutline to take a visual
overflow rect and layout size (w/o paint offset), plus a paint offset.
This cleans up the callsites so each doesn't need to compute a moved
visual overflow rect, and prepares the paint code for paint offset
caching. This has been split off from https://codereview.chromium.org/1315993004.

A TODO has been added above outlineRectForSVG because the function
should not exist. paintInvalidationRectInLocalCoordinates should be
fixed to contain the outline extent.

BUG=508383

Review URL: https://codereview.chromium.org/1321613002

git-svn-id: svn://svn.chromium.org/blink/trunk@201326 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=525300

Review URL: https://codereview.chromium.org/1319983003

git-svn-id: svn://svn.chromium.org/blink/trunk@201325 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also clean up unused option parameters to DPL::boundingBoxForCompositing.

BUG=460195

Review URL: https://codereview.chromium.org/1313953006

git-svn-id: svn://svn.chromium.org/blink/trunk@201324 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Viewport size determines the scroll clamp boundaries so when it changes,
we should retry any pending scroll restoration in case it is blocked
due to clamping. This can happen when page scale changes.

Removed |FrameView::clampOffsetAtScale| as it was only ever used
with scale 1 and could be replaces with |ScrollableArea::clampScrollPosition|.

FrameView calls the restore method directly making it unnecessary for
ChromeClient to be involved.


BUG=522153

Review URL: https://codereview.chromium.org/1300393003

git-svn-id: svn://svn.chromium.org/blink/trunk@201323 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Related chromium-side change: https://codereview.chromium.org/1307073002

BUG=456845

Review URL: https://codereview.chromium.org/1307863003

git-svn-id: svn://svn.chromium.org/blink/trunk@201322 bbb929c8-8fbe-4397-9dbb-9b2b20218538

 - WebServiceWorkerRegistration* (ownership transferred)
  => WebPassOwnPtr<WebServiceWorkerRegistration>
 - WebVector<WebServiceWorkerRegistration*> (ownership transferred)
  => WebPassOwnPtr<WebVector<WebServiceWorkerRegistration*>>
 - WebServiceWorkerError* (ownership transferred)
  => const WebServiceWorkerError&

This CL also fixes a memory leak in GetRegistrationsCallback::onSuccess.

1/3: https://codereview.chromium.org/1312343004/
2/3: https://codereview.chromium.org/1318953002/
3/3: https://codereview.chromium.org/1316293002/

BUG=493531, 525340

Review URL: https://codereview.chromium.org/1312343004

git-svn-id: svn://svn.chromium.org/blink/trunk@201321 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true
BUG=525286

Review URL: https://codereview.chromium.org/1311453003

git-svn-id: svn://svn.chromium.org/blink/trunk@201320 bbb929c8-8fbe-4397-9dbb-9b2b20218538

LayoutSVGText::locateRenderSVGTextAncestor returns a LayoutSVGText*, so
widening it to LayoutObject only serves to lose information - for the
primary benefit of "interface hiding".
This in turn mean that some calls can be devirtualized.

Also restructure the methods themselves to avoid stating the predicate
twice (negated and not.)

Review URL: https://codereview.chromium.org/1308983006

git-svn-id: svn://svn.chromium.org/blink/trunk@201319 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of SegmentedString::push() should always push a char in front (patchset #2 id:20001 of https://codereview.chromium.org/1308573006/ )

Reason for revert:
HTMLEntityParserTest.ConsumeHTMLEntityIncomplete fails on two Win bots

The newly added test is failing on WebKit Win7 (dbg) and WebKit Win Oilpan
(dbg) with the following message:

[ RUN      ] HTMLEntityParserTest.ConsumeHTMLEntityIncomplete
ASSERTION FAILED: !notEnoughCharacters

Sorry for the revert! Full output @ http://goo.gl/tnYH67

Original issue's description:
> SegmentedString::push() should always push a char in front
> 
> Before this CL, SegmentedString::push() had an exotic behavior, where
> two consecutive push would swap its order.
> 
> This CL changes the push() implementation so that it would always push
> the new char in front of the SegmentedString.
> This CL also updates the HTMLEntityParser code which relied on the behavior.
> 
> BUG=None
> TEST={SegmentedStringTest,HTMLEntityParserTest}.*
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201294

TBR=tasak@google.com,tzik@chromium.org,tkent@chromium.org,yosin@chromium.org,kouhei@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/1311043004

git-svn-id: svn://svn.chromium.org/blink/trunk@201318 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Several notifications layout tests misues assert_object_equals, passing
in non-object values, and assuming it will behave like assert_equals.

Spoiler - it doesn't: assert_object_equals(true, false) passes!

BUG=none

Review URL: https://codereview.chromium.org/1321643002

git-svn-id: svn://svn.chromium.org/blink/trunk@201317 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently CacheQueryOptions(ignoreSearch, ignoreMethod, ignoreVary) are not
supported on Cache.match/matchAll/delete/keys and CacheStorage.match, but
these APIs can accept the options and just drop them internally.

This CL makes these APIs show a warning message when unsupported options
are specified.

BUG=426309, 499216, 482256, 520784

Review URL: https://codereview.chromium.org/1320823003

git-svn-id: svn://svn.chromium.org/blink/trunk@201316 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When applying any other property than "all", we already perform this whitelist
check, but applying "all" is a separate code path, and the checks were missing
there.

BUG=524682
R=rune@opera.com

Review URL: https://codereview.chromium.org/1304123006

git-svn-id: svn://svn.chromium.org/blink/trunk@201315 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=497522

Review URL: https://codereview.chromium.org/1299323005

git-svn-id: svn://svn.chromium.org/blink/trunk@201314 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove a raw pointer to a PlatformEventController instance in PlatformEventDispatcher on Oilpan build

BUG=509911

Review URL: https://codereview.chromium.org/1301543002

git-svn-id: svn://svn.chromium.org/blink/trunk@201313 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This series of CLs fixes WebCallback parameter types used in BackgroundSync.

 - WebSyncRegistration* (ownership transferred)
  => PassOwnPtr<WebServiceWorkerResponse>
 - bool* (ownership transferred)
  => bool
 - WebVector<WebSyncRegstration*>* (ownership transferred)
  => const WebVector<WebSyncRegistration*>&
 - WebPermissionStatus* (ownership transferred)
  => WebPermissionStatus
 - WebSyncError* (ownership transferred)
  => const WebSyncError&

1/4: https://codereview.chromium.org/1309143002/
2/4: https://codereview.chromium.org/1311053002/
3/4: https://codereview.chromium.org/1308273002/
4/4: https://codereview.chromium.org/1308283002/

BUG=493531

Review URL: https://codereview.chromium.org/1311053002

git-svn-id: svn://svn.chromium.org/blink/trunk@201312 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a regression from r201058. We incorrectly marked the shadow root
node for style recalc instead of the host. Marking the host is necessary
to apply new :host rules.

R=esprehn@chromium.org
BUG=525280

Review URL: https://codereview.chromium.org/1311463004

git-svn-id: svn://svn.chromium.org/blink/trunk@201311 bbb929c8-8fbe-4397-9dbb-9b2b20218538

imported csswg-test@70d47dff45667002f8acdbd137f8cf2b04109365
imported web-platform-tests@1831450b96c77f1b8fa631f6987e3bc1e4eacf8e

* css-color-4 was added and skipped.

* 1 file to skip was renamed.

* 6 tests no longer fail and removed from TestExpectations
  - 1 in html/semantics/embedded-content
  - 4 in shadow-dom
  - 1 in css-writing-modes-3

TBR=dpranke@chromium.org,jsbell@chromium.org,tkent@chromium.org,hayato@chromium.org,kochi@chromium.org
BUG=490511, 492664, 505364

Review URL: https://codereview.chromium.org/1313623003

git-svn-id: svn://svn.chromium.org/blink/trunk@201310 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Depends on https://codereview.chromium.org/1316093003

BUG=none

Review URL: https://codereview.chromium.org/1309273006

git-svn-id: svn://svn.chromium.org/blink/trunk@201309 bbb929c8-8fbe-4397-9dbb-9b2b20218538