- 10 Nov, 2020 40 commits
-
-
Noel Gordon authored
Add fakes of the API calls file manager makes to its chrome background extension page. Add a TODO to rename this file. These fakes are copied from their externs file definitions [1]. Also includes fakes for window.metrics, and chrome.{storage,extension} until we find a better home for them. Taken together, these are the minimum number of fakes needed to render current files app code in the SWA container. [1] https://bit.ly/3n9Ckbv chrome/src/ui/file_manager/externs Bug: 1113981 Change-Id: Ic53fe5f50f2fd97a557292fc308c0d7dd16004bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528513 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#825671}
-
Wenbin Zhang authored
We only have 4 bots on win7-perf and there's no backup for those old models. Now we are only running a small set of tests on win 7, we can reduce the shard count to 3 to avoid capacity issue. Bug: chromium:1146593 Change-Id: I05187c0b65742cd9f06d12ee1e180065a548f30b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525860Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#825670}
-
Nnamdi Theodore Johnson-Kanu authored
Bug: 093185 Change-Id: Ic66508d92a5eb9c0d72c4b21e7517cbabb4563d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507295 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#825669}
-
Moe Ahmadi authored
Modules wait for the promo to be loaded before showing. The promo is considered loaded when the ntp-middle-slot-promo has been fired by the promo element. This event is expected to be fired whether or not there is a promo data available. crrev.com/c/2505739 changed that behavior causing NTP Modules to remain hidden when there is no promo data. Fixed: 1147257, 1143366 Change-Id: If0c14ec8ee142fd38cdbc1bf9249f3345db6ca82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527854 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#825668}
-
Charlene Yan authored
Bug: 1116118 Change-Id: I1d187df059f74e9e08fa2b55aedb29b86e29693d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523470Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#825667}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b5e18417..0833ef41 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I50f4182d502006d0c53fb1563c64d672096b7ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527347Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825666}
-
Brian Liu Xu authored
Do not process window management mouse messages (WMMMs) when the pen is active over the client area. Windows sends window management mouse messages at the mouse position when windows open or close (e.g. Aura tooltips and Status Bubbles), including WM_MOUSEMOVE, WM_NCMOUSEMOVE, and WM_SETCURSOR. This is a longstanding Windows behavior designed to ensure that mouse cursor visuals and hover states update when the foreground window changes. However, this behavior does not extend to pen input, so WMMMs always come with the mouse coordinates instead of with the pen coordinates even if there is an active pen. In Chromium, WM_POINTER processing in the window non-client area are "promoted" to mouse messages in order to allow for interaction with the native window frame (e.g. resize handles, title bar, and window caption buttons). However, WM_POINTER messages in the window client area are handled as Chromium events without any mouse promotion; in this latter case, mouse position and pen position are not guaranteed to be in sync. Since Aura tooltips and Status Bubbles appear as custom windows on pen hover, opening/closing them causes Windows to send WMMMs. Consequently, users might see visual flickering as hover states flip back and forth between pen and mouse positions. In order to ensure that these WMMMs do not interfere with hover states, we must ignore such messages until the pen is no longer active. This change affects only Windows 8 and newer clients, which use the WM_POINTER API. Bug: 1147222 Change-Id: I44335348f933f48edcfe665b396f133388169957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525220 Commit-Queue: Brian Liu Xu <brx@microsoft.com> Auto-Submit: Brian Liu Xu <brx@microsoft.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#825665}
-
Mark Pearson authored
It's flaky. TBR=rbpotter@chromium.org BUG=1147205 Change-Id: I8461641ba7380178e272e7a6ab1908de50f9b1c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527672Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#825664}
-
Noel Gordon authored
Change chrome_file_manager_private_test_impl.js so that it can be used in files SWA. No change in behavior. When the code is used in SWA, simulate test.Event because code further down in this chrome.fileManagerPrivate mock expects it to exist. This code is also used by the file manager UITests and that code needs a MockVolumeManager so we must create one in the UITests case. Test: browser_tests --gtest_filter="FileManagerUITest*" Tbr: alex Bug: 1113981 Change-Id: I0adc6c15a9dfaf3ced49dd9ba34a9ed900218dd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526822Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#825663}
-
Josh Karlin authored
Renames the table from sites_blacklist to sites_blocklist. This required bumping the database version up to 3. Modified the test databases to include a row to ensure that it's correctly carried over when migrgated. Bug: 1097286 Change-Id: I96d997377ae854fef23920f5f1b77a6ec773d247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495696Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#825662}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1604685414-e1e235adb1c3aa909026ef65a3bd85555a33e659.profdata to chrome-win64-master-1604955437-c91abc52162c185f79a73166dbe14ec0b1c66fea.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iff180398a0edfadaf5b5d090543dcedbdd218c68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527795Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825661}
-
Xinghui Lu authored
Only users who queried the feature flag are counted as active. Check the feature flag first to make sure there is no difference of group sizes in different experiment groups. There is no behavioral change in this CL. Bug: 1097310 Change-Id: Ib502759bce7d965641f4df49dddfa7b659eab50e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527759 Auto-Submit: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#825660}
-
Fergus Dall authored
Tooling which tries to find the owning component for a file for e.g. automated bug filing seems to only look at the OWNERS files in the direct ancestory of that file, it doesn't look at files included from elsewhere in the tree. Therefore we should add our component to everything to prevent bugs from being lost. Bug: 1113581 Change-Id: I784dd868f54d84cc226883405250c7acaf1c0b29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528516 Commit-Queue: Fergus Dall <sidereal@google.com> Commit-Queue: Daniel Ng <danielng@google.com> Auto-Submit: Fergus Dall <sidereal@google.com> Reviewed-by:
Daniel Ng <danielng@google.com> Cr-Commit-Position: refs/heads/master@{#825659}
-
Jesse Schettler authored
Add a progress bar and use it to display scan progress. Bug: 1059779 Change-Id: I9172be485799002364f4d5259fdbe006e80f6d02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521695 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#825658}
-
Wei Lee authored
Bug: b/172345161 Test: tast run [DUT] camera.CCAUI* Change-Id: I10484c9263f3e4c560028aef272cd3db88c47b31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509834 Commit-Queue: Wei Lee <wtlee@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#825657}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I5170fa85640ecf95c26b0f000fdcb6169073ccdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527628Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825656}
-
Noel Gordon authored
The files app front-end code creates a metadata Shared Worker. Provide a helper routine to do that and document it. Allow the routine to work if window.isSWA is defined [1]. [1] window.isSWA is not defined today, so no change in behavior. Bug: 1113981 Change-Id: Ib42ccadec1ee853758175ff018322954fd42c27c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526666 Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#825655}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/982b2a757087..e7a31f42cda3 2020-11-10 sokcevic@google.com Support main branch in bot_update If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com Change-Id: I21dd97b39154aaaf11633c3acb38e121b1f50968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528709Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825654}
-
Kai Ninomiya authored
Blink must also validate against 0xFFFF'FFFF coming in from JS, to prevent it from being interpreted as WGPU_STRIDE_UNDEFINED by Dawn. Currently this is done as an exception, but later needs to be an error injected into the command encoder. Bug: dawn:520, dawn:566 Change-Id: Ie9c992ffab82830090d0dfc3120731e89cd9691c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504584Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#825653}
-
Yulun Wu authored
Bug: 1147178 Change-Id: I0daed330aa98fee3166372f98c693cbef6ab5a69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527843 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#825652}
-
Jesse Schettler authored
Bug: 1059779 Change-Id: I9005fb60fdff0c38526411125614f6883ea3cbfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527883 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#825651}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9b7f81867ddd..1d532cbd0baa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iff99a34ad586a3993c69b8ffee9750db1c8350c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528569Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825650}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/489f2c838bb7..528ae31edd58 2020-11-09 jmadill@chromium.org Vulkan: Move ExtensionNameList out of the class. 2020-11-09 jmadill@chromium.org Vulkan: Move primary command buffer to CommandQueue. 2020-11-09 jmadill@chromium.org Traces: Use 4 download threads. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I0ee2d7ce821d16dbed062d5dd9f828d0f548aac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528611Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825649}
-
Nate Chapin authored
Change-Id: I47f74861053c14ddb9cc78ddfd360048968390e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523065 Commit-Queue: Nate Chapin <japhet@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#825648}
-
Jesse Schettler authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/284391894473..97f865a06daa $ git log 284391894..97f865a06 --date=short --no-merges --format='%ad %ae %s' 2020-11-06 fletcherw lorgnette: add CancelScan constant and permissions 2020-11-01 yichengli cryptohome: Add userdataauth implementation for GetWebAuthnSecret 2020-09-17 yichengli cryptohome: Set up WebAuthn secret during mounting Created with: roll-dep src/third_party/cros_system_api Change-Id: Ie04adba40fc0dbb2ce1b0d8470d7ab3518c881bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527425Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#825647}
-
Alexander Dunaev authored
This CL moves some test code to X11 utils and makes Ozone using it. Bug: 1121952 Change-Id: I4fdd95838f200960db0c232adfb56c6f25b6511a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524534 Auto-Submit: Alexander Dunaev <adunaev@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#825646}
-
Dale Curtis authored
This just fixes issues with the existing P010 GpuMemoryBuffer support and enables (but doesn't use) that support on macOS for VideoFrames. P010 GMBs while somewhat implemented did not actually work in the renderer since the flag which indicates if they're available wasn't setup correctly in the IPC configuration for FeatureInfo. Bug: 1101041 Change-Id: I9f96c2a920d34a352909f88f8548fa0348f98703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527589Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#825645}
-
Wenyu Fu authored
Introducing SkipTosDialogPolicyListener that loads TosDialogBehavior policy and determines if we should skip the ToS dialog. Update the ToS Fragment to make use of SkipTosDialogPolicyListener. This CL also changes semantics for two metrics we used to record in the ToS Fragment, so bump up the metrics version. Bug: 1108549 Change-Id: I4a61c96d815dce619f39a6252ef36b25095a73da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503312 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#825644}
-
Rakina Zata Amni authored
We changed it into a DCHECK in crrev.com/c/2478744, but not really sure if this can happen IRL or not, so adding DumpWithoutCrashing here to see if we can turn it into a CHECK eventually. Bug: 1131832 Change-Id: Ia8974f218fae4aada933cbabb3f59163ccc0e03a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522791 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#825643}
-
Scott Violet authored
The current checks mean WebLayer has to be loaded sooner then we would like. This moves the checks to a later point. I wanted to keep the exception as it seems very important to ensure that if code thinks it is creating an incognito profile, it actually gets one. BUG=1142989 Change-Id: Ic57304a8c3cfaeeba06e231f32b8dbf50456788e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527624 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#825642}
-
Toni Barzic authored
Bug: None Change-Id: I872883e1f978a6e2cb679ae16347a21b5ae202bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522986Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#825641}
-
Wei Li authored
Mac's platform shadow shows a black outline in dark mode. Use our own shadow instead. Bug: 1146562 Change-Id: I56562b806a43558d88dbd8e73aa2ea49e25c36ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524294Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#825640}
-
John Delaney authored
These histograms are no longer used and account for some of the larger histograms recorded by Chrome due to being per-resource. Bug: 1135295 Change-Id: I2a19101d049209f2894625c03c851034cff16a7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521367 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#825639}
-
George Burgess IV authored
This new clang-tidy check fires when the result of a function like `unique_ptr.release()` is unused. Sometimes this is intentional, other times, it's not (e.g., the dev intended to `.reset()`). Bug: 1134714 Change-Id: Ibb59ab44faba246b1d80f2abc0897238bf0c3e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457670Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#825638}
-
Zach Trudo authored
Call for uploading EncryptedReportingJobConfiguration jobs. Bug: chromium:1078512 Change-Id: Ib8018b4eed4392bbeccdae96a5924a2ed6411b8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499073 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#825637}
-
Joon Ahn authored
http://screen/6qQmdsFTNNFnfcv Bug: 1059779 Test: browser_tests --gtest_filter=Scanning* Change-Id: I3706aebdfbdfa18e495e114767984758c81c3086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521231 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#825636}
-
Robbie McElrath authored
This CL adds the bytecode_rewriter_target argument to the google_play_services_basement_java target, and marks it as not_needed in internal_rules.gni. The actual rewriting implementation will be landed in a later CL, but this first step allows us to add the bytecode_rewriter_target parameter where it's needed in Clank to avoid breaking it when the real implementation is landed. Bug: 1123216 Change-Id: I34c7af6582948b6fa07bc822d1c5f8ed8a9605b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527841Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#825635}
-
Kenichi Ishibashi authored
This CL implements a part of storage service crash recovery. After the mojo connection to the Storage Service is disconnected, ServiceWorkerRegistry enters a recovery state, binds a new remote, then sends live version information to restore state of resource purging scheduling. If ServiceWorkerRegistry gets a reply from the restarted Storage Service, it goes to a normal state. If multiple attempts of recovery are failed consistently, ServiceWorkerRegistry gives up recovery steps and aborts. See the design doc [1] for the overall approach. [1] https://docs.google.com/document/d/1RQgiuAZVbQZbYJeLOfmydBMwXTTfsL2RqZKx90yPT7U/edit#heading=h.qzq6g5l1po8a Bug: 1133143 Change-Id: I72411d77cc3a0e62d0c9471dd1c93fa9b05e21f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501165Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#825634}
-
Steven Valdez authored
This changes function/object/test strings to remove the 'signed' portion and references to SRR. Design: https://docs.google.com/document/d/1-4n1RLaJs8ANw34TsS6BVt7ARa7lK70F6aHFG2CL3Rc/edit#heading=h.6a92f2gfl9le Bug: 1133310 Change-Id: I63b1abd46542f9e4614e706403df14b84122f1e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436719 Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#825633}
-
Chris Hall authored
BlinkAXTreeSource::SerializeNode discards any node's language attr if it agrees with its parent's language attr. So any language inheritance work we do Blink side risks being wasted. This change requires us serializing some previously discarded ignored nodes (e.g. spans) if they have a language attribute so that browser side AXNode::GetLanguage() can perform all language inheritance. AX-Relnotes: n/a. Change-Id: Idc3fa8b6c600e76a01491944c13d495ed39446da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228269 Commit-Queue: Chris Hall <chrishall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#825632}
-