- 03 Feb, 2020 40 commits
-
-
Daniel Cheng authored
- Use updated kMaxValue convention for representing the histogram boundary. While it doesn't matter much here, not having a sentinel value is generally preferred (especially if the enum is used in switch statements). - Default to using the function instead of the macro. The macro is more performant, but the UMA recording paths here aren't on the critical path - Switch away from blink::EnumerationHistogram Bug: 742517, 1047547 Change-Id: Ibdcbb312dc1157d6284bdb0de8c9a3b2a591de62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032417Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#737888}
-
Daniel Rubery authored
XSD files are opened the same way as XML files, and should be treated equivalently. Bug: 1024190 Change-Id: Ief9ed22c433b51ffe9d16cb9578fa7a61118140e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032720Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#737887}
-
John Delaney authored
Currently, whitelist rules in the easylist are not always deduplicated by the rule. It is possible for there to be two separate lines with the same rule but different domains. This CL adds an awk command during filter list generation which combines these lines. This shrinks the filter list size by 1.7% and reduces the number of overall rules by 4.7% on the current list. Bug: 1048224 Change-Id: Ib3e71e9b371605380cfc5600fe8a92f5898f5b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033987 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#737886}
-
Christopher Cameron authored
It used to be that setting the contents of a CALayer to an IOSurface that has an HDR color space, and setting that the CALayer wants extended range content was sufficient to display HDR content. This was an undocumented behavior, and macOS has recently fixed it (made it not work). The documented way to get HDR is to use a CAMetalLayer. Unfortunately, one cannot call setContents (or provide a pre-existing IOSurface) to this API. As a consequence, we need to perform a copy from the IOSurface to the CAMetalLayer. Add HDRCopierLayer subclass of CAMetalLayer, which overrides setContents to blit the specified contents to the CAMetalLayer. Add tests for this. It appears that the test suite is not running, because most of the tests are broken. Fix all the tests (next step there is to add them to bots, but that will get a separate patch). Bug: 976426 Change-Id: I8115f2ad19f9a9fd3d1018d2bde7132f7bcfc6e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033906 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#737885}
-
Toni Barzic authored
Clicking app list button while app list is shown should hide the app list. The click is handled by AppListPresenterDelegate first, and the delegate dismisses the app list if the event is outside certain parts of UI. The logic is supposed to be no-op if the event is targeting home button, but it does not work for app list button on the secondary screen (as it compares the display root window coordinates with screen coordinates), so when clicking app list button on secondary display, AppListPresenterDelegateImpl dismisses the app list before the event is handled by home button, at which point the app list is shown again (in peeking state). This cl fixes the logic to use correct coordinates - additionally, uses View::HitTestPoint to test whether the event should be handled by home button (the home button uses custom event targeter, and HitTestPoint takes this into account). BUG=1047769 Change-Id: I18fd36bfff1583ab4cf1e78cd5732cb8525ef174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033071Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#737884}
-
Lei Zhang authored
- Remove unused includes. - Use ScopedFD. - Remove memory allocation with new. - Remove out-parameter checks that are always true. Change-Id: Ia4627f692057a3306f795f27b261489ca11981a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034110Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#737883}
-
Eugene But authored
This reverts commit 9af22179. Reason for revert: Consistently failing in EG2 tests on iphone-simulator, ipad-simulator Original change's description: > [ios] Translate Messages EGTest > > This creates an EG2 test suite for Translate for the new Messages UI. > Many tests are either direct copies or similar to those found in > TranslateTestCase. Some of them were also not moved over, because they > do not apply to the new Messages design. > > Bug: 1014959 > Change-Id: I3e8c5865686f23f500a31902dbfd60fe225bda6a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027127 > Commit-Queue: Chris Lu <thegreenfrog@chromium.org> > Reviewed-by: Sergio Collazos <sczs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737531} TBR=sczs@chromium.org,thegreenfrog@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1014959 Change-Id: I1faaa10ec76edbb54cfbcbab83983d2d4eaeba24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035302Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#737882}
-
Yusuke Sato authored
chromium:2025697 has introduced a new observer interface called arc::ArcSessionManager::Observer::OnPropertyFilesExpanded(). This CL is to make it so that all arc::ArcSessionManager instances in unit_ and browser_tests properly call the new observer interface just like the production code does. This is not currently mandatory but makes the test code more future proof. BUG=b:144199481 TEST=try Change-Id: I93c18a12ff406b36a1c484c24ab4b9f806fa38bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033691Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#737881}
-
Kurt Horimoto authored
This is a helper object that installs callbacks for every request that is added to an OverlayRequestQueue. It uses OverlayRequestQueueImpl:: Observer to detect newly-added requests, and installs callbacks on each added request using a list of OverlayRequestCallbackInstallers. This CL also updates OverlayRequestQueueImpl::Observer to include OverlayRequestQueueDestroyed(). This was not necessary before since the only queue observer was OverlayPresenterImpl, which is Browser-scoped and guaranteed to outlive all WebState-scoped queues. No such guarantee is made by OverlayRequestQueueCallbackInstaller, so a destruction observer callback is used to stop observation. Additionally, OverlayRequestQueueImpl::FromWebState() was added in order to safely fetch an OverlayRequestQueueImpl from the queue callback installer in order to observe the queues. Bug: 1030357 Change-Id: Ie1769b593f637a29dae9efe13de5e4d7d5a58164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032680 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#737880}
-
Lei Zhang authored
Currently, the function replaces backslashes with underscores. Do the same for forward slashes. Bug: 1041897 Change-Id: I2063992a093d3a8f10f71b452617313783b6bcd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036352Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#737879}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/906bfde9b6e2..852d4aa1ba41 git log 906bfde9b6e2..852d4aa1ba41 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 ynovikov@chromium.org Don't drop windows.winmd when packaging Windows toolchain Created with: gclient setdep -r src/third_party/depot_tools@852d4aa1ba41 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1032635 Tbr: agable@chromium.org Change-Id: Id7b08f6ea4a880e5be02c946057e03623dc036bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036111Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737878}
-
Andrew Grieve authored
These were easy to move, so I thought it was worth doing. Advantages to having them live under //android_deps: * Maven version constraints are checked when resolving deps * Consistency / ease of future updates Bug: None Change-Id: I71b2925dca94f55cf51c48e61bde3566ab214b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034076 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#737877}
-
Yusuke Sato authored
Previously, the /run/arcvm/host_generated/*.prop files were generated in arc_vm_client_adapter.cc only for ARCVM. This CL moves the logic to ArcSessionRunner so that these files are generated not only for ARCVM but also for ARC (as /run/arc/host_generated/*.prop). This will allow us to remove two features in arc-setup in the near future: - The *.prop generation logic itself. - Board-specific default apps setup. BUG=b:144199481 TEST=try, ARCVM still starts Change-Id: I0ce90e5b04c80079ae4f5a865c81191d7dc2b793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025697 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
-
Regan Hsu authored
This CL copies strings used by the OS About page from browser settings to OS settings. Bug: 967888 Change-Id: Ia16c8fcebf672ba67820a9e6b77aebe78012eeb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006257Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
Natalie Chouinard authored
Move autofill settings alongside autofill code. Bug: 1047357 Change-Id: Id5679d4392e23cff775dfcefa41930af9ab0f602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031538Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#737874}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/24046f60..522a6a0e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iaead286d1976d6a4bb7a9920a5c6989f12a61570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036010Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737873}
-
Manu Cornet authored
Bug: 1042491 Change-Id: I28e5d2ffb9a960e1146a8b6496ffd920e5d56509 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035867Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#737872}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/91f38e4aa97b..78f5b92a0b6b git log 91f38e4aa97b..78f5b92a0b6b --date=short --first-parent --format='%ad %ae %s' 2020-02-03 eseckler@google.com Merge "ipc: Add an option to require file seals when mapping shm." Created with: gclient setdep -r src/third_party/perfetto@78f5b92a0b6b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ie6d8158676c6a6b080ad8015ec780226d546abe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035308Reviewed-by:
-
James Cook authored
Replace the only check with a check for SplitSettingsSync. Enough features have been converted to work with the unconsented primary account that I don't need a separate flag for it any more. Bug: 1042400 Test: existing signin tests Change-Id: Iaf3690027737fd0ac674dad20d7da6107bb6b1b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035862 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e1a7bef8922f..db9ce1e03ccc Created with: gclient setdep -r src-internal@db9ce1e03ccc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:927262 Tbr: jbudorick@google.com Change-Id: Ic7c35d856fb508eda55c99bcf369cae421b3e8c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035309Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737869}
-
Vasilii Sukhanov authored
Bug: 1037189 Change-Id: Ideb252f3a08922586b340d044bb500a2259c5dcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030891 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#737868}
-
Navid Zolghadr authored
Bug: 1000682 Change-Id: Id5a6b7e87e983b475dda60821b1edff2ed23b0fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027891 Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#737867}
-
Christopher Cameron authored
We always want HDR videos to use GMBs on macOS. Bug: 976426 Change-Id: I9cf36ef2d031ec99320dde8ce4599664df0fa6f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034903Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#737866}
-
Austin Eng authored
This adds dawn_end2end_tests to the following bots: Linux Debug (NVIDIA) Linux Release (NVIDIA) Mac Debug (Intel) Mac Release (Intel) Mac Retina Debug (AMD) Mac Retina Release (AMD) Win10 x64 Debug (NVIDIA) Win10 x64 Release (NVIDIA) Win10 x64 Release (NVIDIA) Code Coverage Win10 FYI x86 Release (NVIDIA) On the main CQ, linux-rel, mac-rel, and win-rel will run the tests. Usually these tests will be deduped and noop -- unless a build change causes the test binaries to change. Bug: chromium:1046362 Change-Id: Ibcd059e262b6a28554bb06aad22a066b69b00953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033758Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#737865}
-
Chromium WPT Sync authored
Using wpt-import in Chromium dddedb4c. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Iacc561853044e64ff9ea73cde6ed15993fa7c723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036013Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737864}
-
Nate Fischer authored
No change to logic. This adds a histogram to measure the startup time impact of the flags UI (only when the flags UI is enabled). Bug: 1001185 Test: None (this is in the glue layer, so it's not testable) Change-Id: I5db50113324e63e4ac3dc39c8f9740a8342b774f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032194Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#737863}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c0feb63a6ff4..664c5603593f git log c0feb63a6ff4..664c5603593f --date=short --first-parent --format='%ad %ae %s' 2020-02-03 pfaffe@chromium.org Allow tests to switch on individual experiments 2020-02-03 pfaffe@chromium.org Report the content type for wasm modules in hosted mode Created with: gclient setdep -r src/third_party/devtools-frontend/src@664c5603593f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1047677 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I69881ca1f78c4160bd5e38a742f8960b5d389ee6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035306Reviewed-by:
-
Charlie Hu authored
This CL filters out features that are disabled by origin trial when initializing document policy in SecurityContextInit and when parsing from policy attribute on iframe element. Bug: 993790 Change-Id: I5b6a9f9e4b19275cb483c23c8d3cefa9e74af29c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019925 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#737861}
-
Muhamed Parić authored
Bug: 988059 Change-Id: Ibd28b8060aa1efff383e689ffa3ee5437d0faf4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035950 Commit-Queue: Muhamed Parić <muhamedp@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#737860}
-
Henrik Lundin authored
The UMA metric is not monitored anymore. Bug: none Change-Id: I8e3b333558502bc5d7cb0be3144ad0b0ceefaba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030169 Auto-Submit: Henrik Lundin <hlundin@chromium.org> Reviewed-by:
-
Avery Musbach authored
There is a comment that speaks of handling "when there is a window being dragged" but only checks if the active window is being dragged. It seems based on a mistaken assumption that a dragged window must be active. The behavior is actually reasonable because the purpose is to avoid stealing activation from a dragged window, which is not a concern if the dragged window is already inactive. Only the comment needs to be fixed. Bug: None Change-Id: I390eccc6370ad4ed7d15f2d32212fe43b0233633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031641Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#737858}
-
Sammie Quon authored
This is a common case in tablet because users frequently press the home button which minimizes all windows. It also is slightly different from other overview animations - it animates the wallpaper blur and opacity while fading in the mirror views and slides up the hotseat. Also, UX wants to remove delay on wallpaper blur when exited, so these metrics will catch a regression. A tast test will be added shortly. Test: ash_unittests *Overview* Bug: 1045185 Change-Id: I3ae72d876857415b11d1a3a5870b404b3e997660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018448Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
-
Tibor Goldschwendt authored
Bug: 1009579 Change-Id: I05870155fdba4e6c4fb2053661efebd3418017ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031555 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Takumi Fujimoto authored
Add these metrics: Media.Notification.Cast.UserAction Media.Notification.Cast.Count Their non-Cast counterparts still include counts for Cast sessions. Bug: 1042832 Change-Id: Ifb4b808be1ea2e266f2fdbd849d1646678c016d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032722Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#737855}
-
Kevin McNee authored
A portal WebContents has TabHelpers even when embedded. When the helpers are added, the portal WebContents is assigned a distinct tab ID. This is an issue when attempting to load the PDF viewer as ExtensionTabUtil::GetTabById cannot find the specified tab ID in the TabStripModel. Until we have a more thorough plan to deal with issue 1042323, we have the PDF viewer load without a tab id when created in a portal. Bug: 932691 Change-Id: Idbde43efcc1c0453abcea9b507cf01e9ef81f5f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033325Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Zachary Kuznia <zork@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#737854}
-
Kelvin Jiang authored
This CL adds documentation for the feedback API as well as the declarativeNetRequestFeedback permission. The getMatchedRules has also been made available for beta. Bug: 1044702 Change-Id: I9752110fce82b56efe5666fc811c018b1cf2e895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032415Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#737853}
-
Evan Stade authored
Bug: 1038415 Change-Id: I799c77bb441d34c68cd425e34e841ecd2c167a1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031711Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#737852}
-
Becca Hughes authored
For playback sessions (the continue watching table) we actually just want the most recent playback for a URL so we can make it unique. BUG=1041662 Change-Id: Ib7ad1d9f276ffe1b669fff36aa3154daf6b23ffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033908 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fb3951000894..5ddc34ca3de6 git log fb3951000894..5ddc34ca3de6 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 herb@google.com Remove 565 mask data from GrStrikeCache to constexpr varialbe 2020-02-03 bsalomon@google.com Use GrTextureEffect::MakeTexelSubset instead of MakeSubset in SkGpuBlurUtils Created with: gclient setdep -r src/third_party/skia@5ddc34ca3de6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: scroggo@google.com Change-Id: Ibc66f3cb616edd4d18fff5af348b2f592d2ef3be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034836Reviewed-by:
-
Nohemi Fernandez authored
This CL is part of a series of refactors to move the existing sign-in architecture to the Coordinator-Mediator design paradigm. Fore more information, see go/chrome-ios-signin-migration. Bug: 971989 Change-Id: Iba4a27f8b763697348cbd3f7c5a670fecbabf624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033145 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#737849}
-
