- 30 Sep, 2020 40 commits
-
-
Melissa Zhang authored
This CL adds a callback when the sharesheet closes. Bug:1126788 Change-Id: Ibc5e0a0d3d0f431139af5d0d783ad398646713f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434078 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#812342}
-
Jun Mukai authored
Bug: 1089768, 1089767, 1089854, 1089855 Change-Id: I8d927ca35e82a004c8900930b09c1a9ce250b137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439418Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#812341}
-
mark a. foltz authored
This was to record YouTube-specific use of remote playback, which is no longer supported. Bug: 1088674,1090963 Change-Id: Ib51ce33d59abb26ad29da01d887d923495c9faa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436554Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#812340}
-
Elly Fong-Jones authored
There's no particular reason for it to be on DialogDelegate since it applies to all WidgetDelegates. Bug: 1075649 Change-Id: I48da9f88b2c7b9bcc4171091eaa519ff0997bd4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440285Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#812339}
-
Andre Le authored
This is a reland CL for crrev/c/2419552, which ran into a compilation failure and merge conflict when reland. In this CL: - Create a base class for quick actions controller. - Create silence phone controller that connect to the DND controller in PhoneHubManager. Display the icons according to the states. - Hook up the quick actions UI in the bubble to silence phone controller. Enable hotspot and locate phone implementation will be added in the next CL. BUG=1106937,1126208 Change-Id: Ie8540bdc29de8b73297dcf5c3f0a0d963f76d63d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438590 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#812338}
-
Tomasz Wiszkowski authored
This change introduces an abstract CarouselSuggestion item that features title and configurable RecyclerView component. The content of the RecyclerView component (items) can be easily configured to display any type of elements. Change-Id: Ibdf9505c919c1f47a9cd1af14d538ff2bcbeacb3 Doc: http://doc/1IFsDKYhy_ARMOdT8jd1pMtk497xe03lb3hVnsaY-dOM Slides: http://slides/1c1SzJLzEsTjLmqIVLTomC8l9EgslBgYaBN6I7t8mbDI#slide=id.g8b3736bab3_0_0 Figma: https://www.figma.com/file/h8qjD0s9tezRzHdCMxIhYJ/On-Focus-Suggestions?node-id=290%3A309 Bug: 1106109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427724 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#812337}
-
Xiaohui Chen authored
When running ash_unittests on CloudTop instance, many tests would fail with "Maximum number of clients reached" X11 error. This does not repro on physical gLinux workstation though. Adding explicitly -maxclients parameter to make it consistent across platforms. Bug: None Test: Run testing/xvfb.py out/Release/ash_unittests Change-Id: Iac41378470d87df4b5d8140b3ee03a9a93a8c5ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438577Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#812336}
-
Lei Zhang authored
With the SaveEditedPDFForm feature, users have several new choices for how to save PDFS. Extend the existing PDF.Actions histogram with new ChromePDFViewerActions to cover these scenarios. This will help developers understand how often these new features are being used. Bug: 1130079 Change-Id: Ifb090f74b4f369d5e7c229bdaaf69138f430dc17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439553Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#812335}
-
Brandon Wylie authored
This reverts commit fd165f29. Reason for revert: Failing build on ToT: new ChromeActivityTestRule<>(ChromeActivity.class); ^ reason: cannot infer type-variable(s) T Original change's description: > Migrate remaining usages of ChromeActivityTestRule > > Bug: 989569 > Change-Id: If9f2bf207142253262bca092ca7dad6975893322 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437026 > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811949} TBR=mthiesse@chromium.org,agrieve@chromium.org Change-Id: I5970dcbad4685e2ae423b0bf5bdcd8beb7b00396 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 989569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441672Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#812334}
-
Ahmed Fakhry authored
This reverts commit 99860347. Reason for revert: Causes SubresourceExternalFileURLLoaderFactoryTest.SubresourceNotAllowed to fail on linux-chromeos-rel BUG=1133842 Original change's description: > Make ExternalFileURLLoaderFactory always owned by its |receivers_|. > > This CL introduces ExternalFileURLLoaderFactory::Create static method > that allows creating a ExternalFileURLLoaderFactory that is owned by its > |receivers_| and will self-delete when the last receiver disconnects. > > This CL removes the ability to directly construct and own a > std::unique_ptr<ExternalFileURLLoaderFactory>, because this ability > means that the factory can be destructed while receivers bound via the > Clone method are still alive (see the associated bug). In particular, > this CL stops exposing ExternalFileURLLoaderFactory constructor as a > public member, which forces construction to go via the new Create static > method. > > This CL mostly just follows the pattern established earlier by > https://crrev.com/c/2337411. > > Bug: 1106995 > Change-Id: I4bd235cf9132668d80657aece34de6fe7b60f78b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357620 > Reviewed-by: Sam McNally <sammc@chromium.org> > Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812139} TBR=sammc@chromium.org,lukasza@chromium.org Change-Id: I46984baa4f64848eb15a0a5db2a7883bd6077520 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1106995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441048Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#812333}
-
Xinghui Lu authored
For the motivation, see the document linked in https://crbug.com/1103015#c15. before: http://screen/By7yYtW4AUgLf5v after enterprise: http://screen/6JGbKuWZvsbmTNK after extension: http://screen/8KwaPD3geRVmDmN Bug: 1103015 Change-Id: I144468a0499493a7a7ca1d7fa622a49afc41cc02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439560 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#812332}
-
Akihiro Ota authored
This change adds tests for: 1. The 'Main menu' button; ensure that clicking this button takes the user to the main menu. 2. The 'All lessons' button; ensure that clicking this button takes the user to a screen displaying all lessons for the chosen curriculum. 3. The 'Next lesson' and 'Previous lesson' buttons; ensure that clicking these buttons moves the user between lessons. Fixed: 1127049 AX-Relnotes: N/A Change-Id: I0223769bf3ac79071918bcd764b0d2069556f446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439480Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#812331}
-
Ken Rockot authored
This reverts commit 18096716. Reason for revert: collides with https://chromium-review.googlesource.com/c/chromium/src/+/2401506 for compile failure Original change's description: > Delete service_manager/embedder/switches.h > > Each switch is either deleted because it's no longer used, or migrated > to a more appropriate layer (generally Content). > > Bug: 977637 > Change-Id: I9c4a74d4d99f4f7e7df8319d95b4ac4f55f11165 > Tbr: caseq@chromium.org > Tbr: dschuff@chromium.org > Tbr: finnur@chromium.org > Tbr: halliwell@chromium.org > Tbr: wez@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440908 > Commit-Queue: Ken Rockot <rockot@google.com> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812318} TBR=avi@chromium.org,rockot@google.com,rsesek@chromium.org Change-Id: I6edf5e5305491092e3d9ad52d252a7eafc518a0b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 977637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440973Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#812330}
-
Antonio Gomes authored
This is a reland of e511a14a Change from the original CL: - `BLINK_MODULES_EXPORT` added to the FuchsiaAudioDeviceFactory class declaration (fixes the linking problem locally for component builds). TBR=haraken@chromium.org Original change's description: > Onion soup FuchsiaAudioDeviceFactory > > This CL executes phases 5 on the design document [1]. > > [1] https://docs.google.com/document/d/19Zk6Fv1E-6QTQ2c33rpBjDNEkzlsSKvjb3hWkvZAE80/ > > It also adds triggers the generation of blink bindings by > //media//fuchsia/mojom. > > BUG=787252 > R=guidou@chromium.org, haraken@chromium.org > > Change-Id: Ic2a1ffaea1f9647d9c2c18d298fc23c58d5cc5bb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436749 > Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812057} Bug: 787252 Change-Id: If5d205e84c2a27842303566e03c568fb8e6c87c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441148Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Auto-Submit: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#812329}
-
Zentaro Kavanagh authored
- Tests method calls after resetting the FakeSystemDataProvider Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I83e6b90a47dec6ac2e1c885dfb17a2642e91b7bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441012Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#812328}
-
Yuwei Huang authored
Per discussion with Chrome network folks, network stack we are using appears to have an issue with proxy resolution such that it always fails no matter whether the host is using a proxy, and it blocks each HTTP request for 10-30 seconds, which is unreliable and sometimes triggers timeout error on the caller. This CL disables proxy resolution on Windows 7 hosts as a workaround, given we have never officially supported or tested proxied connections, and it will likely fail in later P2P connection stage. Bug: 1132978 Change-Id: I9096557105c566075bd2991007fe7d984476bf27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436670 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@google.com> Cr-Commit-Position: refs/heads/master@{#812327}
-
Christian Biesinger authored
These have the same issue that I fixed in https://crrev.com/c/2429543, but I didn't realize that when I made that CL. The -014 test is still failing. I will fix that separately. R=ikilpatrick@chromium.org, mstensho@chromium.org Bug: 1045668 Change-Id: Ic13c0e44edf7b962b2e28a8d3e6910e8bd841a79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441009 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#812326}
-
Aaron Leventhal authored
Layout is always clean here. Bug: None Change-Id: I5e45083d0be1ac99bd25bbc183dbeb6126c83db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438689 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#812325}
-
Ian Struiksma authored
Match proper mb configs for win10 1909 fyi and trybot Bug: 1132195 Change-Id: Ie40149eb07bd1298cebd83bbbc31dcc4e916714a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433999Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Cr-Commit-Position: refs/heads/master@{#812324}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5b238b2e5f6e..95c77a92cd84 2020-09-30 bingler@chromium.org Show Schemeful Same-Site Issues for unspecified SameSite 2020-09-30 andoli@chromium.org [ts] Typecheck components/Linkifier.js with TypeScript 2020-09-30 tvanderlippe@chromium.org Typecheck elements/DOMPath.js with TypeScript 2020-09-30 petermarshall@chromium.org [typescript] TypeScript-ify timeline/PerformanceModel.js 2020-09-30 petermarshall@chromium.org [typescript] TypeScript-ify timeline/ExtensionTracingSession.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1133612 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic9000eb19926d44080cade8ac69f92f7797e185b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441170Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812323}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 649c62d4. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox eae@chromium.org, szager@chromium.org: external/wpt/intersection-observer foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools hbos@chromium.org, hta@chromium.org, guidou@chromium.org, philipp.hancke@googlemail.com: external/wpt/webrtc NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I18b5f9c3eb08d07571a388a25b3de9a793e9e597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441247Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812322}
-
Jarryd authored
The corresponding instrumentation was removed in M67, however, this histogram was never marked as obsolete. This change only marks the histogram as obsolete, completing the histogram removal. CL that removed instrumentation: https://crrev.com/c/940525 Bug: 1089336 Change-Id: Iad9ab4b5d65a467ba70d4af74038bff069c639fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436776 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Auto-Submit: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#812321}
-
Peter Boström authored
Fixes an instance where BubbleDialogDelegateView claims to be a child of DialogDelegateView. It's in fact a child of BubbleDialogDelegate and View. Bug: None Change-Id: Ie5c123d6e4d2ee695b3e4c34ce1d61e35a55d32a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440967 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#812320}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601451302-74bafe020c79028d442bb7dcedaaf977604dc6fc.profdata to chrome-mac-master-1601488745-21956df111f44074edeba5bc0b298067a5c332e8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: I6eabaad319036cd8f0a08efa4644ae5c5ad1d6cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441335Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812319}
-
Ken Rockot authored
Each switch is either deleted because it's no longer used, or migrated to a more appropriate layer (generally Content). Bug: 977637 Change-Id: I9c4a74d4d99f4f7e7df8319d95b4ac4f55f11165 Tbr: caseq@chromium.org Tbr: dschuff@chromium.org Tbr: finnur@chromium.org Tbr: halliwell@chromium.org Tbr: wez@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440908 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#812318}
-
Kyle Milka authored
When populating the bottom row filter out any activities that have the same package name as the application. Bug: 1129175 Change-Id: I0ad7b66a0df89022b9abe1118e8324f452595561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417212Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#812317}
-
Yue Li authored
Bug: b/150034512 Test: Manual Test Change-Id: I86b9bd86fecb41f57de604cc1bfb5806b7494cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439027 Auto-Submit: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#812316}
-
Dominik Röttsches authored
Ship text-decoration-thickness, text-underline-offset and from-font keyword for text-underline-position. Intent-to-ship approved in https://groups.google.com/a/chromium.org/g/blink-dev/c/9OzS90KISXI/m/q5KYyyWBCAAJ In collaboration with schenney@ for resolving blocking paint invalidation issues and important refactorings in the paint code. Big thanks! Bug: 785230 Change-Id: I235a8e01fef8d8e9c4abd921190ce0023cf5bc16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440615Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#812315}
-
Joe DeBlasio authored
This CL changes target embedding to: 1. Allow a domain to embed itself (e.g. example.com.example.com). 2. Detect embeddings where the embedding happens at the end (e.g. www-example.com). Fixed: 1116859 Fixed: 1130843 Change-Id: Ic8e45bb7cf17a7f3473b859709b375bfc0eca44b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437914Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#812314}
-
Marijn Kruisselbrink authored
As it turns out Chrome OS guest mode is violating the assumption <webview> made that a chrome app's storage partition is always on disk. Because of this, before the change that added the blob url fallback mechanism a <webview> with no explicit partition name set would (incorrectly) share the storage partition with the app that embeds it. Adding the blob url fallback flag fixed that (by making them separate configs only differing in the fallback flag), but the fallback mechanism also assumed that a chrome app's storage partition always was on disk. This CL fixes loading blob URLs in a <webview> in guest mode by changing StoragePartitionConfig to store a tri-state enum rather than a simple bool for its blob url fallback mode. This way we can support fallback regardless of if the chrome app's storage is in memory or on disk. Bug: 1128330 Change-Id: I518cd5d1e89491eaf1cc6e2ed9ddb5cd3f0b9e87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439110Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#812313}
-
Haben Foto authored
Enable SystemWebAppManagerAdditionalSearchTermsTest on ChromeOS only as it is targeting ChromeOS specific feature and is flaky on Windows. Bug: 1133012 Change-Id: Id73da9a387dbbb8f6781998a06b9b69361b3b366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436321Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Haben Foto <v-habenfoto@microsoft.com> Cr-Commit-Position: refs/heads/master@{#812312}
-
Yi Gu authored
We currently use a map to store "origin, subscribers" pairs. Multiple pending origins may be rare in practice. e.g. a user visits origin A, while waiting for an SMS by WebOTP, they visit origin B and wait for another SMS. We want to measure the frequency of the multiple pending origins occurrenceto to evaluate other metrics. e.g. when an sms from one origin cannot be parsed, or the prompt is canceled/timeout, The simplest most practical approach is to report it on all existing pending origins which could lead to over-counting if multiple pending origins are a common occurrence. Bug: 1127397 Change-Id: Ife092d8e038b96977b34740854e5ed0a690083af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426974 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Sam Goto <goto@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#812311}
-
Nohemi Fernandez authored
Allows manual testing of the GAIA refresh feature by reducing the delay between polls to verify if GAIA cookies are available for a signed-in user. Bug: 1131027 Change-Id: Ib163a91ec3e5b922d652cff68c60b4e08708a828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440505 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#812310}
-
Frank Tang authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/aef20f06..aba3f0dfe aba3f0d Add rbns/zh.res rbns/ja.res to fix DateTimeFormat by Frank Tang · 11 minutes ago master 3c77cb5 Pass -fvisibility=hidden on Fuchsia by Fabrice de Gans-Riberi · 4 days ago Bug: v8:10960 Change-Id: Iec6f6d59131ec535ef3da369e7771d523734527c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437820Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#812309}
-
Maksim Sadym authored
rebase CL 2044170 part 1: Adds a new `FrameNavigationControl::JavaScriptMethodExecuteRequest` method. Previously every message was turned into an object literal in a new script and sent to the renderer process executing the front-end, which was very costly and leads to a lot of unnecessary script executing in the V8 engine. Bug: chromium:1029427 Change-Id: I9e803ea9d32ce333c4eea1d2cb06f1b2eaffaf02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431864Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Maksim Sadym <sadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#812308}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0f6ed710764d..1e5bef446919 2020-09-30 jbudorick@chromium.org devil: remove deprecated arguments. 2020-09-30 johnchen@chromium.org Revert "[Fuchsia] Allow passing through ssh_config file directly, make port optional." 2020-09-30 jleconte@google.com Fix Android swarming command line in WebRTC quest. 2020-09-30 a.pereira@eyeo.com Changed mint certificate expiration date to no more than 12 months 2020-09-30 jbudorick@chromium.org telemetry: update to denylist. 2020-09-30 johnchen@chromium.org Reland "[Catapult] Fix Mac CQ resource error" 2020-09-30 chonggu@google.com [Fuchsia] Allow passing through ssh_config file directly, make port optional. 2020-09-30 johnchen@chromium.org Revert "[Catapult] Work around dashboard test failures on Mac" 2020-09-30 johnchen@chromium.org [Catapult] Disable dashboard test on canary/Mac 2020-09-30 johnchen@chromium.org [Catapult] Work around dashboard test failures on Mac 2020-09-29 jleconte@google.com Revert "[Catapult] Fix Mac CQ resource error" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1097306,chromium:1123318,chromium:1128481,chromium:1132884 Tbr: skyostil@google.com Change-Id: I4bba362d4d851db02c5aeeb731da4a515af04668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441314Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812307}
-
Maria Kazinova authored
Bug: 1075444, 1131038 Change-Id: Id5aa1c9d1e3a18d432d460c1a45878a945d018c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435092 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#812306}
-
Zhenyao Mo authored
except for RGB32F. This is true since ES3 and most of Android devcies are on ES3+, and histogram data confirmed this: 100% renderable for all formats, except RGB32F, which is 99.99%+ unrenderable. Avoid runtime check - this is a minor optimization in validating command buffer on Android. BUG=1127837 TEST=bots R=kbr@chromium.org Change-Id: I9ac1c0c87ae197d6883e9167068bd81fc4e0d844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438313Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#812305}
-
chinsenj authored
With the ongoing interactivity improvements to the window cycle list (alt-tab) three finger horizontal trackpad scrolling was introduced as a way for users to cycle the window cycle list. However, if the user's most recent active window was a chrome window with multiple tabs, the three finger swipes would also tab scrub. To prevent both tab scrubbing and window cycle list cycling, this CL disables tab scrubbing while a user is cycling windows. Tests: manual + added test Bug: 1067327 Change-Id: Ic1ffd1152c3082c2cbc4ab198f5bf0f0c4540037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437155 Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#812304}
-
Weilun Shi authored
Put the real command-line flag `--enable-features=` in the comment of InitializeFromCommandLine to avoid confusion. Change-Id: I9bb542faebf2d0d8fe618142ebfbab56bc2c270e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430363 Commit-Queue: Weilun Shi <sweilun@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#812303}
-