GitLab

Bug: 1015293
Change-Id: Ic76e7911403a925fa46a5b5fc58eca95fa292269
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209392
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Auto-Submit: Esmael Elmoslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771116}

- Create a new structure to hold all all of the network health state.
- Add a call to the mojo service to return this structure on request.
- Merge the Device mojo struct into the Network struct.
- Remove GetActiveNetwork API call in favor of a single GetNetworks
  call.

Bug: chromium:1076177
Change-Id: I644348b85584e3dfda2e2406186fc77f03d9556b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2174172
Commit-Queue: Trent Begin <tbegin@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771115}

At the moment plumbing around freezing and pausing is highly convoluted
which leads to a few unfortunate consequences, namely:
- visibilitystatechanged events are not dispatched when bringing the
frozen page to the foreground.
- if bfcached page tries to execute JS, the events are silently ignored
instead of triggering eviction.

One factor which makes the plumbing complicated is that there is a
per-frame (instead of per-page) renderer-driven (instead of
browser-driven) freezing codepath — iframe.freezing.

Given that iframe.freeze API hasn't shipped and not under active
development, the suggested fix for the problems above is to unship it,
and reuse the modern plumbing instead when we decide to ship it.

This patch splits pausing and freezing into two independent states in
in Page (so the freezing-pausing-unpausing will still leave the page
frozen) and makes ExecutionContext::IsContextPaused return false
when the page is paused but not frozen.

R=dtapuska@chromium.org
CC=yuzus@chromium.org,haraken@chromium.org
BUG=1018601

Change-Id: Ibc1cb8aa5f2c0b1f221229d0e22855ddeb8e46bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202977
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771114}

BUG=1066670
R=msisov
CC=sky

Change-Id: I7072c4511358f992e373450c6100fe0b63b31551
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210822Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Maksim Sisov <msisov@igalia.com>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771113}

This has been done in this CL:
https://chromium-review.googlesource.com/c/chromium/src/+/2193691

Change-Id: Ib4b7d2e3c786fd1fffc0b36bff9e36741c1ffb93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210467Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771112}

Currently coverage.py is using update.py as a module which is not guaranteed

Bug: 1075586
Change-Id: Ia4c54413bfd63adc412fd665af26ac0b228f3e30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210175
Auto-Submit: Prakhar Asthana <pasthana@google.com>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771111}

https://dawn.googlesource.com/dawn.git/+log/214c71769bbb..bd0ad7921d3d

2020-05-21 rharrison@chromium.org Add support for WGSL shaders via Tint

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I1f6448f2361efa82a7453d8f0c2f0121701835d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212360Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#771110}

Split the processing into sample accurate and not sample accurate so we
can work on them independently to optimize each.

No functional changes.

Bug: 1013118
Change-Id: I58bce37b33fee9e4a272e164a6b0b4f37c7f8d1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2174994
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771109}

compress="gzip" is (as of r761031) the default behavior for
HTML/CSS/JS/SVG files, and therefore there is no need to
explicitly specify it.

Bug: 1068407
Change-Id: I578a85265869c286f52a507469b8627dfbb01480
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209906Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771108}

This story has been disabled before on windows. This change sets the
story to experimental, so that representative perf tests would run the
test without checking the values. This helps us know if the story needs
a new upper limit, and what is this new upper limit.

Bug: chromium:1053614
Change-Id: I697f4e3d2a2fd546bcb4e5b4caf4a71d0e9cf7d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208294Reviewed-by: John Chen <johnchen@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771107}

http://crrev.com/c/2197417 assumes in TabListMediator, adding a tab to
a target index in TabListModel when the PropertyModel at that index has
the exact same ID indicates that this is a redundant addition. However,
this is not true when we undo a group by multi-selection. When undoing a
group operation, it is possible that we add the moved-out tab to the
index of the group PropertyModel, and the group PropertyModel has the
same ID as the tab.

Since this assumption doesn't hold for tab group, this CL skips the
fix for tab group and adds a regression unit test and e2e test to cover
user journey.

Bug: 1083895
Change-Id: Ia1545a7b137c3089126498860e17f88308506158
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209810
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771106}

This CL fixes the remaining major known Site Settings issues. This
makes the fake settings Activity return the correct LayoutInflater,
which fixes two dialogs that used to crash when opening, and fixes
several theming issues such as incorrect colors or missing checkboxes
or radio controls.

Bug: 1049683
Change-Id: I4d8ab780eac74f3108361a1168e5e41b46935787
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207814
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771105}

As part of this bug the fetcher will need to
access the parsed data from the feed. This
moves the conversion into the fetcher.

BUG=1084303

Change-Id: I4a06dd9d0f46ceccc7df35b6376a16bb5548b227
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208084
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771104}

This reverts commit 3f8e5c2d.

Reason for revert: Mainframe document intersections will be inaccurate due to fix for https://crbug/1084786.

Original change's description:
> Ad Density UKMs recorded in AdsPageLoad.
> 
> This change adds ads page load metrics observer processing of
> FrameIntersectionUpdates for ad frames. Each frame, including the
> main frame, stores its main frame intersection in FrameData. The new
> AdsArea class handles calculating the combined area of all ad frames.
> Density is measured over the lifecycle of a page and the maximum denisties
> are recorded.
> 
> The two new UKMs are: MaxAdDensityByArea, MaxAdDensityByHeight. These
> will be used to evaluate/motivate future interventions on page ad
> density according to the Better Ads Standard. Height is needed
> explicitly to match the definition of the standard.
> 
> BUG=993453
> 
> Change-Id: I054a2017f56843762d39f44870848c622fc38a43
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137771
> Commit-Queue: Justin Miron <justinmiron@google.com>
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> Reviewed-by: John Delaney <johnidel@chromium.org>
> Reviewed-by: Josh Karlin <jkarlin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#768347}

TBR=rkaplow@chromium.org,jkarlin@chromium.org,johnidel@chromium.org,justinmiron@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 993453
Change-Id: I63812d8044a112b711a30bcef58f935f6959d9ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212445Reviewed-by: John Delaney <johnidel@chromium.org>
Commit-Queue: Justin Miron <justinmiron@google.com>
Cr-Commit-Position: refs/heads/master@{#771103}

These tests were relying on scrollers not being composited and did not
pass with --enable-prefer-compositing-to-lcd-text. This patch updates
the tests to explicitly disable composited scrolling.

Bug: 1085035
Change-Id: I5f2be2c7c57ce535801c9498a87ba42635906faf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209993
Commit-Queue: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771102}

Change Log:
https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/f2bc9d11e8..768eb2ca28
Full diff:
https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/f2bc9d11e8..768eb2ca28

Bug: None
Change-Id: I24e6eff1c28f4412299df6afef1eef3477c29cb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212166
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771101}

This is a reland of 8a905049

The issue was that settings_list->Get was in a DCHECK, meaning it was
never ran in non-debug builds. This fixes it by removing the DCHECK and
also uses GetList()::operator[] instead of
Get(size_t index, Value** out_value) since the later is deprecated.

Original change's description:
> Reuse upload browsertests for corresponding Enterprise Connectors
>
> This reuses tests by having the policy setters of
> DeepScanningBrowserTestBase set either legacy or Connector policies, and
> then making every upload browsertest parametrized with a bool so both
> policy sets get tested.
>
> The DeepScanningDialogViews test also change a bit, the ScanType test
> parameter is removed since this dialog doesn't depend on the type of
> scanning being done. This avoids having a very large number of
> combinations for that test that don't cover different code paths.
>
> Bug: 1076083
> Change-Id: I419b21de0095add8b5b214993be010d022941202
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210782
> Reviewed-by: Roger Tawa <rogerta@chromium.org>
> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#770745}

Bug: 1076083
Change-Id: I28eb4e2b9db730152c8c7f2a0a8404372ee00923
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211903Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771100}

Change-Id: I3aa4903a069ab7c73b428ff5fb8dc5c685444c4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211056Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Brian Manthos <brianman@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#771099}

All other calls to CanBePlacedInDefaultSiteInstance() provide the user
URL, but the call in SiteInstanceImpl::GetSiteForURLInternal() passes
the effective URL stored in |url| instead. This can lead to differing
behavior than other call sites. This change makes all the call sites
consistent. This causes subtle change in behavior on a platform that
chooses to enable default SiteInstance and uses effective URLs
(e.g. hosted apps). I do not believe Chrome currently has a platform
that combines these features.

Bug: 1085275
Change-Id: I6ae445f2e45a31f91a4428a6c2fc0a340157b75f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186639Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Aaron Colwell <acolwell@chromium.org>
Auto-Submit: Aaron Colwell <acolwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771098}

Add helpers to RenderFrameImpl and WebWidgetTestProxy to get to the
WebFrameWidget, because it's a big pain to go through WebFrame, to
its local root, to the WebFrameWidget.

R=dcheng@chromium.org

Bug: 866140
Change-Id: I818e1f88512fb4a951059106079fd13feccd6271
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210676
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771097}

TBR=hans

Bug: 1077698
Change-Id: I73ab941475c572bbecfdf40d293cd3acc838a138
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211125Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771096}

This reverts commit add913dc.

Reason for revert: closed tree due to
https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/13297?

Original change's description:
> Crash fast in case of an exception from ATL.
> 
> BUG=108176
> TBR=fdoray@chromium.org
> 
> Change-Id: I9723b07932b35fd098e40965735d1e92cb0c8946
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210466
> Commit-Queue: Greg Thompson <grt@chromium.org>
> Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#771073}

TBR=fdoray@chromium.org,grt@chromium.org,nicolaso@chromium.org

Change-Id: Idaa6e98d787d8dc33c08aede2c33dca919d2a612
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 108176
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212255Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771095}

This reverts commit f34af30b.

Reason for revert: broke android-pie-arm64-rel

https://ci.chromium.org/p/chromium/builders/try/android-pie-arm64-rel/124453

ERROR at //third_party/android_deps/BUILD.gn:1408:30: Assignment had no effect.
  enable_bytecode_rewriter = false
                             ^----
You set the variable "enable_bytecode_rewriter" here and it was unused before it went
out of scope.
See //third_party/android_deps/BUILD.gn:1404:1: whence it was called.
java_prebuilt("org_robolectric_android_all_java") {
^--------------------------------------------------
See //services/BUILD.gn:106:7: which caused the file to be included.
      "$google_play_services_package:google_play_services_base_java",
      ^-------------------------------------------------------------

Original change's description:
> add robolectric_all to android_deps.
> 
> This is the same file as included in
> 
> https://source.chromium.org/chromium/chromium/src/+/master:third_party/robolectric/cipd.yaml;l=16?originalUrl=https:%2F%2Fcs.chromium.org%2F
> https://source.chromium.org/chromium/chromium/src/+/master:third_party/robolectric/BUILD.gn;l=59?originalUrl=https:%2F%2Fcs.chromium.org%2F
> 
> I'm just moving it to android_deps, so I don't think we need security
> or license review.
> 
> Will remove duplicate file when robolectric moves to android_deps.
> I could possibly remove it now but sdk_texts writes in the location.
> https://source.chromium.org/chromium/chromium/src/+/master:third_party/robolectric/BUILD.gn;l=268?originalUrl=https:%2F%2Fcs.chromium.org%2F
> 
> Bug: 1060721
> Change-Id: I95fd2fc63d652c3b7274753532e6a86081f60a58
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210094
> Reviewed-by: Peter Wen <wnwen@chromium.org>
> Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> Commit-Queue: benjamin joyce <bjoyce@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#771084}

TBR=yfriedman@chromium.org,wnwen@chromium.org,agrieve@chromium.org,bjoyce@chromium.org

Change-Id: I0b12781d7df4416d76629c336373ceb608983c87
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1060721
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212464Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771094}

This change is necessary to hook up service worker to shared worker
clients in the performance manager's graph. This is because the
notification that the shared worker was added as a controllee of a
service worker comes before the shared worker could start.

Bug: 993029
Change-Id: I6b6377712001be84a9071a34fb56265d4a45f802
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199695
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771093}

In CL:2042214, we had to add an early return to
AXPlatformNodeTextRangeProvider::NormalizeTextRange when inside of an
editable text to avoid issues with Narrator not announcing deleted
characters.

That partial fix only works for plain text fields, like an <input>.
It doesn't work for rich text fields. Furthermore, it causes additional
issues with rich text fields that contains, for example, a list. For
this reason, we decided to limit this early return only for plain text
fields.

AX_Relnotes: Fixes a bug whereby Narrator was not announcing that the
user had entered or exited a list inside a rich text field.

Bug: 1083481
Change-Id: I5b07875b648923db9b39edffbdb0802b00ef4aa5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204684
Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#771092}

This reverts commit 83c14c4e.

Reason for revert: ReadyToCommitNavigation is the right place for this.

Original change's description:
> content: adds comment to RenderFrameCreated()
> 
> Hopefully this comment will help those trying to understand message
> ordering. RenderFrameCreated() is a good place to send a message to the
> renderer before loading starts.
> 
> BUG=none
> TEST=none
> 
> Change-Id: Idd7e3d9b8c6e41daf6b1d50cd4088bd12132deae
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212286
> Reviewed-by: danakj <danakj@chromium.org>
> Commit-Queue: danakj <danakj@chromium.org>
> Commit-Queue: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#771080}

TBR=sky@chromium.org,danakj@chromium.org

Change-Id: I59496bc0c1624395b1e0228faf852ffc2550c403
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: none
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211936Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771091}

https://chromium.googlesource.com/angle/angle.git/+log/ce285f432c39..1a4f6e1f3ce1

2020-05-21 tobine@google.com Vulkan:Migrate command buffers to pointers
2020-05-21 cnorthrop@google.com Tests: Add a common framebuffer config for perf tests

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: geofflang@google.com
Test: Test: angle_perftests
Change-Id: I73ca248b32c365e82deeae330f33f75a4fe51781
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212349Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#771090}

This CL adds and tests a utility function that checks if the captured
screenshot matches a given VisualTarget from the VisualModel.

Bug: 1068617
Change-Id: I3cad89f7ce6aa16a0e97ac31e30c8205fb93d3d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209475Reviewed-by: Bettina Dea <bdea@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771089}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4d042c5649f6..52e9a761fba0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC avi@google.com,vasilii@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1080903
Tbr: avi@google.com,vasilii@google.com
Change-Id: I6b07be344e8a9cf967daeca654d9002a87c1146d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212356Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#771088}

Using wpt-import in Chromium baa502f0.
With Chromium commits locally applied on WPT:
f6984fd9 "De-flaky pointerlock/pointerevent_pointermove_in_pointerlock.html"
45436d4d "CookieStore: WPT to verify subscribe/unsubscribe is idempotent"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: Ie1041caeaa2571184a4170c38977b1db9c5d6d0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212382Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#771087}

Bug: 1085007
Change-Id: I0cf4beaf1c10fabecb79eaa6d7a14d0b52eba6cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210486Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771086}

This function actually produces a periodic Hanning window instead of a
symmetric one.

Change-Id: If921c08d990eafe3e9475de2fbf7b6a64c7879f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211363
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771085}

This is the same file as included in

https://source.chromium.org/chromium/chromium/src/+/master:third_party/robolectric/cipd.yaml;l=16?originalUrl=https:%2F%2Fcs.chromium.org%2F
https://source.chromium.org/chromium/chromium/src/+/master:third_party/robolectric/BUILD.gn;l=59?originalUrl=https:%2F%2Fcs.chromium.org%2F

I'm just moving it to android_deps, so I don't think we need security
or license review.

Will remove duplicate file when robolectric moves to android_deps.
I could possibly remove it now but sdk_texts writes in the location.
https://source.chromium.org/chromium/chromium/src/+/master:third_party/robolectric/BUILD.gn;l=268?originalUrl=https:%2F%2Fcs.chromium.org%2F

Bug: 1060721
Change-Id: I95fd2fc63d652c3b7274753532e6a86081f60a58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210094Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: benjamin joyce <bjoyce@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771084}

Roll Chrome Mac PGO profile from chrome-mac-master-1590061793-cada8ca96f7665a04948a973b6cd8e2e12d92609.profdata to chrome-mac-master-1590076755-1b22274f1ce7584ce2730bbd2446e2694cb4fc1a.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:mac-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com
Change-Id: I480cf742a5dc461d028d4911f0768a547bc9cb8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212582Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#771083}

Post-chrome home, the BottomSheetTestRule has little functionality and
gets in the way of modularization. All existing tests have been easily
updated to work without it.

Bug: 100227
Change-Id: I6ae907599f0d651ae9d540b483b32146d678ed18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210668Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771082}

Make |version| a named parameter instead of positional. This should
make command lines less error-prone and magical (i.e. "what's this 3 in
the middle of the command").

Change-Id: I7ac59fa0268c0015f99232a8d3e24a64dadee717
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204627Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Jason Chase <chasej@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771081}

Hopefully this comment will help those trying to understand message
ordering. RenderFrameCreated() is a good place to send a message to the
renderer before loading starts.

BUG=none
TEST=none

Change-Id: Idd7e3d9b8c6e41daf6b1d50cd4088bd12132deae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212286Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771080}

This reverts commit bfe52a91.

Reason for revert: The Chrome security team has prohibited the use of gRPC in its current state as it does not go through Chrome's network stack. The Cloud Speech-to-Text implementation will be replaced with an alternative REST-based API that goes through the network stack.

Original change's description:
> Add protos required by Cloud Speech-to-Text
> 
> This CL adds the protos required by the Cloud Speech-to-Text service
> used by the Live Caption feature. The proto files come from Google3 with
> the following modifications:
> 
> 1. The package name of some of the protos were changed to avoid
>    conflicting with identical protos in the third_party/grpc repository.
> 
> 2. The license text was changed to align with Chromium conventions.
> 
> 3. any.proto and status.proto were renamed to prevent conflict with
>    protos in components/offline_pages/core/prefetch/proto.
> 
> 4. All protos are optimized for LITE_RUNTIME.
> 
> Bug: 1071626
> Change-Id: I351d98c9272e7ec7991a8182dbc305673c8e239c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153759
> Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
> Reviewed-by: Yuwei Huang <yuweih@chromium.org>
> Reviewed-by: Albert J. Wong <ajwong@chromium.org>
> Commit-Queue: Evan Liu <evliu@google.com>
> Cr-Commit-Position: refs/heads/master@{#764033}

TBR=ajwong@chromium.org,nyquist@chromium.org,yuweih@chromium.org,lgrey@chromium.org,evliu@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1071626
Change-Id: Ie0f8b65ed29217cbbedb28e8551e49189028203e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210799Reviewed-by: Evan Liu <evliu@google.com>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Evan Liu <evliu@google.com>
Cr-Commit-Position: refs/heads/master@{#771079}

Overall goal here is to ensure WindowAndroid instances are destroyed at
the end of instrumentation tests, but there is change in behavior for
production code.

Eager destroy WindowAndroid in AwContents. When the destroy runnable for
all AwContents that uses a WindowAndroid runs. Need to ensure at this
time that the WindowAndroid is removed from the global map as well. This
works because WindowAndroid lifetime and destroy runnable lifetime are
essentially the same.

Then in AwActivityTestRule, keep track of all AwContents created in
instrumentation tests in a list of weak references, and destroy at the
end of the test. Calling AwContents.destroy multiple is ok, so this
should be safe.

Need specific handling for AwUncaughtExceptionTest because it renders
the UI thread useless at the end of the test. Instead synchronously
destroy the AwContents in the test body itself.

Bug: 1081250
Change-Id: Ic07e52c7b21bf1300942e8b0a7cf178b8e3858b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205879
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771078}

Previously ShellWindowDelegateView had its initialization happen in
ViewHierarchyChanged(). This change splits initialization between the
constructor and AddedToWidget().

This allows the ShellWindowDelegateView to support being re-parented
to a Widget hierarchy multiple times.

Bug: 1083822
Change-Id: I4e0da0bcf458683bea2d327613588754c7372945
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206218
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771077}