GitLab

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=blundell@chromium.org

Bug: 968047
Change-Id: Ie7157527c1c36286c321800db5ecac024e8124c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728557
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683238}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7ae4b7f3..69c9ca09

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I19e2313e425bc7efaa2f4f128ccd6ccc7b4e4313
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731331Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683237}

... so it does not collide with blink's conamed class, when
these files get Onion soup'ed.

BUG=704136
R=guidou@chromium.org

Change-Id: I93961b646cb79ff29d54a10f5114bb4866e029f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731450
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683236}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=rdevlin.cronin@chromium.org

Bug: 968047
Change-Id: I2082e38973c90b49627bea4f27f7e00550f1a5ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729221
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683235}

This change adds a `url` parameter intended to be used later in the life
of a file handle.

One of the uses is to implement two steps in our security model:
The SafeBrowsing check and the Quarantine Service process.

Both of these steps require the source URL of the originator of the file
data.

Bug: 986588
Change-Id: I367e48a2654ac9aa0dc09979efabc9e31e261609
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729291
Commit-Queue: Olivier Yiptong <oyiptong@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Jay Harris <harrisjay@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683234}

If daily refresh is enabled refresh the custom background image if it's
been more than 24 hours since the last update.

Bug: 850317
Change-Id: Ic3b5611bb9ce975998bce75936e19cfc3dd2ef66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721682Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683233}

TBR: vitaliii@chromium.org
Bug: 972871
Change-Id: I5196841239ddf2ba8294457ecc7542e6843374a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730953Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683232}

Modifies the build to produce system image tarballs.

Adds logic to unpack the tarballs and restructure their contents to
mirror the layout of the image repository uploaded to CIPD.

Bug: 977018
Change-Id: Ib4ccff8a514d72cd426232c6e1a548f593e38082
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722287
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683231}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=falken@chromium.org

Bug: 968047
Change-Id: Iffe135d54c238ed7be67fe9bc1bdade9d050ee2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728666
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683230}

https://webrtc.googlesource.com/src.git/+log/84de3d95cf0e..bd3f30535c33

git log 84de3d95cf0e..bd3f30535c33 --date=short --no-merges --format='%ad %ae %s'
2019-08-01 kron@webrtc.org Request a new key frame if packet buffer is cleared
2019-08-01 nisse@webrtc.org Simplify ReportBlockStats

Created with:
  gclient setdep -r src/third_party/webrtc@bd3f30535c33

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: None
Change-Id: I072ff3b2708e82bbe304b918011d59316a857727
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730742Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683229}

setting logic.

This updates a unit test and adds another to verify that we're setting
num_attempts as expected for Periodic Background Sync registrations.

Bug: 989444
Change-Id: Ic4aa69f772ce388025ad4344f346464813f679a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729086
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Auto-Submit: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683228}

Prevents the CastRunner from clobbering the Agent's
setTouchSupportEnabled() platform API if it's already been installed.

Bug: 953796,953958
Change-Id: Ia1044a96209f04d792a8c671a8ac18eb98b2d9ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728445Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683227}

This cl adds SupervisedUserCrosSettingsProvider to be able to
control cros settings.

Bug: 945934
Change-Id: Ifd8d5660c6520754543666ce82f189901b1ae7e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724495
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683226}

On Intel the instruction used is CRC-32C (Castagnoli), which uses a
different polynomial than 'traditional' crc32 deployed in zlib.

Fortunately ARM has instructions for both polynomials, so this patch
will ensure that compressed content using Chromium's zlib will match
i.e. checksums should be the same.

Bug: https://issuetracker.google.com/115695768
Change-Id: Ia22bc150e89afa345a6d3149c30332a6c1e7934d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726551
Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org>
Reviewed-by: Adenilson Cavalcanti <cavalcantii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683225}

Ozone/X11 window "mobility" has been broken by crrev.com/c/1698263. Which
has been observed in apps such as content_shell, ozone_demo. The issue
is caused |ui::XWindow::activatable_| being set to false in those builds.

This fixes it, defaulting PlatformWindowInitProperties::activatable to
true and just forwarding it to ui::XWindow::Configuration at
X11WindowOzone initialization code.

Bug: 988913
Change-Id: I65cd8ab8a5763ae0f0cbfb748f146662f80846d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726597
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683224}

https://skia.googlesource.com/skia.git/+log/a00318f1ad00..69e1462010af

git log a00318f1ad00..69e1462010af --date=short --no-merges --format='%ad %ae %s'
2019-08-01 michaelludwig@google.com Remove SkDEBUGFAIL in SkDisplacementMapEffector ctor
2019-08-01 robertphillips@google.com Add GrCaps::getTestingCombinations

Created with:
  gclient setdep -r src/third_party/skia@69e1462010af

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=benjaminwagner@google.com

Bug: chromium:988237
Change-Id: Ib923c3c1a51a855ec3430f81c3d81333605d60ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730792Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683223}

Disable the test as it's flaky.

Bug: 982564
Change-Id: I81f4f87ccd6b2b20f497d42debcbba7741da2090
Tbr: khmel@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731610Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683222}

Specifically porting:
 - cr-button
 - cr-checkbox
 - cr-toast
 - cr-toggle
 - cr-view-manager
 - md-select, shared-style, hidden-style styles
 - shared icons

Repro:
 - Add optimize_webui=false flag.
 - Go to chrome://print/polymer3/demo.html.
 - See working cr-* elements, styles, icons.
 - Open Devtools console.
 - No HTML imports warnings should exist.

Bug: 965770
Change-Id: I1eec3c588a155ce32477cbd74cbd0a4864fb3ba3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626665
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683221}

This reverts commit be8f1163.

Reason for revert: crbug.com/977942

Original change's description:
> Replace base::queue with WTF::Deque in mediarecorder
>
> This is a part of moving media recorder implementation to blink.
> This CL replaces base::queue with WTF::Deque in mediarecorder.
>
> Bug: 960665
> Change-Id: If3b1a795b5e21cfd54b83c46481bf6591efaa74a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669255
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#671211}

TBR=mcasas@chromium.org,haraken@chromium.org,guidou@chromium.org,myid.shin@igalia.com

Bug: 960665
Change-Id: I33d40175cfe2cc357fbd876408579c7c07ab4a29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730063Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683220}

Before this change, from debug console, you can see:
 - <AppMeasurement>[I-ACS036002] Analytics screen reporting is enabled...
This boolean option in Info.plist turns this off.

Bug: 989857
Change-Id: I83d1a22b9f546e2efb1278aaad7d66edb722fffd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729248
Auto-Submit: Peter Lee <pkl@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683219}

The validation to check that the texture is non-null was inverted which
allowed invalid or null textures to pass validation and crash when being
accessed.

BUG=986057

Change-Id: Icc3e297d16e0c80019b49f6b80b1972911f2f338
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724694
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: James Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683218}

https://swiftshader.googlesource.com/SwiftShader.git/+log/204a410c8c40..f63c4e51101a

git log 204a410c8c40..f63c4e51101a --date=short --no-merges --format='%ad %ae %s'
2019-08-01 bclayton@google.com Reactor: Don't auto-initialize Pointer<T> variables with null.
2019-08-01 bclayton@google.com Reactor: Add nullptr_t copy / assignment operators to Pointer<T>

Created with:
  gclient setdep -r src/third_party/swiftshader@f63c4e51101a

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@google.com

Bug: None
Change-Id: I51f77af807365c89ba77b30b32ac2e0428610af7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730741Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683217}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=boliu@chromium.org, ntfschr@chromium.org

Bug: 968047
Change-Id: Ia18ba834e8e7182f4d7224645e05e894f1991173
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728661
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683216}

Currently when only federated credentials are saved on the site,
the key icon isn't showing up when we refresh the site.

Bug: 677111
Change-Id: I0188d001b59f2af081688acb89adf0928898ead5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717301
Commit-Queue: Rafał Godlewski <rgod@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683215}

https://chromium.googlesource.com/angle/angle.git/+log/e995d7fb23c5..868f5fa02353

git log e995d7fb23c5..868f5fa02353 --date=short --no-merges --format='%ad %ae %s'
2019-08-01 jmadill@chromium.org Refactor return values from entry points.

Created with:
  gclient setdep -r src/third_party/angle@868f5fa02353

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@google.com

Bug: None
Change-Id: I9d212cf8906e5e84c2c9dd419bd7059af8d1ff24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730736Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683214}

All policy-based extensions' files should be checked in some way. It
already works for Chrome Web Store extension, but not yet for
self-hosted ones. This commit adds a way of telling to ContentVerifier
that extension should be checked.

The commit only adds a new delegate method, which is not yet used.

Bug: 958794
Change-Id: I67898ce61c47d9ecc53c0398bfa5e9bdb65373b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710327Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Nikita Podguzov <nikitapodguzov@google.com>
Commit-Queue: Oleg Davydov <burunduk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683213}

This CL removed a for-test function since it's no longer used.

Bug: NONE
Change-Id: I998b98f68e9bba9f8366747c4bc7854dfbc97ba3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728180Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683212}

This is a reland of 107a4e3e

Original change's description:
> Integration tests for click to call
> 
> Bug: 982229
> Change-Id: I3d0f19b55dc6dc07c6ad427d670aaa2db0a9af2d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718410
> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org>
> Reviewed-by: Peter Beverloo <peter@chromium.org>
> Reviewed-by: Richard Knoll <knollr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#682242}

Bug: 982229
Change-Id: Id20a918d405d7f56fa1a362666b2da510ee4b3e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728552Reviewed-by: Richard Knoll <knollr@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683211}

This is a follow-up of:
https://chromium-review.googlesource.com/c/chromium/src/+/1724499

This CL introduces new reporting methods to the AudioGraphTracer
class to notify when the graph object connection/disconnection to
the devtool frontend.

The actual reporting code to InspectorWebAudioAgent will be implemented
by the follow-up CLs.

Bug: 970898
Change-Id: Idd00e73f8aec36f2812c4ee60b6bf42d1a2bbd39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726957
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683210}

Disable PermissionDialogTest.
ActiveTabClosedAfterRendererCrashesWithPendingPermissionRequest on Win.

Bug: 989858
Change-Id: I59ad637e0e12e62e4e791d9d389dcac4118bcd3a
Tbr: engedy@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731014Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683209}

This CL makes Widget::InitParams movable, and adds to it a
movable element `init_properties_container` of type
PropertyHandler. This adds support to views::Widget to allow
its users to set any arbitrary properties that will be set
on the native widget's window before it is initialized and
parented.

This way we can watch for windows with particular properties of
interest in WindowObserver::OnWindowAdded().

Example use case: Mark widgets to be ignored in the mini_views
before they're added in the desks containers. This avoids refreshing
the mini_views unnecessarily. This will be handled in a follow-up
CL.

BUG=979434, 866622
TEST=Added a new test.

Change-Id: I26f4c5db77e7acd9c4b52ea77775376d52c50897
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709966
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683208}

The class is now a no-op as of
https://chromium-review.googlesource.com/c/chromium/src/+/1686726.
It never fires its observer calls and always returns https://www.google.com/.
Move that constant to google_util and unwind the rest.

This ends up touching a lot of files. The two interesting parts:

- Check that GoogleURLTracker is always created with ALWAYS_DOT_COM_MODE,
  and that, in ALWAYS_DOT_COM_MODE, it degenerates into return
  kDefaultGoogleHomepage. (Apart from test code which manually triggers
  bits of it.) That means we can replace all uses of
  GoogleURLTracker::google_url with the newly-added
  google_util::kGoogleHomepageURL and remove everything that registers
  callbacks.

- Check that nothing else uses the prefs in google_pref_names.h, and
  thus they can be removed. Check that I've correctly replaced them with
  migration code in chrome/browser/prefs/browser_prefs.cc and
  ios/chrome/browser/prefs/browser_prefs.mm

From there, this CL does that following:

- Remove GoogleURLTracker and associated classes from tests and production
  code.

- //components/google/core/browser got folded into
  //components/google/core/common

- A bunch of test-only functions to simulate the Google URL changing are
  gone.

- UIThreadSearchTermsData in both iOS and non-iOS no longer needs a Profile
  parameter.

Hopefully that's enough context that one can review the bulk of the CL
(which is fairly uninteresting) without too much trouble.

Bug: 973591
Change-Id: I4aa3606e4a1b2ccf2d33932c22a69b74e5176753
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687348
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683207}

Implement the "seekto" and "scrubto" mojo commands
by calling the "seekto" action handler in Blink.

For reference, these are separate in the generic
media session mojo API because not all media
sessions support scrubbing.

BUG=977375

Change-Id: Ib62e069a03539e57de832e8108c877be7f582e93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697428Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683206}

Using wpt-import in Chromium 501c13b1.
With Chromium commits locally applied on WPT:
250461b3 "Worker: Register a service worker just once for worker subresource interception tests"
bf4ad57e "Experimental CookieStore API: some additional browser-side validation"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: I17f35901d86be31d418e6889db8adc55c5d07560
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731310Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683205}

The decision logic depends on browser and webview bitness. These are
Chrome concepts. Therefore, move the decision logic from //build to
//chrome.

Change-Id: Idd334e521ed30dd09805c795be32f790a52a51cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730834
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683204}

This patch makes the ModelListAdapter compliant with MVC by
introducing a "ListObservable" ModelList. This allows the adapter to
know about changes to the list without explicitly being told. As a
result, coordinators and mediators no longer need to hold references
to the adapter to make changes.

Downstream component here: https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/1377764

Bug: 909779
Change-Id: I626f513f1e63bc8a1808390d01d4058b631ca18d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652423
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683203}

Disable this test on Win, ChromeOS and Linux(chromium)

TBR=msramek@chromium.org

Bug: 985131
Change-Id: I2df66eded5c6f5129bde29d8f715dab6c658b3d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731170Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683202}

Another preparation step to Onion souping this test
and its respective production code.

BUG=704136
R=guidou@chromium.org

Change-Id: I213eee21c66213c06350413600f2fbe487c5cd2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731449
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683201}

The initial version of this component was intended for improving
captive portal detection only, and was guarded via
ENABLE_CAPTIVE_PORTAL_DETECTION. The component now handles additional
features such as dynamic interstitials which should be enabled on
Android.

Bug: 987346
Change-Id: I7bf9e7ac411efc97957364fe2ccbab802eebc6b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730089Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683200}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/682bc0e14c7a..1f08ded4fe9a


Created with:
  gclient setdep -r src-internal@1f08ded4fe9a

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:None
Change-Id: I1cf8ea6bc504198d1a12c2d6245d11a707f50e8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731098Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683199}