- 23 Jul, 2018 40 commits
-
-
jonross authored
content/renderer:renderer has public dependencies on content/common:mojo_bindings but it had only been picking that up implicitly. This has broken on the waterfall in the past. This adds it to the public deps. Bug: 859324 Change-Id: I546280c175f3b857466f0f8de4b0aac64766acda Reviewed-on: https://chromium-review.googlesource.com/1145715Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#577227}
-
Miguel Casas authored
This CL relands crrev.com/c/1021675 that got reverted as predecessor to crrev.com/c/1104394 (but was otherwise innocent AFAIK). The said predecessor situation has been corrected by crrev.com/c/1117606 (that landed in ChromeOS 10840.0.0 [1]) [1] https://crosland.corp.google.com/log/10837.0.0..10840.0.0 TBR=dcastagna@chromium.org (same code as reviewed before) Original CL description ----------------------------------------------- vaapi: decode on client NativePixmaps This CL teaches VaVDA to use client VASurfaceIDs to decode onto, saving a buffer copy and removing a costly blit (DownloadFromSurface) on the GPU Main thread. Three groups of changes: 1. In AssignPictureBuffers(): if |vaapi_picture_factory_| Create()s a VaapiPicture with a VASurfaceID, we use those to decode onto and set a new flag: |decode_using_client_picture_buffers_| 2. When the decoder calls CreateVASurface(), instead of giving it the first |available_va_surfaces_|, we need to figure out the first VASurfaceID in this |available_va_surfaces_| such that the corresponding VaapiPicture in |pictures_| is available (i.e. in |available_picture_buffers_|). Reason: libva holds on to some VASurfaceIDs, there's no simple one-to-one correspondence like on ToT. 3. When we're ready to OutputPicture() to |client_|, instead of using the first |available_picture_buffers_|, we find the corresponding one for the passed |va_surface_id| (we could search all over |pictures_| but there's always less |available_picture_buffers_|. Some other notable developments: - s/output_buffers_/available_picture_buffers_/ - OutputPicture() loses a parameter. - |decode_using_client_picture_buffers_| is still false for e.g. VP9 Profile 2 or the ImportBufferForPicture() path. - Pictures is made a base::small_map. (Originally from crrev.com/c/988512). resolutions for a long time. No hickups, no dropped frames. Bug: 822346, 717265 Test: v_d_a_unittest vp8/vp9/h264 passing on eve, running crosvideo changing Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie1fb21a7a302476bceee3dd905278d53f13b1475 Reviewed-on: https://chromium-review.googlesource.com/1021675Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Kristian H. Kristensen <hoegsberg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1147143 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#577226}
-
Lily Houghton authored
As part of the network servicification project, this CL replaces the use of net/ sockets in the PrivetTrafficDetector class with the UDP socket interfaces in the network service. Bug: 811497 Change-Id: I0f0295f032684b0e6a32de222760cfeb409c7d21 Reviewed-on: https://chromium-review.googlesource.com/1127268Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Cr-Commit-Position: refs/heads/master@{#577225}
-
Christian Fremerey authored
Crash reports indicate that on some devices the call to getCameraCharacteristics raises an AssertionError inside Android OS level code. The message attached to it is typically "Supported FPS ranges cannot be null." On the Chromium side, the best we can do is to catch this, so that instead of crashing, we fail gracefully. This CL adds the catch clause. Bug: 860784 Change-Id: Ic5092e98b9497399ac309f00ea3eaecd41512646 Reviewed-on: https://chromium-review.googlesource.com/1145727Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#577224}
-
Jian Li authored
Bug: 865140 Change-Id: Id58e74ea8cda672252b5f6abce911ce7d849ee3e Reviewed-on: https://chromium-review.googlesource.com/1142448 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#577223}
-
Vasilii Sukhanov authored
Bug: 854638 Change-Id: I32e08f3f33558f7286f5cd80b05e86aa0dae0dd4 Reviewed-on: https://chromium-review.googlesource.com/1146817 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#577222}
-
Victor Costan authored
Bug: 410350 Change-Id: I34cbb3572b1b5202ea2400acaafa68eae47809e4 Reviewed-on: https://chromium-review.googlesource.com/1146494Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#577221}
-
Lei Zhang authored
Currently, there are some code paths in PrivetNotificationService where PrivetTrafficDetector is not stopped. This causes PrivetTrafficDetector to forget to unregister itself from NetworkConnectionTracker. BUG=866199 Change-Id: I75721603889a6886b012d439bd6e8f2266083ee1 Reviewed-on: https://chromium-review.googlesource.com/1145888Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
-
Jochen Eisinger authored
We no longer should wait for frames in tests, so this should pass again R=ccameron@chromium.org BUG=772576,753691 Change-Id: I9ff676c05fff3fa2d79e1a22edb4ec25ef5e5806 Reviewed-on: https://chromium-review.googlesource.com/1146191Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577219}
-
Ryan Cui authored
Bug: b/78189672 Change-Id: Id8716cca1f4cf15a5700a0a4afa822302a829662 Reviewed-on: https://chromium-review.googlesource.com/1142623 Commit-Queue: Ryan Cui <rcui@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#577218}
-
Scott Chen authored
This allows us to not copy every property specified in the mixin when we want to override just one of them. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I121c5cbf66f8fbdd159a65139d537d92119ea2e1 Reviewed-on: https://chromium-review.googlesource.com/1142482Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577217}
-
Ryan Sturm authored
NoScript savings was previously recorded on the IO thread using ChromeDataUseAscriber framework. This framework is being deprecated and this change is blocking parts of previews servification. The results from looking at this on real no script pages was not far off from the results using CDUA, and I believe it is accurate enough. Bug: 842233 Change-Id: I70057574554fd6717e0837be1a46cb6afa05ce4b Reviewed-on: https://chromium-review.googlesource.com/1139081 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#577216}
-
Michael Spang authored
We need to call drmFreeVersion(). Bug: none Test: compile Change-Id: I0c819d989a15dc2a5ddda7f9e37311d860f5afa1 Reviewed-on: https://chromium-review.googlesource.com/1146980Reviewed-by:
-
Roger McFarlane authored
Tests 148 through 151 were not included in the test case bundle (copy step for dependendent data) in the iOS build, so these tests were not being run on that platform. This CL adds the input and output files to the unit_tests_bundle_data. Bug: 865864,857488 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib501fe2644c7961f2d6bcee80f7388a7daef8623 Reviewed-on: https://chromium-review.googlesource.com/1146769Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#577214}
-
Oscar Johansson authored
This commit will enable jumbo for chrome/browser/ui. This will reduce the build time by approximately 90 CPU minutes (more than 10 % of the total jumbo build time for chromium), compared to building without jumbo. Bug: 803406 Change-Id: I7774bd55378ea88dadcbf452679686e383bb15a2 Reviewed-on: https://chromium-review.googlesource.com/1143269 Commit-Queue: Oscar Johansson <oscarj@opera.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#577213}
-
Andrey Kosyakov authored
This introduces additional interception step into DevTools network interception logic -- we now pause and report intercepted requests after browser decided to follow the redirect, but before the request is sent. Change-Id: I228e6898d3a28abf80b8b6cc72ff61fac3884279 Reviewed-on: https://chromium-review.googlesource.com/1145946 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#577212}
-
Christopher Cameron authored
ImageTransportSurfaceOverlayMac is written under the assumption that it is only ever paired with a GLContextCGL. This assumption has recently been broken. The ERROR here was, as a result, creating an unruly amout of console spam. Bug: 866520 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I3f3524f3f45e9e4cdaae09aeb672c9ab3b8edafa Reviewed-on: https://chromium-review.googlesource.com/1147100Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#577211}
-
Fabio Tirelo authored
The goal is to make more clear to translators that they are supposed to choose either YY/MM or MM/YY. Change-Id: I5c84a566ac83e15e59bbca413506035197553c0a Reviewed-on: https://chromium-review.googlesource.com/1146665 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#577210}
-
Becky Zhou authored
Bug: 863171 Change-Id: Ibf9c93098fef18bbda60370d6bdd771442debd9f Reviewed-on: https://chromium-review.googlesource.com/1145788Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#577209}
-
Maggie Chen authored
Due to some bad versions of Vulkan Runtime/Loader, there are crashes when Vulkan is called for the GPU supported Vulkan versions and extensions. From the logs, most vulkan-1.dll crashs are from the following versions. As of 7/23/2018, 0.0.0.0 - # of crashes: 6556 1.0.26.0 - # of crashes: 5890 1.0.33.0 - # of crashes: 12271 1.0.42.0 - # of crashes: 35749 1.0.42.1 - # of crashes: 68214 1.0.51.0 - # of crashes: 5152 The GPU could be from any vendors, but only some certain models would crash. For those that don't crash, they usually return failures upon GPU Vulkan support querying even though the GPU drivers can support it. The solution of this CL is to skip the Vulkan GPU info collection if bad Vulkan versions are detected. Bug:850384,863546 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I80cf1f7a45d6d501db678bdf18d98f5e95930e1d Reviewed-on: https://chromium-review.googlesource.com/1146984Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577208}
-
Daniele Castagna authored
This reverts commit d3408523. Reason for revert: A proper fix landed with https://crrev.com/c/1141356 Original change's description: > ozone/drm: No CTM on external monitor on i915 > > When using a CTM on i915 with some monitors, for some resolutions, > colors don't look right. > > This CL pretends external displays don't support HW CTM on i915. > > Bug: 848540 > Change-Id: Ibdf3d2ef4bc8e2fce5669086043d54f715263fab > Reviewed-on: https://chromium-review.googlesource.com/1128406 > Reviewed-by: Stéphane Marchesin <marcheu@chromium.org> > Commit-Queue: Daniele Castagna <dcastagna@chromium.org> > Cr-Commit-Position: refs/heads/master@{#573140} TBR=marcheu@chromium.org,dcastagna@chromium.org,afakhry@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 848540 Change-Id: I9a0ae39f46e629879f45f1d43e65a2e43da62505 Reviewed-on: https://chromium-review.googlesource.com/1146782Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#577207}
-
Daniel Rubery authored
If the window is closed after GetThreatDOMDetails finishes, but before OnReceivedThreatDOMDetails is run, |sender| is invalid. Instead, we observe FrameDeleted and track which frames are closed. Then we know to skip this RenderFrameHost when GetThreatDOMDetails runs. Bug: 817724, 860445 Change-Id: I2c8ed6c6a160264d91ca9b5a4760e53a7606f487 Reviewed-on: https://chromium-review.googlesource.com/1146997Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#577206}
-
Takumi Fujimoto authored
In a browser window without BrowserActionsContainer, there is no Cast toolbar icon to anchor the dialog to. So we anchor it to the top center of the window. Bug: 853371 Change-Id: If79016f0bd06e322db8b96621ab058e215ba5364 Reviewed-on: https://chromium-review.googlesource.com/1145237 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
-
Evan Stade authored
Bug: 854704 Change-Id: I00c25bee75cb69d36af1ab022847cf08100f5e88 Reviewed-on: https://chromium-review.googlesource.com/1144640Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#577204}
-
Ted Choc authored
BUG=800825 Change-Id: I8aaaf6a3e80cf6a0075fab4e73a60e7610d9b60d Reviewed-on: https://chromium-review.googlesource.com/1145861 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#577203}
-
Tiger Oakes authored
Continuation of work in bug 646094. Preparing to activate an errorprone check to flag context#getApplicationContext calls. The goal is to prevent storing the resulting context as a class property, and instead use ContextUtils. Bug: 846456 Change-Id: I2c3efdf6c0de690ee8a9a06a523c773722c07196 Reviewed-on: https://chromium-review.googlesource.com/1095997Reviewed-by:
-
Robert Liao authored
BUG=766926 Change-Id: I6d0302763687bbb4fe30682684ad85a2ac79f782 Reviewed-on: https://chromium-review.googlesource.com/1145674Reviewed-by:
-
Mohamed Amir Yosef authored
This allows more easy testing of the feature under development/ experimentation. Bug: 516866 Change-Id: I8418b9c61ad42214491c8b97edfcfe71f879b14f Reviewed-on: https://chromium-review.googlesource.com/1146818Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#577200}
-
Mohamed Amir Yosef authored
This CL restructures the two client browsers tests to be parameteized such that different tests can be enabled for USS incremently. Bug: 516866 Change-Id: Ifc7b8aa39992e30fef876d28b9b29f1419426972 Reviewed-on: https://chromium-review.googlesource.com/1146927Reviewed-by:
-
Artur Khachatryan authored
Branching Chrome v69. We are adding supporting of Chrome v69 and dropping supporting of Chrome v66 Change-Id: Id9b75ef78dd14da34f5165cbc6f64b3a188a5eb9 Reviewed-on: https://chromium-review.googlesource.com/1146993Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#577198}
-
James Cook authored
This tests ChromeVox integration with an out-of-process mojo app. Bug: 851578 Test: interactive_ui_tests Change-Id: I23a6cbf9bf93d675f5cc774e3df82eb4be5a334f Reviewed-on: https://chromium-review.googlesource.com/1132555 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#577197}
-
Allen Bauer authored
Refactor, minimize and clean up code. Moved the non-refresh/non-touch tab close button highlight colors to theme_properties.cc since there was a theme element. It's still using the close (X) icons instead of painting them since the coordinates of the strokes are very odd. Also, the "touch" version of the icon drawn by outlining the X with a complicated path. Once actual specs for the icon are available, the code can be updated. TBR=estade@chromium.org Bug: 838152 Change-Id: I2abca3be74f08649b3472f22fa31d0f897789e70 Reviewed-on: https://chromium-review.googlesource.com/1145590Reviewed-by:
Sidney San Martín <sdy@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
-
Scott Violet authored
It's no longer used. BUG=842365 TEST=none (removal of dead code only) Change-Id: I7ec73de3686591c4697ea6b58dfbeeb5961d0648 Reviewed-on: https://chromium-review.googlesource.com/1146983Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#577195}
-
Owen Min authored
Run the dialog modally on mac so that the dock and main menu are blocked. Bug: 865760 Change-Id: I734ba42a3110b6a71fa2aaae807ef9b1f763a90d Reviewed-on: https://chromium-review.googlesource.com/1135728 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#577194}
-
Chris Kuiper authored
This implements a caching logic to store the Android volume tables in native code. This avoids constant JNI calls that can slow things down too much leading to problems (see bug for more details). Bug: [internal] b/71871956 Test: Running on a several AThings Cast-enabled speakers, as well as unit-test. Change-Id: I5c769d0d98e3d4b00f01d74a0b0ded984993431e Reviewed-on: https://chromium-review.googlesource.com/1134589Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Chris Kuiper <ckuiper@chromium.org> Cr-Commit-Position: refs/heads/master@{#577193}
-
khmel@google.com authored
Suspended means state when an app was for some reason disabled on Android. For example as a result of policy apply. We should gray out such apps and prevent launch attempts. Key points of this CL * Register new state, suspended for ARC app OnAppReadyChanged renamed to OnAppStatesChanged and called all times when any ARC app state is changed. * ArcAppIconLoader is extended to apply gray effect in case app becomes suspended. * ArcAppModelBuilder was implemented before ArcAppIconLoader was introduced and it has own logic to handle ARC app icons. To prevent code duplication this builder is moved to ArcAppIconLoader as many other consumers in Chrome. TBR=kerrnel@chromium.org TBR=poromov@chromium.org BUG=863567 TEST=Manually + unit tests. Change-Id: Icfd2e2df37726b6abb76b0be7bf73da05e621b22 Reviewed-on: https://chromium-review.googlesource.com/1142687 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:Sergey Poromov <poromov@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#577192}
-
Tibor Goldschwendt authored
Forward keystore_name, keystore_password and keystore_path to android_apk_or_module to actually make use of those parameters. Bug: 866352 Change-Id: I8c330b46b4d0d4f33db40b2f6fef69dd2a3ce74a Reviewed-on: https://chromium-review.googlesource.com/1146901Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#577191}
-
Ken MacKay authored
Bug: internal b/111451219 Change-Id: I9ffa8324d3392cf7ced97465c4a65fdcd8c0c00c Reviewed-on: https://chromium-review.googlesource.com/1145793 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
-
Tommy C. Li authored
Seems like a long shot to fix the flakiness of this browser test, but this fixes an error anyways. Bug: 817270 Change-Id: I97bf32f5924f58e0965c80587eedd419a9739ca1 Reviewed-on: https://chromium-review.googlesource.com/1145863 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#577189}
-
Kyle Milka authored
Bug: 858885 Change-Id: I9ea772268411272c86e333ec4041b3e17b38f3af Reviewed-on: https://chromium-review.googlesource.com/1142541 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
-
