GitLab

R=neis@chromium.org,gsathya@chromium.org

Change-Id: Ia547dff4600ccb4618e791528a784771f05cb038
Reviewed-on: https://chromium-review.googlesource.com/518104
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475872}

It's not referenced at all.

Bug: None
Change-Id: I28ea78f8ab424564aae794690dfae737b9a7b054
Reviewed-on: https://chromium-review.googlesource.com/519202Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475871}

We early return in some cases but they must not happen because
 we use valid VisibleSelection which is not null.

// We can get into a state where the selection endpoints map to the same
// |VisiblePosition| when a selection is deleted because we don't yet
// the |FrameSelection| of text removal.
That's now not the case because we have SelectionController catching
 text modification.

BUG=708453

Review-Url: https://codereview.chromium.org/2910373002
Cr-Commit-Position: refs/heads/master@{#475870}

No flakes observed after https://codereview.chromium.org/2907193002.

TBR=schenney@chromium.org
BUG=727257

Review-Url: https://codereview.chromium.org/2917623002
Cr-Commit-Position: refs/heads/master@{#475869}

Spec: https://w3c.github.io/webappsec-csp/embedded/#subsume-source-expressions
Added wpt tests

Bug: 647588
Change-Id: If8098467158135b88a619a4420f13e98394af293
Reviewed-on: https://chromium-review.googlesource.com/518962
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475868}

Currently, the user-select property is a 'storage_only' field,
so it has no generated public getters/setters. This patch changes it to
a 'keyword' field so that its getters/setters can be generated as well.
We also generate the EUserSelect enum and use the generated
CSSValueID <-> EUserSelect mappings.

Diff of generated files:
https://gist.github.com/darrnshn/55f9abda5310dd37a0b60386f23e0e4a/revisions

BUG=628043

Review-Url: https://codereview.chromium.org/2911963004
Cr-Commit-Position: refs/heads/master@{#475867}

R=dgn@chromium.org

Bug: None
Change-Id: I95085bb6bca567676ae666ca8f410866f1cee598
Reviewed-on: https://chromium-review.googlesource.com/517491
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Anton Vayvod <avayvod@chromium.org>
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Reviewed-by: Anthony Berent <aberent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475866}

Add a use counter for the unshipped method registerProperty.

https: //drafts.css-houdini.org/css-properties-values-api-1/#the-registerproperty-function
Change-Id: Ib40364526ada0f62451082fd1d5cb3dc2ac0791c
Reviewed-on: https://chromium-review.googlesource.com/518704Reviewed-by: Rune Lillesveen <rune@opera.com>
Cr-Commit-Position: refs/heads/master@{#475865}

The benchmark is now superceeded by memory.long_running_dual_browser_test
(in contrib).

Also update the docs on memory benchmarks.

Bug: 713338
Change-Id: I41b4a5b520878805dfcb0cfd30e3eaa2830dc2d8
Reviewed-on: https://chromium-review.googlesource.com/518014Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475864}

This patch moves |{Left,Right}BoundaryOfLine()| to "SelectionModifier.cpp" as
file local functions since these functions are used in |SelectionModifier| class
only, for improving code health.

BUG=707656
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2912303002
Cr-Commit-Position: refs/heads/master@{#475863}

We can normally trust UpdateLogicalWidth() to detect and report size changes,
but this is not the case when printing, because
FrameView::ForceLayoutForPagination() changes the logical width of the
LayoutView behind our back.

BUG=702778

Review-Url: https://codereview.chromium.org/2908503003
Cr-Commit-Position: refs/heads/master@{#475862}

Rewrite base::Bind to base::BindOnce with base_bind_rewriters in //chrome/browser/chromeos/file_manager

This is a generated CL by a clang refactoring tool at //tools/clang/base_bind_rewriters.
It rewrites base::Bind to base::BindOnce where the resulting Callback is converted to
OnceCallback immediately.
E.g.:
  base::PostTask(FROM_HERE, base::Bind(&Foo));
is rewritten to:
  base::PostTask(FROM_HERE, base::BindOnce(&Foo));

In terms of the behavior change after the rewrite, the OnceCallback
implementation moves out the bound argument to the target function, unlike
Callback.

Bug: 554299
Change-Id: I54220a53ba53141700cecbbeed585a8c1627e0a8
Reviewed-on: https://chromium-review.googlesource.com/517466Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475861}

Remove history and password related code from 
PasswordStatisticsAggregator replace it with BrowsingDataCounters.

Bug: 716267
Change-Id: I35b3f4e312732306dcb4ff2a9906976f3f62223e
Reviewed-on: https://chromium-review.googlesource.com/503232Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475860}

This is a clone of https://codereview.chromium.org/2564663003 in
preparation for replacing the FakeServer impl with the LoopbackServer.
It should also improve the loopack server main purpose.

Original description of the clonned CL:
"Fake server now updates each model type's progress markers independently.

 Previously the fake server used to update all of the progress markers
 to the highest single version of an entity being returned in a
 GetUpdates response. This caused odd behaviors when clients asked for
 different sets of model types. This in turn resulted in tests failing
 when they never agreed on some progress marker's version that wasn't
 actually being actively updated.

 This change separates all model types version/progress markers in the
 fake server code. This should help clients that are being enabled
 mid-test to get match progress markers when priority and non-priority
 types are requested across separate GetUpdates messages.

 Also removed some special case logic around filtering deleted items. It
 is unclear what purpose that logic was serving."

BUG=651415
TEST=components_unittests, browser_tests

Review-Url: https://codereview.chromium.org/2910993002
Cr-Commit-Position: refs/heads/master@{#475859}

A recent spec change means that 0 is no longer supported as a valid value for angles.
https://github.com/w3c/csswg-drafts/issues/1162#issuecomment-293637767

As registerProperty has not yet shipped, we can reject unitless 0
angles without breaking legacy pages.

BUG=727195

Review-Url: https://codereview.chromium.org/2917573002
Cr-Commit-Position: refs/heads/master@{#475858}

This patch makes TextCombine an enum class for type safety.

BUG=684966

Review-Url: https://codereview.chromium.org/2914753002
Cr-Commit-Position: refs/heads/master@{#475857}

BUG=695275

Review-Url: https://codereview.chromium.org/2910813002
Cr-Commit-Position: refs/heads/master@{#475856}

This CL is just a refactoring so doesn't change any behavior.

BUG=697359
TEST=none

Review-Url: https://codereview.chromium.org/2906323002
Cr-Commit-Position: refs/heads/master@{#475855}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2893603003
Cr-Commit-Position: refs/heads/master@{#475854}

This CL mainly changes core/layout/api/SelectionState.*.
We won't increase the enum members so just go straight forward definition
 not using macro.
Also this CL changes SelectionStateBoth to SelectionState::kStartAndEnd
 because we have 5 members and 'both' is ambiguous.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2916493002
Cr-Commit-Position: refs/heads/master@{#475853}

Once I shipped the CL that enabled PerformanceTests/Editing but it was
 reverted because of bot failures:
https://chromium.googlesource.com/chromium/src.git/+/9ddf0ddf5dc89355220874dc29cc9ca1e3501839
Instead of ship all of perf tests under Editing/ at once,
  I try to ship one by one under DOM directory.

BUG=698661

Review-Url: https://codereview.chromium.org/2899793003
Cr-Commit-Position: refs/heads/master@{#475852}

BUG=636993
TBR=eae@chromium.org, atotic@chromium.org, ikilpatrick@chromium.org

Review-Url: https://codereview.chromium.org/2910393002
Cr-Commit-Position: refs/heads/master@{#475851}

This patch expands |TextIterator::Initialize()| into constructor where the
only call sites to simplify code for improving code health.

This patch is a follow-up of patch[1], which makes call sites of
|Initialize()| to just one.

[1] http://crrev.com/2912053002: Call TextIterator constructor with proper range

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2919453002
Cr-Commit-Position: refs/heads/master@{#475850}

The "updatecheck" tag is unnecessary when we want to fetch default
settings. Additionally its presence causes the servers to infer that
Chrome needs to be updated.

BUG=727829
TBR=vasilii@chromium.org

Review-Url: https://codereview.chromium.org/2908073006
Cr-Commit-Position: refs/heads/master@{#475849}

Bug: 712963
Change-Id: I629e4bc40e23b7fad8efe2b0278254b171e2853f
Reviewed-on: https://chromium-review.googlesource.com/518762Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475848}

NV8 characters are invalid in IDN 2008. Four of them are currently
allowed. ( https://goo.gl/LSgs1R )

  [:Idn_2008β=NV8:] & [:Identifier_Statusβ=Allowed:]

Mozilla began to block them earlier this year.

Besides, block 2 quote-like characters that are easy to miss when
put next to other characters.

Bug: chromium:678812
Test: components_unittests --gtest_filter=*IDNToUni*
Change-Id: I994e123335df5446a7a3f41bbb48326319aa1c5f
Reviewed-on: https://chromium-review.googlesource.com/517505
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475847}

This CL also moves the Launch.Modes histogram and its enum into the
Chromium repo.

BUG=717091
R=pkasting@chromium.org

Review-Url: https://codereview.chromium.org/2902963002
Cr-Commit-Position: refs/heads/master@{#475846}

This can be replaced with WebURLRequest::FetchRequestMode which is more
readable and well corresponds to the spec terms.

- Merged the signal indicated by kForcePrelight into fetch_request_mode
- Removed lines setting preflight_policy to the default value
  kConsiderPreflight
- Removed preflight_policy from NotificationImageLoader as it's
  meaningless when the mode is set to NoCORS

Bug: 727596
Change-Id: I5da2b549e4e497f371b21f7acee53920e29b3acc
Reviewed-on: https://chromium-review.googlesource.com/515182Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Brad Nelson <bradnelson@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475845}

BUG=n/a
TEST=n/a; no behavioral change

Review-Url: https://codereview.chromium.org/2913953002
Cr-Commit-Position: refs/heads/master@{#475844}

BUG=724932

Review-Url: https://codereview.chromium.org/2895123002
Cr-Commit-Position: refs/heads/master@{#475843}

Mac OS UI fonts renders U+0620 as blank. (radar/32458012)

Bug: chromium:725660
Test: components_unittests --gtest_filter=*IDNToUni*
Change-Id: Ib7d678aae0379e8ac53064663660a7840e5fd3bd
Reviewed-on: https://chromium-review.googlesource.com/517669
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475842}

Android API allows these methods to return null, but converters from
jni_string.h expect jstrings to be non-null with a DCHECK. See
https://developer.android.com/reference/android/hardware/usb/UsbDevice.html
> Returns ... or null if the property could not be read

R=reillyg@chromium.org
TEST=Don't crash in debug on null jstring DCHECK on KeyedService creation, or
any other scenarios that call UsbDeviceAndroid::Create. Was reproducible only
on certain devices, like Motorola Nexus 6.

Review-Url: https://codereview.chromium.org/2914453002
Cr-Commit-Position: refs/heads/master@{#475841}

Currently there's a lot of duplicated code in all the MarkerType-specific
DocumentMarkerController::Add*Marker() methods. This CL factors out the common
logic into an AddMarkerInternal() method, and renames the existing (private)
AddMarker() method to AddMarkerToNode().

This CL also adds some filtering to avoid constructing DocumentMarkers with
start/end offsets that are the same (the current version of the code constructs
these DocumentMarkers, then filters them out before actually adding them), or
when the range returned by TextIterator is not a text node (we don't currently
do this filtering).

BUG=707867

Review-Url: https://codereview.chromium.org/2916463002
Cr-Commit-Position: refs/heads/master@{#475840}

The test RenderThreadImplBrowserTest.InputHandlerManagerDestroyedAfterCompositorThread
is flaky on Windows, with first obvservation being
https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/24771

BUG=728034
TBR=skyostil@chromium.org

Change-Id: Icf3a073407eb8eaa13c111987544d887bcac68ca
Reviewed-on: https://chromium-review.googlesource.com/518822Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475839}

This change removes usages of raw pointers where the underlying data has
been moved from. Currently this code still works fine, but it would
result in uses-after-free with the upcoming change to
Value::DictStorage.

BUG=646113

Change-Id: I99c1498c4c157fbc60ccc240dc243056acb8be13
Reviewed-on: https://chromium-review.googlesource.com/518129
Commit-Queue: jdoerrie <jdoerrie@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475838}

This CL adds a base::SharedMemoryHandle getter to gpu::BufferBacking.
The getter will be used by gpu::BufferBacking users when OnMemoryDump is
called to create base::SharedMemory dumps.

This is part of work for exposing SharedMemory usages on tracing
memory-infra dumps.

Design doc: https://docs.google.com/document/d/16Mi5_puxKgQ-9IX7ANfbji0WiqBCK3yrnJ0Qi2wa3w0/edit#heading=h.lofdeze1a2hr

Note: This can conflict with https://codereview.chromium.org/2912723002/

BUG=604726
TEST=gpu_unittests --gtest_filter=Buffer.*
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2909003002
Cr-Commit-Position: refs/heads/master@{#475837}

Bug: 727991
Change-Id: Ife0e27562727cf08ff40615baf3f024ed621534d
Reviewed-on: https://chromium-review.googlesource.com/518745Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475836}

Disable a flaky test InputRouterImplTest.AckedTouchEventState in content_unittests on Win, Linux and ChromiumOS

TBR=aelias@chromium.org

Bug: 728025
Change-Id: Icb1df3b7e353b4626c9ba263dd3b4c64dcd04276
Reviewed-on: https://chromium-review.googlesource.com/518783
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475835}

:host and :host-context() should not have implicit type selectors pre-
pended for universal rules with default @namespace. Default @namespace
applies to type and universal selectors inside :host() and
:host-context(), but a default @namespace rule should not affect :host.
That is, :host matches the host element regardless of any @namespace
rules.

R=hayato@chromium.org,kochi@chromium.org
BUG=727603

Change-Id: I78d2919275aa6bdc4fdc5b02a4772d2352819258
Reviewed-on: https://chromium-review.googlesource.com/518019Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Rune Lillesveen <rune@opera.com>
Cr-Commit-Position: refs/heads/master@{#475834}

Currently the bookmark bubble builds its own button row, but that's
unnecessary and causes it to miss out on shared framework code for
layout and button style.

BUG=726187

Review-Url: https://codereview.chromium.org/2908963002
Cr-Commit-Position: refs/heads/master@{#475833}