- 06 Feb, 2020 40 commits
-
-
Natalie Chouinard authored
Move Sync settings alongside Sync code. Bug: 1047357 Change-Id: I66839fc3a913ff3993a24afef051f5626f87ef43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040444Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#739046}
-
Robert Flack authored
The devtools frontend roll in https://chromium-review.googlesource.com/c/chromium/src/+/2038189 broke web_tests text output on debug bot runs. TBR=tvanderlippe@chromium.org Bug: 1049641 Change-Id: I12f91f3ed99d1d945b2fd780dcd69c7cf52563a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041532Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#739045}
-
Nate Fischer authored
This adds a targetSdk quirk for WebView's CookieManager API. Starting for apps which target Android R, WebView will no longer accept cookies for insecure ('http' scheme) URLs which also specify the 'Secure' cookie directive. While this changed for Chrome in M58 (https://www.chromestatus.com/feature/4506322921848832), WebView has been working around this by fixing up the URL's scheme to 'https'. WebView will continue to do so for apps targeting < R. This adds a histogram to track the new case. Bug: 933981 Test: run_webview_instrumentation_test_apk -f CookieManagerTest#testSetSecureCookieForHttpUrl* Change-Id: Ie31f02911d38984983fdf4afeb4d6e1eb4f7d094 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040685Reviewed-by:Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#739044}
-
Xianzhu Wang authored
When blink directly sets scroll offset in the scroll tree, we need to set the associated cc::Layer's NeedsPushProperties to ensure update of cc::LayerImpl's scroll related properties (see cc::LayerImpl::UpdateScrollable()). This reverts the change about cc::LayerTreeHost::LayerByElementId() in https://chromium-review.googlesource.com/c/chromium/src/+/2020554 because we still need it in layer list mode. Bug: 1048113 Change-Id: I686beebcf54e96cc517700c0f987aaceec880c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036834Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#739043}
-
Peter Wen authored
Java targets use the contents of the res_sources_path file of all their dependencies to determine the resource_dirs value in the java target's build config. Thus these files need to be in its depfile through all_inputs. Also remove unused resource directory shortcut, and build/android/empty* Bug: 1049296 Change-Id: Icc8375bdeca1a4ba2d954a964a62bf852a81b788 Fixed: 1049296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042405 Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#739042}
-
Luke Zielinski authored
Bug: 1049607 Change-Id: Id99fb07fc85539dad0d4928761e1abe2857541fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042371 Auto-Submit: Luke Z <lpz@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#739041}
-
Mustafa Emre Acer authored
The presubmit code for translation screenshots parses grd and grdp files modified in the CL. It does this by referring to the old and new contents of the files passed to it by the presubmit. grd files can refer to grdp files via <part> tags. This causes the messages in the grdp file to be included in the grd file. If a modified grd file's old contents refers to a now renamed or deleted grdp file, grd reader fails to open the grdp and crashes. This CL fixes this by ignoring <part> tags while loading grd files. This should be safe: The presubmit processes grdp files separately, so all grdp files should still be processed, just not when loading grd files. Additionally, grdp files cannot contain part files, so ignoring the tag while loading grdp files should also be safe. Bug: 1047487 Change-Id: I3d79aa028c4ae360d74a437a019628d0bdab494a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037027Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#739040}
-
Alex Ilin authored
This CL adds a new field to OAuth2MintTokenConsentResult proto, modifies the parsing function and plumbs this new field to GaiaRemoteConsentFlow::Delegate::OnGaiaRemoteConsentFlowApproved(). IdentityGetAuthTokenFunction is going to remember this gaia id and reuse the same account for the next calls. The usage of the gaia id will be added in future CLs. Bug: 1026237 Change-Id: Ieb407ee26d8b2ab9e4a4f4bb3c164f5c88c37440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042097Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#739039}
-
Rohit Rao authored
This will allow us to add dependencies to ensure that EG2 host apps are always compiled alongside their test modules. Previously, bots would incrementally compile only the test modules and then fail when the host app wasn't present. BUG=1019533 Change-Id: I42fca4f6767fba723dcb425b6485a1211c714b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949847 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#739038}
-
Jae Hoon Kim authored
BUG=b:145814572 Change-Id: I837389427d673c564fc2b3f147f8f56ac04e01ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036548Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Jae Hoon Kim <kimjae@chromium.org> Auto-Submit: Jae Hoon Kim <kimjae@chromium.org> Cr-Commit-Position: refs/heads/master@{#739037}
-
Manu Cornet authored
Split the |UpdateCollapseState| function in two: one const function |CalculateCollapseState| that returns a collapse state and the existing |UpdateCollapseState| that returns void. Also move the logic that alters the collapse state inside |CalculateButtonVisibilityForCollapsedState| out of that function and place it where it belongs. Bug: 1048119 Change-Id: I49eaa86f914cf9910b47afde698aa82c8eaa0aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040955 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#739036}
-
Steve Kobes authored
This is a single browser test that verifies CLS metric values through four reporting mechanisms (web perf API, trace event, UKM, and UMA). Bug: 1045064 Change-Id: Ie1616e961b2771e792d9d2b15babaaa2125822d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943427Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#739035}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cc21d0c1f2ce..782a957f83c0 git log cc21d0c1f2ce..782a957f83c0 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 bungeman@google.com Update fontscalerdistortable to onOnceBeforeDraw. 2020-02-06 brianosman@google.com Remove SkMaxScalar and SkMinScalar 2020-02-06 egdaniel@google.com Switch SkImage_Base asTextureProxyRef to return view instead. 2020-02-06 tdenniston@google.com Reland: Initial checkin of GM verifier framework Created with: gclient setdep -r src/third_party/skia@782a957f83c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: scroggo@google.com Change-Id: I9774f80862e32f00f906f64b1c9199fb79103960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042238Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#739034}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d48320747592..74e27c36bc28 Created with: gclient setdep -r src-internal@74e27c36bc28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1010176 Tbr: jbudorick@google.com Change-Id: I65306687d4263b956435579a8298c32f94a00ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042241Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#739033}
-
Kevin Babbitt authored
On non-desktop Windows SKUs such as Hololens, CreateStdAccessibleObject() will fail since MSAA is not available. That failure would cause us to exit LegacyRenderWidgetHostHWND::Init() before creating a UI Automation fragment root. Later on, an inbound UI Automation call would ask a web content fragment for its fragment root, we would attempt to look it up and find nothing, and crash. The fix is to ignore the failure from CreateStdAccessibleObject(). There are no subsequent calls in Init() that depended on it succeeding. I also took the opportunity to switch the return value to type void since the only caller wasn't doing anything with this information anyway. Bug: 928811 Change-Id: I11f63139575de131f41733be6f73192c118ec792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037963 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Cliff Smolinsky <cliffsmo@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#739032}
-
Rouslan Solomakhin authored
This patch adds a payment app factory for 3rd party native Android payment apps in accordance with the design at: https://bit.ly/cross-platform-pay-app-factory The factory is responsible for finding the payment apps (AndroidPaymentApp), filtering out apps that don't support the requested methods, verifying ability to use the method names, and querying the IS_READY_TO_PAY service when necessary. Bug: 1022512 Change-Id: Id3862e8a7e1aa6ace6ce70adde56cd90c20c23fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025229Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#739031}
-
Vasiliy Telezhnikov authored
GLPixelBufferRGBAResult in GLRendererCopier hold reference to context provider. When the results are sent to different thread we force all GPU work to happen before in ReadPixelsWorkflow::Finish, but we still hold the reference. If the results will outlive the SkiaOutputSurfaceImplOnGpu it will be the last reference and DirectContextProvider will be destroyed on a wrong thread. This CL fixes this by dropping reference to context_provider when we don't need it anymore. Bug: 1035881 Change-Id: I6e0bfe7013a61f96ec7f33d40bae377d6831ffc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041800Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#739030}
-
Mike Klein authored
SkTypes.h is the canonical way to get to this stuff. Change-Id: I3708082d0a4f2f5646f1040e83cce1c8b9967e25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039131Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Mike Klein <mtklein@google.com> Cr-Commit-Position: refs/heads/master@{#739029}
-
Kyle Horimoto authored
After design discussions with jamescook@, we've decided to remove this enum, since it's not strictly needed for the metrics we're trying to compute (number of navigations until a setting has changed). This complexity is unnecessary at this time. Bug: 1047062 Change-Id: I6280115e051f9bbd67434e5a5faf25c1bc03854d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040913 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#739028}
-
Theodore Olsauskas-Warren authored
As part of the privacy settings redesign, the capability to display recently changed permissions to the user is required. This CL introduces the a handler to enable querying for this information from JS. The GetRecentSitePermissions provides the most recent permissions changes grouped by at most N unique origin/[incognito, normal] combinations. Existing functionality which is reused from the GetAllSites handler is also refactored out. Bug: 1032584 Change-Id: I885c859d455bc49d8ec9d91bf3101cf337c4ae51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002577 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#739027}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/065348503c2e..4f68f5398d7f git log 065348503c2e..4f68f5398d7f --date=short --first-parent --format='%ad %ae %s' 2020-02-06 sprang@webrtc.org Remove PlayoutDelayOracle and make RtpSenderVideo guarantee delivery Created with: gclient setdep -r src/third_party/webrtc@4f68f5398d7f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iaeae7fdc7e992f09f8e6dd178d8d1f27ad1cd364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042239Reviewed-by:
-
Victor Costan authored
This CL makes the blink::CachedStorageArea constructor public and removes the Create*() factory functions. The functions recently became identical, with the exception of the blink::CacheStorageArea::AreaType value passed to the constructor. This small refactoring removes one layer of indirection, as well as the use of the bare new operator in the factory functions. Change-Id: I0e6606f3021771c712a79878d681290c3862acc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038035 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#739025}
-
Ayu Ishii authored
Bug: 1007677 Change-Id: Icb307b143a5776768d7b23e3c2d925b417d0dafa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040672Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#739024}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I150445ba27465e8949f6aafc954f5629ff075813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042242Reviewed-by:
-
Camille Lamy authored
This CL adds a flag to block external requests coming from insecure contexts. Blocking these kind of requests is a first step towards implementing CORS-RFC1918 which will require CORS preflight for all external requests. Bug: 986744 Change-Id: I9318c8484d66f01612f5ddfdda26974066253720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019105 Commit-Queue: Camille Lamy <clamy@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#739022}
-
Elly Fong-Jones authored
This change moves the ExtensionInstalledBubble's model, which was previously a collection of anonymous functions in the Views implementation, into //cbui/extensions as a separate class with unit tests. It also changes the Views implementation to use this new class. Change-Id: I3e379db88fcd4d40014c74f14c67b155dde3ac63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007508 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#739021}
-
Saurabh Nijhara authored
This CL marks the proto for the deprecated device policy SupervisedUsersEnabled as deprecated. The policy SupervisedUsersEnabled has already been deprecated in CL 1221253 and the code for reading from the proto SupervisedUsersSettingsProto was removed in the CL 1224033. Bug: 834488 Change-Id: I067708d9e3eb1defb5b92b9c1276a39998316495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038773Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#739020}
-
mark a. foltz authored
This API was not implemented in the Chrome task runner. The implementation will allow us to make the API pure virtual upstream. Change-Id: I44598d5c0410ed6019de7c8042bfa2ae54b96544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040112Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#739019}
-
Livvie Lin authored
Bug: 987407 Change-Id: Ifb8927a6cfefee1a40b91130677d6ce1b90c3dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036544Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#739018}
-
Michael Thiessen authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/2039301, fixing the NPE in WebViewChromium. Bug: 783819 Change-Id: I35bde03e1b58c13323b4a085bcde065f4b01f0be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042370Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#739017}
-
Philip Rogers authored
This patch fixes a bug in https://crrev.com/732194 where subframes that were cross-origin to their parent were not composited. This mistake was due to a misreading of Frame::IsCrossOriginSubframe which returns true if the frame is cross origin to the main frame. "IsCrossOriginSubframe" has been renamed to "IsCrossOriginToMainFrame" in https://crrev.com/737198 to prevent similar mistakes. This patch adds Frame::IsCrossOriginToParentFrame and uses it when deciding whether to composite an iframe. Bug: 1047497, 1014273 Change-Id: Iecef138be2b083953559fb856d60939cdfbc8c60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034031 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#739016}
-
Elly Fong-Jones authored
This class has been around since the initial commit. This change makes it not exit(1) on errors, then adds test coverage for most of it. Bug: None Change-Id: I5c366415c34abaa6bb90ce4657f2f94c3a45a1ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040211Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#739015}
-
Sigurdur Asgeirsson authored
Bug: 1044707 Change-Id: I13352b60258ac48c58473261fb0acaca30719fbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033857Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#739014}
-
Hongbo Song authored
On render side, the DelegatingUkmRecorder doesn't work. To record UKM, we need the Document::UkmRecorder. This CL is for changing the ukm recorder for input delay UKM. Change-Id: Iaaaa47c478d9bcf5e5f43a0cbcc81483cb4ee27a Bug: 1042004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035307Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Hongbo Song <hbsong@google.com> Cr-Commit-Position: refs/heads/master@{#739013}
-
Joey Arhar authored
This change implements https://html.spec.whatwg.org/C/#plan-to-navigate by adding an async step to form submissions which was removed in https://crrev.com/c/1520353. This patch also reverts https://crrev.com/c/1850358 which was a temporary fix for duplicate form submissions caused by sync form submissions. Now that they are async with this patch again, the temporary fix is no longer needed. Bug: 1013385 Change-Id: Ieec850c9684c796ac0582917494ff4dc3ac8f1b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922699Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Brian White authored
Updates the expires_after attribute for 32 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 30 days of 2020-08-10. Change-Id: I0c255c53b6a2e4c8addacb16b053966c9b147780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042350 Commit-Queue: Brian White <bcwhite@google.com> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
-
Yue Zhang authored
Currently, when triggering contents in bottom sheet, the popup tab strip shows above bottom sheet, which is unexpected. This CL makes popup tab strip hides when bottom sheet shows and restores its original visibility when bottom sheet hides. Bug: 1045974 Change-Id: Icd5fe051d9eaa2cdff6da22ae19e4515cdde8738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036936Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#739010}
-
Maksim Moskvitin authored
This method does nothing what won't be done by dtor and always followed by destruction. Bug: 1020117 Change-Id: I1c7a615a0127211a413953fc42da0951aa28c53f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041756Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#739009}
-
Daniel Cheng authored
This patch splits out: - accessibility - canvas - mediastream - netinfo - peerconnection - permissions - quota - serial - service_worker - speech - vibration - video_raf - webaudio - xr These modules were prioritized in order to reduce the number of special cases in modules_idl_files.gni. Bug: 1048907 Change-Id: If8d215ed00ad2decb83bc916205c0ac611d9c37c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040956 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#739008}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/2d70e98deab2..95c414ffee64 git log 2d70e98deab2..95c414ffee64 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 johnkslang@users.noreply.github.com Merge pull request #2079 from dneto0/warnings Created with: gclient setdep -r src/third_party/glslang/src@95c414ffee64 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,cnorthrop@google.com Change-Id: Iab4dffce77bd489a432187308f551f5bb381efe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042236Reviewed-by:
-
