GitLab

Remove usage of DISALLOW_COPY_AND_ASSIGN from documentation.

styleguide/c++/c++-dos-and-donts.md:
'DISALLOW_COPY_AND_ASSIGN` is deprecated.  For
a non-copyable/movable type, delete the copy operations (the move
operations will be implicitly deleted); otherwise, declare either
copy operations, move operations, or both (a non-declared pair
will be implicitly deleted).  Always declare or delete both
construction and assignment, not just one (which can introduce
subtle bugs).

Change-Id: I2d2e0ecf95c3ef764dc90d49c674625c15432d87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404905Reviewed-by: Tal Pressman <talp@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#806782}

Bug: internal b/160616014
Change-Id: If764ba82678059a21cda3d9ecd44c7dbe620fb92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410926
Auto-Submit: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806781}

This will be used by crash restoration logic to know which sessions
to backup for restoration.

Bug: 1126311
Change-Id: I064d1da30bfcfc368539240b7c9c9a2f65490d1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399886Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806780}

Bug: 1127549
Change-Id: Ie996c71a86bd6303f8e82c20086ad34711b89e80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407074Reviewed-by: Rakesh Soma <rakeshsoma@google.com>
Commit-Queue: Yusuf Sengul <yusufsn@google.com>
Cr-Commit-Position: refs/heads/master@{#806779}

Choosing to disable 3 tests failing on an assert, because an alternative
is to revert a crash fix. This fails on assert which is compiled out.

TBR=peconn@chromium.org

Bug: 1128073
Change-Id: Icc5667f4ad1504c7776bc06af010e9f8d94b5a41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410923Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806778}

Add partial support to the largeBlobs CTAP2.1 command at the device
level. In particular, implement chunking, reading and writing arbitrary
blobs. The virtual authenticator command is also implemented in order to
test the feature.

Missing features are encrypting & compressing the blobs and pin token.

Nothing is wired to the web yet.

This is part of the large blob storage extension implementation.
https://w3c.github.io/webauthn/#sctn-large-blob-extension

Bug: 1114875
Change-Id: I2f85c0b0b17b2054ad5bc0af69432d1765b6f2f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388992
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#806777}

This is needed to look up the Metal cache directory, which is used for
graphics acceleration by various system frameworks.

Bug: 1126350
Change-Id: I79e05c603859aa49082fbbbc09c1da9b4ae3a990
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411151
Auto-Submit: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806776}

R=khorimoto@chromium.org

Bug: 1045266
Test: NetworkComponentsNetworkProxyInputTest*
Change-Id: I45813304a2c638cd13bb64a46e2fe14a23037783
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406666
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806775}

Bug: 1099917
Change-Id: I828357cb3123ffbf574b25756082b7f5f966f3c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405532Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Commit-Queue: Roman Arora <romanarora@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806774}

The sample callback was heavily convolved with lots of if:s and really
hard to read with all special cases. This change cleans it up.

Bug: 1127791
Change-Id: Id9cb4b4994288667d3fa22e5dfd4ade095853d65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410400
Commit-Queue: Markus Handell <handellm@google.com>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806773}

A bit of cpp lint cleanup, no functional changes.

Bug: 1010217
Change-Id: I7b713e20ae81a896537f0683b1ba31a8465c9d5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408179Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806772}

This is a refinement of [1] [2] [3] [4]:

1. MathML elements should not try to force NG layout when using a
  non-math display.
2. Really make ShouldForceNGLayout() override ShouldForceLegacyLayout()
   ([1] was only doing that for the inherited child context).
3. Make MathML elements class keep handling the case of a forced legacy
  layout, but only on non-math display values. Note that this check is
  not necessary in LayoutObjectFactory::CreateMath which is only called
  for math display values.
4. Allow to override the display of the <math> tag too (it's unclear
   why [3] had a special case and that does not match the spec).

Ideally, 3. can be removed when we completely switch to NG layout for
all displays. New tests are added to verify related crashes found by
clusterfuzz and check overriding of the layout MathML elements with
various display values.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2398702
[2] https://chromium-review.googlesource.com/c/chromium/src/+/2397949
[3] https://chromium-review.googlesource.com/c/chromium/src/+/1985766
[4] https://chromium-review.googlesource.com/c/chromium/src/+/1917207

Bug: 6606, 1127628, 1127407, 1127222
Change-Id: I62b0ef4de623f4eb93184a1cecce598905160dad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409957
Commit-Queue: Frédéric Wang <fwang@igalia.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806771}

After OOBE sign-in, FamilyUserMetricsProvider::
ProvideCurrentSessionData() sometimes gets called before the
AccountManager has been initialized. Check for this scenario and
return prematurely to avoid throwing a DCHECK.

Bug: 1103077,1127838
Change-Id: I8cda0daccdfe3398e1891ecd4f4663ae71fea742
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404409
Commit-Queue: Toby Huang <tobyhuang@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806770}

Move all files from package org.chromium.policy to
org.chromium.components.policy as other java code in //components.

Change-Id: I1be82a80e38d7b2cdacddeedd3d1e9d6f8b9b556
Bug: 1127469
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406526Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806769}

- There was no flake in the test history on FYI bot recently,
- There is no stack trace available from the bot.
- Not locally reproducible.

Re-enable this test to get the stack traces and see if flakiness can
still be reproduced.

        50 times on emulator out of 50 trials

Tested: passed AndroidScrollIntegrationTest#testTouchScrollCanBeAlteredByUi
Bug: 813837
Change-Id: Ibb240d0720a223c20f8d815c0c0fa6d4246a7e8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411147
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806768}

Invalidate send and receive surfaces to make sure we start or stop
advertising based on changes to screen lock state.

Bug: b:166174379
Bug: 1119993
Change-Id: Ie7490d888b42e4c4aac783216b54490476f53aa5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392703
Commit-Queue: Michael Hansen <hansenmichael@google.com>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806767}

TBR=rsleevi@chromium.org

Change-Id: Ide799d50c22a45123b3a15fd6cff731176da6cb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410522Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Nick Harper <nharper@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806766}

Add FeaturePromoSnoozeService that handles the dismiss and snooze of IPH
bubble by the user. This service uses PrefService as the storage for
snoozed IPH status.

This service is a middleware between IPH frontend and backend. The
frontend asks it for IPH display permission before asking the backend.
The frontend should notify this service when the user clicks dismiss or
snooze button on the IPH bubble.

Note that in addition to snooze, this service handles dismiss.
Otherwise, we will have to change backend to incorporate dismiss logic.

Bug: 1121399
Change-Id: Ie0817a1ec15ff835344aa95dc17a27c0ae6f4338
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398979Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Wei Li <weili@chromium.org>
Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
Auto-Submit: Keren Zhu <kerenzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806765}

Bug: 1090917, 1022172
Change-Id: I109106e44ffddda58e1418cf438ab09eed20f038
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324994
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806764}

Bug: 1127495
Change-Id: I34bc0d93516c4a4cb7fda7b9de049fe08ddc6112
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406934Reviewed-by: Min Chen <minch@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Yulun Wu <yulunwu@chromium.org>
Commit-Queue: Yulun Wu <yulunwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806763}

Expecting a chrome://newtab/ url to check for a new tab page could cause
tests to be flaky because the NTP URL could be chrome://newtab/ or
chrome-search://local-ntp/local-ntp.html. This change makes the
expectation use the GetFinalNtpUrl util instead to ensure the correct
URL is expected.

Bug: 1078301
Change-Id: I9cc31a7399a7b79cd832327c67f59959ef97e5eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391601
Commit-Queue: Lu Huang <luhua@microsoft.com>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806762}

As per suggestion [1], this switches exo::Seat's last_location_ variable
and SetLastLocation method to use gfx::PointF to handle last pointer
location. It'll be used in a followup CL as part of the extended-drag
protocol extension implementation in Exo [2].

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2307653/comment/45820a22_e6516518/
[2] https://chromium-review.googlesource.com/c/chromium/src/+/2401280

R=oshima@chromium.org

Bug: 1099418
Change-Id: I3be933f8788f748ff0324760d8f98b70e13b8d96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410664
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Auto-Submit: Nick Yamane <nickdiego@igalia.com>
Reviewed-by: Mitsuru Oshima (Slow: gardener) <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806761}

Deduplicate code disables/restores window animations by exporting
ash::ScopedAnimationDisabler and reusing it in exo::ShellSurface
implementation.

It will also be reused in extended-drag Wayland protocol extension
implementation, in a followup upcoming CL [1].

[1] https://bugs.chromium.org/p/chromium/issues/detail?id=1099418

R=oshima@chromium.org

Bug: 1099418
Change-Id: I463e1c1942e8667105f7a87703b0f075321b2be0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410839
Auto-Submit: Nick Yamane <nickdiego@igalia.com>
Commit-Queue: Mitsuru Oshima (Slow: gardener) <oshima@chromium.org>
Reviewed-by: Mitsuru Oshima (Slow: gardener) <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806760}

Bug: b/168511137
Change-Id: I024ac632134e1f897015e65bf68d36ca79aa58dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410897Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806759}

BUG=chromium:1124819,chromium:1125323,b:168513070

Change-Id: I4ece2eeae9137334baedae3029d92df60236988c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410355
Commit-Queue: Brian Malcolm <bmalcolm@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806758}

Two changes to PipelineReporter traces:
 . Set |state| correctly for partial updates.
 . For dropped (or partially dropped) frames, report whether
   the frame affects smoothness or not.

BUG=1125152

Change-Id: If282c20bc19931b14b3f71c589e9fa78e25e4710
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410618
Commit-Queue: Xida Chen <xidachen@chromium.org>
Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806757}

This change introduces the ads intervention API - an API
that tracks the triggered ads interventions for a site
tied to a user's profile. This API can be used to activate
the subresource filter to block ads on sites that have had
interventions triggered within the last 3 days.

This change instantiates the ads intervention framework
in dry run mode - it only records metrics and does not
block any ads for users. It simulates ad blocking in
metrics by only recording an intervention once per
3 days.

BUG=1099741

Change-Id: I6474db65414789877fb8bb1c06ae1e8d64298508
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243254
Commit-Queue: Justin Miron <justinmiron@google.com>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806756}

This CL removes two unused string suppressions for strings that are now
used.

Bug: 1114311
Change-Id: I40cdc2af0509f55ba95fbd5b30cc89ba2dc1274f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410724
Auto-Submit: Trevor  Perrier <perrier@chromium.org>
Reviewed-by: Megan Jablonski <megjablon@chromium.org>
Commit-Queue: Megan Jablonski <megjablon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806755}

The first attempt at making the referrer chain portal aware involved
creating a synthesized navigation event upon portal activation to tie
the host and portal contents together. However, this was incomplete
w.r.t. redirects within portals.

We now make the association with a portal contents upon its initial
navigation which will allow the referrer chain to capture any redirects
before the activation along with navigations after activation. This
effectively treats portal creation like window.open w.r.t. the referrer
chain.

Bug: 1096115, 1103235
Change-Id: I4aa63380fb3a1c7840a331af882d39f64215a511
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293635
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806754}

Add espresso tests for button actions available in crash UI:
- Report an uploaded crash.
- Force upload a skipped or a pending crash.
- Refresh the crash list.

This adds a delegate class to mock network checks and upload job.

Fixed: 1106313
Test: run_webview_instrumentation_test_apk -f "*android_webview.devui*"
Change-Id: Ic513f8cd9194ab1873849076549a2ad959a8f9c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392254
Commit-Queue: Hazem Ashmawy <hazems@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806753}

I missed these uses in crrev.com/c/2336013.

Bug: 1069498
Change-Id: Ie86e1694a86e40f015296d66e6d68177283755f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406539Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806752}

http://crrev.com/c/2391942 removes the initial set of BottomControls
visibility when BottomControlsCoordinator is created. This leads to a
visual bug that the empty BottomControls is visible right after app
launch. This CL fixes this issue by setting the BottomControls
visibility to false by default.

Bug: 1127776
Change-Id: I740b04bc4293b3f48accd021376fadb74752b4c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410721Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806751}

This dialog is one of a handful where AcceptDialog() can be called
with the dialog's "Ok" button disabled during a test. This isn't
possible in production but misbehaved tests are preventing that from
being asserted. To fix that, ensure that the Ok button here is
enabled on the test accept path.

This change also adds a test to validate this behavior locally.

Bug: 1075649
Change-Id: I39321f34692a929c2edf9e9e65c22687685d561b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399126Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806750}

While the flag for limiting windows to the current active desk is
enabled, if a user swaps desks while the window cycle list is open, the
contents will not update to the new active desk.

This CL makes the window cycle list reset if it is open and a desk
swap occurs while the aforementioned flag is enabled.

Test: LimitedWindowCycleControllerTest.CycleShowsActiveDeskWindows
Bug: 1067327
Change-Id: I9d940ad82a2f05ab1d2fd9e8c5115d5f3eda9826
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398559
Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806749}

Bug: None
Change-Id: I9a4fd6ff2c68bc228efda58d6e332218c729193a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410667Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806748}

- DiscoverFeedService is now in charge of creating and owning a single
instance of FeedMetricsRecorder.
- Add the FeedMetricsRecorder to DiscoverFeedConfig
- Adds engagement recording events

Bug: 1085419, 1127557
Change-Id: Iaf3cdcca850babb54bc8149050a4ebd6c3f8d68c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406715
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806747}

This CL adds and option to the TabGridDialog toolbar menu to update
the group name. Also, this CL cleans up a bit the dependency
relationship between title text focus and keyboard visibility, so that
keyboard visibility is controlled by title text focus. When title gains
focus, we try to show the keyboard; when title text loses focus, we
hide the keyboard.

Apart from the above rule of thumb, we handle three cases specifically:

* When "Edit group name" item is selected in dialog menu, we request
  focus programmatically which also shows the keyboard.
* When keyboard hides but the title still has focus, we manually clear
  the focus.
* When dialog hides, we always clear focus on dialog title.

This CL is gated by Finch parameter "enable_launch_polish" under flag
"enable-tab-grid-layout", with gate function
TabUiFeatureUtilities#isLaunchPolishEnabled. This CL is verified by the
formal equivalence tool in http://crrev.com/c/1934235 to be completely
behind flag.

Bug: 1116644
Change-Id: I208807435cc27ffb3536e6ccbc30f96380f1e766
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386376Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806746}

Also fixing a minor issue with a preprocessor define, see bug 10322.

https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/a8c51df76caa..995c0b844144

$ git log a8c51df76..995c0b844 --date=short --no-merges --format='%ad %ae %s'
2020-08-28 tuexen Fix explicit EOR mode, thanks to Taylor Brandstetter for reporting.
2020-08-26 tim constants: increase SCTP_DIAG_INFO_LEN to accommodate longer file paths (#521)
2020-08-18 tuexen Fix two bugs I introduced in https://github.com/sctplab/usrsctp/commit/e954753202890c9681eb82c7bcc9d6b37e276360
2020-08-16 tuexen Improve concurrent send() calls
2020-08-15 tuexen Sync with FreeBSD
2020-08-13 yuquanw2 Yuquan2 (#515)
2020-08-11 yuquanw2 add tests for nr sacks (#514)
2020-08-06 yuquanw2 new fuuzer for data fragmentation and connect corpus (#512)
2020-08-01 jmillan Provide ulp_info pointer on send_callback() (#511)
2020-07-30 lennart.grahl Fix oversight: Don't not undefine platform specific defines (#510)
2020-07-23 tuexen Clear the pointer to the socket when closing it also in case of an ungraceful operation. This fixes a use-after-free bug found and reported by Taylor Brandstetter from Google by testing the userland stack.
2020-07-23 tuexen Detect and handle an invalid reassembly constellation, which results in a memory leak.
2020-07-22 weinrank Sync master with OSS-FUZZ (#505)
2020-07-19 tuexen Add reference counts for inp/stcb/net when timers are running. This avoids a use-after-free reported for the userland stack. Thanks to Taylor Brandstetter for suggesting a patch for the userland stack.
2020-07-18 tuexen Cleanup
2020-07-17 tuexen Improve address list locking
2020-07-16 weinrank add fflush() (#502)
2020-07-14 tuexen Improve the error handling in generating ASCONF chunks. In case of errors, the cleanup was not consistent. Thanks to Felix Weinrank for fuzzing the userland stack and making me aware of the issue.
2020-07-10 tuexen Remove program used only locally.
2020-07-10 tuexen Sync with FreeBSD
2020-07-10 tuexen Fix a use-after-free bug for the userland stack. Thanks to Mark Wodrich from Google for finding and reporting the bug.
2020-07-09 tuexen Optimize flushing of receive queues. This addresses an issue found and reported for the userland stack in https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=21243
2020-07-08 tuexen Improve consistency
2020-07-08 tuexen Fix description in error cause
2020-07-08 tuexen Don't accept FORWARD-TSN chunks when I-FORWARD-TSN was negotiated and vice versa
2020-07-08 tuexen Improve handling of PKTDROP chunks. This includes the input validation to address two issues found by ossfuzz testing the userland stack: * https://oss-fuzz.com/testcase-detail/5387560242380800 * https://oss-fuzz.com/testcase-detail/4887954068865024 and adding support for I-DATA chunks in addition to DATA chunks.
2020-07-07 yuquanw2 Yuquanw4 branch (#500)
2020-07-03 tuexen Fix compilation since last debug output cleanup.
2020-07-03 tuexen Simplify conditions and don't send ERROR chunks when not ready.
2020-07-01 tuexen Fix a bug introduced in recent cleanup
2020-06-30 weinrank Improve debug logging (#498)
2020-06-26 tuexen Remove dead assignment.
2020-06-26 tuexen No need to use a non-default C compiler on FreeBSD.
2020-06-26 tuexen Fix error handling.
2020-06-26 tuexen Fix error message.
2020-06-26 yura.yaroshevich GitHub Actions: Make builds more verbose to help understanding what went wrong. (#497)
2020-06-26 tuexen Another Windows build failure...
2020-06-26 tuexen Add missing include. This possibly fixes the builds on Windows
2020-06-26 weinrank Ekr loop refactoring (#491)
2020-06-26 timo.voelker tsctp: add parameter to get the current throughput periodically (#490)
2020-06-26 yura.yaroshevich GitHub actions: CMake is preinstalled. CPU count is fixed. (#495)
2020-06-26 lennart.grahl Clean Meson build file (#494)
2020-06-26 tuexen Fix syntax error.
2020-06-24 yura.yaroshevich GitHub Actions: switch to Ninja from "Unix Makefiles" (#489)
2020-06-24 tuexen Fix the accounting for fragmented unordered messages when using interleaving. This was reported for the userland stack in https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=19321
2020-06-24 tuexen Don't use an AF_INET6 address on a AF_CONN socket in the fuzzer.
2020-06-23 yuquanw2 Adding tests for ASCONF chunks (#487)
2020-06-24 yura.yaroshevich Enable GitHub actions to perform "sanity" compilatoin of new changes. (#475)
2020-06-24 tuexen Fix alignment issue
2020-06-23 timo.voelker tsctp: add partial reliability with parameters -P and -t (#485)
(...)
2020-05-10 tuexen Only drop DATA chunk with lower priority as specified in RFC 7496.
2020-05-05 tuexen Avoid underflowing a variable, which would result in taking more data from the stream queues then needed.
2020-05-05 tuexen Undo earlier change, since it is incorrect.
2020-05-05 tuexen Fix the computation of the numbers of entries of the mapping array to look at when generating a SACK. This was wrong in case of sequence numbers wrap arounds. Thanks to Gwenael FOURRE for reporting the issue for the userland stack: https://github.com/sctplab/usrsctp/issues/462
2020-05-05 ystreet00 user_recv_thread: set fd to -1 when closing (#461)
2020-04-29 tuexen Fix #458
2020-04-22 tuexen Improve input validation when processing AUTH chunks.
2020-04-22 tuexen Improve input validation when processing AUTH chunks.
2020-04-20 tuexen Honor sysctl variable sctp_no_csum_on_loopback not only for SCTP/IPv4.
2020-04-11 tuexen Zero out pointers for consistency.
2020-04-06 tuexen Be more pedantic when starting / stopping a timer.
2020-03-28 tuexen Deal with AF_CONN address in SCTP_STATUS.
2020-03-28 tuexen Fix build.
2020-03-28 tuexen Fix time to ticks conversion and vice versa. Overflows were not handled correctly.
2020-03-27 tuexen More uint32_t cleanups.
2020-03-27 tuexen Use uint32_t where intended.
2020-03-25 tuexen Don't optimize for timers when the socket is gone. This fixes another bug where the COOKIE was not retransmitted if the socket was closed.
2020-03-25 tuexen Fix handling of accepted sockets.
2020-03-25 tuexen Fix FreeBSD vnet stuff and cleanup debug output.
2020-03-25 tuexen Fix lock name in Windows.
2020-03-25 tuexen Only call panic() when building with INVARIANTS.
2020-03-24 tuexen Cleanup the timer code and also stricly check the arguments used when starting or stopping a timer.
2020-03-24 tuexen Add some lock asserts, which will be used shortly.
2020-03-23 tuexen More timer cleanups.
2020-03-21 deadbeef Get rid of unnecessary include in fuzzer (#449)
2020-03-20 tuexen Remove a set, but unused variable. This should fix https://github.com/sctplab/usrsctp/issues/447
2020-03-20 tuexen Fix a NET_EPOCH bug.
2020-03-19 tuexen Cleanup starting and stopping timers.
2020-03-19 tuexen Cleanup stream reset and asconf timer.
2020-03-19 tuexen MTU candidates must be a multiple of 4.
2020-03-19 tuexen First pass on cleanup timer code.
2020-03-18 weinrank Fuzzer (#446)
2020-03-16 tuexen Get changes in again I accidently took out.
2020-03-16 tuexen Set default MTU for an endpoint to 9000 bytes.
2020-02-18 tuexen Epochify SCTP for FreeBSD.
2020-02-17 tuexen Fix the non-default stream schedulers such that they don't interleave user messages when it is not allowed.
2020-02-12 tuexen Sync with FreeBSD.
2020-02-11 tuexen Use bool for boolean variables.
2020-02-11 tuexen Don't start a timer on a net, which has been removed.
2020-02-11 tuexen Use int instead of bool.
2020-02-09 tuexen Stop the HB and PMTU timer when removing the net, not freeing it.
2020-02-09 tuexen Cleanup timer handling.
2020-02-06 tuexen Let sctp_os_timer_start return if the timer was rescheduled. This will be used in a follow-up commit.
2020-02-04 tuexen Remove unused timer.
2020-02-04 tuexen Fix iterator.
2020-02-04 tuexen Sync FBSDIDs.
2020-02-03 tuexen Prepare location information in preparation for integrating #417.
2020-02-03 tuexen Remove trailing whitespaces.
2020-02-03 weinrank ekr_loop - Fix bug (#425)
2020-02-03 weinrank Handle usrsctp_sendv EWOULDBLOCK (#424)

Created with:
  roll-dep src/third_party/usrsctp/usrsctplib

Bug: webrtc:11899, webrtc:10322
Change-Id: I85cff712ac96f60ab06ea524e614bf458e48e7b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387140Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Commit-Queue: Taylor <deadbeef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806745}

Bug: b:153364303
Bug: b:153659559
Change-Id: I0a7ecedbcf043b93473334e666c93532586eca3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399122
Auto-Submit: Leonid Baraz <lbaraz@chromium.org>
Reviewed-by: Zach Trudo <zatrudo@google.com>
Commit-Queue: Leonid Baraz <lbaraz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806744}

https://webrtc.googlesource.com/src.git/+log/8452ea86c5cb..295570eb332d

2020-09-14 tommi@webrtc.org Use PostTask instead of MessageHandler for cert generation.
2020-09-14 tommi@webrtc.org Make StunRequest not use auto cleanup.
2020-09-14 tommi@webrtc.org Avoid deallocating the async invoker when clearing the transport.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Ic8089c1bd8a28722a7de49a8ecc0e27000b2f563
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410608Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#806743}