- 21 May, 2020 40 commits
-
-
Luciano Pacheco authored
Only show focus ring only when interacting with keyboard. Add the hover color/style for OK button. Fix font face when opening delete dialog from <quick-view>, it was using Arial font, because it was missing "text_defaults.css" in this context. Bug: 992827, 1062902 Change-Id: Ibc4f6c576779a764d496d3d810d46bfa5378eef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208779 Commit-Queue: Alex Danilo <adanilo@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#770932}
-
Alexey Baskakov authored
In next CLs: Add more started/shutdown checks in WebAppInstallFinalizer, WebAppInstallManager, ManifestUpdateManager. Bug: 1084939 Change-Id: I720cbdd79998e895f5b9171e3173f89c6977be6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210085 Auto-Submit: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#770931}
-
Alex Danilo authored
The drop-down menu hanging off the elider button has a width range between 192px and 288px depending on the content inside it. Wide menus can get clipped on the right hand side if the window width is reduced to the smallest size possible, obscuring any scroll bar in the drop-down. Changes the max-width selector to take the minimum of 288px or 40vw which guarantees the right side of the menu doesn't get clipped out. Bug: 1083046 Change-Id: Ia64dc5befe62e5d4370044fe2545c1c720efee40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210177 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Wenyu Fu authored
Add paddingTop to make spacing consistent between top and bottom. Bug: 1068831, 1084791 Change-Id: I68639415615c24d3fa7889c53b74d9102482a59f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209895Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#770929}
-
chrome://media-appDavid authored
This patch * Mutates `currentFiles` upon deletion and tries to open the next file. * allows empty fileLists in `advance()` and `sendFilestoGuest()` * Adds a test for the scenario of deleting files in a directory of images. * reworks some of DeleteOriginalIPC to make the test more robust as before it was passing due to FakeFileSystemHandle always having the same default file name. Explicitly adding a filename makes the test more obvious when debugging. * Also swap DeleteOriginalIPC assert calls around to have the expected value on the LHS as we use the `assertEquals` from go/crcs/chrome/test/data/webui/test_api.js Bug: 1077732, b/156042029 Change-Id: I1606809db9ccae388182a086aa9045280624c5dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206195 Commit-Queue: David Lei <dlei@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#770928}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 1069817 Change-Id: Iee9b615a27bd3b88d73228461dc52e188bfce52b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208888 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#770927}
-
Khushal Sagar authored
Add a finch feature flag to disable delaying scroll response in the compositor for scroll handlers. R=sadrul@chromium.org,szager@chromium.org Bug: 1080911 Change-Id: Ida54b5f160b4438898cde48e59037d5c5254b4cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209688 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#770926}
-
Thomas Lukaszewicz authored
Updated the FocusRing class to use a ScopedObserver when observing its parent. Currently the FocusRing is successfully removed as an observer from the parent due to the fact that the FocusRing lives in a unique_ptr in the parent class. When destruction of the FocusRing's parent occurs, the unique_ptr is deleted before ~View() begins deleting the parent's children - a process which nullifies the parent_ pointers of the children. Since the unique_ptr is deleted prior to the ~View() destructor it still maintains a pointer to its parent and can successfully remove itself as an observer of its parent. In the current state this works, however the intention is to remove the use of set_owned_by_client() in FocusRing. If added as an owned child of the parent view, it will not have access to a pointer to its parent during destruction, meaning that it will be unable to remove itself as an observer of the parent, causing a seg fault later in destruction. The use of a ScopedObserver solves the problem in this case by allowing the FocusRing to remove itself as an observer of the parent irrespective of whether the parent_ pointer exists. Bug: 1044687 Change-Id: I54f486a326a6babe50baa3746868cfa27284e75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210009 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#770925}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ie58e595af915448eb44851f34e409d802e3204d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211460Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770924}
-
Sadrul Habib Chowdhury authored
Report the top-level UMA metrics for rendering from the system_health benchmark. BUG=1080679 Change-Id: Ie8e1810714780c786200d6d703e0dcacdd2ab041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198597 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#770923}
-
Mike Jackson (EDGE) authored
Rename shortcut_manger to shortcut_manager Change-Id: Ie21c942340b858f615f2dec84fe1b8821af00ff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208304 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#770922}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f83baf230c69..4c0578632217 2020-05-21 reed@google.com init fDeviceClipBounds for empty canvas 2020-05-21 fmalita@chromium.org [skottie] Add support for embedded fonts (glyph paths) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: Ia2c1952313c35d4c1a08996b278222dd9e932d5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210062Reviewed-by:
-
Xianzhu Wang authored
This reverts commit 0bd440c5. Fixed (mostly invisible) raster invalidation issue with PaintOpBuffer::NeedsAdditionalInvalidationForLCDText() to invalidate the whole layer when LCD Text under SaveLayerAlpha may change. Original change's description: > Revert "Preserve LCD-text in SaveLayerAlphaOp when possible" > > This reverts commit 0c258cbd. > > Reason for revert: Flakiness of raster result. crbug.com/1082804. > > Original change's description: > > Preserve LCD-text in SaveLayerAlphaOp when possible > > > > This achieves LCD-text under non-composited opacity when possible. Pass > > two flags to SkCanvas::SaveLayer() for SaveLayerAlphaOp: > > kPreserveLCDText_SaveLayerFlag to preserve LCD text, and > > kInitWithPrevious_SaveLayerFlag to to ensure an opaque background. > > > > This doesn't apply when there any SaveLayer modes which would break > > LCD text or be broken by kInitWithPrevious_SaveLayerFlag. So we disable > > the feature for the whole layer when there is any of such effects in > > the layer. The new operation is also a bit more expensive, so only do > > it when there is text. For now these two conditions are applied on the > > whole layer for simplicity. Otherwise we would need to track them in > > SaveLayerAlpha/Restore hierarchy which would be complex and error-prone. > > > > Bug: 942051 > > Change-Id: I3ab2e8051e26c5714fd72830a7921099b9170d0d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2189260 > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Reviewed-by: Philip Rogers <pdr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#768367} > > TBR=wangxianzhu@chromium.org,pdr@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 942051, 1082804 > Change-Id: I36f281df4940588d5c2b1b4da415f5d22b0aa9e3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203495 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#769425} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 942051, 1082804 Change-Id: Ic4bccc769a044061238469a38edf0822a6ed16c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206213Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#770920}
-
Moe Ahmadi authored
Only realbox matches with descriptions should have a hyphen Bug: 1085240 Change-Id: Ieb4f8f27dcbf8b6763d025935a7547a2180657b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211129 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#770919}
-
Julie Jeongeun Kim authored
This reverts commit aff3274e. Reason for revert: This causes the crash. It's important to handle the message in order in the preview UI. So, the interface should be converted with PrintHostMsg_MetafileReadyForPrinting together. TBR=dtapuska@chromium.org Bug: 1008939,1084837 Change-Id: Iedae9b30c7fb1c87a1537efbf8696e7762e8e259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208778 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#770918}
-
Victor Costan authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/a09ea700d32b..011959aafddc $ git log a09ea700d..011959aaf --date=short --no-merges --format='%ad %ae %s' 2020-05-13 absl-team Googletest export 2020-05-13 absl-team Googletest export 2020-05-11 absl-team Googletest export 2020-05-08 martin Remove an explicit include of debugapi.h 2020-05-08 martin Revert "Googletest export" 2020-03-29 verdoialaurent Fix --gtest_print_time coloring Created with: roll-dep src/third_party/googletest/src Change-Id: I57639ecb4ed40df147a55e41434bd3fccc441b7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211195 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#770917}
-
Brian Sheedy authored
Suppresses some lightly flaky WebGL 2 shader operation tests on Intel GPUs with a RetryOnFailure expectation. TBR=ynovikov@chromium.org Bug: 1085222 Change-Id: I8bf470a2b7c4fa4a8a9277cb50d12328fb45cc3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210972 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#770916}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 668e5fe8. With Chromium commits locally applied on WPT: f6984fd9 "De-flaky pointerlock/pointerevent_pointermove_in_pointerlock.html" 45436d4d "CookieStore: WPT to verify subscribe/unsubscribe is idempotent" 2588266e "ServiceWorker: Modernize fetch-request-resources.https.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dtapuska@chromium.org: external/wpt/uievents NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: If9c1eaff752d01fd9fa323d2aa42e754f66fd5c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210536Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770915}
-
Joel Hockey authored
Launching terminal via shelf context menu, or launcher is not currently using the same display as the shelf. The display_id is available through most of the call chain, but is needed in a few extra places. CreateApplicationWindow receives display_id in AppLaunchParams, but was never setting Screen::SetDisplayForNewWindows which is required to ensure that WindowSizer will put the new window on the specified display. Same for WebAppLaunchManager::OpenApplication. Updated LaunchSystemWebApp for all callers to pass display_id where it is available. Bug: 1083825 Change-Id: I5e7046af772b09a3c5340083ded33e42642acd6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208799Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#770914}
-
adamta authored
Change-Id: I04d3b1315656d9adedd6871435ef0686924bb41a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202387Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Cr-Commit-Position: refs/heads/master@{#770913}
-
Julian Pastarmov authored
BUG=1052093 Change-Id: I59e493b1b9a057fd73dc206e9c18584397fd0fd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196345 Commit-Queue: Matt Giuca <mgiuca@chromium.org> Auto-Submit: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#770912}
-
wutao authored
Bug: b/156856260 Test: new unittests Change-Id: Idee6218ff7d3c3cde0bcb91885d10b909bcef95e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207586 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#770911}
-
Jesse McKenna authored
This change makes MFVideoCallback::OnSample favor faster buffer-lock methods IMF2DBuffer2::Lock2DSize and IMF2DBuffer::Lock2D over IMFMediaBuffer::Lock. This reduces the total system CPU time during videoconferencing by an estimated 3.5%. Currently, on every call to OnSample (i.e., every frame), Lock: * Allocates memory for a buffer, * Initializes the memory, resulting in page faults, * Copies the memory to the actual buffer, and * Frees the allocated memory (which has additional cost to the system process, which has to zero out the freed memory). Per crbug.com/1071180, this process accounts for an estimated 3.5% of total system CPU time during videoconferencing. An additional cost is incurred when Unlock is called, as the buffer is then copied back. Using either Lock2DSize or Lock2D avoids this memory allocation and its associated overhead. Lock remains as a fall-back in case the faster methods fail. Lock2DSize/Lock2D may fail if the buffer does not support the IMF2DBuffer2/IMF2DBuffer interfaces. Bug: 1071180 Change-Id: I09918e6a33f4e10999573c298b832ecd1d9bfc9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207580Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#770910}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8f6bfe301f30..14a83aec5603 2020-05-21 sokcevic@google.com Reland "Use OS level locking in git_cache.py" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1049610 Tbr: agable@chromium.org Change-Id: I1ec79a5e7fd9ff0ab11c19fc53166befff435041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210066Reviewed-by:
-
Christopher Cameron authored
There exists a literal in the test shader's binary. Add a list of valid values that can be inserted at that location in the shader, and choose one at random when testing shader link time. This will defeat caching that Metal might be doing (at least for a while). Remove DumpWithoutCrashings on failure (we just skip recording a UMA on failure). Randomly choose between testing shader compile or shader link at runtime, so we get distributions for both. Bug: 974219 Change-Id: I61b067596a69884fcdf967b9774397d0112a6a0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209309 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#770908}
-
Avi Drissman authored
A test moved in bd3e9864 and therefore this include is no longer needed. Tbr: nasko@chromium.org Bug: 1076947 Change-Id: Id926e1b0c1759b5d1bcac1d33231ad443832cc58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210027Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#770907}
-
Yoshifumi Inoue authored
This patch changes "move_backward_line_table.html" to utilize |selection_test()| for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: Ib5088b3888a26e599639bbfa9366aec75a067329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210171 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#770906}
-
Kent Tamura authored
We avoid unnecessary memory allocation by this CL. Bug: 1052232 Change-Id: Id8f4e70f2e6dd58fb51f198b71e42495188242e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210084 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#770905}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: Ia935020991ad31688e7ff0acdb9e0f5f6e68fc78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208817Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770904}
-
Kyle Horimoto authored
This function can be used to generate search results for sections, which is required for showing parent section subpages. Bug: 1082249, 1071700 Change-Id: If96bbe51df071a9e8b7466720b670eb6326221f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211133 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#770903}
-
Matt Giuca authored
Change-Id: I5eb58a1862611fb9a23396c1852de90c23153a78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210280 Auto-Submit: Matt Giuca <mgiuca@chromium.org> Reviewed-by:
-
Glen Robertson authored
Once the browser side implementation lands the stubs can be replaced with calls to a mojo service, as described in the design doc for this feature go/cros-skus (Google only). Modified from crrev.com/c/1959237 based on drafted changes proposed in Explainer (see below). Discourse post: https://discourse.wicg.io/t/proposal-web-payments-digital-product-management-api/4350 Intent to prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/vkS3k30lWNs/m/Gt4sKECQEgAJ Explainer: https://github.com/WICG/digital-goods/blob/master/explainer.md Chrome Status: https://chromestatus.com/feature/5339955595313152 A followup CL will add the mojo structs/enums and type converters. Note: This is behind a runtime enabled feature flag, and so, does not expose any new APIs to the web. This is a very early prototype, and will likely not ship in its current form. Bug: 1061503 Change-Id: Ic7a1a5b2866e40eef466f6e1d29436ba144c90ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2183770 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#770901}
-
Brian Sheedy authored
Removes the trigger_multiple_dimensions.py trigger script and all references to it/related code. More reliable and functionally equivalent behavior can be achieved using the swarming dimension OR operator instead. Bug: 1084737 Change-Id: Ied8be2157a6543d33501518029609f7c3afbe699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211232 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#770900}
-
Moe Ahmadi authored
- Makes <ntp-realbox-button> and <ntp-realbox-match> custom elements focusable with proper aria roles and labels. Removes or replaces focusable child elements of these custom elements. Removing the <a> element in <ntp-realbox-match> has the added benefit of eliminating the possilbity of navigation to a suggeestion without going through the browser. - Adds tooltips and aria labels to the suggestion header toggle button: - Tooltip: "Hide suggestions" / "Show suggestions" - Voiceover: "Hide the 'X' section" / "Show the 'X' section" - Allows the suggestion header text to truncate if needed. Bug: 1084718 Change-Id: I063821d9bfcef191deb070007c028c44903feaae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210938 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#770899}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3a5742c880b4..3cc1a6509bf6 2020-05-20 jianj@google.com Set av1 speed from resolution. 2020-05-20 mbonadei@webrtc.org Add ios_code_signing_identity_description to GN args. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I060ab7bc0c14275a5198927082a4a2c207de46f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210909Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d3affaa62488..8f6bfe301f30 2020-05-20 sokcevic@google.com Revert "Use OS level locking in git_cache.py" 2020-05-20 isherman@chromium.org Fix `git cl format` for metrics XML files on Windows 2020-05-20 isherman@chromium.org Add git cl format support for "structured" metrics If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1049610 Tbr: agable@chromium.org Change-Id: Ib60930a32b43c9bf6475a76243b5b0f674e41469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211028Reviewed-by:
-
David Schinazi authored
We use these histograms to monitor the performance of the QUIC network protocol. This CL unifies all of our non-expired histograms to use the same expiration date. R=renjietang@chromium.org Change-Id: Iec8194a253d75b2661a31fe71f34a10398081054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211067 Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#770896}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1589947115-d59e956e9f0cd8de69b108c77019d85951a98a26.profdata to chrome-win32-master-1590019092-d032408a4c7d66eb8e8eaad56f5f62575a89e2db.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I5e9e61eb1ff5dfcf41ba611e6a572186d22fbf08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211031Reviewed-by:
-
David Tseng authored
R=hirokisato@chromium.org AX-Relnotes: n/a Fixed: 1056072 Test: manual Change-Id: Ia4e93e745ab8bdd93ca7fee324efbae258e4d236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209992Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#770894}
-
Will Cassella authored
This CL fixes all style warnings in FFmpegDemuxer that make error/warning based IDE navigation cumbersome. There should be no functional changes in this CL. Change-Id: I30371e6a889d29d553f95aa275e98cfd05591b8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211081 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
