- 19 Jan, 2021 40 commits
-
-
Eric Willigers authored
We add use counters for - close() - readable - writable - remoteAddress - remotePort Bug: 905818 Change-Id: I02539b29d3c1035642ba9200651ac15135eb58c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636634 Commit-Queue: Glen Robertson <glenrob@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#844693}
-
Tal Pressman authored
Following the discussions on platform-architecture-dev[1], this CL expands MojoBindingContext's responsibility to include context lifecycle notifications which were previously in ContextLifecycleNotifier. [1] https://groups.google.com/a/chromium.org/g/platform-architecture-dev/c/_7Ybv_RLgic Change-Id: Icdcc2a59bf0580b919d1dbb015a45bfd184583b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596279 Commit-Queue: Tal Pressman <talp@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#844692}
-
Luciano Pacheco authored
When running as JS module which is strict by default, the IF condition was raising an exception because the Polymer variable isn't defined. Fix by checking the variable explicitly in the global scope. Bug: 1133186 Change-Id: If62e8d5fd45a4453e67810c04a6bdf3cf2033fa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637097 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#844691}
-
Polina Bondarenko authored
Add ArcSnapshotRebootNotification that is shown if inside a snapshot update interval and user is logged in. SnapshotRebootController tries to reboot the device once user consents by pressing a restart button. BUG=b:170187468 TEST=components_unittests TEST=unit_tests Change-Id: I3dcae858e8f889aa4be4fc7d5344359488c9d5fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627523Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Oleksandr Peletskyi <peletskyi@chromium.org> Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#844690}
-
Keishi Hattori authored
chrome/install_static/DEPS excludes base/ includes so we cannot include checked_ptr.h Bug: 1080832 Change-Id: I78fa4d1404da39c3539e7619367911e0aa6522e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636817Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#844689}
-
Peter Kotwicz authored
This CL rolls: androidx.activity androidx.appcompat androidx.fragment androidx.gridlayout androidx.leanback androidx.preference androidx.slice androidx.savedstate androidx.transition The InputTypestTest.java test changes are needed because the internals of how fragments listen to the result after launching an activity have changed. See implementation of FragmentManager#launchStartActivityForResult() BUG=1064277 Binary-Size: Method count increase is unavoidable due to many libraries. Change-Id: I8ee9bcb199b60e039213975586f2d6022e06311c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602665 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#844688}
-
Wei Lee authored
As a follow-up of https://crrev.com/c/2547856, since we have already changed to use test/test.html instead of views/test.html in test codes, it should be safe to remove views/test.html to avoid confusion. Bug: b/173092399 Test: tast run [DUT] camera.CCAUISmoke.swa Change-Id: I904591b53591a388c729a7857144557dd1b08267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636735 Commit-Queue: Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#844687}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c1912a4fbb17..111e01a4ac13 2021-01-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I20738df292c8dd6a87aa7ed32d4baa788ba8d55c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636996Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844686}
-
Yoshisato Yanagisawa authored
Now I heard it looks working. Let me remove the limitation. Bug: b/64390790 Change-Id: Ie36419d538c2a32a4dad98dd93e0574a4c869cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637176 Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com> Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Fumitoshi Ukai <ukai@google.com> Cr-Commit-Position: refs/heads/master@{#844685}
-
Thiabaud Engelbrecht authored
See related bug for details. This CL lays the groundwork for further ParkableImage work by encapsulating the RWBuffer in DeferredImageDecoder inside a ParkableImage. This CL does not introduce any changes to functionality. Bug: 1142834 Change-Id: Ic5497b89346f8b2437a41d70381220b72ffed9de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519728 Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
When running as JS modules which is strict by default the cr.ui.List fails when trying to set the label here [1]. Fix by adding a no-op setter in the FileGrid.Item. [1] - https://source.chromium.org/chromium/chromium/src/+/master:ui/webui/resources/js/cr/ui/list.js;l=898;drc=d95bb037d381ef68fa70418e2a8dedce62c1127b Bug: 1133186 Change-Id: Idc0a97d8739c029dc1709d8c90bd20aaf786fd57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636742 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL replaces blink::mojom::ResourceType with network::mojom::RequestDestination in content/{common,renderer}/service_worker since blink::mojom::ResourceType is deprecated[1]. [1] https://crbug.com/960143 Bug: 1059639 Change-Id: Ia88dc12a3a655d09419a9b9c88c9457b74abdb02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635999Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#844682}
-
Luciano Pacheco authored
Now that <bread-crumb> can run as JS modules the <cr-action-menu> works in the unittest and can be shown/hidden. Bug: 1133186 Change-Id: I45fe6eecca50499ac4574f57234bb7af30dc4597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636903 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1611013939-db0b1e97bc691be6bf78d3a336cf34d826bfa98b.profdata to chrome-win64-master-1611024810-f8a51712b469a1b51b3e448822968fd32c8978ae.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4a43c44d0bef83e8bb23f749ab951559bc133694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636717Reviewed-by:
-
Luciano Pacheco authored
This is a preparation to run Files app as JS modules. Bug: 1133186 Change-Id: I0447d7c19950c69aa47ecb33f5df35a0fcb330d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636814 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2a27413fde15..1cb592d4efd1 2021-01-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 04772515a8b6 to e45593cb0876 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I28776299b5605b874dff3282df260bbdcf8f4950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636716Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611003391-e5257fde85260089be74668a059af9daef590c17.profdata to chrome-win32-master-1611013939-1c9af1927a800d0fae0bbc5808e1b1b28e5ab3fe.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib5995358cca7df1b57fa4cb90e1e67ccabb6f0dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636673Reviewed-by:
-
Kenichi Ishibashi authored
This CL replaces ClearForShutdown() call in the destructor of ServiceWorkerContextCore with AbortAll() to run callbacks. Some callbacks contain mojo response callbacks which need to be executed before being destroyed if their corresponding bindings are still connected. It's a bit hard to disconnect these bindings so run callbacks in destructors. Bug: 1161799 Change-Id: I39ff795f7246d944f26f2814cb60adfd68b17abe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635403Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#844676}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/cf567b6b9616..5eda7597b6b7 2021-01-19 dberris@chromium.org Reland "chromeperf: Anomaly configs in subscriptions" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1158326 Tbr: skyostil@google.com Change-Id: I91a4e19a9636d5dd2aba469ef2d928f4c45b17dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636267Reviewed-by:
-
Maggie Cai authored
This reverts commit 21a8ee36. Reason for revert: This CL is likely the culprit for the failure of tests: AssistantTimersBrowserTest.ShouldRemoveTimerWhenStoppingViaNotification AssistantTimersBrowserTest.ShouldTickNotificationsAtRegularIntervals on builder linux-chromeos-chrome First occurance: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/11466 Original change's description: > views-posse: Add metadata to notification_view_md > > Bug: 1159562 > Test: build > Change-Id: I5cd5b56c5ef11899bdac3122ed1525a24bbf6fa5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615725 > Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> > Reviewed-by: Allen Bauer <kylixrd@chromium.org> > Commit-Queue: Sara Kato <sarakato@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844496} TBR=yoshiki@chromium.org,kylixrd@chromium.org,sarakato@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I3fe76cb2391afb9ef454f3e3fb8d8c44c6753013 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1159562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636737Reviewed-by:
Maggie Cai <mxcai@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#844674}
-
Tal Pressman authored
Change-Id: If5bc40ac15f246c8419a2ad92dcd06346ae62d12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633488Reviewed-by:
-
Kenton Lam authored
This will help as we add more events for additional functionality. Particular flags need to be set for all CustomEvent's so they bubble up through the Polymer components. Change-Id: I11e909b7a6afc6bc9433392e1fbb160156cdf10e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636077 Commit-Queue: Kenton Lam <kentonlam@google.com> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
John Palmer <jopalmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#844672}
-
Dominik Röttsches authored
After moving OTS to a DEPS-based checkout in [1] but keeping it at the same commit position, now roll OTS forward to upstream tip-of-tree. Update baselines to reflect that OTS changed the wording of some error messages. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2589853 Bug: 1158389 Binary-Size: OTS has not been rolled in a long time and is a required component to protect against malicious web fonts and to avoid bugs in the system font stack. Change-Id: I5999049091f6c4472a0613d5fb5b284929e7702d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635654 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#844671}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5635dbb91641..81430e11c81e 2021-01-19 jmadill@chromium.org Vulkan: Remove command processor special functions. 2021-01-18 penghuang@chromium.org Support create ANGLE EGLContext from an external EGLContext If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I7151178c817f802ba66f240de9e84fa0ca6f8a73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636299Reviewed-by:
-
Fergal Daly authored
This test is slow on debug builds in general but on Mac and Win it's slow enough to cause timeout flakes. FIX: Set the entry-count limit to 10. This test takes 15s on my desktop before this change and 6 afterwards, so the build bots should be OK. Bug: 1167300 Change-Id: Iaf3cf63aed26dc0a79a02cb6b2af6ecada30303f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636633Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#844669}
-
Yann Dago authored
This fixes the fact that the wrong data was sent to the histogram "Sync.Startup.PolicyLoadTimeout" and uses a new histogram named "Sync.Startup.PolicyLoadTimeout2" to avoid using the wrong data. Bug: 1129065 Change-Id: Iaa42e0ede6348f130a8e1e09ea35c2989aaff955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629574 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Auto-Submit: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#844668}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I2d8e726c97ed232fbf35df7b10162f99409cf6bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636505Reviewed-by:
-
Alan Cutter authored
This CL fixes middle clicks on links inside a link capturing web app scope from crashing. These were crashing due to the expectation that the navigating tab was already attached to a browser window (which is incorrect during the navigation throttle) causing a nullptr crash. We should not be link capturing these navigations so this CL checks for and early exits in these cases. Bug: 1159666 Change-Id: I9dae80d84a44e8bf2fa9918ece8fee6d19af2ee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636009 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f2a99e868d8f..c1912a4fbb17 2021-01-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iace1a91741c4cb02f97ef91e24420ee978760512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636266Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1611003391-f38d26b13046eb21865bd4aef763cfd6c815875c.profdata to chrome-win64-master-1611013939-db0b1e97bc691be6bf78d3a336cf34d826bfa98b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4400c7dd961d394fe1a6949ab7a530f1f693350d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636508Reviewed-by:
-
Hui Yingst authored
For a XYZ fit type named destination, if the x or y coordinate is null, that specific coordinate of the current viewport should be retained (See table 151 in ISO 32000-1 for more details.). Also, one null parameter does not invalidate other parameters, all parameters should be handled independently. Currently, the PDF viewer ignores both the x and y coordinates if either one of them is null, and it always resets the viewport position to (0,0) (top-left corner) without retaining the current coordinate which receives a null input. This CL does the following changes to fix this issue: - Makes PDFiumPage::GetPageDestinationTarget() return x and y coordinates separately, so that each null input can be handled individually as an undefined value. - Introduces retrieveCurrentScreenCoordinates() to calculate the current in-screen coordinates of the viewport, so that goToPageAndXY() can use its return value to retain x/y coordinate while navigating to a new destination. Bug: 1163701,1157061 Change-Id: I4a4e8f1e193aab8ad2d5c8f3a277d0892e3e72c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632325Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: Hui Yingst <nigi@chromium.org> Cr-Commit-Position: refs/heads/master@{#844663}
-
Ye Kuang authored
Bug: 1141780 Change-Id: I0eac786673ac31f68128059d627d7156c6a8d653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631894Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Ye Kuang <yekuang@google.com> Cr-Commit-Position: refs/heads/master@{#844662}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 89-4380.0-1610362181-benchmark-89.0.4387.0-r1 to 89-4380.0-1610362181-benchmark-89.0.4389.4-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I087561bf4471f7e924d3ddbc7f40090127b52a1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636753Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=pbommana@chromium.org Change-Id: Idb6f4477661f20d91cfcdbab48bda80dd3c6f3a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636773Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844660}
-
Xianzhu Wang authored
This ensures that cc will rasterize the animating layer at the maximum scale, to avoid 1. blurriness during scaling-up animations (e.g. scale 1 -> 3), 2. too big raster scale (wasting memory) during small scale animations (e.g. scale 0.1 -> 0.3). Previously in the above cases, in simple cases (without ancestor scales), scale 1 for the layer was used for raterization because ui::TransformAnimationCurveAdapter failed to provide the maximum scale of animations. Also remove unused ui::InverseTransformCurveAdapter. Bug: 1161586 Change-Id: Ieb876bc271c98627bd61370c93e806b44be0b868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605242 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#844659}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/13466d016b58..84e43fa2c447 2021-01-19 tikuta@chromium.org ninjalog uploader: migrate to python3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: I472e79748ba8fd8beeb74b26830ba66e25e3c10d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636298Reviewed-by:
-
tby authored
We've changed the proto field used to record structured metrics, this CL changes the metrics provider from using deprecated_structured_event to using structured_data.events. Bug: 1148168 Change-Id: I9b987c2e24886ee72b2f404dcd713981674cc194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636079Reviewed-by:
Rachel Wong <wrong@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#844657}
-
Kyle Williams authored
Move the various GetCurrentFormFactor functions to the VariationsServiceClient class. BUG=b:177442621 TEST=autoninja -C out/Default/ components:components_unittests && xvfb-run ./out/Default/components_unittests --gtest_filter=FieldTrialUtilTest.* Change-Id: Ib677ed6cfbba91a287cb5c9ef06cf96332e4be3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633426 Auto-Submit: Kyle Williams <kdgwill@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#844656}
-
Song Fangzhen authored
Reject hostnames that resolve to non-public exception unless a raw IP address or a *.local hostname is entered by the user. TODO: Show connection dialog and use the hostname provided by the user. Below documents are from Eric Willigers <ericwilligers@chromium.org>. Explainer: https://github.com/WICG/raw-sockets/blob/master/docs/explainer.md Design doc: https://docs.google.com/document/d/1Xa5nFkIWxkL3hZHvDYWPhT8sZvNeFpCUKNuqIwZHxnE/edit?usp=sharing Bug: 1119661 Change-Id: I9a1300adf8b4acef2fbc2f18c465f86bc11b3859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631664 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#844655}
-
Minggang Wang authored
The functions declared in ip_address_space_util.h are needed when moving WebURLLoaderImpl into blink. So, as part of the OnionSoup project, this patch moves the functions to third_party/blink/public/common/net/ and its unit test accordingly. Bug: 1110176 Change-Id: I9a9b7056d6e822eaf39a1f21a8c5fb35379d5ffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635217Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Minggang Wang <minggang.wang@intel.com> Cr-Commit-Position: refs/heads/master@{#844654}
-
