- 18 Oct, 2019 40 commits
-
-
Antonio Gomes authored
BUG=787254, 919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ia9e4ca1ea07c0386972a5f113972f3e2be3bb27e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867449Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#707300}
-
Noel Gordon authored
TreeItem handles the item content creation, label, tree parent_ etc so remove local FakeItem code related to that. Bug: 992819 Change-Id: Ice70bf57e9e739a4dc806c5e3973f893be5e7bd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868212Reviewed-by:
Austin Tankiang <austinct@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#707299}
-
Pâris MEULEMAN authored
This adds a failing assert when SigninManager.Signin is triggered while the primary account is already set in IdentityManager. Bug: 995201 Change-Id: Ib404f930694ea82aada3bac5a144dac096fa1541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824267Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#707298}
-
Huanzhong Huang authored
Reserve space for (lazy-loaded) cookie controls toggle Bug: 967668 Change-Id: Ia6fa8e84590c8512fcd6cb84f72f7db339b69e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865222 Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#707297}
-
Friedrich Horschig authored
With this CL, the peeking height is set depending on whether a second suggestion will be half visible. Additionally, various paddings and margins are adjusted to match the specs. The see the differences with layout bounds, find screenshots in the linked bug. Bug: 1009331 Change-Id: Ib522938becca2012efbd30200f8a19e6c56c5380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866629 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
-
Roman Aleksandrov authored
This is a reland of 71c00bee Original change's description: > Welcome screen: Fix language list initialization > > Change ResolveLanguageListInThreadPool so that it uses AppLocale instead > of default locale if exists. > > Bug: 955397 > Change-Id: I6947dd89e297adea3fd019e38d083e45419ea282 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704098 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Denis Kuznetsov <antrim@chromium.org> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> > Cr-Commit-Position: refs/heads/master@{#706436} Bug: 955397 Change-Id: I9b6bc855f0a87eadab42af14d5e3d797f77d6a57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865227 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#707295}
-
Michael Lippautz authored
This unblocks fully deprecating the methods that take v8::Value. Switching Blink to fully use references based on v8::Data is future work. Bug: v8:9841 Change-Id: I263ae03e9c6057b84fe84bbeff59a0bfbba01c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868949 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#707294}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6dee176c8d7d..c6db4a035a17 git log 6dee176c8d7d..c6db4a035a17 --date=short --no-merges --format='%ad %ae %s' 2019-10-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 6652f0b64287..a68a80a4dbf9 (1 commits) Created with: gclient setdep -r src/third_party/angle@c6db4a035a17 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@google.com Bug: chromium:None Change-Id: Ibf16bda63c21dafa64ded15626905c649dcecb15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868969Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707293}
-
Tim van der Lippe authored
With the removal of the terminal, we no longer need this experiment. BUG=1011466 Change-Id: I0c097d33d09329eae41079504d825041f082e1fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866930 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Paul Irish <paulirish@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#707292}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7bf8699dd1ce..c336dd1cb69c git log 7bf8699dd1ce..c336dd1cb69c --date=short --no-merges --format='%ad %ae %s' 2019-10-18 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 8a67b116..f29003dd (707122:707259) Created with: gclient setdep -r src/third_party/webrtc@c336dd1cb69c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Id55eb5681de8dd6f4336b87758b1fd2791817aaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868910Reviewed-by:
-
Miyoung Shin authored
This CL converts AudioDecoderClient{AssociatedPtr, AssociatedPtrInfo} and AssociatedReceiver<AudioDecoderClient> in media to the new Mojo type, and uses pending_associated_remote<AudioDecoderClient> in audio_decoder.mojom. Bug: 955171 Change-Id: I0639e2bbbd97b0f5aebc958a739dae4e1769240f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865162 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Sam McNally <sammc@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#707290}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I897849bfeace4d4c0396261e1e92d370a872d15b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868511Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707289}
-
Leo Zhang authored
IME decoder shared library has its own threads. In order to make sure all the child theads post message via mojo safely, we must post all of these tasks to MainTaskRunner. Bug: 837156 Change-Id: I564662bfae078844da47628ad95560bdc160e6a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868532 Commit-Queue: Leo Zhang <googleo@chromium.org> Auto-Submit: Leo Zhang <googleo@chromium.org> Reviewed-by:
Marti Wong <martiw@chromium.org> Cr-Commit-Position: refs/heads/master@{#707288}
-
Yuta Kitamura authored
This reverts commit f2baca71. Reason for revert: This CL is triggering a CHECK failure in a few tests in ash_unittests. Failed tests: ShelfApplicationMenuModelTest.VerifyContentsWithMenuItems ShelfApplicationMenuModelTest.VerifyContentsWithNoMenuItems ShelfApplicationMenuModelTest.VerifyHistogramBuckets ShelfApplicationMenuModelTest.VerifyHistogramOnExecute ShelfViewInkDropTest.ShelfButtonWithMenuPressRelease Started to fail since: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/14866 (Just look at ash_unittests, other failures are irrelevant) Crash log sample: [ RUN ] ShelfViewInkDropTest.ShelfButtonWithMenuPressRelease [15893:15893:1017/174420.948496:6297578335:FATAL:simple_menu_model.cc(561)] Check failed: item.command_id >= 0 (-2 vs. 0) Original change's description: > Menu Model: fix bug where menu item title was greyed out because it is disabled. > > The old approach of adding title as a disabled item meant that this CL: > > https://chromium-review.googlesource.com/c/chromium/src/+/1788198 > > causes the menu title to be displayed in grey text instead of solid black text. This CL introduces a new menu type that, while still disabled and non-reactive, be displayed in solid black text. > > Bug: 1006203 > Change-Id: I9fa38132160228ebde5bd43d8db9c2f60d5f001c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841583 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Toni Baržić <tbarzic@chromium.org> > Commit-Queue: Yulun Wu <yulunwu@chromium.org> > Auto-Submit: Yulun Wu <yulunwu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707147} TBR=tbarzic@chromium.org,sky@chromium.org,msw@chromium.org,newcomer@chromium.org,yulunwu@chromium.org Change-Id: I39a3bebb393d70e1dbeb6da61908f7ec2e3e9b2e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1006203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869050Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#707287}
-
Victor-Gabriel Savu authored
Remove WilcoDtcSupportdClient from DBusThreadManager and use a feature check to determine if initialization is required. Moving the files is required to be able to access ::features::kWilcoDtc. Bug: 1014062 Test: unit_tests --gtest_filter="WilcoDtcSupport*" Test: on device with diagnostics_dpsl_demo_vm Change-Id: Ia83b91495cfab32a05a9642a871a4cdd8b13392e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865156 Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#707286}
-
Miyoung Shin authored
This CL converts CameraHalClient{Ptr, Request} in media and components to the new Mojo type, and uses pending_remote<CameraHalClient> in cros_camera_service.mojom and camera.mojom. Bug: 955171 Change-Id: I33fc6c386f1fe8dc205a8ea76d5afc0782c7996b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862924 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#707285}
-
Chih-Yu Huang authored
We plan to create another class to replace VideoFrame usage inside the CrOS VideoDecoder implementations. In order to output another type to the client, the current CrOS VideoDecoder implementations have to inherit a new interface. This CL adds a new interface VideoDecoderPipeline::DecoderInterface, and changes CrOS VideoDecoder implementations to inherit this. BUG=chromium:998413 TEST=run video_decode_accelerator_tests on Eve and Kevin with dcheck_always_on = true Change-Id: I822014474e2cc708fdfc96e30ec4be99c0b4ac8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777446 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#707284}
-
Caleb Rouleau authored
This reverts commit 7bfe9152. Reason for revert: crbug.com/1000426 is fixed now, so this is no longer needed. Original change's description: > [run perf tests] Output to swarming log again. > > We used to do this before > https://chromium-review.googlesource.com/c/chromium/src/+/1629432 > We changed it because the swarming was cutting off the logs > because they were too long (and also loading them was difficult). > > This change is a temporary trial for figuring out crbug.com/1000426 > while we wait for email responses to > https://groups.google.com/a/google.com/forum/#!topic/luci-eng/3uLbRYVecuc > > > Bug: 1000426 > Change-Id: I788d385a665604030f0df93a24e6aab3606929cd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790243 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694372} TBR=crouleau@chromium.org,johnchen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1000426, 1015505 Change-Id: Ic5b43be621c0719eaec981b54a9a89f22623857f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864622Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#707283}
-
Peter Kasting authored
Also shortens some repetitive code. Bug: 82078 Change-Id: Ib0e4946233c3bf595319ce8368e106eb1be8a041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868629 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#707282}
-
Matthias Körber authored
Clear-text form fields can be marked as type |NEW_PASSWORD| by a server-prediction to enable the password-generation feature. If a field of type |NEW_PASSWORD| is clicked, Chrome not only offers password generation, but also offers to fill the field with stored credentials as a fallback option to handle type misclassifications. For a clear-text field, this fallback mechanism must be disabled to prevent the user from exposing his credentials. Bug: 1012234 Change-Id: I9bbc19d7bb22c80c22f0a3782cab6b9f97d57891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847279Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#707281}
-
Fredrik Söderquist authored
Animation arguments/value computations shouldn't be tied to interval update, it should only "react" to progress. Turn the |animation_valid_| bool into an tristate (enum) and refactor the validation of animation parameters to suit. The UpdateAnimation(...) override now performs the validation (if needed). Implement WillChangeAnimationTarget() for SVGAnimationElement and invalidate animations there. Then fold SVGAnimateElement::ResetCachedAnimationState into the corresponding override in SVGAnimateElement, removing the calls that is now handled by the superclass. Bug: 998526 Change-Id: I30ad39d5599839dcdd6b4d34573be027f3b42f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866519Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#707280}
-
Miyoung Shin authored
This CL converts CameraHalServer{Ptr, Request} in media to the new Mojo type, and uses pending_remote<CameraHalServer> in cros_camera_service.mojom. Bug: 955171 Change-Id: Ice2749a91a90e6e0da0c8211209aa7f3e0a72db0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863022 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by: -
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9fdb14b94056..b582d244f316 git log 9fdb14b94056..b582d244f316 --date=short --no-merges --format='%ad %ae %s' 2019-10-18 vapier@chromium.org gconv_strip: drop old ahocorasick support 2019-10-18 jrosenth@chromium.org run_tests: enable Python 3 for git, patch, gob_util unit tests Created with: gclient setdep -r src/third_party/chromite@b582d244f316 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ic07e014c55adf430ea6c34cbabd7fd34701f1533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868082Reviewed-by:
-
Takuto Ikuta authored
This is to fix https://ci.chromium.org/p/chromium/builders/ci/Deterministic%20Linux/25327 The script reads //chrome/VERSION https://cs.chromium.org/chromium/src/tools/flags/generate_expired_list.py?l=31&rcl=1fbbcc1d5355dae3c52ed9a8c74f71bc4f4e7070 Change-Id: I0f1bd5e6e091e1cc3e016588f21ba8128f6d366d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868218 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Cr-Commit-Position: refs/heads/master@{#707277}
-
Raphael Kubo da Costa authored
The failure was introduced by commit f206f95f ("Test that access to Generic Sensor APIs is autogranted"). Looking at the trybot results in that CL, the test timed out even back then, and I think the lines added by that commit never worked. When content_shell is running in web_tests mode, all permissions are denied by default unless testRunner.setPermission() is called. Switch the expectations from "granted" to "denied" just like all other tests in the file. Bug: 863896 Change-Id: I1085352da5a94492b2b8bfa0c413cd3846c8f14d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866514Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#707276}
-
Victor-Gabriel Savu authored
The current UMA, InvalidDevicePolicyFiles, that logs the number of invalid files doesn't allow to understand if all the files are broken (which might suggest a disk corruption). This change introduces InvalidDevicePolicyFilesStatus logs if no, some or all files are invalid. CL that implements the code change: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1863798 Bug: 10148806 Change-Id: I79841e847a78f1b965f56e7b9616501b85966483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864771Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Cr-Commit-Position: refs/heads/master@{#707275}
-
Matt Falkenhagen authored
Android's New Tab Page has an empty site URL by design to let navigations from the NTP use the same process. The site URL is assigned after the navigation is committed. However, this doesn't interact well with SW. SW is created in a process suitable for the service worker's script URL, and the navigation stays in the NTP process, so the SW is out-of-process which has a performance and memory cost. With this CL, when the SW process is chosen, it takes a process that hasn't yet been assigned to a SiteInstance. The idea is to choose the Android NTP process. Bug: 1012143 Change-Id: I423de186982a11c68e4c2bec7b5ca56b3245f62c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849473 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#707274}
-
Primiano Tucci authored
Manually fix API change in protozero iterator. https://android.googlesource.com/platform/external/perfetto.git/+log/45f9f6cebc3a..95524e4897be git log 45f9f6cebc3a..95524e4897be --date=short --no-merges --format='%ad %ae %s' 2019-10-17 treehugger-gerrit@google.com Merge "Clarify sampling rate unit of power rails." 2019-10-17 treehugger-gerrit@google.com Merge "processor: Move json, fuchsia, systrace parsers to importers subdirs" 2019-10-17 treehugger-gerrit@google.com Merge "protozero: Remove untyped accessor for RepeatedFieldIterator" Change-Id: I1407d7ff0a067c3c30c965bc55b5bd48b21f2995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864664 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Auto-Submit: Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#707273}
-
Yuta Kitamura authored
Bug: 999409 Change-Id: I97e343f985b23087a958cd5182663733a52d35bb Tbr: mpawlowski@opera.com Tbr: mattreynolds@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868570Reviewed-by:
-
Hajime Hoshi authored
This adds new metrics for eviction by back-forward navigation: BackForwardCache.NotRestoredReason BackForwardCache.NotRestoredReason records the reason why the page cannot be put into the cache, e.g., due to disallowed features. BackForwardCache.EvictedReason is now merged with BackForwardCache.NotRestoredReason by this CL. Bug: 1004676 Change-Id: I2af3d49b806ee731c296e716513d16fb732f988d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827099 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#707271}
-
Yuta Kitamura authored
Bug: 1015737 Change-Id: I595c11f58a7b7c5d2b13241e1c06dc71787493da Tbr: rtoy@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868531Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium a08aa5a7. With Chromium commits locally applied on WPT: 6386d9d8 "Update service_worker_unregister_and_register()" 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" ba49a3d6 "autofocus: Change the timing of 'flush autofocus candidates'" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I66d51f4884195a11328bbb725e9ca83309a4a6f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866820Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707269}
-
Wenbin Zhang authored
In order to ensure homogeneous fleets, we need to have more specific dimension values when looking for bots. This set of CLs updated some existing dimensions, and added the synthetic_product_name values for dimensions if appropriate. This CL updated the dimensions for Win 7 Perf: - Added synthetic product name 'PowerEdge R210 II (Dell Inc.)'; - Updated GPU from '102b:0532' to '102b:0532-6.1.7600.16385'. Please check the link below for the available bots based on the old/new dimensions: https://chrome-swarming.appspot.com/botlist?c=id&c=task&c=gpu&c=os&c=pool&c=status&c=synthetic_product_name&d=desc&f=gpu%3A102b%3A0532&f=os%3AWindows-2008ServerR2-SP1&f=cpu%3Ax86-64&f=pool%3Achrome.tests.perf&s=synthetic_product_name Bug: chromium:996830 Change-Id: I1fc8278887a8e362958205f1cccde11f1f129030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867473Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#707268}
-
Noel Gordon authored
TreeItem handles the item content creation, label, tree parent_ etc so remove local ShortcutItem code related to that. Bug: 992819 Change-Id: I137853c9f85db7c78516cbe708cc79186f449412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868351 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#707267}
-
Peter Kasting authored
Bug: 82078 Change-Id: I5883996d3474f10898689defc6bdfd0932b332f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866263 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#707266}
-
Alan Cutter authored
The current merge process for Phase 3 (late beta/stable) doesn't cover cases where it's unclear whether the severity of the issue meets the requirements for merging. This CL adds a segment to tell the engineer to consult the TPM/their manager. Bug: 1015723 Change-Id: Ia8406f47be7e0ed6ce87b6f4b3bf4cc9ecca78ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868213Reviewed-by:
Josafat Garcia <josafat@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#707265}
-
Noel Gordon authored
TreeItem handles the item content creation, label, tree parent_ etc so remove local AndfroidAppItem code related to that. Bug: 992819 Change-Id: Idc618323fdfae016c2e8788f3d54148ae33f38b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868352 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I0a08bf275b625ca03d0113fee1babe204ac7c1a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867918Reviewed-by:
-
Alex Danilo authored
Checks the behaviour of createPanelItem(), attachPanelItem() and removePanelItem() with different ordering of API calls. Checks changing feedback panel types. Adds 2 getters to the feedback panel API to help testing. Bug: 1009318, 1009853 Tests: browser_tests --gtest_filter="FileManagerJsTest.FilesDisplayPanel" Change-Id: Ie7b2a198b0259c344418dcb21ca0208de0837cdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865915 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
While it's nice on its own to handle this, this CL can also be used as an example to lean on when implementing block fragmentation support in other layout modes, such as flexbox and tables. We still don't support early breaks before column rows. That may also be a useful thing to support, but it would require some more work, since we'd need another way of specifying early breaks, because column rows aren't uniquely identified by nodes. NGEarlyBreak currently only supports breaks before line numbers or nodes. Bug: 829028 Change-Id: Id1517790826223402c6ea4cd72ca565e0bd0e368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865325 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#707261}
-
