- 02 Oct, 2018 40 commits
-
-
Andrew Comminos authored
Having a large amount of <script> tags on a page with an invalid type for execution (e.g. text/html) triggers the same path for event loop yielding as JavaScript tags, causing slowness due to parser yields and unnecessarily aggressive chunking. Avoid performing this logic if the ScriptLoader can't recognize the script type. This reduces the amount of time it takes for DOMContentLoaded in the script attachment for issue 873648 from 367ms to 208ms, similar to the div attachment's 209ms. R=kouhei@chromium.org Bug: 873648 Change-Id: I4c7ea76feb2034f5ff97fe08b481c790b9a35122 Reviewed-on: https://chromium-review.googlesource.com/1247230Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#595719}
-
Trent Apted authored
Nothing inherits from the Mac MenuController, except its own tests. It also sends out some notifications that were once used by a test, which was recently deleted. Bug: 832676 Change-Id: Ie95206a3a17461c41683422d61f5a18e4ae5c95a Reviewed-on: https://chromium-review.googlesource.com/1250466Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#595718}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/083bc1576a0e..16c9216905c1 git log 083bc1576a0e..16c9216905c1 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 reed@google.com remove LEGACY_SVG code, as no one defines that flag anymore. Created with: gclient setdep -r src/third_party/skia@16c9216905c1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: Ib325eecbe8973bf4cde4907cc49a749aed4fe0d4 Reviewed-on: https://chromium-review.googlesource.com/1256225Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595717}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/399029db4a18..421d954080fe Created with: gclient setdep -r src-internal@421d954080fe The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I92cdfc345b8ca07ece9eb5248ca4d7f3c5d24c7d Reviewed-on: https://chromium-review.googlesource.com/1256226Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595716}
-
Luis Hector Chavez authored
I'll be leaving the team soon, you'll still have good reviewer coverage across timezones. BUG=b:116761000 TEST=None Change-Id: Id323102da135ad095b408bbbb5102ce469b8321f Reviewed-on: https://chromium-review.googlesource.com/1252323 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#595715}
-
Robert Ma authored
Do not attempt to comment on CLs in dry run mode. Change-Id: I141d143674b22d47021ea425259491d3698ebf2d Reviewed-on: https://chromium-review.googlesource.com/1255964Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#595714}
-
Sathya Gunasekaran authored
Atomics.notify is the new alias for Atomics.wake. This use counter lets us figure out if Atomics.wake can be deprecated without breakage. V8 use counters were added here: https://chromium-review.googlesource.com/c/v8/v8/+/1234581 Bug: v8:7883 Change-Id: I8eb7f32535aa3d913362aae1544e1dc2f595d38e Reviewed-on: https://chromium-review.googlesource.com/1255587Reviewed-by:
Ben Smith <binji@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#595713}
-
Tetsui Ohkubo authored
This CL applies same anchor insets to both UnifiedSystemTray bubble and volume slider bubble. It gives 8dip padding between the shelf and the volume slider (see the screenshot in the bug). TEST=manual BUG=888182 Change-Id: Idd455bb272cf58fb023a69359cd6ec68755a2b59 Reviewed-on: https://chromium-review.googlesource.com/1250461 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#595712}
-
Marijn Kruisselbrink authored
Bug: 872462 Change-Id: I0f20f1c71d3d9aee53a2f875198e1e4b3461d90c Reviewed-on: https://chromium-review.googlesource.com/1232397Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#595711}
-
BUG=762641 TBR=sammiequon@google.com Change-Id: I68b6fabc93058316d96f0508c3b8ead15a4bd25e Reviewed-on: https://chromium-review.googlesource.com/1256070Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595710}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I328e26bb479248995ced0d1a7dcc2867c6247f78 Reviewed-on: https://chromium-review.googlesource.com/1256443Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#595709}
-
Istiaque Ahmed authored
Add a test that verifies that runtime.onStartup fires on Service Worker based extension upon chrome start. This CL also expands "runtime" feature to "extension_service_worker" context type. Bug: 891016 Change-Id: I4a11f6da2f5311d7901ad8bb05c348b9343fe701 Reviewed-on: https://chromium-review.googlesource.com/1255588 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#595708}
-
Scott Chen authored
This CL preemptively fixes closure annotations for all NUX-related JS files, there will be a follow-up CL to actually enable closure compiling on these files. Bug: 874151 Change-Id: I67d56d7b0cffc2c8fa8134c03bf748eaaf79c376 Reviewed-on: https://chromium-review.googlesource.com/1256362 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#595707}
-
Xing Liu authored
This CL hooks the video thumbnail backend to the UI layer of new download home. Bug: 826021 Change-Id: I190ad09e8231d94d7546128bd1d22dc39f4d5f35 Reviewed-on: https://chromium-review.googlesource.com/1247529 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#595706}
-
Fergal Daly authored
Bug: 864900 Change-Id: I9228f1d475e19786ce675da93210c08b54bc3988 Reviewed-on: https://chromium-review.googlesource.com/1250523 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#595705}
-
rbpotter authored
Add a new mixin for the new input container, which is needed by the PDF viewer. Also move background-color styling to the existing --cr-input-background-color so it is applied to both the container and the input. Bug: 888985 Change-Id: I60e1dfe6828ba2d198984ed9ca33d0753aaa1308 Reviewed-on: https://chromium-review.googlesource.com/1244831Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#595704}
-
Luciano Pacheco authored
This fixes the perception to users that the dialog is taking too long to disappear. Test: No change in behavior, so current test suite should cover it. Additionally, manually tested file manager file deletion confirmation. Bug: 883659 Change-Id: I414a7282f70a64c0826954ef850a16e0bc37182e Reviewed-on: https://chromium-review.googlesource.com/1242725Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#595703}
-
Scott Wu authored
This check is needed since iOS Chrome is returning nullptr in GetPasswordAutofillManager() https://cs.chromium.org/chromium/src/ios/chrome/browser/passwords/ios_chrome_password_manager_driver.mm Bug: 890655 Change-Id: I33951b54d0e618f861284df7aeabcbf3d9e1681b Reviewed-on: https://chromium-review.googlesource.com/1253164 Commit-Queue: Scott Wu <scottwu@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#595702}
-
yusukes authored
BUG=b:116761000 TEST=None Change-Id: I48c405c71f7fbe5ca57912f970ab5b271750dc6c Reviewed-on: https://chromium-review.googlesource.com/1253212Reviewed-by:
Pawel Osciak <posciak@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#595701}
-
Steve Anton authored
Bug: 864871 Change-Id: I710b18f8644be51d08b33b9852c00f4fbacec286 Reviewed-on: https://chromium-review.googlesource.com/1208961Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#595700}
-
Nico Weber authored
Bug: 832676 Change-Id: I1ca68200cd3555fe6ff77ca63eb5d5a61dccfdc3 Reviewed-on: https://chromium-review.googlesource.com/1255862 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#595699}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9cb89c11. With Chromium commits locally applied on WPT: 92605c16 "[Unified Plan] Remote MediaStreamTracks should be muted by default." 534cd7bb "isXXX methods added to TrustedTypePolicyFactory" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25735 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jochen@chromium.org, estark@chromium.org: external/wpt/referrer-policy NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I80101b075d8390707bdd52c9e67d594fff9771a8 Reviewed-on: https://chromium-review.googlesource.com/1255454 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#595698}
-
Theresa authored
TBR=huayinz@chromium.org BUG=891089 Change-Id: I4d4c6fbdb2d845b0639f0eab05f4b043a2a9a15e Reviewed-on: https://chromium-review.googlesource.com/1256108 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#595697}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/ce342184e625..e8b02fb54234 git log ce342184e625..e8b02fb54234 --date=short --no-merges --format='%ad %ae %s' 2018-10-01 rharrison@chromium.org Add XFA BMP pixel test 2018-10-01 rharrison@chromium.org Add XFA TIFF Deflate pixel test 2018-10-01 rharrison@chromium.org Add XFA TIFF PackBits pixel test 2018-10-01 rharrison@chromium.org Add XFA TIFF LZW pixel test 2018-10-01 rharrison@chromium.org Add XFA PNG pixel test 2018-10-01 rharrison@chromium.org Add XFA TIFF pixel test 2018-10-01 thestig@chromium.org Remove checks for impossible situation in CPDFXFA_Context. Created with: gclient setdep -r src/third_party/pdfium@e8b02fb54234 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Id6d2f742b7ae49d81c56acce5ca096da1d4bc3c2 Reviewed-on: https://chromium-review.googlesource.com/1255569Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5f45e6651864..957c62e0d63e git log 5f45e6651864..957c62e0d63e --date=short --no-merges --format='%ad %ae %s' 2018-10-01 kron@webrtc.org Use timestamp instead of seq_num to distinguish between packets. 2018-10-01 nisse@webrtc.org Move call of stat's OnPreDecode to VideoReceiveStream::Decode 2018-10-01 ssilkin@webrtc.org Set key frame request in VP9 enc wrapper on init. 2018-10-01 oprypin@webrtc.org Revert "Tidy up and increase exception handling in compare_videos" Created with: gclient setdep -r src/third_party/webrtc@957c62e0d63e The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id09937ffef84650fa06ce34eed3107d0b5bce174 Reviewed-on: https://chromium-review.googlesource.com/1255510Reviewed-by:
-
Scott Chen authored
This adds the back-end functionality of setting default for the NUX set-default module, by subclassing a very similar handler from Settings. There will be follow-up CLs to match front-end with mock. Bug: 874122 Change-Id: I2e54ed7846e036cf48f4d6b22f2a7b867d65baa6 Reviewed-on: https://chromium-review.googlesource.com/1222914 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
-
Koji Ishii authored
This patch fixes AddOutlineRects to include continuation when the first line is empty. In such case, NGInlineLayoutAlgorithm suppresses box fragments, and thus we cannot reach to the continuation by traversing fragment tree. This patch detects such case and traverse the first LayoutInline instead. Bug: 889721 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I0e3bbd895501231b76775b074b35310037a3e113 Reviewed-on: https://chromium-review.googlesource.com/1252484Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#595693}
-
Tiansong Cui authored
Continuous Bluetooth scan may cause scan results to accumulate. This can result in large memory usage if there are other devices advertising with randomized MAC addresses. We limit the scan result cache to 1024 entries to prevent this situation. We kick out the least recently used entry when limit is reached. Bug: internal 116650055 Test: cast_bluetooth_unittests, manual. Change-Id: Ife0161a6edbc4354133dc158d0901ddce6ef876a Reviewed-on: https://chromium-review.googlesource.com/1255630 Commit-Queue: Tiansong Cui <tiansong@google.com> Reviewed-by:
Bailey Forrest <bcf@chromium.org> Cr-Commit-Position: refs/heads/master@{#595692}
-
Carlos IL authored
Starting implementation of go/auto-upgrade-mixed, adds the variations flag and auto upgrades all mixed content (with no fallback) if it is set. Further CLs will filter by mixed content type (blockable vs optionally blockable) depending on variations parameters, and will add fallback. Change-Id: Ic14124fe21ba08dc34738fdedebe2a37fb73ac3d Reviewed-on: https://chromium-review.googlesource.com/1249094 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#595691}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2a44a65dc4a9..399029db4a18 Created with: gclient setdep -r src-internal@399029db4a18 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I5e1c76695c9b8d79767e2669e9afe5f70d04a263 Reviewed-on: https://chromium-review.googlesource.com/1255513Reviewed-by:
-
Kevin Marshall authored
The issue which prompted reverts on "mac_upload_clang" and "linux_upload_clang" had to do with incorrect platform-specific paths to the GN tool. Summary of reverts: Reland "Revert "Roll Fuchsia SDK from 98ba6c8440c2 to b9dd8279f122"" This reverts commit 6be9416c. Reland "Revert "[Fuchsia] Remove namespace_path parameter from FIDL targets"" This reverts commit c354aa9a. Reland "Revert "[fuchsia] Reland "Generate BUILD.gn from SDK metadata...""" This reverts commit 712b3456. TBR=sky@chromium.org Bug: 889839 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I46650fb6c7887393c409bd13d9f0851a5630c88e Reviewed-on: https://chromium-review.googlesource.com/1252013 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#595689}
-
Parastoo Geranmayeh authored
Using the Autofill Profile Validation API, we can validate some data on the CLIENT side, and set the validity states in the Autofill Profile. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I144117287972587ae2c99afded0b792d3ed58874 Reviewed-on: https://chromium-review.googlesource.com/1239175Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#595688}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a7a52b9de36c..083bc1576a0e git log a7a52b9de36c..083bc1576a0e --date=short --no-merges --format='%ad %ae %s' 2018-10-01 michaelludwig@google.com Update parameter generation for randomized gradient tests 2018-10-01 thakis@chromium.org Remove a few exit-time destructors. Created with: gclient setdep -r src/third_party/skia@083bc1576a0e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:101600 TBR=mtklein@chromium.org Change-Id: If414a9f2810aa659d750b2b6548ef28433ffcb82 Reviewed-on: https://chromium-review.googlesource.com/1256223Reviewed-by:
-
mark a. foltz authored
r594911 added unguessable_token.mojom as a dependendy of origin.mojom. This imports the JS bindings for unguessable_token.mojom into the Media Router component extension bindings to prevent a JS exception when validating a message that includes an Origin. Bug: 890916 Change-Id: I83426296abbf911587367ffbd0b002a6c1525522 Reviewed-on: https://chromium-review.googlesource.com/1255585 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#595686}
-
Yoichi Osato authored
Design doc: http://bit.ly/2Njo0zR This patch introduces |SelectionInDOMTree ComputeLayoutSelection (const SelectionInDOMTree&)| for replacing CreateVisiblePosition at ComputeLayerSelection. The new adjustment algorithm is based on LayoutSelection and really simple: pick SelectionState::kStart/kEnd nodes. They are the start/end nodes of selection painting. For caret, caret positioning should be done before LayoutSelection, thus ComputeLayoutSelection() returns as-is. Though ComputeLayoutSelection is targeting to replace CreateVisibleSelection, there is difference because of simplicity: it doesn't consider contenteditable, block-end BRs nor any InlinBox matter. The difference is also tested at layout_selection_test.cc Bug: 789870 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I9de9fef6e76ff65c1b2575c47d39e156d8e56380 Reviewed-on: https://chromium-review.googlesource.com/1182710Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#595685}
-
gogerald authored
Bug: 806868 Change-Id: Iffbbac28a2712e59e2c5a59c733c18b46b90f9ef Reviewed-on: https://chromium-review.googlesource.com/1256015Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#595684}
-
Nick Harper authored
TBR=bnc@chromium.org Change-Id: I439602d0a330f87efc14e384c56df343b60d2a50 Reviewed-on: https://chromium-review.googlesource.com/1256210Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#595683}
-
Daniel Rubery authored
This was used to evade referrer chain attribution. However, the problem was already fixed at HEAD by the time we discovered what was wrong, so this CL just adds a browser test to ensure that we don't regress. Change-Id: I69b3189a873288509fb8bdad02c248598819e07c Reviewed-on: https://chromium-review.googlesource.com/1256105 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#595682}
-
Ahmed Fakhry authored
This CL changes the default app order according to PRD at go/default-apps. It also introduces a mechanism to add default page breaks that are part of the default sort order so that we're able to make default apps span multiple pages if desired. Default page breaks should only be installed for first-time users, or users who already have them in their remote sync data. BUG=880506 TEST=Manually by installing an image on device, also added a test. Change-Id: I4882e3a6b76b81862686b2eba0d1bd76d0ec4b35 Reviewed-on: https://chromium-review.googlesource.com/1212704 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#595681}
-
Andres Calderon Jaramillo authored
This CL moves RecordJpegImageArea() from JpegImageDecoder to BitmapImageMetrics to centralize the recording of UMAs for JPEGs and to be consistent with the color space UMA. The method is renamed to CountJpegArea() to be consistent with other methods in BitmapImageMetrics. Bug: 886914 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Idd0dc443a7e742065a158ee19adeb242479a245f Reviewed-on: https://chromium-review.googlesource.com/1249399 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
-
