- 12 Dec, 2017 40 commits
-
-
Penny MacNeil authored
- kFileNotFound and kArraySizeZero now treated as kSuccess. - Updated shared definitions in whitelist_packed_format source set. New timestamp to track last load attempt in local cache. Added relative path and file name too. - Decision made to check is_sorted on array during init. The array will be smaller than in original design, so speed hit will be minimal. - New tests. BUG=769590 TEST=chrome_elf_unittests.exe, WhitelistFileTest.* Change-Id: I45c4321ccdf89d8768509c0dad21c9c15f73c4e3 Reviewed-on: https://chromium-review.googlesource.com/794551 Commit-Queue: Penny MacNeil <pennymac@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#523544}
-
Dominick Ng authored
https://crrev.com/c/737610 fixed a performance issue in WebsitePermissionsFetcher by overriding android.util.Pair's hashCode method. This allowed a previous fix for a NullPointerException crash on Android pre-Kitkat to be removed. Unfortunately, the pre-KitKat crash occurs not only in the hashCode() method, but also in the equals() method. This CL overrides equals() with an implementation that correctly handles nulls. The implementation is taken from the CL which introduced correct null handling to android.util.Pair - https://android.googlesource.com/platform/frameworks/base/+/162fabbcf81157fddab1c38de09bdabaff8c068a%5E%21/#F0 BUG=793974 Change-Id: Ica6b102146222fbeac98c3179dbcf0c9ef101f85 Reviewed-on: https://chromium-review.googlesource.com/821330Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#523543}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/8cc672aa9c1c..d076c5980367 $ git log 8cc672aa9..d076c5980 --date=short --no-merges --format='%ad %ae %s' 2017-12-11 simonhatch Dashboard - Parallelize some things in /add_histograms_queue Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I92852cee232fa1d454ada70f4b221038d067c430 Reviewed-on: https://chromium-review.googlesource.com/822452 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523542}
-
Sadrul Habib Chowdhury authored
Start running content_unittests with the --mus flags on linux-chromeos bots. BUG=786453 Change-Id: Ied53b0f651dbec49ee7a3224623bb69343eaf891 Reviewed-on: https://chromium-review.googlesource.com/817691Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#523541}
-
Paul Miller authored
UpdateEnabledState is really 2 functions in one: UpdateEnabledState(true) is only called from Enable, and UpdateEnabledState(false) is only called from ~Connector. Despite its name, UpdateEnabledState(false) must not actually disable accessibility, because of bugs 775532 and 792269. So fold the 2 parts into their respective call sites. BUG=792269 Change-Id: Ie7afcebda79820d4856a8b050f9b865c2bd1f5c3 Reviewed-on: https://chromium-review.googlesource.com/812084Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523540}
-
Tarun Bansal authored
A URLRequest is heuristically marked as hanging if its value is M times more than the transport RTT estimate, and/or N times the HTTP RTT estimate. A throughput observation window is marked as hanging by comparing the duration of the window with the HTTP RTT estimate, and the number of bytes received during the window with the expected congestion window size. Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Bug: 765378 Change-Id: Ia215102194a4426cf6c447a629e29145fa8cb13c Reviewed-on: https://chromium-review.googlesource.com/777855Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#523539}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/c896eddc1cf7..09757b29feeb $ git log c896eddc1..09757b29f --date=short --no-merges --format='%ad %ae %s' 2017-12-12 kjlubick Fuzz skpicture with ReadBuffer 2017-12-12 robertphillips Remove GrBackendObject from tests (except image_from_yuv_textures) 2017-12-12 angle-deps-roller Roll skia/third_party/externals/angle2/ 7f5c3eb76..3c613c0d7 (1 commit) 2017-12-11 halcanary dm: require tmpDir, reasonable defaults Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: I678b50b539327c401c4218ac2b31e7e5a4bd75f9 Reviewed-on: https://chromium-review.googlesource.com/822600Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523538}
-
Scott Chen authored
Bug: 793369 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If5b0fe0db0ddbbacce655ef90cd8fe3d135982d0 Reviewed-on: https://chromium-review.googlesource.com/817939 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#523537}
-
Devlin Cronin authored
One of the variants of ModuleSystem::RunString() was unused. Remove it. Bug: None Change-Id: I551b5b2baec597d20d8923578b52ea6f02a169ce Reviewed-on: https://chromium-review.googlesource.com/822730Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#523536}
-
Erik Luo authored
A recent CL to persist sidebar state introduced a regression where the console sidebar is open by default. It should be closed by default. Bug: 794236 Change-Id: Ia9e58843bc10b7cbbe94aae511ca05a1a833b5f3 Reviewed-on: https://chromium-review.googlesource.com/822598 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523535}
-
Parastoo Geranmayeh authored
In the Payment Request and the Autofill address editor, for the admin area field (state/province), the default selection must be the hint (which is "Select"). Previously, the default was the first item in the list. BillingAddressAdapter is used for both Card Editor and Address Editor dropdown lists. Modify it so that it works correctly for Address Editor as well. Bug: 793436 Change-Id: Ib91b9d62105f255edddbc67fc295387e23aaffb2 Reviewed-on: https://chromium-review.googlesource.com/820050 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#523534}
-
Ryan Sturm authored
This tracks network and cache bytes and rounds them to a lower bounding exponential bucket threshold before reporting them to UKM. Bug: 723703 Change-Id: Ica14f0c7e396c9086e71f6cdc3c9b869cf75d0a8 Reviewed-on: https://chromium-review.googlesource.com/791529 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#523533}
-
Nicolas Pena authored
This CL adds toJSON to the following: * PerformanceLongTaskTiming * PerformanceResourceTiming * TaskAttributionTiming * Performance within workers Link to Intent to Implement and Ship thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/ZnXvNe_wNyk Bug: 740094 Change-Id: I54622b9bd213fd806a9108598ccf4798c2ceffa2 Reviewed-on: https://chromium-review.googlesource.com/802019Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#523532}
-
Tom Anderson authored
Example flakes: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65337 https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65304 https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65296 BUG=799129 TBR=pavely@chromium.org Change-Id: Id9775baf2e5f82e7c5b7a9bd3194cf24dd3ad74e Reviewed-on: https://chromium-review.googlesource.com/822980Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#523531}
-
Charles Harrison authored
The experiment is over and this could mask real improvements on the critical loading path, especially CPU performance wins on the IO thread. Bug: None Change-Id: I904e1be21961aca3e35245f569651700f1b0dad8 Reviewed-on: https://chromium-review.googlesource.com/822298Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523530}
-
Ned Nguyen authored
Bug:786385,786010 TBR=eyaich@chromium.org NOTRY=true Change-Id: I0fd582abd70963b56616c90434ebbf3971f0adaf Reviewed-on: https://chromium-review.googlesource.com/822978Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#523529}
-
Scott Chen authored
Bug: 793397 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id9ae040cfc149fe3483156ab80dfaeaa5a2566de Reviewed-on: https://chromium-review.googlesource.com/817371Reviewed-by:
-
Tom Sepez authored
The restriction is only required when "temporary file" permissions have been granted, since that is what implies no access to pre-existing files. Fixes the issue hit by https://chromium-review.googlesource.com/c/chromium/src/+/818486 in that the network service may try to ensure a file is present via a single call with O_CREAT without knowing if it pre-exists. Change-Id: I3cf3f2389a78a5a46f43505a64d106614e4dcf90 Reviewed-on: https://chromium-review.googlesource.com/820611 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#523527}
-
Shivani Sharma authored
HttpCache.ParallelWritingPattern histogram's 0 enum value is actually a valid value and not undefined. This CL fixes the description and adds tests for testing the 0 value. Bug: 472740 Change-Id: Iac4cdb38b6141221e901003e3540c60228626400 Reviewed-on: https://chromium-review.googlesource.com/820191Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#523526}
-
Dave Schuyler authored
This CL replaces some examples of using old i18n with new $i18n{} replacements. Bug: 677338 Change-Id: Ibdd8b98bd067262879ea11842b5b20c2c4ac34e7 Reviewed-on: https://chromium-review.googlesource.com/820550 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#523525}
-
Boris Sazonov authored
This CL implements account list filtering when there are multiple accounts on the device and one of these accounts is a child account. In this case AccountManagerFacade will expose the child account only. Bug: 779568 Change-Id: I70fb00fc692e3f54c779ac618167afd9ad728c09 Reviewed-on: https://chromium-review.googlesource.com/819414Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#523524}
-
Maks Orlovich authored
In particular the motivating case was when the partial write was before the bitmap... ... however this is done by rewriting the function entirely to be formulated in terms of net::Interval, since I found the details of the original pretty much inscrutable, but believe to have understood both the data representation and the interface. Bug: 791056 Change-Id: I297ee4cbcfc204df8ccab9c45145eaf0a82eb0b7 Reviewed-on: https://chromium-review.googlesource.com/806687Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#523523}
-
Daniel Hollingshead authored
This cl lands server change 177974921 by dahollings. BUG=488484 Change-Id: Idcfd03b2163aded499ea6858a490f0b80146ba4d Reviewed-on: https://chromium-review.googlesource.com/821092Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Daniel Hollingshead <dahollings@chromium.org> Cr-Commit-Position: refs/heads/master@{#523522}
-
Will Chen authored
Part manual, part automated migration for these tests. Many of these weren't html tests and require special treatment (typically navigating the inspected page to a special resource file). Bug: 667560 Change-Id: I70d5813346e2a59abf1f72390189c76563fbd023 Reviewed-on: https://chromium-review.googlesource.com/820605Reviewed-by:
-
Randy Smith authored
This refactor is to remove the passed URLRequestContextGetter as an argument, preperatory to shifting cookie deletion in StoragePartitionImpl over to Mojo interfaces. Bug: 721395 Change-Id: I4568cb5ffd98591605a7c5d8b3850c5d8cd5d9b7 Reviewed-on: https://chromium-review.googlesource.com/754518 Commit-Queue: Randy Smith <rdsmith@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#523520}
-
Scott Graham authored
In order to roll GN f3a5b8c1..a37803c9 (r520777:r523254) and pick up the following changes: a37803c9 Don't print warning for unused default args 06ebd496 GN: don't deadlock when encountering import loops e48b26a4 Remove base::Value::IsType 6713d85d Generate relative paths for build.ninja and build.ninja.d TBR=dpranke@chromium.org Change-Id: I1cb88049988dd4c3ccfd858909a31830cd9acb8c Reviewed-on: https://chromium-review.googlesource.com/821210Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#523519}
-
Artur Khachatryan authored
Test ChromeLoggingCapabilityTest.testPerformanceLogger is flaky on Android. Disabling for now until the bug is fixed. Bug: chromedriver:2108 Change-Id: I12fabca049de4e5366e426e519ef4e84e1a6c873 Reviewed-on: https://chromium-review.googlesource.com/822918Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#523518}
-
Eric Lawrence authored
TBR=palmer@chromium.org Bug: 794171 Change-Id: I7b418f308affbde0586aca0c15f7578b073ac9d8 Reviewed-on: https://chromium-review.googlesource.com/822292Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Commit-Queue: Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#523517}
-
chrome://gpuSunny Sachanandani authored
Relying on "Supports overlays" is misleading because we might be using direct composition surfaces without overlays. R=piman,zmo BUG=776403 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I468e73fb0ec75fb03fe5e5273001c36d548b765b Reviewed-on: https://chromium-review.googlesource.com/820770Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#523516}
-
Abhishek Arya authored
R=dpranke@chromium.org Bug: 783296 Change-Id: Id7331db499a8e448c8e58cabab4e7b170e45db93 Reviewed-on: https://chromium-review.googlesource.com/821853 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/a4789fffa5f9..f7aa204aafe9 $ git log a4789fffa..f7aa204aa --date=short --no-merges --format='%ad %ae %s' 2017-12-12 dsinclair Move Script_Attribute_String to CJX_Object Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iecef075f30b2cef3a6124ee1437bffa36f6011e7 Reviewed-on: https://chromium-review.googlesource.com/822516 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523514}
-
Sunny Sachanandani authored
Worker context is on a different share group from compositor context so worker context lost notification does not propagate to compositor context. This is mostly fine because we restart the gpu process anyway but we don't for synthetic context loss such as out of memory conditions. R=piman,danakj BUG=786570 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I4afda056ba7399806c9dd56d83a2efb208c95847 Reviewed-on: https://chromium-review.googlesource.com/795184 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
-
Vladimir Levin authored
This patch makes it possible for cache entries to specify their own ids namespaced to the type of the entry. This makes it possible for things that already have unique ids to just use those, minimizing the risk of duplicate cache entries. At the same time the old behavior can be reproduced by a static incrementing id counter per cache entry type. R=ericrk@chromium.org, piman@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I76ebaf5650d2f44b1480420bbe7fe3b1726e6b92 Reviewed-on: https://chromium-review.googlesource.com/820600 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
-
Daniele Castagna authored
In order to debug dmabuf mmap failures, we added all parameters to the logs. Since dmabufs mmap issues have been addressed, this CL removes mmap parameters from the ERROR log. Bug: 629521 Change-Id: I09ea05956a60bdac53cd775534c979c5a7f82f95 Reviewed-on: https://chromium-review.googlesource.com/822814Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523511}
-
Egor Pasko authored
Small refactoring to eliminate the warning in Android Studio: "This AsyncTask class should be static or leaks might occur". There is not much benefit, because holding a reference (via the anonymous AsyncTask) to the instance of LibraryLoader won't change the lifetime of this LibraryLoader. There is some additional verbosity as well :/ Given the amount of subtleties around the use of AsyncTask, having uses of it being consistent with the Lint recommendation seems worth it. Bug: None Change-Id: I9e2d8c2c427bb6e565f3b4dc11c59904069c7b36 Reviewed-on: https://chromium-review.googlesource.com/819352 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#523510}
-
Ryan Sturm authored
Bug: 793137 Change-Id: Ifb14055f98fbe75523aaca6d61cf0ed85b9ef70c Reviewed-on: https://chromium-review.googlesource.com/820560 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#523509}
-
Robert Sesek authored
Bug: 598854 Change-Id: I0f2ad410d87e27bac5686091b31fbbab311acf14 Reviewed-on: https://chromium-review.googlesource.com/820855Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#523508}
-
Joshua Bell authored
Avoid key repeat triggering an unintentional commit of the subsequent dialog by launching the picker on the Enter keyup event rather than on keydown. Bug: 637098 Change-Id: Ia327a7a9f92c34fd3fcdf971d8c21a5ce744254b Reviewed-on: https://chromium-review.googlesource.com/814916 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#523507}
-
Thanh Le authored
The map data structure is not really a good fit since we can replace the data holds in the key to an attribute in the value field. Bug: 786996 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib3f62522f2b3ea8a890bc1ba21d56509d5f13e8f Reviewed-on: https://chromium-review.googlesource.com/817517Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Matt Menke authored
This CL passes in the path for the network service to open. It's an intermediary step towards opening the file in-process and passing the file handle to the service instead. Bug: 746977 Change-Id: Ic432cd2d78027a83e9f63e2bc2a66c0eea51b937 Reviewed-on: https://chromium-review.googlesource.com/811887 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Randy Smith <rdsmith@chromium.org> Cr-Commit-Position: refs/heads/master@{#523505}
-
