- 04 Jan, 2020 22 commits
-
-
Ted Choc authored
The issue is that the MotionEvent (ACTION_BUTTON_PRESS) was bleeding through the view hierarchy and being consumed by the underlying web contents, which would request focus away from the omnibox triggering an ACTION_CANCEL to be dispatched. The solution is to have the suggestion list consume any previously unconsumed mouse click events to ensure they do not bleed through to the sibling yet lower in the Z-axis views. BUG=968414 Change-Id: Ic29114419708a1bf4d7b4ccb03b7cd0144d6bcd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987073Reviewed-by:
Ender <ender@google.com> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#728360}
-
Stefan Zager authored
The first attempt at a fix was reverted, because we can't CHECK(!NeedsLayout()) at the end of a lifecycle update: https://chromium-review.googlesource.com/c/chromium/src/+/1972230 BUG=1035029 R=chrishtr@chromium.org Change-Id: I976c46b13c5a6789ca8df1142269c635cdaa1bb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986911Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#728359}
-
Stephen Chenney authored
Move all the web_tests for image-orientation to external/wpt. Update the testing methods to wpt standards. Adjust the test images to be ammenable to ref tests, though fuzzy matching is still required. Round out the test suite for <img> tags, content images and image documents. Bug: 158753 Change-Id: Iff393f350cbecfc66a91811c72b0ee6274289e5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980505 Auto-Submit: Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
Zhuoyu Qian authored
Per the spec [1], the ChooseFileSystemEntriesType should be lowercase, dash-delimited, such as `save-file`. [1]: https://wicg.github.io/native-file-system/#api-choosefilesystementries Bug: 1020715 Change-Id: Iafc02db7344c70589cf007a7d66b9cd3f9dda6a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981515Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#728357}
-
Mason Freed authored
The [1] CL enabled the FormControlsRefresh feature by default for Windows, Linux, and ChromeOS. In the process, many layout tests were disabled, because the form controls have a different appearance with the feature enabled. This is one of several patches rebaselining those disabled tests. [1] http://crrev.com/c/1967608 Bug: 1035582 Change-Id: I6d53990de99466a718bda5bff923b026b2b0c4a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986331 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#728356}
-
Donn Denman authored
Disable all tests in VrBrowserJavaScriptModalDialogTest before Android Oreo, where they are very flaky. They are solid on O+. BUG=1034735 TBR=tedchoc@chromium.org Change-Id: Icf2a34ea2ec2f682484afe5dc1e63af3ccdb5987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986954Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#728355}
-
Orin Jaworski authored
This CL adds 'change' and 'create' to synonym lists for two Pedals. To better track changes to this data, the source JSON data is also added for source control. Bug: 893183 Change-Id: I812e1c052b78dc72d7f1b4580ca4eaeb9b0338bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986428Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#728354}
-
Caleb Rouleau authored
Speculative fix. See bug for details. Bug: 1039019 Change-Id: I15ee33cfba36b1896b089147fd8fa6f6cd9e2459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986969 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#728353}
-
meacer authored
IDNSpoofCheckerTest.IDNToUnicodeThese takes a punycode hostname, passes it through url_formatter's IDN conversion logic and checks the output. If the hostname is safe, it expects the conversion result to be equal to the expected unicode value. Otherwise, it expects the result to be equal to the input punycode value. This means that the test doesn't actually use the expected unicode value if the conversion is not safe. As a result, a few invalid values have made it to the expected_unicode field of the tests. This CL adds a sanity check to make sure that the expected_unicode field is indeed the unicode version of the input hostname. It does this by first doing an unsafe conversion disabling the spoof checks. The CL also introduces an enum with an "invalid" result type. This result is used for punycode that fail before coming to the spoof checks. Making this distinction seems important to be able to reason about why some inputs are failing. Bug: 1036523 Change-Id: Id1d2c374e5cb01900f61703418c21512c41b445d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979592 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#728352}
-
Tomasz Wiszkowski authored
ApiCompatibilityUtils.setImageTintList has correct support only for - Android Lollipop and Above, - AppCompatImageView class. Any other imageview will seem to work, but will receive no tint. Bug: 1038497 Change-Id: I7a7fcad80ff7b7ca3fb344448f27c5c093b25156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987266Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#728351}
-
chrome://extensionsToby Huang authored
This disable reason will be used in a downstream CL to force-disable the extension enable toggles when the extension state is BLOCKED. This force-disabling will prevent a regression to crbug/1003014. Bug: 1033687,1032352 Change-Id: I73788620179026f68a2b72ef9fc72429d7ab62ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975456 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#728350}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ibf6d6684c9b847a51a5e3b19f0906445c1354760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987229Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728349}
-
Peter Kasting authored
Without this, toggling between light/dark mode could produce hard-to-read text. Bug: none Change-Id: Ic61c5d61b2da5dc6d58485dd0c604ab34da7d614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986309 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#728348}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a5b4ab17af94..d3a10a0399c1 git log a5b4ab17af94..d3a10a0399c1 --date=short --first-parent --format='%ad %ae %s' 2020-01-03 hypan@google.com Add support of android app bundles for webview Created with: gclient setdep -r src/third_party/catapult@d3a10a0399c1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:986990 Tbr: sadrul@google.com Change-Id: Icbbe5dae89bc8dfb95f0224f18f48b59ec51e0f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987230Reviewed-by:
-
James Cook authored
We now have updated strings in go/cros-sync-mock, so remove some of the placeholders. There's still a placeholder for the feature description because that line will be replaced with a sync status component that requires more refactoring before I can use it. Bug: 1013466 Change-Id: I4ccfcb408dcf3b01088a158fa01567c69d7babd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986961Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#728346}
-
Donn Denman authored
This reverts commit 034ba71f. Reason for revert: Causing multiple WebView test failures. NOTE: The author is responsible for updating WebView's "exposed feature list," similar to the blink "exposed feature list" in updated in the original CL. BUG=1038974 TBR=dtapuska@chromium.org Original change's description: > Enable HrefTranslate > > Approved I2S https://groups.google.com/a/chromium.org/d/msg/blink-dev/gDLl4fKCr8Y/35aaeQ0fAgAJ > > BUG=872777 > > Change-Id: Ib45c1cebca2181f61d2fa29bd702fed8a99ff530 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979005 > Reviewed-by: Philip Jägenstedt <foolip@chromium.org> > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#728015} TBR=dtapuska@chromium.org,foolip@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 872777 Change-Id: I498180fb7ad9b15a265e38a0b253aba246057762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986963 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
-
Victor Fei authored
Previously, when a child has multiple static text nodes as its descendants, TextProvider::RangeFromChild would only return the range that encompasses the first two static text nodes. This change fixes this issue and now TextProvider::RangeFromChild returns a range that encompasses all the descendants of the child. This issue was uncovered by Windows Narrator scanning over a dialog, consider the following AXTree: RootWebArea ++Dialog ++++StaticText "Dialog label" ++++StaticText "Dialog description" ++++Button ++++++StaticText "ok button" ++++StaticText "Dialog details" Previously, Windows Narrator would only announce "Dialog label; Dialog description" for the dialog, which is due to 'RootWebArea.TextProvider::RangeFromChild(Dialog)' returns a range that only encompasses "Dialog label;Dialog description". Now, Windows Narrator can announce all the contents in the dialog. "Dialog label;Dialog description;ok button;Dialog details". Changes include: - Refactored the logic for retrieving the full text range for a given AxPlatformNodeWin from TextProvider::get_DocumentRange to AxPlatformNodeTextProviderWin::GetRangeFromChild helper function. So that both TextProvider::get_DocumentRange and TextProvider ::RangeFromChild have a unified logic for retrieving the full text range through GetRangeFromChild helper. - Added a unittest for TextProvider:::RangeFromChild which covers the case when a range has multiple static text children. - Refactored tests in *TextProvider_win_unittest. - Refactored and fixed tests in *TextChildProvider_win_unittest since they are depended on GetRangeFromChild helper function. Bug: 928948 Change-Id: Ief75ca060073b06828bf44f712c1cc844a046088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983552 Commit-Queue: Victor Fei <vicfei@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Adam Ettenberger <adettenb@microsoft.com> Cr-Commit-Position: refs/heads/master@{#728344}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b8f36ec0ec7a..bc5a2d004f61 Created with: gclient setdep -r src-internal@bc5a2d004f61 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I2f52f874f99184ee9bd78c55d2fd361836cef0fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987228Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728343}
-
Eugene Zemtsov authored
GpuVideoDecoderError and GpuVideoDecoderInitializeStatus should be safe to remove, since crbug.com/902968 was fixed about a year ago. Bug: 902968 Change-Id: I09710c71f0ef5fc04e7cd9acd8b97c8344808154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978156 Commit-Queue: Eugene Zemtsov <ezemtsov@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#728342}
-
Peter Williamson authored
This reverts commit aad41255. Reason for revert: This is being reverted by the build sheriff on suspicion of causing the following break. https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/16082 The following two tests seem to fail consistently after this changelist: RenderWidgetHostViewAuraTest.KeyEventRoutingWithKeyboardLockActiveForAllKeys RenderWidgetHostViewAuraTest.KeyEventRoutingWithKeyboardLockActiveForOneKey Original change's description: > Remove CompositorFrame handling in render_host > > This CL starts to remove code in content/browser/renderer_host/ that > existed to receive CompositorFrames and submit them to the display > compositor running on the browser UI thread. The VizDisplayCompositor > feature has launched so this code is no longer used. > > This CL is a first pass to delete code that doesn't have require > significant changes to tests. > > TBR=sky@chromium.org > > Bug: 759653, 812322, 1038683 > Change-Id: I7bf29f57e7418eb8d3a16b86169f2b30bb9fbf80 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978997 > Reviewed-by: Saman Sami <samans@chromium.org> > Commit-Queue: kylechar <kylechar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#728209} TBR=sky@chromium.org,kylechar@chromium.org,samans@chromium.org Change-Id: Ia0b20ebad951e8f22fb0f108cb9d09160e1a645c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 759653, 812322, 1038683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986978Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#728341}
-
Lijin Shen authored
This CL moves some hex values to color_palette.xml and and renames some colors for consistency in code base/with UX. Bug: 775198 Change-Id: I36b182f8d75ce73e1de6f2f635f693fa714f85ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900396 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#728340}
-
Peter Kasting authored
Such cases either mean an ID was added without ensuring its value was always set, or a caller asked ThemeProperties for a color directly when they should have gone through ThemeService. Bug: none Change-Id: Ib0af93a225145cdeea68bc3347b7038fd2a1a6e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986238 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#728339}
-
- 03 Jan, 2020 18 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a14d809391c8..f1b42a219fee git log a14d809391c8..f1b42a219fee --date=short --first-parent --format='%ad %ae %s' 2020-01-03 herb@google.com Use fCurrGlyph as the looping variable. 2020-01-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@f1b42a219fee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: I9d59df2aeef8d05569c2f631d6d04eba651e522e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986279Reviewed-by:
-
Charlene Yan authored
Previously, tabs would always get inserted to the end of the tab group. This changes it such that if the tab is currently to the left of the group, it will be inserted at the front of the tab group respecting the relative order of the selected tabs. If the tabs are to the right of the group, it will be inserted to the end of the tab group as before (no behavior change). This change also allows tabs in a group to be restored to the location saved at closing time, or the closest location if the group has moved. Bug: 1030779, 1038362 Change-Id: Id26cdfa2df769bc738d780e48277e603acef42ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977849 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#728337}
-
Julie Jeongeun Kim authored
This is a part of effort for using [RaisesException] when synchronously rejecting a promise. It uses [RaisesException] for //third_party/blink/renderer/modules/payments and updates all implementations to take ExceptionState&. It removes default argument for |result| from PaymentResponse::complete() as it has ExceptionState& for the last parameter, it has a default value, "unknown", from idl, it doesn't change any behavior. It also updates unit tests with EXPECT_EQ if the test throws an exception in promise-returning functions since it returns an empty ScriptPromise when it throws an exception. Bug: 1001114 Change-Id: I0fa34bbdca6e4476801da91e5edf6e3f6973be3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985820Reviewed-by:
-
Austin Eng authored
This test is no longer failing. Bug: 781668 Change-Id: I855acb188ea7ec82b22b462ab04cecf18c7215a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984378Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#728335}
-
liberato@chromium.org authored
Since we have multiple things that would like a stable estimate of the effective video playback, such as MediaCapabilities, the media power experiment, and "will ever play" learning experiment, this CL adds a centralized FPS computation / callback. FrameRateEstimator takes frame durations and buckets them to the nearest integer FPS. PipelineClient::OnVideoFrameRate relays changes to this estimate. Change-Id: I5699f3d83fd1b3406c6dc10e7cabe363f683487e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954356 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#728334}
-
Peter Kasting authored
This will be necessary in an upcoming CL to avoid infinite recursion; splitting to its own CL since it's no behavior change and arguably a tiny readability win. Bug: 878664 Change-Id: Ie6a4b79040f111f83ea0a4a400e7ab22cdaa6d62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986405 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#728333}
-
James Cook authored
Chrome browser recently renamed the browser settings "People" section to "You and Google". Chrome OS shared the string, so the OS settings section changed its name as well. We want to keep the OS section called "People", so introduce a new string for the label. Screenshot: http://screen/wCNpdUEhoXx TBR=rockot@chromium.org Fixed: 1038980 Change-Id: I06e3235b9ea987e0de1950307e610161e2ef85b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980507 Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
-
Caleb Rouleau authored
See https://bugs.chromium.org/p/chromium/issues/detail?id=1036846#c32 TBR=rmhasan@google.com Bug: 1036846 Change-Id: Ic635c6f4adf4a361c5449753c53aa43b49e12a55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987128Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#728331}
-
Pete Williamson authored
Disable flaky test HistoryListTest.All failed twice in three builds, and is a shows frequent flakes on the flakiness dashboard. Disabling until we can fix. Bug: 1038991 Change-Id: Ic281aea4e7d5cbf5cec9bdedddf23ca830752db4 TBR: rbpotter@chromium.org Change-Id: Ic281aea4e7d5cbf5cec9bdedddf23ca830752db4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987080Reviewed-by:
-
Mia Glaese authored
Follow up to: https://chromium-review.googlesource.com/c/chromium/src/+/1956187 Before: StartSurface state is not shown correctly when triggered through swipe down, because StartSurface state is not set in LayoutManager. StartSurface state is not always set in Activity. After: If state is not set (on swipe down), StartSurface defaults to SHOWING_HOME. Start Surface state is always set correctly in ChromeTabbedActivity. Bug: 1038276, 1038274 Change-Id: Ifbf7ece713a6866b2c9925d485f1ae3a27d24d51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981096 Commit-Queue: Mia Glaese <glamia@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#728329}
-
Tom Anderson authored
Due to C++ overloading rules, only some of the gbm_* wrapper functions were getting called. For example, if we were passing a char* where a void* was expected, the wrapper would get called, but if we passed exactly the arguments that function expects, the wrapper would not get called. To fix this, add macros that remap gbm_* to call_gbm_*. BUG=1031269 Change-Id: I1814be43f4e5b0f746a6e4a068a95c229a71d20b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981053 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#728328}
-
Philip Rogers authored
This test is now passing and no longer has additional hit test rects with CompositeAfterPaint. The result is equivalent to pre-CAP. Bug: 909749 Change-Id: I6fbbb32d8c35c27d71054346d5511b5c513bf177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987125 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#728327}
-
Andrew Xu authored
Layer::Clone(), which may be triggered by screen rotation, does not copy the mask layer. As a result, gradient zone for scrollable shelf may not show after screen rotation. This CL fixes the issue by checking the mask layer in ScrollableShelfView::Layout() and setting the mask layer if necessary. Bug: 1035715 Change-Id: I0f8adb1df9991066c2e6ff46a401a561fdb15204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986055 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#728326}
-
Ben Joyce authored
BUG: 965286 Change-Id: I61c48daea3dba4b0a12e0dc0727981b80da30174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967877 Commit-Queue: benjamin joyce <bjoyce@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Conley Owens <cco3@google.com> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e994380d00bb..a14d809391c8 git log e994380d00bb..a14d809391c8 --date=short --first-parent --format='%ad %ae %s' 2020-01-03 nifong@google.com Support using an externally manage list of images in UrlDataManager for wasm debugger. 2020-01-03 mtklein@google.com remove FAAA/FSAA bots 2020-01-03 mtklein@google.com remove redundant Debug bots that have ASAN bots Created with: gclient setdep -r src/third_party/skia@a14d809391c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: Iceb863f1f685635c8307e2b540123ddaf0296819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987106Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS orderfile from 81-3987.18-1577705382-benchmark-81.0.4011.0-r1 to 81-3987.18-1577705382-benchmark-81.0.4012.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I276f4154a5d9df7a1f21107b4f78248478be6d48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986277Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2257c087b11b..1f74351e20ca git log 2257c087b11b..1f74351e20ca --date=short --first-parent --format='%ad %ae %s' 2020-01-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9427b393..236f912c (728171:728281) Created with: gclient setdep -r src/third_party/webrtc@1f74351e20ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5861167faab84f15aee06540f159ce79416d33fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987105Reviewed-by:
-
Lukasz Anforowicz authored
This CL adds a DumpWithoutCrashing call when a destructor of content::BrowserContext gets called without an earlier call to BrowserContext::NotifyWillBeDestroyed. This CL will hopefully help 1) verify if there are scenarios in the wild, where a BrowserContext/Profile gets destroyed without calling BrowserContext::NotifyWillBeDestroyed first 2) find root cause of these scenarios Bug: 1038844 Change-Id: Ifb40daa27b7b4a4fc301df2ea6f09ffa499fe7d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986262 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#728321}
-
