- 04 Jun, 2020 40 commits
-
-
Anastasia Helfinstein authored
Fixes a bug where the menu is not being entered sometimes. AX-Relnotes: n/a. Bug: N/A Change-Id: Ifeee180eda2cf681672392bde7e9c032dd86c9e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228557 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#775315}
-
Sigurdur Asgeirsson authored
This CL rearranges cleanup and removal notification such that removal notification is always the last notification issued for or by any node. Change-Id: Ia83c58a3995e226c4860640f7096cae6e0aed77b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231265Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#775314}
-
Asanka Herath authored
The identifiability metrics reporting APIs should be able to consume digestible parameters directly without passing it through a non-typesafe conversion. In addition, the generated "digests" aren't really digests in the sense that the output depends quite directly on partitioning of the input, something that shouldn't affect digests. In order to account for these, this CL introduces a concept of a IdentifiabilityToken which can automatically consume supported data types. It is a 'sample encoding' rather than a digest and cannot be used as an input for the purpose of constructing stateful digests, because by design it is not a digest. From the perspective of a call site, these changes mean that the invocation for recording a metric will go from this: IdentifiabilityMetricBuilder( base::UkmSourceId::FromInt64(document->UkmSourceID())) .Set(IdentifiableSurface::FromTypeAndInput( IdentifiableSurface::Type::kWebFeature, static_cast<uint64_t>(feature)), IdentifiabilityDigestHelper(value)) .Record(document->UkmRecorder()); To: IdentifiabilityMetricBuilder(document->UkmSourceID()) .SetWebFeature(feature, value) .Record(document->UkmRecorder()); Bug: 973801 Change-Id: I326bc5a4ead5efbb3a04bf8314692a151fa082f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207291 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:Kentaro Hara <haraken@chromium.org> Reviewed-by:
Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#775313}
-
Mike Frysinger authored
These APIs were already being generated, so make sure they stay in sync. Bug: 469920 Change-Id: Ia8c77affe69730a3b3be3455af200e6633dc6848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217866 Commit-Queue: Mike Frysinger <vapier@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#775312}
-
inglorion authored
Local ThinLTO defaults to emitting data objects and functions in dedicated sections to facilitate dead stripping. This change adds the same behavior to the distributed ThinLTO scripts. BUG=1078453 TEST=tools/clang/scripts/goma_link_unit_tests.py; \ tools/clang/scripts/goma_link_integration_tests.py; \ check that the expected options were passed Change-Id: Ie5e442bf20f886b899a80a8443fce47a709c006f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231034 Commit-Queue: Bob Haarman <inglorion@chromium.org> Reviewed-by:
Tiancong Wang <tcwang@google.com> Cr-Commit-Position: refs/heads/master@{#775311}
-
Katie D authored
Bug: 1088525, 1089578, 1088521 Change-Id: I459c4ad1014dc04c9043f96b187e4f1da5f736a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227905 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#775310}
-
Robert Ogden authored
PrerenderManager doesn't fallback to preconnecting when a prerender can't be done. Bug: 1091428 Change-Id: Ifb09e72a33ceff93a5ba2c66c7c2fa452fe4c136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231276 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#775309}
-
Toni Barzic authored
During initialization, BrowserStatusMonitor initializes its browser_tab_strip_tracker_, which creates insertion events for all existing web contents - on these events, BrowserStatusMonitor was updating associated app statuses, and started observing the web contents for navigation, but was not updating the browser windows kShelfIDKey window property (which should match the active web content's app ID). This property would get updated on the next navigation, but if the web contents navigation had already finished by the time BrowserStatusMonitor was created, the browser window kShelfIDKey would remain unset. For example, during user first run flow, Discovery app window gets launched before the user session changes to active state, and thus before the BrowserStatusMonitor creation, causing the linked bug. This updates BrowserStatusMonitor::OnTabInserted to update the browser window kShelfIDKey immediately, instead of waiting for navigation. This required BrowserStatusMonitor::Initialize() call to be removed from ChromeLauncherController's ctor to ChromeLauncherController::Init, after CreateBrowserShortcutLauncherItem(). Attempts to update the shelf ID window property before calling CreateBrowserShortcutLauncherItem() are hitting DCHECK in ChromeLauncherController::GetBrowserShortcutLauncherItemController(). BUG=1075940 Change-Id: I9fb8e404349c01d1998fb01b5d8133ff0afc105f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223976Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#775308}
-
Vincent Boisselle authored
The timeout is 50 seconds when it should be 5 seconds. Bug: 1091374 Change-Id: I0af7ec8e42b2a659149037147f5c33633da0e3c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231296 Commit-Queue: Dmitry Titov <dimich@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#775307}
-
Toni Barzic authored
When flinging a window in split view from shelf, the side of the split view with the flinged window transitions to overview (though, split view remains active). With existing logic, the hotseat was not getting marked as extended for this gesture, which created a weird interaction with the hotseat during window drag/fling from shelf. The hotseat would be extended from the bottom of the shelf as pointer was moving up from the shelf, then immediately hidden as the gesture ended. This CL changes the logic to keep the hotseat in extended state when the gesture ends - the hotseat is marked as manually extended, and logic that hid the hotseat on visibility updates with split view with overview is removed. Additionally, fixes an issue where window drag controller was not exiting overview when drag window bounds were getting restored for gestures from split view. Also, makes window activation changes while dragged window bounds are being restored not mark hotseat as not manually extended. These two were caught by a test added in this cl. BUG=1025301 Change-Id: I494d1f924bdc6f88294cd0610b9dcc929fa0591f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226066 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#775306}
-
Tarun Bansal authored
This reverts commit 62ef43a9. Reason for revert: Speculative revert to fix ios13-beta-simulator failures. See https://ci.chromium.org/p/chromium/builders/ci/ios13-beta-simulator/15625. If the revert does not fix the breakage, I will put this back. Original change's description: > Adds ChangeTabSwitcherPosition to Field Trial Testing Configuration > > > Bug: 1073826 > Change-Id: I378c67f926df54bd4bd75d0a64f7b241534238a7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208971 > Commit-Queue: Ewann Pellé <ewannpv@chromium.org> > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#775055} TBR=asvitkine@chromium.org,gambard@chromium.org,ewannpv@chromium.org Change-Id: I7b4dab3b0627b5d4b6375638021eec62610c48d9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1073826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231591Reviewed-by:
-
Ken Rockot authored
BigBuffer intentionally constructs a malformed object when it can't provide a suitable representation of its contents for transmission. This is suspected to be the underlying cause for a few assorted bad IPC reports. This CL adds a temporary CHECK to investigate that hypothesis. Bug: 1076341, 1087814 Tbr: dcheng@chromium.org Change-Id: I2e07f3fcb9642034987e8bf3194b6817fbd701c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231584Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#775304}
-
Nina Satragno authored
Implement sending the permissions RPID [1] to authenticators when getting a PinUvAuthToken using UV. [1] https://drafts.fidoalliance.org/fido-2/stable-links-to-latest/fido-client-to-authenticator-protocol.html#permissions-rpid Fixed: 1090361 Change-Id: I4ac942ea787b60f3bc69b21da84c05bd29ff5801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225294 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#775303}
-
Jonathan Ross authored
There is a known failure mode for these tests on Mac NVidia, with finding a fix de-prioritized due to general WebGL2 conformance issue on Mac. I'm expanding the suppression to include the other tests in that folder as currently 10% of runs on the Mac NVidia bot fail due to one of them. TBR=ynovikov@chromium.org TEST=conformance/textures/canvas_sub_rectangle/* Bug: 1027776 Change-Id: I1df617130b30d27fb13efac165ab7df2d9bfb2c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231548Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#775302}
-
Annie Sullivan authored
- Split "realtime" into the two different concepts we've been conflating. "Immediate" means we know immediately when the metric occurred. "Performant to compute" means we can compute it in a RUM context. - Fill in/update the TTI example. Change-Id: I5bf1ea0357eb4b7c3f81b3a0e4112d48ec3f2296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230930 Commit-Queue: Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#775301}
-
Haiyang Pan authored
Some of the tests are known to fail on MM emulator due to historical bug. The rest are known to be flaky on emulator in general Bug: 1056330, 1081969, 1036571 Change-Id: Ifa0c62f85c91ff2fcd6dd3ac6f5d0acb3013c348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231035 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#775300}
-
Ben Pastene authored
Without the fix, the modified unittest fails with: "GNError: Expected an identifier" With the fix, the unittest passes. Bug: 1091082, 937821 Change-Id: I32591c64945dd918dfc341c8327fd530058b90ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231286Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#775299}
-
Brian Sheedy authored
This reverts commit 60f4f958. Reason for revert: crbug.com/1091140 Original change's description: > Add async accessibility hit testing API > > Previously, in order to do a hit test for accessibility we'd > send an action to the renderer with the x,y coordinates, and > the renderer would fire an accessibility event on the matching > node. > > It'd be more flexible if we had an API that could do a hit > test and call a callback function with the result. That > eliminates the need for keeping track of requests and matching > them up with events. > > This patch refactors the way hit testing works so that a > hit testing request may contain a request for an accessibility > event to fire, or a callback function to call, or both. > > Existing tests are extended to cover both mechanisms. > > Bug: 1083834 > > > Change-Id: Idb4c1f302361a0eb6d6344bcee9da7f086caf3c8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209630 > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Emily Stark <estark@chromium.org> > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774697} TBR=dmazzoni@chromium.org,acolwell@chromium.org,estark@chromium.org,aleventhal@chromium.org,arthursonzogni@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1083834 Change-Id: I2454cf5f36e09a3a902960e936f39d5c443cab65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231581Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#775298}
-
Torne (Richard Coles) authored
AwDebug.dumpWithoutCrashing was added to diagnose a suspected renderer hang; it's only accessible by reflection and has not been used to debug an issue for a long time. It no longer provides very useful output since it only dumps the current process and WebView is now multiprocess in the majority of cases. Therefore, just disable the API entirely rather than making it more complex to support multiprocess - if there's a similar need in future it would be more useful to support capturing a trace than a minidump, which did not prove valuable. We keep it around so that any hypothetical clients won't see exceptions during reflection (though they should be handling those exceptions) - it just always returns false to indicate the dump was not generated. AwDebugTest relied on dumpWithoutCrashing to test the crash key filtering mechanism, but the tests have been disabled for some time and maintaining this just for a test doesn't seem worth it; just remove those disabled tests entirely. Fixed: 568825 Fixed: 913515 Change-Id: I2b5b242388d6aaac14508f554e58c3eabbc4ae5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231658Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#775297}
-
Rouslan Solomakhin authored
Before this patch, payment handlers were implemented in two different places: ServiceWorkerPaymentApp.java and service_worker_payment_app.cc. This also resulted in differences of behavior, such as Android returning "true" for hasEnrolledInstrument() of JIT installable payment handlers, whereas desktop platforms returned "false". This patch replaces ServiceWorkerPaymentApp.java with JniPaymentApp.java that wraps service_worker_payment_app.cc. After this patch, JniPaymentApp.java can wrap arbitrary C++ payment apps and there're fewer differences in behavior between Android and desktop platforms: (1) All platforms now return "false" for hasEnrolledInstrument() of JIT installable payment handlers. (2) All platforms now return "false" for hasEnrolledInstrument() of payment handlers that support only standardized payment method identifiers, such as "basic-card". (3) JIT installed payment handlers now can be aborted on both desktop and Android. Design: https://bit.ly/cross-platform-pay-app-factory Bug: 1022512 Change-Id: I03e6bc856f1bce662a68a95513c2f097784a2e51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198918Reviewed-by:Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#775296}
-
Luis G Garcia authored
I2P: https://groups.google.com/a/chromium.org/d/msg/blink-dev/4kMGCyCUIao/5vjPk4tuAQAJ Change-Id: I9969f0c6d65a7afce14b5058c6719599c72dad80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225546 Commit-Queue: Luis Garcia <luisggarcia@google.com> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#775295}
-
Devlin Cronin authored
They were removed long ago. Bug: 1088769, 1088770 Change-Id: Ic12d7290e192f3a31ff9aea711ac81a353f7005c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229239Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5f07cbd7440cafb3d629e0cc90fbfb3d0cdc199b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231465Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#775293}
-
Xianzhu Wang authored
This reverts commit 94c64b41. After the revert, we no longer have crbug.com/1086968 crashes. The root cause of the crash is still unclear, but crrev.com/c/2226924 changed the class hierarchy of LayoutCustomScrollbarPart which may affect the issue. Reland the CL tentatively to see if the crash still occurs. Original change's description: > Revert "Fix layer/phase violation of custom scrollbar painting" > > This reverts commit 64bcb13d. > > Reason for revert: Tentative for crbug.com/1086968. > > Original change's description: > > Fix layer/phase violation of custom scrollbar painting > > > > TL;DR, with this CL: > > - We no longer update custom scrollbar part position during paint; > > - We avoid unnecessary ScheduleAnimation when painting custom > > scrollbars; > > - CustomScrollbar::*Rect() methods no longer have side effects; > > - Some FIXMEs are fixed. > > > > Details: > > > > Previously LayoutCustomScrollbarPart::FrameRect() stored different > > values at different document lifecycle stages: > > > > - Before paint, its location was always zero, and the size was not the > > actual size for some parts, but the minimum size calculated from the > > style, not based on layout, though updated in UpdateLayout(). > > UpdateLayout() was called not during layout (as a scrollbar part is > > not in the layout tree), but anytime we wanted the minimum size from > > const methods of CustomScrollbar. > > > > - During paint, as the FrameRect() calculated during UpdateLayout was > > not the real frame rect, we updated the frame rect to make sure they > > would be painted correctly. This caused unnecessary > > SetShouldCheckForPaintInvalidation when the FrameRect changed and > > unnecessary ScheduleAnimation(). > > > > This CL contains the following changes: > > - Removes LayoutCustomScrollbarPart::UpdateLayout(). > > Adds ComputeThickness() and ComputeLength(), and lets Margin*() get > > style directly, to replace the original UpdateLayout() (which called > > SetSize()/SetMargin*()) + Size()/Margin*() in the const methods of > > CustomScrollbar. This removes the dependency of the const methods > > on the temporary incorrect FrameRect(). > > > > - Adds CustomScrollbar::PositionScrollbarParts() to set the correct > > FrameRect() for scrollbar parts. It's called from several places that > > position of scrollbar parts can change. This replaces the Set* called > > from CustomScrollbarTheme::Paint*. > > > > Bug: 856802 > > Change-Id: I5b120294a31a7f91831441cb361adfd27aefa44e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167602 > > Reviewed-by: Philip Rogers <pdr@chromium.org> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#771890} > > TBR=wangxianzhu@chromium.org,pdr@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 856802, 1086968 > Change-Id: If1703dcda1d4cb6a53a132557b34867090f397ae > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225222 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773772} TBR=wangxianzhu@chromium.org,pdr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 856802, 1086968 Change-Id: I7108a82ed453c32a87ca1aad689cf8a1c157f8fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231458Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#775292}
-
Charlie Hu authored
In order to unblock document policy violation report deduplication implementation, it is necessary to separate subtests for font-display wpt test into subframes so that their violation reports do not interfere with each other. Bug: 1087277 Change-Id: I79ece4fbaae2b28b40b85ca0a0df4daffd54bca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227863Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#775291}
-
Ovidio Henriquez authored
This change implements the BluetoothDevice.watchAdvertisements() API to enable sites to detect when devices come into range of the Bluetooth radio. Design doc: https://docs.google.com/document/d/1h3uAVXJARHrNWaNACUPiQhLt7XI-fFFQoARSs1WgMDM Bug: 654897 Change-Id: Id160188f7a3932819db5e140c41a9dcfdbca321a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112966 Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
James Hollyer <jameshollyer@chromium.org> Reviewed-by:
-
Yi Xu authored
Bug: 1090252 Change-Id: I9041b0653c4a8b9207d964e244a2cfafd28b30e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229429Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#775289}
-
Ian Wells authored
Responsibility for defining snackbar durations will belong to FeedStreamSurface. Bug: 1044139 Change-Id: Ifd007e0014fb46e5c81eb6e7ad6d78ed4a23eb13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231540 Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#775288}
-
Shakti Sahu authored
This CL 1 - Adds TileUmaLogger to omnibox which was missing earlier. 2 - Fixes a bug in TileUmaLogger which wasn't recording top level tiles correctly. 3 - Added tests for TileUmaLogger. Bug: 1091130 Change-Id: Ie556640c6b301cb26915462973d26c373667ab16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230318Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#775287}
-
Ali Juma authored
testIncognitoPlusRegular fails flakily depending on the order in which it is run relative to other test cases. It also fails when it is the first test run after app launch, which means that if it fails once in a given run, it won't even pass on retry. Here's an example run where this happens on a change that is a no-op other than adding a new empty test: https://chromium-swarm.appspot.com/task?id=4c998d1e469f0110 This CL disables this flaky test. BUG=1033726 Change-Id: I77949094e448c26a5db176f4b18c60a783aefc8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231447 Commit-Queue: Ali Juma <ajuma@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Auto-Submit: Ali Juma <ajuma@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#775286}
-
Marijn Kruisselbrink authored
Fix one comment to not mention non-existing methods, and change a parameter from a non-const reference to a const reference, as I assume it was supposed to be. Bug: None Change-Id: I38d6cef800958dc0c4cf22af16e2cb2a9e4f58ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231543 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#775285}
-
John Pham authored
If the text scale change delta is too small (e.g. 100% to 105% compared to 100% to 150%), Windows only sends a text scale change message. If the delta is large (e.g. 100% to 150%), Windows sends a text scale and window resize message. Here's the new behavior: https://i.imgur.com/PAjwJSt.gif Bug: 1087626 Change-Id: I5b6d86a6219d3e27128a5b221d401bcf001443ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223123 Commit-Queue: John Pham <johnp@microsoft.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#775284}
-
mark a. foltz authored
Updates expiration to M92 for current MediaRouter.* histograms, and obsoletes some old histograms that are not being collected. Bug: 1088926,1088925,1088923,1088909,1088673 Change-Id: Ib4ab0bfd6649935e08c6100e17bf652a6676e127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225633Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#775283}
-
Matt Mueller authored
Bug: 1090998 Change-Id: Ib0d787b38e484d15965209f880d8cb8af3ecdc72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230925 Commit-Queue: Matt Mueller <mattm@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Auto-Submit: Matt Mueller <mattm@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5a2a7b3096d0..4926b07217f0 2020-06-04 michaelludwig@google.com Revert "Improve scissor state tracking in GrRTC" 2020-06-04 michaelludwig@google.com Improve scissor state tracking in GrRTC 2020-06-04 mtklein@google.com refine __chkstk_darwin() workaround 2020-06-04 mtklein@google.com remove templates from SkSwizzler_opts 2020-06-04 herb@google.com Make vertex structs private 2020-06-04 herb@google.com Remove unused vertex filler 2020-06-04 johnstiles@google.com Update GrFragmentProcessor::SwizzleOutput to use a child FP. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tdenniston@google.com Change-Id: I74a1eda69a59a9aee58d9d2cb86cb34c3ff7c3da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231598Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7835859ea8de..4a3f9b801b02 2020-06-04 lalitm@google.com Merge "benchmark: update googlebenchmark to v1.5.0" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I81758e42cca1c1d296485c1077c6fc13307c347c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230246Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c461b6d69583..14793b02f904 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yigu@google.com,tbansal@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yigu@google.com,tbansal@google.com Change-Id: I5b2693c454ba56ca64bbe616de34b005be905acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231013Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#775279}
-
Matt Jones authored
This patch splits the BottomSheetController into 3 pieces: - BottomSheetController: This interface is intended to be the public interface for anyone trying to use the bottom sheet and should freely be passed around in features. - BottomSheetControllerInternal: This interface specifies methods that are necessary for "glue" code to effectively manage the sheet. When the sheet has its own component, the only code allowed to depend on it will be glue. - BottomSheetControllerImpl: This is the implementation of the above interfaces and will eventually be private (or just internal to the bottom sheet widget). This patch also replaces most of the test-exclusive methods using various alternatives in tests outside of the bottom sheet's package. Bug: 1002277 Change-Id: Ic84ae52fab3554ef38d84ee32734340c224d8872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225845 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by: -
Daniel Cheng authored
Bug: 898348 Change-Id: I3abe58863f85f5ca3abf0a5bb00bb969d775ad22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225928 Auto-Submit: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Cr-Commit-Position: refs/heads/master@{#775277}
-
Yi Gu authored
Most TODOs are assigned to the linked bugs. TODOs related to GroupEffect are outdated so they are removed. Bug: None Change-Id: I7b413773904efd93c6b6959545c5d74f7d4760ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227299 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#775276}
-
