- 20 Jan, 2021 40 commits
-
-
Esmael El-Moslimany authored
When the NTP has a vertical scroll bar, the NTP contents had a 32px empty space at the bottom. This was from the cr-button which was using "position: sticky" to stick to the bottom right of the window. The empty space looks good, but it should not be due to the height of the cr-button (it is not obvious). This CL introduces a div to explicitly set a 32px empty space at the bottom of the NTP content area, removing the dependency on the cr-button height. Change-Id: Ib035affef92445d3c7f1effdc61b5daea108c4ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638633 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#845304}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611142151-59c02f8532ae979e0b13a34b9cbf149a736aa67f.profdata to chrome-win32-master-1611153816-d2f18273110c533af9e6c4795ef7f831ac05328f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I11d159b6f18ef74cae328a9711c5ebc9057f8a73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640734Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845303}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ff509c5440f5..40fbf5738639 2021-01-20 soxia@microsoft.com Service Worker Update Cycle Timeline 2021-01-20 tvanderlippe@chromium.org Put platform on the global scope in layout tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1050549,chromium:1066604 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I018ee80ed4a0982db93513735d6b8197ebd204d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639520Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845302}
-
Bin Du authored
We are continuing data collection from this histogram. Bug: 1167829 Change-Id: I2114321350cf2ae940b2239eb82eebd243e436c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638073Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Bin Du <dubin@google.com> Cr-Commit-Position: refs/heads/master@{#845301}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a3c06205b28b..477bd92472cc 2021-01-20 hjd@google.com Merge "ui: Support zoom to 1us" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ie9a21ea56513137dfe446527289f3b8d82d1da2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639302Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845300}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1611142151-f3b642624b7e7391f296111a04b779942697c546.profdata to chrome-linux-master-1611165592-f4f825a470f7704c21486baf150746af41ae52eb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I89733be810dc859982b739572c6b26decde7f5cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640738Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845299}
-
gogerald authored
Bug: 1168574 Change-Id: I41f45073df9b7a8249d9c5b529439d718a32675a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640633 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#845298}
-
Xinghui Lu authored
Add SafeBrowsingPasswordProtectionReferringAppEnabledAndroid to control whether to include referring app info in password protection requests on Android. The flag is disabled by default. Bug: 1154860 Change-Id: I26d0384601f84067a00bc08a548fc4f7f14eb8c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638781Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#845297}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e48903477157..39ca1963aa25 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC harringtond@google.com,gab@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: harringtond@google.com,gab@google.com Change-Id: Icdc7c1bd96d2708bf08e95e03cf82af675eea8f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639017Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845296}
-
Aaron Colwell authored
Replacing whitelist usage with allowlist terms to bring the code in line with our inclusive code guidelines. https://chromium.googlesource.com/chromium/src/+/master/styleguide/inclusive_code.md No functionality has change. I simply updated comments and a few variable names. Bug: 842296 Change-Id: I84c6e5594eb85d5b1d5d0a56b41fa366e669ddac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638547 Commit-Queue: Brad Nelson <bradnelson@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Brad Nelson <bradnelson@chromium.org> Cr-Commit-Position: refs/heads/master@{#845295}
-
Peter McNeeley authored
Due to existing limitations in damage calculations some overlay candidate quads will still lack a valid |surface_damage_index|. This means that separating out the damage of a promoted overlay quad from the damage on the primary plan is now virtually impossible. However, a simple optimization is still possible if the overlay candidate is opaque and sits above the primary plane (pure overlay not underlay). So in this case the |display_rect| of the promoted overlay can be subtracted from the primary plane damage. The motivation for these changes is primarily improved Lacros power performance. The special case mentioned above is far more common in existing lacros due to the entire lacros window being contained in one compositor frame. Finally, it should be noted that with this change some pages now move closer to power equivalence between Lacros and ash chrome. Specifically the Google Keeps drawing application has now only ~6% greater power usage on Lacros than ash chrome. Change-Id: I83af491adb3dd2832f599d34e5849fd518ffdfa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634926Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Peter McNeeley <petermcneeley@chromium.org> Cr-Commit-Position: refs/heads/master@{#845294}
-
Devon OBrien authored
Change-Id: Iebbad1bb62f55e24fae2fe8240e06ae9d60b78ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638595Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Devon O'Brien <asymmetric@chromium.org> Cr-Commit-Position: refs/heads/master@{#845293}
-
Shakti Sahu authored
Added toolbar shadow for the video tutorial list. Also modified the change language button text to show a constant string. Bug: 1168267 Change-Id: I682e527a37a677da0ca40f809c7e19bfddbe8887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638414 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#845292}
-
Jeroen Dhollander authored
This CL is part of a migration of all interactions with the Libassistant 3rd party library to a mojom service. Currently Libassistant is invoked directly from the browser thread. This specific CL focuses on the display controller, which in the current Libassistant V1 API has 2 jobs: - Configure Libassistant parameters that only apply to devices which have a display (as opposed to for example Google home devices). - Receive updates about the user speech input volume. In the new Libassistant V2 API, the first job is handled by the display service (http://shortn/_XZThaXrQKb), while the second job is handled by a newly introduce recognition event API (http://shortn/_GyiHLrIRtn). As such, this CL also introduces 2 distinct mojom files to handle these different jobs. Bug: b/177471991 Bug: 1168230 Test: compiled & deployed on real hardware Change-Id: Ic404db5b29d9c12332b584501a43012b9ee8312d Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625963 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#845291}
-
Mike Jackson authored
As we look towards adding a enterprise policy, we want to have an option to show/hide the menu item, and an option to enabled/disabled the menu item. This CL updates the existing parameter to indicate what the flag actually does. Explainer: https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/master/RunOnLogin/Explainer.md I2P: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/T6d2zqF_jpw/76TP7Bc2DwAJ Bug: 897302 Change-Id: I4ef7becd32dd003d8efaab503f0d51a7919d589a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637329Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Commit-Queue: Mike Jackson <mjackson@microsoft.com> Cr-Commit-Position: refs/heads/master@{#845290}
-
Filip Gorski authored
Bug: 1160779 Change-Id: I273f33b905ac886a5c192cf3fb0d1014f41109e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611330 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#845289}
-
Rohit Agarwal authored
Bug: 1168161 Change-Id: I776a8f152a05cde5fbb939a707ee0e8eba43b083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640033Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#845288}
-
Collin Baker authored
A TouchModeChanged() call may happen just after a session ends, but just before the associated OnSessionEnded() call. This caused a DCHECK. Handle this case by ignoring it. Fixed: 1165462 Change-Id: Id8c8a52acd94fef6a34a5349693af7caa9c570d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622529Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#845287}
-
Robert Liao authored
BUG=1168231 Change-Id: I7d0249efadf3da294414932f9511e18d1752994e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638550 Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#845286}
-
Mitsuru Oshima authored
Bug: 1155308 Change-Id: Ib42a0acc0a29beb35ced0e9cd717456c1d62a92e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638540Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#845285}
-
Nate Fischer authored
record_netlog.py was constructing an on-device path with "os.path." This isn't correct on Windows, where we want to use posixpath for on-device paths and os.path for on-host paths. Fixed: 1156518 Test: validity check the script still works as intended on Linux Change-Id: I8120bf5416fc957d4cc0605a49d2a32d190aa2e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577634 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#845284}
-
Kevin McNee authored
We recently added a CHECK that MimeHandlerViews can't navigate away from their handling extension. However, attempting to perform a lighthouse audit of the PDF viewer causes it to navigate to about:blank. While this is still a bug, we no longer CHECK in response to about:blank. Bug: 1168046, 1158381 Change-Id: I84f137cffb1dbf6173bd6ad53d7bf24703acba3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637404Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#845283}
-
danakj authored
The Frame mojom is removed, and FrameNavigationControl inherits its members and is renamed to Frame. The FrameFactory is deleted, and we pass a pending Frame receiver to the renderer when we create the RenderFrame. Likewise, when a child frame is created in the renderer, we pass a pending Frame remote to the browser. Then the Frame mojom interface is present in the browser as long as the RenderFrame is created (aka render_frame_created_ = true). This means we remove the concept of pending RenderFrames in the renderer as well. This was discussed on chromium-dev@ and navigation-dev@ here: https://groups.google.com/a/chromium.org/g/navigation-dev/c/ROWqf4OSAc8/m/ayWK5o5HAwAJ RenderFrameCreated() is now solely responsible for setting up the mojom bindings pulled off the content::mojom::Frame interface, and assumes that the remote Frame interface has been given to the RenderFrameHost before-hand. This should be done as at the time of sending or receiving and IPC to create the renderer-side Frame, the pending remote is generated or received in the browser process. R=dcheng@chromium.org, dtapuska@chromium.org Bug: 1158869, 859110 Change-Id: Ibbb91855ea5428d21b6bfe2328fa845eaa4794c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593750 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#845282}
-
Ken Rockot authored
Bug: 1004256 Change-Id: Id69210a2c22bd64da82492fae5da41f4eaf0da98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636851 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#845281}
-
Collin Baker authored
For security reasons, the thumbnail system must be able to clear the thumbnail for a tab and notify subscribers. A recent CL implemented this behavior but resulted in crashes in TabStripUIHandler::HandleThumbnailUpdate This CL fixes the crashes due to the null pointer access and handles blank thumbnails by sending an empty URI to the WebUI. Fixed: 1167502 Change-Id: I679500882b671b799f3a3c00b55ac20d8e1fb561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638635 Auto-Submit: Collin Baker <collinbaker@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#845280}
-
Alex Newcomer authored
The debouncing we have in place is not slow enough for the web async clipboard api. Pasting from the google searchbox results in multiple clipboard reads, and debouncing requires more of a delay than provided by PostTask. Add a 100ms delay instead. Bug: 1167403 Change-Id: Id24b6a7d21b7dd6e471a8f79635fc25cdae194f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636886 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#845279}
-
Andrey Kosyakov authored
Add an ability to enable HUD display for performance metric on a per-renderer basis through CDP. Bug: 1152089 Change-Id: Ia6f097fc90ceae5a3e9dc878d7880adbf02ce7be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639393Reviewed-by:
Peter Kvitek <kvitekp@chromium.org> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#845278}
-
Ken Rockot authored
Minimal changes are made here to adapt the webmidi tests to WPT and move them into wpt_internal. Bug: 1004256 Change-Id: I78fe61ca5885c9896f63472d2b564eae6ec68951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638773 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#845277}
-
Javier Ernesto Flores Robles authored
To be submitted between Jan 13-20 after PSA and reach of deadline. Context: https://docs.google.com/document/d/1zR3Zewjo6ACEFZBMSG_YWTg9vouaeGAmbIzmp0bTpzY Bug: 1161027 Change-Id: Ie198bbd9cd99e301ee893b3caff36e75dd868a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599927 Commit-Queue: Javier Flores <javierrobles@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#845276}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/22be66d40712..e27e7488e4ad 2021-01-20 amaiorano@google.com VulkanBenchmarks: factor out code into separate files If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I75acb85222c7b980b5dcbebdc48a54d315ae9eec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640733Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845275}
-
Kevin Marshall authored
Fixes a test flake that was caused by incomplete precondition criteria. Now the test case will wait until the document is parsed before executing the test case. Bug: 1162433 Test: Executed test case with --gtest_repeat=500, no issues found. Change-Id: I0c5f58965906ec4e83b6212287a529d5b0190034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638333 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#845274}
-
Patrick Noland authored
This change moves setUrlFocusChangeInProgress, onUrlFocusChange, and finishUrlFocusChange to LocationBarMediator, consolidating phone- and tablet-specific logic as appropriate. Moving these together allows us to move several pieces of state into LocationBarMediator together, e.g. mUrlFocusedWithoutAnimations and mUrlFocusChangeListeners. Unit and instrumentation tests covering the migrated logic are also included, and some on-focus triggered accessibility logic has been moved to UrlBarCoordinator. Bug: 1147581 Change-Id: I4cab5b32402b86a953d22418eb94f375a21b9cc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598036Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#845273}
-
Ken Rockot authored
This is in preparation for moving the tests to internal WPT where they can consume Mojo JS modules. Opportunistically modernizes and simplifies many of the tests as well. Bug: 1004256 Change-Id: I2fcfa11034c82d5cde8d300fed98188aa6088b32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638569 Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Ken Rockot <rockot@google.com> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#845272}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/710f03fa..1d681a1a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifb7da2ade04690d20d683728f3a586567a2195b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640676Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845271}
-
Yutaka Hirano authored
Bug: 1168407 Change-Id: I5faa426fac6c53e1219dfe3ae7805a2eff26e393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639499 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#845270}
-
John Delaney authored
Update expiry of PageLoad.HeavyAds.ComputedTypeWithThresholdNoise and PageLoad.HeavyAds.InterventionType as they are still used to measure impact of heavy ad intervention. PageLoad.HeavyAds.ComputedType2 is no longer needed and is obsoleted. Bug: 1160766,1160767,1160768 Change-Id: I5bdc902b7fee7915741d80110dc64c3c2ecde933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638104Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#845269}
-
Eugene But authored
Change-Id: I9d2be54c92815a0dffcf1c01c28c537a0ff6839d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638784Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#845268}
-
Yann Dago authored
The field "program_files_dir" will accept the full path to the system's Program Files or Program Files (x86) directory (typically found in C:\). This field will be linked to the MSI installer's PROGRAMFILESDIR property. This new field will only be used for fresh system-level Chrome installations and will be ignored for other kind of installations and updates. Bug: 1165921 Change-Id: Id688133c2b2740a953569c9453b808f2aeb7d1e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439784 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#845267}
-
Rushan Suleymanov authored
The FlocIdComputedEventLogging feature toggle might cause failures in some sync integration tests. Disable it as a temporary solution to mitigate the flakiness. Bug: 1153297 Change-Id: Ibda3ea651751cc19709f3a2c0f56956b3702b6f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640420Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#845266}
-
Evan Stade authored
The unit test is ported to be run outside of Chrome. Bug: 1164069 Change-Id: I8c047e8497cc738ede8c20d5ae43b30089a81357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631626 Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#845265}
-