- 01 Feb, 2018 40 commits
-
-
Yuzhu Shen authored
This is needed in order to switch frame resource loading to use the new safe_browsing::BrowserURLLoaderThrottle (once feature NavigationMojoResponse is enabled). Bug: 715673 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: If7919dbdd2ad0c8b09c38a0ba350f04c02ab5f3b Reviewed-on: https://chromium-review.googlesource.com/887796 Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#533781}
-
Peter Wen authored
Stable's gradle plugin has updated to 3.0.1. TBR=agrieve@chromium.org Bug: 620034 Change-Id: I91dc19b1ef2dc3215b7219b4cfdc58274ca21050 Reviewed-on: https://chromium-review.googlesource.com/897054Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#533780}
-
Allen Vicencio authored
Adds WriteFile to SmbProviderClient and FakeSmbProviderClient. Bug: chromium:757625 Change-Id: I00f09ad71787dc4db922b318e0ae7afbf845ea46 Reviewed-on: https://chromium-review.googlesource.com/889559Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Allen Vicencio <allenvic@chromium.org> Cr-Commit-Position: refs/heads/master@{#533779}
-
Jay Civelli authored
Making the CredentialManagerBrowserTests work with the network service. They were failing because the certificate verifier was not set up for the network service and an interstitial would be shown when navigating to an HTTPS page. Bug: 807739 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I11500770f119c677b4a5b62f929b3e09dafd5047 Reviewed-on: https://chromium-review.googlesource.com/896869Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#533778}
-
Stefan Zager authored
The long test names were causing failures on Windows, which evidently has a too-low limit on file name length. BUG=808111 TBR=skobes@chromium.org,oprypin@chromium.org NOTRY=true Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I67181501b11963362e8aac0ae1782e2cfe7c1b4a Reviewed-on: https://chromium-review.googlesource.com/898062Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#533777}
-
Bin Zhao authored
We are going to use device UUID instead of hashed device UUID as sink id in both browser side and extension side. Added MediaSinkInternal::GetSinkIdFromDeviceUUID() to unify different device ids from DIAL and cast. Extension side change: cl/182557041 Bug: 779892 Change-Id: I5843af35c75d74006849a70d07236a8def3dd922 Reviewed-on: https://chromium-review.googlesource.com/889501 Commit-Queue: Bin Zhao <zhaobin@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#533776}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2fc50dd0..595a0288 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I5634398067826ef46a257e578af8958d333caf57 Reviewed-on: https://chromium-review.googlesource.com/897748Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#533775}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c8f1338f. With Chromium commits locally applied on WPT: 9b477bca "Remove extra form data, if "value" attribute present with non-empty value" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/11427 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: Ibd43bee022603a27b3eff95398adc1b7111a31fe Reviewed-on: https://chromium-review.googlesource.com/897183 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#533774}
-
Steve Kobes authored
NOTRY=true TBR=szager Bug: 808112 Change-Id: I09a75429a6efaae567dfd5d42cc98ef46667b843 Reviewed-on: https://chromium-review.googlesource.com/897999Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#533773}
-
Zhenyao Mo authored
The last bit is pre-lollipop Android blacklisting for accelerated_video_decode. To handle this, we query it on renderer startup from GPU process (through GpuChannelHost). This will cause slight renderer startup perf regression, but only on older Android systems. This is the LAST piece of this refactoring. BUG=744658 TEST=bots R=piman@chromium.org,kbr@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie2773a15ed10d27e04364a18f1aa49cd0843280c Reviewed-on: https://chromium-review.googlesource.com/894734Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#533772}
-
https://pdfium.googlesource.com/pdfium.git/+log/71a7d377ff36..55c62a48d36c $ git log 71a7d377f..55c62a48d --date=short --no-merges --format='%ad %ae %s' 2018-02-01 rharrison Convert CFX_CSSPropertyTable to CFX_CSSData Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I58d62d766d64103abe9408416aa2af4d6316332f Reviewed-on: https://chromium-review.googlesource.com/896693 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533771}
-
Patrick Noland authored
If this bit isn't set, crashes can happen because the anchor object isn't properly cleaned up after being removed from the DOM. Rather than adding a call to SetIsScrollAnchorObject at the problem call site, it seemed easier to just ensure it was set by calling it in FindAnchor. Bug: 806631 Change-Id: I6c12c65b83995b08d2fdaedd8d4f6b7f574fa692 Reviewed-on: https://chromium-review.googlesource.com/896562 Commit-Queue: Patrick Noland <pnoland@google.com> Reviewed-by:
-
Elly Fong-Jones authored
The confirm bubble is used only for the "Ask Google for Spelling Suggestions?" prompt. The Cocoa bubble has some visual defects, but the Views one looks quite a bit better. Bug: 747203 Change-Id: I7876819a1b4dd96d32f4491ac67187be5c941c3c Reviewed-on: https://chromium-review.googlesource.com/889139 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#533769}
-
Raymond Toy authored
Bug: 745778 Change-Id: I7c9d5803bf488e1f7c306b7cae652a182b64d633 Reviewed-on: https://chromium-review.googlesource.com/896392Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#533768}
-
Nate Fischer authored
No change to production logic, only changes tests. This adds two new tests to check the Safe Browsing Extended Reporting checkbox: * The checkbox is visible by default * The checkbox can be hidden using onSafeBrowsingHit() This makes no assertion about the default *value* of the checkbox (since this depends on the user's last reporting preference within the browsing session). We're only checking whether it's hidden. This also does some refactoring: * Adds evaluateJavaScriptOnInterstitialOnUiThreadSync() method and uses it where applicable * Renames waitForInterstitialToLoad to waitForInterstitialDomToLoad (to clarify what it actually does) Bug: 738192 Test: run_webview_instrumentation_test_apk -f SafeBrowsingTest#testSafeBrowsing*ReportingCheckbox* Change-Id: Ib1d6cc74c037f60d3c026c87264bf9f768884544 Reviewed-on: https://chromium-review.googlesource.com/896790Reviewed-by:
-
Tibor Goldschwendt authored
Procedurally generate a controller model as a replacement for the Gltf mesh. Procedural controller is disabled for now until we have the proper button icons. Bug: 799606 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I09ce54d3374154db9baf352e5a2e7b5b923d1618 Reviewed-on: https://chromium-review.googlesource.com/887626 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#533766}
-
Daniel Bratell authored
In jumbo builds many cc files compile in the same translation unit and then they share the same anonymous namespace. Having two classes with the same name will then result in compilation failures. In preparation for jumbo in chrome/browser, this patch renames two classes named DefaultDelegate so that they have different names. Bug: 746957 Change-Id: I15cdab5fd9e51223a76d295991513e6e815e3c51 Reviewed-on: https://chromium-review.googlesource.com/897942Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#533765}
-
Daniel Bratell authored
In jumbo builds many cc files compile in the same translation unit and then they share the same anonymous namespace. Having the same constant several times will then result in compilation failures. In preparation for jumbo in chrome/browser, this patch deduplicates the kMHTMLExtension constant and puts it in the utility class. An alternative would be to use the literal string "mhtml" without going through a constant at all. Bug: 746957 Change-Id: I869f15c17bcf14a633a3e0711c7e469159e3083f Reviewed-on: https://chromium-review.googlesource.com/897944Reviewed-by:
-
Devlin Cronin authored
v8_helpers::SetProperty() just wraps Object::DefineOwnProperty(). However, with it, we lose the WARN_UNUSED_RESULT on the method, which can lead to dangerous assumptions or not handling edge cases. The method also doesn't really save us anything (the call to DefineOwnProperty is pretty concise). Remove v8_helpers::SetProperty(), and just use DefineOwnProperty directly. Bug: None Change-Id: I261ef1dc4f59f9541067f9fb87a115e49b32dc8d Reviewed-on: https://chromium-review.googlesource.com/896372 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#533763}
-
Rouslan Solomakhin authored
Bug: 687438 Change-Id: If141c86a47e5455c94a3ed36b1d6d5bc95033d9f Reviewed-on: https://chromium-review.googlesource.com/897887 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#533762}
-
Steven Bennetts authored
This fixes a couple of issues with the 'shared' logic in the config UI: * 'guid' != configured, use source != CrOnc.Source.NONE instead * Share toggle should be visible for all unconfigured networks, even if it can not be changed (i.e. in the login screen). Bug: 807494 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6f068adbe04b9011763426e9b9f72ac0ebb01535 Reviewed-on: https://chromium-review.googlesource.com/896023Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#533761}
-
Takumi Fujimoto authored
This CL makes WiredDisplayMediaRouteProvider not check for the primary display when there is 0 or 1 display. This should fix the crash in which WDMRP attempts to get the primary display when the primary display ID is invalid. Bug: 803881 Change-Id: I095ff7a69b1777c3466d2b6378fcd95e497c5641 Reviewed-on: https://chromium-review.googlesource.com/895389Reviewed-by:
-
Joy Ming authored
Many recent bugs in downloads notifications resulted in many different temporary fixes that made the logic for the service and notifications very confusing. This CL attempts to isolate out the Android-based corner cases related to notification adjustment for the foreground service. This makes these cases easier to test and understand. Change-Id: I9057ca59a88583c986a9d2d78e159ee02adf0a55 Reviewed-on: https://chromium-review.googlesource.com/879819 Commit-Queue: Joy Ming <jming@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#533759}
-
Peter Wen authored
android.test.TouchUtils is deprecated. Bug: 807766 Change-Id: Ib30f91f13afc9a1f7daf19a144dbd43eb06917b7 Reviewed-on: https://chromium-review.googlesource.com/897912Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#533758}
-
Jonathan Metzman authored
TBR=mbarbella@chromium.org Bug: 769578 Change-Id: Id2039ce1c97d42723c5616c4655d2c9c39ed130f Reviewed-on: https://chromium-review.googlesource.com/897984Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#533757}
-
Koji Ishii authored
On Windows, FontCache creates an SkFontMgr using SkFontMgr_New_DirectWrite() if the font manager isn't explicitly set, so that unit tests work. To clarify the suspicious that this test code is running in the production environment, this patch captures the information in the minidump. Bug: 561873 Change-Id: Ib60c9a569242a242c095180bffb0024fc03f129b Reviewed-on: https://chromium-review.googlesource.com/895167 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#533756}
-
Jonathan Metzman authored
TBR=thakis@chromium.org, mbarbella@chromium.org Bug: 769578 Change-Id: I7acdf703c5ac82a791e94fcad993d2b2f1657017 Reviewed-on: https://chromium-review.googlesource.com/896687 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
-
Dale Curtis authored
This specifically tests the force suspend signal sent by the browser when tabs are closed. Full suspend/resume testing is handled by layout tests for ease of test writing and ready state manipulation: https://chromium-review.googlesource.com/c/chromium/src/+/882283 This is part 1/2, a later CL will add an MSE variant of this test. BUG=756897 TEST=it's all tests! Change-Id: I588ccf5feb285f972e392c17498c2eaa071a86c6 Reviewed-on: https://chromium-review.googlesource.com/881832Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#533754}
-
Dominic Mazzoni authored
The widget delegate can be null when the native widget is destroyed. Bug: 678889 Change-Id: Id6e24aceeec59caea48b736309b63a1301823136 Reviewed-on: https://chromium-review.googlesource.com/833181 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#533753}
-
Eugene Ostroukhov authored
"other" service workers section should only collapse when the label was clicked. Bug: 807232 Change-Id: Ib048968ed555121c385a176a602a84a00853b152 Reviewed-on: https://chromium-review.googlesource.com/897913 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#533752}
-
Kevin Bailey authored
This change is to split SetInputInProgress() so the notifications occur after the Start. This change reduces calls to StartAutocomplete from 2 to 1 on the first character typed. Bug: 669727 Change-Id: I6fbba62284a3cd6c8192ffb9c9d1381433ebe798 Reviewed-on: https://chromium-review.googlesource.com/883947Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#533751}
-
Joe Downing authored
This flag will be used for development / testing of the KeyboardLock feature. My plan is to have something available for testing (but behind the flag) in M66. We also plan to use this flag for rolling out the change when it is ready for launch. BUG=680809 Change-Id: I2e4f7ea16c458cab053a998ae1de4d9d7ab7fbec Reviewed-on: https://chromium-review.googlesource.com/896022 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
-
Scott Graham authored
After https://chromium-review.googlesource.com/c/chromium/src/+/876683. Bug: 644525 Change-Id: Ic8f71d5f4cababaa252fd4c9155ea8b34b29158b Reviewed-on: https://chromium-review.googlesource.com/896695Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#533749}
-
https://webrtc.googlesource.com/src.git/+log/10d9d59db164..28dbf9724281 $ git log 10d9d59db..28dbf9724 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I3ae6f051431514c07e64b999ef3b76b9384dcf5d Reviewed-on: https://chromium-review.googlesource.com/897934 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533748}
-
Evan Stade authored
This code does not appear to be necessary any more. Bug: 578868 Change-Id: I1437f18f800fe6293bc01ac207f604da2c9afb6c Reviewed-on: https://chromium-review.googlesource.com/897042Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#533747}
-
Daniel Park authored
Reverts to method before setClipBounds was used. Removes canvas.save and restore as they weren't doing anything Removes check for clip bounds = 0 since it was never 0 Adds scrollX() to rectangle clip bounds for canvas Bug: 805479 Change-Id: I3d32f8dd9526ca7d5504d702283f8fcd2364d678 Reviewed-on: https://chromium-review.googlesource.com/896635Reviewed-by:
-
Dominick Ng authored
This is a reland of 58ab87ff. Original change's description: > Consolidate app banner testing. > > This CL removes several different app banner testing files, and replaces > them by calling the necessary JavaScript setup code in one test file. > For instance, all tests will no longer have the "appinstalled" title > overwriting, as that will only be active when the appropriate setup > JavaScript is run. > > This allows future tests to be more easily added, and reduces collisions > when manipulating the page title. > > BUG=806923 > > Change-Id: Ia28837b8675a2e1fe329cb1df1be4798ddb03d02 > Reviewed-on: https://chromium-review.googlesource.com/892182 > Commit-Queue: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Matt Giuca <mgiuca@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532978} Bug: 806923 Change-Id: Ia85a5be0828ad0820a891f8cde9d9e492dc0b831 Reviewed-on: https://chromium-review.googlesource.com/896326Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
-
Ran Ji authored
We have limited number of jni local references, leaking jobjects inside loop may cause local reference table to overflow. Bug: 726426 Change-Id: I4b1ffc9fcb74d1a78d0415f9d9c79533facb7839 Reviewed-on: https://chromium-review.googlesource.com/895843 Commit-Queue: Ran Ji <ranj@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#533744}
-
Marijn Kruisselbrink authored
Revoking right after navigating and/or loading script should not break the loading. Bug: 800901 Change-Id: I5b2fc378ae4681fb4d42e1e3742111f67a2d1a41 Reviewed-on: https://chromium-review.googlesource.com/894843 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#533743}
-
Gayane Petrosyan authored
When navigating to about:version/?show-variations-cmd an additional section will appear showing complete set of client's variations in the command line formatting that can be used to reproduce the same exact state of variations. The displayed info contains all the trials including not activated ones marked by '*' along with the corresponding group assignment. It will also contain enabled and disabled features where the ones that should use the default value will be marked with '*'(e.g. expired trials). Trials that are unforcable through command line will be shown but warning will be shown when processing the command line input with unforcable trial. This CL doesn't cover iOS. As the displayed text is huge I also changed the width of the text in the about:version page (not mobile) to be 60% of the page with a minimum of 800px as it used to be. Bug: 694675 TEST=unit test, manual testing 1. run chrome with --fake-variations-channel=beta 2. copying command line input from about:version/?show-variations-cmd 3. run chrome without channel but with command line input copied in step 2. 4. confirm about:version/?show-variations-cmd page shows the same info Change-Id: Ie73174bd5bd1a02baa75cd3294fd36cf63b3c923 Reviewed-on: https://chromium-review.googlesource.com/865286 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#533742}
-
