GitLab

This test is flaky:
[FATAL:web_contents_observer_sanity_checker.cc(318)] Check failed: !is_loading_.

Example failure: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/81768

TBR=aee

Bug: 1056688
Change-Id: I5b6d229ea2178bb2f6ee35e7af5b3423f2f6ad66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079031Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745128}

Parsing of the COOP and COEP header is currently not done for redirects.
This is a requirement for COOP to have that info even for redirects.
So moving it to the general repeated function.

Bug: 922191
Change-Id: Ifba6b4e9f0a649dd4492989bd17af5cd4d84a348
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066931
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745127}

This reverts commit 39a8ab18.

Reason for revert: Speculatively causing consistent failures in
KioskTest.LaunchAppWithNetworkConfigAccelerator, which was mentioned
earlier in this revert/reland thread.

First failed build included this change: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3569

Original change's description:
> Reland "[Kiosk] Refactor AppLaunchSplashScreenHandler so it works more reliably"
> 
> This reverts commit 0e5a5146.
> 
> Reason for revert: Fixed errors in AppLaunchController. Time refactor all of this.
> 
> Original change's description:
> > Revert "[Kiosk] Refactor AppLaunchSplashScreenHandler so it works more reliably"
> >
> > This reverts commit cdce07c9.
> >
> > Reason for revert: KioskTest.LaunchAppWithNetworkConfigAccelerator has been failing on msan fairly consistently since this landed:
> > https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/17653
> >
> > Original change's description:
> > > [Kiosk] Refactor AppLaunchSplashScreenHandler so it works more reliably
> > >
> > > This handler was little bit overcomplicated. This led to a bug in web
> > > kiosk mode when we update network state, but do not update the handler.
> > >
> > > Because of this convolution, in web kiosks, the network configure
> > > screen did not update itself when connected to network(which is what
> > > client will expect from the handler which observes network state).
> > > Now it behaves more logically and predictably.
> > >
> > > Bug: 1015383
> > > Change-Id: I78b024b1d51b54b0d01d0a5a5694f6ae3f5ac19e
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031406
> > > Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
> > > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#739128}
> >
> > TBR=xiyuan@chromium.org,rsorokin@chromium.org,apotapchuk@chromium.org
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: 1015383
> > Change-Id: Ibc08de19048d9c8af95c3f517b748d09e37c7597
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045479
> > Reviewed-by: Nico Weber <thakis@chromium.org>
> > Commit-Queue: Nico Weber <thakis@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#739735}
> 
> TBR=xiyuan@chromium.org,thakis@chromium.org,rsorokin@chromium.org,apotapchuk@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 1015383
> Change-Id: Ie77ba40fa6bf3bc94a22c97a8d2b0764ef0614d8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047225
> Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#745056}

TBR=xiyuan@chromium.org,thakis@chromium.org,rsorokin@chromium.org,apotapchuk@chromium.org

Change-Id: I8696f63297d359b9aa34dcaa9d8e402ba9afb419
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1015383
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079138Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745126}

This change uses prefs to store and retrieve app ids for the apps
registered for updates.

Bug: 1020285
Change-Id: I7dea36049e6e09ff7039b61f79acb268e94baddb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053584
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745125}

Assigned return value of getSortKey() to sort_key_size variable as it was before.
related patch: https://chromium-review.googlesource.com/c/chromium/src/+/1592677

Bug: 1056603
Change-Id: I979ef2416fcc428546148f6a7874ab61d9269b34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078014Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Parastoo Geranmayeh <parastoog@google.com>
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Cr-Commit-Position: refs/heads/master@{#745124}

This reverts commit 1d7cbd22.

Reason for revert: This is still causing a compile failure:
../../chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiTest.java:70: error: cannot find symbol
        CachedFeatureFlags.setForTesting(ChromeFeatureList.TAB_GRID_LAYOUT_ANDROID, true);

Original change's description:
> Reland "Make tab strip auto scroll to position of the selected tab"
> 
> This reverts commit e3a03f83.
> 
> Reason for revert: Try to fix the compile failure.
> 
> Original change's description:
> > Revert "Make tab strip auto scroll to position of the selected tab"
> > 
> > This reverts commit 7767aa96.
> > 
> > Reason for revert: suspect causing compile failure on android-archive-rel
> > 
> > Sample build: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/9648
> > 
> > Sample log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8887341380366474896/+/steps/compile/0/stdout?format=raw
> > ----
> > ../../chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiTest.java:70: error: cannot find symbol
> >         CachedFeatureFlags.setGridTabSwitcherEnabledForTesting(true);
> >                           ^
> >   symbol:   method setGridTabSwitcherEnabledForTesting(boolean)
> >   location: class CachedFeatureFlags
> > ../../chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiTest.java:71: error: cannot find symbol
> >         CachedFeatureFlags.setTabGroupsAndroidEnabledForTesting(true);
> >                           ^
> >   symbol:   method setTabGroupsAndroidEnabledForTesting(boolean)
> >   location: class CachedFeatureFlags
> > ../../chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiTest.java:83: error: cannot find symbol
> >         CachedFeatureFlags.setGridTabSwitcherEnabledForTesting(null);
> >                           ^
> >   symbol:   method setGridTabSwitcherEnabledForTesting(<null>)
> >   location: class CachedFeatureFlags
> > ../../chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiTest.java:84: error: cannot find symbol
> >         CachedFeatureFlags.setTabGroupsAndroidEnabledForTesting(null);
> >                           ^
> >   symbol:   method setTabGroupsAndroidEnabledForTesting(<null>)
> >   location: class CachedFeatureFlags
> > 4 errors
> > ----
> > 
> > Original change's description:
> > > Make tab strip auto scroll to position of the selected tab
> > > 
> > > Currently, when a tab in group is selected or a new tab is created
> > > within group, the tab strip doesn't scroll to the position of the
> > > currently selected tab. This could lead to a state where user needs to
> > > scroll by themselves to find their selected tab in strip. This CL fixes
> > > this issue by making following changes:
> > >   * Always scroll the strip to the last position when new tab is added
> > >     in group.
> > >   * When selected a tab in group (through tab grid dialog etc), try to
> > >     scroll to a state where the selected tab is in the middle of the
> > >     strip, if possible,
> > > 
> > > Bug: 1054079
> > > Change-Id: Ic6921225d744a7b5df1853aa78e14a8f9249f2c8
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068888
> > > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
> > > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#744892}
> > 
> > TBR=yusufo@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org
> > 
> > Change-Id: I8db970a5e6c2338ce19c8870964b96c48e66eb44
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 1054079
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076219
> > Reviewed-by: Takashi Sakamoto <tasak@google.com>
> > Commit-Queue: Takashi Sakamoto <tasak@google.com>
> > Cr-Commit-Position: refs/heads/master@{#744908}
> 
> TBR=tasak@google.com,yusufo@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org
> 
> Change-Id: If473ca1321615dd4d2972287274f53be6e0bb574
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1054079
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078415
> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
> Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#745086}

TBR=tasak@google.com,yusufo@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org

Change-Id: I8bfddb25a503e743d790d0ddc59c4a45e0c91665
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1054079
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079137Reviewed-by: Patrick Noland <pnoland@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745123}

The accessible alert while prompting the user for deep scanning is still
"Downloading, 0% remaining", which is jarring. This CL fixes that.

Bug: 1056350
Change-Id: I5e10dcc702c6bef8368492819ce67e432dd469b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076429Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745122}

crrev.com/c/1845766 added the signed in Gaia name to the local
profile name for displaying a profile name in the user menu
and profile switcher.

Since the pwa+profile name in the file association open with
menu is static, I think it's better not to include the
signed in gaia name - and it looks odd the way it is now
<pwa name>(<profile name>(<gaia name>)).

Bug: 960245
Change-Id: Ic6a1476590c469c413cd8a5fe6883440e23c953b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075975Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745121}

Implementing the behaviour that already exists on other platforms:
when user starts typing the username into username field, it makes sense
to show only credentials with the same username prefix.
When user types something into password field, no suggestions should
be shown.

Bug: 831564
Change-Id: I9eeffd808e441ff598d26a1af88994150d8682a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073761Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Maria Kazinova <kazinova@google.com>
Cr-Commit-Position: refs/heads/master@{#745120}

TTI should not be used as a RUM metric. This CL removes the plumbing of
TTI and related values from the renderer to the browser process. It also
removes the UMA and UKM histograms that were using it.

Bug: 1055806

Change-Id: Ia72c454587f633e58882153bd921ddafae3e71f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070384Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Deep Roy <dproy@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745119}

Change-Id: I6d8f3dce02ff4fb21e60d38c8c52d79a9ab156ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078656Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745118}

https://swiftshader.googlesource.com/SwiftShader.git/+log/4b34ee3de531..ad3e42a439e2

git log 4b34ee3de531..ad3e42a439e2 --date=short --first-parent --format='%ad %ae %s'
2020-02-27 amaiorano@google.com Subzero: add support for variadic calls (System V)

Created with:
  gclient setdep -r src/third_party/swiftshader@ad3e42a439e2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I4fb314de2dc79619882a5655f2149b86ab193d5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078304Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#745117}

Followup from:
https://chromium-review.googlesource.com/c/chromium/src/+/2044522/3/third_party/blink/renderer/core/paint/ng/ng_box_fragment_painter.cc#325

I was pointed out that now we have the
ScopedPaintTimingDetectorBlockPaintHook within PaintInternal, the one
within PaintLineBoxChildren was redundant.

Change-Id: I285ce15eba904c1c21e24e94ce87cf86184edec8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076080Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745116}

Failure reason:
Exception: NoMatchingElementException

TBR=stkhapugin@chromium.org

Bug: 1056700
Change-Id: I2ee0b6871d2ef725316c158f0cbe2167315b969b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078434Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745115}

This resolves a couple final style comments on the previous change
https://crrev.com/c/2057009:
- renames a test helper class to be more descriptive
- adds a space after a class definition

R=csharrison

Change-Id: I08c6311f3a3b18aebb23d710cdb22284291620fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068736
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Auto-Submit: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745114}

Bug: 1026426
Change-Id: I2e98be132e07c90aa1535cd4edb4cc399fc4a84f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073226
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745113}

https://skia.googlesource.com/skia.git/+log/289ecf8b9b71..fb3f302bdf69

git log 289ecf8b9b71..fb3f302bdf69 --date=short --first-parent --format='%ad %ae %s'
2020-02-27 michaelludwig@google.com Reland "Track device coordinate space as matrix"
2020-02-27 egdaniel@google.com Blacklist hanging test on vulkan pixel3 perf bot.
2020-02-27 bsalomon@google.com Add assert that GrTextureMaker never adds MIP maps

Created with:
  gclient setdep -r src/third_party/skia@fb3f302bdf69

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: jlavrova@google.com
Change-Id: Idfe0feabb47e74e34b9928fd47435e2f5c948bc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078597Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#745112}

In Chromium builds, cache.dat and sitelistcache.dat will neither be written by
nor cleaned up by Legacy Browser Support.

Bug: 1054573
Change-Id: I9f0a782dc0011465dfb192cbe381892b97fc4c3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074920
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745111}

Threaded scrolls unnecessarily cause commits on every change. This
patch implements an optimization from pre-BlinkGenPropertyTrees in
layer list mode to avoid these commits.

When an impl-side scroll occurs, cc can immediately apply the scroll
before notifying blink so that the blink update only causes a commit if
needed (e.g., interest rect changed). This has been implemented in
LayerTreeHost::UpdateScrollOffsetFromImpl. A second change was needed in
PropertyTreeManager::DirectlyUpdateScrollOffsetTransform to avoid
commits if cc already matches blink.

The first version of this patch (https://crrev.com/743622) was reverted
(https://crrev.com/743844) due to breaking scroll animation
interruptions. This patch adds the missing call to
Layer::SetNeedsPushProperties to ensure scroll animations are clobbered.

Bug: 1048384f
Change-Id: Iadf7b5fb0471f74b46ed6d7ecf9edade51484646
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076419Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745110}

The traffic annotation auditor tool allowed for switching between two
different extractor backends while usage was being migrated to a python
script extractor. This CL removes existing usage of clang-tool as well
as the switching infra, as well as the clang-tool extractor itself.

Bug: 1046869
Change-Id: I4dd77598cc3b7c80723e59951681cef28103670d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070818
Commit-Queue: Ehsan Kia <ehsankia@google.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745109}

This prepares for allowing paint chunks that don't contain any display
items. Previously we used display item indices which couldn't accurately
indicate whether an empty paint chunk belonged to a subsequence.

This avoids the lookup of a paint chunk from display item index.

Also adds under-invalidation checking for paint chunks in cached
subsequences.

Will introduce empty paint chunks in crrev.com/c/937573.

Change-Id: I7c18a0f6b176b535c04414db28a244491e3023af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076411Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745108}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e9fa76827a5a..f99345291868


Created with:
  gclient setdep -r src-internal@f99345291868

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1055533
Tbr: jbudorick@google.com
Change-Id: I92073191a1ad2c91f58c851da6395bc042a01892
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078303Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#745107}

Before this change:
If a user tried to search the menus and no items matched their query,
'no items' was displayed visually, but not communicated verbally.

After this change:
ChromeVox announces when no items match their search query. This change
also makes a small UX enhancement; if there is no query upon activating
the menu, then we should clear the previous contents of the menu.

Bug: 1056282
Change-Id: I5563f45850c4d8377090558e7a637bf209165458
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074813Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745106}

The existing iOS recipe utilizes an isolate template, and an
isolated.gen.json file to fill the template in per test with
config-variables and path-variables. This isolate template contains
the command arguments to invoke the iOS test runner.

To support the iOS recipe migration to the Chromium recipe, I use GN to
generate a script per test target instead of the isolate template. The
script is pre-baked with arguments to the test runner (run.py). The
given Swarming task is expected to execute the test by invoking the
generated script.

Invoking the generated script requires changes to gn_isolate_map.pyl
for each iOS test target, and thus, these changes are only additive.

* "ios_test_runner_wrapper" template wraps the generate_wrapper target.
 It bakes iOS specific arguments into the script, such that it can
 launch run.py with the given args.
* ios_eg2_test, ios_eg_test, and test templates have
 been updated to utilize the ios_test_runner_wrapper for iOS targets.
* mb.py to skip generated_directory check when writing isolates.
 View crbug/ in comments.

Change-Id: I941d37dfdff0bd1ead1baff70907a197fee3fe64
Bug: 1055328,912681
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023748
Commit-Queue: Jeff Yoon <jeffyoon@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745105}

Bug: None
Change-Id: Id3f73138ca5a5a8c05fd4556cea380ae1c7401e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078091Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745104}

This CL adds an Enterprise Policy, UseLegacyFormControls, which
will allow enterprise customers to opt out of the new
FormControlsRefresh feature for a few milestones, in case of
problems.

Bug: 1054511

Change-Id: I9982335da17dd1323e09798c613d30d446ffd227
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076758Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745103}

Matching existing non-fyi android bots.

Bug: 922145
Change-Id: I12e793167c3abe66f2a283f1e1ffe61735002ec4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078838Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745102}

Change-Id: I68b5cdb12e628ffdcd91e097c4512a733cc5ba79
Fixed: 1056243
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072667Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Auto-Submit: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745101}

This CL restores GL state to correct values before clearing FBO to
ensure glClear happens. It also fixes problem in destruction when
GLContext got destroyed before AwGLSurfaceExternalStencil.

Bug: 1056655

Change-Id: I70102fae19d25ae9d2795ddf37e0c393dc2e18f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075971Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745100}

Because the buttons show images, VoiceOver was reading the image
filename. There should be a real label instead.

Bug: 1028938
Change-Id: I3fdcb3e325460616d935cc594f4a7489ebbb033f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078474
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745099}

The CL removes the EmbeddedVTTStylesheetsEnabled runtime flag as the
feature has been stable since M78.

Bug: 1056392
Change-Id: I935bf5f099753f5e33b312b5aca1a513a7c29152
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076408Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Evan Liu <evliu@google.com>
Cr-Commit-Position: refs/heads/master@{#745098}

https://android.googlesource.com/platform/external/perfetto.git/+log/56731e642bb7..a4b8c86e94ba

git log 56731e642bb7..a4b8c86e94ba --date=short --first-parent --format='%ad %ae %s'
2020-02-27 lalitm@google.com tp: add missing systrace comment

Created with:
  gclient setdep -r src/third_party/perfetto@a4b8c86e94ba

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I4c4e871f5e32e4b977f067b85c4a6325bb112d6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078295Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#745097}

- Move individual authors out of the organizations section.
- Sort obviously tacked-on entries.
- Add documentation to try to prevent the above errors.

Change-Id: Iee56967642e0a92346863f9229914069a5a37af3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076952Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745096}

Bug: 993790
Change-Id: I3c6e738d9b409854a046f215858bd82f628e8442
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031602Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Rodney Ding <rodneyding@google.com>
Cr-Commit-Position: refs/heads/master@{#745095}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/091710f87c8c..29c52f9cafce

git log 091710f87c8c..29c52f9cafce --date=short --first-parent --format='%ad %ae %s'
2020-02-27 wolfi@chromium.org Add toolbar showing count of warnings to issues panel

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@29c52f9cafce

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ib9daa215e267c79f2ab29efa35ff4ca3698bd08e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078535Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#745094}

contain:strict elements are stopping points for ancestor recursion when
finding a CompositingInputsRoot, but this should only be for when
*descendants* of the contain:strict element are dirtied, not the
contain:strict element itself.

This problem exhibited in a bug in a case when the contain:strict
element was also position:sticky, causing it to fail to update sticky
position constraints as a result.

Bug: 1051455

Change-Id: If7e9f3d19ce5dc949ee9ba6ab7c0c0c2e03b2f20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076546Reviewed-by: Manuel Rego <rego@igalia.com>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745093}

This change updates the WebOTP API shape to the latest spec.
It adds the following changes.

1. Adds `code` field for the one-time-code
2. Updates `id` to be undefined for OTPCredentials
3. Updates OtpCredentials to be OTPCredentials

WebOTP Explainer: https://github.com/samuelgoto/WebOTP/blob/master/explainer.md

Bug: 1053594
Change-Id: I747446b2fffc8f00afef105db3a5bcb35b124890
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068300Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745092}

This reverts commit 959b4db4.

Reason for revert: Failing consistently (2/2) since this change landed.
https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/17292
https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/17293

Failed with status TIMEOUT

Original change's description:
> [Kiosk] Fix flaky KioskTest.LaunchAppUserCancel
> 
> Sometimes network timer was timing out and we were going into
> network configure screen. This screen is orthogonal to the purpose of
> this test. Let's disable network handling in this test.
> 
> Bug: 964333
> Change-Id: Ic93568970b7af07f4703c9474868aaefabccf1cd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075457
> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
> Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#745038}

TBR=rsorokin@chromium.org,apotapchuk@chromium.org

Change-Id: I39fa8e39a956c0780839eed42d4a43ca1264b3e4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 964333
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078999Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745091}

This adds helper functions for going from an SVGResource or
StyleSVGResource to the associated LayoutSVGResourceContainer type.
This reduces the amount of boilplate needed for this a little bit. These
types of access is expected to be little more common when the
SVGResources object has been phased out.

Add a special overload for ReferenceClipPathOperation that maps to a
LayoutSVGResourceClipper, and GetFilterResourceForSVG to capture the
current "single url(...)" restriction.

Bug: 1028063
Change-Id: I7d408a4d25d024162ace818a088b25be1205cedb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072218
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745090}

Bug: 1056575
Change-Id: I3df2c9af1ee19becf4164d06ad210e81f29a4fea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078911Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745089}