- 16 May, 2018 40 commits
-
-
Becky Zhou authored
Change-Id: I5e9e977d1fd072b8b7f2b3ce8193214bb6c8fe4a Reviewed-on: https://chromium-review.googlesource.com/1060431Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#559335}
-
Pete Williamson authored
Bug: 831803 Change-Id: Ib1d125d22cbec36fc09e544db00d8c4cd10b5190 Reviewed-on: https://chromium-review.googlesource.com/1045839 Commit-Queue: Peter Williamson <petewil@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#559334}
-
mrefaat authored
This fixes a problem when the StoreKit is dismissed, the URL stays on the omni box. Where it should be reverted to the last item. Bug: 842725 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2c645289209d0ae03b09d60e9b90d42565bca057 Reviewed-on: https://chromium-review.googlesource.com/1060346Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#559333}
-
Quinten Yearsley authored
This change was made by the update-test-expectations script. Recent test results history: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=http/tests/appcache/abort-cache-onchecking-resource-404.html,http/tests/d om/create-contextual-fragment-from-svg-document-range.html,http/tests/cache/zero-length-xhr.html Bug: 762008, 762399, 762423 Change-Id: If563520cb19cc426ddf93581570cfb3d4b76f7d5 Reviewed-on: https://chromium-review.googlesource.com/1062601Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#559332}
-
Wenzhao Zang authored
Bug: 834993 Test: --enable-features=EnableHomeLauncher, --new-wallpaper-picker Change-Id: I499db4f6bbb5511f5feb6da0b5df5ccd7ef1143f Reviewed-on: https://chromium-review.googlesource.com/1058490 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#559331}
-
Esmael El-Moslimany authored
Bug: 806990 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I88014d77169c3b6f75c5905fa4219b8be92e6fa4 Reviewed-on: https://chromium-review.googlesource.com/1060265Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#559330}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8de3800ce55b..ed1bb34fc59e $ git log 8de3800ce..ed1bb34fc --date=short --no-merges --format='%ad %ae %s' 2018-05-16 ehmaldonado gclient: Remove condition_value. 2018-05-16 ehmaldonado gclient: Merge hook_os with hooks and deps_os with os. 2018-04-26 ehmaldonado Reland "bot_update: Patch on gclient by default." Created with: roll-dep src/third_party/depot_tools BUG=chromium:839925,chromium:839925,chromium:643346 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I593c53bdc762894bd3c7bdf61337327f4e2763f9 Reviewed-on: https://chromium-review.googlesource.com/1062929Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559329}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d95db22a613c..a7e134aa0dbf $ git log d95db22a6..a7e134aa0 --date=short --no-merges --format='%ad %ae %s' 2018-05-16 szager Refactor browser_interval_profiling_controller 2018-05-16 benjhayden Add google-signin to third_party/polymer2. 2018-05-16 nednguyen Add logging of the apk name picked by android backend settings 2018-05-16 benjhayden Add paper-checkbox to third_party/polymer2. 2018-05-16 benjhayden Add polymer-redux to third_party. 2018-05-16 eyaich Updating telemetry smoke-test-mode flag to not take a value 2018-05-16 benjhayden Add paper-input to third_party/polymer2. 2018-05-16 nednguyen Make sure Telemetry use <benchmark>/<story_name> consistenly when printing to stdout Created with: roll-dep src/third_party/catapult BUG=chromium:839645,chromium:843516,chromium:840427 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I25330250acecec6a49829102e25e07ff8b35db93 Reviewed-on: https://chromium-review.googlesource.com/1062933 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559328}
-
Lukasz Anforowicz authored
This reverts commit 1f4fc1f7. Reason for revert: Speculating that this is the root cause of https://crbug.com/843725 Original change's description: > Add dummy benchmarks to chromium waterfalls > > Bug: 840427 > Change-Id: I44364a9c3954b14118c77c51cfd454be3919c1f2 > Reviewed-on: https://chromium-review.googlesource.com/1055776 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Ned Nguyen <nednguyen@google.com> > Commit-Queue: Emily Hanley <eyaich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#559076} TBR=nednguyen@google.com,eyaich@chromium.org,jbudorick@chromium.org Bug: 843725 Change-Id: I10fa2c1c631e3d43b31f610f4af40756840e9ba2 Reviewed-on: https://chromium-review.googlesource.com/1062711Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#559327}
-
Nate Fischer authored
No change to logic. This removes the 'public' visibility modifier from methods on public interfaces, as these methods are implicitly public (and this is a lint warning on the Android side). Bug: 843420 Test: N/A Change-Id: I17ea506f8cb7965c80e2489d985d1a3f2476fb50 Reviewed-on: https://chromium-review.googlesource.com/1062965Reviewed-by:
Paul Miller <paulmiller@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#559326}
-
Kyle Milka authored
Add edit link for NTP custom backgrounds. This should only be visible when both the flag is enabled and a custom theme is not being used. Bug: 839152 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I00cb54167ba099da18d5999eb60c98c7bf8f2447 Reviewed-on: https://chromium-review.googlesource.com/1060126 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#559325}
-
Chris Lu authored
Creates new tableviewtextactionbuttonitem and tableviewtextactionbuttoncell for signed in, but not synced, state in recent tabs. Can be reused for signin promo when that time comes. Screenshot: https://drive.google.com/open?id=14BFzN7256LtFGvGUl2yU9HDOFqaBQisJ Bug: 822988 Change-Id: I9634282b7e65d2d740db43f6425413a69b25b5b8 Reviewed-on: https://chromium-review.googlesource.com/1048873 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#559324}
-
Xiyuan Xia authored
The cause is a typical mojo message race. SessionController and MediaController use different mojo message pipes. The problem happens when two or more users are added to the system and somehow MediaController call is delayed after SessionController calls. As a result, MediaController calls contains a stale capture states array (less than actual users). MultiProfileMediaTrayView uses a user index based on SessionController's view and would hit an index out of bound error when accessing the stale data. Make MultiProfileMediaTrayView::OnMediaCaptureChanged use size of the passed-in |capture_states| to fix the problem. This should be fine since it is transient and there should soon be another MediaController::NotifyCaptureState call. Bug: 842442 Change-Id: Ife6ea23c85d27e2e89a042bb849ef03af4ccc061 Reviewed-on: https://chromium-review.googlesource.com/1062716Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#559323}
-
Fady Samuel authored
|current_size_| is unused so this CL removes it. Bug: 672962 Change-Id: Ief6fc89d6e207672e12a5e1c929ff6dc0ba5f5dd Reviewed-on: https://chromium-review.googlesource.com/1062655Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#559322}
-
Sergey Berezin authored
TBR=sdefresne@chromium.org, tandrii@chromium.org Bug: 731542, 731544, 731354, 776178 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I79d65f73e574e11afd9b0b490edf056c0d8c90fd Reviewed-on: https://chromium-review.googlesource.com/1062967Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org> Cr-Commit-Position: refs/heads/master@{#559321}
-
Katie D authored
Per UI review, the TTS settings page sliders should have their current values shown on the screen and dots showing that they have steps, similar to the slider in the display settings page. Bug: 823359 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9a52d25c11a95439f90e767a02744c162f693605 Reviewed-on: https://chromium-review.googlesource.com/1054558 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#559320}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5f638a1091fb..4c1562dfdeef $ git log 5f638a109..4c1562dfd --date=short --no-merges --format='%ad %ae %s' 2018-05-14 shapiroc cbuildbot: Fix file check outside chroot 2018-05-04 bmgordon cros_test_lib: Refactor cros_build_lib mocks 2018-05-12 yunlian cros_setup_toolchain: build toolchains in reversed order. Created with: roll-dep src/third_party/chromite BUG=chromium:842834,chromium:809634,chromium:711369 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Icd8ebd153995e7b541c78dc08f8072239c16a140 Reviewed-on: https://chromium-review.googlesource.com/1062649Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559319}
-
Jeremy Roman authored
Bug: 841751 Change-Id: I6913fa775c3783f10d98a701479e403ca6fc92fc Reviewed-on: https://chromium-review.googlesource.com/1054146 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#559318}
-
Jiawei Li authored
This will allow Chromecast builds to host mojo interfaces in the "content_renderer" service. A mojo interface MediaLoadDeferrer is added to "content_render" service, which is used to control when media resources are loaded. The old CastRenderFrameActionDeferrer is replaced with CastMediaLoadDeferrer. Also,unused switch kAllowHiddenMediaPlayback is eliminated. BUG=internal b/74121154 TEST= Newly added media_load_deferrer interface connect correctly Change-Id: I70eb80d30aa6777426ac5c9c0a39a95af4529c0c Reviewed-on: https://chromium-review.googlesource.com/1056071 Commit-Queue: Jiawei Li <lijiawei@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Cr-Commit-Position: refs/heads/master@{#559317}
-
Dale Curtis authored
Fixes broken ToTAndroidCFI bot after http://crrev.com/558826. BUG=842890 TEST=none TBR=emircan Change-Id: I1aba2e491b34d71910430bfd4d2d6cba55045889 Reviewed-on: https://chromium-review.googlesource.com/1062802Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#559316}
-
Sonny Sasaka authored
Android takes 3-4 seconds to fulfill power state change, so the timeout of 5 seconds is too close that the probability of the timeout hit is high enough to happen to users. As a result, users often encounter Bluetooth turned off by itself. This CL changes the timeout to 8 seconds to provide safer buffer, if there is no response from Android after 8 seconds it is considered as lost (will never respond). Future larger work is needed to avoid relying on timeout to make it more robust, but at this moment we need a low-risk solution to be merged to stable channel. BUG=843650 Change-Id: I9aded127e3eb510ff58b1167900bda9546226aa5 Reviewed-on: https://chromium-review.googlesource.com/1062773Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#559315}
-
Joe Downing authored
This CL adds a debugging message to the console window if the caller supplies one or more invalid DOMStrings. We currently reject the promise if all strings are invalid, but if a subset are invalid, there was no good way to debug that issue before this change. Now it is obvious which DOMString is not a valid DomCode. It also helps prevent silent failures if a single invalid key was passed in. BUG=680809 Change-Id: If978952e53e35e128528aad28ff1e0bdc969ba14 Reviewed-on: https://chromium-review.googlesource.com/1062367 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#559314}
-
Aaron Leventhal authored
Bug: 843594 Change-Id: I47910f9634b2a66e8ca979427ad1d42cb45ffd46 Reviewed-on: https://chromium-review.googlesource.com/1062407Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#559313}
-
Steven Holte authored
Bug: 842012 Change-Id: Ifc35114d2f1a4b6045e97aa45c1c56ed96abae19 Reviewed-on: https://chromium-review.googlesource.com/1055936Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#559312}
-
Troy Hildebrandt authored
Change-Id: Ibe077e38a97226b8bbf8af9c974a3ef2e4472c8a Reviewed-on: https://chromium-review.googlesource.com/1062657Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Cr-Commit-Position: refs/heads/master@{#559311}
-
Tommy C. Li authored
Previously, it was only white in the touchable modes, but it should be white when the popup is open in all the newer Material modes. Bug: 837500, 823535 Change-Id: Ifd52903798553f50645148a9d44c6a80ee0eb479 Reviewed-on: https://chromium-review.googlesource.com/1062504 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#559310}
-
Elly Fong-Jones authored
Failure to do this causes a UAF later. Bug: 840895 Change-Id: I4f4a62721b6c67c7d3e5ab4d137b4bd64d8a8f14 Reviewed-on: https://chromium-review.googlesource.com/1062511Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#559309}
-
Euisang Lim authored
Apply 4dp corner radius to cards in Settings, Bookmarks, Extensions, Downloads, and History. Add --cr-card-border-radius in cr_elements/shared_vars_css.html to be used in all files. Bug: 841848 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id509e89be2b3c97f6d9b60662ab959b3fca59469 Reviewed-on: https://chromium-review.googlesource.com/1056928Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#559308}
-
Evan Stade authored
Also add checks to StubNotificationDisplayService test util class to catch this in the future (checks match NotificationDisplayServiceImpl production code). Bug: 843692 Change-Id: Iebb64687dadf6eb50bffea80e946e8dd3336bac9 Reviewed-on: https://chromium-review.googlesource.com/1062653Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#559307}
-
Erik Luo authored
Completions in the middle of the text will not show SuggestBox if one of the suggestions already exists in the editor. Diff GIF: https://imgur.com/a/1Ry9Ser Bug: none Change-Id: I3bd27fa58b6a36c963e08f10f90e4747882f77e3 Reviewed-on: https://chromium-review.googlesource.com/1050503Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#559306}
-
https://chromium.googlesource.com/angle/angle.git/+log/e943df226e2b..21386a349acc $ git log e943df226..21386a349 --date=short --no-merges --format='%ad %ae %s' 2018-05-16 jmadill dEQP: Implement --deqp-case for GTest. 2018-05-10 lucferron Vulkan: Basic support of copySubImage Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I0354711b842de67f4117ced9535b5cc46e80edb1 Reviewed-on: https://chromium-review.googlesource.com/1062586Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559305}
-
James Cook authored
In a later CL I'm creating and tearing down the UI widgets for the touch HUD app, which revealed problems with widget ownership and child views::View teardown. * Use a single PointerWatcher across all displays (since PointerWatcher tracks events on all displays) * Fork ash::TouchHudRenderer. The legacy ash one will go away when the mojo app becomes the default. * Make the app own the TouchHudRenderers and TouchHudRenderer own the views::Widget. TODO: Eliminate Launchable interface. Tbr: sky@chromium.org Bug: 840380 Test: chrome --show-taps-app paints touch points Change-Id: Icba099a00f284835099af244db8afd93b9ed7a48 Reviewed-on: https://chromium-review.googlesource.com/1060523Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#559304}
-
Devlin Cronin authored
TBR=mkearney@chromium.org Bug: None Change-Id: I920eba3b1cab6240ca5999b556443e0dae6c2241 Reviewed-on: https://chromium-review.googlesource.com/1062186Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#559303}
-
Xiaohan Wang authored
Bug: 658026 Change-Id: Id49c0781ab9427da46a4d26d55a510e4aaeea94e Reviewed-on: https://chromium-review.googlesource.com/1062326Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#559302}
-
Martin Kreichgauer authored
This adds an implementation of the FidoAuthenticator interface that uses the Touch ID operatio code. Along the way, make several refactorings to the existing Touch ID code: - Extract OperationBase as a common abstract base from {MakeCredential,GetAssertion}Operation (and Operation as an interface to OperationBase). - Add a Keychain class proxying calls to macOS Keychain Services and related APIs that need to be stubbed out in testing. - Extract Touch ID prompts, including SecAccessControl creation and callback handling, into a TouchIdContext class. Also fix potential use-after-destroy issues from callback invocation after operation destruction. Change-Id: I660f01c083c6cf973c61d244f61801d20d9ca927 Reviewed-on: https://chromium-review.googlesource.com/1040275 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#559301}
-
Sahel Sharifymoghaddam authored
This reverts commit 76b93d2d. Reason for revert: The cl is the root cause of crbug.com/843027 Original change's description: > Don't suppress Showpress after a GFC followed by Tap down suppression > > Showpress should get forwarded after a GFC followed by Tap down suppression. > > Bug: 842221 > Change-Id: I60beaf3296557ec8c3d3d25b627f272b82114eed > Reviewed-on: https://chromium-review.googlesource.com/1055653 > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557958} TBR=dtapuska@chromium.org,sahel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 842221, 843027 Change-Id: Ie47d1836059dd0336fa5c48a11bf5680e32f9adf Reviewed-on: https://chromium-review.googlesource.com/1062545 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by:
Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#559300}
-
Sammie Quon authored
Test: covered by tests Bug: 838103 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0bde97d3398ae60968d3646ee8254d24270c84df Reviewed-on: https://chromium-review.googlesource.com/1056227Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#559299}
-
Zhongyi Shi authored
Bug: 843299 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I55bac965509f9576b30ad5e872f6e127bae8f661 Reviewed-on: https://chromium-review.googlesource.com/1060285Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#559298}
-
rbpotter authored
Was accidentally introduced in https://crrev.com/c/1055657. Bug: 773928 Change-Id: I1167284e1d03cd89154310041c1d1f64021f7725 Reviewed-on: https://chromium-review.googlesource.com/1062503Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#559297}
-
Bailey Berro authored
Changes SmbService::Mount from returning a base::File::error as a result to an SmbMountResult so that we can provide more valuable mount result feedback to users. Bug: chromium:757625 Change-Id: I8a7372529031a1ea6829f62119964b34c4a26465 Reviewed-on: https://chromium-review.googlesource.com/1058041Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#559296}
-