- 23 Oct, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4900f195bb83..9709599c10ff Created with: gclient setdep -r src-internal@9709599c10ff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ic97ea5e1ed4574cbca38d0d2f12725461368591f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876079Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708773}
-
Jeff Yoon authored
Defining xcode build version as recipe properties for each respective builder. ios-simulator-cr-recipe already had 11a1027 set as part of recipe properties. Migrating over the following: - xcode_10e1001 - xcode_11m382q Bug: 1014539 Change-Id: I111bc9a02bb125c38daf2694441d3d6fd9bd3318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874735Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#708772}
-
Regan Hsu authored
Currently the navbar is too long and some image titles are prematurely cutoff. This CL ensures the navbar is up to specs. screenshots (after): https://screenshot.googleplex.com/ZYi94ycYreo (english ltr) https://screenshot.googleplex.com/cVFMK99HuDv (arabic rtl) Specs: https://drive.google.com/open?id=10Mwipz5IFvlf_bOVSu7JnTS2bKckrGBp Bug: 1016964 Change-Id: Ibba8c02abf66249b6f2a42fd9af7781951db8b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874817Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#708771}
-
Xianzhu Wang authored
This reverts commit 1a394948. Reason for revert: crbug.com/1011605 (probably caused by a linker bug on ARM ChromeOS) has been worked around in crbug.com/1011161. Original change's description: > Revert "Mark some blink testing targets testonly" > > This reverts commit a4453534. > > Reason for revert: http://crbug.com/1011605 > > Original change's description: > > Mark some blink testing targets testonly > > > > This forbids production code depending on these targets, and enables > > these targets to depend on other testonly targets in the future. > > > > The only dependency prevented core:testing from being testonly was > > from BlinkLeakDetector. Add Page::PrepareForLeakDetection() and > > InternalSettingsPageSupplementStub (in page.h) to avoid the > > dependency. > > > > Change-Id: Ie22676a233d9b5c02cf3cde79629f4b84782b572 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829586 > > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#701334} > > TBR=wangxianzhu@chromium.org,chrishtr@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Change-Id: Icb266b74d3f75ffff2176ec2b0ca4871d99e7587 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842973 > Reviewed-by: Kuo Jen Wei <inker@chromium.org> > Commit-Queue: Kuo Jen Wei <inker@chromium.org> > Cr-Commit-Position: refs/heads/master@{#703202} TBR=wangxianzhu@chromium.org,chrishtr@chromium.org,inker@chromium.org Change-Id: I7390267d2f56aed847dd0f615bebdac5e2348526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876870Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#708770}
-
Yang Guo authored
https://chromium.googlesource.com/devtools/devtools-frontend/+log/acb77af66d..d45051a43c TBR=bmeurer@chromium.org Change-Id: Id86bca44c7d9356d44e722fa83af81707bfab610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876848Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#708769}
-
Sasha McIntosh authored
Mirroring ScopedImageDecodeTask, measure and record decoded image upload time for gpu raster tasks. Added metrics: Renderer4.ImageUploadTaskDurationUs.{ImageType} Renderer4.ImageUploadTaskDurationUs Renderer4.ImageUploadTaskDurationUs.OutOfRaster Bug: 963619 Change-Id: Ie4faaba63129b13a35eddf3b91b93635940e04bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852485Reviewed-by:Eric Karl <ericrk@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Cr-Commit-Position: refs/heads/master@{#708768}
-
Dave Tapuska authored
Remove FrameMsg_NotifyUserActivation and add an API on LocalFrame to cause a UserActivation caused from some user action in the browser. BUG=1008432 Change-Id: I0d4f808b1cd23d73baa2cd752026c5541e770801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871643 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#708767}
-
Ian Kilpatrick authored
Not sure why the other phases weren't included in the initial patch when this was introduced: https://chromium.googlesource.com/chromium/src/+/dd40dd139ddc8739797f923d4bcd3681e694ac2c But this fixes all the descendant clip related issues when turning on block-level fragment painting. Bug: 988015 Change-Id: If6d88422ff5a4dc1bc06d60588a5b4fd5227e74b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869012 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#708766}
-
Dale Curtis authored
Since we have been unable to join on the VideoDecoderStats table due to processing times and lack of cross correlation per resolution, metrics leadership has asked we add this field directly to watch time calculations. BUG=1002587 R=chcunningham Change-Id: Id7ef8a28ec43607920885d62f3597b54aad647cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869681Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#708765}
-
Adrian Taylor authored
This omission has resulted in some bugs not being credited properly in release notes. R=wfh@chromium.org Change-Id: I27f9ff6605f3d037afdbeb8552e7f277436d9b7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868917 Auto-Submit: Adrian Taylor <adetaylor@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Adrian Taylor <adetaylor@chromium.org> Cr-Commit-Position: refs/heads/master@{#708764}
-
Dana Fried authored
Provides a little more information when a particular pathological case is reached. This case can happen due to quirks in Views and almost always indicates a bug in the infrastructure so it's important to know what view is causing the problem. Change-Id: I9527773a2a8660fcb5646c6802a489772db8a6e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876914 Commit-Queue: Dana Fried <dfried@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Auto-Submit: Dana Fried <dfried@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#708763}
-
Tommy Li authored
Currently, RemoteSuggestionsService sounds more general than its true usage, which is only for ZeroSuggestProvider. This CL makes that more clear in the class comment, as well as adding a TODO for a structural cleanup. Bug: NONE Change-Id: Iac4604e62b967d27ae65218813ecfd31e32d3d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876875Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#708762}
-
Livvie Lin authored
Changes the static cast to fix a type mismatch. Bug: 1016898 Change-Id: I4133129cc676065e0014d8c938bf04e3957b9962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875469 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#708761}
-
Tommy Steimel authored
This CL adds the ability to hide the app icon view in Message Center's NotificationHeaderView. This allows the Global Media Controls dialog to hide the unnecessary Chromium icon that appears before the URL. Bug: 1011047 Change-Id: Ic3e5a8e57ecfc14698697370e4fc0d5840c28ff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875276Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#708760}
-
Henrique Ferreiro authored
Convert the implementation and all users of the ui::ozone::mojom::GesturePropertiesService interface. Bug: 955171 Change-Id: I8a70b91624fef3f7e94e25e2f7071d85a4dec42a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864776Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#708759}
-
Maggie Chen authored
Once GPU hang is detected in the GPU watchdog V2, the watchdog will try to load/unload a file from the hard drive and create/destroy a thread to see if the GPU has made any progress in the current task. This will give a hint if the system is busy. If the GPU is still stuck, Wait until 60 seconds has passed and check again the GPU status. After this, the watchdog kill the GPU main thread. This is to see whether the GPU thread is killed too early and to compare with V2 on the number of hangs. This piece of code can be deleted after the data is collected. Bug:949839 Change-Id: I3a6afeed21776553d7416682baf6eed2d521286c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872166Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#708758}
-
Hui Yingst authored
Change-Id: If554173ce7a75ecbcbb0464288875a3a5510e6bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869941Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Hui Yingst <nigi@chromium.org> Cr-Commit-Position: refs/heads/master@{#708757}
-
Rakesh Soma authored
Bug: 1013208 Change-Id: I74316f804e253516821bd4ae24a478e203f4914a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870011Reviewed-by:
Tien Mai <tienmai@chromium.org> Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Auto-Submit: Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#708756}
-
Elly Fong-Jones authored
This change moves ContentSettingBubbleContents from overriding CreateExtraView to using SetExtraView. Since the code for creating the extra view needs to store quite a few internal parts of the created view, it is left as a method on ContentSettingBubbleContents. Bug: 1011446 Change-Id: I8c14fffdfe742e3223dbb9431c6ef27761623419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876747Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#708755}
-
rbpotter authored
Web UIs using Polymer 3 generally have resources in two different directories: the original source directory (for data files) and a corresponding generated directory (for UI elements). This results in the resources map having paths of the form: @out_folder@/<gen_path>/path/to/ab/a.js as well as path/to/ab/b.js However, for bundling, all resources should live in the same directory structure in the unpak folder. This CL adds logic to correctly map the generated resources paths to their corresponding location in the source paths when unpacking, so that the resulting unpak folder will hold all files side by side, i.e. a.js and b.js will both be located in: <unpak_path>/path/to/ab/ Bug: 965770 Change-Id: I0f8ac02727a721f4ddc6c67d4e1788c2ce30f3f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875029Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#708754}
-
Jimmy Gong authored
- Adds a feature flag for the print server UI for consumers in printer settings. Bug: 1015628 Change-Id: I9b761e23d930775c35198fb072ba2664539476d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866860Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#708753}
-
Nate Fischer authored
No change to logic. This is a code cleanup for some subfolders of //aw/browser/. This was guided by chromium's copy of cpplint.py, fixing most of the errors it raised for these two subfolders. Test: /path/to/depot_tools/cpplint.py android_webview/browser/network_service/* Test: /path/to/depot_tools/cpplint.py android_webview/browser/safe_browsing/* Change-Id: Ib71092570a1123e4c3a12cca9febc250d5c803e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873350Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#708752}
-
Nigel Tao authored
This isn't enabled by default yet. This commit should not change the generated binaries. Bug: 1014044 Change-Id: I1edd29dc6533f7407043bee4d3399fb6c39b4068 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874412Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#708751}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1c5bed7f..17e452a6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib7b72b69d13a0091db4c254bc0d3ed158c421c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876487Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708750}
-
Tomasz Wiszkowski authored
This change updates EntitySuggestion mechanism to rely on common mechanism for all suggestions. Doc: http://doc/1aL_UcW1gdeSLqNzuJZlQPBqMG0XAwVaoa05UTyVulp8 Bug: 982818 Change-Id: I4562e777f2e899a1863e0e8179c9d4b6c5dc7a72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866988 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#708749}
-
Rune Lillesveen authored
Remove the remaining test failures for writing-mode propagation to viewport from TestExpectations. One of the tests had a missing period in the test text that caused it to fail, and the other one was fixed in the github repo, now passing. Bug: 988585 Change-Id: I307eb4453479a71529f6c96d87b299f22a7a2c36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875263Reviewed-by:
-
Dominik Röttsches authored
Add known DWrite error codes and NTSTATUS type failures that are commonly returned when IDWriteFont::CreateFontFace fails and returns a failure error code. Adding these to enums.xml helps interpret UMA results for the existing DirectWrite.Fonts.Proxy.CreateFontFaceResult metric, because HResult enum values are recorded for this metric. Currently, the mentioned error codes show up as hard-to-identify integer values. Adding them to enums.xml will make the metric easier to analyse. Bug: 1009402 Change-Id: I40e5bf8b8c8eebff4841cedf03eb848e296db821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876091 Commit-Queue: Dominik Röttsches <drott@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
Incorrect js file included, which made the tests fail. Bug: 1013965 Change-Id: Ie716a6c1734d96c0090752e9b88274d70643bf57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875754Reviewed-by:
-
Avery Musbach authored
When the MultiDisplayOverviewAndSplitView feature flag is disabled, during transition to unified desktop mode, the destructors of BackdropController and ShelfLayoutManager should call SplitViewController::RemoveObserver on the split view controller for the old primary root window rather than for the new primary root window. The present CL addresses the problem by adjusting the timing of when Shell::GetPrimaryRootWindow stops returning the old primary root and starts returning the new primary root. The child CL has some LOG(ERROR) code useful for verifying that the present CL serves its purpose. Bug: 970013 Change-Id: I81074d4883a7d252d1da6a808976b47ad22cfc32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869838 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#708745}
-
James Cook authored
This reverts commit 87fc2374. Relanding after fixing initialization in the chrome crash-and-restore case. The old code missed a call to OnProfileInitialized() in that crash-and-restore case. Instead of relying on chrome to call OnProfileInitialized() in all startup code paths, we now observe the IdentityManager for when the primary account information becomes available. Original change's description: > Revert "Migrate the Chrome OS device_sync service off of the mojo pref service" > > This reverts commit 671afa99. > > Reason for revert: Breaks proximity auth in the crash-and-restore > login flow (e.g. if chrome crashes during the session and logs you > back in automatically on restart). See crbug.com/1015215 > > Original change's description: > > Migrate the Chrome OS device_sync service off of the mojo pref service > > > > DeviceSyncService runs in the browser process on the UI thread. It can > > directly use the Profile's PrefService*. This simplifies the code, and > > will reduce the amount of work rockot@ has to do for Service Manager > > cleanup. > > > > Delete the DeviceSyncService mojo interface and implementation object. > > They primarily existed to support wiring up the mojo pref service. > > Instead, directly connect the DeviceSyncClientImpl to the backing > > DeviceSyncImpl. > > > > Explicitly initialize the DeviceSyncImpl when the user's profile is > > ready. The old code had startup timing dependencies that assumed that > > DeviceSyncImpl was created after IdentityManager had information about > > the primary profile. The new code instantiates the DeviceSyncImpl > > object earlier, and IdentityManager may not be ready yet. > > > > Bug: 977637, 1012941 > > Test: bots > > Change-Id: Ia32b687404e5b68980cb3aecd3003e6f7e48ffcd > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849217 > > Commit-Queue: James Cook <jamescook@chromium.org> > > Reviewed-by: Greg Kerr <kerrnel@chromium.org> > > Reviewed-by: Josh Nohle <nohle@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: Ken Rockot <rockot@google.com> > > Cr-Commit-Position: refs/heads/master@{#706181} > > TBR=jamescook@chromium.org,sky@chromium.org,rockot@google.com,kerrnel@chromium.org,hansberry@chromium.org,nohle@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 977637, 1012941 > Change-Id: Id6cf5f43aac57415dae266a7871c08e4954fa24b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865602 > Reviewed-by: James Cook <jamescook@chromium.org> > Commit-Queue: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707000} TBR=jamescook@chromium.org,sky@chromium.org,rockot@google.com,kerrnel@chromium.org,hansberry@chromium.org,nohle@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 977637, 1012941 Change-Id: I1fff46240f3b34a7d1276edb7e79a264150ceb73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869576Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#708744}
-
Mohammad Refaat authored
This method clears WK WebSiteDataStore default store data including wk forward/back cache Bug: 987646 Change-Id: I64bbb8015cc12a623c8a2096981d16198adc5a6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876732 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#708743}
-
Greg Thompson authored
It appears that this was supposed to have been disabled from initial commit. BUG=1001597 R=wfh@chromium.org Change-Id: I28eafadc31d7a8416263c35dccba89f579fd84b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876030 Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
-
Shawn Gallea authored
This prevents crashes when web_contents_window_ was null. Bug: b/136460199 Test: Compile cast_shell Change-Id: I6f48801e69745bcfc5fb29a7db0632e10a0bd8a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876890Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Shawn Gallea <sagallea@google.com> Cr-Commit-Position: refs/heads/master@{#708741}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/370eefceab98..75647d9e1ae7 git log 370eefceab98..75647d9e1ae7 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 lamontjones@chromium.org paygen: Don't remove all the locks all the time. 2019-10-23 vapier@chromium.org alerts: get it working under Python 3 Created with: gclient setdep -r src/third_party/chromite@75647d9e1ae7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I74d137fe1926b4e2a0e0a81a525a830b2e6b86a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876076Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708740}
-
Xinghui Lu authored
Password Reuse Detection is not fully functional on Android because it doesn't capture SetComposingText events and FinishComposingText events. In this CL, password manager listens to these two events. Also, since composing text may not be committed eventually, OnKeyPressed() is splitted based on the value of is_committed. If is_committed is false, the text is not concatenated in input_characters_. Bug: 1006430 Change-Id: Ibf3e17c5e86895e7b9aee32463455333c24a1759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873144 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#708739}
-
Danan S authored
Bug: 943901 Change-Id: I8917e05092856f5f909c8a4e1b60c73ac7e58739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876490Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Dan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#708738}
-
Stephen McGruer authored
It seems like this is causing consistent failures on Mac10.10 tests; not sure why it was created by the WPT importer in the first place. https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/48035 TBR=klausw@chromium.org Bug: None Change-Id: I89cf2d8c0e7ec47f80952310b746c3a904bef863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876889Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#708737}
-
Wei-Yin Chen (陳威尹) authored
PseudoTab represents Tab-like cards in the Grid Tab Switcher. It can be used to represent a card before the Tab objects are constructed. Bug: 1016952 Change-Id: I908dbe70dae6af691ae45ab3342701b4995220bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874708 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#708736}
-
Oriol Brufau authored
Since https://crrev.com/c/1477255, when you type something but the caret has been scrolled out of view, the scroll container only scrolls the minimum amount to make the caret become fully visible. The search field for languages has some line-height, min-height and padding-top values that make it taller than the caret. So there is some space above the caret which is not automatically scrolled into view when typing in the search field. The scroll container is later scrolled to the very top by some script, so it looks like it gets momentarily stuck while scrolling up. This patch fixes that by calling scrollIntoViewIfNeeded() on the search field when something is typed in it, so the scroll container is scrolled to the very top. Fixed: 1013556 Change-Id: I5524ad85e14d5d38a1aa31eb3ae061051ccc8dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873758 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
-
Garrett Beaty authored
Change-Id: Ica03d95af30be8221b67648578460ba2c7ce4a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869682 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#708734}
-
