- 09 Nov, 2018 40 commits
-
-
David Black authored
Previously Assistant cards were rendered using WebContentsManager. This did not support either single- or multi-process mash. After this CL, I'll do a follow up to remove WebContentsManager and AnswerCardContentsRegistry as they are no longer used by either Assistant nor AppList. Known issue: This works fine for single-process mash but a crash occurs in multi-process mash when testing on device. No crash occurs with a glinux build so need to do more debugging. That said, this still moves us forward and allows us to deprecate some classes :) Bug: b:78078693 Change-Id: Iae0e9de8e5291f0ac99bae12207483838ccb910e Reviewed-on: https://chromium-review.googlesource.com/c/1321861 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#607030}
-
Etienne Pierre-doray authored
base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more explicit counterpart. It should have been replaced by : * base::ScopedAllowBaseSyncPrimitivesForTesting in test files. * base::ScopedAllowBaseSyncPrimitives in non-test files * base::ScopedAllowBaseSyncPrimitivesOutsideBlockingScope when it's used on threads that don't allow blocking The last one is strongly frowned upon but this CL aims to document existing behavior rather than address it. Owners are encouraged to follow-up by fixing unnecessary waits and more particularly unnecessary waits outside-blocking-scope. Note: The non-for-testing versions require friend'ing in thread_restrictions.h but care was taken to add these friends ahead of git cl split (since it wasn't possible to do a line-by-line associated CL split). Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1288533 Please CQ if LGTY! This CL was uploaded by git cl split. R=stevenjb@chromium.org Bug: 766678 Change-Id: I931476842857ed391d7148febbcac1c811a9ead1 Reviewed-on: https://chromium-review.googlesource.com/c/1324398 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#607029}
-
Varun Khaneja authored
Bug: 867518 Change-Id: I16891cc486f3d884229482b8c4d90309f9994b43 Reviewed-on: https://chromium-review.googlesource.com/c/1327810Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#607028}
-
Scott Violet authored
If the server shows a window, views was also activating the window. Instead views should just show the window. If the server wants the window active, it'll activate the window. BUG=756085 TEST=covered by test Change-Id: I208945a61d8c96b5dba0a070d7f32f6536342f28 Reviewed-on: https://chromium-review.googlesource.com/c/1330710Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#607027}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I6e6c980f74f247b4fd1615f7a956a5e8e2a4f8b6 Reviewed-on: https://chromium-review.googlesource.com/c/1330110Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607026}
-
John Budorick authored
Tbr: chrisha@chromium.org Bug: 902335 Change-Id: Ie360d85f9f2a6ecc8f2305f9133a7313fb73dc09 Reviewed-on: https://chromium-review.googlesource.com/c/1330353Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#607025}
-
Andrii Shyshkalov authored
They became the default ones, no need to specify them. R=iannucci, vadimsh No-Try: True Change-Id: Iebc66d8291fdebab72fcdb334e26befdc6d90bf3 Reviewed-on: https://chromium-review.googlesource.com/c/1330288Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#607024}
-
Jun Mukai authored
OnEventFromSource for the |held_move_event_| may not return if one of the event handler creates a run loop -- this happens on tab-dragging. As long as |held_move_event_| is valid, any further touch moves are also held and not processed anymore. Bug: b/119260190 Test: manually Change-Id: Ibeacc167bbcf71d6d89a40ad2916ecf1f880998c Reviewed-on: https://chromium-review.googlesource.com/c/1330061Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#607023}
-
Carlos IL authored
Variations service now sets a flag if the last request was an HTTP retry, and uses it to decide whether to retry again, instead of relying on the scheme of the final URL. Also, retries are now disabled if the fallback url is HTTPS. Bug: 902727 Change-Id: Ibd6df4a22bc6302b231aff0ae32f8e1c8a1f277c Reviewed-on: https://chromium-review.googlesource.com/c/1325035 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#607022}
-
Roger Tawa authored
Bug: 902890 Change-Id: I57021c1d018a48869aecf404854566bbf0b5dabd Reviewed-on: https://chromium-review.googlesource.com/c/1330080Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#607021}
-
Tarun Bansal authored
Normalize the score across all anchor elements. This makes it simpler to use anchor element score when predicting the next navigation when there are many anchors on the webpage, and all of them may have high score. Also, includes minor cleanups where some of the variables are added to the header file. These will be used in the next CL. Change-Id: Iad914682ef6d96c1b4d3cab040b555a6723f05de Bug: 903945 TBR: ryansturm@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1328561 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#607020}
-
Sandra Sun authored
According to the spec, https://github.com/w3c/csswg-drafts/issues/2593#issuecomment-386154394 scrollIntoView should 1) Always snap to the target element's snap alignment, and 2) All the affected scrollers should also land on a snap position if one exists. This patch does part 2). Before a scrollable_area is added to the smoothScrollSequencer with its new scroll_offset, we will check if it has a valid snap offset around, and update the final offset accordingly. We'll implement part 1) in a separate patch. Bug: 842317 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ica22134ed0b1f9d36f5a017c8dd0be54e907dd3d Reviewed-on: https://chromium-review.googlesource.com/c/1188746Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#607019}
-
Kyle Milka authored
Bug: 864763 Change-Id: If3baac188ce07a4c2259b97b013353920b4ad3ba Reviewed-on: https://chromium-review.googlesource.com/c/1329668Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#607018}
-
Nektarios Paisios authored
Changes in the reland compared to the original patch: Switched to using GetRoot instead of Root() which might prevent the use of an uninitialized root object. Original description: Screen readers want to have a reliable way to know whether a document is still loading so as to ignore events coming from it. The current change can be made irrespective to whether we will mark the document as loaded when HTML parsing has started or when the "interactive" readyState has been entered. R=dmazzoni@chromium.org, aleventhal@chromium.org Bug: 897177, 903402 Change-Id: I681883999918ffdd32fc11d2f691b659c7e91149 Reviewed-on: https://chromium-review.googlesource.com/c/1327745 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#607017}
-
Eric Stevenson authored
Collides with components/autofill_assistant/browser/batch_element_checker.cc. Broken in https://chromium-review.googlesource.com/c/1323489. Bug: 903940 Change-Id: I8f5efa61ebc3e4ec44f9206ceff863f7082c36ba Reviewed-on: https://chromium-review.googlesource.com/c/1330293Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#607016}
-
Jun Choi authored
This CL adds UI flag to add WebAuthN UI that guides users through the pairing process when using Bluetooth authenticators. Bug: 877344 Change-Id: I12a109fc34f947e64db0ad99089f83fb39ccf6d0 Reviewed-on: https://chromium-review.googlesource.com/c/1329926 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#607015}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e28390cc438f..af0ede1e73a7 git log e28390cc438f..af0ede1e73a7 --date=short --no-merges --format='%ad %ae %s' 2018-11-09 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-09 mheikal@chromium.org Fix crash were CL has no reviewers Created with: gclient setdep -r src/third_party/depot_tools@af0ede1e73a7 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:895722 TBR=agable@chromium.org Change-Id: I1f65e12c3257a9fa87331f2e409dc702434e5c96 Reviewed-on: https://chromium-review.googlesource.com/c/1330007Reviewed-by:
-
Erik Luo authored
Hovering over a TextNode in DevTools will now highlight it on the page. Its tooltip shows "#text" with VisualOverflowRect dimensions. Screenshot: https://imgur.com/a/yPFT73e Bug: 893426 Change-Id: If988e72960aa68b2d9c666c5de3feb5ce1192509 Reviewed-on: https://chromium-review.googlesource.com/c/1269859Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#607013}
-
bsheedy authored
Moves the 'file count' metric generated by resource_sizes.py out of the _Specifics group into its own _FileCount group. This is a workaround for https://crbug.com/903970, where mixing units within a group causes malformed data to be generated when using the HistogramSet format. Bug: 892344, 892301 Change-Id: Icfd47567127d51f7ee703262c448c2619148cb10 Reviewed-on: https://chromium-review.googlesource.com/c/1330707Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#607012}
-
Scott Violet authored
This reverts commit ce37f17d. Reason for revert: Causes crash, see 903671 Original change's description: > Fix text input on ARC++ Kiosk apps. > > We changed IsInArcAppWindow() to use the window property, > aura::client::kAppType, but it's not set for ARC++ Kiosk apps' window. > It makes text input on ARC++ Kiosk apps stop working. > This CL adds a temporary workaround for this situation. Ideally, > IsArcAppWindow() in arc_util.cc should handle windows of ARC++ Kiosk app > correctly. > > Bug: 891825 > Test: Can type text on Wikipedia kiosk app. > Change-Id: I594aa5c0730704b9ad922441187297bd707de20a > Reviewed-on: https://chromium-review.googlesource.com/c/1291289 > Commit-Queue: Yusuke Sato <yusukes@chromium.org> > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601631} TBR=yusukes@chromium.org,yhanada@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 891825 Change-Id: Ic50a4bac3af3dfb7f8fd335bb669d3e620a4446a Reviewed-on: https://chromium-review.googlesource.com/c/1330339Reviewed-by:
-
Carlos IL authored
Bug: 885376 Change-Id: Ic1b4075a169512103994edabc53b5d1b6daffb10 Reviewed-on: https://chromium-review.googlesource.com/c/1325190 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#607010}
-
Mohamed Amir Yosef authored
After initial sync is done, sync loads the persisted metadata and checks their integrity against the bookmark model. This CL adds a UMA metric to track different reasons why metadata might be corrupted Bug: 516866 Change-Id: I94ed2d80ec487a52069de6a6124419f97b4d5456 Reviewed-on: https://chromium-review.googlesource.com/c/1329248Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#607009}
-
Bailey Berro authored
- Creates a free form SMB share dialog - Dialog will be opened by SmbProvider::RequestMount Bug: chromium:887135 Change-Id: I379417ac15d633bce704bd50c8d31e8488fc2975 Reviewed-on: https://chromium-review.googlesource.com/c/1289409 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
wutao authored
This cl add a STOP button to timer notification. Bug: b/118655426 Test: manual Change-Id: I88752010e4b0c5be54debddb8394827a798d65fe Reviewed-on: https://chromium-review.googlesource.com/c/1330296Reviewed-by:
-
Scott Chen authored
Bug: 881937 Change-Id: Iac86251f6f6d7bba501b2add3260579d2f2ba53b Reviewed-on: https://chromium-review.googlesource.com/c/1327569 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#607006}
-
Martin Kreichgauer authored
There are versions of webauthn.dll that ship without BLE support. On platforms where that is the case, direct access to FIDO token is not blocked by the OS and so we don't want to integrate with webauthn.dll there. This changes WinWebAuthnApi to call WebAuthNGetApiVersion on initialization and mark the API as unavailable if the version number is not at least the current version (1). The check may be overridden by a flag while we wait for WebAuthNGetApiVersion function to ship. Bug: 898718 Change-Id: Ic20e55a416d858214b9f444031f4700567933eb4 Reviewed-on: https://chromium-review.googlesource.com/c/1327885 Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#607005}
-
Jao-ke Chin-Lee authored
BUG=790286,790294,790309 Change-Id: I5314b6a2743a83ed3b864b6842b32d023caed977 Reviewed-on: https://chromium-review.googlesource.com/c/1330340Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#607004}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b07ed8fb0766..2bb343c5e822 git log b07ed8fb0766..2bb343c5e822 --date=short --no-merges --format='%ad %ae %s' 2018-11-09 herb@google.com Remove runIndex as a concept for GrTextBlob 2018-11-09 reed@google.com rm legacy flags for hinting enum 2018-11-09 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-09 herb@google.com Reland "Move remove ptr args to MakeRecAndEffects" 2018-11-09 herb@google.com Revert "Move remove ptr args to MakeRecAndEffects" 2018-11-09 herb@google.com Move remove ptr args to MakeRecAndEffects Created with: gclient setdep -r src/third_party/skia@2bb343c5e822 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I4074acffea1b16b5c684b8b2d47166cca80b0257 Reviewed-on: https://chromium-review.googlesource.com/c/1329992Reviewed-by:
-
Siddhartha authored
Remove java mapped regions so that the unwinder does not try unwinding these frames at all. BUG=888434 Change-Id: Ic5999652ec85a4a3ed04aa7e8030d0a3faf11fbd Reviewed-on: https://chromium-review.googlesource.com/c/1327424 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#607002}
-
Kim Paulhamus authored
Bug: 902554 Change-Id: Ic14cfeaa7b041c316bcb77066d69a7b701bd5a62 Reviewed-on: https://chromium-review.googlesource.com/c/1321260 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#607001}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7b37bbfad45f..1ba4ba601cc4 git log 7b37bbfad45f..1ba4ba601cc4 --date=short --no-merges --format='%ad %ae %s' 2018-11-09 treehugger-gerrit@google.com Merge "profiling/memory: tiny fixups of a couple of copy/move aspects." Created with: gclient setdep -r src/third_party/perfetto@1ba4ba601cc4 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I69cc1381e2a50fa4332ac2d776ade5e00bfebc8f Reviewed-on: https://chromium-review.googlesource.com/c/1330023Reviewed-by:
-
David Jacobo authored
views::TouchSelectionMenuRunnerViews::Menu should be better by separating it on their own class, this CL introduces TouchSelectionMenuViews. Bug: None Test: Build. Change-Id: Ic9e8e258c41d2686746ff9b7d73fef1826424851 Reviewed-on: https://chromium-review.googlesource.com/c/1328281Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
-
Sammie Quon authored
Now that tablet mode manager tracks all user windows and not just current accounts, the window should be non account windows should be maximized on entering tablet mode, not on user switch. Test: unit_tests MultiUserWindowManagerChromeOS.TabletModeInteraction Bug: 903427 Change-Id: Ib21a7e1d7f1a37f8a571ad16226f11e03f0db960 Reviewed-on: https://chromium-review.googlesource.com/c/1329502Reviewed-by:
-
Kevin Marshall authored
Currently, a Frame doesn't process WebContentsObserver methods until a FIDL NavigationEventObserver is registered. WebContentsObserver is useful for more than just navigation events, though! In cases where a Frame is created but never passed a N.E.O., observer events like ReadyToCommitNavigation() were not being received, which interfered with on-load script injection. This CL fixes the issue by attaching the observer at Frame creation time. Bug: 903880 Change-Id: Ie3ab194fbaa60a5e18a4150be3ce4c6f7345845f Reviewed-on: https://chromium-review.googlesource.com/c/1328147 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#606997}
-
Kyle Milka authored
Allocate more ids for local ntp resources in preparation for adding more resources. Bug: 864763 Change-Id: I9b68fdda795959306d248eec973b86e0506323c7 Reviewed-on: https://chromium-review.googlesource.com/c/1327558Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#606996}
-
Roger McFarlane authored
Change-Id: Ia78991eda5e1e25ca410ab94b3a1176ae75f7d7a Reviewed-on: https://chromium-review.googlesource.com/c/1330333Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#606995}
-
Becca Hughes authored
Support playback state in MediaSessionImpl. This is analogous to the previous IsActuallyPaused boolean. Also exposes MockMediaSession as we have duplicate test helpers in content and services that can be shared. BUG=893296 Change-Id: I8d7120a64b2eb9792eb7ba11e1ef13849eb81b93 Reviewed-on: https://chromium-review.googlesource.com/c/1281905 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#606994}
-
Parastoo Geranmayeh authored
validity related members in AutofillProfile should be mutable, and changing them should not change an instance of the profile. (The instances could remain const.) Change-Id: I2b088013ab4be3f4d7116c6949285690c965d68f Reviewed-on: https://chromium-review.googlesource.com/c/1324233 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#606993}
-
Fabio Tirelo authored
This CL is the first step in the refactoring and: - Adds a new class (TabData) to represent the data in both C++ and Java, which replaces the AccessoryItem/KeyboardAccessoryData.Item classes. - Replaces AccessoryItem with TabData in the back end and sends it to the Java frontend. - Converts from TabData to KeyboardAccessoryData.Item in the Java frontend, so we don't need to propagate these changes everywhere. A follow-up CL will completely replace KeyboardAccessoryData.Item with TabData and remove the conversion listed in the last step above. Please check the linked bug for the desired final state as well as the steps of this refactoring to be sent in follow-up CLs. Bug: 902425 Change-Id: I6c28a31c682176c2409d3e3df2f6604768aed16d Reviewed-on: https://chromium-review.googlesource.com/c/1320732 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Friedrich Horschig [CET] <fhorschig@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#606992}
-
Mikel Astiz authored
Each flag maps to one feature toggle representing one (usually) or two (rarely) sync datatypes. If enabled, the sync datatype(s) are wrapped within the USS architecture, based on the so-called pseudo-USS approach (SyncableServiceBasedBridge). The functionality has been sanity-checked for crashes on dev&canary already, although some resulting UMA is suspicious. The flags should allow easier debugging and testing. Bug: 870624 Change-Id: Id5762c01f7232de8dda4e524083fae59f66217a2 Reviewed-on: https://chromium-review.googlesource.com/c/1329142 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#606991}
-
