- 17 Oct, 2019 40 commits
-
-
Daniel Libby authored
From the comment and linked bug history, this was introduced so that scroll code could identify main thread scrolling reasons. These have since moved to the scroll property tree, and no further compositing queries exist on this codepath (or at least are not hit by tests - this one is a pretty high-level disablement). Bug: 1007989, 625676 Change-Id: I86ee8d1ab864fe6334ba4c7c7aa35e07cdc937cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865424 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#706972}
-
Joe DeBlasio authored
Change-Id: Ib0eb67560ac8b5d070ad85d8d5d4e6b2faf90d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866875 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#706971}
-
Takumi Fujimoto authored
Enable the feature flag for the native DIAL MediaRouteProvider by default. Bug: 956621 Change-Id: Ied8686c0accfe46397b97890c9778f5876276484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864013Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#706970}
-
Lan Wei authored
This reverts commit 2000b5b1. Reason for revert: <INSERT REASONING HERE> inspector-protocol/accessibility/accessibility-getFullAXTree-display-locked.js is keeping failing on WebKit Linux MSAN. Original change's description: > DL: Fix flaky getFullAXTree & wrongly updated accessibility tests > > A devtoools display locking a11y test was marked as failing in MSAN bots > and is also flaky when tested locally, this CL updates that test and > fixes the cause of the failure (getFullAXTree might be called when > style/layout is dirty, which caused failing DCHECKs). > > Some other display locking a11y tests were not updated correctly, and is > updated in this CL as well. > > Bug: 996625 > Change-Id: I32eac1385c54eb07b1e6dab800620a2485158437 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846618 > Commit-Queue: Rakina Zata Amni <rakina@chromium.org> > Reviewed-by: vmpstr <vmpstr@chromium.org> > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706834} TBR=vmpstr@chromium.org,aboxhall@chromium.org,rakina@chromium.org Change-Id: I11a6bbc935ec0b88d9f72af37cc729cc28257766 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 996625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866620Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#706969}
-
Robert Ogden authored
Adds a new method, GetLastVisitToOrigin, to the history stack which gets the last visit to any page on an origin within a time range. This call is successful if there were no previous visits to that origin but reports a null base::Time. Bug: 995437 Change-Id: I56b421161c85076f5b81c61fcf1e31ef08abfe81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860733 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#706968}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/989bc351863d..b594247e39a4 git log 989bc351863d..b594247e39a4 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 ehmaldonado@chromium.org Reland "depot_tools: Run recipe scripts using vpython." Created with: gclient setdep -r src/third_party/depot_tools@b594247e39a4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1002153 Change-Id: I2e064ac8c7e012aa945ede3840763abe37c133a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866737Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706967}
-
Denis Kuznetsov authored
Previously OOBE UI Dialog size was controlled from JS code. This CL changes implementation so that dialog size is set according to UI specifications in C++ code, and web-based ui should just fully fit into given dialog. Note that code in ash/wm/lock_layout_manager / lock_window_state propagates bounds changes only to full-screen children, so OobeUIDialogDelegate will create full-screen Widget that will host WebUI dialog, receive all bound-changed events and update hosted dialog size according to specs. Bug: 1007294, 1007861 Change-Id: Ib81ec7f886cd406df98838de5af8401083de0b87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841953Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#706966}
-
Mitsuru Oshima authored
1) getAppWindowInfo to retrieve the list of application windows with ids. 2) setAppWindowState to set the window state using the id. 3) closeAppWindow to close the window. Bug: 1010671 Test: Covered by unit test except for close. It'll be covered in next CL. Change-Id: Iaa71764a58663713ac5d745b550bfa7b46bb383b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857603 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#706965}
-
chrome://device-emulatordpapad authored
This is in preparation of migrating this page to Polymer3. Bug: 1015241 Change-Id: Id8533d89043f288fee6aaa45fcbde5ef48bda51a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865266Reviewed-by:
-
Owen Min authored
Change MachineLevelUserCloudPolicyController to ChromeBrowserCloudManagementController Change MachineLevelUserCloudPolicyEnrollmentMetrics to ChromeBrowserCloudManagementEnrollmentMetrics IsMachineLevelUserCloudPolicyEnabled rename will be in the next CL. Bug: 1010704 Change-Id: I4e28f1e690237e7d310be42341d3b5f0ba47135f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865674 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#706963}
-
Denis Kuznetsov authored
Bug: 1000606 Change-Id: I35cb734412924fa0a315063c5ca80556f6bb40fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863094 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
Maksim Sisov authored
By accident, we didn't pass the icon further to the XWindow from the PlatformWindowProperties. This CL fixes that. Based on the patch provided by mail@maciej.szmigiero.name. Bug: 1007996 Change-Id: I3718f5f1698438ed07c5f453cdb445cd50a48219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864803Reviewed-by:
-
Sebastien Marchand authored
Also rename some of the existing params while I'm here to make them more explicit. Bug: 1014976 Change-Id: I6fade2127172343f22084b762a500309a418920b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865599 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#706960}
-
Daniel Vogelheim authored
The current Trusted Types spec no longer supports TrustedURL. This CL adapts to the spec. Reland after revert (crrev.com/c/1866406) Bug: 1002555 Change-Id: Ia683ad3ff4e7390ba59bf7313fd605c976cea3b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834142 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#706886} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864798 Cr-Commit-Position: refs/heads/master@{#706959}
-
Jan Wilken Dörrie authored
This change adds a check to TouchToFillController that allows disabling Touch To Fill for secure frames. This check queries a Field Trial Parameter which can be set on the server side. Bug: 1014042 Change-Id: I0ef9cf016b9057a8c2c3e97fbe356d7e49ffd28d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863932Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#706958}
-
Evan Stade authored
Bug: 268984 Change-Id: Ie8b843cbebedf8a4c881e6e275ca8f734af70331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856851 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706957}
-
Steven Bingler authored
Add metric to track SameSite cookies sent which cross schemes http-to-https and https-to-http, as seen from site-for-cookies to request, and are Lax or Strict. Add metric to track SameSite cookies sent with Lax or Strict. These metrics will be used to assess potential breakages if http://site.example and https://site.example were to be treated as cross site instead of same site as they currently are. Change-Id: I3a9e2831bba98d85cf0dd607e158b2bf4f8ed8d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863349Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#706956}
-
Eric Stevenson authored
Currently, trying to use proxy natives in an APK target will result in multiple copies of GEN_JNI.class being added to the final jar since: * The jni_processor creates a GEN_JNI for the library target it runs on * The java_library_impl inside the APK target also adds a GEN_JNI to the output .jar because the final JNI step is a srcjar_dep APK targets now support the annotation_processor_deps and processor_args_javac args and must provide "org.chromium.chrome.skipGenJni" to use proxy natives. This CL also converts chromium_linker_test_apk__apk to use annotation_processor_deps directly instead of the workaround added in http://crrev.com/c/1758655. Bug: 1001595 Change-Id: Ifb31b7c52327b2793540142eb013d0c39cb6435e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842297Reviewed-by:Andrew Grieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#706955}
-
zhaoyangli authored
This is the major change for autofill automation EG2 migration. - Separated test and app side code in former automation_egtest.mm by creating private helper function and app interface for app side calls. |NSString*| and |NSError*| are communicated between test and app. App interface code is mostly migrated from automation_egtest.mm with minor changes: - |GREYAssert|s are changed to |NSError*| to be sent back to test. - Moved some instance variable and methods to static variable and functions. - Overrode |launchAppForTestMethod| in |AutofillAutomationTestCase| to start app with needed features. - Created eg2test target and eg_app_support+eg2 target in automation BUILD.gn. Created new eg2tests_module and included new eg2test target in earlgrey2 BUILD.gn. - Removed unused headers in code and unused deps from build file. Bug: 987646, 1003605 Change-Id: I22ae675848bd1b08df9cdb375a6dcfb2f42b8c75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850739 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#706954}
-
Cathy Li authored
[ExploreSites]: Do not set height in the dense tile views to allow text to overflow when text size increases Bug: 1009093 Change-Id: Ia4cf81bf699f4fd392ff98e3212d62b77bf7b134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830170 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#706953}
-
Nicolás Peña Moreno authored
This CL adds a test where FCP must be equal to LCP for a website that has a single contentful element: a <p>. It is currently flaky in Chrome. Bug: 1015130 Change-Id: I0da2d7b15ac72fe2f0964043f01c49b089d201a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865540 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Tom McKee <tommckee@chromium.org> Cr-Commit-Position: refs/heads/master@{#706952}
-
Lan Wei authored
Browser tests ProfileMenuClickTest_WithUnconsentedPrimaryAccount is keeping failing on Mac 10.12. Disable it. Builder: Mac10.12 Tests https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests TBR=tangltom@chromium.org Bug: 1015429 Change-Id: Ib617d534d2ea7eb3b294b456837a5025ecc6698d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865145Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0544d1e26010..45f9f6cebc3a git log 0544d1e26010..45f9f6cebc3a --date=short --no-merges --format='%ad %ae %s' 2019-10-17 treehugger-gerrit@google.com Merge "processor: Add foundations for modularization of proto trace parsing" 2019-10-17 primiano@google.com Merge changes I24d0f3b6,I0e78257d 2019-10-17 treehugger-gerrit@google.com Merge "protos: Update comments on TrackEvent protos" Created with: gclient setdep -r src/third_party/perfetto@45f9f6cebc3a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I5e3c8dc8e0ecf2a28c476e281bb522b9034bb1ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866733Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5f01bf6c8b78..c06aef2ad1b3 git log 5f01bf6c8b78..c06aef2ad1b3 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 sprang@webrtc.org Reland "Use just a lookup map of RTP modules in PacketRouter" 2019-10-17 mbonadei@webrtc.org Update DEPS to download the checked-in JDK. 2019-10-17 mbonadei@webrtc.org Use symbol_level=1 also for MSVC dbg bots. 2019-10-17 sprang@webrtc.org Revert "Use just a lookup map of RTP modules in PacketRouter" 2019-10-17 sprang@webrtc.org Use just a lookup map of RTP modules in PacketRouter 2019-10-17 henrik.lundin@webrtc.org Avoid reading outside of memory in WebRtcVad_FindMinimum 2019-10-17 gustaf@webrtc.org Avoid running NullAudioPoller without receiving streams Created with: gclient setdep -r src/third_party/webrtc@c06aef2ad1b3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:b/142775365 Change-Id: I00413a82f84457d4efea64837516eae8619aa05d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866735Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e62dfe9064db..1b3fb455bf18 git log e62dfe9064db..1b3fb455bf18 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 perezju@chromium.org [Telemetry] Remove some dead code in story_run_unittest Created with: gclient setdep -r src/third_party/catapult@1b3fb455bf18 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:921000 Change-Id: Id41221d7be64891f834043ba7957a32373b51542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866734Reviewed-by:
-
Bailey Berro authored
This change switches to calling sync's ReportUnrecoverableError function rather that DumpWithoutCrash. This reduces the number of crash reports that are uploaded with this signature. Change-Id: I46cf634bbfa4dcd460dae89dd4b91a412678fa7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862246 Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#706947}
-
Miyoung Shin authored
This CL converts MediaControllerManager{Ptr, Request} in chromeos, content and services to the new Mojo type. Bug: 955171 Change-Id: Ic346dcdeac6e2dc59dc99a953345abd61f9d2c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849735 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#706946}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 60f3e975. With Chromium commits locally applied on WPT: 6386d9d8 "Update service_worker_unregister_and_register()" f2b0f018 "Revert "[Trusted Types] Remove TrustedURL."" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ib1c9ad76b650f97c9f8cb2cdd3a56563d00bc805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866691Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706945}
-
Cliff Smolinsky authored
If we patch a function in a delayloaded dll, __HrLoadAllImportsForDll is called to load everything before the patch. If we then patch another method in the same dll, __HrLoadAllImportsForDll is called again and this will overwrite the original patch. This change adds tracking to ensure the load only occurs once per dll. Bug: 1012424 Change-Id: Ib20fe38461a7eab3735f851bdfd53f9cf99fc5d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848362Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#706944}
-
Scott Violet authored
java_observer_ -> java_delegate_ BUG=none TEST=none Change-Id: Ic11f77dfc5110188e6dc658b0fdcd49975e48e40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866067 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#706943}
-
Scott Violet authored
This is a good basic set. I would like more, but they require js injection. BUG=none TEST=test*Fullscreen* Change-Id: I0a605e4aefe3b0be6b9a754e437aa496f1e059bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866271Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#706942}
-
Alex Chau authored
- SharedClipboard sender names are embedded in SharingMessage or determined in SharedClipboardMessageHandler - SharingService::GetDeviceByGuid now changes client_name returned - sender_guid is no longer embeded in AckMessage as it's only used for sending acks - Removed dependency of LocalDeviceInfoProvider in SharingFCMSender, instead sender_device_info is passed in and constructed by SharingService with updated client_name Bug: 1013565 Change-Id: If901fe96ba140b804a87fcd8d2565512d76fa167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865318Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#706941}
-
Kurt Catti-Schmidt authored
This CL is aimed at resolving differences in the platform-neutral accessibility tree depending on whether or not UIA is enabled. The goal is to make it possible to enable both IA2 and UIA simultaneously. The differences arise due to the presence of extra nodes to implement IRawElementProviderFragmentRoot for UIA. These extra nodes exist because, for a given web content accessibility tree coming from the renderer, we cannot identify whether that tree corresponds to a root frame, and thus whether that tree's root would be the node we would otherwise expose as the fragment root attached to the legacy HWND. IRawElementProviderFragmentRoot is obtained via QueryInterface, and COM rules require that the set of interfaces available via QI be static over the lifetime of a given object instance. To deal with this, we have separate nodes that act as fragment roots for each HWND, and each fragment root's sole child is the root of the associated accessibility tree. This CL takes these fragment roots out of the platform-neutral accessibility tree. Instead, we re-wire UIA tree navigation to account for fragment roots. The next steps would be to modify the places we check for UIA enabled to not assume that IA2 and UIA are mutually exclusive, and then to implement a feature flag to allow switching between IA2 only, UIA only, and both APIs enabled simultaneously. Bug: 928811 Change-Id: I7a0e6f1b12bc1a8b44fd7c08541703b1277bf9eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823822Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Vladislav Kaznacheev authored
Force-enable kShelfScrollable feature in ScrollableShelfViewTest to make sure they do not regress regardless of the default state of this feature. Bug: 1015426 Test: ash_unittests with and without --shelf-scrollable flag Change-Id: I2c07aaefaff2ba9785884e1959ebdd2a72a3398b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866871 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
-
Maksim Moskvitin authored
From processor perspective, we always choose remote update in case of conflict. This should work, because bridge aware of not-commited local changes. Pending local commits reapplied on top of incoming changes after processing conflicting remote update as regular update. Bug: 922900 Change-Id: I7673822b4c8b4bd21965d5b2401c9dd3d62f0e6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865333 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#706938}
-
Anatoliy Potapchuk authored
This one just created some code duplication of LoginStatus::KIOSK_APP Bug: 1015383 Change-Id: Id03e4813199dd38b29ca46845182b7f82b04382c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864799 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
-
Jazz Xu authored
Bug: 1015133 Change-Id: I515a115a14febce67c41566cee4a266e6c9386a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865262Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/42ac78d2d012..9b925bcdd2c1 Created with: gclient setdep -r src-internal@9b925bcdd2c1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I889f73b8394cc35559983faed7a49602457518ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866732Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706935}
-
Nico Weber authored
headless_shell_child_lib transitively includes something from webrtc (via content/browser) and it gets the include dir for that transitively via a dep on blink if is_multi_dll is true. So things only work by accident there. As a workaround, since we only depend on headless_shell_child_lib if is_multi_dll is true, make the whole target conditionaly. This remains questionable deps-wise (since we pull in the webrtc header via content/browser headers but get the include flag for it via the blink dep), but since multi dll hopefully goes away soon it'll fix itself. Bug: 726150 Change-Id: I23908e640a8ba61ace00ca5189f80d88c1537f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866849 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#706934}
-
Eric Willigers authored
Instead of defining a static constant equal to SkColorSetARGB(0, 0, 0, 0), use the constant defined in SkColor.h Change-Id: I193fe569569cd9698a0463da9d23f9f9bcff64a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865909 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#706933}
-
