- 19 Oct, 2018 40 commits
-
-
Yoshifumi Inoue authored
This patch gets rid of redundant call of |EmitEndBlock()| after calling ProcessChildrenWithRequiredLineBreaks() which calls |EmitEndBlock()| at end of function in |Element#innerText| for improving code health. Since EmitEndBlock() turns |has_collapsible_space_| to false, second call has no effect. Change-Id: I44012380d7335b33f901954ac24a85e9cd4e98b4 Reviewed-on: https://chromium-review.googlesource.com/c/1290058Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#601088}
-
Arthur Sonzogni authored
In bug 882661: one mojo::URLLoader is sending OnStartLoadingResponseBody without sending OnReceiveResponse before. Add instrumentation to check this never happen with this class. Bug: 882661 Change-Id: I8a157949feacfe65f0ea1aa8c32b28352d6d6f57 Reviewed-on: https://chromium-review.googlesource.com/c/1288595 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#601087}
-
Mario Sanchez Prada authored
Neither SigninManager nor ProfileOAuth2TokenService are in use anymore, we can safely remove them. Bug: 885174 Change-Id: I9ea858295b2bb868b7a8bdbb73ec34927041fbac Reviewed-on: https://chromium-review.googlesource.com/c/1288438 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#601086}
-
Yoshifumi Inoue authored
This patch gets rid of unused function |HasCollapsibleSpace()| from |ElementInnerTextCollector::Result| for improving code health. Change-Id: I2bd15fe2f8837f098d42dded7202e14ecf42eac9 Reviewed-on: https://chromium-review.googlesource.com/c/1290432Reviewed-by:
-
Jérôme Lebel authored
Replacing bzanotti by jlebel ios/chrome/browser/ui/first_run/OWNER, since bzanotti doesn't work on Chrome anymore. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I5defa6613f4e49dfd5a94a06539f44bf8a4ad379 Reviewed-on: https://chromium-review.googlesource.com/c/1288541Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#601084}
-
Takuto Ikuta authored
This CL is part of https://chromium-review.googlesource.com/c/chromium/src/+/1286016 This CL was uploaded by git cl split. R=jkrcal@chromium.org Bug: 753973 Change-Id: Id1503ebb271fd19492e49d98e821412d67cbc5aa Reviewed-on: https://chromium-review.googlesource.com/c/1288171Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#601083}
-
Jérôme Lebel authored
The sign-in/firstrun buttons is moved inside the safe area (related to the iPhone X like). The patch has been tested with rotation. ** Before ** - First run: https://drive.google.com/open?id=1Ig3SCaKTeCZkf3KfCnRHfPpAA9mZdLSB - Sign-in with first run: https://drive.google.com/open?id=1arrBQ44c9kj7_R8xIykEfxLcJZjfTlZT - Sign-in portrait: https://drive.google.com/open?id=17UlTFkc416iU72LeMFgg9PoEG-gRVXCc - Sign-in landscape: https://drive.google.com/open?id=1pqC00vqx6AtHDJHXSxc_0yZ2Qr_1O66l ** After ** - First run: https://drive.google.com/open?id=1c6rJtftJInGlNgLTj19jmsbzgRf3hQZv - Sign-in with first run: https://drive.google.com/open?id=19GRHlX6HdyO5HnPkVDzKCbxfcwSsyFyn - Sign-in portrait: https://drive.google.com/open?id=187VDZsNLMzI50q4RLi2eAaLsXs7aZ6Zm - Sign-in landscape: https://drive.google.com/open?id=1Q_WCYA8-JMI5cRtshLKAjFIXk9vLaNEn Bug: 864225 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I33478974bbb0de2180ab842eb07321dcf5140ed0 Reviewed-on: https://chromium-review.googlesource.com/c/1286659Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Fredrik Söderquist authored
Store the (stroke) geometry class in the LayoutSVGShape. This allows us to compute stroke bounds in a slightly less "context-aware" way. This is a step on the way to break up UpdateShapeFromElement into several steps. We can also get rid of LayoutSVGPath::HitTestStrokeBoundingBox since we now carry the information it provided in the geometry class. The geometry class also replaces the LayoutSVGShape::affected_by_miter_ so it is removed, and replaced with a new kNoMiters class type. Bug: 435097, 493888 Change-Id: I422b72451c6cea8045dea547a500984863e83a8d Reviewed-on: https://chromium-review.googlesource.com/c/1288359 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#601081}
-
Erik Luo authored
Password manager may analyze a page and report errors to DevTools: "[DOM] Found N elements with non-unique id#id: (More info:...)" This CL changes the level to warning, since duplicates do not break execution flow. Bug: 825184 Change-Id: Ia7bb544f712e14bc99a7fdf7d912fa70c2a4d5c7 Reviewed-on: https://chromium-review.googlesource.com/c/1064978Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#601080}
-
Takashi Sakamoto authored
Bug: 888904 Change-Id: I1d11d01e7adb51ec15d921c359d0e5171d00cb87 Reviewed-on: https://chromium-review.googlesource.com/c/1286241Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#601079}
-
Noel Gordon authored
FilesApp provides the innards of the extension file dialog. For tablet mode tests, always enable the Ash virtual keyboard and add a test that clicks dialog filename <input> element and checks that the Ash virtual keyboard appears. The virtual keyboard test and enable-features=SingleProcessMash do not play nice at this time: exclude this test from single process mash. Bug: 879434, 897012 Change-Id: Ia5a72abd3fcdbd12282c36b27cc1213fd7e6672b Reviewed-on: https://chromium-review.googlesource.com/c/1290571 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#601078}
-
Koji Ishii authored
Following bot results are included. 10805 10807 10816 10819 10820 10830 10836 10848 10851 10854 75 lines were removed and 2 lines were deflaked by consecutive results since 10792. New failures are from 'text-indent' changes in r600989 (CL:1285109). TBR=eae@chromium.org, mstensho@chromium.org, szager@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I13d5c2d6033ac237cc7d867490c4896702c0c2f6 Reviewed-on: https://chromium-review.googlesource.com/c/1288151 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#601077}
-
Christian Dullweber authored
This reverts commit dcf5246f. Reason for revert: It looks like this broke web_tests on linux-xenial-rel Original change's description: > [run_web_tests] Initialize printer earlier > > This allows logging before creating the port. > > Bug: 896799 > Change-Id: I3198fcaeb8d64d748a12d9882cddc273a9e3efe6 > Reviewed-on: https://chromium-review.googlesource.com/c/1289305 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Ned Nguyen <nednguyen@google.com> > Cr-Commit-Position: refs/heads/master@{#601049} TBR=wangxianzhu@chromium.org,dpranke@chromium.org,nednguyen@google.com,robertma@chromium.org Change-Id: I71ae432b2db53611d6cd44d788d8f450e714ba78 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 896799, 897019 Reviewed-on: https://chromium-review.googlesource.com/c/1290151Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#601076}
-
Marina Ciocea authored
Stat reporting was incorrect, and it's no longer needed because it's covered by the more generic stats ChildProcess.Crashed.UtilityProcessHash and ChildProcess.Launched.UtilityProcessHash. Bug: 866909 Change-Id: I89622417e3923f9a95d4553f95a369341499bbcf Reviewed-on: https://chromium-review.googlesource.com/c/1286856 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#601075}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/95c5c15bdec9..b4d999866772 git log 95c5c15bdec9..b4d999866772 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 briannorris@chromium.org cros flash: produce valid alternate GPT Created with: gclient setdep -r src/third_party/chromite@b4d999866772 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I2f93bfa22f8f1076267877032f99d3ce05778e44 Reviewed-on: https://chromium-review.googlesource.com/c/1290107Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601074}
-
Daniel Bratell authored
An android specific block in BUILD.gn kept some references to files that no longer existed after a cleanup in https://chromium-review.googlesource.com/896839 This caused some local issues with trybots so it was time to clean up the build files. Bye unnecessary code block. Bug: 808221 Change-Id: I29ff4fc149fe408bd2a97517fbc338b408d13e7d Reviewed-on: https://chromium-review.googlesource.com/c/1290272Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#601073}
-
Javier Ernesto Flores Robles authored
Adds a flag wich resets after a delay when the device rotates. This allows to know if certain notification are caused due a recent rotation. Bug: 845472 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I7b36544a451c677ff0ff842876f80841847a2833 Reviewed-on: https://chromium-review.googlesource.com/c/1273145 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#601072}
-
David Jean authored
Bug: 894031 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ib7d7e07e198043f8aacbbf78eef30a496be6550d Reviewed-on: https://chromium-review.googlesource.com/c/1288530Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
Suppress the warning only on windows build. This will help to prevent case insenstive include on Mac. Bug: 617318 Change-Id: I765c10473f750277706fe60ec1c4779d4e11203b Reviewed-on: https://chromium-review.googlesource.com/c/1286101 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#601070}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d34ba3865bbb..ebc5860af783 Created with: gclient setdep -r src-internal@ebc5860af783 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iee57d3f4cf7c99e5c53d959f5c1e8b36080d3b10 Reviewed-on: https://chromium-review.googlesource.com/c/1290106Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601069}
-
Ioana Pandele authored
The old icon can be completely removed once the generation popup is removed. Bug: 891323 Change-Id: I6bba6c657f2c442365141d64e01077387f4b0ceb Reviewed-on: https://chromium-review.googlesource.com/c/1280667Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#601068}
-
Fumitoshi Ukai authored
Bug: 835732 Change-Id: If4948dbc2eb49b32ab5b8c87e4356f07e4a89570 Reviewed-on: https://chromium-review.googlesource.com/c/1282444Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Shinya Kawanaka <shinyak@chromium.org> Commit-Queue: Fumitoshi Ukai <ukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#601067}
-
Leo Zhang authored
Bug: 837156 Change-Id: I226459175c995b029f30932327f19124f33ac1d5 Reviewed-on: https://chromium-review.googlesource.com/c/1288152Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#601066}
-
Daniel Bratell authored
The file discard_reason.h was deleted when its content moved into a mojom file in https://chromium-review.googlesource.com/1176267 but it was not removed from the sources lists. This caused some local problems with trybot servers so here it goes. Change-Id: I873bc5e643c87f83197b4f0512d2859371c1e005 Reviewed-on: https://chromium-review.googlesource.com/c/1288794 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#601065}
-
Takuto Ikuta authored
I will remove -Wno-enum-compare-switch flag to block incorrect enum type comparison. To enable the warning let me fix the current codebase. This CL is a part of effort. https://chromium-review.googlesource.com/c/chromium/src/+/1286016 This CL was uploaded by git cl split. R=raymes@chromium.org Bug: 753973 Change-Id: If4e27fa4d1977a57080090c5a2275de64cee626f Reviewed-on: https://chromium-review.googlesource.com/c/1288155 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#601064}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/aad5d36f95f1..2461c319ed08 git log aad5d36f95f1..2461c319ed08 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 343f58e4..c66210d3 (600903:601019) 2018-10-18 Peter) Slatala Fix the 'SetConfiguration(RTCConfiguration::use_media_transport)' setting. 2018-10-18 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 834490b7..343f58e4 (600802:600903) Created with: gclient setdep -r src/third_party/webrtc@2461c319ed08 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I10d08f6c4515cb89d16a2f39a5212184244808af Reviewed-on: https://chromium-review.googlesource.com/c/1290103Reviewed-by:
-
Fumitoshi Ukai authored
Bug: 835732 Change-Id: Ia09b959c4b0e0f6d28f5a4e320cd36525dbf9000 Reviewed-on: https://chromium-review.googlesource.com/c/1282044Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Fumitoshi Ukai <ukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#601062}
-
Daniel Bratell authored
Not all sources lists have been kept up to date with code movement/removal and it seems to make some isolate steps in cq sad for some CLs (mine). Change-Id: Ie643b34a044b927021ce8ad2774568973c328a3c Reviewed-on: https://chromium-review.googlesource.com/c/1288793Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#601061}
-
Michael Lippautz authored
Adds the following UMA metricss: - BlinkGC.TimeForGCCycle: Time spent in Blink GC for a complete cycle. This includes marking, the atomic pause, and sweeping. - BlinkGC.TimeForNestedInV8: Time spent in Blink GC events that are nested in V8 GC events. Bug: 843903 Change-Id: Ide371e4d599b6c0f19593d9d6c77ed88a86704c5 Reviewed-on: https://chromium-review.googlesource.com/c/1283369 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#601060}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e82e0c2cae50..d34ba3865bbb Created with: gclient setdep -r src-internal@d34ba3865bbb The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ibcd4edd6ea67a00c39226e995deac1102eda8f3a Reviewed-on: https://chromium-review.googlesource.com/c/1290102Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/60ad17593c93..cd316406e106 git log 60ad17593c93..cd316406e106 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 csmartdalton@google.com Fix ccpr build on wasm 2018-10-19 csmartdalton@google.com ccpr: Use SkMessageBus for thread-safe eviction of cache entries Created with: gclient setdep -r src/third_party/skia@cd316406e106 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=egdaniel@chromium.org Change-Id: Ibed1a1efedf072c74a4f44ecd1fc4b4cf065d2ab Reviewed-on: https://chromium-review.googlesource.com/c/1290529Reviewed-by:
-
Darren Shen authored
Somehow didn't upload newest changes to the submitted CL, so this is just following up. https://chromium-review.googlesource.com/c/chromium/src/+/1282514 TBR=jamescook@chromium.org Bug: 893859 Change-Id: I970b36469320705fc80f9e171957c53bce08d187 Reviewed-on: https://chromium-review.googlesource.com/c/1290590Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#601057}
-
Takuto Ikuta authored
This CL is part of https://chromium-review.googlesource.com/c/chromium/src/+/1286017 This CL was uploaded by git cl split. R=xdai@chromium.org Bug: 681136 Change-Id: Ie3ad102b5b38cbb0ee31622d4b544358a947b8f9 Reviewed-on: https://chromium-review.googlesource.com/c/1288343Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#601056}
-
Takuto Ikuta authored
The flag suppressed user defined warning from libc++ https://github.com/llvm-project/llvm-project-20170507/blob/a2e822e3ac432da65d730dca1f2cbeee49f6e235/libcxx/include/__tree#L1848 I think this will be useful to prevent forgotten const. Bug: 683349 Change-Id: I24199ae9bf065ee6560b6caa397cd5fd8c042e83 Reviewed-on: https://chromium-review.googlesource.com/c/1286103 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
This CL is part of https://chromium-review.googlesource.com/c/chromium/src/+/1286017 This CL was uploaded by git cl split. R=xdai@chromium.org Bug: 681136 Change-Id: I2dff39578c1c05a5ddef7758b74a84f7b54b00af Reviewed-on: https://chromium-review.googlesource.com/c/1288491Reviewed-by:
-
Jonathan Metzman authored
Comment it so that people uninterested in fuzzing can understand why something is a fuzzable_proto_library and what that means. Also, fix copyright/license headers in LPM GN files. Change-Id: I898816a69f574175b27a970a0e5a289b74b133b6 Reviewed-on: https://chromium-review.googlesource.com/c/1288895 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Cr-Commit-Position: refs/heads/master@{#601053}
-
Toni Barzic authored
This code is currently shared between file_manager app and webstore_widget app. The latter is not longer used and will be removed. Given that file manager will becaume the only user of the widget currently under components/chrome_apps/webstore_widget/cws_widget, move this to ui/file_manager. (This breaks webstore widget app, but as stated before, the app is no longer used) BUG=839992 TEST=Verify that installing new file system service in file manager works. Change-Id: Ibe0778b2bb8ef075765ce864835751414baa8841 Reviewed-on: https://chromium-review.googlesource.com/c/1288076Reviewed-by:Stuart Langley <slangley@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#601052}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I18a4a800b822a7c998b983c83501035589477721 Reviewed-on: https://chromium-review.googlesource.com/c/1290205Reviewed-by:
-
Fumitoshi Ukai authored
Bug: 835732 Change-Id: I57a009a667ff59e7b5c232df31faa03df830e979 Reviewed-on: https://chromium-review.googlesource.com/c/1282423Reviewed-by:
-
Xianzhu Wang authored
This allows logging before creating the port. Bug: 896799 Change-Id: I3198fcaeb8d64d748a12d9882cddc273a9e3efe6 Reviewed-on: https://chromium-review.googlesource.com/c/1289305 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#601049}
-
