- 10 Oct, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c5e0ac757a11..ad5f71649e21 git log c5e0ac757a11..ad5f71649e21 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 3c7ff8d4f0a1..82f84c4b8f19 (10 commits) Created with: gclient setdep -r src/third_party/angle@ad5f71649e21 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: chromium:None Change-Id: Id174c3f64769f0a0dba9eebe0f632d637a6a557d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851766Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704548}
-
Yoshifumi Inoue authored
This patch introduces |NGInlineCursor| member functions for painitng selection: - MoveToContainingLine() - MoveToFirstChild() - MoveToLastChild)( - MoveToLastLogicalLeaf() - Replacement for NGPaintFragment::InlineFragmentsFor() * MoveTo(const LayoutObject&) * MoveToNextForSameLayoutObject() - MoveToNextSibling() - TryToMoveToFirstChild() - TryToMoveToLastChild() - Property getters for detecting line break * Current{Base,Resolved}Direction() * CurrentSize() * CurrentStyle() * CurrentText{Start,End}Offset() * IsAtomicInline() * IsBeforeSoftLineBreak() * IsHiddenForPaint() * IsEllipsis() * IsLineBreak() * Rename |NGInlineCursor::IsAtEnd()| to |IsNull()| because |MoveTo{First,Last}Child()| set cursor to null if current position has no children. * Rename |NGFragmentItem::ChildrenCount()| to |DescendantsCount()| to avoid confusion with immidieate children count and descendants count. This patch is a preparation of the patch[1]. [1] http://crrev.com/c/1832843 Paint selection with NGFragmentItem Bug: 982194 Change-Id: Icc09d380371f08477fcc9a45ae0c03c50968a3f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851885 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#704547}
-
Hajime Hoshi authored
This adds new metrics for eviction by back-forward navigation: BackForwardCache.EvictedReason. BackForwardCache.EvictedReason records the reason why the page is evicted, e.g., by JavaScript execution. This CL is a split of the CL for all the metrices: https://chromium-review.googlesource.com/c/chromium/src/+/1782233 Bug: 1004676 Change-Id: Ieea66f2ae6ed30fb836262632ab39b450698a6e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820701 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#704546}
-
Eric Willigers authored
ExternalInstallOptions and InstallManager::InstallParams now contain DisplayMode instead of LaunchContainer. This allows minimal-ui to be supported by InstallManager. TBR=jonmann@chromium.org Bug: 1009909 Change-Id: I13adaf8f834f2cb2d8e80d7ad3bffc24b9d9d73d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849471Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#704545}
-
Adam Rice authored
Implement compression for "gzip" and "deflate". The implementation is hidden behind the ExperimentalCompressionStream flag. For unit tests, we compress and stream and uncompress it with pako, and we make sure its output is the same as our original data. The original CL was reverted in https://chromium-review.googlesource.com/c/chromium/src/+/1849376 due to failures on the MSAN and leak bots. The compression-stream.any.js test has been modified from the original version of this CL to improve performance, and also marked as slow. TBR=kinuko Bug: 999091 Change-Id: I3952f500cd1ea614397fdf47771e037546583a16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851584Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#704544}
-
Jan Wilken Dörrie authored
This change makes the Touch To Fill implementation robust against a quick double tap before opening the sheet. It does this by introducing a new flag in the renderer, that is only unset once a user has dismissed the Touch To Fill sheet. Until then each focus event will result in a call to PasswordAutofillDriver::ShowTouchToFill() if the other conditions are met. Prior to this change a user could trigger both the Touch To Fill sheet and the soft keyboard by a quick double-tap on an input field before the Touch To Fill sheet was expanded. Now this doesn't happen anymore, as a keyboard will only be shown after the user has explicitly dismissed the Touch To Fill sheet. Bug: 1012236 Change-Id: Ie207789fe35aced4f94e3a5433adee016f0738eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848696 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#704543}
-
Sigurd Schneider authored
This simplifies determining whether a location is inside a CSS header in the front-end (the front-end doesn't have to request the source to determine the end line:column from the start line:column and the size). Before/After: https://imgur.com/a/OFdQBNL Bug: chromium:1005789, chromium:1005708, chromium:1004203 Change-Id: I4c660c2a5f901cfe24d022b2636926ecf99254ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821721 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#704542}
-
Monica Basta authored
Use the concatenation of GAIA name and profile name as the identity of the profile to be shown in the User Menu and the profile switcher. With the efforts towards encouraging the use of multiple profiles, it becomes more important to show a clear identity for the profile and clear transitions on events like sign in, enable sync, sign out. If no primary account or unconsented primary account exists for the profile, the local profile name is used. Otherwise, we show the concatenation of GAIA name and profile name in this format: |GAIA name (profile name)|. The only exception where we only show the GAIA name is if the profile name is a substring of the GAIA name. The implementation is behind a kill switch |kConcatenateGaiaAndProfileName| enabled by default. Bug: 1012182 Change-Id: I27626d9e9c77f38698db1012abf5e3fceccc266d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845766Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#704541}
-
Sergio Villar Senin authored
In order to remove the dependency, the contents of the header file were merged in the already existing third_party/blink/public/common/notifications/notification_constants.h Bug: 1008303 Change-Id: Ic22f381d031475d00b2614640bad5022717ab74b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848694 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
-
Makoto Shimazu authored
This CL converts base::Bind to BindOnce or BindRepeating, and also changes relevant base::Callbacks or base::Closures to appropriate types. This CL is split from https://crrev.com/c/1831621. This CL was uploaded by git cl split. R=falken@chromium.org Bug: 1007760 Change-Id: I899d8944d5a54b317f274ae24f716cce39ef9600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849488 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#704539}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 64b82d94. With Chromium commits locally applied on WPT: 23748e60 "Change text directive to text=" 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: If78e608f3a641b86ea3308fcfe67abfaa3ee660e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851647Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704538}
-
Juan Antonio Navarro Perez authored
Test is flaky on Lollipop Tablet Tester TBR=boliu@chromium.org Bug: 1010034 Change-Id: Ie0de96720fe2396da9032b1cc745445c06dfab61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851707Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#704537}
-
Richard Knoll authored
This moves all required data to display sharing dialogs into the view itself instead of having to call through to the controller. User actions are bound back to the controller via weak pointers. This is a cleaner fix for a UAF issue caused by different lifetimes of controller and view and prevents further similar issues here. TBR=pkasting@chromium.org Bug: 1000934 Change-Id: I34b4695fb6cdddb96c0e7bbf5d7edd36c5e729db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789149 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#704536}
-
Eric Seckler authored
This reverts commit 79081496. Reason for revert: cause of the flakiness was identified and reverted Original change's description: > Disabling flaky ChromeTracingDelegateBrowserTest tests. > > Tbr: skyostil@chromium.org > Bug: 1012218 > Change-Id: If238d6632769c3f4faa4fde81d53b26ba83bdf01 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847293 > Reviewed-by: Patrik Höglund <phoglund@chromium.org> > Commit-Queue: Patrik Höglund <phoglund@chromium.org> > Cr-Commit-Position: refs/heads/master@{#703677} TBR=phoglund@chromium.org,skyostil@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1012218 Change-Id: I69ed751afd7cf328232c2b303933dc9c66fa4fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852204Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#704535}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/aa9175d6761d..e6b95e45544d git log aa9175d6761d..e6b95e45544d --date=short --no-merges --format='%ad %ae %s' 2019-10-10 primiano@google.com Merge "build: support target sysroot" Created with: gclient setdep -r src/third_party/perfetto@e6b95e45544d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I2b00c0bbdcb71ded3a851a9f0da2bb74e321d833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851769Reviewed-by:
-
Benoît Lizé authored
This CL turns load-bearing comments into thread annotations checked by the clang static analyzer. Comments were actually out-of-date already (as it wasn't specified that is_young_ must be protected by the mutex), though the code was correct. No behavior change, and besides the annotations, unit tests have to change as they need locking to access a variable. Bug: 924164 Change-Id: Iecac23df0c2e61f4d42be105387fa6bf7605d8cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849854Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#704533}
-
Robbie Gibson authored
The root cause for the bug is that the fakebox fades out as it scrolls up in landscape. After it gets all the way offscreen, its alpha is 0. Once that happens, Voiceover doesn't recognize it as a view, so there's no way to go back up to get it in view. To prevent this, this CL sets the minimum alpha of the fakebox/header to 0.01, so Voiceover will still see it. It still shouldn't affect the actual visibility because the fakebox is behind the toolbar by the time it fades out, so it still won't be visible. Bug: 985726 Change-Id: Ibbb3947561e13a6312bcdc8973c7c71c25e728cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849676Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#704532}
-
François Beaufort authored
https://dawn.googlesource.com/dawn.git/+log/e16a901fb853..91b2142ee44d $ git log e16a901fb..91b2142ee --date=short --no-merges --format='%ad %ae %s' 2019-10-10 beaufort.francois Change setVertexBuffers to setVertexBuffer Created with: roll-dep src/third_party/dawn Bug: 877147 Change-Id: Ia4bb0d2e0aa2e3f41c74c7a24e509198214f38b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848387Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#704531}
-
Juan Antonio Navarro Pérez authored
This reverts commit b5385fa9. Reason for revert: Appears to have broken VR render tests https://crbug.com/1013009 Original change's description: > Fix default font used in VR text element > > The VR code is using the default font "sans-serif". > The Font (and FontList) on that platform is the PlatformFontSkia > When creating the font with the literal "sans-serif", there is > not matched typeface. > > The function creating the typeface has a fallback path that try > "sans" which is the resulting typeface used. > > see: https://cs.chromium.org/chromium/src/ui/gfx/platform_font_skia.cc?l=53 > > This CL avoid to use that fallback logic. Instead, we rely on > the FontList behavior to use the default system font with the default > constructor. > > > R=alcooper@chromium.org > > Change-Id: I612502f32d77787b8f0346c0fc23cd65b68e3013 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847902 > Reviewed-by: Klaus Weidner <klausw@chromium.org> > Commit-Queue: Etienne Bergeron <etienneb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#704279} TBR=klausw@chromium.org,etienneb@chromium.org,alcooper@chromium.org Change-Id: I7a54e9bf314a67661e625cbb4d838eea73560b75 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852424Reviewed-by:
-
Gyuyoung Kim authored
This reverts commit 7cf54149. Reason for revert: This CL broke the build on bots. Original change's description: > Replace .mojom-blink.h with .mojom-blink-forward.h in blink - 12 > > To reduce pre-processed size of header files have been including > foo.mojom-blink.h, this CL replaces .mojom-blink.h with > .mojom-blink-forward.h in blink header files. > > This CL has no behavior changes and following CLs will > continue replacing them more. > > Bug: 1001360 > Change-Id: I034377bb4772d565567ced5dd15f58a6440ee1ee > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849741 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Cr-Commit-Position: refs/heads/master@{#704527} TBR=kinuko@chromium.org,tkent@chromium.org,gyuyoung@igalia.com Change-Id: Id98d6c344506431061536680b2f15a9547a83496 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1001360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851635Reviewed-by:
Gyuyoung Kim <gyuyoung@igalia.com> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#704529}
-
https://crrev.com/c/1842316Kinuko Yasuda authored
Adding a prefix tentatively, which is probably a bad fix TBR=bdea@chromium.org Change-Id: Ic9614606fbf8a96bdd8229ab7c842e5e16907f21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851630Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#704528}
-
Gyuyoung Kim authored
To reduce pre-processed size of header files have been including foo.mojom-blink.h, this CL replaces .mojom-blink.h with .mojom-blink-forward.h in blink header files. This CL has no behavior changes and following CLs will continue replacing them more. Bug: 1001360 Change-Id: I034377bb4772d565567ced5dd15f58a6440ee1ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849741Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#704527}
-
Fredrik Söderquist authored
This removes the ResolveFirstInterval() function, in favor of just passing the appropriate arguments to ResolveInterval(). The |is_waiting_for_first_interval_| is cleared in the StartedActiveInterval() callback (when the first interval starts), and SVGSMILElement::CurrentIntervalIsActive() is simplified to only check if |next_interval_time_| has been reached. Because of this, the initial value of that member field is changed to Earliest(). Bug: 998526 Change-Id: I56103218fd210fbcd11076f20757b06319f5a054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848692Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#704526}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5224ac45e460..a441815f4dc3 git log 5224ac45e460..a441815f4dc3 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 vapier@chromium.org lint: clean up arguments-differ warnings with func signatures Created with: gclient setdep -r src/third_party/chromite@a441815f4dc3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ic6854311040a659d2ee681c26d5639fbeabc8cfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851765Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ef91f895..d0b81401 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1a49857ed3cd954cd70bb5c9d067cc43b00bb8ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851645Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704524}
-
My Nguyen authored
Update Catalan's input method indicator to comply with ISO language code. Bug: 1003357 Change-Id: I5a27d65f76a9564bd191170e41a44c6824fe6b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834803 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#704523}
-
Eric Seckler authored
This reverts commit 32fac919. Reason for revert: crbug.com/1012218 Original change's description: > Improve InterningIndex performance by switching to std::array. > > Instead of MRUCache which uses a sorted map under the hood. Use two > std:arrays, one to store all the keys (very cache friendly when scanning > them). And then immediately jump to the value in the other array. > > This leads to a ~9% speed up (5 to 13% at the 95% confidence). See the > "two_arrays tracing/tipOfTreeTracing" sheet in > https://docs.google.com/spreadsheets/d/1HIiyUQa7d8eLfMBBBm_7V60kqNABYoFbHpKdpwnYu78/ > > Total tracing overhead is ~59.8% (52% to 67% at the 95% confidence). See the > "two_arrays tracing/tipOfTreeNotTracing" sheet in the doc above. > > Bug: 1007611 > Change-Id: Ie2584e0e3a13e34097021fd128387cfa4fabaeed > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844822 > Commit-Queue: Stephen Nusko <nuskos@chromium.org> > Reviewed-by: Stephen Nusko <nuskos@chromium.org> > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Auto-Submit: Stephen Nusko <nuskos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#703377} TBR=eseckler@chromium.org,nuskos@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1007611, 1012218 Change-Id: Ie5d8298a2a62e4856d1cd16fec7dae6bf1e73bf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852084Reviewed-by:
-
Jeevan Shikaram authored
Hide the uninstall button for system apps and remove the description for Chrome apps. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=415747&signed_aid=gwLp8IV1DTB8pINqUZ3Twg==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=415748&signed_aid=klGiEUGbTUYNh9P4-D_3HA==&inline=1 Bug: 1013034 Change-Id: I34a271d52eef8c0ed66b7fa7010d27fce3376968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851786 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#704521}
-
Justin Cohen authored
Bug: 1010765 Change-Id: I5aaf239b0cae1cfc0ca1600d89b6bdc6893e52c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849131 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#704520}
-
Johannes Henkel authored
It turns out we may not need to have a deeply nested hierarchy, so this PR attempts to flatten this hierarchy as we're creating child session instances. This avoids a crash that would happen for grandchildren when they're trying to use their parent's socket to send messages. BUG=chromedriver:3165 Change-Id: I4fb22a7aeaf67321a062deb831ebc68ace904b7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851227 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#704519}
-
Justin Cohen authored
On iOS13, WebKit started changing the URL visible webView.URL when opening a new tab and then writing to it, e.g. window.open('javascript:document.write(1)'). This URL is never committed, so it should be OK to ignore this URL change. Bug: 1012718 Change-Id: Id7f24384f3146ecad3af0fbfabfdfa02a9bb63f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849993 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:Ali Juma <ajuma@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d65a3ffb5ea1..01cfdcb21734 Created with: gclient setdep -r src-internal@01cfdcb21734 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I829fbf3f67531b090133be282092d9397777e42d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851824Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704517}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fe23b1de9ed0..0fc9b3829b47 git log fe23b1de9ed0..0fc9b3829b47 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 309b078c..92809357 (414 commits) Created with: gclient setdep -r src/third_party/skia@0fc9b3829b47 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: chromium:None Change-Id: I795a8ab228cd6d9a3e5268576de740362f94fa89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851726Reviewed-by:
-
Abhijeet Kandalkar authored
This CL converts usage of |ConsumerHostRequest| to mojo::PendingReceiver<mojom::ConsumerHost> Bug: 955171, 978694 Change-Id: I5ce130f32d6c1af7662e239e47046d8f2187250d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843992Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#704515}
-
Julie Jeongeun Kim authored
This CL converts AlertBridgeRequest and AlertBridgePtr to new Mojo types using PendingReceiver, Remote and Receiver. Bug: 955171 Change-Id: I24ef7e3f521e7967c75ad7ed8dedb80e3e0e1a2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846632 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#704514}
-
Miyoung Shin authored
This CL converts ImmersiveOverlay{Ptr, Request} in chrome and device to the new Mojo type, and use pending_receiver<ImmersiveOverlay> in isolated_xr_service.mojom. Bug: 955171 Change-Id: I6bffe1a07b9e2240834e69d2ebcada64b8fdd7fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847452 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#704513}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d7323cf7f12d..c5e0ac757a11 git log d7323cf7f12d..c5e0ac757a11 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 kbr@chromium.org Conditionalize DeviceCGL implementation. 2019-10-10 nazabris@microsoft.com Add D3D11on12 device option Created with: gclient setdep -r src/third_party/angle@c5e0ac757a11 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: Ie3cbf8a645de49ff7d95f99cc70d2a167efe507f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851326Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I3864d00ebe05e8395157369cc04effb7b79050e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851684Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/992c5b481bab..5224ac45e460 git log 992c5b481bab..5224ac45e460 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 jclinton@chromium.org Disable release HW tests for more betty and novato boards 2019-10-10 tbosch@google.com cros_setup_toolchains: Also copy .elf file from noccache version 2019-10-10 achuith@chromium.org Revert "chrome_chromeos_lkgm: Temporarily skip the betty trybot on the CQ." Created with: gclient setdep -r src/third_party/chromite@5224ac45e460 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Icca68167f2ae3fd431de543de875e326ad7023bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851385Reviewed-by:
-
Hwanseung Lee authored
Use enum class instead of enum for ActivatedShape enum class is more type safety. Bug: 940736 Change-Id: I377b57af89eb29199f31496b310d7adea414e711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850677 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
