- 08 Dec, 2020 40 commits
-
-
Megan Jablonski authored
"rw", "or", "tt", "tk", and "ug" were launched by the Translate service in March. Add those that are supported by l10n to the default Translate supported languages list. Also update translate and l10n comment names to match those in the Translate service. Bug: 1150514 Change-Id: Ifd69d003c1f2b917af3ac57b2631a566c33f3853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561268Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#834508}
-
Peng Huang authored
Bug: 1155622 Change-Id: I8def57cef648ec4881f666aec614200d13eac972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577815 Auto-Submit: Peng Huang <penghuang@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#834507}
-
Liquan (Max) Gu authored
This CL removes AndroidPaymentApp's dependency' on ChromeActivity by WebContents.getTopLevelNativeWindow().getActivity().get(). Bug: 1140340, 1156191 Change-Id: I8c0a5295ab931748c35c4d7c442f5b59b888af6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577856 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#834506}
-
Nancy Wang authored
This reverts commit 2cf475dd. Reason for revert: <INSERT REASONING HERE> This CL looks break browser tests: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29 2 Test Suite(s) failed. browser_tests failed because of: NewTabPageCustomizeDialogTest.All ProfilePickerEnterpriseCreationFlowBrowserTest.CreateSignedInProfile NewTabPageModulesDummyModuleTest.All NewTabPageModulesModuleWrapperTest.All ...17 more failure(s) (21 total)... interactive_ui_tests failed because of: NewTabPageDoodleShareDialogFocusTest.All NewTabPageCustomizeDialogFocusTest.All NewTabPageMostVisitedFocusTest.All Original change's description: > NTP: Allow modules to instantiate the header > > This CL removes the module header from the wrapper and instead allows > the modules to instantiate it instead. This makes the title and actions > properties of the ModuleDescriptor obsolete, so this CL also removes > those. > > Bug: 1152205, 1152216 > Change-Id: Ib524a59c8c8a7cc69e130b31a8557b903233ab95 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570390 > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Commit-Queue: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#834424} TBR=tiborg@chromium.org,steimel@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I2a3471f3bef9d8b6b1c3c7c6f026f0d1c9da00d2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1152205 Bug: 1152216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578296Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#834505}
-
Gavin Mak authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under web_tests/fast/. Bug: 1113033 Change-Id: I0a7a2fbc4c32d1bb8ea4ad7f6af297c25c332778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573000 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Auto-Submit: Gavin Mak <gavinmak@google.com> Cr-Commit-Position: refs/heads/master@{#834504}
-
Hongchan Choi authored
AudioWorkletProcessor::CopyParamValueMapToObject() assumed the array topology is always valid (DCHECK), but if the user code actively mangles the parameter descriptor getter the array to return invalid content this assumption becomes invalid. The fix is to fail gracefully when the object type or the array content is not correct. Bug: 1151069 Test: The repro case does not reproduce any more after 1 hour run. Change-Id: I3f8decd3721e9b00ba201e2f76751e4bc941e05d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569788Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#834503}
-
Fabrice de Gans-Riberi authored
* Add an implementation for a Cast Streaming Sender for testing at // fuchsia/cast_streaming:cast_streaming_test_sender * Move some common conversion code to its own header Bug: 1087537 Change-Id: Icdf95dea5436646b5a6f9da72735720f64f6a359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573238 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#834502}
-
Gavin Mak authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under web_tests/fast/. Bug: 1113033 Change-Id: Ia264d11f713b04f392be52ca503eb8dd5d412a43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573157 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
Shimi Zhang authored
Since the Android platform has this feature on Android R and above, we need to make it consistent with the platform. Bug: 1126778 Change-Id: Ie1404bc963e01b5154b4751413423f2e58ef9289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575729Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#834500}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607353071-6048a593794456949e3ffd6a87397fecfdc4317e.profdata to chrome-win64-master-1607363880-ba632ae780cc1bebf61d324b0c586630719677ae.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2498f51fa6923e493d37b3bd4d340c04a7b4abe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577799Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834499}
-
Gavin Mak authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under web_tests/http/. Bug: 1113033 Change-Id: I2e0be3a743d657d8ad986b56abde73b52fd15806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573001 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I8d224a4e5f9e77cebc7f24f11b9a53e4454d5ada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577805Reviewed-by:
-
Nodir Turakulov authored
This reverts commit 76bc29ba. Reason for revert: the rolled CL was problematic and was reverted. https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2576761 Original change's description: > Roll Depot Tools from 3b055d329e60 to 8bbab2d87493 (1 revision) > > https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3b055d329e60..8bbab2d87493 > > 2020-12-08 nodir@chromium.org [dirmd] Roll dirmd > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/depot-tools-chromium-autoroll > Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Bug: chromium:1154541 > Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com > Change-Id: I7708e6eed2fb6dbb672aca41e0f684536c27ac43 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577728 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#834492} TBR=ehmaldonado@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com,ajp@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,apolito@google.com,sokcevic@google.com Change-Id: Ic37722200d7c22be014a4f2d9d7707c8e9953d90 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1154541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577763Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#834496}
-
John Lee authored
This CL adds support for screen readers to read out when browsing data is being cleared and when it has successfully cleared. There seems to be an issue when the IronA11yAnnouncer's element lives outside of a modal dialog as it is ignored by the screenreader. Similarly, if the alert is inside of the dialog, its contents do not get read if the dialog closes. Therefore, the "Clearing data" alert needs to live inside the dialog as it is read while the dialog is open, and the "Data cleared" alert needs to live outside of the dialog as it is read after the dialog is closed. Fixed: 1101151 Change-Id: I88c3dd98383b5d1b66a4b8492dcc8e8b817a8843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569942 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#834495}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I5d825e91720fcab6bafd486f41b6c67fe2dd7fce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577798Reviewed-by:
-
Joel Hockey authored
Bug: 1098615 Change-Id: Ia0ac1e49eb8255b762211a13d1158395d05dca06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576233 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3b055d329e60..8bbab2d87493 2020-12-08 nodir@chromium.org [dirmd] Roll dirmd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1154541 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I7708e6eed2fb6dbb672aca41e0f684536c27ac43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577728Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fa2c56d16d1c..2ded1d94cebd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nancylingwang@google.com,ellyjones@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1056387,chromium:1148485 Tbr: nancylingwang@google.com,ellyjones@google.com Change-Id: I91e6f74c696b4d36f5886c1bf51ee02e06c03f36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577827Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834491}
-
David Black authored
Previously the recent files container managed both screen captures and downloads type holding space item views. Now, separate view classes are added to manage each respective section. As a result, these sections will now animate independently of one another. There is opportunity for a lot of additional refactoring that will be done in a follow up CL. The existing pinned files section and new screen captures and downloads sections can inherit from a common view class. The existing pinned files container and recent files container can also inherit from a common view class. Bug: 1154998 Change-Id: I27af3c70859a8cd3da91b3ea7b4668910ebe7ca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577938 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#834490}
-
Hui Yingst authored
CodeHealthRotation: Migrate Bind to BindOnce/Repeating in extensions/renderer/api/display_source/wifi_display/. This change migrates uses of base::Bind to BindOnce/BindRepeating, and uses of base::Callback to OnceCallback/RepeatingCallback. Please see crbug.com/714018 for full details about the migration. Bug: 1152265 Change-Id: I27d247be6958c1205c9ffa165b8554cf5df168d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566883Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Hui Yingst <nigi@chromium.org> Cr-Commit-Position: refs/heads/master@{#834489}
-
Brandon Wylie authored
This is a reland of d3688f7c Original change's description: > Reland "[ToolbarMVC] Move loadUrl logic to LocationBarMediator" > > This is a reland of 068a70b1 > > Internal change to remove the use of > LocationBarLayout#performSearchQuery: > https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/3428545 > > Original change's description: > > [ToolbarMVC] Move loadUrl logic to LocationBarMediator > > > > Bug: 1147581 > > Change-Id: Ic19a6f597138d6d9a769ac1fb186a317d8e3f3fe > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551466 > > Commit-Queue: Brandon Wylie <wylieb@chromium.org> > > Reviewed-by: Ted Choc <tedchoc@chromium.org> > > Reviewed-by: Filip Gorski <fgorski@chromium.org> > > Reviewed-by: Patrick Noland <pnoland@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#830389} > > Bug: 1147581 > Change-Id: I0c523ff90079294db6e38da24ba764386c6abd0e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558955 > Commit-Queue: Brandon Wylie <wylieb@chromium.org> > Reviewed-by: Filip Gorski <fgorski@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#832627} Bug: 1147581 Change-Id: Ib4da1e94a9b1f12653a8194d76b3bd8a545a5a62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568884 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#834488}
-
Bao-Duy Tran authored
This test used to check the integrity of legacy config file input_methods.txt [1] (mainly detecting typos therein). This was approx 9 years ago, before the migration to extension-based input methods. Nowadays, almost all of input_methods.txt is obsolete. Until recently, this test had only been checking data that's no longer used. After the recent refactor to add hermetic-ness [2], this test now only verifies local test data (!), further highlighting its unhelpfulness. [1] https://source.chromium.org/chromium/chromium/src/+/master:chromeos/ime/input_methods.txt;drc=8cbe6597e4cc8457f4e33ef2ad189f0553f59f54 [2] https://crrev.com/c/2546667 Bug: 1134465,1134526 Change-Id: I2842465289c0acd1acab217d3031a0327fb9bc88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576226 Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#834487}
-
Fredrik Söderqvist authored
The former is only used once, but we have similar code sequences for the the other two resources handled in WriteResources(). Move this sequence into a new WriteSVGResourceReferencePrefix() function and reuse that for all three. Bug: 1028063 Change-Id: If557d447d3e14702def8b99d8fee659cc316d355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575030 Auto-Submit: Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#834486}
-
Ken Rockot authored
Also delete a bunch of dead code within. Bug: 977637 Change-Id: Ieeb45f102332bf06568ab83b7183769b3da2fdf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568612 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#834485}
-
Tarun Bansal authored
Remove the logic for the experiment since it does not show any performance improvement. Bug: 1130607 Change-Id: Ifaf8ca94bece6fe48aa0c9b7038357b0a563f982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575194 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Auto-Submit: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#834484}
-
Glen Robertson authored
We should try to move profile to its own GN target (see linked bug). To do so we need to remove a few more deps from profile onto headers in //c/b. This CL adds a DEPS entry to prevent/deter new deps on //c/b from being added in the mean time. Bug: 1149277 Change-Id: I190c49fb3432ba275db3fb605f5f57e709779113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568994Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#834483}
-
Caroline Rising authored
Bug: 910739, 1152816 Change-Id: I44aa8b946783511e3e61c2b59625b338882dad8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568538Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Auto-Submit: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#834482}
-
Elaine Chien authored
Bug: 1145666 Change-Id: Ibcabfa5e2f3d5c9aa5fa1bec86855ed56854b518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575728 Commit-Queue: Elaine Chien <elainechien@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#834481}
-
David Black authored
The play icon is only applicable to the screen captures holding space item views so should be implemented at that level rather than at the base holding space item view class level. Bug: 1154998 Change-Id: I6f7bfe287a50f2029beff43c13e01cccc2a2d680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578003Reviewed-by:
-
Wojciech Dzierżanowski authored
This fixes the following issues with OverlayWindowViews sizing: - Windows: For large and small aspect ratios (e.g., 10:1 on my display) resizing the window was badly broken, with the window disappearing from the work area. - macOS: The minimum size was not enforced properly. For example, it was possible to resize a square window down to 146x146 pixels, which ignores the 260 lower bound on width. To fix the Windows issue, SizeMinMaxToAspectRatio() is merged into SizeRectToAspectRatio() and protection is introduced against exceeding the size limits. So for example, even for a large aspect ratio and a certain maximum width, SizeRectToAspectRatio() will never produce a height that is below the minimum height specified. SizeRectToAspectRatio() is now also re-used on macOS as a replacement for the Cocoa implementation of aspect ratio enforcement, which suffers from the issue described above. Bug: 1123249 Change-Id: Icdd5bcd920d940d7d46926a199300ce305c7f430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552394Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Cr-Commit-Position: refs/heads/master@{#834479}
-
Yuki Shiino authored
Just updates the test expectation by running: third_party/blink/tools/run_bindings_tests.py --reset-results Change-Id: If7ca26d339d4045ea0bb9b62fe32fa8bdc0615b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576985 Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#834478}
-
Zhiyuan Cai authored
This change adds a new message type PRICE_WELCOME to current message scheme. A new layout tab_grid_price_message_card_item.xml is created and a new UiType PRICE_MESSAGE is added correspondingly. This feature is hidden behind the flag ENABLE_PRICE_TRACKING. Some more specific logics such as where to show the message card will be added in the later CLs, as well as the tests for this CL. Bug: 1148020 Change-Id: If4d6b11762c9a16f6d73ee05bcee7f6bacfdcbf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556657 Commit-Queue: Zhiyuan Cai <zhiyuancai@google.com> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#834477}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/48b2aad780bf..3efbe10ffd42 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I58d86b9f9114ba8efdc23b92583d235859f5fd14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578077Reviewed-by:
-
Felipe Andrade authored
Remove Kerberos settings from people section when KerberosSettingsSection flag is enabled. Kerberos accounts entry will be hidden in the UI and the search tags won't be created (inside people section). Instead, they will be added to the new Kerberos section (currently under development). Bug: 983041 Change-Id: I852ddcb4921c7aac4b7088bf0e72dac58411e771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565430 Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#834475}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c56ea91f6bd1..48b2aad780bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I23acca4038ec2be4239b3c2e352b142f6ee353a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575523Reviewed-by:
-
Stephen McGruer authored
With this change, passing --debug-rwt-logging to run_web_tests.py will cause base.py to print the difference for a failing reftest to the console. A better solution would be to parse the data from image_diff and pass it back up the stack to be embedded in the results, but this approach is quick and works. Bug: 997202 Change-Id: I541110cdafa18287fc47856c71a2c41427cf297d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575455Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#834473}
-
Gavin Mak authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //chrome. Bug: 1113033 Change-Id: Ia95da91501cd73d454dab90f888dba6c5506e1e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576626Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/011a77357ec4..529b25929c85 2020-12-07 michaelludwig@google.com Use SkTCopyOnWrite more in SkCanvas 2020-12-07 nifong@google.com update buildbot repo to deploy debugger changes from https://skia-review.googlesource.com/c/buildbot/+/341046 2020-12-07 johnstiles@google.com Replace array indexing on vector types with swizzles. 2020-12-07 nifong@google.com handle different bounds for every frame 2020-12-07 bsalomon@google.com Take origin when creating/updating backend texture using pixmaps. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jmbetancourt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jmbetancourt@google.com Change-Id: Iefe44a1ad9a8b6c16fe946283580d3d309db9ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577822Reviewed-by:
-
Kinuko Yasuda authored
These don't need this generic API in most cases, but can just use a simpler SetHeader(), which is clearer and less error-prone. Bug: 862175 Change-Id: I7d1fb86b2f9c81fc4858a55a094ae3be696e049d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577150Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
Specifically ExtensionPageCaptureApiTest.SaveAsMHTMLWithoutFileAccess, which is flaky everywhere. Bug: 1156323 Change-Id: Ie47a1e830df1ae145cb593f5a4c6516c4dcf2cab Tbr: lazyboy@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577588Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#834469}
-
