- 21 Dec, 2018 15 commits
-
-
Lukasz Anforowicz authored
In presence of Strict Site Isolation (aka site-per-process) this CL should prevent a compromised renderer from being able to commit an origin incompatible with the process lock. Note that more work is still needed to protect other isolation modes (citadel-style protection is needed to prevent non-locked processes from committing an origin that requires a dedicated process). Change-Id: Ifc39a81d8a1ded184c2ceb64c943f7ed2babb858 Bug: 770239 Reviewed-on: https://chromium-review.googlesource.com/c/1383293 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#618405}
-
Jay Harris authored
The custom tab bar should appear as an extension of the title bar. Before this CL, this was not not the case on Linux or Windows without DWM (disable-dwm-composition), as we draw small borders between the window frame and the toolbar. This CL removes them when displaying the custom tab bar. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=372746&signed_aid=ybrF8gUqHfRhz-mI-R7-SQ==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=372747&signed_aid=-_9BQ_5YxzT6Gg67Aj49ag==&inline=1 Bug: 853593 Change-Id: Ice90aef02c074d344066f8b5dd8e50fe77310a8e Reviewed-on: https://chromium-review.googlesource.com/c/1385685 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#618404}
-
James Robinson authored
This adds a black-box test of the webrunner's functionality as a runner for http:// URLs in Fuchsia. The test opens up a random port on the device, instantiates web runner via launching a web URL, then verifies that the URL is fetched and parsed. Change-Id: If3084760eb96bdc9c609ab9beef1a3507ee77011 Reviewed-on: https://chromium-review.googlesource.com/c/1387813 Commit-Queue: James Robinson <jamesr@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#618403}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I612a908d462425630e3c14778fde679e6eee4308 Reviewed-on: https://chromium-review.googlesource.com/c/1387675Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#618402}
-
Tien Mai authored
TBR=rogerta@chromium.org Bug: 917155 Change-Id: I1ac44cfe4b25264f954b97350c7b0e69ec029aa7 Reviewed-on: https://chromium-review.googlesource.com/c/1388043Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#618401}
-
Lukasz Anforowicz authored
The following tweaks were made: - Use NavigationSimulator where possible (instead of manually calling individual functions of TestRenderFrameHost). - Target the correct RenderFrameHost (which might change during a navigation that requires a process swap). This is achieved by introducing the GetNavigatingRenderFrameHost helper method. - Fix several tests that used a different url 1) when initiating the navigation and 2) when committing the navigation. - Change interstitial tests so that the target page doesn't change while the interstitial is shown. - Make sure that Forward_GeneratesNewPage and Reload_GeneratesNewPage unit tests pass the correct value of |did_create_new_entry| (which is |false| in browser tests / in production). This changes the expectations of Reload_GeneratesNewPage to match the production (reload should replace the history entry, instead of creating a new entry) and Forward_GeneratesNewPage (no pruning needs to take place). This change is supported by introducing a new browser test that replicates the scenario of Reload_GeneratesNewPage. Cleaning up unit test will help proceed with enforcement of CanCommit origin checks (which might have otherwise introduce "renderer kills" during the tests). Bug: 770239, 916783 Change-Id: I0af7e1049376a0d0834d48f4de05fb0fe38d56df Reviewed-on: https://chromium-review.googlesource.com/c/1387196Reviewed-by:
-
Tommy C. Li authored
Updates the bookmark copy to write a hyperlink. The justification to not write a hyperlink no longer applies. It also makes copying bookmarks more congruent with how copying from the Omnibox will work soon. See: https://chromium-review.googlesource.com/c/chromium/src/+/1370909 This CL also simplifies the copy API a bit. Bug: NONE Change-Id: Ibfd097a0ba6675a831fa8746987a15986e2337fa Reviewed-on: https://chromium-review.googlesource.com/c/1387949Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#618399}
-
Dana Fried authored
This fixes a DCHECK caused by a race condition between listeners. It is possible to try to resize a ToolbarActionsBar which has not yet been notified that an action was added; the inconsistency resulted in an immediate layout, which resulted in a DCHECK failure in toolbar_actions_bar.cc:223: DCHECK_EQ(model_->toolbar_items().size(), toolbar_actions_.size()); This bug occurs deterministically when launching the old Cast dialog, which adds its icon to the browser actions container rather than as a first-class toolbar icon as the new Cast dialog does. Now we only lay out the view after all of the callbacks take place, so the containers all have the proper number of things in them. We remove the callback on resize started, since the only time this can affect things is if the actions bar in the toolbar is resizing smaller while the menu is open, which should not happen. We continue to lay out after a drag operation, because we need to immediately resize the view if the number of lines of icons changes. Bug: 916687 Change-Id: Id22c6f1697ace1cddc8813016c02a488fb5134bb Reviewed-on: https://chromium-review.googlesource.com/c/1384929Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#618398}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2b35654dcf74..92b16ea26290 git log 2b35654dcf74..92b16ea26290 --date=short --no-merges --format='%ad %ae %s' 2018-12-20 courtneygo@google.com Re-land: Compress symbols for libraries Created with: gclient setdep -r src/third_party/angle@92b16ea26290 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I4a6c1c9b07eec679b1e24aaae7100c173dca8f80 Reviewed-on: https://chromium-review.googlesource.com/c/1387663Reviewed-by:
-
Fergal Daly authored
Currently there is "setup" which runs before every test and "done" which runs after all tests are finished. This adds "teardown" to run after every test as a inverse of "setup". It seems like many tests thought "done" was already behaving this way. Bug: 914276 Change-Id: I9fdb83c5616d77f187624fea21cd7b07898765ed Reviewed-on: https://chromium-review.googlesource.com/c/1381397Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#618396}
-
Xiaocheng Hu authored
This patch converts the web test with testharness to reduce usage of legacy editing.js. This is also a preparation for implementing bidi caret affinity. Bug: 917165 Change-Id: I84bbcba69f6a9dc768e92081b274146689635e28 Reviewed-on: https://chromium-review.googlesource.com/c/1388026 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#618395}
-
Ehsan Karamad authored
This CL introduces a new enumeration metric for feature policies, namely, "PotentialViolation". This new metric tracks potential violations of each feature policy in a document; that is, for feature policy X this metric would emit a potential violation if the conditions to violate feature X are (regardless of the actual feature X being disabled in the document). In other words, the metric tracks the percentage of pages that would have violated the given feature X if it was disabled in all documents. Most current policies are covered by this CL. The few cases where a policy generates its own violation report, or does not support reporting violations yet, will be addressed in future CLs. Bug: 915788 Change-Id: Iccb77ee8f47995a0debe7bb1faafbee3686b2ed6 Reviewed-on: https://chromium-review.googlesource.com/c/1380933 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#618394}
-
Li Lin authored
Send the server side experiment ID for enabling OPEN_APP action in AS if open app is supported in the client. Bug: b:121043828 Change-Id: I4e22800649a30498b61e116e304b123767de0502 Reviewed-on: https://chromium-review.googlesource.com/c/1387161 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#618393}
-
Lei Zhang authored
Messages with placeholders should be written as: <message>Foo <ph>$1</ph></message> and not as: <message>Foo $1</message> Detect this case and print warnings. In unit tests, throw exceptions. Once all GRD files are warning free, follow up and always throw exceptions. BUG=915681 Change-Id: I242b86bc0b8653e654c7a595a61f7668978f9bca Reviewed-on: https://chromium-review.googlesource.com/c/1385456 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#618392}
-
Katie D authored
Also changes 'let' to 'const' per new git cl presubmit error. Bug: 913369 Change-Id: I922ccccb6425a680f6da30200c8f0535fbd2daff Reviewed-on: https://chromium-review.googlesource.com/c/1376094Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#618391}
-
- 20 Dec, 2018 25 commits
-
-
Albert J. Wong authored
This changes the deletion order of RenderView and RenderWidget. From analysis, it seems the two pieces of code should be independent. Bug: 545684 Change-Id: I470c390eb7c3e51a6868fa758f76718c3d1cdcf7 Reviewed-on: https://chromium-review.googlesource.com/c/1387747Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
-
David Benjamin authored
Noticed this while I was in the area. Bug: none Change-Id: I2e0190ca2966ff6d9ed14daf584b76e82df3ff79 Reviewed-on: https://chromium-review.googlesource.com/c/1387840Reviewed-by:
-
Steven Bennetts authored
Previously the translation code assumed that onc::ipconfig::kIPAddress would never be empty, however that is not enforced in ONC. If the address is empty it should be treated as if it is not present. With this change the code will fall back to a Saved or Static IP Address if the value is missing or if it is empty. If none are available the IP Address will not be set. Bug: 902713 Change-Id: I2f9880966661a85a8aace04e56bdac8516e5b3e4 Reviewed-on: https://chromium-review.googlesource.com/c/1379207 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#618388}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e4beab79cd67..578b089986fa git log e4beab79cd67..578b089986fa --date=short --no-merges --format='%ad %ae %s' 2018-12-20 jvanverth@google.com Revert "Tweak Plot size to try to get better perf." 2018-12-20 herb@google.com Convert GrGlyph::PackedID to SkPackedGlyphID 2018-12-20 reed@google.com add gm and fix origin for xform-based blobs 2018-12-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@578b089986fa The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@chromium.org Change-Id: Ifd8c78a579a8634b7ce0e327d6a8947f3935557c Reviewed-on: https://chromium-review.googlesource.com/c/1387660Reviewed-by:
-
Nick Harper authored
Removal request received via email and validated via DNS. Change-Id: Iec03253374fc203a7c9785511151771ccc0162d7 Reviewed-on: https://chromium-review.googlesource.com/c/1387605Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#618386}
-
Kristi Park authored
TBR=sdefresne@chromium.org Bug: 893362 Change-Id: I9ad091f564dfc9d0e1772fb34222007e7cc51388 Reviewed-on: https://chromium-review.googlesource.com/c/1387910Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#618385}
-
Sergey Ulanov authored
Previusly when ssh port forwarding command exits with exitcode != 0 the script was trying to format error message with output.returncode, where output is a pipe, i.e. it doesn't have returncode field. Updated the script to use task.returncode instead. Change-Id: I132f7de42344244dfbdf16f4f4a500ac1a48b7df Reviewed-on: https://chromium-review.googlesource.com/c/1387726Reviewed-by:
-
Peter Wen authored
This option no longer exists in Android Studio 3.4+. Bug: 917016 Change-Id: I533d40288faf2693ad32fe9646d48073c30ac7c8 Reviewed-on: https://chromium-review.googlesource.com/c/1387155 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/bbf63435c37a..17da9f8231f7 git log bbf63435c37a..17da9f8231f7 --date=short --no-merges --format='%ad %ae %s' 2018-11-30 cepheus@frii.com Reserve tokens for float controls and no integer wrapping: Created with: gclient setdep -r src/third_party/spirv-headers/src@17da9f8231f7 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-headers-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ied8db2e8b2d87d962c41bc8b0854b04e2bc8c551 Reviewed-on: https://chromium-review.googlesource.com/c/1387673Reviewed-by:
-
Abhishek Bhardwaj authored
This change removes a separate test implementation of wake locks. This results in more production code being unit tested. BUG=chromium:913353 TEST=Run WakeLockTest unit tests. Change-Id: Ie4b3d3384c148c90c6ee937b91710bfe9b87d9c8 Reviewed-on: https://chromium-review.googlesource.com/c/1379704 Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#618381}
-
Jay Harris authored
An instance of the badge service can be moved between different browsers so we should find the delegate/hosted_app as needed instead of storing them at instantiation. Bug: 916904 Change-Id: Ia91875f3342be0bb7b2e7dd1807efd2cdd36206c Reviewed-on: https://chromium-review.googlesource.com/c/1385726 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#618380}
-
Dave Tapuska authored
Remove the paused_calls vector on WorkerGlobalScope because all the calls executed occur on pausable task queues after http://crrev.com/1eb2d22. BUG=907125 Change-Id: I42ad827eb1131f643158f9c6e565d69886896ccc Reviewed-on: https://chromium-review.googlesource.com/c/1385015 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#618379}
-
Tomasz Wiszkowski authored
Presentation is done by Mediator instead. Bug: 871798 Change-Id: If7fc3d1243990580d3e95c6ce3023fe23f03cd65 Reviewed-on: https://chromium-review.googlesource.com/c/1384632 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#618378}
-
James Robinson authored
This function shadowed the 'package_name' local so it always ended up running the most recently installed package instead of the specified package. This works fine for invocations with a single package, or with the target package last, but not for tests with multiple package dependencies. Change-Id: I1fe16ab22bd46970a99043fa42c810c32d323701 Reviewed-on: https://chromium-review.googlesource.com/c/1387905Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
-
Matthew Denton authored
This missing space may have screwed up WHERE statements when creating indexes (or might not have, since I don't see any errors. Adding anyway) R=metzman@chromium.org, pwnall@chromium.org Bug: 909886 Change-Id: Idd322f43a2b715d1d282546df4c504148a5014a4 Reviewed-on: https://chromium-review.googlesource.com/c/1387837 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#618376}
-
Leonard Grey authored
This change: - Mostly implements UX's secondary UI spec - Switches topchrome to use the same colors as incognito, though this may be temporary - Replaces some temp colors Bug: 912375, 850098 Change-Id: I447c3062455330b01c0e7381d3a9eabd2709a970 Reviewed-on: https://chromium-review.googlesource.com/c/1378408 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#618375}
-
CJ DiMeglio authored
This reverts commit b5126abd. Reason for revert: Breaks build Original change's description: > Revert "Add verification of e-mails being signed in using GCPW." > > This reverts commit 42eeddf5. > > Reason for revert: <INSERT REASONING HERE> > > Original change's description: > > Add verification of e-mails being signed in using GCPW. > > > > - Remove use of 'ep' registry for e-mail patterns and instead use 'ed' to > > specify valid e-mail domains. > > - Allow multiple valid e-mail domains > > - Check Gaia signed in user has a valid e-mail / gaia id > > > > Bug: 914366, 913977 > > Change-Id: Icb2a3281f2381d5c64200cafbfb2f452f5d0aecf > > Reviewed-on: https://chromium-review.googlesource.com/c/1381726 > > Commit-Queue: Tien Mai <tienmai@chromium.org> > > Reviewed-by: Roger Tawa <rogerta@chromium.org> > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#618215} > > TBR=rogerta@chromium.org,thakis@chromium.org,tienmai@chromium.org > > Change-Id: I82bfd838901dd7cd2730c4a0a1c8d0a4886b4c83 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 914366, 913977 > Reviewed-on: https://chromium-review.googlesource.com/c/1387961 > Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org> > Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> > Cr-Commit-Position: refs/heads/master@{#618371} TBR=rogerta@chromium.org,thakis@chromium.org,lethalantidote@chromium.org,tienmai@chromium.org Change-Id: I8888a63d3d14387a954b45cdbc306292ba97059c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 914366, 913977 Reviewed-on: https://chromium-review.googlesource.com/c/1388028Reviewed-by:
-
Sadrul Habib Chowdhury authored
Add a test to make sure that already removed presentation callbacks for submitted compositor frames do not cause crashes. BUG=915458 Change-Id: Ia0ae709a6a6792564a01d3086369f32850cf14fb Reviewed-on: https://chromium-review.googlesource.com/c/1381778 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#618373}
-
Zhenyao Mo authored
This reverts commit 6b713ba7. Reason for revert: This doesn't fix the test failure on Linux/AMD Original change's description: > Clamp texture BASE/MAX_LEVEL for GenerateMipmap on Linux AMD > > The conformance test fails on Linux/AMD. Let's see if the workaround may fix it. > > BUG=913301 > TEST=Linux AMD bot on GPU/FYI > R=kbr@chromium.org > > Change-Id: I15c73bfc36f621b3bc02d678be70727bb3995d42 > Reviewed-on: https://chromium-review.googlesource.com/c/1385106 > Commit-Queue: Zhenyao Mo <zmo@chromium.org> > Reviewed-by: James Darpinian <jdarpinian@chromium.org> > Cr-Commit-Position: refs/heads/master@{#618010} TBR=zmo@chromium.org,kbr@chromium.org,jdarpinian@chromium.org Change-Id: I49f854d90ae1df1dc1b3eb70c8584d2d98355848 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 913301 Reviewed-on: https://chromium-review.googlesource.com/c/1388025Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#618372}
-
CJ DiMeglio authored
This reverts commit 42eeddf5. Reason for revert: <INSERT REASONING HERE> Original change's description: > Add verification of e-mails being signed in using GCPW. > > - Remove use of 'ep' registry for e-mail patterns and instead use 'ed' to > specify valid e-mail domains. > - Allow multiple valid e-mail domains > - Check Gaia signed in user has a valid e-mail / gaia id > > Bug: 914366, 913977 > Change-Id: Icb2a3281f2381d5c64200cafbfb2f452f5d0aecf > Reviewed-on: https://chromium-review.googlesource.com/c/1381726 > Commit-Queue: Tien Mai <tienmai@chromium.org> > Reviewed-by: Roger Tawa <rogerta@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#618215} TBR=rogerta@chromium.org,thakis@chromium.org,tienmai@chromium.org Change-Id: I82bfd838901dd7cd2730c4a0a1c8d0a4886b4c83 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 914366, 913977 Reviewed-on: https://chromium-review.googlesource.com/c/1387961Reviewed-by:
-
Brian White authored
More than 1000 buckets is probably an error and so make it obvious to the user by a DCHECK and a reduced output. Some histograms are known to already have more than this number of buckets; whitelist those. Bug: 915892 Change-Id: I79a562ec7b883f57b5721e2f0ecd52f955044f39 Reviewed-on: https://chromium-review.googlesource.com/c/1385120 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#618370}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7b72af28fb84..f5b3ad2f705e git log 7b72af28fb84..f5b3ad2f705e --date=short --no-merges --format='%ad %ae %s' 2018-12-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-12-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-12-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@f5b3ad2f705e The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ie43e1f06714f7d58d8e1024cc38e37a2a7566d26 Reviewed-on: https://chromium-review.googlesource.com/c/1387833Reviewed-by:
-
Avi Drissman authored
This switches them to use Optional, and makes them clonable in preparation for linked_ptr removal. BUG=582001 Change-Id: I1ba6bb559b6fec703f41ad22ad670799ec61c91d Reviewed-on: https://chromium-review.googlesource.com/c/1380819 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#618368}
-
Mustafa Emre Acer authored
The top domain heuristic incorrectly marks certain domains as lookalikes, despite the fact that the domain itself is a top domain. As a result of this bug, tést[.]blogspot[.]com displays a "Did you mean to go to blogspot.com". This happens because: - We currently use INCLUDE_PRIVATE_REGISTRIES flag when computing eTLD+1s via net::registry_controlled_domains::GetDomainAndRegistry. - This results in the eTLD+1 of "tést[.]blogspot[.]com" being computed as "tést[.]blogspot[.]com" instead of just "blogspot[.]com". - Since the eTLD+1 contains IDN, we perform the top domain skeleton check. - This check compares "tést[.]blogspot[.]com" against top domains and finds "blogspot[.]com" as a match. - This in turn records metrics and shows the UI. This CL excludes private registries in eTLD+1 computation. As a result, eTLD+1 of private registries will exclude the subdomain, e.g. eTLD+1 of "tést[.]blogspot[.]com" will now be computed as "blogspot[.]com". Since the new eTLD+1 does not have IDN, it will not trigger any further checks and the navigation will not be treated as a lookalike. Bug: 843361 Change-Id: Iaec1a0af61fa7aa9a2091bff3212171ba36034ad Reviewed-on: https://chromium-review.googlesource.com/c/1387670Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#618367}
-
Esmael El-Moslimany authored
Patchset 1 is the revert. Patchset 2 is the fix. Bug: 916888 Change-Id: I16e2fc111c8ca6e3477414f4ed893bd4da0e2087 Reviewed-on: https://chromium-review.googlesource.com/c/1387386Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#618366}
-
