- 20 Aug, 2019 40 commits
-
-
Ian Prest authored
The `CreateNextWord*Position` functions were not updating their iterator in certain edge cases, which caused an infinite loop. (Notably, the `CreatePreviousWord*Position` functions *are* updating their iterators in the same scenarios.) The new test included in this change would hang before the fix. The following is a detailed description of the error scenario: -- Start with a AXTextPosition (at index 0) at a high level in the tree. -- Call one of the `CreateNextWord*Position` functions. -- These functions start by getting a "leaf" text position, which drills down deeper in the tree. Specifically, they drill down into a node that includes placeholder text (which appears as part of their hypertext, but not in the hypertext of the outer node). -- The function then tries to advance to the next word, and finds a valid word stop. -- The end of this loop compares the new position against the original. -- operator==/CompareTo must adjust the positions to be relative to the same node, which it does using repeated calls to GetParentPosition(). -- GetParentPosition() determines that the text-offset in the deep node is not valid in the outer node, so it resets the index to zero. (This workaround was added in CL:1661548.) -- As a result, CompareTo determines that the two nodes are equal. -- Therefore, we loop in CreateNextWord*Position. -- Because the iterator was not updated, we loop infinitely. Bug: 994871 Change-Id: I6e5880bfa7073e2ca672d281fca223e90e5fe288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758590Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Ian Prest <iapres@microsoft.com> Cr-Commit-Position: refs/heads/master@{#688611}
-
John Lee authored
This CL moves the permission checks that used to exist in the ExtensionTabUtil::ScrubTabForExtension method into its own util method so that the level of scrubbing of data that needs to happen can be determined in the context from which it is requested. This will ultimately help in allowing WebUI to get non-scrubbed data. Bug: 994337 Change-Id: I6c7cd37b1cb0f64233759ccac7aa9b8097234482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755052 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#688610}
-
Xianzhu Wang authored
It returns the matrix with transform origin applied. Useful where we want to get whole matrix that this transform node will apply. Also fix a bug in CullRect::ApplyTransforms() where we missed the origin. Change-Id: If671470a5c9ea0e8a46e128692862bb0779d005f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757081Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#688609}
-
Manu Cornet authored
We were showing the nav widget in the right conditions, but we were not hiding it aggressively enough. Add tests to prevent future regressions. BUG=992336 Change-Id: I4d19473f514b8979c940daa008e16a43e3de9773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761492Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#688608}
-
Matt Menke authored
This CL adds NetworkIsolationKey as an argument to H2-support-checking methods in HttpServerProperties, and makes consumers pass in the correct key. Bug: 969890 Change-Id: I8ea06693a470eef3ca24ec8d269ce5ac131e312f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753807Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#688607}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5c6b118c..f624b9be Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0032e6229b83cf1202e7c5a5063e2ac6c3995e91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757862Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688606}
-
Vadym Doroshenko authored
Bug: 994291 Change-Id: I48fe790dbf6c686e83264b638b0b031eb801d626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762239Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#688605}
-
Khushal Sagar authored
Bug: 900706 Change-Id: Id3940f6d3321f22159a577e3634ea926f6870b04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755409 Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#688604}
-
Will Harris authored
Add three bots to CQ for any changes to sandbox/win: * win-asan * win10_chromium_x64_dbg_ng * win7-rel This is because any sandbox changes can be particularly sensitive to OS version/configuration. BUG=750886 Change-Id: I4ff315f65e220591a0835069342b51ab2549d183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762384Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#688603}
-
Xianzhu Wang authored
... with translations: origin and post_translation. This reduces the size of TransformNode by 108 bytes. Bug: 993937 Change-Id: I52b60dfba9a34b1062960cbd78a9bababd0e6a1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759891 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#688602}
-
Elly Fong-Jones authored
TBR=marinaciocea@chromium.org,robertma@chromium.org Bug: 995817 Change-Id: I854a366775f515744bc9422cf5e58c16a99fa25a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762350Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#688601}
-
Anne Lim authored
Bug: 992491 Change-Id: Icf791568a56e5dafb9f280021aad4a0742520fe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733726 Commit-Queue: Anne Lim <annelim@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#688600}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I0de7982a275451bcc781621c8fae884d9ddb66de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700942 Auto-Submit: Eric Foo <efoo@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#688599}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3fb589c1. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: iclelland@chromium.org: external/wpt/feature-policy NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Ib5b023b71030a64d76e1403dc27ce60a8f8d73ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762408Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688598}
-
Nicolas Ouellet-payeur authored
This is a reland of d9dbade3 Original change's description: > [Traffic Annotations] Run extractor.py on waterfall > > linux-annotator-rel and win-annotator-rel will now test traffic > annotations with extractor.py, as well as the clang tool. > > Also updates a traffic annotation in management_ui_handler.cc, since > extractor.py doesn't understand #ifdefs. As a workaround, this > CrOS-specific annotation is moved to a CrOS-only file. > > TESTED= > Ran traffic_annotation_auditor_tests.py locally, excluding the > --no-filtering configs. > > Bug: 966883 > Change-Id: I7848877f67635b50d8ce2a841019e49136a33b11 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692970 > Reviewed-by: Hector Carmona <hcarmona@chromium.org> > Reviewed-by: Ramin Halavati <rhalavati@chromium.org> > Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> > Cr-Commit-Position: refs/heads/master@{#675994} Bug: 966883 Change-Id: I5d3275315565b0592c86feedb564fa5cbf154e4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761146Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#688597}
-
Balazs Engedy authored
Update the description string shown for `File editing` on chrome://settings/contents. Bug: 992175 Change-Id: I88d6283d8b481989f2af8cd24e20fc560f1b9c23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760962Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Auto-Submit: Balazs Engedy <engedy@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#688596}
-
Sunny Sachanandani authored
Make RenderingContext::IsOriginTopLeft() the source of truth for flip-y state and update the associated pixel test to verify this. This fixes incorrect rendering of low latency canvas2d on Windows since CanvasResourceProviderSharedImage started being used. This resource provider doesn't support single buffering mode if overlays aren't being used which is what caused the flip-y state to be inconsistent. Also includes minor cleanup in CanvasResourceProvider to store important state in the base class instead of duplicating in many subclasses. Bug: 994866 Change-Id: Ia955bfa87380ecfb3772b017528434182cbd391a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759214 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#688595}
-
Erik Chen authored
It's unused. This CL is a refactor with no intended behavior change. Bug: 994926 Change-Id: Ied6ff61da33b3f69b1cd49ffb310fe4e0668c192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761261 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#688594}
-
Yasmin authored
Bug: 988461 Change-Id: I86be68ebf6ad07bf680f11c49864a4ccb056e19e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761276Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#688593}
-
Yann Dago authored
Screenshot (<1024px) : http://screen/ktdXzvCgc0c Screenshot (<512px) : http://screen/kPDKQRi0dyo Bug: 994545, 993915 Change-Id: Iecf2c2c7865e9d8aaf905fe43124193f03b2beda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757290 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#688592}
-
sczs authored
Bug: 993962 Change-Id: Iaa4ada2faf2384a4bdb142756bece266d80fddd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761297 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#688591}
-
James Forshaw authored
This CL updates the expiry milestone for the GPU AppContainer flag to M82. While this file is being modified remove the entry for the old renderer AppContainer flag which has already been removed from the codebase. Change-Id: I75ddee725bc86a1ed0a6063b77a9c2e4c56bf4eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758342Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#688590}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b88012e339bf..7a6df9bfe5fd Created with: gclient setdep -r src-internal@7a6df9bfe5fd The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I576796369c22bec219158b991358e2fa9f5e85a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762270Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688589}
-
Kevin Qin authored
Enable openxr input tests in webxr_vr_input_browser_test.cc by changing tests using IN_PROC_MULTI_CLASS_BROWSER_TEST_F2 to WEBXR_VR_ALL_RUNTIMES_BROWSER_TEST_F. Bug: 992575 Change-Id: I1799b3c332424530b16e1f865b0785aa51755639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744675 Commit-Queue: Zheng Qin <zheqi@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#688588}
-
Yi Gu authored
This test is still flaky. crrev.com/c/1760892 didn't disable it correctly. TBR=eirage@chromium.org Bug: 995285 Change-Id: I1459e5a753d9e2435393242a990c20741be77a91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761637Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#688587}
-
Justin Cohen authored
This is for test only. Bug: 993298 Change-Id: I1ad64dc60828040403be5bc0e8265d89c1ddf60c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757311 Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#688586}
-
Maks Orlovich authored
both for implementors and users. The previous version used out parameters combined with usual net style maybe-async methods, which were also cancelled if the backend was destroyed. This has caused multiple complexities: 1) Managing lifetime of the place where the out parameter is written to is messy for the client. 2) The cancellation requirement on the backend is a bit tricky since it needs to post asynchronously, so there are multiple ways of getting it wrong and either overruning the lifetime of target pointer or leaking a pointer that shouldn't leak, and I think I did pretty much all of them? 3) (This was pointed out by comments in CacheStorage code): if the callback to is bound to a weak pointer, then it was very easy for just-opened entries to leak if the destination became null. This was a problem before CL internally in SimpleCache, and despite having these helpful comments on some ops, CacheStorage had it wrong in others. GeneratedCodeCache (which I reviewed, *cough*, *cough*), had that leak. I think the HTTP and shader caches might have been the only places to get it exactly right... So instead, return / pass to callbacks a move-only EntryResult type which owns the entry until it's released from it. This type still has a net error code, so the pending pattern still largely follows, but there are no longer any out pointers, and if a callback is cancelled the entry gets closed. Bug: 586174 Change-Id: I9b747766dff0b3cad031a1e04658ea7ad96643b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735974Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Derek Schuff <dschuff@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#688585}
-
Clark DuVall authored
These were not being assigned to a var, so were immediately getting destroyed. I did the same thing for one of my crash keys so thought I would look around to see if anyone else made the same mistake. Bug: 824649 Change-Id: Ib253e01f4eedeae8412a80fb91650639b06c84e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761014 Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#688584}
-
Jimmy Gong authored
- This change disables non ipp/ipps protocols for autoconf printers, since selecting one for an autoconf printer could put the user in a broken state. - Since we will disable the make/model dropdown in the edit dialog for autoconf printers, we want to prevent users from selecting a protocol that would require users to select their own PPD make/model. Bug: 947183 Test: End to end manual, browsertest Change-Id: I0d46626113f98a128e05cc7b6d95678e6e9301cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747148 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#688583}
-
Natalie Chouinard authored
Just some spelling corrections. Change-Id: I5d3105901de21b444014f599dafad74d29ea4571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761475Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#688582}
-
Yue Zhang authored
https://crrev.com/c/1666270 uses recyclerView.removeViewAt to manually remove dropped view, but this will lead to crash on KitKat devices because this is not the most ideal method to manually remove child from recyclerView. This CL fixes this issue. Bug: 988400 Change-Id: I61f643dddf1870c7c9007b692ca85630ec2c79b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733423 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#688581}
-
Willie Koomson authored
This is a reland of 9e12e07d Original change's description: > Refactor dependency on memory_instrumentation.mojom out of process.mojom > > Deprecates use of memory_instrumentation.mojom.GlobalMemoryDump struct > in process.mojom and ArcProcessService. Uses new struct ArcMemoryDump > instead. > > manager for Android memory footprint > > Bug: b:139190852 > Test: Build cheet_x86 and flash betty-arcnext, check Chrome OS task > Change-Id: Ib21dfcf8ab7c23dfd60573341dfdddbcb744f166 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749456 > Commit-Queue: Willie Koomson <wvk@google.com> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#688212} Bug: b:139190852 Change-Id: I956b640fae3127e65c148ae40c474142ad685ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761292Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Willie Koomson <wvk@google.com> Cr-Commit-Position: refs/heads/master@{#688580}
-
chrome://policyAnqing Zhao authored
After buttons are changed as unscrollable, users can reload policy or export them to Json file without scrolling the page to the top. That's will be more convenient. Bug: 991296 Change-Id: Ic9a0b70cb888a1eb36f58c8ac2317ea96b781aab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761603Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Yann Dago <ydago@chromium.org> Commit-Queue: Anqing Zhao <anqing@google.com> Cr-Commit-Position: refs/heads/master@{#688579}
-
Ryan Powell authored
This CL creates the SystemMemoryPressureEvaluator for MacOS, as part of a refactoring of the MemoryPressureMonitor to use the Voter-Aggregator design described here: https://docs.google.com/document/d/1W3FPDyjIAKBcFGNYsHA3EKR1FHrJlbBaqT4_RUnxzq0/edit?ts=5d3f5714#heading=h.7nki9mck5t64 This Evaluator calculates memory pressure and emits notifications identically to the previous Monitor, but does so by casting its votes for memory pressure through a MemoryPressureVoter. Bug: 980965 Change-Id: I7a065bd2adb635520744870ed9bd680a5dcb4178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742510 Commit-Queue: Ryan Powell <ryanpow@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#688578}
-
Alex Moshchuk authored
This converts a few more files to expect the right result from NavigateToURL(), fixing behavior in several tests in the process. Most of these files had tests that would fail if we simply added EXPECT_TRUE to their use of NavigateToURL(). Some of the causes of that were: - Navigating to invalid/broken URLs (MHTMLGenerationTest.InvalidPath, TracingControllerTest.*) - Navigating to javascript URLs that actually ended up navigating the page (or some other frame) somewhere else. (BookmarkletTest.Redirect*, SessionHistoryTest.*) - Navigating to URLs that redirect to other URLs (VerifyCrossSiteRedirectURL, RedirectAndRespondWithNavigationPreload) - Navigating to URLs with a broken test server that was incapable of actually serving the right files. (NetworkServiceBrowserTest.SyncXHROnCrash) - Navigating to URLs that result in a crash (SecurityExploitBrowserTest.DidCommitInvalidURL) - Navigating to a webui URL that doesn't exist in content/ (WorkerNetworkIsolationKeyBrowserTest). Bonus points for then relying on cross-process behavior of error page isolation to accidentally satisfy the test's requirements. Bug: 425335 Change-Id: I471479b5811f89793f105dce429fa13f342e0df5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759900Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#688577}
-
Matt Menke authored
ServerInfoMaps now use NetworkIsolationKeys in addition to SchemeHostPorts as indices. These new indices are stored on disk. This CL also introduces a feature to enable respecting these indices when creating the keys. The on-disk format of the ServerInfoMap changes from: [{<server1>: {<values1>}},{<server2>: {<values2>}}] to [{<values1>},{<values2>}] And <values> dictionaries now contain both the server HostPortPairs, and the NetworkIsolationKeys. As a result of this change, ServerInfo data from old prefs files will be lost, though other entries will be retained. This CL does not add an API to actually set NetworkIsolationKey when using an HttpServerProperties object, that will come in another CL. Bug: 969890 Change-Id: I8b115f5e704358c3178052e225087de2ef5446a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745820Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#688576}
-
Evan Stade authored
touchable_icon_size is no longer necessary as the icon is sized at the MenuItemView level. touchable_icon_color is also removed. The foreground color for Chrome OS menus (in normal/light mode) is GG900, and DeriveDefaultIconColor (by design) computes a value very close to GG700 from that input. Thus, this is a slight behavioral change, but it removes one more instance of a hard-coded color, and prepares Chrome OS to support dark mode. Bug: 989353 Change-Id: I3a4cd11624b461c05e00bd3b8c82acbce3f75d9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759084Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#688575}
-
nancy authored
ArcAppsPrivateApiTest.OnInstalled creates a FakeAppInstance, but the instance is torn down without clearing the underlying connection. This causes test flakes where the App Service is still trying to resolve callbacks against the FakeAppInstance that is now destroyed at the end of the test. This CL fixes the test by creating the FakeAppInstance as a member variable on the test, and adding a TearDown step to properly clean up the connection. BUG=992839 Change-Id: I748fcc6c64d66392848ad0c49ec7916e7e8686b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757950 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#688574}
-
Takashi Toyoshima authored
"Purpose: prefetch" is not standardized, and is not considered in the CORS spec. To obey the CORS spec strictly, we need to perform a CORS preflight handshake, but this is undesirable. Until we standardize this header in the spec, we decided to use "cors_exempt_headers" mechanisms. Blink already uses it, but the PrerenderURLLoaderThrottle is overlooked. This won't break anything, but will reduce benefits of prerendering. This patch adopt the "cors_exempt_headers" fix even for the PrerenderURLLoaderThrrole case, and solve the potential performance issue. This is affecting some large sites as observing increased OPTIONS requests. Bug: 995733 Change-Id: I7efd365d48bf24e27e18847f2c26da15c6613a22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757415 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#688573}
-
Bettina authored
Bug: 914410 Change-Id: I9510cd8eda7d8b678b1579798670b9d01d82a755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761243 Commit-Queue: Nathan Parker <nparker@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#688572}
-