- 14 Nov, 2019 40 commits
-
-
Peter Kotwicz authored
This CL introduces a new UMA metric - WebApk.NewStyle.Startup.Cold.ShellLaunchToSplashscreenVisible which measures the time elapsed between Activity#onCreate() of the activity which handles the launch intent and the ShellAPK adding the splash screen to the view hierarchy. The purpose of the UMA metric is to be comparable to WebApk.Startup.Cold.ShellLaunchToSplashscreenVisible BUG=1000949 R=hartmanng,dominickn,rkaplow TBR=yfriedman (For code deletion in IntentHandler) Change-Id: I934297febaba5e6c8c8f5087c770542ede27f257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786720 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Cr-Commit-Position: refs/heads/master@{#715419}
-
manuk authored
Change-Id: I96e6877c3c1eee0161208b9f4d776dac2f82b4b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917330Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#715418}
-
Kevin Ellis authored
Previously, the pending pause and play flags were reset in Animation::Update. The flags should be reset when the animation is ready (received start notification or stopped a running animation). This change will affect when Animation::pending() changes state from true to false. The next step is to reset these flags inside of play and pause tasks per spec, which requires further cleanup of the use of PlayStateUpdateScope. The following patch introduced a subtle bug to the timing of notifications to devtools > Animations, whereby the devtools notification could fire a start notification before the start time was received. https://chromium-review.googlesource.com/c/chromium/src/+/1822321 Fixing the timing of the pending task resets forces the devtools notification to sync with the start of the animation, which in turn undoes the faulty perf improvement seen in 1822321. Bug: 960944 Change-Id: Icbcf546614570e1936bec3db94facb1b5bfc4e46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873905Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#715417}
-
Ben Pastene authored
And fix //third_party/android_sdk/OWNERS to prevent presubmit warnings when touching //infra/OWNERS. Change-Id: I4cfaed0f2dfa8b4b2f81e341e8492febe4f83995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916964Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#715416}
-
Tommy Steimel authored
LoginTest.GaiaAuthOffline is failing often on the linux-chromeos-google-rel bot. Example failure: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/9135 Disabling the test for now TBR=antrim@chromium.org Bug: 1023591 Change-Id: I1aced34639a552c0badea33f3787358d898c5b9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917879Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#715415}
-
Tommy Li authored
Previously, both ChromeOS launcher and NTP ZeroSuggest avoided calling MaybeCullTailSuggestions. This was because MaybeCullTailSuggestions did not handle the no-default-match case. This was fixed here: https://chromium-review.googlesource.com/c/chromium/src/+/1872485 So this carveout / special case is no longer needed, and in fact, no longer desirable. Going forward, we aim to support the no-default-match case as a first-class citizen in the autocomplete world, so we are working to eliminate all these special cases in the codebase. Bug: 1016845, 363656 Change-Id: Ic42bb0d6e114393b03df20cf218a6e328bd197dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913566 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#715414}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3f3aa545f7de..5bd6ca022650 git log 3f3aa545f7de..5bd6ca022650 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 brcui@microsoft.com Revert: DevTools: Fix NVDA screen reader Enter keypress hiding settings pane https://chromium-review.googlesource.com/c/chromium/src/+/1848114 Created with: gclient setdep -r src/third_party/devtools-frontend/src@5bd6ca022650 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC v8-waterfall-sheriff@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=v8-waterfall-sheriff@grotations.appspotmail.com Bug: chromium:1023755 Change-Id: If1d52c6ae732162ac1b727ae073f26599980c269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917799Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715413}
-
Regan Hsu authored
Currently, on tablets, if you tap on the "Set up PIN" button, the entire row is highlighted grey. The row should not be highlighted at all when the button is tapped because it is a bad experience for the user. This CL ensures when the user taps on the "Set up PIN" button, the row is not highlighted grey. Fixed: 1020087 Change-Id: Icba9e6db6b3e561fb124c2b9cb06ae43c982ae6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913483Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#715412}
-
Andrew Grieve authored
* trichrome_shared_assets GN arg * references to o_mr1 and p in config.gni Bug: 1003532 Change-Id: Ib3c9df5638ed8b336457b9dc9a450ffc9b578879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916681 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#715411}
-
Yun Liu authored
Bug: 1008894 Change-Id: Icbf5e6212a63cedd87f7c0a829824e415a21b0ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911701Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#715410}
-
Bailey Berro authored
This change removes the unnecessary navigation stop on the "Add Connection" cr-expand-button. Previously, this was read by ChromeVox as first stop: "Add connection", second stop: "Add network connection, [Expanded|Collapsed], Button". Now, only the second stop will be read. Bug: 1012565 Change-Id: I42ac19da1d3813cf17830c340c7ef883c2e7ab91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915089Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#715409}
-
Sean Gilhuly authored
TransformScreenToWidgetCoordinates() assumes that coordinates are given in absolute space, but they are sent by EventSender relative to the main frame. This caused a number of tests to fail when --disable-headless-mode was passed due to the offset caused by the window decorations and tool bar. Add this offset into the calculation. This doesn't work for OOPIF tests because the main frame is a WebRemoteFrame object without a corresponding RenderWidget, so the offset can't be retrieved in the same way. None of these tests are run out of headless mode, so this should be fine. Mark this expectation for now. Bug: 935970 Change-Id: I255cec584fc91176471861b45ab8ff37aade7b39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814838Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#715408}
-
David Bienvenu authored
This reverts commit e2f0841e. Reason for revert: <causes issues with Citrix and other remote desktops> Original change's description: > Enable NativeWinOcclusion by default. > > Bug: 813093 > Change-Id: I17a6e74172bc994723a0c23fa3e8dabfc30a4f45 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815546 > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#699119} TBR=sky@chromium.org,fdoray@chromium.org,davidbienvenu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 813093 Change-Id: I163b75d39ce4249cb77251a8de0a2c5eaa332d2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917679Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
-
Raphael Kubo da Costa authored
Both WakeLock and WakeLockSentinel inherit from ContextLifecycleObserver, but by design a WakeLock is always created before a WakeLockSentinel, and thus its ContextDestroyed() implementation is called before WakeLockSentinel's. This can result in the following call chain: 1. WakeLock::ContextDestroyed() 2. WakeLockManager::ClearWakeLocks() 3. WakeLockSentinel::DoRelease() if a WakeLockSentinel has an event handler, DoRelease() will try to dispatch an event after the context has been destroyed, as WakeLockSentinel::ContextDestroyed(), which calls RemoveAllEventListeners(), has not been called yet. We now check if we have a usable context before dispatching events. WakeLockSentinelTest.ContextDestruction() has been augmented and now tests the entire flow (i.e. starting with a WakeLock object) rather than just context destruction when a WakeLockSentinel is present. Bug: 1023477 Change-Id: I3211d60d624456b950a884771c3fba79a4f8fa8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917359 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#715406}
-
Ken MacKay authored
The resampler requests chunks of |request_size| from the constructor, not the ChunkSize(). Change-Id: Iba4b896c995a50094316d0db6c64174f3e83eebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917746Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#715405}
-
Bailey Berro authored
All networking sub-pages have an unnecessary navigation stop on the enabled-state of the feature. This is particularly bad on the wi-fi sub page because the enabled-state text and the toggle are separated by the add network button. Fixed: 1024597, 1007058 Change-Id: I12d6233090dc3c5ff1b37526be9bf67211f78886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914827 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
-
Mikel Astiz authored
No behavioral changes: various minor refactorings are introduced to improve code readability and simplify future patches. Bug: 978430 Change-Id: Iafca6dd38e3c918b35417cd1c65b17cc37ec03d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917361Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#715403}
-
yilkal authored
This CL attaches the WebTimeLimitEnforcer to AppTimeController. Bug: 1015661 Change-Id: Ic9bd0d3ed349a5300fa59fa873c94c45d24128f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914940 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#715402}
-
Sidney San Martín authored
Bug: 1024914 Change-Id: I3ff68438b028fe38ad7270d7f90772b595f4f46e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917603Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#715401}
-
Wei-Yin Chen (陳威尹) authored
We have assertions in @After, which is a bad idea in general. When a test fails, and the assertions in @After also fails, the error message in @After could be misleading that it's the main reason the test fails. Bug: 1023833, 983170 Change-Id: Iae6f3e194559dad7fb9ab4e3aa1ee7835e4b3223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916260 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#715400}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ccb4439237a9..5c144f39feb1 git log ccb4439237a9..5c144f39feb1 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 hjd@google.com Merge "Add lsb/msb UUID in trace proto" Created with: gclient setdep -r src/third_party/perfetto@5c144f39feb1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ibb00b8a0fcb7a6a26836f5d73c8dd5166c307b38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916968Reviewed-by:
-
Yue Li authored
Bug: b/144383302 Test: Manual Test Change-Id: I54dee29269111170716376762f94eef1a63e2a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915105Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#715398}
-
Luke Zielinski authored
Skipping the webdriver directory still caused timeouts. Instead, omit the `wdspec` test type. Bug: 1023835 Change-Id: Ied3971bf844f9ea9fb89f4f5c39cb2aeca01f904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917690 Commit-Queue: Luke Z <lpz@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Auto-Submit: Luke Z <lpz@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#715397}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5f43d8c3..8fccd236 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8f07f962651f88665acb00df42f354fc15822136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917081Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715396}
-
Morten Stenshorne authored
Introducing NGPhysicalFragment::IsCSSBox(), to distinguish between fragments generated from CSS boxes [1] and those generated by the layout engine to hold CSS box fragments. We have a lot of checks for fragments not being line boxes before working on the associated LayoutObject, but we need to do the same for column boxes. This CL only changes HasLayer(), to fix outline painting, but we could do the same for many of the other methods here. Column boxes don't establish layers, so return false. The layout object that a column box is associated with does establish a layer (for legacy reasons). The outline code [2] has special-code for layers, but shouldn't treat each column as establishing a layer. While we wait for NG column painting to be implemented, we now need to guard against entering columns when painting a box fragment, and instead let the paint layer established by the multicol container and the flow thread drive the painting (like before). [1] https://www.w3.org/TR/css-display-3/#box-tree [2] NGPhysicalContainerFragment::AddOutlineRectsForDescendant() Change-Id: I6fcd753cbed2e5f19560eddf45e903dd58bf4bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912713Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#715395}
-
Sven Zheng authored
This reverts commit 01bf58b0. Reason for revert: Disable again until we fix it. Original change's description: > Reenable CleanerSandboxInterface.DeleteService_HandleHeld for debugging > > We currently do not have sufficient tools to repro failure on bot without > enable the test. > > Bug: 956016 > Change-Id: I89a97d78310fbae96016909196e56cd33ead9230 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914295 > Reviewed-by: Joe Mason <joenotcharles@chromium.org> > Commit-Queue: Sven Zheng <svenzheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715017} TBR=joenotcharles@chromium.org,svenzheng@chromium.org Change-Id: Icadd13e899c5413bee0a059902a1a2af00c0cfd3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 956016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917541 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#715394}
-
John Lee authored
This CL also prevents a use case in which the slideOut animation begins while the tab strip is open but will not end until the tab strip is in a closed state. Fixed: 1024620 Change-Id: Id9c7c8dac533bcdff530b1073a0a086a25efde28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914836Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#715393}
-
Wei-Yin Chen (陳威尹) authored
TabSwitcherCoordinator#getSoftCleanupDelayForTesting wrongly returned the value of getCleanupDelayForTesting. Bug: 983170 Change-Id: I5747b7e9bd8feee743de9268cc090820f5ec4ec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916259Reviewed-by:
-
W. James MacLean authored
This test sometimes fails because it calls WaitForLoadStop() before the WebContents has even started to load ... making it return false since there is no previous navigation entry. This CL makes sure we don't call WaitForLoadStop until we know the guest has started to load. Bug: 1024672 Change-Id: Ia6babfa739adbc000093184bee71b445db4189ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917740Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#715391}
-
Sammie Quon authored
Old logic: windows that are not fully onscreen are not animated. Does not quite work when the window is partially offscreen and we fade in windows, in this case the partially offscreen windows should still animate. New logic: window that are partially offscreen will be clipped to their onscreen bounds and treated normally. Fully offscreen windows are never animated. Test: added test Bug: 1024665 Change-Id: I097364fa23e37872fdd3714dfb3c76229aeb68d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917292Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#715390}
-
Yue Zhang authored
TabListContainerViewBinderTest#testShowWithAnimation is failing on Android CFI bot. This CL disables this test on Nexus 5X to skip this bot. Bug: 954145, 1023530 Change-Id: I386ada2bee2959568e4b9dc09913ee6fa8c3db10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913171Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1dbf452d7ecb..f34a9d2df428 git log 1dbf452d7ecb..f34a9d2df428 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 khokhlov@google.com Add --results-label command line option to run_metric Created with: gclient setdep -r src/third_party/catapult@f34a9d2df428 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:945713 Change-Id: I75c136798a7ef98d41f08fb6d348d7deccdcbbe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917303Reviewed-by:
-
Mugdha Lakhani authored
to add a list of expected objects. Bug: 996664 Change-Id: I8b13a849a82687ae2d2c9f41856569391c02a35d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912206 Commit-Queue: Mike West <mkwst@chromium.org> Auto-Submit: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#715387}
-
Xianzhu Wang authored
Some that don't seem to be flaky are rebaselined if needed, and the [ Skip ] expectations are removed. For the rest that we don't know if they are flaky, the failure expectations are changed from [ Skip ] to the best guess of possible results. Should monitor these tests for some time and update the expectations and baselines according to the flakiness dashboard. Change-Id: Iaca86efb9d1490b7f6b07785a9ff4adb22aacec7 Bug: 680635, 377696, 769885, 591500, 722943, 922951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915461 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#715386}
-
Joshua Peraza authored
The upload list is capped at 50 crashes. Previously, the already completed uploads were listed before the pending uploads. This patch places the pending uploads first so that it is possible for the user to see them and manually* trigger an upload. *The "send now" button does not actually send the report now. It schedules the dump for upload at a later time of the Job Scheduler's choosing. Bug: 1023836 Change-Id: Ided52abc451f4ac167dc9eb0db93d4ea32bdc090 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917689Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#715385}
-
Joshua Peraza authored
0208c1a175e1 fuchsia: Don't capture incorrect/unreasonably large stacks 2291bfa32ef1 android, gyp: fix the build 74490f00a47b linux: roll lss and use sys_sigtimedwait/sys_sigprocmask Change-Id: I220c774c372f59303e62f1da5a1946549ce47cb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914901 Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
-
Matt Menke authored
Make the ProxyService API take a NetworkIsolationKey and pass it down to the ProxyResolver. Also make the main consumer actually pass in requests' NIK. Some other callsites still need to be updated to pass in NIKs. Also introduce new pattern of using NetworkIsolationKey::Todo() to create empty NetworkIsolationKeys() in places that should be modified to pass in populated NetworkIsolationKeys. Bug: 1021661 Change-Id: I4cd2a54fb68dea74cb9a3660b2b2d38f1a35f6f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908922 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#715383}
-
Peter Kotwicz authored
BUG=None TBR=dominickn Change-Id: Ibf4ea006bacaae543bc1d3641d6e850ae35ad582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917745Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#715382}
-
Reilly Grant authored
Bug: 1007782 Change-Id: I5bc515340e1836297565fa54f9b30124917126f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916963 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#715381}
-
Vasiliy Telezhnikov authored
This CL fixes GLRenderer::RestoreGLState to DisableVertexAttribArray that Skia might enabled and not used in GLRenderer. Bug: 1021361 Change-Id: Ic7fab80058ebdea902dadc64edce647ede16517a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917680Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#715380}
-
