- 03 Dec, 2018 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ec0f45be1144..ec086d842ce7 git log ec0f45be1144..ec086d842ce7 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 srte@webrtc.org Fixes race in SendSideCongestionControllerTest.OldFeedback. Created with: gclient setdep -r src/third_party/webrtc@ec086d842ce7 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2b9c9d8a3e9eb8b45e4b661eba92c960a2b9a680 Reviewed-on: https://chromium-review.googlesource.com/c/1359372Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613336}
-
Ken Rockot authored
Migrates most remaining usage of ServiceContext over to ServiceBinding and eliminates all remaining usage of EmbeddedServiceInfo outside of content. Bug: 891780 Change-Id: Id7a83918e58a1cecdcadd6c20ee624c1dcbd3729 Reviewed-on: https://chromium-review.googlesource.com/c/1357534Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#613335}
-
Nigel Tao authored
Lots of TODOs, but there's enough implemented so that running "chrome --enable-features=AppService" will populate the launcher with extension apps' names and icons, and clicking on the icon will launch the app. BUG=826982 Change-Id: Id424abac859dde69ffdac3c28a473fce61fbe8df Reviewed-on: https://chromium-review.googlesource.com/c/1351975 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#613334}
-
Joshua Peraza authored
This is a reland of 66b2e0f1 Original change's description: > Enable Crashpad for Android > > Overview: > This CL disables Breakpad for Chrome, Content Shell, WebView, and > Chromecast on Android and replaces it with Crashpad. When a crash > signal is received, the browser forks+execs a Crashpad handler process > either for itself or on behalf of a crashing child to create a crash > dump. > > components/crash/ > - Remove CrashDumpManager. Minidump creation is handled entirely by > Crashpad. > - Remove OnChildStart from ChildExitObserver as it is no longer > necessary. > - ChildExitObserver observers CrashHandlerHost to be notified when > child processes receive crash signals. > - De-duplicate calls to ChildExitObserver::Client::OnChildExit when > NOTIFICATION_RENDER_PROCESS_{CLOSED, TERMINATED} are both sent. > > components/minidump_uploader/ > - Uploaders expect crash reports to already be MIME encoded since > Breakpad was doing that in a signal handler call-back. > CrashFileManager now automatically calls into native code to do > the encoding and write to a directory of crash reports whenever it > checks for reports without logcats. > > chrome/app/*.{cc,h} > chrome/browser/*.cc > content/shell/app/*.{cc,h} > content/shell/browser/*.cc > - Initialize Crashpad instead of Breakpad, with minor cleanup and > adjustment for changes to CrashDumpObserver. > > chrome/browser/metrics/oom/out_of_memory_reporter_unittest.cc > - Simulate crashes/exits with NOTIFICATION_RENDER_PROCESS_{CREATED, > CLOSED} and signals sent to ChildExitObserver instead of a crash > dump. > > android_webview/ > - AwBrowserTerminator now observes child process crashes via > ChildExitObserver rather than its own pipe. > - Crashpad always produces minidumps, and not microdumps. > - Disabling Crashpad is not yet supported. > > chromecast/ > - There are now two directories that crash report uploaders should > be aware of: "Crashpad" contains a database of raw minidumps > produced by Crashpad, and "Crash Reports" contains MIME encoded > minidumps. MIME encoding is performed by a CrashReportMimeWriter > in CastCrashUploader.java:checkForCrashDumps(). > > Bug: crashpad:30 > Cq-Include-Trybots: master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg > Change-Id: I0efa451585f60287853c47f860f09ced581c8958 > Reviewed-on: https://chromium-review.googlesource.com/c/989401 > Commit-Queue: Joshua Peraza <jperaza@chromium.org> > Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Peter Wen <wnwen@chromium.org> > Reviewed-by: Luke Halliwell <halliwell@chromium.org> > Reviewed-by: Simeon Anfinrud <sanfin@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612987} TBR=tobiasjs@chromium.org,jam@chromium.org,wnwen@chromium.org,halliwell@chromium.org,sanfin@chromium.org,yfriedman@chromium.org,peter@chromium.org,isherman@chromium.org Bug: crashpad:30 Change-Id: Ia1654bc4fbe59005513f30364753309ae232052d Cq-Include-Trybots: master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg Reviewed-on: https://chromium-review.googlesource.com/c/1357941 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#613333}
-
Dan Beam authored
This makes test code easier to write and understand and is also what the "prod" WebUI class already does. This is loosely related to Dark Mode support, as I discovered this difference in behavior while working on unit tests for this work. WIP Dark Mode CL: https://crrev.com/c/1354685 R=jam@chromium.org BUG=883049 Change-Id: I6862e2cd0244bdb02bd6dd92870bc2ec70d2099a Reviewed-on: https://chromium-review.googlesource.com/c/1359132Reviewed-by:
-
Dominic Mazzoni authored
Bug: 862710 Change-Id: I84432cae10fb11134023dd68da86995855fa809f Reviewed-on: https://chromium-review.googlesource.com/c/1351088Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#613331}
-
Eugene But authored
NavigationItemCommitted is deprecated in favour of DidFinishNavigation. This change will simplify transition from NavigationItemCommitted to DidFinishNavigation, because DidFinishNavigation does not pass NavigationItem as argument. Bug: 720786 Change-Id: I758d7220c2d600bc663d8c55eeb49b5c54e619ff Reviewed-on: https://chromium-review.googlesource.com/c/1356770 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#613330}
-
Doug Arnett authored
The EffectiveConnectionTypeThresholdForClientLoFi() is no longer used except for tests (replaced by GetECTThresholdForPreview(PreviewsType::LOFI)), Change-Id: I925c21ecd5589d6a74f232359dd24f2e84b16ed3 Reviewed-on: https://chromium-review.googlesource.com/c/1359460Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#613329}
-
dpapad authored
Conversions performed with a tool (lebab). In a few occasions had to manually convert, where the tool could not determine if the conversion was safe. This is in preparation of turning on no-var, and prefer-const ESLint checks for all of chrome/browser/resources/ Bug: 792774 Change-Id: I0d5fa98d5efb935e84c1990db635f96df5957e4d Reviewed-on: https://chromium-review.googlesource.com/c/1357726Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#613328}
-
Kurt Horimoto authored
This will allow AlertCoordinators to access FullscreenController, which will provide the necessary insets to use for non-modal alert presentation. This CL also removes the unnecessary empty initializers, as this is handled by the NS_UNAVAILABLE annotation now. Bug: 674649 Change-Id: I0d1b5efbcf0266103090e879b078cef64df42593 Reviewed-on: https://chromium-review.googlesource.com/c/1340602 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#613327}
-
Krishna Govind authored
R=cmasso@chromium.org Change-Id: Ie2331c427c40d394319e94e62e649a0d21fd0f58 Reviewed-on: https://chromium-review.googlesource.com/c/1359484Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#613326}
-
Lei Zhang authored
The class and file referenced do not exist anymore. Change-Id: I80f0b67c94b6f7a5d3ad5498f885464cf2c0c4e9 Reviewed-on: https://chromium-review.googlesource.com/c/1359316Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#613325}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1fbed8388ab1..8b8b9a06ee3d Created with: gclient setdep -r src-internal@8b8b9a06ee3d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:856278 TBR=mmoss@chromium.org Change-Id: Ib2d9012753c7ddca3d7aab6ece572a2288686385 Reviewed-on: https://chromium-review.googlesource.com/c/1358765Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613324}
-
iOS Autoroller authored
TBR=smut Change-Id: Iac742b113fdcd8e50516d808c2039e19eceb5d95 Reviewed-on: https://chromium-review.googlesource.com/c/1358640Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#613323}
-
Jay Harris authored
Bug: 853593 Change-Id: I4618ca91c53a18ed7a56cb8dce0416d25318ab41 Reviewed-on: https://chromium-review.googlesource.com/c/1328084 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#613322}
-
Jacob Dufault authored
- Simplify helper code used with ScreenLockerTest.TestFullscreenExit - Simplify BrailleDisplayPrivateAPIUnitTest.KeyEventOnLockScreen, remove MSAN restriction since views-lock screen is significantly faster to load Bug: 899777 Change-Id: I0cf3c50c562289c42513b8509a86f901caf93035 Reviewed-on: https://chromium-review.googlesource.com/c/1327543 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#613321}
-
Min Chen authored
Open the application select menu of chrome shortcut will trigger the window stacking change. It will update the shelf visibility before showing the menu. Call UpdateVisibilityState after the menu is shown to keep the auto-hide shelf shown. Bug: 908681 Change-Id: I1e4dca91a03ca85df5ddb1511bd2b4f3fe6c8d63 Reviewed-on: https://chromium-review.googlesource.com/c/1356595 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#613320}
-
Kenneth Russell authored
The GPU tests act much like integration tests for the entire browser, and tend to uncover flakiness bugs more readily than other test suites. In order to surface any flakiness more readily to the developer of the CL which is introducing it, we disable retries with patch on the commit queue. Bug: 906166 Change-Id: Iee56100a774377b9172325627da4694ce0a15009 Reviewed-on: https://chromium-review.googlesource.com/c/1357569Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#613319}
-
rajendrant authored
Bug: 911001 Change-Id: I72b6f8955be6c736f5c0063e76c3695bbde07e28 Reviewed-on: https://chromium-review.googlesource.com/c/1359128Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#613318}
-
Nicolas Ouellet-payeur authored
Fixes the alignment of the "Managed by your organization" footnote in the App Menu, to respect the spec from UX. Specifically: - Footnote no longer spills over the menu's bottom border - Add some top & bottom margin to make the footnote larger - Fix capitalization on Mac OS ('Organization' => 'organization') - Fix rounded corners not appearing on Mac OS Bug: 893626 Change-Id: Iccaa6e702bc4ccdc756b34f362874059a4347a18 Reviewed-on: https://chromium-review.googlesource.com/c/1355888 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#613317}
-
Akihiro Ota authored
Improve upon previous implementation of GetPosInSet and GetSetSize for AXNode, which computed pos_in_set and set_size values upon every call of either function. Introduced cache for these values in AXTree, which maps a node's id to a struct holding its pos_in_set and set_size values. Cache is invalidated upon updates to the AXTree. Change-Id: I70c0878b05b53b98648af1f2b76d1e1bf6e6d294 Reviewed-on: https://chromium-review.googlesource.com/c/1351782Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#613316}
-
Ned Nguyen authored
** NOTE TO PERF SHERIFF **: this CL might cause false regressions on "Win 7 Nvidia GPU Perf" & "Win 7 Perf" that are safe to ignore Commandline: $ ./tools/perf/generate_perf_sharding update --builders="Win 7 Nvidia GPU Perf" -r $ ./tools/perf/generate_perf_sharding update --builders="Win 7 Perf" -r Bug:906654 Change-Id: I420051f0629a8b8c79ac2e4da6cc736e911b02bb NOTRY=true # ios-simulator flake Change-Id: I420051f0629a8b8c79ac2e4da6cc736e911b02bb Reviewed-on: https://chromium-review.googlesource.com/c/1358911 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#613315}
-
Alexander Alekseev authored
This CL replaces CHECK with DCHECK to prevent fatal failures in the wild. TBR=asvitkine@chromium.org Bug: 910833 Change-Id: I070339cb47506b2b6823b9d3f8e4a7b06fc310ff Reviewed-on: https://chromium-review.googlesource.com/c/1357919Reviewed-by:
-
Kurt Horimoto authored
This callback can be used to notify FullscreenControllerObservers of changes to the viewport inset range. It can be used to trigger a viewport adjustment for new toolbar heights. Bug: 674649 Change-Id: I4ecdc374c1017716518118a27d4b9c5e0f1db48f Reviewed-on: https://chromium-review.googlesource.com/c/1340953 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/0c172a6b74fc..d835d664bd3b git log 0c172a6b74fc..d835d664bd3b --date=short --no-merges --format='%ad %ae %s' 2018-12-03 dj2@everburning.com [val] Fixup id name output (#2158) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@d835d664bd3b The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I852dbbda7a2562d71be516546c95e8051e9a46ab Reviewed-on: https://chromium-review.googlesource.com/c/1358767Reviewed-by:
-
Kelvin Jiang authored
Occasionally, 2 activity log entries with the same api call exist in the database. When presented to the UI, this can confuse some users. This CL groups activities by their api call and sorts them based on the total number of calls. This achieves feature parity with the Chrome Apps and Extensions Developer Tool. Bug: 832354 Change-Id: I566a3620b6a5fd3b35825e49d3db5fb9fbb7f416 Reviewed-on: https://chromium-review.googlesource.com/c/1350924 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
Erik Luo authored
- Avoid showing scrollbar when creating new watch - Fix object watch alignment - Replace "minus" icon with "cross" Screenshot: https://imgur.com/a/pdrKIey Bug: 910683 Change-Id: I554f08295a4c92c954167f5e09f55f104d285bfb Reviewed-on: https://chromium-review.googlesource.com/c/1357602Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#613310}
-
Etienne Pierre-Doray authored
This CL splits ScheduleAdjustMaxTasksIfNeeded() into: - ShouldScheduleAdjustMaxTasksLockRequired() - ScheduleAdjustMaxTasks() To reuse taken lock and avoid reacquiring the same locks multiple times. Change-Id: I55e2f8fa1063e2cb5537ca14a96cb118b388047d Reviewed-on: https://chromium-review.googlesource.com/c/1357304 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#613309}
-
James Cook authored
AXTreeSourceAura doesn't exist any more. The tests exercise the integration of AXRootObjWrapper with AXTreeSourceViews, so rename the tests ot AXTreeSourceViewsRootTest. Note that the tests lived in //chrome/browser/ui/ash. If we need an ash-specific tree source we could introduce an AXTreeSourceAsh either in //ash (for mash) or //chrome/browser/ui/ash (for SingleProcessMash). Bug: 910672 Test: views_unittests Change-Id: I79438345e3ad9bd1aa69d74b3c34cc35efe87142 Reviewed-on: https://chromium-review.googlesource.com/c/1358972Reviewed-by:
-
Lei Zhang authored
Change-Id: Ia5f0d37480f95d9412f3d4f4534e227c9dae3733 Reviewed-on: https://chromium-review.googlesource.com/c/1357765Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#613307}
-
Charles Zhao authored
The 10% stable experiment has shown 10% improvement. Bug: 862413 Change-Id: I9c2422f8c19e0fb997160f49d822882b96f18aff Reviewed-on: https://chromium-review.googlesource.com/c/1351337Reviewed-by:
-
Yao Xiao authored
To get a sense of which sites are having sandboxed download, so we might be able to provide evidence that the blocking is worthwhile. Bug: 539938 Change-Id: I672077892064b0f156a78aac1ff5be044f6c3ef8 Reviewed-on: https://chromium-review.googlesource.com/c/1356890Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#613305}
-
Justin Donnelly authored
This feature has been approved for launch. Bug: 824893 Change-Id: I41dcae918a9649e2313dc592dfbe702f66123a03 Reviewed-on: https://chromium-review.googlesource.com/c/1359062 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#613304}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/eec53b64a610..89808a631e39 git log eec53b64a610..89808a631e39 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 achuith@chromium.org tast_test_stages: Launch VM outside cros_sdk shell 2018-12-03 zentaro@chromium.org cros image test: Update tss group baseline for oobe_config Created with: gclient setdep -r src/third_party/chromite@89808a631e39 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I56fc84a29929d20e721fd1c1355173021c3a429a Reviewed-on: https://chromium-review.googlesource.com/c/1358766Reviewed-by:
-
Saman Sami authored
This parameter is currently ignored. It was added with the intention of importing a SharedImage multiple times with different internal formats for RGB emulation, however an alternative solution that does not require this parameter is creating two different SharedImages wrapping the same GpuMemoryBuffer, with one SharedImage having a special usage flag that indicates RGB emulation. See http://crrev.com/c/1348974 Bug: 882591 Change-Id: Ia48d3dd78321f1c3f20816e5c1856ef23c56cda1 Reviewed-on: https://chromium-review.googlesource.com/c/1359058Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#613302}
-
Giovanni Ortuño Urquidi authored
This make it easier to write tests while still maintaining the flexibility of the fakes. Also gives more descriptive names to the adapter objects paths. This makes the adapter object paths easier to distinguish from future device, service, characteristic, and descriptor object paths. Bug: 870192 Change-Id: I716809e757ab2ddf4a261fa2105e2224ec982ee1 Reviewed-on: https://chromium-review.googlesource.com/c/1358117Reviewed-by:
Ovidio Henriquez <odejesush@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#613301}
-
Oleh Prypin authored
This is a reland of e14ed878 With correct output path to v4l2/v4l2_stubs.{h,cc} Original change's description: > Make a GN template for generate_stubs.py > > Make it produce a source_set which can be depended on rather than directly including sources into the parent target. > > Bug: chromium:682122 > Change-Id: I7ad9f94459f187481e656e3513eabb3e2a6f92a1 > Reviewed-on: https://chromium-review.googlesource.com/c/1348042 > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Oleh Prypin <oprypin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611117} Bug: chromium:682122, chromium:909020 Change-Id: I1d34d5bb0dc9f4f72a444e9463669793c3f5a171 Reviewed-on: https://chromium-review.googlesource.com/c/1356703Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Oleh Prypin <oprypin@chromium.org> Cr-Commit-Position: refs/heads/master@{#613300}
-
Robert Flack authored
This reverts commit 902bd031. Reason for revert: The DCHECK is regularly failing on telemetry_perf_unittests, sample https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/73315: [9072:11232:1203/091954.734:FATAL:latency_tracker.cc(468)] Check failed: !pending_finished_lag_report_. Backtrace: base::debug::StackTrace::StackTrace [0x6F0548A6+102] base::debug::StackTrace::StackTrace [0x6F05387B+27] logging::LogMessage::~LogMessage [0x6F0A4A07+151] ui::LatencyTracker::CalculateAverageLag [0x5FB5FDD1+3281] ui::LatencyTracker::ComputeEndToEndLatencyHistograms [0x5FB5CC83+8595] ui::LatencyTracker::OnGpuSwapBuffersCompleted [0x5FB5AAAE+494] ui::LatencyTracker::OnGpuSwapBuffersCompleted [0x5FB5A6E4+260] viz::SoftwareOutputSurface::SwapBuffersCallback [0x5F92B4B0+64] base::internal::FunctorTraits<void (__thiscall viz::SoftwareOutputSurface::*)(bool),void>::Invoke<void (__thiscall viz::SoftwareOutputSurface::*)(bool),base::WeakPtr<viz::SoftwareOutputSurface>,bool> [0x5F92BB7C+76] base::internal::InvokeHelper<1,void>::MakeItSo<void (__thiscall viz::SoftwareOutputSurface::*)(bool),base::WeakPtr<viz::SoftwareOutputSurface>,bool> [0x5F92BA62+130] base::internal::Invoker<base::internal::BindState<void (__thiscall viz::SoftwareOutputSurface::*)(bool),base::WeakPtr<viz::SoftwareOutputSurface>,bool>,void __cdecl(void)>::RunImpl<void (__thiscall viz::SoftwareOutputSurface::*)(bool),std::tuple<base::Wea [0x5F92B98F+111] base::internal::Invoker<base::internal::BindState<void (__thiscall viz::SoftwareOutputSurface::*)(bool),base::WeakPtr<viz::SoftwareOutputSurface>,bool>,void __cdecl(void)>::RunOnce [0x5F92B804+84] base::OnceCallback<void __cdecl(void)>::Run [0x6F008900+80] base::debug::TaskAnnotator::RunTask [0x6F0566EB+859] base::MessageLoopImpl::RunTask [0x6F0D0656+886] base::MessageLoopImpl::DeferOrRunPendingTask [0x6F0D0B79+73] base::MessageLoopImpl::DoWork [0x6F0D15F0+400] base::MessagePumpForUI::DoRunLoop [0x6F0DA8BE+62] base::MessagePumpWin::Run [0x6F0D9837+119] base::MessageLoopImpl::Run [0x6F0CFF63+483] base::RunLoop::Run [0x6F189298+488] base::Thread::Run [0x6F2A0367+375] base::Thread::ThreadMain [0x6F2A0B58+1272] base::PlatformThread::GetDefaultThreadStackSize [0x6F292C86+406] BaseThreadInitThunk [0x74C8338A+18] RtlInitializeExceptionChain [0x770C9902+99] RtlInitializeExceptionChain [0x770C98D5+54] Original change's description: > Add Latency.AverageLag metric > > This CL adds a float value scroll_update_delta_ for GSU deltaY and > a time component for last coalesced event to latency_info. > And also adds implementation for Event.Latency.Scroll.AverageLag > metrics, which measures an average distance represents the lag > between finger movement and page scroll. > > detail of the metric see the design doc: > https://docs.google.com/document/d/154jddNiKtxELBvrjLz9v6A7sA1J3iwQQzySHgtY12Oo/edit?pli=1#heading=h.zf3l6o8vecuv > > Change-Id: I64adef4ebf107185ad4fd1eeec276ea527e1c5ef > Reviewed-on: https://chromium-review.googlesource.com/c/1239260 > Commit-Queue: Ella Ge <eirage@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611206} TBR=kenrb@chromium.org,rkaplow@chromium.org,tdresser@chromium.org,nzolghadr@chromium.org,eirage@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I08d00db01093c787afff59d6ed9714b9bf7ab746 Reviewed-on: https://chromium-review.googlesource.com/c/1359299Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#613299}
-
Jonathan Backer authored
This makes sure that when a RasterDecoderContextState context is lost that we follow the same logic for GLES2 decoder context loss. Change-Id: Ia46c54311cf8ae696b4b464cfb33b365601843f9 Reviewed-on: https://chromium-review.googlesource.com/c/1355338Reviewed-by:
-
Andrey Lushnikov authored
The --disk-cache-dir flag allows to use custom disk cache folder instead of using the one inferred from user data directory. BUG=882431 R=caseq Change-Id: I2da7e1c4b72eda32bccf6851c66ce44c1aaa837d Reviewed-on: https://chromium-review.googlesource.com/c/1359038Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#613297}
-
