- 30 May, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fc230bf93695..9a7ea23c1933 Created with: gclient setdep -r src-internal@9a7ea23c1933 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ricea@google.com,jeffreycohen@google.com,seblalancette@google.com,mkwst@google.com Change-Id: I3a4cd7db8d6e9864828166873d4f8c480fd1c9f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636616Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664638}
-
Yuwei Huang authored
There is a bug in heartbeat sender's backoff logic such that the backoff is not capped to a maximum retry interval. This CL: * Fixes the bug by switching to use BackoffEntry * Adds unittests * Adds LOG to help future debugging Change-Id: Idd737d2c8edfec326adf394eef5ee6857d757287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636829 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#664637}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: Idc698f32b8e234b20b8d14118a1ac45ff4ddefaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637029Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#664636}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2a2bfdfe. With Chromium commits locally applied on WPT: e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" abf2ac5e "webrtc wpt: avoid race conditions" d9a6ec05 "[MediaStreamTrack] Remove tests and existing support for the 'volume' property." 0882bebe "Change ICE connection state on transceiver changes" 1bbbd106 "Add feature policy for client hints, used for third-party subresources." 2229f484 "Revert "Change ICE connection state on transceiver changes"" ab94a58b "Add the remaining Client Hints to Feature Policy." fa044597 "Fix issue with inline WebXR sessions returning null viewports" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I6e16dcb0f809b01ee3d99b1146199c803a2d4ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636832Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664635}
-
Ben Kelly authored
Move the LegacyCacheStorageManager created in crrev.com/c/1626503 into a separate set of files in the legacy sub-directory. Note, many of the changes in this CL are simply to add includes that external clients used to get from cache_storage_manager.h. Bug: 940449,960012 Change-Id: I6ed9c492546f6b44609b0aed4f13fa4bd7ca66d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632000 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#664634}
-
John Abd-El-Malek authored
Ensure that SharedWorkerServiceImplTest tests don't make network requests when the network service is enabled. When Network Service (PlzWorker) is enabled WorkerScriptFetchInitiator::CreateScriptLoaderOnIO makes a network request before running the callback that the tests wait for. Pass in a testing URLLoaderFactory that gives bogus data to avoid network requests. Bug: 966633 Change-Id: I373791ba659b9056560fe7d151259607cc0336c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636253 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#664633}
-
Gabriel Marin authored
This is a reland of fa4a217a Original change's description: > Make the new tcmalloc the default for Chrome OS > > The new tcmalloc has been enabled on three Chrome OS boards since R72, > and on ten additional boards accounting for over 50% of users in the > wild since R75. It has also been the default on Linux for over one month. > > BUG=chromium:724399,b:70905156 > > Change-Id: Id1f49f66a963c9a327edeee3e85d0d128c9de78c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630233 > Commit-Queue: Gabriel Marin <gmx@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#664303} Bug: chromium:724399, b:70905156 Change-Id: I3f377fc3094c7231b4282ccdd3d56cb4dd3d463c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636615Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#664632}
-
Jia authored
Bug: 881215 Change-Id: Ie467687d488068b5bab5b3551ccad07c8f81ea9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631913Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#664631}
-
Eugene But authored
This reverts commit f7f90b37. Reason for revert: crbug.com/968296 Original change's description: > Compile some ios_chrome_web_egtest files with EG2. > > This CL makes changes to the files, so they either compiled without (or > with fewer) errors with EG2. Updated EG1 build target with proper EG1 > defined. > > This CL does not add files to EG2 target, because tests are failing > because of EG2 helper absence. > > Bug: 922813 > Change-Id: I0fbb023d5861405a7324521c0f34f114ec29868e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632591 > Commit-Queue: Eugene But <eugenebut@chromium.org> > Auto-Submit: Eugene But <eugenebut@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#663853} TBR=rohitrao@chromium.org,eugenebut@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 922813 Change-Id: I11bf5065050ce2eb6837001be0ba89472ed1e428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636922Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#664630}
-
Wei-Yin Chen (陳威尹) authored
Add a bare-bone implementation of the Grid-to-Tab expanding animation. This is only used for the Grid Tab Switcher, and is behind a flag, "TabToGTSAnimation". Further optimization is needed. Bug: 964406 Change-Id: Ie07275ac0ef622d52fd0bdf91fd389f3397f3b6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629046 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#664629}
-
Ehsan Karamad authored
This CL ensure that a frame-based MimeHandlerView does not load inside a sandboxed frame.; to this end, the following changes are made to the loading mechanism for MimeHandlerView: 1- Blink embedder is not asked for a MimeHandlerView if the document is sandboxed. 2- For frame navigation to MimeHandlerView MIME type where the HTML page is injected by the browser, MimeHandlerViewEmbedder will clear itself at commit time, if the embedder frame turns out to be sandboxed. 3- MimeHandlerViewContainerManager will load an empty page. Bug: 963641 Change-Id: Ib68be60042556a39e38d92f954201d0297631890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614282 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#664628}
-
Alan Cutter authored
This CL hides the omnibox PWA install icon for installable sites if the related_applications field lists a Chrome app that's already installed. Example manifest field: related_applications: [{ "platform": "chrome_web_store", "id": "<extension id>" }] Bug: 949430 Change-Id: Ic0a5a7992811b008a1cceb382255ca1ecad35fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630078 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#664627}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/74bebc597e25..a913c12462c7 git log 74bebc597e25..a913c12462c7 --date=short --no-merges --format='%ad %ae %s' 2019-05-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2d1120f0..81e50638 (664417:664522) Created with: gclient setdep -r src/third_party/webrtc@a913c12462c7 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I4c3a09322a8a2bf223060e66722d02fc3206e5eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636894Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664626}
-
Rafael Cintron authored
GLImageDXGI::ReleaseTexImage was querying the D3D device from ANGLE, turning it into a D3D11Device1 and then doing nothing with either pointer. This change removes the unnecessary code from ReleaseTexImage. Bug: 776010 Change-Id: I561acb741134194df4cc76852449411830c7bc1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636552 Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#664625}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/eca7315109de..56543311ae75 git log eca7315109de..56543311ae75 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@56543311ae75 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Change-Id: I58d631dfc836426e3d4dc4f79bafb4ac48f12eef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636893Reviewed-by:
-
Kenichi Ishibashi authored
Bug: 951571, 963626 Change-Id: I6d625c4a728d5cad402fc70c0878e5e46ee2dc71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636655Reviewed-by:
-
Moe Ahmadi authored
Fixes a bug where the leading language labels were being cut off because the cells were not adapting their heights in edit mode. Bug: 957688,967658 Change-Id: I6f8abab90b77565c71dcedc9cc4648a433ec324c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635933Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#664622}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a694bab26bc0..fc230bf93695 Created with: gclient setdep -r src-internal@fc230bf93695 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ricea@google.com,jeffreycohen@google.com,seblalancette@google.com,mkwst@google.com Change-Id: Ib18b5a69875dc15774625b514c88f73f4addbbb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636891Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/761ce8af8341..37bc82ac64f5 git log 761ce8af8341..37bc82ac64f5 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 chrisforbes@google.com Enable arm32 build for pastel 2019-05-29 chrisforbes@google.com Various additional fixes for Android build Created with: gclient setdep -r src/third_party/swiftshader@37bc82ac64f5 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/129979580,chromium:b/129979580 TBR=swiftshader-team+autoroll@google.com Change-Id: Id33c66a1f84628cd21d95f7d32aeb35a6fc8821c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636892Reviewed-by:
-
Lukasz Anforowicz authored
We should keep the NetworkService.URLLoader.RequestInitiatorOriginLockCompatibility histogram until we are ready to start terminating renderers which submit a request_initiator that is incompatible with request_initiator_site_lock. Bug: 967471 Change-Id: I7a6df884257aaeea15bf39cced24e8393e27e07a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632556Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#664619}
-
Takashi Sakamoto authored
This reverts commit 514383cf. Reason for revert: suspect causing chrome_all_tast_tests and cros_vm_sanity_test failure on chrome-os-kevin-rel: https://ci.chromium.org/p/chromium/builders/ci/chromeos-kevin-rel/9026 E.g. 019/05/29 22:45:19 debugd.Printer [ FAIL ] Failed to start Chrome: OOBE target not found: context deadline exceeded; last error follows: no chrome://oobe target ... Original change's description: > Make ChromeDriver/DevTools APIs return sink structs > > Make the get_sinks API return sink structs instead of sink name strings. > > Bug: 963963 > Change-Id: Idb6b555544f29aaa308b8d289335073348c653f5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615982 > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: Takumi Fujimoto <takumif@chromium.org> > Cr-Commit-Position: refs/heads/master@{#664485} TBR=dgozman@chromium.org,caseq@chromium.org,johnchen@chromium.org,takumif@chromium.org Change-Id: I9276a8043c250e72f4e2e0bf612cad6a2a892ce2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 963963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636667Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#664618}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I17a9b52e3094886726e856658e73cca6fe44f565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636912Reviewed-by:
-
Alexander Hendrich authored
This CL adds an api test for the new chrome.loginScreenUi API. It checks availability (only available to whitelisted extension on unknown, trunk and dev browser channel). It also checks that the API can only be called from the login/lock screen, that windows are automatically closed when login in or unlocking and that appropiate error messages are emitted when opening two windows or closing non-existent windows. Bug: 957573 Change-Id: I95c72e2462da0b316f87bcbf3d8ed601e33cc4e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598824 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#664616}
-
Wei-Yin Chen (陳威尹) authored
This is a reland of 2bc512d7 Original change's description: > Support downsampling in ViewResourceAdapter > > Bug: 965609 > Change-Id: I148d5fe8b7371a529b612ed2e9b407ced0062f82 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623139 > Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#662915} Bug: 965609, 966859 TBR=dtrainor@chromium.org Change-Id: I3da718de48413f22060f7504c78932d941929308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635431Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#664615}
-
Rafael Cintron authored
SwapChainFactoryDXGI::MakeBacking calls BindTexImage on the GLImageDXGISwapChain before binding the GL texture as GL_TEXTURE_2D. This causes eglBindTexImage validation to run on whatever texture happens to be bound as GL_TEXTURE_2D, causing random failures. To fix this problem, MakeTextureAndSetParameters was moved before the call to BindTexImage. Now eglBindTexImage validation runs on the correct texture. Change-Id: I3ad60c45c4acfb1b2a2fc8e5d15964accbdf8027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636612Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/c7b49740a0c4..27bffdf23dd3 git log c7b49740a0c4..27bffdf23dd3 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 zoddicus@users.noreply.github.com Roll spirv-tools dependency (#634) Created with: gclient setdep -r src/third_party/shaderc/src@27bffdf23dd3 The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Change-Id: I9da114d47f3a352671ac8212bacd188375774cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636890Reviewed-by:
-
Andrew Luo authored
This is a reland of 621bb15a Original change's description: > Switch webview bots to google devices. > > Bug: 814405 > Change-Id: I217f731c39f9ad0576ce98236c7c7dc78cf71dd4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592874 > Commit-Queue: Andrew Luo <aluo@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#663371} Bug: 814405 Change-Id: I94d5ea313108a0105a8658daae4f20c320beba9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632901Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#664612}
-
Nigel Tao authored
Change-Id: I1e5136fcea84af9d3251cd0c5b0c0f47fff975df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634589Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#664611}
-
Takuto Ikuta authored
This reverts commit 622d8879. Reason for revert: infra failure https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/WebKit%20Linux%20MSAN Original change's description: > Drop Trusty from WebKit Linux builders > > I applied following command to renmae > $ git grep --name-only 'WebKit Linux Trusty ' testing/ infra/ | \ > xargs sed -i 's/WebKit Linux Trusty /WebKit Linux /g' > > This is step 3 written in > https://chrome-internal-review.googlesource.com/c/infradata/config/+/1341927 > > Bug: 954450 > Change-Id: Ia29366bcdb60d7b28b44964a89d0033855866b8a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635069 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#664591} TBR=tikuta@chromium.org,bpastene@chromium.org,jbudorick@chromium.org Change-Id: I86650591a406e54eda6c39d4c21eab832440b0ad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 954450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636661Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#664610}
-
Eugene But authored
This reverts commit 137ad170. Reason for revert: Fix did not help Original change's description: > Fix testRepostFormAfterReload for slim-nav. > > crrev.com/c/1632591 changed test behavior to wait until reload is > finished for slim nav, which broke the test. > > This CL restores the original behavior, so the test does not wait until > reload is finished. > > Added -[ChromeEarlGreyImpl reloadAndWaitForCompletion:] to compliment > existing -[ChromeEarlGreyImpl loadURL:waitForCompletion:] > > Bug: 968296 > Change-Id: I86d1d982424ee4f56c64ac4cae522f1070d116ab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636570 > Commit-Queue: Eugene But <eugenebut@chromium.org> > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#664544} TBR=justincohen@chromium.org,eugenebut@chromium.org Change-Id: Iaedd550ba2dde2abca2c52849a41951f8ba2c336 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 968296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636921Reviewed-by:
-
Scott Little authored
Previously, support for the "loading" attribute to control lazy iframe loading was only used in conjunction with automatic lazy loading. This CL separates those two concepts, allowing for "loading" attribute support to be enabled for iframes without automatically lazily loading iframes that have no "loading" attribute set. Bug: 937980 Change-Id: I0bf8f0e4d073fee3a3530b654a7834d1eb70cee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633790Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Min Qin authored
This CL adds a new flag to allow download without strong validators to resume. Some data will be used for validation purpose. Two browser tests are added. BUG=965215 Change-Id: Ia6a86dfbe2c076b5123a909142e47b80192cb80c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635830 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#664607}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/688dd321c9df..9779b146cdfe git log 688dd321c9df..9779b146cdfe --date=short --no-merges --format='%ad %ae %s' 2019-05-29 jrn@google.com git-cl: Use modern environment variable name to trigger tracing 2019-05-29 iannucci@chromium.org Roll led to latest version. Created with: gclient setdep -r src/third_party/depot_tools@9779b146cdfe The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ie93914166886ee1d566a645362f205f7f98fa089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636910Reviewed-by:
-
Ben Kelly authored
This CL splits the CacheStorageManager into separate interface and implementation classes. This serves two purposes: 1. It allows us to support separate backend implementations as described in crbug.com/940449. 2. It will also allows us to provide a cross-sequence wrapper implementation for external clients accessing cache_storage from different threads. This CL initially creates the Legacy implementation in the cache_storage_manager.h and .cc files. A follow-up CL will move the LegacyCacheStorageManager to separate files in the legacy directory. Bug: 940449,960012 Change-Id: I5e03ca7de5890d0984add581b6d6bf10d9338497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626503Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/ca41bc48d6f6..12899533d341 git log ca41bc48d6f6..12899533d341 --date=short --no-merges --format='%ad %ae %s' 2019-05-30 tsepez@chromium.org Remove some more xfa/fwl circular includes into xfa/fxfa 2019-05-30 thestig@chromium.org Reorganize |kCMYK| constant. 2019-05-30 thestig@chromium.org Add tests for FPDF_SetPrintMode(). Created with: gclient setdep -r src/third_party/pdfium@12899533d341 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: Icee4c87694f439deca6fceb5addbd46d67459fd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636909Reviewed-by:
-
Dan Beam authored
R=mpearson@chromium.org,avi@chromium.org BUG=953522 Change-Id: I1db3a0f648e70adece42f34a4db49eec22569790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627903 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#664603}
-
dalyk authored
Future cls will use the SecureDnsMode specified in these two structs to control host resolution behavior. This change should be a no-op. Bug: 878582 Change-Id: I2a1434ede92ec6d9997291571e4d32e0b725ea37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628013Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#664602}
-
Joel Hockey authored
Bug: 957477 Change-Id: Ica275a246afc3791cf06d32b8a67fa4587d1083b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636651Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#664601}
-
Xiaocheng Hu authored
Find-in-Page requires |NGOffsetMapping|, which however isn't available on every block due to layout bugs. As the layout bug is currently hard to fix, we work around it in Find-in-Page so that in production build, it ignores those failed blocks instead of crashing. It still hits a DCHECK in DCHECK-enabled builds. Bug: 955678 Change-Id: Ia5e6f45ce8f343deb6c4890de9fac4bdb2be712f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636304 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#664600}
-
Matthew Webb authored
Change-Id: Ie2414402ecceb3d51d39a1f57a5dfc901b31300e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636454 Commit-Queue: Matthew Webb <noviv@google.com> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Matthew Webb <noviv@google.com> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#664599}
-
