- 23 Oct, 2020 40 commits
-
-
Joel Hockey authored
DragDropController::Drop() can be reentrant since exo::DataDevice creates a nested RunLoop (crbug.com/1141745), and referencing |drag_data_| after it has been moved causes a crash. This is fixed by checking |!!drag_data_| in IsDragDropInProgress(). Bug: 1141745 Change-Id: Ide2b376d2b6d8dff3ba820c308e1cc1faffbe7e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494189Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#820402}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f6657788. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I19918b89ed4f89c4a21e7d1799405f53a092b66f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494381Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820401}
-
Scott Violet authored
BUG=1128033 TEST=test only change TBR=ryansturm@chromium.org Change-Id: I271de37305ee5714f2a46e29f71b4ebbd5d9fb50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495641 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#820400}
-
Lei Zhang authored
The v8 binding target has generated sources like gen/third_party/blink/renderer/bindings/modules/v8/v8_media_recorder.cc that then includes third_party/blink/renderer/modules/mediarecorder headers. These headers use buildflags.h and all buildflags.h files are generated. Thus for v8_media_recorder.cc to build, it needs to depend on //third_party/blink/renderer/modules/mediarecorder:buildflags, but that dependency is missing. To fix this, add a dependency from //third_party/blink/renderer/core:prerequisites, which is responsible for generating all necessary C++ source code to //third_party/blink/renderer/modules/mediarecorder:buildflags. Bug: 1139543 Change-Id: If48a33cf4b5deb5bc66a8c21612eff924da774f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482030 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#820399}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9d69cbeabf5d..3d2593512740 2020-10-23 mbonadei@webrtc.org Rename RoboCaller to CallbackList. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I16167a90241ce2f76c89f729e91a58915a4a49ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495048Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820398}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0ce7bcc8e296..5f4e51f38e3e 2020-10-23 yich@google.com cros_flash: add clear-tpm-owner to flash options 2020-10-23 chrome-bot@chromium.org Update config settings by config-updater. 2020-10-22 ahassani@chromium.org cros_flash: Handle App ID mismatch between device and payload 2020-10-22 bhthompson@google.com Make bvt-installer suite asynchronous on release builders If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Ibeeb390c40e63e2607abb49309f50092522b1d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494981Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 88-4280.20-1603104419-benchmark-88.0.4296.6-r1 to 88-4280.20-1603104419-benchmark-88.0.4300.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If8fbdaf9574d237e95cca676dfa7561dbe2df820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495901Reviewed-by:
-
Robin Lewis authored
This allows us to link with protobuf protos and not have the component builds fail during tests. Refactored registry related flags and operations from mdm_utils to reg_utils. Modified fakes usage for cloud policies since in component builds they need to be installed differently. Bug: 1134817 Change-Id: Icfa40921d82e64d1a905273693cf569d108ff31b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493725 Commit-Queue: Robin Lewis <wrlewis@google.com> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#820395}
-
Ana Salazar authored
Update the title for launcher's window when the launcher changes states. This will give Chomevox the information needed to read the title of the window when the user is navigating through the launcher and presses search + a, w. For a partially shown launcher (peeking), the title will be "Launcher, partial view". For the fullscreen launcher, the title will be "Launcher, all apps". If the searchbox or the assistant is displaying results, the title will be "Launcher" Bug: 1111165 Change-Id: I6715ea095b568f72466182ed20a33b7fffde8538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476618 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#820394}
-
Joshua Pawlicki authored
Unfortunately, deferring uninstallation until after the RPC server starts up means the test must pay the 10s between task handling and server shutdown (& uninstall). This CL also adds some basic functionality to print the updater log in the case of a failed test, and speeds up Windows integration tests by moving the sleep to only happen for --uninstall launches. Bug: 1141659 Fixed: 1141659 Change-Id: Iba90261c402966fe1ddb814d01b5521c94da0a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493043 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#820393}
-
Lukasz Anforowicz authored
CheckedPtr<SomeClass> => SomeClass* implicit cast won't kick in when the pointer is used as an argument of an implicitly invoked constructor. After this CL, the rewriter will append |.get()| to make sure that such code still builds after the rewrite. This CL should help ensure that the build is successful, once we stop excluding |const char* fields| from the rewrite. Bug: 1069567 Change-Id: I85c15639c3d15ccbd834298ee4866ed64a053848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495716Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#820392}
-
Regan Hsu authored
* When user clicks dismiss on the real Notification Setup UI in phonehub they can now show the UI again by clicking a button. * When user dismisses the real onboarding UI, they can now show the UI again by clicking a button. Other- * When user dismisses the fake onboarding UI, it will be reflected to the toggle accurately as off. Screenshots: https://screenshot.googleplex.com/6eofiCBa3afSUMT https://screenshot.googleplex.com/3YLYNsHkA6aGVKo Bug: 1106938 Change-Id: I2fb56e1864905602a9ae769d0d9b007294fa7441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490513Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#820391}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/805ba2eff0e1..751a6ed6316a 2020-10-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: If2976134bc78416dfe4e14d48da6f0330cacc76c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495392Reviewed-by:
-
Roman Arora authored
Tab search WebUI source migration effort. Will be followed by a CL that removes tab_search references from src-internal/DEPS and another CL to rename the tab_search_merge references back to tab_search. Bug: 1134167 Change-Id: I4d44201b651b60c13125ffaffece668ce66df28e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492544Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Yuheng Huang <yuhengh@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#820389}
-
yilkal authored
This is a reland of dca1afe8 This is an interesting failure point due to the difference between official builds and non official builds. In official builds, the Sync Consent screen is shown and it will not exit until we interact with it. The waiters timeout waiting for the Parental Handoff Screen to be shown. Original change's description: > Adds parental handoff login screen in oobe. > > The description and mock can be seen in the comments in the bug report. > > Bug: 1134567 > Change-Id: I2ecd7c72629dc96dfbc054f747c6cb2508210709 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466618 > Commit-Queue: Yilkal Abe <yilkal@chromium.org> > Reviewed-by: Aga Wronska <agawronska@chromium.org> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819158} Bug: 1134567 Change-Id: Id4d8c15363579799da14a3f3ed0a285e61dde5d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489756 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#820388}
-
Chong Gu authored
Adding a fuchsia deterministic try builder with the intent of using it in Fuchsia SDK rolls. Bug: 1135171 Change-Id: I353631041e449f28c61368d5afbf6412174f0644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494660 Auto-Submit: Chong Gu <chonggu@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#820387}
-
Ian Struiksma authored
This should be a no-op to definition as fleet has moved, but let's us keep things clean. Bug: 1124829 Change-Id: I9975c20e5e14bbe510f39acebb5d2e7170d629db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493098Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Cr-Commit-Position: refs/heads/master@{#820386}
-
Curt Clemens authored
Add some polymer bindings to share the discovery page's SendPreview with the confirmation page. This allows showing the correct filename on the confirmation page, and also paves the way for using the appropriate icon depending on the file type. Bug: 1123942 Change-Id: Iff779c2fa681f85ff3fd7435cce3a38706ff5c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493376 Commit-Queue: Curt Clemens <cclem@google.com> Reviewed-by:
-
Jonathan Ross authored
Two webgl_conformance_gl_passthrough_tests have begun failing on Linux AMD bots. With driver related errors. A reboot of the bot did not resolve the issue, and we have no good candidate to revert. The consistently failing conformance/renderbuffers/renderbuffer-initialization.html will be suppressed. The flaky conformance/context/deleted-object-behavior.html will be retried. Bug: angleproject/5213 Change-Id: I373979662c70a202d5c3cb65a8f5d9b97bd77774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495420Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#820384}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4791cf2cde52..7a0263547cda 2020-10-23 jmadill@chromium.org Link C++ histogram support into angle_perftests. 2020-10-23 courtneygo@google.com Re-enable dEQP-EGL.functional.fence_sync.* 2020-10-23 jmadill@chromium.org Clean up test runner TODOs. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I035ca9a75055502321f6384d11f03d961b07e6d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495045Reviewed-by:
-
Stephen McGruer authored
This adds a paragraph explaining what action we have actually taken (adding the tests to expectations/adding a baseline file), and what action the bug recipient should undertake (investigate/triage). Bug: 1140476#c7 Change-Id: I20d2c1bb50ab6bf46c6430416599e24fee4b8a94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495011 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#820382}
-
Nate Fischer authored
This adds a section to explain how to out-of-line methods which return or accept new types. This isn't generally necessary for implementation code, but this is important for external-facing classes (such as WebView's glue layer). Fixed: 1112420 Test: Upload to gerrit > open file > click "gitiles" Change-Id: Ia5f835663780c50e1d1601e969a5a6d550e9fbf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493430 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#820381}
-
Michael Bai authored
Check the system setting instead of using Chrome's Bug: 1141646 Change-Id: I43d8bfc8dd3462da21cc040d2c5e4bc3b7469bb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492964Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Michael Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#820380}
-
Maria Kazinova authored
Forms that do not have a <form> tag are treated by Passwordmanager as one synthetic form. This might negatively affect websites that allow navigation via JS scripts, without committing the actual navigation. Password fields might be added/changed, but the already existing PasswordFormManager can store outdated server predictions and treat the form as previously filled. This CL makes sure that the valid server predictions are used when the form changes. Bug: 1140480 Change-Id: I68475dc0c55e8878781351f3f28b3f3f70429271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489990 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#820379}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1315d1d2d5a5..1bec20b5b70c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sky@google.com,mohsen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1141127 Tbr: sky@google.com,mohsen@google.com Change-Id: I889b09de8551b518b95d0512e08987229fa8165e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495046Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820378}
-
Livvie Lin authored
Enables the component updater logic to be moved into a component and used in iOS. Bug: 1140271 Change-Id: If3714b26d9a0dc02f540b67f071a3774d49e94ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486700Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#820377}
-
Andre Le authored
This is a reland of 55f62f27 BUG=1140857,1140980 Original change's description: > [CrOS PhoneHub] Disable Locate Phone button when Silence Phone is on. > > - Add an observer for state change in Silence Phone so that Locate Phone > can be disable when Silence Phone is on. > - Refactor InitQuickActionsItems() since Locate Phone and Silence Phone > is no longer independent. > > BUG=1106937,1126208 > > Change-Id: I6f015e868d6d00df6a40447de62f3efd0b2f2ad0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480662 > Reviewed-by: Tim Song <tengs@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: Andre Le <leandre@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819161} Bug: 1106937 Bug: 1126208 Change-Id: I3bcae322124af80f0947a26c7b0e776757f2ccfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490380 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#820376}
-
Reilly Grant authored
The SerialPort close() method internally calls this.readable.cancel() and this.writable.abort() to close its data streams before closing the port itself. When either of these streams is already erroring the Promises returned by these methods can be resolved before the underlying source or sink has actually finished closing the stream. This patch adds logic to wait until the streams are actually closed before continuing the close process. Bug: 1137563 Change-Id: Ic2c1fd10524292f5b33dfc8279804fe89b00ce7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462711 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#820375}
-
Zachary Kuznia authored
This will still work after git "master" branch is renamed to "main", and makes inclusive language dashboards easier to interpret right now. Bug: none Change-Id: I628be29ce14257b82aa0f88448a9650b56671359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493186Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Zork <zork@chromium.org> Cr-Commit-Position: refs/heads/master@{#820374}
-
Peter Kasting authored
Bug: 772945 Change-Id: Ia203016d23ba52d8cb1cc33164a9a56988aaba23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492546 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Daniel Cheng authored
Bug: 1047547 Change-Id: I4feb88f042b31c02f6616a1ccf250d38af1a16c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494514Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#820372}
-
dpapad authored
This was intentionally postponed in previous CLs that converted them to JS modules to make it easier to review. Fixed: 1139849 Change-Id: Id3399caabcc2057de545b73cf275ee6f813161f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491975 Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
-
Matt Mueller authored
Bug: b/170619368 Change-Id: I9ff06c3ef7dee571936dee89ab5e45c64163b1ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488906Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#820370}
-
Xianzhu Wang authored
This reverts commit 22c627b9. Reason for revert: Performance regressions, e.g. crbug.com/1141834. Need to improve performance of copying subsequences. Original change's description: > Unify PaintController for CompositeAfterPaint and pre-CAP > > This lets pre-CompositeAfterPaint also use a single PaintController > for each local frame tree to reduce the differences between CAP and > pre-CAP. Each GraphicsLayer will create a subsequence. During paint, > when we don't need to repaint a GraphicsLayer, we copy the cached > subsequence for the GraphicsLayer. > > Bug: 1132717 > Change-Id: I27abe8f0f8380b8d4de73b47d3e1fd9f4860365c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466266 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820136} TBR=wangxianzhu@chromium.org,pdr@chromium.org Change-Id: I67fd3e149059fa0c3413609e4f14be25675eeb1d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1132717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495860Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#820369}
-
Chait Pinnamaneni authored
Original PR https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2403841 Bug: 1137050 Change-Id: I9772601823cac56518d7bbedc6320d3970ad6a5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463929Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Chait Pinnamaneni <cpinnamaneni@microsoft.com> Cr-Commit-Position: refs/heads/master@{#820368}
-
Jamie Madill authored
The standalone and non-standalone ANGLE tests are now duplicates. We can switch the bots to use the non-standalone named tests and then remove the duplication. Also removes the old main files that interact with the base test launcher. These are no longer used. Must land after http://crrev.com/c/2491932 rolls into Chrome. Bug: angleproject:5124 Bug: 1141838 Change-Id: Id2fb314ff46562b40473af5224282f70ea3b890a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495003 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#820367}
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 88-4280.20-1603100572-benchmark-88.0.4296.6-r1 to 88-4280.20-1603100572-benchmark-88.0.4300.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I063a6f78cd97374f3a8596f03e64fbd7972b95df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495297Reviewed-by:
-
Justin Cohen authored
Bug: 1140474 Change-Id: I74c00893e6c69cb1cfcbbeed906448d0958f524a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495245 Commit-Queue: Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#820365}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/88d705dc85ff..1b1d2a590744 2020-10-23 dneto@google.com Fix doxygen comment If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: dsinclair@google.com Change-Id: I0d89a433c66ef7f00403533b18898ea1bc8353ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495390Reviewed-by:
-
Xiyuan Xia authored
Make stopSmoothnessTracking to return ThroughputTrackerAnimationData that contains raw metrics data so that tast side could calculate jank metrics as well as smoothness. Bug: 1132017 Change-Id: If1a64d1b681505d0baece3bd7650c1e8a04351b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488664 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#820363}
-
