- 21 Aug, 2020 40 commits
-
-
Mehran Mahmoudi authored
This adds two new UMA histograms: 1.Record whether a paint preview was painted before the associated tab was loaded or not. 2. Record the time it takes from activity initialization to the first paint event. Bug: 1109991 Change-Id: I5757dafbb69289c607d8493acd99314e34538c73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364022Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#800566}
-
Friedrich Horschig authored
The disabled test flakes for 12h with a high frequency. According to the flakiness dashboard, it affects all platforms: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests&tests=virtual%2Fthreaded%2Fexternal%2Fwpt%2Ffeature-policy%2Fexperimental-features%2Fvertical-scroll-disabled-scrollbar-tentative.html TBR: iclelland@chromium.org Bug: 1120106 Change-Id: Ia4bf0c4ac0428cac22ded67a562b4179ee7b9e4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367949 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#800565}
-
Hajime Hoshi authored
Bug: 1014174 Change-Id: Id42d841138d0b571f12d6d9e81aa17a236a222e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366533 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#800564}
-
Curt Clemens authored
Log a variety of errors and the start/finish of async operations in NearbyShareCertificateManagerImpl and NearbyShareCertificateStorageImpl using the NS_LOG macro. Change-Id: Iadbee4fff8869b23606b990f7635e3f73429dad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364086 Commit-Queue: Curt Clemens <cclem@google.com> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#800563}
-
Mike Reed authored
... removing unused enum parameter Amends previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/2367441 Change-Id: Id36d21a264a32801dc09253112180bd2d1f6aaaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367987Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#800562}
-
Siyu An authored
Introduced the skeleton of the new autofill offer sync bridge. Will add more to it in the following CLs. The offer data and the wallet credit card data now will controlled by the same toggle in the Chrome sync settings page. Therefore the sync logic will be almost same. So reuse the current model type controller. Bug: 1112095 Change-Id: I7464dde02b84f0a020f262c5453e8ac4a067edfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365854Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#800561}
-
Peter Boström authored
The extension icon images are 28x28 to as they contain space for badging the icon with "click to script". They are still visually 16x16 icons. This change adds the same amount of space (but not for badging) around the actually-16x16 settings icon to make icon and text aligned with other items in this menu. Bug: 1050601 Change-Id: I51c9aa81ab05fd53cf3b3702e73c543f257a1960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368927 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#800560}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a2c33e3fa098..9d8fd36d3b95 2020-08-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 2979391e5b0c to e1c7eaa74142 (1 revision) 2020-08-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from a711c594b8cc to b79773a35d52 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: Ida343d5391e43bc1c974b6659e75db1761c17c9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368911Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800559}
-
Thiabaud Engelbrecht authored
Discardable memory Lock()-ing can succeed or fail once it has been Unlock()-ed. For example, Lock() will fail if the memory has already been discarded. This CL is to record the hit rate in UMA. Bug: 1117043 Change-Id: I1c7214365fe7b0b20d3af7e750ff4cfdf3ef4c50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344812Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com> Cr-Commit-Position: refs/heads/master@{#800558}
-
Christian Dullweber authored
Show cookie settings when the user clicks on "Settings" link. As chrome and weblayer have different ways of creating intents, this happens in the pageinfo delegate. Bug: 1077766 Change-Id: Iefd81c06ce3947eb4e95107db1360c375955ed01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343033 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#800557}
-
Arthur Hemery authored
A cross origin isolated page is a page that has set COOP and COEP, eventually unlocking access to powerful APIs such as SharedArrayBuffer. This first patch goal is to introduce cross origin isolated BrowsingInstances that only contain cross origin isolated pages. It modifies the SiteInstance selection process to make sure the invariant holds. In more details: - BrowsingInstances now have a is_coop_coep_cross_origin_isolated boolean, that indicates if all the pages contained into it have been COOP+COEP enabled. Each BrowsingInstance also holds the origin of the top level pages contained in it, unique across all the top level pages in it. - CHECKS and DCHECKS enforce the BrowsingInstance invariant. See the full design doc https://docs.google.com/document/d/1OFaz1Txi4ynFLmRqNTLFF3qd6jm4kK4GkJdmgr5_aZA/edit?usp=sharing for more information. It was based on clamy@ work here: https://chromium-review.googlesource.com/c/chromium/src/+/2066844 and further discussed here: https://chromium-review.googlesource.com/c/chromium/src/+/2119854 BUG=1055779 Change-Id: I4829337f5fd4a4c2cd18f2cfaaf7ef8054eb67a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230632Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#800556}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597967068-f4dc3a01dd1d9ac3893254a5c720534a30d259cc.profdata to chrome-mac-master-1598010867-4aa503022e102f1aa007637f80b234f543663e29.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: Ic87539cead5efc07220c201af63008ff2c700268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369153Reviewed-by:
-
Titouan Rigoudy authored
Following Camille's recommendation, this CL moves all mentions of PrivateNetworkRequestPolicy out of components/content_settings and into content/browser. Given that the content setting is now used purely as an escape hatch disabling CORS-RFC1918 checks, a boolean is simpler and clearer. It also removes useless DEPS and BUILD.gn dependencies that were left over from an incorrect rebase operation during crrev.com/c/2282932. Bug: chromium:986744 Change-Id: I5912e2bb091e28dfdcc273342e10fd2e2bbc47ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367074Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Cr-Commit-Position: refs/heads/master@{#800554}
-
Liviu Tinta authored
Pointer lock is acquired and released asynchronously. Remove reliance on timeout from the test by waiting until lock is properly acquired/released during the test steps. Bug: 1025944 Change-Id: Ibd5b1c19efb9c00794f1b900e12a5f5a4edab16e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360494Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#800553}
-
Roman Sorokin authored
This CL modifies existing behavior in the way that HID Detection screen is always shown on OOBE start if it's needed. It proceeds to the saved in the local state screen (or welcome screen) after that. Also removed CheckIsScreenRequired from the handler. Change-Id: I0253eae1a67c39567aba4f0cc522488c465056a4 Bug: 1105889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339655 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#800552}
-
Anna Malova authored
TBR=arthursonzogni@chromium.org Bug: 1119555 Change-Id: I9c83227a0aae954e57d8f15cd7b4fc1cc1970a82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368873Reviewed-by:
Anna Malova <amalova@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#800551}
-
Weilun Shi authored
Temporary disable validate_prefix.py until we split all histograms because this blocks all updates in the current histograms.xml. Bug: 1120228 Change-Id: I5f3a607942098c4aa9341d1f86dda7913d185c49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368080 Auto-Submit: Weilun Shi <sweilun@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#800550}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f8fa384f..ce9f3a41 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idacdb9154bd2679c28d63ac986dbcce89cbd2823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367495Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800549}
-
Stephen Sigwart authored
Home key changes to first of month, January in month view, and week 1 in week view. End key changes to last of month, December, or last week. For time, home goes to 1, 00, and am while end goes to 12, 59, and pm. Bug: 1062025 Change-Id: I40daebeca55eeb578a3b75d1ab06b6013d9bc540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358476Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Stephen Sigwart <ssigwart@gmail.com> Cr-Commit-Position: refs/heads/master@{#800548}
-
kylechar authored
This CL changes how pixel tests are defined in viz_unittests. This is intended to be a refactor only change with no changes to the test logic or what tests run on each platform. Vix pixel tests previously used gtest typed tests, where the RendererType was a template parameter. Typed tests are not particularly extensible and don't work well when the parameter space to be tested isn't directly mapped to existing types. Some hacks to define pseudo types and use type deduction were used to specify things like running SkiaRenderer with different graphics backends (eg. GL vs Vulkan). This CL converts switches viz_unittests to use value parameterized tests to specify different renderer and graphics backend combinations. Value parameterized tests are the most extensible in gtest, and this fits in well with existing value parameterized tests. The key change here is replacing the cc::RendererPixelTest base class with a new VizPixelTest class. It's essentially equivalent except the RendererType is passed a constructor parameter instead of template parameter. An attempt was made to keep the test names stable, however some changes were introduced when changes as tests suites were merged. A follow up CL will use the renderer name instead of an arbitrary number to identify variations of the same test with different renderers, so the test naming is about to change significantly anyways. Bug: 1117587, 1047820 Change-Id: Ib626a081fb7797938a5cd34e96d8af44d7181965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364222 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#800547}
-
Roman Aleksandrov authored
Create all needed Update screen steps, use newly added time left estimation and progress procent. Bug: 1119399 Change-Id: Ia7ff7f76fb21fa683457f71f0bab3f598571e096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364634 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#800546}
-
Mohamed Amir Yosef authored
... in CompromisedCredentialsConsumer. This is similar to OnGetCompromisedCredentials(), but also receives the originating PasswordStore as a parameter. Bug: 1108422 Change-Id: Icc4e8135f4181b17f23fbee23666d20ad4f04277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367717 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#800545}
-
Harald Alvestrand authored
Rewrite test so that it does not hang (create promise before event that it is waiting for). Bug: chromium:1115080 Change-Id: Ic445bef22561a1d997b4d3657a76e1b0779a1259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367854Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#800544}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/bfb423d26610..490961030b55 2020-08-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I26a9e59c62ff3bbc0b82df23bfa6210d0c1abd8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368921Reviewed-by:
-
Tanmoy Mollik authored
The sync related icons will now change color depending of light mode or dark mode. Screenshot: https://crbug.com/1109149#c3 Bug: 1109149 Change-Id: I631b6940f2ced0903f3687bd6ce84b5cbe7c0ccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362807 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#800542}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e719fca9. With Chromium commits locally applied on WPT: 3b705a74 "WPT: Service Worker: Add unexpected state check to wait_for_state()" 9f52c7e4 "COOP: add reporting to redirects" f3b221b0 "[COOP] access reporting: Extend report.body.type values." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I9bde9e84e4306a1c69914262376fcfc4ec7c364f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367399Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800541}
-
Ewann authored
This CL is developed under a flag. It displays the OpenIn.. toolbar to all files that support preview. Bug: 1117398 Change-Id: I32ad05e7cf0de89f3407366fa6767a29af3b80f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276269 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#800540}
-
Irina Fedorova authored
This feature flag allows as to enable checking passwords for weakness in chrome://settings/passwords/check. Bug: 1119752 Change-Id: I24984ee3cd64778260195b4319262c8b7851895d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367033 Commit-Queue: Irina Fedorova <irfedorova@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#800539}
-
Mohamed Amir Yosef authored
This CL only introduce the simplest version of the reader which handles only one store. Follow-up CL will wire it up to the rest of the code, and then make it handle multiple stores. Bug: 1108422 Change-Id: If5202f5112cb841bd1c3ac65b37b5a1fa0eade4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367065 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Swapnil authored
Add swapnilgupta@ to OWNERS in the following directory: forced_extensions in chrome/browser/extensions/ Change-Id: I051d997768624f720c7950250b17eb488db62b12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364534Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#800537}
-
Eleonora Rocchi authored
This CL adds tests to verify the number of compromised credentials is correctly updated: if the status is IDLE the count should be updated, otherwise the count should be null. Bug: 1117543, 1092444 Change-Id: I1f5a63745bc20789fc7df7bb5b5672df97e3b5e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367719Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
-
Mohamed Amir Yosef authored
... DatabaseCompromisedCredentialsObserver. This is similar to OnCompromisedCredentialsChanged(), but also receives the originating PasswordStore as a parameter. Bug: 1108422 Change-Id: I76fffc36c65554bbe3e812c9e21ab229437f20a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368554 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/12ffc2536244..c153394161f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mxcai@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1099917,chromium:1115567 Tbr: mxcai@google.com Change-Id: I69d01e6985fe8d4c24c945227d10488057df24e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368546Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800534}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5d93c7e06451..d7508751f4e1 2020-08-21 patrick.brosset@microsoft.com Grid: Transform grid lines and labels based on the current writing mode If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1096971 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I96147e0515c03dfb66f28fcbdf9db251b680a6b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368923Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4909d08c1410..a2c33e3fa098 2020-08-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from cbfd396756c6 to 44e1791f100c (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: Ib7262936b7d170cce9dd20f38b60d742b4bbd991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368478Reviewed-by:
-
Igor authored
Currently three links from feedback form don't work properly on login screen, by opening invisible incognito windows only. This CL removes the links until the problem can be fixed on login screen. screen and click on the links for privacy/terms of service. Nothing is expected to happen, the links are disabled. Bug: chromium:1116383 TEST: Manually verified on device by pressing alt+shift+I on login Change-Id: Ieffd4cccbc8fbac52f45890761783cadb29cd3ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362797 Commit-Queue: Igor <igorcov@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Roland Bock <rbock@google.com> Auto-Submit: Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#800531}
-
Leszek Swirski authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/899af242..f8fa384f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I336d80b56df8dff866a47b0796a7cebf3ad038d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366276Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Maggie Cai authored
This reverts commit f5cdac12. Reason for revert: This might be the cause of test failure virtual/threaded/external/wpt/feature-policy/experimental-features/vertical-scroll-disabled-scrollbar-tentative.html for https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/48699 (and some builds after this). Revert to see if this fixed the test. Original change's description: > Don't trigger main-thread overlay scrollbar animations if composited > > There are already hit tests and animations entirely in the impl thread > for such scrollbars. > > Bug: 1116800 > > Change-Id: I2714258717c89e0ea41232eb86abe12570526d28 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364972 > Commit-Queue: Chris Harrelson <chrishtr@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800302} TBR=bokan@chromium.org,chrishtr@chromium.org Change-Id: Ided42e8aa3339e93f85d9f73f3737197864b493d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1116800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369076Reviewed-by:
Maggie Cai <mxcai@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#800529}
-
Friedrich Horschig authored
After this CL, CrOS tests will only execute 2 more tests from this test suite but the flakiness has reached a frequency of 1 failure per run (not the same test though). The failure reason is not easy to track down but the error log is pretty much always show the same DCHECK being hit: Check failed: casting_session_count_ > 0 (0 vs. 0) #0 0x561ba221ecab in __interceptor_backtrace /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:4176 #1 0x561ba221ecab in ?? ??:0 #2 0x561bb683aea9 in base::debug::CollectStackTrace(void**, unsigned long) ./../../base/debug/stack_trace_posix.cc:840 #3 0x561bb683aea9 in ?? ??:0 #4 0x561bb656d143 in StackTrace ./../../base/debug/stack_trace.cc:206 #5 0x561bb656d143 in StackTrace ./../../base/debug/stack_trace.cc:203 #6 0x561bb656d143 in ?? ??:0 #7 0x561bb65cd766 in logging::LogMessage::~LogMessage() ./../../base/logging.cc:543 #8 0x561bb65cd766 in ?? ??:0 #9 0x561bb65cee7e in logging::LogMessage::~LogMessage() ./../../base/logging.cc:537 #10 0x561bb65cee7e in ?? ??:0 #11 0x561bc20145a9 in ash::ProjectingObserver::OnCastingSessionStartedOrStopped(bool) ./../../ash/display/projecting_observer.cc:50 #12 0x561bc20145a9 in ?? ??:0 #13 0x561bc1fe0c33 in ash::Shell::OnCastingSessionStartedOrStopped(bool) ./../../ash/shell.cc:404 #14 0x561bc1fe0c33 in ?? ??:0 #15 0x561bb6cc6e86 in MediaCaptureDevicesDispatcher::UpdateMediaRequestStateOnUIThread(int, int, int, GURL const&, blink::mojom::MediaStreamType, content::MediaRequestState) media_capture_devices_dispatcher.cc:? #16 0x561bb6cc6e86 in ?? ??:0 #17 0x561bb6cc9822 in Invoke<void (MediaCaptureDevicesDispatcher::*)(int, int, int, const GURL &, blink::mojom::MediaStreamType, content::MediaRequestState), MediaCaptureDevicesDispatcher *, int, int, int, GURL, blink::mojom::MediaStreamType, content::MediaRequestState> ./../../base/bind_internal.h:498 #18 0x561bb6cc9822 in MakeItSo<void (MediaCaptureDevicesDispatcher::*)(int, int, int, const GURL &, blink::mojom::MediaStreamType, content::MediaRequestState), MediaCaptureDevicesDispatcher *, int, int, int, GURL, blink::mojom::MediaStreamType, content::MediaRequestState> ./../../base/bind_internal.h:637 #19 0x561bb6cc9822 in RunImpl<void (MediaCaptureDevicesDispatcher::*)(int, int, int, const GURL &, blink::mojom::MediaStreamType, content::MediaRequestState), std::__1::tuple<base::internal::UnretainedWrapper<MediaCaptureDevicesDispatcher>, int, int, int, GURL, blink::mojom::MediaStreamType, content::MediaRequestState>, 0, 1, 2, 3, 4, 5, 6> ./../../base/bind_internal.h:710 #20 0x561bb6cc9822 in RunOnce ./../../base/bind_internal.h:679 #21 0x561bb6cc9822 in ?? ??:0 #22 0x561bb6702dd1 in Run ./../../base/callback.h:99 TBR: mfoltz@chromium.org Bug: 822231 Change-Id: I1780e4f0be20361bded9d38a070e6dfacdfdd45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367676Reviewed-by: -
Mugdha Lakhani authored
Bug: 1119726 Change-Id: If3a82e7718590e51bafeee191e2176cd2a3f2a4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366754 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#800527}
-
