- 17 Oct, 2017 40 commits
-
-
Daniel Bratell authored
In the jumbo build experiment (chromium unity builds) there is a collision between the two different kDataFile strings. This patch renames them kNetworkErrorDataFile and kTargetsDataFile which also matches their intended values. Bug: 746953 Change-Id: Ib9f47fa4d358303c7cdbb65b54b40080521a915d Reviewed-on: https://chromium-review.googlesource.com/721299Reviewed-by:
Bence Béky <bnc@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#509320}
-
Will Chen authored
This eliminates a lot of the code duplication between the new and legacy integration test frameworks by making the legacy test helper files small wrappers to load the new *test_runner modules. * Fixes data_grid_test_runner because the legacy test helpers had two data grid implementations, one of which was not actually used anymore. Bug: 667560 Change-Id: I2ad21ec7b50be89a44f643858cec3b9348d8d857 Reviewed-on: https://chromium-review.googlesource.com/722112 Commit-Queue: Will Chen <chenwilliam@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#509319}
-
Marc Treib authored
For a long while now, this method always returns true on desktop and false on mobile, so any code that's either desktop-only or mobile-only doesn't need to check it. Bug: 627747 Change-Id: I6d1b25ad0e6f2c76a0013725b675e5d059f6cff0 Reviewed-on: https://chromium-review.googlesource.com/720922Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#509318}
-
Daniel Cheng authored
The original code used a different way to check that the extension is an image extension (and not something else, like .exe), but this depended on being able to directly access the blink::Image class. When the name calculation was moved into the browser, blink::IsSupportedImageType was used instead to ensure that a user doesn't drag out an image and get something surprising like an executable instead. However, it turns out that blink::IsSupportedImageType doesn't consider SVG an image type--since it's actually an XML file. To get around this, just simply check that the MIME type begins with image/. This is safe enough, since the filename calculation only takes well-known MIME types into consideration. Bug: 767775 Change-Id: I5c71d8ae2daa9a413beab9c3c1cb393760383323 Reviewed-on: https://chromium-review.googlesource.com/721615 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#509317}
-
Christopher Cameron authored
Bug: 775202 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I9565ee77b276fe14ecbdfaf17ec18d348a80cb85 Reviewed-on: https://chromium-review.googlesource.com/722034Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: ccameron chromium <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#509316}
-
Klemen Kozjek authored
This CL removes notifications to indicate successfully completed and pending operation of an external drive rename. Related strings will be removed in CL:722460. Bug: 775018 Test: browser_tests --gtest_filter=FileManagerJsTest.DeviceHandlerTest Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3eb43a6f4cc4f53214e074813e04f561262d7767 Reviewed-on: https://chromium-review.googlesource.com/722140 Commit-Queue: Klemen Kozjek <klemenko@google.com> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#509315}
-
Lucas Garron authored
The committed interstitial project will use a navigation throttle [1] to watch for requests that failed due to cert errors. WillFailRequest() will allow it to decide how to respond, and provide custom error HTML for SSL interstitials. [1] crrev.com/c/621236 Bug: 751941 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I9a597851d018e3e42d884c185ba2c619b9d31923 Reviewed-on: https://chromium-review.googlesource.com/621873 Commit-Queue: Lucas Garron <lgarron@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#509314}
-
Iris Uy authored
Bug: Change-Id: Icb5351bb6112fc89e36dab82c15f32887dab9217 Reviewed-on: https://chromium-review.googlesource.com/720594Reviewed-by:
David Vallet <dvallet@chromium.org> Commit-Queue: Iris Uy <irisu@chromium.org> Cr-Commit-Position: refs/heads/master@{#509313}
-
erikchen authored
The existing code for views::ScrollView and views::TableView contains a layout-dependency cycle. * The size of the TableView depends on whether scrollbars are present. * Whether scrollbars are present is dependent on the size of the TableView. This causes the following problem: The TableView sets its height to ScrollView::content_viewport_'s height. But the TableView's width is wider than the viewport's width. This causes the ScrollView to add a horizontal scrollbar. But now horizontal scrollbar + content's height > viewport's height, so a vertical scrollbar is also necessary. A full fix to this problem would require a large refactor to avoid layout-dependency cycles. Instead, I will extend an existing workaround. Prior to invoking layout for the TableView, the contents_viewport_ will be artificially shrunk to make space for both a vertical and horizontal scrollbar. Previously, it was only shrunk to make space for a vertical scrollbar. This way, if the contents chooses to take up the full height, there's enough space for a horizontal scrollbar to appear without causing a vertical scrollbar to appear. Bug: 771502 Change-Id: Ib97ddd8f5619d16342ee85e7ad280c049a1566e5 Reviewed-on: https://chromium-review.googlesource.com/719380 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#509312}
-
Blake O'Hare authored
This is a small first step towards the floating keyboard, although the changes here are pre-emptive refactorings independent of any floating keyboard functionality or UX (and are probably reasonable de-couplings to do anyway). Unit tests that are coupled to the current animation behavior are still valid and pass, although those should be decoupled when more container behaviors are added. Bug: Change-Id: Ifbd8e4125fe4be89e03a2fec813714edc0036996 Reviewed-on: https://chromium-review.googlesource.com/720541 Commit-Queue: Blake O'Hare <blakeo@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Keigo Oka <oka@chromium.org> Cr-Commit-Position: refs/heads/master@{#509311}
-
Yuichiro Hanada authored
Also clean up some obsolete paths. Change-Id: I843dba25f99dbae12b3e420317d1259b54b1b1d3 Reviewed-on: https://chromium-review.googlesource.com/713034Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#509310}
-
Albert J. Wong authored
Prior to this CL, DecommitSystemPages() performed 2 conceptually different operations that callers cared about depending on which platorm it was called on. There are 2 operations: * return storage from ram or swap to the OS * make the page inaccessible. On Windows, "Committed memory" is a first-class concept in the OS Memory Subsystem API. A region returned via VirtualAlloc() when MEM_COMMIT is specified is guaranteed to be touchable without causing the program to crash due to out of memory. Since it is a first class concept, decommitting is directly supported and calling this function resulted in the both operations above. In the POSIX memory API, there is no such thing as "Committed memory." Until the first touch of an anonymous mmap()ed region, it is unknown if the pointer deference for that address may crash. Therefore this API had unclear semantics and was implemented to ONLY return allocated ram and swap to the OS. Page permissions were left the same meaning subsequent touches would just reallocate the memory instead of fault. This divergence in page accessibility caused callers to manually execute SetSystemPagesAccess() after calling DecommitSystemPages() to ensure uniform behavior across all platforms which resulted in a wasted syscall on Windows and confusing API semantics. This CL changes the contract of DecommitSystemPages() so that it provides the guarnatees that can be enforced on all platforms. The naming is still somewhat incorrect as "commit" is not a well defined concept in POSIX...baby steps... Bug: 766882 Change-Id: Ib5c8f1c712e080f1003fad628f60012e0feaf9d8 Reviewed-on: https://chromium-review.googlesource.com/696292 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#509309}
-
Yuichiro Hanada authored
Also remove several people who are no longer working in chromium. Bug: None Change-Id: I8221077bd2aa0d1e0e271dc19c48b5e4a5ad627d Reviewed-on: https://chromium-review.googlesource.com/701877Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Zachary Kuznia <zork@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#509308}
-
Piotr Swigon authored
POST requests should not get opened in CCT, as: 1) Request might not require redirecting the user. 2) CCT will issue the request as GET and drop the request body. Test for this change has been extracted to crrev.com/c/722488 for easier merging. Bug: 771984 Change-Id: I1f49409ec3de20c9c29352e5e23c571a365e515b Reviewed-on: https://chromium-review.googlesource.com/722384Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Piotr Swigon <piotrs@chromium.org> Cr-Commit-Position: refs/heads/master@{#509307}
-
tzik authored
scoped_refptr.h is allowed in Blink, and ref_counted.h is allowed only on wtf now. This CL updates existing ref_counted.h inclusion to scoped_refptr.h. Bug: 763844 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I3837118b1cb4176c427ad9e39e43ade2769aeaf9 Reviewed-on: https://chromium-review.googlesource.com/712274Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
mariannet authored
Add more margin to quick viewing text files in order to improve readability. Bug: 742944 Test: manually Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Icc25905d01eba4e266b949ddde075d10e1ad93ed Reviewed-on: https://chromium-review.googlesource.com/720656Reviewed-by:
-
mariannet authored
Keep the focus on the files table when long pressing the header. Bug: 752389 Test: manually Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic9833320e728cb64767741b88c43d6c8a22fc733 Reviewed-on: https://chromium-review.googlesource.com/716077Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
-
Leo Zhang authored
Original check will load the whole accepted language code list, then check whether the given code is in the list or not. But in Android client, loading a list of codes will trigger 100+ JNI calls which costs 30~60 ms (based on the local testings on my Nexus 6). This change will call only one JNI to check whether a given language is accepted in Chrome. It matters in Clank, because the JNI is very expensive. It will save 30~60 ms for each check in my local testing. Bug:771835 Change-Id: If2f3838492521373a139a4220c843fc7bc3b1f8b Reviewed-on: https://chromium-review.googlesource.com/708097 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#509303}
-
Victor Costan authored
The crash can only occur when the "Enable Experimental Web Platform Features" flag is turned on. Bug: 774626 Change-Id: I4e8170d2c82db53d8bacd5c8586ef4cce3000be4 Reviewed-on: https://chromium-review.googlesource.com/722038Reviewed-by:
-
junweifu authored
Shape Detection will use WRL to access Windows Runtime components, wrapped GetActivationFactory, CreateIBufferFromData and GetPointerToBufferData function also need to be used in CL[1], so move these common functions to winrt util. [1] https://chromium-review.googlesource.com/c/chromium/src/+/708336 BUG=767021 Change-Id: I054e273dc14fea648d1fed444d189ecd5e4292ca Reviewed-on: https://chromium-review.googlesource.com/715656 Commit-Queue: Junwei Fu <junwei.fu@intel.com> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#509301}
-
Henrik Boström authored
trackSwitchingStream: 1. SRD: "stream1 with track1 created." 2. SRD: "track1 is moved to stream2." trackAddedToSecondStream: 1. SRD: "stream1 with track1 created." 2. SRD: "stream2 with track1 created, track1 still belonging to stream1." Bug: 769743 Change-Id: I64f5c0790c17c2c396f38be39580da495844c749 Reviewed-on: https://chromium-review.googlesource.com/711135Reviewed-by:
Taylor Brandstetter <deadbeef@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#509300}
-
Xiaocheng Hu authored
This patch adds ::first-letter handling to the following functions by adding LayoutTextFragment overrides: - LayoutText::CaretMinOffset - LayoutText::CaretMaxOffset - LayoutText::ResolvedTextLength Bug: 771398 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I5309e706a5161498b9e909b9d2098a232e328020 Reviewed-on: https://chromium-review.googlesource.com/719410 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#509299}
-
Katie Dektar authored
Don't highlight whitespace-only nodes. Bug: 753022 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iaac62b135512ba95ea6dfaabc9450802e939e621 Reviewed-on: https://chromium-review.googlesource.com/719763 Commit-Queue: Katie Dektar <katydek@google.com> Reviewed-by:
-
Darren Shen authored
This patch change selector parsing to use streams. The advantage is two fold: - We no longer have to allocate memory for long selector preludes, e.g. .a, .b, .c, .d, .e .... { }. This is useful for websites that minify their CSS, as the minified CSS tend to form very long selector lists. - This is the last use of CSSParserObserverWrapper, so we can remove it in a future patch. To use streaming, we have to be careful with error recovery. If an error occurs in the prelude, we still have to skip the rest of the block. For reviewers: - Most of this code is from the original patch in [1]. - The 'new' code in CSSSelectorParser is pretty much just the streaming version of the Range based version of ConsumeComplexSelectorList. [1] https://codereview.chromium.org/2503683003/ Bug: 661854 Change-Id: Ied369ffba695f15baf347591e833aaec40080662 Reviewed-on: https://chromium-review.googlesource.com/676888Reviewed-by:meade_UTC10 <meade@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#509297}
-
Makoto Shimazu authored
This patch ensures unit tests create valid disk cache entries for SWVersions which could be started using SWInstalledScriptsSender. If unit tests don't create valid entries for the worker scripts, SWInstalledScriptsSender detects it and deletes the SWVersion, so some tests trying to dispatch events or something would be aborted. Bug: 683037 Change-Id: I0f226767454db46d5112b48ed2bdbb6999ac384c Reviewed-on: https://chromium-review.googlesource.com/712674 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
John Budorick authored
Put it in the wrong place in https://chromium-review.googlesource.com/c/chromium/src/+/719456 TBR=dpranke@chromium.org Bug: 771841 Change-Id: I46ff199310a6ce8e490e7d78e285924edd321e42 Reviewed-on: https://chromium-review.googlesource.com/722447Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#509295}
-
Vladislav Kaznacheev authored
--mash --test-launcher-filter-file= testing/buildbot/filters/ash_unittests_mash.filter --mus --test-launcher-filter-file= testing/buildbot/filters/ash_unittests_mus.filter Bug: 773016 Test: ash_unittests --gtest_filter=ScreenshotTool* Change-Id: I38fdf03b3d88fe0a2a831b950f0e95cbf6f5afcc Test: ash_unittests --gtest_filter=ScreenshotTool* Test: ash_unittests --gtest_filter=ScreenshotTool* Reviewed-on: https://chromium-review.googlesource.com/721603 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#509294}
-
Christopher Cameron authored
Bug: 766918, 775226 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I204884a683f0c7e5aa6eaf431103ff72d01dbd0b Reviewed-on: https://chromium-review.googlesource.com/722339Reviewed-by:
-
Michael Giuffrida authored
Recommend appending, instead of prepending, paths to `runtimepath`. Vim uses the first directory in the 'runtimepath' option for some special uses, such as the location of the .netrwhist file.[1] Prepending these paths to `runtimepath` may result in unwanted file creation in those directories, leading to annoying untracked files in your workdir. It should be safe to append these paths instead, assuming other scripts for these file types aren't appended first. Alternatively, we could add files like .netrwhist to .gitignore, but then developers would lose global Vim history when removing their workdir, which is weird. [1] https://github.com/vim/vim/blob/890680ca6364386fabb271c85e0755bcaa6a33c1/runtime/doc/pi_netrw.txt#L1434 Change-Id: I3bff2aa540a8392b103d0edf3eba59b7482296c7 Reviewed-on: https://chromium-review.googlesource.com/721256Reviewed-by:
-
Darren Shen authored
When we fill in the RuleSet for a StyleSheetContents object, a rule in a media query would only be added if the media query evaluate to true. Hence, a StyleSheetContents may have different RuleSets depending on the current media. This is why we do not cache StyleSheetContents that contain media queries, since the RuleSet needs to be different. This patch enables (hidden behind a flag) caching of StyleSheetContents with media queries, but when they are retrieved from that cache, they are cloned. Design doc: https://docs.google.com/document/d/1IpyqChzXDJczfsxnbv0kh-gAx6HBGGfIpSu4P6nKI1s/edit?usp=sharing Bug: 472923 Change-Id: I61778a9e50fc11881a3cb5f5ddfe358876c43fc6 Reviewed-on: https://chromium-review.googlesource.com/704474Reviewed-by:
Rune Lillesveen <rune@opera.com> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#509291}
-
Sylvain Defresne authored
There was only one call to Tab -originalTitle, so inline it and remove the property from Tab. Bug: none Change-Id: Idc574da6818df54eac30df23afb636444b119456 Reviewed-on: https://chromium-review.googlesource.com/720170 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#509290}
-
Yutaka Hirano authored
No one uses it. Bug: 775318, 624278 Change-Id: I1efddd76f8a7eba5fbe4a0bf1eb12899b391baa7 Reviewed-on: https://chromium-review.googlesource.com/722299 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#509289}
-
Tatsuhisa Yamaguchi authored
Bug: 762746 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I77f2279247ffdf33790946f623ff4115b2752e0b Reviewed-on: https://chromium-review.googlesource.com/715837Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#509288}
-
Yoshifumi Inoue authored
Remove redundant file WebKit/LayoutTests/platform/mac-mac10.10/fast/text/atsui-kerning-and-ligatures-expected.png This patch gets rid of redundant layout test expected image file[1] introduced by the patch[2], which missed to move this file to "fast/text/selection" directory. [1] WebKit/LayoutTests/platform/mac-mac10.10/fast/text/atsui-kerning-and-ligatures-expected.pngatsui-kerning-and-ligatures-expected.png [2] http://crrev.com/c/718239: Move selection related layout tests to fast/text/selection from fast/text/" TBR=alexmos@chromium.org NOTRY=true Bug: 775064 Change-Id: Ib5cac0d3e3009ee52c46e81e106d710d4b6f1e42 Reviewed-on: https://chromium-review.googlesource.com/722361Reviewed-by:
-
Yue Li authored
Send the updateScreenSize signal after the screen starts loading to correct the size of inner-container. BUG=b/65555008 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4c3db0fb419de439450b4a4bdcbaa9981849b505 Reviewed-on: https://chromium-review.googlesource.com/717722Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#509286}
-
Stephen McGruer authored
Each of these files consisted of less than 50 loc implementation across the methods they contained, and each contained methods that were called from only one implementation (.cpp) file. Moving the helper functions into their calling .cpp lowers the cognitive overhead in finding the implementation as well as allowing for complete inlining of some helper functions where appropriate. Bug: None Change-Id: Ibaa89188d724a80aea76239c5b27fe672471b18b Reviewed-on: https://chromium-review.googlesource.com/713469 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#509285}
-
Harald Alvestrand authored
Rewrote RTCPeerConnection-lifetime and RTCPeerCOnnection-ontrack to work with real peerconnections. Deleted three tests that should have appropriate coverage in existing WPT tests. Bug: 771540 Change-Id: I1d5d26bb48ce4993714115bdcfb9ceb2edd02947 Reviewed-on: https://chromium-review.googlesource.com/715597 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#509284}
-
Adam Langley authored
There are two changes around base::checked_cast in here: Firstly, one call was changed from checking a cast to uint8_t before left-shifting, to checking it after the shift. Since it's the final value that we care about r.e. truncation, I think that makes sense. Secondly, a value that was ANDed with 0xff was being checked before casting to uint8_t, which is superfluous. Change-Id: I4c4fedfd3aa7c693d24a5d2cb5d48dcd40eaaae1 Reviewed-on: https://chromium-review.googlesource.com/716572 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#509283}
-
Jennifer Apacible authored
Intent to implement/ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/a0tguvcZZyk BUG: 747082 Change-Id: I740aa8396a7cecc74b741ab544c71652121c44d3 Reviewed-on: https://chromium-review.googlesource.com/666121 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Dimitri Glazkov <dglazkov@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#509282}
-
Hidehiko Abe authored
BUG=None TEST=Trybot. Change-Id: I383365208716b3b1e2deadca1d8d42710cd9882f Reviewed-on: https://chromium-review.googlesource.com/718162 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#509281}
-
