- 01 Aug, 2017 40 commits
-
-
Etienne Pierre-Doray authored
Bug: 729154 Change-Id: Ifc313411a21c340588fd41a97ba74ccc9a84dbfa Reviewed-on: https://chromium-review.googlesource.com/570767Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#491083}
-
sunxd authored
When tiling masks, sometimes we get tiles that are completely outside the layer's visible rect. This would lead to problems in determining whether quad rect contains visible rect, because an empty rect's origin is not always contained by a quad rect that locates at a random origin. This would result in problems when converting draw quads to RPDQs in IPC, thus breaking Android WebView. This CL makes RenderSurfaceImpl::TileMaskLayer throw away such quads. Bug: 740810 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I07c4024894740d09ba4708d5ead37a4bec99d7ea Reviewed-on: https://chromium-review.googlesource.com/570630Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#491082}
-
Bruce Dawson authored
VC++ is much less frequently used now so it can easily accumulate compiler warnings. A couple were fixed a few hours ago but two more remain. This fixes them by adding casts. Arguably the better fix would be to make the types actually match so that no casts are required. TBR=toyoshim@chromium.org BUG=750999 Change-Id: I1776d93a66db6b74175ed02548525e458be05117 Reviewed-on: https://chromium-review.googlesource.com/596348Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#491081}
-
Reilly Grant authored
This change rewrites the single Payments API layout test that uses Mojo mock services to use the new Mojo JS bindings. Bug: 699569 Change-Id: I6fa74bfb2e926d35ccf3232c87f7a0114592ce9a Reviewed-on: https://chromium-review.googlesource.com/595246 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#491080}
-
Reilly Grant authored
This change rewrites the WebShare API layout tests to use the new Mojo JS bindings. Bug: 699569 Change-Id: Id95a016765c5b101ee347f760e7cec8b74ec4b7e Reviewed-on: https://chromium-review.googlesource.com/587412Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491079}
-
dpapad authored
Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ida67f99137833161bdccc05b29f41e0f184bb7a0 Reviewed-on: https://chromium-review.googlesource.com/592132Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#491078}
-
Jiaquan He authored
This relands commit cc2fbf55, which was reverted by f87a709b. We create threads to load icons while initializing ArcPlayStoreSearchResult objects, so we have to wait for them to finish, otherwise the test will be flaky and fail the base::MessageLoop::current()->IsIdleForTesting() test in test_browser_thread_bundle.cc. Bug=736552 Change-Id: Icd054ea66367f3c28c3333522795e85475f40a1f Reviewed-on: https://chromium-review.googlesource.com/590027Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#491077}
-
Paul Jensen authored
Some devices/emulators run quickly so requests take less than 1ms, which causes some test failures. Fix them using MetricsTestUtil.assertAfter() and also clean up copies of that code. Bug: 751184 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: Icdce80479a887276b8921b4168a96c65b12d0143 Reviewed-on: https://chromium-review.googlesource.com/596073 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Miriam Gershenson <mgersh@chromium.org> Cr-Commit-Position: refs/heads/master@{#491076}
-
Andrew Grieve authored
This reverts commit cfa74c50. Reason for revert: Broke downstream compile Original change's description: > Android: Make all targets depend on specific play services targets > > Deletes google_play_services_library GN variable. This should reduce > compile times a bit, but mostly is just a good idea in general. > > Change-Id: Ia991772db4a8549490926ad46808ceefaf12853f > Reviewed-on: https://chromium-review.googlesource.com/585450 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org> > Reviewed-by: Paul Miller <paulmiller@chromium.org> > Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org> > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Reviewed-by: Michael Case <mikecase@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#490968} TBR=lambroslambrou@chromium.org,nyquist@chromium.org,mariakhomenko@chromium.org,mikecase@chromium.org,agrieve@chromium.org,paulmiller@chromium.org,jochen@chromium.org Change-Id: I404413dfe809a6918015d109524c4995ec202789 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 751199 Reviewed-on: https://chromium-review.googlesource.com/596807Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#491075}
-
Diana Gage authored
CanCut() should be renamed to CanEditText() because this method can also be used for asking a plugin if it can paste text. As before, with respect to the PDF plugin, this method returns true if focus is within a user-editable form text area and returns false otherwise. BUG=59266 Change-Id: I0ac86a86c96d64c42cc1246615b54ad3246c8513 Reviewed-on: https://chromium-review.googlesource.com/588067 Commit-Queue: Diana Gage <drgage@google.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Alexandre Elias <aelias@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#491074}
-
Reilly Grant authored
This change rewrites the Budget API layout tests to use the new Mojo JS bindings. Bug: 699569 Change-Id: I4af6e3a78c16cf4ecc6aeedc5317eaf1021ca9eb Reviewed-on: https://chromium-review.googlesource.com/595234 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#491073}
-
spqchan authored
Using field editors is finicky especially when there's multiple textfields. Using one field editor is enough, so this CL combines the name and URL field editors into one. In addition, like what the AutocompleteTextFieldEditor is doing, the field editor's fieldEditor property will reset each time windowWillReturnFieldEditor:toObject: is called so that notifications will be sent properly. Bug: 744211 Change-Id: I2367d2abc788aaf1ef3daa037c879a222440015a Reviewed-on: https://chromium-review.googlesource.com/595214Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#491072}
-
Stefan Zager authored
Previously, LayoutUnit's between NearlyMax() and Max() would round down, even though their fractional parts are > 0.5. Similarly, LayoutUnit's between Min() and NearlyMin() would round up (toward zero), even though their fractional parts are < -0.5. Change-Id: I824db066f6f45b58512a30ed32c1d280604bfefe Reviewed-on: https://chromium-review.googlesource.com/592854Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#491071}
-
Hongchan Choi authored
In some cases where the worklet cannot function, registering AudioContext is not possible. (e.g. detached iframe from the document) So BaseAudioContext needs to check the existence of worklet before registering itself. The fix is locally confirmed; ASAN does not crash anymore with it. Bug: 750502 Change-Id: Id35358b0811c7f4c3476ab62e49611a8d28bad60 Reviewed-on: https://chromium-review.googlesource.com/594852 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#491070}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8e13a185..6329c5bd Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I0d98eac5a9cfed543f3452b910e1fdfb6bfa8271 Reviewed-on: https://chromium-review.googlesource.com/596068Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#491069}
-
Sean Kau authored
We need to generate a make and model string from a PpdReference for edit to behave reasonably. So, lookup make and model from our PPD index. Because we don't want to assume anything about the relationship of the effective_make_and_model strings and manufacturer names, iterate through all of them. Bug: 685673 Change-Id: I016e2cbc45abc9ee6e8a6edf556a962c07c94541 Reviewed-on: https://chromium-review.googlesource.com/592767Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#491068}
-
DongJun Kim authored
Previous codes do not return directly even if plugin_instance and load_manager are null. It can occur crash whenever accessing each variables. This patch add return codes for avoiding crash if variable is null. BUG=NONE Change-Id: Ia5c59a9473124d6ad1ff76ee909d9396af35e96c Reviewed-on: https://chromium-review.googlesource.com/586488Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#491067}
-
Ehsan Karamad authored
When an OOPIF is hidden through changing CSS properties of its frame- owner element, the state is reported to the browser and the IPC handled in the CrossProcessFrameConnector associated with RWHV. This will also lead to a call to RenderWidgetHostImpl::WasShown/WasHidden for the corresponding local root. However, when the browser is shown all RWHVs are asked to Show which will invalidate the current state of CSS visibility. Specifically, this causes a hidden frame to generate compositor frames. This CL will add a bit to RenderWidgetHostViewChildFrame to remember its CSS visibility state. Also when RWHVCF::Show is called, the view will verify that neither itself nor an ancestor view are CSS invisible before calling RenderWidgetHostImpl::WasShown. BUG=628700 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I42c3d7f50aacd47b12f0de151c856233e8942510 Reviewed-on: https://chromium-review.googlesource.com/583729 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491066}
-
Devlin Cronin authored
api_resource_manager.h mentioned the FILE thread in a comment when discussing resources on named threads (and theoretically would have allowed its use). Update the comment to not mention the FILE thread and add explicit notes that the only allowed threads are the IO and UI threads, which are all we currently use, along with a note about how the API could be expanded, if need be. To be safe, also add a static assert to ensure that resources use no other threads. Since we currently only need IO and UI threads, this CL doesn't rearchitect anything unnecessarily. Bug: 689520 Change-Id: I5d304fd9153865af7c9778d93b34f2e20ddb95a6 Reviewed-on: https://chromium-review.googlesource.com/591688Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#491065}
-
Alex Newcomer authored
OnMousePressed now properly returns true if the event is consumed. This fixes the bug where unhandled mouse events were not propogating to the AppListView. Bug: 744778 Change-Id: I46cf1eb64994221b37ef186754d5409c5ddbd466 Reviewed-on: https://chromium-review.googlesource.com/589819Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#491064}
-
Paul Irish authored
Bug: 750767 Change-Id: I7acea758a3142f599326eb745ae16db5f020b06b Reviewed-on: https://chromium-review.googlesource.com/594633 Commit-Queue: Paul Irish <paulirish@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#491063}
-
dpapad authored
Change log: https://github.com/google/closure-compiler/compare/71ab0eecc33e2d8db1ce9ee251cbf174bddc493b...8fc82299c45b0a33f19834222acda4850fd77bc0 chrome_extensions.js: 3444857184440010d5703dfaf6617eca79b2dab4 -> dba6fb0fccdf6701490dabe08c4a8d602f4addbd TBR=fukino@chromium.org BUG=421562 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4f13ce7b6eb84d7c2ed681d387adc0c644bee721 Reviewed-on: https://chromium-review.googlesource.com/592719Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Dan Beam (no longer on Chrome) <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#491062}
-
Francois Doray authored
The FILE_USER_BLOCKING and CACHE WebThreads are deprecated an aren't used anymore. Bug: 689520 Change-Id: I9facb7539513b22cdae0688f088e9bbd10dfb73c Reviewed-on: https://chromium-review.googlesource.com/595873Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Francois Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#491061}
-
erikchen authored
Bug: 669240 Change-Id: I97cf582b97fac7aec2aa92bbdda02f5c17482c1d Reviewed-on: https://chromium-review.googlesource.com/570459Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#491060}
-
Rouslan Solomakhin authored
If a payment method manifest contains "supported_origins": ["https://alicepay.com"], then all apps from "https://alicepay.com" with valid signatures can claim support. These apps must match the package name, minimum version, and SHA256 certificate fingerprint of the web app manifest from "https://alicepay.com", which is linked as "default_applications" from a payment method that has "https://alicepay.com" origin. Bug: 735184 Change-Id: I1abdca115434769e75570dd8569facf497b6ef65 Reviewed-on: https://chromium-review.googlesource.com/585171Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#491059}
-
Erik Jensen authored
This ports the wait_for_logs method from the Python script, and forwards the pipe write fd to the Python script. Change-Id: Ief54da136894cd13e0761b9755aa3c7d51fe17f8 Reviewed-on: https://chromium-review.googlesource.com/594807Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Cr-Commit-Position: refs/heads/master@{#491058}
-
Luke Zielinski authored
This will be useful when evaluating effectiveness of ad-related reporting. Change-Id: I6b718f6d808a51961f99c5282aebd2f450b26fa1 Reviewed-on: https://chromium-review.googlesource.com/591612 Commit-Queue: Luke Z <lpz@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#491057}
-
Christopher Lam authored
This CL fixes an issue where a function that was being checked for truth should actually have been a boolean. Bug: 750558 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib3c9e2f71b865b86b6ff46cc1fb9be8c9bff11b4 Reviewed-on: https://chromium-review.googlesource.com/594946Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#491056}
-
Christopher Lam authored
This CL makes the right arrow on a bookmark item focus the menu and the left arrow go back to the item. Bug: 692302 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ida54f5e2c0995997b22489bda02bc37f6a7e1d2e Reviewed-on: https://chromium-review.googlesource.com/584207 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Tim Sergeant <tsergeant@chromium.org> Cr-Commit-Position: refs/heads/master@{#491055}
-
Emil A Eklund authored
Add drott as core OWNER following successful nomination. Change-Id: Id2b25adb545275ac6fb43acc4acf2f7781bb9f1b Reviewed-on: https://chromium-review.googlesource.com/595976Reviewed-by:
Rune Lillesveen <rune@opera.com> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#491054}
-
David Tseng authored
Test: existing tests for abstract containers and manually. Bug: 750324 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I051e5430865c8724c65860aa3e594c8a99b3b3ee Reviewed-on: https://chromium-review.googlesource.com/594227Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#491053}
-
Steven Bennetts authored
Bug: 749307 Change-Id: I041c4d7346c1e1b0980985fc62826818f3323952 Reviewed-on: https://chromium-review.googlesource.com/590069 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#491052}
-
Shivani Sharma authored
While working on the actual fix, converting these to DCHECKS Only one assert is failing in the field now: CHECK(is_partial || (!entry->writer && entry->done_headers_queue.empty())) which is being tracked in crbug.com/750725 Rest can be safely converted to DCHECKs. Bug: 751111 Change-Id: I5d7bb011115248ff101c3f9be180f1e9bb55109b Reviewed-on: https://chromium-review.googlesource.com/596187Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#491051}
-
Hajime Hoshi authored
'start' argument is no longer used per https://codereview.chromium.org/135653016 Change-Id: If9e87db7dcb6a085550e66978d203269c7090c09 Reviewed-on: https://chromium-review.googlesource.com/595297Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#491050}
-
Zhen Wang authored
This CL adds BackgroundTabLoadingMode to TabManager. So TabManager can pause loading background tabs when memory pressure gets critical. Bug: 730098 Change-Id: I1add97d91b9bb9abeeb3b483046da310ba9abff9 Reviewed-on: https://chromium-review.googlesource.com/585212 Commit-Queue: Zhen Wang <zhenw@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#491049}
-
pdr authored
This patch removes the LayerImpl references from DidUpdateScrollOffset. Instead of looking up scroll and transform property nodes with Layers, ElementId is used. Tests have been modified to ensure property trees exist before updating scroll offset. This should be true in all real cases but is not for synthetic testing scenarios. A bug has been fixed in UpdateScrollChildPosition where the scroll layer was not actually scrollable. This is a reland of [1] which was rolled out due to flakiness on telemetry_perf_unittests. This flakiness has been fixed by [2]. [1] itself is a reland of [3] which was rolled out because the active tree can have a scroll offset for an element id that is not present in the pending tree. The comment in DidUpdateScrollOffset has been updated to reflect this. This is tested in PushPropertiesToMirrorsCurrentScrollOffset. [1] https://chromium.googlesource.com/chromium/src/+/80d5a3ec9a3f7a2a94bfaa36aacc62979322125a [2] https://chromium.googlesource.com/chromium/src/+/79fe848764520df822d23d9a234a7710a7ebfe83 [3] https://chromium.googlesource.com/chromium/src/+/5657b4033dc807c8e34a76ce44f3d1e1c3afe174 TBR=enne@chromium.org Bug: 746718, 743241 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iff2431887585b624264e5699ce0373f68f458929 Reviewed-on: https://chromium-review.googlesource.com/594707Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#491048}
-
Yuzhu Shen authored
BUG=699569 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib314a69a4717fe1a932ece2f0025ec20c8c64f26 Reviewed-on: https://chromium-review.googlesource.com/592607Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#491047}
-
Mike Bjorge authored
Chromecast does not set USE_KEYRING, USE_LIBSECRET, or USE_KWALLET, so there is no benefit os using os_crypt_linux over os_crypt_posix. Use os_crypt_poxis instead because it does not require setting up an os_crypt::Config. BUG=750391 Change-Id: Ia320b6c058137d68a55af33bc8ffb9bf5226a325 Reviewed-on: https://chromium-review.googlesource.com/592847Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Mike Bjorge <mbjorge@chromium.org> Cr-Commit-Position: refs/heads/master@{#491046}
-
hkamila authored
Added the functions in the WebUI side which are going to process the proto information for the Safe Browsing database and show it in the page. Bug: 734667 Change-Id: I10d8c89318a02563b2ce803110339191fe88aac6 Reviewed-on: https://chromium-review.googlesource.com/585230 Commit-Queue: Kamila Hasanbega <hkamila@google.com> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#491045}
-
Alexander Timin authored
Currently "suspending" means two different things. Split them into pausing and stopping to avoid confusion. - Pausing refers to the state during printing dialog, javascript alerts and such. All javascript callbacks should not fire. - Stopping refers to not running timers (and potentially more) on mobile after five minutes in background. Future work needed after this patch: - Refactor task queues (i.e. get rid of suspendable one) - Rename ScopedPageSuspender. Change-Id: Ie8c0bb8339fea295ac1245d9b440769ad8452b51 Reviewed-on: https://chromium-review.googlesource.com/583450Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#491044}
-