- 17 Aug, 2020 40 commits
-
-
Rouslan Solomakhin authored
Before this patch, the platform-specific Chrome OS Android app communication code was checking the number of IS_READY_TO_PAY services in an Android app, which could cause duplication of logic between Chrome OS and Android. This patch moves the check for number of IS_READY_TO_PAY services from the platform specific Chrome OS Android app communication to the cross-platform Android payment app factory. After this patch, the logic for checking the number of IS_READY_TO_PAY services is cross-platform. Bug: 1061503 Change-Id: I72f3b3040771174d61e72bd71afe5665c5a30865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302369 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#798584}
-
Maksim Moskvitin authored
This CL adds high-level device registration logic for trusted vault together with required interfaces/skeletons. Device has to be registered in order to silently follow further key rotations in the future. Device registration means generation of device key pair and sending public key to the server. Most recent vault key must be locally available in order to register the device. Currently, device registration is supported only for active sync account. Bug: 1102340 Change-Id: If7f6034db56752622bd108598a80c3e19681ba17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339484Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#798583}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I94a75a303c4515b6634545c68a9b19dffc36756b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360032Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798582}
-
Viktor Semeniuk authored
This change updates delete password button and error description strings according to the mocks. Bug: 1075494 Change-Id: Icb08eb7531ac6914b1a826a7cb34bd0f347611c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353463Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#798581}
-
Christian Dullweber authored
This enum contains a subset of the values of ContentSettingsType. As WebsitePermissionFetcher defines which ContentSettingsType are fetched as ContentSettingsException and which as PermissionInfo, we do not need this duplicate and the code to convert between types. Bug: 1103597 Change-Id: I17667e76c5091ed6417795cdba807c78b35a85a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346425Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#798580}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a9b199b05c1f..d852ad24adc0 2020-08-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from d253278f9865 to 758b30727efc (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I0a84c82baf47072a4f459947306544d6867f7148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359766Reviewed-by:
-
Matthias Körber authored
This CL adds merging support of structured address tokens. When two profiles are merged, the substructure that corresponds to address line that is merged into the new profile is used. If the feature |kAutofillAddressEnhancementVotes| is disabled, the structure is dropped in the merging process. Change-Id: Ifc24c0a65b40fad0ae32b1001cc6560ad946cb6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353267 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#798578}
-
Victor Hugo Vianna Silva authored
The CL fixes minor UI details in passwords settings, namely: - The color of the computer icon should be grey-200. The same is done for the analog icon in the dialog to move a password to the account. - The icon is resized to be 40px size instead of 42px. - A gray separator is now displayed between the opt-in buttons and the link to the device passwords page, with a 16px spacing between them. Before the CL: https://screenshot.googleplex.com/ce9c4b15-1427-4cad-8ca0-ab009f14851d After the CL: https://screenshot.googleplex.com/5c84c711-7527-4938-a7f4-17ae9f789b45 Bug: 1115955 Change-Id: I61d76f6ca5b522bba99d27b9bc0bead6ac3f3088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352806Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#798577}
-
Yuki Yamada authored
This is a reland of f29d2ae1 ExecutionContext::NotifyContextDestroyed() has relied on the deterministic iteration order of ObserverList, so landing the original CL caused a problem. It is fixed in another CL: https://crrev.com/c/2352588 Original change's description: > Change HeapObserverList to HeapObserverSet > > The previous CL for HeapObserverList https://crrev.com/c/2060348 > addressed two things: changing HeapObserverList to HeapObserverSet and > allowing removal while iteration, and was reverted for performance > reasons. This CL only does the former and avoids performance > implications of the latter. > > This CL is for migration of NewLinkedHashSet. > See: https://crrev.com/c/2134039 > > Bug: 1100257 > Change-Id: I2426d14d77a68f200bf1398b16638e1605dd4ff1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319087 > Commit-Queue: Yuki Yamada <yukiy@chromium.org> > Reviewed-by: Keishi Hattori <keishi@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Bartek Nowierski <bartekn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797115} Bug: 1100257, 1115411 Change-Id: Id8e1b9a4141777de89bbc471f6ac8c6508a0adff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352292 Commit-Queue: Yuki Yamada <yukiy@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#798576}
-
Miyoung Shin authored
This is a reland of d8d1f551 Original change's description: > Reland "Convert WidgetMsg_WaitForNextFrameForTest to mojo" > > This is a reland of 75391394. > > Reason for reland: > - Fixed a flaky test failures in crrev.com/c/2309317 > - No changes in this CL between original & reland. > > Original change's description: > > Convert WidgetMsg_WaitForNextFrameForTest to mojo > > > > This CL uses VisualStateRequest Mojo API in FrameWidget mojo interface > > introduced at https://crrev.com/c/2178480 since > > WidgetMsg_WaitForNextFrameForTest has the same implementation with > > VisualStateRequest Mojo API notifying that the frame swap has occurred. > > > > Bug: 1071588 > > Change-Id: If317b98320ec3fb85fcf7a5d1e39f0fa202d4cde > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216145 > > Commit-Queue: Miyoung Shin <myid.shin@igalia.com> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#789910} > > Bug: 1071588 > Change-Id: I7ade2819495cddf87862054095db361e0511dcf5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309497 > Commit-Queue: Miyoung Shin <myid.shin@igalia.com> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#793839} Bug: 1071588 Change-Id: I9499c2b89eb892b9275f9fa7f0445858ea5b5bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342333 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#798575}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/00fc92a77376..467b0b16324b 2020-08-17 petermarshall@chromium.org tests: Use mocha-extensions in e2e tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101782 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia337ad643679cecad3805d8f0e268672d8f4c39c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359763Reviewed-by:
-
Yuki Yamada authored
This is to ensure vibration/vibration-iframe.html passes with another CL: https://crrev.com/c/2352292 The test should hook disconnect handler in js and make it sure that vibration stops, but it is not supported yet. Bug: 1115894, 1100257 Change-Id: Ia4934d4a4537f04bc8f43550c83c8f003c4b7683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355638 Commit-Queue: Yuki Yamada <yukiy@chromium.org> Reviewed-by:
Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
-
Chih-Hsuan Kuo authored
When --fuchsia-out-dir is not specified, the variable is NoneType. It will hit "'NoneType' object has no attribute 'startswith'" error when trying to call os.path.expanduser() with it. Bug: 1115450 Change-Id: Iaf920b47ceb664a6ad7cd4963a016d1dfb60147e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351934Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Chih-Hsuan Kuo <chkuo@google.com> Auto-Submit: Chih-Hsuan Kuo <chkuo@google.com> Cr-Commit-Position: refs/heads/master@{#798572}
-
Sreeja Kamishetty authored
16 flake occurrences of this test have been detected. List of all flake occurrences can be found at: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyagsSBUZsYWtlIl9jaHJvbWl1bUBjb250ZW50X2Jyb3dzZXJ0ZXN0c0BSZW5kZXJGcmFtZUhvc3RJbXBsQnJvd3NlclRlc3QuQ2hlY2tJc0N1cnJlbnRCZWZvcmVBbmRBZnRlclVubG9hZAw. This CL fixes the test to avoid the flaky behaviour. Bug: 1114149 Change-Id: I5d465964a2e80395da1fddf0d02d32489eaf840b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352035Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#798571}
-
Maksim Moskvitin authored
Corresponding feature was enabled by default since M84. This CL doesn't remove feature toggle itself in order to have a killswitch for couple more milestones. Bug: 1000146 Change-Id: I7041884ac82a53ffedb07ee558995ece9e5ea4fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355948 Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Anastasiia N authored
Support |getAccounts| Gaia request - send |accountsListed| message with list of emails of accounts in session. Bug: b/123630392 Change-Id: I2e920bf8a1303a17d70d74f0069a6ad9298aa86d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353348Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#798569}
-
nancylingwang authored
In Chrome OS, when the adaptive icon feature is enabled, add the white background and mask to the web app maskable icon. BUG=1083331 Change-Id: Ibf5e87cdd489a470c8ce4d4c5c54f74290652c3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359316Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#798568}
-
Peter Kasting authored
Bug: 1104532 Change-Id: If6affe249332caf832f679e7321e1852c25683d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354915Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#798567}
-
Rohit Agarwal authored
In the Account picker Dialog we had implemented an option for users to sign in temporarily via Incognito mode. This CL adds the functionality of showing an incognito interstitial when the user clicks on the incognito mode button. The incognito interstitial is currently blank expect the Learn more and Continue buttons. The functionality of these buttons and the contents of the interstitial would be followed up later. This CL also adds tests to ensure the UI elements of the incognito interstitial are shown properly and the state switch happened smoothly and didn't leave any past UI elements. TBR=bsazonov@chromium.org Bug: 1103262 Change-Id: I031b505fe347afb3265da4921c002a702a022421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346645Reviewed-by:
Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#798566}
-
Michele Mancina authored
Bug: b/156707484 Change-Id: I4903aadb5e1b2d8455c868b07c2abcca874e7c1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352822 Commit-Queue: Michele Mancina <micantox@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#798565}
-
Andy Paicu authored
Since camera and microphone are particularly sensitive permissions we should be viligent and stop streams immediately when the user revokes the permission. This CL uses the permission controller subscription functionality to listen to permission changes on the relevant origins. Each DeviceRequest will have up to 2 permission subscriptions (1 audio, 1 video). When a permission is changed to non-Granted the specific DeviceRequest is canceled. Subscriptions are removed when the DeviceRequest is deleted. Because MediaStreamManager is an IO thread class but PermissionController is a UI thread class, this CL has to do a bit of thread hoping: FinalizeStream(IO) > SubscribeToPermissionControllerOnUIThread(UI) > SetPermissionSubscriptionIDs(IO) >(maybe)> UnsubscribeFromPermissionControllerOnUIThread(UI) DeleteRequest(IO) > UnsubscribeFromPermissionControllerOnUIThread(UI) Bug: 1116435 Change-Id: I6649125e028d607eeb7ba5701b710a715addf6f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352790 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#798564}
-
Glen Robertson authored
This is used to synchronously query for available icons matching the desired parameters. Needed for app_icon_factory. Will allow other ReadSmallest[Compressed]Icon calls to take a set purpose and size instead of a vector<IconPurpose> and min_size. Bug: 1102701 Change-Id: I592db59435badbbd6e63bf6c485b505ad4c86088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355159 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#798563}
-
George Burgess IV authored
Was this intended to be a use-after-move? Or not? Only one way to find out! (This was flagged by clang-tidy as potentially buggy code, since uses of things after std::move is often a programmer error) Bug: None Change-Id: I274839476d5787820a03aa5e358fd35617a14786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202693Reviewed-by:
-
Wez authored
Add browser-test to verify that the document.visibilityState is set to "hidden" when a web.Frame is created. Also clean up FrameImpl::set_semantics_manager_for_test() not to require a fidl::InterfacePtr<>, to simplify the calling tests. Bug: 1109270 Change-Id: Ief6acc4aacb2e97d64896d30b75d2a3cf2cb9b98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355924 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d2fe803ccc6a..00fc92a77376 2020-08-17 jobay@google.com Reland^2 "eliminate initial timeout in waitForFunction" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1112692 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3a00976cae4a3105188b3ecf786c77e4e8c8fa2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359889Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5abddab6695e..3f714d9026a2 2020-08-17 jleconte@google.com Quest WebRtcTest is missing from the quest module. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1024246 Tbr: wenbinzhang@google.com Change-Id: Ie5189749a1e2a8ad6ed7b6ebda8bbf4b47a09d70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359829Reviewed-by:
-
Jonathan Mengedoht authored
The State processes the logic if .well-known/change-password is supported. Bug: 927473 Change-Id: Ib0276bb716d600aa458c38f8319b0978a3993159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346347 Commit-Queue: Jonathan Mengedoht <mengedoht@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#798558}
-
Takashi Toyoshima authored
Today, the method valid of the HTTP request is validated in Blink for user exposed APIs such as Fetch and XHR to conform the RFC 7230. But it's still possible that compromised renderers insert arbitrary ASCII strings to the method value. This patch adds the same RFC 7230 token check in the network service as the secondary check. Bug: 1110195 Change-Id: Ia99a986f82034875f7e8c0b2224f2260a99eeffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355534Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#798557}
-
Clemens Arbesser authored
This makes more sense to me, since (1) the controller shouldn't have to know, and (2) the parameters are owned by the trigger context anyway. This is a refactoring only and should have no user-facing changes. Change-Id: I06da79a4215a12df66bf5f69f7a2634ba34f43ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356504 Auto-Submit: Clemens Arbesser <arbesser@google.com> Commit-Queue: Luca Hunkeler <hluca@google.com> Reviewed-by:
Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/master@{#798556}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d882e93e416b..c4245f475be7 2020-08-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from eb85c0213d43 to a9b199b05c1f (12 revisions) 2020-08-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 00c099ff to 39dd8685 (521 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1085700,chromium:1112112 Tbr: stani@google.com Test: Test: Test: Capture and play back first 1200 frames of COD. Change-Id: I5c1fb9b7c5bdc4ed5c51d5c0c18b397ac636f053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359750Reviewed-by:
-
Alexandre Courbot authored
This reverts commit 6f7b3d69. Reason for revert: segfaults on tast.arc.VideoDecodeAccelVDVDA.* Bug: b:163920993 Test: video_decode_accelerator_tests --use_vd_vda passes on Nocturne. Original change's description: > RELAND: media/gpu/vaapi_video_decoder: keep allocated VASurfaces alive > > The original CL was reverted due to crashes in betty initialization: > betty is a VM which doesn't support VA, so the VideoDecoderPipeline > constructed-destructed a VaapiVideoDecoder, hitting an unprotected > nullptr |vaapi_wrapper_| in dtor. Fix in crrev.com/c/2339494/2..3. > > TBR=andrescj@chromium.org > > Original CL description ----------------------------------------------- > > Certain platforms and codecs suffer from horrible artifacts (Intel BYT, > H264) or crashes (Intel BSW/BDW, VP9). This was traced to some kind of > error in the tracking of the VASurfaces lifetime in the driver: every > time we get a new resource from the pool to decode onto, this is > imported into libva as a VASurface: this works fine almost everywhere > but doesn't play well in these old platforms (see CreateSurface() body). > > This CL adds a map that keeps the ref-counted VASurfaces alive and > indexed by the unique GpuMemoryBufferId until the VA Context is > destroyed. In so doing, we're basically observing the "contract" of > va.h vaDestroySurfaces() [1] "Surfaces can only be destroyed after all > contexts using these surfaces have been destroyed". > > [1] https://github.com/intel/libva/blob/libva-2.0.0/va/va.h#L1134 > > Bug: b:142019786 b:143323596 > Change-Id: I593763ec02dad7bba240c8fed9e71de21637a231 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339494 > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795026} TBR=mcasas@chromium.org,jchinlee@chromium.org,andrescj@chromium.org Bug: b:142019786 b:143323596 Change-Id: Ibb0ccf74c2c540a005a1f26794fca9b2f85a6ae6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359598 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#798554}
-
Hitoshi Yoshida authored
This CL adds checking if |config->profile| is available before accessing it. Bug: 839389 Change-Id: I92214e32575f86c899c4a6fc3aeea189877118d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358941 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/5f4456e3c52f..807e4fa951b9 2020-08-17 pdfium-autoroll@skia-public.iam.gserviceaccount.com Roll Jinja2 from 3f90fa05c857 to 61cfe2ac6c91 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I0f684505c690cb758d929aeb91de1beb253570bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359683Reviewed-by:
-
Jit Yao Yap authored
This CL adds a Mojo service for Remote Apps. The service is a thin layer which mainly forwards calls to the RemoteAppsManager. Only extensions under the imprivata_in_session_extension behavior feature have access to the API. Bug: 1101208 Change-Id: Ieaf9f6839ba22d86cb3fba8fa64afe49ade8e6ce DD: go/remote_apps_mojo Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332615 Commit-Queue: Jit Yao Yap <jityao@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4ae1505c..f8df7e0a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ief440491b7882dd7dfae0a8338c4fb912a0a307c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358580Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798550}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9ae6d7f2ee9e..a9b199b05c1f 2020-08-17 cnorthrop@google.com Capture/Replay: Add ability to override entry points If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Test: Test: Capture and play back first 1200 frames of COD. Change-Id: I18ca50a17cd334aff13c36e7a4ec171252768453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359677Reviewed-by:
-
Thanh Nguyen authored
This CL: 1. Use vector icons for zero state file results. 2. Remove unnecessary pngs 3. Refactor file icon utils. Bug: 1067326 Change-Id: Ia64a505f4d40c7f8fcf981d7e6b976f7555de83c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355351 Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Austin Tankiang <austinct@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#798548}
-
Zhuoyu Qian authored
This patch rename UpdateShortcutInfosFromManifest() to UpdateShortcutsMenuItemInfosFromManifest(). And rename CreateShortcutInfos() to CreateShortcutsMenuItemInfos(). Bug: 1100751 Change-Id: Ibffe82bcac99676d6ca89f63df0588d776efae5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354126Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#798547}
-
Maggie Cai authored
Currently if we try to launch default arc app (e.g. play store) from intent picker when play store disabled, nothing will happen. This CL adapts the functionatliy to enable play store in this scenario. BUG = 1096903, 853604 Change-Id: Ib1efaba445d0dc957b2c425c61ffee164f838dee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351350Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7491e8b30f77..d882e93e416b 2020-08-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from d315022be5b7 to 5e9b29fab92d (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: stani@google.com Change-Id: I1e1b9d434b22416bf5def211319890efcf35faab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359682Reviewed-by:
-
