- 22 Jan, 2020 40 commits
-
-
Mason Freed authored
The [1] CL enabled the FormControlsRefresh feature by default for Windows, Linux, and ChromeOS. In the process, many layout tests were disabled, because the form controls have a different appearance with the feature enabled. This is one of several patches rebaselining those disabled tests. SHERIFFS: If one of the tests touched in this CL becomes/is flaky, *please* add it to TestExpectations beneath the section for bug 1035582, and mark it with a *new* bug number. At this point, any further failing tests are flaky on their own, not because of this rebaseline. Thanks! [1] http://crrev.com/c/1967608 Bug: 1035582 Change-Id: Icf39d2aca9cf8c3d12c3f4e0709e3601ef30a014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008353 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#734074}
-
Mohammad Refaat authored
Use SessionRestorationAgent to restore the session directly using the browser instead of calling it through tabModel. Bug: 1010164, 783777 Change-Id: Ib1dd37941eccd3e85d0c6c72c2d463ea2cfc69f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007519Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#734073}
-
Oleh Lamzin authored
Introduce wilco_dtc NetworkContext to be able to continue establish TLS connection when server ask client authentication certificate. Bug: b:144545936 TEST=browser tests TEST=verified manually on the device that we are able to setup connection and receive response from the server Change-Id: I039c683fed6859641ea42a1bb79536a7629419de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1964071 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:Pavol Marko <pmarko@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#734072}
-
Alexei Svitkine authored
Bug: 1037118 Change-Id: If86843e59b7880878e39eda8d39aad72208f577e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003399Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#734071}
-
Ben Wagner authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/50b013871c53..e5038be70414 $ git log 50b013871..e5038be70 --date=short --no-merges --format='%ad %ae %s' 2020-01-19 wl Update all copyright notices. 2020-01-04 wl [base] Fix `FREETYPE_PROPERTIES=type1:hinting-engine=adobe`. Created with: roll-dep src/third_party/freetype/src R=bungeman@chromium.org,drott@chromium.org CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng Change-Id: Id71ab1c45b05cb211948381805f3fe2a491845d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014054 Commit-Queue: Ben Wagner <bungeman@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#734070}
-
Marc Treib authored
Before this CL, the pref kAccountStorageOptedInAccounts was a map from hash of account ID to bool. Now it is generalized to a map from hash of account ID to dictionary, and the previous bool is just one entry in the dictionary. This will make it easy to add other account-keyed settings later. Since the previous pref was never launched, there's no need for any migration logic. Bug: 1035407 Change-Id: Ib60f30c644bdf457da841b709c433f35572df543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014449 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#734069}
-
Matt Menke authored
It's only used on Cast, which we're not currently focusing on, but presumably we'll roll out network isolation there at some point as well. Bug: 997049 Change-Id: Ic9d2845fa7010c06030046d770cc8122aa462869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994430 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#734068}
-
George Steel authored
Fix of https://chromium-review.googlesource.com/c/chromium/src/+/1986325 due to ClusterFuzz DCHECK failure (flaky). SVGElement::RemovedFrom was not tearing down elements_with_relative_lengths_ correctly when those references crossed a shadow root. Downgrade the SECURITY_DCHECK on the relative lengths list to a regular DCHECK as it was preventing dangling pointers to Elements in the pre-oilpan days and is no longer protecting against any kind of security issue (the pointers are now WeakMembers). Bug: 1043184 Change-Id: I0ba614a0217dea4df80a743b0628f7fe94117cd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008624Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#734067}
-
Robbie Gibson authored
The reason the DCHECK was being hit is because this forwarder wasn't being properly cleaned up. Fixed: 1044606 Change-Id: Iae58f7af86a6bc0af57a6f93756c0954fba43413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013132 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
-
Sebastien Lalancette authored
See details in bug (flakes portal link, sample failure). TBR=nicolaso@chromium.org Bug: 1044619 Change-Id: I10c5cca2dab7f90749e6e603db288596daf00bd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013757Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#734065}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ed94ccdde306..7d45184d4baa git log ed94ccdde306..7d45184d4baa --date=short --first-parent --format='%ad %ae %s' 2020-01-22 jmadill@chromium.org Vulkan: Fix naming in CommandGraphResource. 2020-01-22 aleino@nvidia.com Reduce fail expectations dEQP-GLES31.functional.program_interface_query.buffer_variable.* 2020-01-22 aleino@nvidia.com Reduce D3D11 skips in dEQP-GLES31.functional.program_interface_query.buffer_variable.* 2020-01-22 sugoi@google.com Extensions suffixes Created with: gclient setdep -r src/third_party/angle@7d45184d4baa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: timvp@google.com Change-Id: I5b1b46619d6ca30110cf1348e137dcb2fc8d2405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014674Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734064}
-
Bailey Berro authored
Extends metric capturing usage of Screen Lock keyboard shortcuts until the end of June. Bug: 1041515 Change-Id: I9b39dc2e4d4975cbd25b27cb2ae262e04900ed3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997765 Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#734063}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c8ebd366bc29..b9cc8d75a2ad git log c8ebd366bc29..b9cc8d75a2ad --date=short --first-parent --format='%ad %ae %s' 2020-01-22 phoglund@google.com Fix gn gen --check breakage on the unit test target. Created with: gclient setdep -r src/third_party/catapult@b9cc8d75a2ad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029452 Tbr: nuskos@google.com Change-Id: I33e6ad9870edac3075ba3e264c486683904d9aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013559Reviewed-by:
-
evliu authored
This CL adds a pre hook for the SODA sandbox that dlopens the libsoda.so and grants the necessary broker file permissions required by the speech recognition library. Bug: 1039824 Change-Id: I8999cec6b6e8c29b7fbe4dc47dff2b971a6e963d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995953Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#734061}
-
Xianzhu Wang authored
The only test ScrollingCoordinatorTest.UpdateUMAMetricUpdated is duplicated with the same test in scrolling_test.cc. Most of the tests in scrolling_coordinator_test.cc were moved into scrolling_test.cc in crrev.com/b2a068a8 because the tests are not just unit tests of ScrollingCoordinator. This test was to be kept in scrolling_coordinator_test.cc but was also copied unintentionally into scrolling_test.cc. This CL just removes scrolling_coordinator_test.cc for simplicity. Change-Id: I4f7d3010f7a22d56ec225e9418773730af860a24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013805 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#734060}
-
Nikita Podguzov authored
This CL adds: * IDL declaration of submitJob() function * Its implementation Bug: 996785 Change-Id: Ic3077e6c5999d83578e6e0e48338a6430f7747e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959979 Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#734059}
-
Pâris MEULEMAN authored
The spec states about COEP "If creator is not null, set document’s embedder policy to creator embedder policy.". This is done in this patch. Note: This is required for COOP, because it cares about COEP in the case of "same-origin" and needs it to be available on the initial empty document of a new popup. Also adds a WPT about a potential COEP exploit using WindowProxy to circumvent COEP restrictions on fetching. Bug: 922191 Change-Id: Ie3097618be825c5031449d997970e33fad3d4f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007747 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#734058}
-
Aran Gilman authored
This should either fix the attached bug or at least help with debugging by DCHECKing when the icon is destroyed without being removed from all observer lists. Bug: 1017341 Change-Id: I8a7457f7f82f3dc4936fb60112742af2a05a7d70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006468Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#734057}
-
Elly Fong-Jones authored
These both have unqualified usernames but the actual correct email addresses are at domains other than chromium.org. Bug: None Change-Id: If1e1153fa53cd43b24008c43b2892025a74bc554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014103Reviewed-by:
Cliff Smolinsky <cliffsmo@microsoft.com> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#734056}
-
Elly Fong-Jones authored
Leaving _node set while posting the notification can lead to VoiceOver re-entering AXPlatformNodeCocoa while the AXPlatformNodeBase it corresponds to is already being destroyed. Bug: 1037855 Change-Id: I8ff959998f05821b5f258d32f4a9328cb29d234c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014104Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#734055}
-
Alex Ilin authored
This CL marks org.chromium.android_webview.test.AwAutofillTest#testPageScrollTriggerViewExitAndEnter and org.chromium.android_webview.test.AwAutofillTest#testPageScrollTriggerViewExitAndEnter__multiprocess_mode as flaky. TBR=michaelbai@chromium.org Bug: 1033179 Change-Id: I5829718f47165867ac1041bf8d24e972f55f1948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014941 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#734054}
-
Antonio Gomes authored
Today, this mojo call comes from LocalFrameClientImpl::DispatchDidHandleOnloadEvents(), which used to make sense when RenderFrameImpl::DispatchDidHandleOnloadEvents() used to send the respective message to content::mojom::FrameHost interface, and calling observers. Now that this mojo message got moved from content.mojom.FrameHost to blink.mojom.LocalFrameHost [1], it seems logical to call it from out of LocalFrameClientImpl class. BUG=1043760 R=dtapuska@chromium.org Change-Id: Ie3917cca5fa687a3d7ede91970321c6d1aa8f3a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014763Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#734053}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d59053987a27..b19c78ebad84 git log d59053987a27..b19c78ebad84 --date=short --first-parent --format='%ad %ae %s' 2020-01-22 robertphillips@google.com Add compressed backend textures to Metal Created with: gclient setdep -r src/third_party/skia@b19c78ebad84 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC benjaminwagner@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: benjaminwagner@google.com Change-Id: Icd9a409d1bd0546f8af719acde6f26c8a7d18fe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014673Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0a5ac419555b..84dafa149509 git log 0a5ac419555b..84dafa149509 --date=short --first-parent --format='%ad %ae %s' 2020-01-22 ilkos@google.com Merge "Filter empty symbols" 2020-01-22 lalitm@google.com Merge "ui: add global slice tracks" 2020-01-22 buss@google.com Merge "Add link to prebuilt binaries/wrapper." 2020-01-22 fmayer@google.com Merge changes Ie5ab30a4,I3d3577d1 Created with: gclient setdep -r src/third_party/perfetto@84dafa149509 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I4835429f5772fa339c316f8fea959f5e6645ff26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014670Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium b6c28694. With Chromium commits locally applied on WPT: 0f8fd66b "[WPT/common/security-features] Support sub projects and split referrer-policy 4K tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: Ibfbcee6de7585c24153abfc460346d261775cbe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014800Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734050}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/2cdf87411246..5f411e4e022c git log 2cdf87411246..5f411e4e022c --date=short --first-parent --format='%ad %ae %s' 2020-01-22 kimjae@chromium.org build_dlc: Selective preloading of DLC(s) 2020-01-22 mmortensen@google.com Add goma log handling to the Sysroot.InstallPackages endpoint. 2020-01-22 bpastene@chromium.org chrome_committer: Apply CQ+2 during the initial git-cl-upload. 2020-01-22 dhaddock@chromium.org Disable paygen_au on jetstream devices. 2020-01-21 chrome-bot@chromium.org Update config settings by config-updater. 2020-01-21 saklein@chromium.org Build API config: Use a proto-based configuration 2020-01-21 mmortensen@google.com Generate updated sysroot_pb2.py and common_pb2.py including goma fields. 2020-01-21 chrome-bot@chromium.org Update config settings by config-updater. 2020-01-21 jacobraz@google.com flash_ap: update volteer support, linter cleanup Created with: gclient setdep -r src/third_party/chromite@5f411e4e022c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I70ed8739210a48cd3f9c3d465e2b29fa1efa0f1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014672Reviewed-by:
-
Patrick Noland authored
This CL also moves some custom IPH code from ToolbarManager to ToolbarButtonInProductHelpController. Bug: 865801 Change-Id: I49ea9a8954c17be39d99e598208a5b4e78f9fa31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995466 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#734048}
-
Sebastien Lalancette authored
Test: BrowserNavigatorTest.ReuseRVHWithWebUI See bug for falkiness dashboard link and sample failure. TBR=ellyjones Bug: 1044335 Change-Id: Ia5c8742a82aa8f750d46f011326a0fa2edeaee24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013756Reviewed-by:
-
Christopher Cameron authored
Change viz::Display, viz::mojom::DisplayPrivate, and viz::SurfaceAggregator to take a gfx::DisplayColorSpaces. Change Windows' gfx::DisplayColorSpaces to indicate that opaque HDR content should use PQ, while transparent HDR content should use sRGB-linear. On Windows, the decision of which HDR space to use was made both in display::ScreenWin and in the ui::Compositor. The reason for the latter is that, when alpha is needed, we cannot use a 10-10-10-2 format, and have to promote ourselves up to half-float. Move this logic to be in viz::SurfaceAggregator. This logic will further be updated to dynamically determine if each RenderPass has HDR or WCG content, and upgrade/downgrade its buffer format accordingly. Add tests to ensure the new SurfaceAggregator behavior, and delete old tests of the ui::Compositor intervention. Bug: 1037954, 958166 Change-Id: I960a1c247efc5489f1f85ddf32afae68822d67f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008134Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#734046}
-
Robert Ma authored
This CL relands the test portion (web_tests/*) of r1979258, and removes external/wpt/css/compositing from W3CImportExpectations. It is marked as No-Export because the tests were successfully upstreamed to WPT and are not deleted (this is the expected behaviour; W3CImportExpectations does not affect upstream): https://github.com/web-platform-tests/wpt/commit/4209d7961bab7dce31baab0918fa9f6dcd74bd8d No-Export: True Bug: 1044405 Change-Id: Ie59c35118de96256816fa35f20aca1c10f5759b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013476 Auto-Submit: Robert Ma <robertma@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#734045}
-
Jochen Eisinger authored
Bug: 927509 Change-Id: I40a99ea449f51fa20553a480de18768575290f68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013124Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#734044}
-
Eric Seckler authored
When depending on multiple similar proto_library targets, each target can create its own public_config. In the case of perfetto, this adds up to about a dozen configs, each adding the exact same include path. Because gn doesn't eliminate duplicate include paths (crbug.com/gn/142), these configs end up adding duplicate -I command line flags to build commands. On some bots, this recently caused us to exceed command line length limits (see crbug.com/1043279). This patch adds an invoker argument to the proto_library gn template, which disables the public_config propgation of the proto_library target and will allow perfetto to define and propagate a separate public_config instead to avoid this duplication. Bug: 1043279, gn:142 Change-Id: Ifa68c164b2b4c631bdaf98f63ba5bf7537e8e166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010860 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#734043}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/de885c91d53b..afc469d68c53 Created with: gclient setdep -r src-internal@afc469d68c53 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1022981 Tbr: jbudorick@google.com Change-Id: I6e8eb69a8c9af48e7e19726d385356ee6b72913f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014671Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734042}
-
Tanmoy Mollik authored
Tests in SyncAndGooglePreferencesTest start settings activity. So they should be annotated with @LargeTest and @Feature({"Sync", "Preferences"}). Bug: 1036314 Change-Id: I459a71041c5350c1d1c1e5b953a205436969f260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002814 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#734041}
-
Eric Stevenson authored
So that we don't accidentally add new targets that don't set the variable (which is required for compile deps and wrapper scripts to work properly). Change-Id: I8541f2fe83bd7ced7a9d215b415c009abda37468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003568Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#734040}
-
Colin Blundell authored
We are in the process of componentizing CaptivePortalService. As part of this we need to eliminate its sending of a notification: as there is no enum of notification types in //components and we don't want to introduce one when notifications have been deprecated for 7+ years. This CL starts the process of that elimination by introducing the ability to register for callbacks when CaptivePortalService completes a query, notifying the callbacks at the same time as the notification, and porting a couple of initial consumers to validate the approach. There remain a handful of consumers to be converted. Bug: 1030692 Change-Id: I2bc682a092fac0c3ab2ebf4b152d6ee62e80d324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010775 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Jarryd authored
Extends the life of quota metrics that will be used for analysis around upcoming storage management changes. Bug: 997258 Change-Id: I96991c7087dc2ed038c8f4f8295e0e4e3618059f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013022Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#734038}
-
Stephen Nusko authored
The deprecated TRACE_EVENT_ASYNC* macros have been superseded by TRACE_EVENT_NESTABLE_ASYNC*. Updating to the new macros is mostly straight-forward, except in cases where STEP_INTO/PAST macros were used extensively (ui/latancy doesn't appear to use any): In those cases, the steps have been converted into nested sub-events. Bug: 1038710 Change-Id: Ic9d0c503aff5b0111c958e90c8fee7c7fb075fdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014503Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Timothy Dresser <tdresser@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#734037}
-
Clemens Backes authored
The comment does not make sense any more after https://crrev.com/c/2013046. It should have been removed together with that CL. R=jsbell@chromium.org No-Try: true Change-Id: I7fcaa85f66377bbefe3527313e7a6f72ddca9a91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014923 Auto-Submit: Clemens Backes <clemensb@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#734036}
-
Denis Kuznetsov authored
Bug: 955194 Change-Id: I4f269e48f09bebe02faed24de8396b9f67486f71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012940Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#734035}
-
