- 24 Oct, 2018 40 commits
-
-
Theresa authored
BUG=898529 Change-Id: Iff27d791065c04700d379cf3d60b1210ac24d477 Reviewed-on: https://chromium-review.googlesource.com/c/1298351Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#602469}
-
Theresa authored
Not all users have suggested articles, so for technical accuracy we're dropping "and view suggested articles" from the clear tab in-product help string. BUG=898598 Change-Id: I75861c97cae32dd5a18007a0017815b4f0ab6e18 Reviewed-on: https://chromium-review.googlesource.com/c/1298226 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#602468}
-
Sylvain Defresne authored
PrimaryAccountMutator is a new API that wraps the method related to the mutation of the signed-in state of the primary account. It will become the recommended API to set and clear the primary account when migrating to the Identity Service API. The PrimaryAccountMutatorImpl methods are not implemented yet. They will be implemented in follow up CLs (and corresponding tests added). This is done to limit the size of the CLs. Design document is available at: https://docs.google.com/document/d/1YVx-SW0VbrAnek69PVxQ1ie71VewcuKvf8JvIzFfuRQ/view Bug: 889902 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I2acd1ebdccadfebb855e55f4e9b78c148557ed85 Reviewed-on: https://chromium-review.googlesource.com/c/1286852Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#602467}
-
Daniel Cheng authored
It's more memory efficient than std::set. Also changes the sets to hold StringPiece instead of std::string, since the sets only hold string constants. Change-Id: Ia5e8823e7285863724bb4a1956afaff2bc6186ea Reviewed-on: https://chromium-review.googlesource.com/c/1298359Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#602466}
-
Katie D authored
Adds user action logging for dwell action types. Changes dwell delay logging so that it is logged each time the user changes the delay pref. It will still be logged when the AutoclickController starts, so we should still get events at startup as well. Bug: 894907 Change-Id: Iedcf7c40385e58e1e29e354870f5c839c5c715c7 Reviewed-on: https://chromium-review.googlesource.com/c/1287265 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#602465}
-
Scott Graham authored
Bug: 808287 Change-Id: I6a8e1af6e4073a3a064a94976b17271f9d7330ca Reviewed-on: https://chromium-review.googlesource.com/c/1298348Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#602464}
-
Joe DeBlasio authored
This CL allows the interstitials browser tests to verify that displayed interstitials are the ones expected. Previously, tests only compared the page titles, which were often shared between different interstitials. Bug: 891096 Change-Id: Ieb5e9f9a90739cf35f2357655d5e0c31a2a68c91 Reviewed-on: https://chromium-review.googlesource.com/c/1297578Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#602463}
-
Xianzhu Wang authored
Scrolling background is the background painted on the scrolling contents layer. Previously we used the scrolling contents graphics layer as the display item client to give the background proper visual rect, but that didn't work for SPv2 which doesn't have the graphics layer. Now use a special display item client for scrolling background. This is a prerequisite of fixing SPv2 scrolling background. Bug: 732611 Change-Id: I3518e69b5985b7c6124ec3e8f9ec9a66005d5eb6 Reviewed-on: https://chromium-review.googlesource.com/c/1297131 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#602462}
-
Theresa authored
The EoC toolbar button used to be wrapped in a FrameLayout. Removing the FrameLayout broke the tab switcher overlay in RTL. This CL mirrors the tab switcher button drawing logic for the experimental button. This also updates when we capture a new texture with or without the experimental button to wait until animations are finished. BUG=898441 Change-Id: I42759ffb3a836ec4a74ec996c070607902517324 Reviewed-on: https://chromium-review.googlesource.com/c/1297978Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#602461}
-
Peter Kasting authored
This is part of an effort to move away from direct reliance on the switches, so they can be renamed or removed. Bug: none Change-Id: I64c5a521f7d6e6e148d0d4329a1710d8efa3b69b Reviewed-on: https://chromium-review.googlesource.com/c/1297582Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#602460}
-
Erik Chen authored
The keyboard shortcut was behaving incorrectly and triggering the shortcut for ctr+tab. This was fallout from the change of the menu item to use "ctr+shift+->" as the key equivalent, and AppKit's funky handling of ctr+shift+tab to create "end of medium" instead of "horizontal tab". Bug: 896389 Change-Id: Iea85c69077874201b6e3608771aa9fcbfa368aef Reviewed-on: https://chromium-review.googlesource.com/c/1298187Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#602459}
-
David Bokan authored
SyntheticGestureTargetAura::GetTouchSlopInDips was subtracting 1 from the slop configuration value. However, GestureDetector::IsWithinTouchSlop would incorrectly return true if we scrolled one pixel past the slop in this case. Additionally, there's no need to ceil the touch slop adjustment in SyntheticSmoothMoveGesture since we're sending float deltas. Bug: 897520 Change-Id: I35725c603910b3c694d9eddf5fde31f1f6b9cf2e Reviewed-on: https://chromium-review.googlesource.com/c/1293171Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#602458}
-
Zhenyao Mo authored
This reverts commit be9cde47. Reason for revert: broke media lab bots Original change's description: > Allow loading SwiftShader after sandbox init on Mac > > We could blacklist WebGL based on GL version, which is after creating a context. > > Right now this will trigger a failure and GPU process will exit and then > relaunch with SwiftShader mode, which pre-load SwiftShader before sandbox init. > > So users will not notice, but this GPU process exit and relaunch is less optimal > and unnecessary. > > BUG=897914 > TEST=manual > R=kerrnel@chromium.org,kbr@chromium.org,sugoi@chromium.org > > Change-Id: Idcd018ca1f2e5161002cdae4563462c76316c606 > Reviewed-on: https://chromium-review.googlesource.com/c/1297481 > Reviewed-by: Alexis Hétu <sugoi@chromium.org> > Reviewed-by: Greg Kerr <kerrnel@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Zhenyao Mo <zmo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#602391} TBR=sugoi@chromium.org,zmo@chromium.org,kbr@chromium.org,kerrnel@chromium.org,rsesek@chromium.org Change-Id: Ib9ab22645f1727249db8f3f9a007cc76402e6067 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 897914 Reviewed-on: https://chromium-review.googlesource.com/c/1298419Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#602457}
-
Kenneth Russell authored
Tbr: mcasas@chromium.org No-Try: True Bug: 865957 Change-Id: I219fb646bc76265e0a42b7ffbcd47bd99d71d127 Reviewed-on: https://chromium-review.googlesource.com/c/1297984 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#602456}
-
Asanka Herath authored
Prior to 2d0226c9 the AsyncDns resolver didn't return the correct canonical name for an address. To work around that limitation, HostResolverImpl routed any request with the CANONNAME flag to the system host resolver. Now that AsyncDns resolver returns the correct canonicalized name, it can once again start servicing requests that have the CANONNAME flag. Bug: 883969 Change-Id: I009ae1b22f4d9a78bb3a905158d2686283626350 Reviewed-on: https://chromium-review.googlesource.com/c/1298175Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#602455}
-
Kenneth Russell authored
Tbr: nednguyen@google.com No-Try: True Bug: 898602 Change-Id: I7da27e4ddff3ff4f15f1b56c3067ff42ecb48a05 Reviewed-on: https://chromium-review.googlesource.com/c/1298197 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#602454}
-
Dirk Pranke authored
Change-Id: Ib45d3f86a0b68f6d0b10847cf7e3859b640e34a3 Reviewed-on: https://chromium-review.googlesource.com/c/1292403 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#602453}
-
wutao authored
This patch adds two shortcuts using `search' to go to beginning/end of document. Bug: 896907 Test: manual. Change-Id: I517f32b89e4e0ea5ad31d54e18f44d591e34531b Reviewed-on: https://chromium-review.googlesource.com/c/1296548Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#602452}
-
siyua authored
Changed the title, and added a body text. Uploaded a screenshot in the bug. Note that the body text color is incorrect (should be Google Grey 700) due to crbug.com/896891. Bug: 880809, 897998 Change-Id: I5bf1cf07c6c86bb5a985811485edcb61d14d2610 Reviewed-on: https://chromium-review.googlesource.com/c/1294722Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#602451}
-
Jacob Dufault authored
- Renamed FingerprintUnlockState to FingerprintState - FingerprintState no longer has AUTH_FAILED and AUTH_SUCCESS. FingerprintState instead determines if fingerprint is enabled. A seperate mojom method is used to notify the ash that an authentication attempt has taken place. - Reordered fingerprint mojom method so it is next to PIN - Eliminated ScreenLocker::FingerprintState, which duplicated the mojom type - Fixed a bug in screen_locker.cc where timing out PIN depended on fingerprint being enabled. - Backlights being forced off is now reset only after an authentication attempt. This means that fingerprint timing out will not turn the display on. - Lock screen is now initialized with full fingerprint state instead of a bool. - Renamed some methods to increase clarity Bug: 897226 Change-Id: I841c7bbdd32730532148ddae96e1b490bee4eb0a Reviewed-on: https://chromium-review.googlesource.com/c/1291998Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#602450}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d86805176f39..02d42b65b779 git log d86805176f39..02d42b65b779 --date=short --no-merges --format='%ad %ae %s' 2018-10-24 thestig@chromium.org Add CFX_Matrix::AsTuple(). 2018-10-24 thestig@chromium.org Implement FPDFImageObj_GetMatrix(). 2018-10-24 thestig@chromium.org Implement FPDFPageObj_GetLineCap(). 2018-10-24 thestig@chromium.org Implement FPDFPageObj_GetLineJoin(). 2018-10-24 thestig@chromium.org Check CPDFFooObjectFromFPDFPageObject() result. Created with: gclient setdep -r src/third_party/pdfium@02d42b65b779 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I5076e2a09925c7c4691ed0cb757233f6735b5c3c Reviewed-on: https://chromium-review.googlesource.com/c/1298160Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602449}
-
Robert Sesek authored
Use wasIntentSenderChrome instead. Bug: 832124 Change-Id: I40586988a3ae88c001332c00d8424ca39df4b1e3 Reviewed-on: https://chromium-review.googlesource.com/c/1297268Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#602448}
-
Robert Sesek authored
Change-Id: I90ee93d91b83d37eb9618165749455fbe5252422 Reviewed-on: https://chromium-review.googlesource.com/c/1298185Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#602447}
-
Kenneth Russell authored
Functionality was lost during a recent refactor. Tested manually. Tbr: nednguyen@google.com Bug: 898528 Change-Id: Ia850e2c74e2dc353e8c18fbca8b90d3efef21908 Reviewed-on: https://chromium-review.googlesource.com/c/1298314Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#602446}
-
Oksana Zhuravlova authored
This change removes the skip_deps_check option since mojom target dependency check now allows transitive dependencies. Change-Id: I40e1a5f024bdb8456fe44e7e419a6ef9cb23e057 Reviewed-on: https://chromium-review.googlesource.com/c/1291993 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#602445}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/62ae178357b7..44a262a6aae2 git log 62ae178357b7..44a262a6aae2 --date=short --no-merges --format='%ad %ae %s' 2018-10-24 srte@webrtc.org Declares BitrateAllocator methods const. 2018-10-24 mbonadei@webrtc.org Add missing directory to api/DEPS and PRESUBMIT.py. Created with: gclient setdep -r src/third_party/webrtc@44a262a6aae2 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7f3ef261b431c4947cdbfd339f990e2c0a146b7c Reviewed-on: https://chromium-review.googlesource.com/c/1298153Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602444}
-
Christian Biesinger authored
Due to https://chromium-review.googlesource.com/c/chromium/src/+/1296491 See log: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20CFI/10902 TBR=mstensho@chromium.org Bug: 898540 Change-Id: I2e3e3ead85602b111ca423cb89b1a0ce2813f170 Reviewed-on: https://chromium-review.googlesource.com/c/1298015Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#602443}
-
mrefaat authored
This is not used at all. Bug: 898380 Change-Id: I67a86391bb99204932f2bf3f7b680f0908d22801 Reviewed-on: https://chromium-review.googlesource.com/c/1298237Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#602442}
-
Ben Pastene authored
This reverts commit 4aa59465. Reason for revert: High telemetry_perf_unittests failure rate on android-marshmallow-arm64-rel CQ bot See crbug.com/898646. Original change's description: > [perf] Add browse:social:tumblr_infinite_scroll system health story > > Bug: 878390 > Change-Id: Ibdaeafbc6d32970641a5a8562125eb15b0bfedf7 > Reviewed-on: https://chromium-review.googlesource.com/c/1277659 > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > Cr-Commit-Position: refs/heads/master@{#602346} TBR=ulan@chromium.org,perezju@chromium.org Change-Id: I5a656976e63444aa583d1c35eea62c34da27a551 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 878390 Reviewed-on: https://chromium-review.googlesource.com/c/1298415Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#602441}
-
Asanka Herath authored
Valid DNS responses need the QR bit set to 1. See https://tools.ietf.org/html/rfc1035#section-4.1.1 This CL adds verification to the AsyncDNS resolver to weed out invalid responses. R=mmenke@chromium.org Bug: None Change-Id: Ieda75f13394564f4617a0752d5740c9feccca850 Reviewed-on: https://chromium-review.googlesource.com/c/1292372 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#602440}
-
Mitsuru Oshima authored
Bug: 898534 Test: manual: no functional/visual change Change-Id: I32aebe966f4a9fc22f51652ddf797583909ded9f Reviewed-on: https://chromium-review.googlesource.com/c/1298122 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#602439}
-
Ben Pastene authored
TBR=jbudorick Bug: 893614 Change-Id: I87127f02cfb44c1be8c8c6fa6d80544b121bcc4d Reviewed-on: https://chromium-review.googlesource.com/c/1298328Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#602438}
-
David Jacobo authored
TouchSelectionControllerClientAura should include set, also removing an unnecessary semicolon. Bug: None Test: Build. Change-Id: Ie12084e61cce65a71fcdd6a7878cb3cbd0293270 Reviewed-on: https://chromium-review.googlesource.com/c/1297980Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#602437}
-
Sergey Ulanov authored
Also removed GetFilterStatus and SetFilterStatus from the Netstack interface. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=kmarshall@chromium.org Change-Id: I17df2c2cb63d27a421fda742d5fd8a3fcbae5036 Reviewed-on: https://chromium-review.googlesource.com/c/1298322 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#602436}
-
Gauthier Ambard authored
This CL sets the fullscreen progress of the toolbar to 1 (meaning fullscreen isn't enabled) when the toolbar view is created. It allows the constraints to be correctly positioned the first time the toolbar is shown. Bug: 895870 Change-Id: I481342521cd1b396f4d00c9f6dcc2a8a3f4cb1eb Reviewed-on: https://chromium-review.googlesource.com/c/1297975 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#602435}
-
Quinten Yearsley authored
This is a change to the chromium/src tricium project config, which would make it so that Tricium jobs are only run for members of the given group (project-chrome-tryjob-access). Others could potentially manually run jobs; this would affect the behavior for analysis run when polling gerrit for new patchsets. Related code: https://cs.chromium.org/chromium/infra/go/src/infra/tricium/appengine/gerrit/poll.go?l=401 Bug: 894541 Change-Id: I1da729a7dd64ac2862c8057b32ced35063bfcf6e Reviewed-on: https://chromium-review.googlesource.com/c/1295389Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#602434}
-
Mirko Bonadei authored
There is no reason to depend on libjingle_xmpp:rtc_task_runner from //third_party/webrtc_overrides. It was causing symbol visibility errors in the WebRTC component build and after looking more carefully into it, it seems that WebRTC doesn't need it, it is used in //jingle so this CL moves the dependency where it is needed. Bug: 896154 Change-Id: Icf24838a7b6220d5cabce1878b128caa3fe2fc9e Reviewed-on: https://chromium-review.googlesource.com/c/1297359 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#602433}
-
Wenzhao Zang authored
Remove the |useNewWallpaperPicker| checks, and modify some comments. Will need follow-up CLs to: 1) Remove the flag in //ash. 2) Take a second pass to check which CSS styles/functions/variables are unused. Bug: 812085 Change-Id: I7faa99c16715360a95feed50b5041d89c8c322a1 Reviewed-on: https://chromium-review.googlesource.com/c/1297308Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#602432}
-
Tommy C. Li authored
Bug: NONE Change-Id: I9fe62588a7d68d0350867c30b8cc9821a05d167d Reviewed-on: https://chromium-review.googlesource.com/c/1296685 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#602431}
-
Dave Tapuska authored
Appears calling the syscall over and over can be slow. Use TLS to stash the result of the syscall. Benchmarks: Without change: taskset -c 0 base_perftests --gtest_filter=SequenceManagerPerfTest.RunTenThousandImmediateTasks_OneQueue* *RESULT task: run 10000 immediate tasks with one queue SequenceManager with message loop= 23483.009389671362 us/run *RESULT task: run 10000 immediate tasks with one queue SequenceManager with message pump= 17142.489726027397 us/run *RESULT task: run 10000 immediate tasks with one queue message loop= 5126.6598360655735 us/run *RESULT task: run 10000 immediate tasks with one queue single thread in WorkerPool= 9817.776470588235 us/run With change: taskset -c 0 base_perftests --gtest_filter=SequenceManagerPerfTest.RunTenThousandImmediateTasks_OneQueue* *RESULT task: run 10000 immediate tasks with one queue SequenceManager with message loop= 15673.59375 us/run *RESULT task: run 10000 immediate tasks with one queue SequenceManager with message pump= 8832.218694885361 us/run *RESULT task: run 10000 immediate tasks with one queue message loop= 5149.919670442842 us/run *RESULT task: run 10000 immediate tasks with one queue single thread in WorkerPool= 9926.059523809523 us/run BUG=898294 Change-Id: I414ff18fd0c92a3837b50e20165bf295b4f63082 Reviewed-on: https://chromium-review.googlesource.com/c/1291710Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#602430}
-