GitLab

This patch adds a UKM metric that tracks two boolean values recorded
once per (main frame's) document:
- Whether find-in-page happened on that page
- Whether a find-in-page activated a render-subtree element.

R=chrishtr@chromium.org, schenney@chromium.org

Bug: 1044299
Change-Id: I753702069fdad5d3145f7afe822ca638304470b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013744
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735061}

This may have been introduced in this CL:
https://chromium-review.googlesource.com/c/chromium/src/+/2006485

TBR: lazzzis@google.com
Bug: 1045415
Change-Id: I7a12c47f4336daa97c9f7c5a8ff5820443869e49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019328Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735060}

Introduce a small helper class TimingUpdate which carries the timing-
related state for a (timing) update of the animations. This helper
will be extended to handle event dispatch when seeking correctly.

Bug: 1039886
Change-Id: I3dbeb64b2cd7ae4d771f80f9232573a0838248df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017333Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#735059}

R=beccahughes@chromium.org
TBR=beccahughes@chromium.org

Bug: 1045500
Change-Id: I19500599b2c459081584dcab9145452e8a9b06d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019384Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735058}

This reverts commit 16775142.

Reason for revert: Quite a few SigninInteractionControllerTestCase tests are failing on https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-noncq and might caused the timeout on swarming task.
See https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8890361013331611952/+/steps/ios_chrome_ui_eg2tests_module__iPhone_X_iOS_13.1__shard_1__with_patch__on_Mac-10.14.6/0/stdout

Original change's description:
> Revert "[ios][eg2] Disable all EG2 tests from SigninInteractionControllerTestCase."
> 
> This reverts commit db9b2ce6.
> 
> Reason for revert: Tests now pass
> 
> Original change's description:
> > [ios][eg2] Disable all EG2 tests from SigninInteractionControllerTestCase.
> > 
> > TBR=jlebel@chromium.org
> > 
> > Bug: 1037676,1036840
> > Change-Id: I552d7cec1cab40b5ef9dae9271bb956a625fd71f
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981141
> > Reviewed-by: Eugene But <eugenebut@chromium.org>
> > Commit-Queue: Eugene But <eugenebut@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#727312}
> 
> TBR=eugenebut@chromium.org,jlebel@google.com
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 1037676, 1036840
> Change-Id: Ie9c4b650360072c3e916e78d122ae331f55f424c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015408
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
> Commit-Queue: Eugene But <eugenebut@chromium.org>
> Auto-Submit: Eugene But <eugenebut@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#734642}

TBR=eugenebut@chromium.org,jlebel@chromium.org,jlebel@google.com

Change-Id: I61d15f1d257bb9836a4ac7257276abad579adeeb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1037676, 1036840
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019936Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#735057}

BUG=1036471

Change-Id: Ia387b4a5cba67581d8607016ee05df403310c864
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017103
Auto-Submit: Theresa  <twellington@chromium.org>
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Reviewed-by: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/master@{#735056}

This change inlines the definition of AssertIteratorsInOrder into the
string_piece.h. While the goal of the previous implementation was to
avoid #including "base/logging.h", that header has already been included
with r353605, thus there should be no regressions when inlining this
definition. Having AssertIteratorsInOrder inline also directly supports
BasicStringPieces that are not base::StringPiece or base::StringPiece16.

Bug: 911896
Change-Id: I9150235dc79687b72f970872af950b0a82e1c0a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019442
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735055}

It is common for WKWebView to have certificateChain, which does not allow
constructing net::X509Certificate.

Bug: 1043736
Change-Id: I554fbf7391e1f267ac78d2eaf29f21945542b51a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016330Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735054}

BUG=1044828

Change-Id: Idd5a5f4fed6ca3d7a9bcae0a14b130e4c6ce9022
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020182
Auto-Submit: Avi Drissman <avi@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735053}

- Test's previously had repeated code, interactions with private
  variables, and required an update to use the FakeNetworkConfig
  to fake connectivity status.
- This refactor simplifies the test code and makes it easier to
  read.

Bug: 1015628
Test: browser tests
Change-Id: I567688fe6bf5a2b0ea8be463c2bed1c6879bcca0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013913
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735052}

Change-Id: I9c458a7fe05c2ed60c1f9498dd0cea3cc3237455
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019923
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735051}

Convert a OnceCallback to a RepeatingCallback.

Bug: b/148234741
Change-Id: I32bcf351f2888925fb5c92b6cea0fd7d04b2f11f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019505
Commit-Queue: Luke Halliwell (slow) <halliwell@chromium.org>
Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735050}

This test is still flaky after it was previously marked RetryOnFailure
but it looks like the expectation wasn't formatted correctly so I
suspect that it isn't being applied at runtime.  I'm fixing the
entry and we can see if the flakiness continues.

TBR: zmo@chromium.org

Bug: 1045339
Change-Id: I989918b4e518b099de9fcd5ddbbb5912f4c3a022
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019471Reviewed-by: Joe Downing <joedow@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735049}

Tab contents may get focused during some renderer-initiated navigations
(e.g. navigations from an NTP-replacement extension - see the regression
test added in r723022).  This CL ensures that the focus decision is
applied not only to navigations that go through OpenURL, but also to
navigations that go through (more freqeuent, usual) BeginNavigation.
This change helps ensure that we retain the right focus behavior after
more navigations switch to the BeginNavigation code path (e.g. after
relanding ShouldFork removal in https://crrev.com/c/1949448).

The CL covers both the OpenURL and BeginNavigation code paths by
handling the focus decisions in a newly added TabContentFocusingHelper
class (replicating/moving the focus decisions from OpenURL-only
Browser::UpdateUIForNavigationInTab).  Adding a new tab-helper class is
useful, because the existing, OpenURL/BeginNavigation-shared navigation
notifications handlers (e.g. Browser::ScheduleUIUpdate) cannot
distinguish between replaceState and new navigations (see also new steps
in the OmniboxFocusInteractiveTest.NtpReplacementExtension test).

While this CL changes how focus behavior is implemented, it should have
no effect on end-to-end/high-level expectations of focus behavior (as
observed by end users or browser tests).

browser_tests do not guarantee window activation and/or focus, but before this
CL navigation in browser_tests would focus WebContents.  This is not happening
after this CL, and requires moving a handful of focus-dependent tests from
browser_tests to interactive_ui_tests.

Bug: 1029161
Change-Id: Ib57c260b2f85f276ff1dad3aabedd59d1d864c8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970834
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735048}

-  Apple is hiding UIActivityViewController's contents from the host app on iPad.

Screenshot: https://drive.google.com/a/google.com/file/d/1yi2FH2gXPm4WNAg7kRLuzkYkHb5tAJE5/view?usp=sharing

Bug: 1044676
Change-Id: Ifc989ba6764fc2232c49333c128b1df953ad05a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019443Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735047}

TBR: wychen@chromium.org
Bug: 1045417
Change-Id: I7ce691f95b917b451224fd7cb2e311a3122c2dcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019473Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735046}

I've not had a chance to follow up on this yet and so require more time.

Bug: 1034570
Change-Id: I8455841184c0f0a1740b3ac9f1693e07cc7727a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017983Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735045}

dav1d is build with C99 which does not define _GNU_SOURCE by
default. However, GNU extensions are used within dav1d,
e.g. RTLD_DEFAULT. clang build succeeds, because _GNU_SOURCE
is defined globally.

Bug: 819294
Change-Id: I1c6e024421c8c8de0b44f0d91dc0b96ef967e712
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010760
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735044}

R=keishi@chromium.org
TBR=keishi@chromium.org

Bug: 1045510
Change-Id: Ic8ff5fb3db4d9aa0fba0c98271ea62ad5c2af4c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020162Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735043}

Include device handles (/dev/class/goldfish-*) which are required
by Fuchsia Emulator in the sandbox policy.

TEST: Run chromium on Fuchsia emulator (with the following patch)
      https://android-review.googlesource.com/c/device/generic/goldfish-opengl/+/1180701
      chromium does not crash.

BUG: fuchsia:41834

Change-Id: Ia083909f61fbdf9049bbff4361f92957b84c9606
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949635Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Yilong Li <liyl@google.com>
Cr-Commit-Position: refs/heads/master@{#735042}

Bug: 1021634
Change-Id: Ide9d5188d36b8ca7eaa4cd890b5b3a4d123966eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018881
Commit-Queue: benjamin joyce <bjoyce@google.com>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735041}

This is a reland of aaab30e7

CQ_INCLUDE_TRYBOTS=luci.chromium.try:win7-rel

Original change's description:
> Local NTP: make past search matches change realbox icon to clock
>
> R=mahmadi@chromium.org
>
> Fixed: 1043335
> Change-Id: I98b1fbcc0a5b5e0d48334e8eb33a31c66f07a4fe
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008614
> Auto-Submit: Dan Beam <dbeam@chromium.org>
> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
> Commit-Queue: Dan Beam <dbeam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#733854}

Change-Id: Ia8665be77fb6cac6da6f3f3fbc33697b2b6bc63c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013813Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735040}

The throttling check, added in a previous CL for this bug, appears to
have fixed some but not all of the crashes.

It's not clear how this point in the code could be reached for a
detached iframe. Nevertheless, the stack trace for the remaining
crashes suggests this might be the case:

When a frame becomes detached, it resets its page_ to nullptr; this is
the only way that Frame::GetPage() can return nullptr. In
EventHandler::HitTestResultAtLocation, if GetPage() returns nullptr, it
skips trying to re-dispatch the hit test to the local frame root, and
instead just falls through to PerformHitTest on the current frame.

If GetPage() is in fact null, we would expect not to see any
recursion in HitTestResultAtLocation; and that holds true in all of
the recent crash reports. Hence the speculation that we might be
trying to hit-test a detached frame.

BUG=1041252
R=chrishtr@chromium.org

Change-Id: I3bf8482867a26f5f7a0369a0e9015c237744c0e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017933Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735039}

This CL adds tests to ensure we do not regress current behavior of
blocking navigations to WebUI URLs through window.open().

Bug: 1002276
Change-Id: Ifcb05b2cd4f99954a4dd70fe4c21fc368a7852d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018384
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735038}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7a319697e3aa..5337c2c3980c


Created with:
  gclient setdep -r src-internal@5337c2c3980c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1028270,chromium:1042208,chromium:1045049
Tbr: jbudorick@google.com
Change-Id: Ia5e1b1044e7f76da134bcdd970133f722ee948fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019854Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#735037}

Notice at the bottom on the Login/Lock screen

Fixed: 1045160
Change-Id: Ib274fd7084dcd80f65cd8051ee360cd359850d5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019208Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735036}

Previously, ISelectionItemProvider::Select, AddToSelection, and
RemoveFromSelection do not work on radio buttons or menu item radios
because AXPlatformNodeWin::ISelectionItemProviderSetSelected returns
UIA_E_INVALIDOPERATION for all elements that do not have
BoolAttribute::kSelected. However, Radio and MenuItemRadio support
ISelectionItemProvider through IntAttribute::kCheckedState, so
ISelectionItemProviderSetSelected call would fail.
This change fixes this issue by removing the check for kSelected in
AXPlatformNodeWin::ISelectionItemProviderSetSelected()and refactors
ISelectionItemProvider.

Bug: 844149
Change-Id: I301c98a80b4915ca81f555ab560417acb252d5fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008623Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Adam Ettenberger <adettenb@microsoft.com>
Commit-Queue: Victor Fei <vicfei@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#735035}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/05eb37fad076..93d8e2cd12d0

git log 05eb37fad076..93d8e2cd12d0 --date=short --first-parent --format='%ad %ae %s'
2020-01-24 aerotwist@chromium.org [Global] Update refs to UI.themeSupport
2020-01-24 almuthanna@chromium.org Remove needless parseInt from toChar test
2020-01-24 brgoddar@microsoft.com Revert "Add script that checks license headers of JavaScript files"
2020-01-24 aerotwist@chromium.org [Global] Update refs to Extensions.extensionServer
2020-01-24 aerotwist@chromium.org [Global] Update refs to Persistence.networkPersistenceManager
2020-01-24 tvanderlippe@chromium.org Migrate event_listeners/ to import cross-module
2020-01-24 tvanderlippe@chromium.org Migrate emulation/ to import cross-module
2020-01-24 tvanderlippe@chromium.org Migrate worker_main/ to import cross-module
2020-01-24 aerotwist@chromium.org [Global] Update refs to UI.shortcutsScreen
2020-01-24 tvanderlippe@chromium.org Migrate diff/ to import cross-module

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@93d8e2cd12d0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1006759,chromium:1045385
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Icfedfa5cedb76fb1ba029b60b805f6cd0ede1d95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019846Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#735034}

Bug: None
Change-Id: I5837d78edbdc0c76dab6a56c4c2f639e2895b1bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015664Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735033}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/781941ba..300b9ced

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I6cfb7eaaa5c92f24b5da8da2fa2dea472246e0d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019822Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#735032}

One of my previous change introduced a regression in determining if an
element should be considered as a UIA control. The previous CL changed
the default value returned by AXNodeData::IsReadOnlyOrDisabled from true
to false, but AXPlatformNodeWin::IsUIAControl's use of this method
needed to be adjusted to the new implementation.

This CL fixes it.

Bug: 928948
Change-Id: Ia5d2ff96e7200ad8806be19f52a249645037bf6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018163Reviewed-by: Adam Ettenberger <adettenb@microsoft.com>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#735031}

Bug: 1045258
Change-Id: Ieee1048e058beb39f8beca6b04dc993153bfdb67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018483
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735030}

Background images are painted by ViewPainter via a call to
PaintFillLayer, passing a |paint_rect|. PaintFillLayer assumes that
any offset from (0, 0) of |paint_rect| is the paint offset in the local
transform space. This was not the case the root element has a transform.
In those cases, remove the offset.

Bug: 988446

Change-Id: I74439771ade6c9c7a54131a84b40ea9a0df5e25c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018451Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735029}

This is what Simple Chrome does today:
https://source.chromium.org/chromium/chromium/src/+/master:third_party/chromite/cli/cros/cros_chrome_sdk.py;l=1008

Setting a proper default here will let us delete that bit from
cros_chrome_sdk.

Bug: 937821
Change-Id: Ic83983c75f392a93256dc9cb278bbbf16081e4fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015822Reviewed-by: George Burgess <gbiv@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735028}

We were trying to remove a child view from the wrong parent. Fix this.

This makes BrowserActionApiTest.Basic pass with the ExtensionsMenu
enabled.

Bug: 984654
Change-Id: I5e648e487fa173370f17eb841587f6136eb67e20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019926Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735027}

Change-Id: Ife1b3c2ca46f19361cf8f92da41528c2c55649c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015343Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Tom McKee <tommckee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735026}

If the RPDQ has a filter, it's touched pixels are not actually restricted
to the visible rect of the quad. In that case it is incorrect to explicitly
clip the visible rect to the scissor and not set the scissor as a clipRect.
This CL makes it so the scissor is remembered and is applied post-filtering,
so effects like drop shadows are properly clipped to the window content.

Bug: 1035271
Change-Id: I138b1412c55489aa0068cc0ea1744a3248738716
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019804Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Cr-Commit-Position: refs/heads/master@{#735025}

This allows the sharing service to communicate via WebRTC in a sandboxed
process. All WebRTC related network access is routed through the network
service to open ports and resolve addresses.

Bug: 1031148
Change-Id: Id143ec84783065ee5b36ba2cb1fe5b8992dac16f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007765
Commit-Queue: Richard Knoll <knollr@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Steve Anton <steveanton@chromium.org>
Reviewed-by: Himanshu Jaju <himanshujaju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735024}

MSTrack.applyConstraints() produces sometimes odd-dimension frames due
to rounding errors. This is a problem for texture-backed VideoFrames.
This CL avoids that by producing a |visible_rect| of even size and
fully enclosed in the original frame.

I tested this on a nocturne chromebook, with the FakeVCD, navigating to
[1] and changing the resolution slider a number of times. This would
mess up ToT graphics; with the patch, it's fixed.

[1] https://webrtc.github.io/samples/src/content/getusermedia/resolution/

Bug: 1045261
Change-Id: I3734ae68a485342195601f15892389793372eed7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017918Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Auto-Submit: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735023}

(See the diff since PS1 for the changes since the original change).

This CL relands https://crrev.com/c/1637737. That CL broke Android Q
compositing of some mixed WebGL/Canvas2D content. The root cause was an
incorrect assumption: that when the framebuffer for the root render pass
is bound, we wouldn't try to bind it again before swapping it. This
assumption was wrong in the case of drawing a render pass quad onto the
root render pass. See [1]. The aforementioned CL would call
BeginSharedImageAccessDirectCHROMIUM() upon binding the root render
pass' framebuffer and would call EndSharedImageAccessDirectCHROMIUM()
only when the buffer is swapped. So, binding the framebuffer multiple
times would result in the shared image system thinking that we wanted
concurrent access to the SharedImage.

This CL fixes that assumption: in case BindFramebuffer gets called more
than once before swapping, we just rebind the GL framebuffer without
requesting to begin access to the shared image.

Additionally, the following changes are made since the original change:

- We cache the textures that are produced by consuming the SharedImages
  from the buffer queue. That way, we don't have to call
  CreateAndTexStorage2DSharedImageCHROMIUM() for the same SharedImage.

- We make sure to delete those textures.

- GpuSurfacelessBrowserCompositorOutputSurface no longer exists, so the
  changes in the original CL for that component are discarded.

- We add some unit test coverage to GLOutputSurfaceBufferQueue to avoid
  this regression in the future. The GLOutputSurfaceBufferQueue
  interface is changed to make it possible to inject a mock buffer queue
  for testing. This in turn, requires a change in the BufferQueue
  interface: instead of passing a SyncTokenProvider on construction, we
  provide a setter method. That way the BufferQueue can be constructed
  before the GLOutputSurfaceBufferQueue (and the latter sets itself as
  the SyncTokenProvider).

  There are also, unfortunately, some #include changes to satisfy the
  bots.

Original change's description:
> This CL migrates the BufferQueue to use SharedImage in order to get
> rid of direct GL dependencies (necessary to eventually be able to use
> Vulkan).
>
> Stencil buffer management depends on the specific graphics API (e.g.,
> GL), so it is moved out of the BufferQueue into its user classes
> GpuSurfacelessBrowserCompositorOutputSurface and
> GLOutputSurfaceBufferQueue. Note that we don't need to have one
> stencil buffer per color buffer: we can reuse the same stencil buffer
> across all the color buffers.
>
> Bug: 958670
> Test: Compositing and overdraw feedback works normally on a nocturne.
> Change-Id: Ia85ea8fea81e125b49a3ce2be195873e77397237
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637737
> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
> Reviewed-by: kylechar <kylechar@chromium.org>
> Reviewed-by: Khushal <khushalsagar@chromium.org>
> Reviewed-by: Eric Karl <ericrk@chromium.org>
> Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
> Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#723697}

Bug: 958670,1033279
Test: visit https://toji.github.io/dinosaurs-static/ on Android Q.
Change-Id: I176af87749c90b775f95c54e2155f27ea9177a94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977969
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735022}