- 03 Jul, 2018 40 commits
- 
- 
mrefaat authored_openedApplicationURL is a set that is used by inserting the URL for external apps that was launched on it. Then in HandleError if the error was policy interruption for a URL inserted on the set ignore it. The problem with that logic is HandleError is never called for requests rejected by DecidePolicyForNavigationAction which is the place that Chromium reject/allow app launches. Bug: 850760 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icc2535af2fef6ade9fdf28350c55336f8dbf51c1 Reviewed-on: https://chromium-review.googlesource.com/1124971Reviewed-by: Danyao Wang <danyao@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#572312} 
- 
Tom Anderson authoredThis is a followup to: https://chromium.googlesource.com/chromium/src.git/+/270b2bfa01f4eadfe6f25673767a3357158e0ef9 BUG=856607 R=sadrul CC=fbeaufort Change-Id: If06c971a309b4630e44184f7a08bb156b620c7ec Reviewed-on: https://chromium-review.googlesource.com/1123367 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#572311} 
- 
skia-chromium-autoroll authoredhttps://skia.googlesource.com/skia.git/+log/94d57c477fe1..34aa059c1502 git log 94d57c477fe1..34aa059c1502 --date=short --no-merges --format='%ad %ae %s' 2018-07-03 ethannicholas@google.com Revert "Remove setting/use of GrPixelConfig in GrBackendTex/RT ctors." 2018-07-03 ruiqimao@google.com added skeletal animation support to GPU backend 2018-07-03 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 92da844eb754..2b06054dd41f (1 commits) 2018-07-03 brianosman@google.com Replace isGammaCorrect with isLinearlyBlended 2018-07-03 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms 9d19e2abf000..678e47d97bc5 (1 commits) 2018-07-03 jcgregorio@google.com Add cloudbuild.yaml file for continous builds of fiddler and skia-release. 2018-07-03 robertphillips@google.com Fix empty stroked oval handling in GrRenderTargetContext::drawOval 2018-07-03 egdaniel@google.com Remove setting/use of GrPixelConfig in GrBackendTex/RT ctors. Created with: gclient setdep -r src/third_party/skia@34aa059c1502 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I75f76fa6db466cd549625022947802cfd60381b1 Reviewed-on: https://chromium-review.googlesource.com/1124649Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572310} 
- 
Ryan Hansberry authoredThis issue manifested as all new account creations on Chrome OS crashing. It was caused by the local device metadata being returned by DeviceSyncClient not yet being initialized. DeviceSyncClient now internally keeps track of whether it is "ready", that is, whether its local device metadata and synced devices are available yet. Only once it has loaded both sets of data will it mark itself as "ready", and inform clients appropriately. This change also ensures that DeviceSyncClient's Observer callbacks, OnEnrollmentFinished() and OnNewDevicesSynced(), are not called until DeviceSyncClient is ready. R=jhawkins@chromium.org, khorimoto@chromium.org Bug: 856406 Change-Id: Idb6fdf123d4d90883f67bb1e88a617004926207e Reviewed-on: https://chromium-review.googlesource.com/1121351Reviewed-by: James Hawkins <jhawkins@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#572309} 
- 
Alexei Filippov authoredChange-Id: I0a07c50c28c4719a18f01305511d63574094f604 Reviewed-on: https://chromium-review.googlesource.com/1115818 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#572308} 
- 
Michael van Ouwerkerk authoredBug: 853791 Change-Id: I3349c450d8b285bcfdea69e6342350941d121353 Reviewed-on: https://chromium-review.googlesource.com/1120503 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#572307} 
- 
Daniel Bratell authoredIt's currently easy to use an IntRect when a FloatRect is needed since there is an implicit (lossy) conversion from IntRect to FloatRect. This patch changes some code to remove some unnecessary conversions between the types. (A float can store all integers up to, but not including, 16,777,217 so it the conversion is most of the time non-lossy) R=fs@opera.com, pdr@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I324b79c3d78d387574f47a4bda8f7dc7bdad567b Reviewed-on: https://chromium-review.googlesource.com/1124682Reviewed-by: Philip Rogers <pdr@chromium.org> Reviewed-by: Fredrik Söderquist <fs@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#572306} 
- 
fuchsia-sdk-chromium-autoroll authoredThe AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Ied1a11b41e14dcc6ce3e64b13889525287c4a6cd Reviewed-on: https://chromium-review.googlesource.com/1124979Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572305} 
- 
Takumi Fujimoto authoredClicking on the Cast button when there are no sinks causes a crash. This CL disables the button when the dialog goes from having sinks to empty. Bug: 857224 Change-Id: I8040aef278d28fbc6e6b03c04e9ff9103156ea44 Reviewed-on: https://chromium-review.googlesource.com/1119531Reviewed-by: mark a. foltz <mfoltz@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#572304} 
- 
Leonard Grey authoredAlso removes the explicit focus ring layout since ImageButton::Layout takes care of this. Bug: 854934 Change-Id: Ib49442d1db95577d9e4f7d0497e1b3bd50bf2cbc Reviewed-on: https://chromium-review.googlesource.com/1124765Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#572303} 
- 
Xianzhu Wang authoredThis reverts commit e71a3846. Reason for revert: Caused performance regressions because changed paint properties are not cleared changed flags. Original change's description: > [PE] Don't call PaintController::FinishCycle() if not repainted > > This is mainly a performance optimization because we don't need > FinishCycle() if PaintController has nothing changed. > > By the way it can also avoid the immediate bad effect (but not the > root cause) of bug 859294. > > Bug: 859294 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: Iad3e14ee303c08185922d3d6e495c3b25ead5434 > Reviewed-on: https://chromium-review.googlesource.com/1121783 > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571803} TBR=wangxianzhu@chromium.org,chrishtr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 859294, 859885 Change-Id: I2a4d2a7d09cc3bf5edfbf0c6dee275581030c2c9 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1124701Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#572302} 
- 
Lei Zhang authoredIt is only used in the ProfileInfoCache sub-class. Change-Id: Iba2c64e99821866d2ec3072d0b0ef412a1353e01 Reviewed-on: https://chromium-review.googlesource.com/1124107Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#572301} 
- 
Pavel Feldman authoredChange-Id: I916652f378d2d43cb89c1aa546108d4bc38d8746 Reviewed-on: https://chromium-review.googlesource.com/1121420 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#572300} 
- 
Reza.Zakerinasab authoredThe flakiness cannot be reproduced and suspected to be a result of recent changes in Skia color management code. Removing timeout tag for the tests and monitoring the bots to see if the flakiness returns. TBR=fserb@chromium.org Bug: 851746 Change-Id: Ie9f3e650140be4b9f27e9e7963ead014cee2bf49 Reviewed-on: https://chromium-review.googlesource.com/1124986Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#572299} 
- 
spqchan authoredTBR=carlosk@chromium.org Bug: 859681 Change-Id: Ic06fbd6b18c570e210ecd5e2e7bd8aa3802fc5cb Reviewed-on: https://chromium-review.googlesource.com/1123319 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#572298} 
- 
Simeon Anfinrud authoredThis method was only used in one place, and was the only user of first() and changes(). unique() can be confusing because its scope exits before it gets new data, so it only happens to work when we don't care about deactivations. While these methods seemed like a good idea at the time, the possibility of Observable implementations that have multiple simultaneous activations make these methods tough to define. In the meantime, duplicate-filtering can be done with Controllers, which now have that built-in to set(). Bug: None Test: cast_base_junit_tests, cast_shell_junit_tests Change-Id: I86f542bbcdcb1a643400715733ecdaae438915ba Reviewed-on: https://chromium-review.googlesource.com/1119192Reviewed-by: Luke Halliwell <halliwell@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#572297} 
- 
Jun Choi authoredImplement GetAssertion operation for CTAP2 software key. The implement GetAssertionOperation does not support multiple accounts per device and never returns UserEntity as a response. Bug: 829413 Change-Id: I58a43a032fc520494ea8fdbfb1c64959a04c6b82 Reviewed-on: https://chromium-review.googlesource.com/1117369 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#572296} 
- 
Christian Fremerey authoredThere is an incompatibility in the serialization of shared memory handles between the Mojo libraries used in Chromium vs. the older ones used in ChromiumOS. As a workaround, this CL allows clients of the video capture service to ask it to use raw file descriptors for sharing shared memory handles instead. Note, this is only supported on platforms that use file descriptors for base::SharedMemoryHandle, i.e. Posix platforms. Design Doc: https://docs.google.com/document/d/1cmtWA8yua5sqjZC0tswVUZwJeQR-KSZBr3Mj1jUagKk/edit?usp=sharing Bug: 847598 Change-Id: Ie269231b98149cbbc104ea62c1ff522c665cf187 Reviewed-on: https://chromium-review.googlesource.com/1043646 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#572295} 
- 
Charlie Harrison authoredThis mode was added as a way to hedge our feature against failing to launch metadata on the SafeBrowsing API side. This feature has been launched for a while and the parameter did not end up being used, so just remove it and associated tests. Bug: None Change-Id: Ib2e7d633da2d98478cee17dc3cdffe4e0b998d1b Reviewed-on: https://chromium-review.googlesource.com/1124763Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#572294} 
- 
Philip Rogers authoredThese were disabled in https://codereview.chromium.org/34353004 but now run. The setting, multiTargetTapNotificationEnabled, is enabled on all platforms. This patch unskips the gesture tap highlight tests on mac and updates their expectations. Bug: 857501 Change-Id: I4bb6c91cd5b75d3fe30420759073f404a62d896f Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1121786Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#572293} 
- 
Brian Osman authoredThis is going away in Skia (no one wants linear blending), so this lets us land some Skia changes that alter image encode/decode/conversion behavior without breaking webkit unit tests. Some canvas color space layout tests do break, because they exercise multiple code paths in Skia. The paths that depend on image encode and decode are now using nonlinear blending, but the paths that just draw (to SW canvas) are hitting code that isn't updated yet. To make it easier to finish that migration, this change suppresses all of the transparent pixel tests within those five layout tests. Bug: chromium:859102 chromium:844145 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I331b5dfc08e53d498fdc1449519b42f67de6d1af Reviewed-on: https://chromium-review.googlesource.com/1117026Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#572292} 
- 
Qiyu Hu authored- Ensure that CCCD is added such that we can report the value change in CCCD to Android in OnNotificationStart/Stop() - Implement SendIndication() such that Android can call it Bug: b:78593133 Test: Pass Android CtsVerifier test on server sending indication/notification Change-Id: I8b1a4be6596555003d6d447b4518f37632a45370 Reviewed-on: https://chromium-review.googlesource.com/1119079 Commit-Queue: Qiyu Hu <qiyuh@google.com> Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#572291} 
- 
Lei Zhang authoredFix includes in chrome_signin_client.cc. Change-Id: I22bdfd9a625ed7e57cab49f61004d2334dea066a Reviewed-on: https://chromium-review.googlesource.com/1124108Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#572290} 
- 
Simeon Anfinrud authoredreactive_java.md documents the expectation that the Observable produced by map() is not activated when its source is activated and the Function that transforms the activation data returns null, but this expectation was not properly tested. Bug: None Test: cast_base_junit_tests Change-Id: If8ff1764efe6790a9eeabcfeadf28b052ce924f5 Reviewed-on: https://chromium-review.googlesource.com/1120643Reviewed-by: Luke Halliwell <halliwell@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#572289} 
- 
Quan Nguyen authoredAlso includes a run of "git cl format --js" on display_manager.js, and a fix for splash screens not stretching to the full screen. Bug: 836861 Change-Id: Icfe750f9d743b9608e120fc02f8cf16228be5c8f Reviewed-on: https://chromium-review.googlesource.com/1115977 Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#572288} 
- 
yiyix authoredRemove the following metrics: Renderer4.CompositorThreadImplDrawDelay (99th percentile by size) Renderer4.LanguageDetection (95th percentile by size) Renderer4.SoftwareCompositorThreadImplDrawDelay (85th percentile by size) Bug: 851784 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I99947370afa55bea137f99a317983db11292e33e Reviewed-on: https://chromium-review.googlesource.com/1112203Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Michael Martis <martis@chromium.org> Reviewed-by: Fady Samuel <fsamuel@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#572287} 
- 
Simeon Anfinrud authoredNow it's possible to e.g. create a Function<Both<ADerived, BDerived>, CBase> from a BiFunction<ABase, BBase, CDerived> if: * ADerived extends ABase * BDerived extends BBase * CDerived extends CBase This will help with some refactors. Bug: None Test: cast_base_junit_tests Change-Id: I7cfa3b3cfb559510e318ac8a597a138c0e4b3e0e Reviewed-on: https://chromium-review.googlesource.com/1119056Reviewed-by: Luke Halliwell <halliwell@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#572286} 
- 
Lei Zhang authoredChange-Id: I8a8c0ba1da296572c5c661a82faa15c776200671 Reviewed-on: https://chromium-review.googlesource.com/1123895Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#572285} 
- 
Bill Orr authoredThe proper fix requires some design work. The current behavior does suffer from potential raciness, but shouldn't cause real-world issues for users. BUG=859666 Change-Id: I8d502a7db25949d2508675e1d153dbf56f69e1ed Reviewed-on: https://chromium-review.googlesource.com/1124948Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#572284} 
- 
Kevin Strohbehn authoredBug: none Change-Id: I564a8acb297811c9dee27d2c6d91077774e1bba7 Reviewed-on: https://chromium-review.googlesource.com/1123372Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Kevin Strohbehn <ginko@google.com> Cr-Commit-Position: refs/heads/master@{#572283} 
- 
Toni Barzic authoredAdds OFFLINE_DEMO_ACCOUNT to ChromeAccountType in auth.mojom, which will be set for offline enrolled demo sessions, so ARC++ can use offline demo mode provisioning flow for this account. Currently, there is no real change in prod, given that ARC still handles demo sessions the same (as arc_kiosk), and logic to determine whether the device is in demo mode is not yet hooked up. This cl additionally updates chromeos::DemoSession to indicate whether the device is offline enrolled while in demo mode - this is hardcoded to false for now (except in tests). BUG=b:110276688 BUG=846934 TEST=None Change-Id: Ib1c49401020838e566e07f765aff3e4f4dd9aad9 Reviewed-on: https://chromium-review.googlesource.com/1105599Reviewed-by: Yury Khmel <khmel@chromium.org> Reviewed-by: Mattias Nissler <mnissler@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> Reviewed-by: Aga Wronska <agawronska@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#572282} 
- 
Chromite Chromium Autoroll authoredhttps://chromium.googlesource.com/chromiumos/chromite.git/+log/45a546a30885..da20e836abca git log 45a546a30885..da20e836abca --date=short --no-merges --format='%ad %ae %s' 2018-07-03 dgarrett@google.com chromeos_config: Move all chrome-pfq builders to swarming. 2018-07-03 dgarrett@google.com chromeos_config: Move all android-pfq builders to swarming. Created with: gclient setdep -r src/third_party/chromite@da20e836abca The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:853969,chromium:853969 TBR=chrome-os-gardeners@chromium.org Change-Id: Ic6cfa31337c5a29b332625f48f0521cd8e5b6e7b Reviewed-on: https://chromium-review.googlesource.com/1124646Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572281} 
- 
Robbie McElrath authoredThis migrates IntranetRedirectDetector from using net::NetworkChangeNotifier to content::NetworkConnectionTracker, which works with the network service enabled. Bug: 859131 Change-Id: Iec4c2f7907066d030d8de11d13ac955a558a2415 Reviewed-on: https://chromium-review.googlesource.com/1123332Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#572280} 
- 
Theresa authoredAdd tests for: * Opening EoC using the toolbar button and tapping a suggestion * Button visibility when entering and exiting the tab switcher * Button visibility when switching tabs BUG=859567 Change-Id: Ib786454fc0f23ead9d6c446e05877e9fb92638e7 Reviewed-on: https://chromium-review.googlesource.com/1123273Reviewed-by: Becky Zhou <huayinz@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#572279} 
- 
Dominic Battre authoredDisable LocalNTPInterceptionWebRequestAPITest.OneGoogleBarRequestsHidden when run in servicified network stack but not otherwise. Flakes are caused due to a bug in the servicified network stack, the test seems to work well on other platforms. Bug: 853118 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I02bf111449dd88c24c788d630e8e53f364e03265 Reviewed-on: https://chromium-review.googlesource.com/1123822Reviewed-by: Dominic Battré <battre@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#572278} 
- 
Brian Sheedy authoredThis reverts commit 65c38f54. Reason for revert: Causing DCHECK failures in VR instrumentation tests Original change's description: > GPU: Grow and shrink transfer buffer > > Automatically grow the transfer buffer when it is full and shrink it > when the full capacity is not being used. Allow choosing larger and > smaller sizes than before. > > Before we would only grow it when a single transfer request was larger > than the whole buffer; requests smaller than the whole buffer would just > block if the buffer was full. Also we would not ever shrink the buffer > until someone called Free() manually. > > Bug: 850271, 835353, 828363, 856347 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: If2f2235a1d5297c63663398b37e1e30791347a3e > Reviewed-on: https://chromium-review.googlesource.com/1105505 > Commit-Queue: James Darpinian <jdarpinian@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572135} TBR=jdarpinian@chromium.org,sunnyps@chromium.org,piman@chromium.org Change-Id: I031b30234cdcfbd8a4e48c7ebb6fd23312ec10ed No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 850271, 835353, 828363, 856347, 859952 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1124822Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#572277} 
- 
Egor Pasko authoredCoding against this API has been a 2-day debugging challenge :) I also considered "moving network controller options out of browser_options into finder_options: [1]. Then quickly I was chasing the ideals of unbundling StorySet from WprArchiveInfo in order to make _possible_browser.{SetUp,CleanUp}Environment() to start/stop the WPR server and forwarding. This would have been a better API IMO. On the other hand the refactoring associated with it looked a bit involved. So here it is - re-elly partial solution, to say mildly, which injects a few more tightly-coupled classes into each other to solve one specific problem. Sorry. [1] Mention of http://crbug.com/404771 in shared_page_state.py. The catapult side of it (https://github.com/catapult-project/catapult/issues/1977) was closed, but seems not done yet. Bug: 760498 Change-Id: I44e03179f9f2ed16f8fc1934c9786ef342f83609 Reviewed-on: https://chromium-review.googlesource.com/1122862 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#572276} 
- 
Theresa authoredBUG=859564 Change-Id: I928bffc0ca099121134c5df8cb2355f7b39738cd Reviewed-on: https://chromium-review.googlesource.com/1124933Reviewed-by: Becky Zhou <huayinz@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#572275} 
- 
Wez authoredThe AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I4129f2fa7e0a9162077e6aeb6ded3c1857113638 Reviewed-on: https://chromium-review.googlesource.com/1124666Reviewed-by: Wez <wez@chromium.org> Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#572274} 
- 
Tarun Bansal authoredThe WPT tests check the Accept-CH-Lifetime (ACL) header functionality. Add tests for: (i) When ACL header is sent by a same-origin iframe. (ii) When ACL header is sent by a cross-origin iframe. (iii) When ACL header is sent by a subresource. (iv) When ACL header is sent on the main frame. Also, change the ACL persistence time-duration from 20 seconds to 5 seconds to make it easier to run multiple tests quickly and without waiting too long. Change-Id: I31047598bbb1e7c64cadf3e6845bf850c29aca8b Bug: 856700 Reviewed-on: https://chromium-review.googlesource.com/1119848 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Yoav Weiss <yoav@yoav.ws> Cr-Commit-Position: refs/heads/master@{#572273} 
 
-