- 04 Jan, 2020 40 commits
-
-
Yuki Shiino authored
This patch improves the code generation speed. Ex) Navigator 10.5 sec => 8.5 sec Bug: 839389 Change-Id: I90b90f00d09b304fa7f5beb9247eefc75bb75cf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980603 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#728386}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ie2559d0d3a4d32e794c44552d995b623a10bde1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987347Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728385}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/eb7e7731ed98..d74594bbbb71 git log eb7e7731ed98..d74594bbbb71 --date=short --first-parent --format='%ad %ae %s' 2020-01-04 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@d74594bbbb71 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I315f960d0d8bdf8507f5b6b2bf08351accbf8f36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987140Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f3aa6326b8e2..cfe75c12ee04 git log f3aa6326b8e2..cfe75c12ee04 --date=short --first-parent --format='%ad %ae %s' 2020-01-04 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 236f912c..e0ea7be7 (728281:728381) Created with: gclient setdep -r src/third_party/webrtc@cfe75c12ee04 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Icce0039c1967ebacac7126ed150fa54e5360099c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987142Reviewed-by:
-
Caleb Rouleau authored
The gtests aren't working on the windows bots for some reason. The hotfix I tried didn't work. This is a partial revert of https://chromium-review.googlesource.com/c/chromium/src/+/1985134 and https://chromium-review.googlesource.com/c/chromium/src/+/1986118 TBR=bsheedy@chromium.org Bug: 1039019 Change-Id: I1a7bf86bd1b563f46b4a19970e89ae0f89f2c98e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986342Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#728382}
-
Antonio Gomes authored
This CL changes this class and its inner ones to use the CrossThreadBind variants. It also delays the conversion to std types RTCRtpSenderImpl::SetStreams until they are actually needed (ie before calling libwebrtc). Basically Vector<String> plays nicely with CrossThreadCopier, whereas std::vector<std::string> does not. BUG=787254 R=haraken@chromium.org Change-Id: Ie747d0c58af1426f18c067460383bb210703d756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984507Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#728381}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d84d8527. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I54f76fa3a3d22aebe204cfcba4bace9cfabbcc52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986140Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728380}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/35075a1b771f..c7797980325f Created with: gclient setdep -r src-internal@c7797980325f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ic7e7cff29b3d3de40db712b86bfb0869c3088911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987465Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728379}
-
Alexandre Courbot authored
The documentation of the constructors was a bit imprecise on the elements that they do not initialize, and sometime was also outdated. Brush it up a little bit. BUG=None TEST=Chromium builds for arm-generic. Change-Id: Ib3a5497c2d9fdc76ae25f58ca52562d0083f7590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981964Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#728378}
-
Charlene Yan authored
Previously, tabs would always get removed from the group and moved to the end of the tab group. This change results in the tab moving the minimum distance when removing from the group. Bug: 1038362 Change-Id: I513b4e6d97ec847d200cdec0c54f64745cab4191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986922 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#728377}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/47a5ad0c3e12..35075a1b771f Created with: gclient setdep -r src-internal@35075a1b771f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ic327260e4c0d6a3528f96bf42c90e593b06d0855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986984Reviewed-by:
-
Christopher Cameron authored
This capability already exists for glSetColorSpaceMetadataCHROMIUM, so use it for glResizeCHROMIUM, to avoid introducing another class of enums. Rename GLColorSpace to GLcolorSpace for consistency. R=ericrk TBR=avi (chrome/) Bug: 1037954 Change-Id: Ife23c4646d0d5677dd14f4d63c189bf2c93d2eff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985009 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#728375}
-
Donn Denman authored
This reverts commit 261096cf. Reason for revert: Speculative revert of this CL since it may be causing many test failures. See issue 1038953. BUG=1038953 Original change's description: > Browser test to exercise DoH against external servers > > This change adds a non-hermetic manual browser test to verify > Chrome's DoH implementation against a handful of external > DoH servers. The test loops through each server, and > attempts to load a test URL. Fallback to Do53 is > disabled, so a successful navigation indicates that DoH passed. > > A new setter set_allow_network_access_to_host_resolutions has > been added to BrowserTestBase to allow browser tests to opt-in > to using the full host resolver stack (instead of the mock host > resolver). This mode then invokes > SetAllowNetworkAccessToHostResolutions() on the NetworkServiceTest > interface to disable the test host resolver. > > Bug: 1032710 > Change-Id: I8e9e029e69a9e8281adb23e55179d9dd94707ef5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961006 > Commit-Queue: Kaustubha Govind <kaustubhag@chromium.org> > Reviewed-by: Eric Orth <ericorth@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#727778} TBR=sky@chromium.org,ericorth@chromium.org,kaustubhag@chromium.org,dalyk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1032710 Change-Id: I1e7628f22b55f9a884926b05e47fff25e2368a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987274Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#728374}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/430f61e2a241..eb7e7731ed98 git log 430f61e2a241..eb7e7731ed98 --date=short --first-parent --format='%ad %ae %s' 2020-01-04 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@eb7e7731ed98 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I30cdfee36572bd38fcd1dc707e517d1eb33838be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986982Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I86d40912f84b9ef5c653abe7ea1c52a06d0a6b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987288Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728372}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a19ceecac150..47a5ad0c3e12 Created with: gclient setdep -r src-internal@47a5ad0c3e12 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I16b863ea5e87bfe81542576c3b3cd04078bca7c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986981Reviewed-by:
-
Ken MacKay authored
Merge-With: eureka-internal/348962 Merge-With: libassistant-internal/120360 Merge-With: libassistant-internal/120361 Merge-With: nest-camera-internal/52300 Change-Id: I43485824a1ca0d42bcc1e681c83555786d55645c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986427 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#728370}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/81ee4d29192d..1031d2c65b5e git log 81ee4d29192d..1031d2c65b5e --date=short --first-parent --format='%ad %ae %s' 2020-01-04 kbr@chromium.org Upstream Mac logging changes from WebKit. Created with: gclient setdep -r src/third_party/angle@1031d2c65b5e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: I76adfb16941f2e57cddb56b2bbdc09034c4d77ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987038Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f1b42a219fee..6791ee2f8059 git log f1b42a219fee..6791ee2f8059 --date=short --first-parent --format='%ad %ae %s' 2020-01-04 rosasco@google.com Add logger service. Created with: gclient setdep -r src/third_party/skia@6791ee2f8059 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: I9e376e71cdefaa58c7a592530525236f6f4d4c78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987041Reviewed-by:
-
chrome://extensionsToby Huang authored
This disable reason will be used in a downstream CL to determine whether to show a button or a toggle for enabling extensions for child users. This disable reason will also force-disable the extension enable toggles when the extension state is REQUIRE_APPROVAL. This force-disabling will prevent a regression to crbug/1003014. Bug: 1030958 Change-Id: I63657d01db8c388906579b3cae77d9d78dd487de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974877 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#728367}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bc5a2d004f61..a19ceecac150 Created with: gclient setdep -r src-internal@a19ceecac150 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1006443 Tbr: jbudorick@google.com Change-Id: Ie895f35c06a3a5c15b0b7c633710f1d0fd9aca6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987039Reviewed-by:
-
Dan Beam authored
When destructing ComponentsHandler, RemoveObserver() was not being called in all cases, and therefore ComponentUpdaterService had a dead pointer dangling until it next notifies. R=groby@chromium.org Fixed: 1038846 Change-Id: I2ec97e41d062ddd788c7caa6b236b4bfdb56b6be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987282 Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Rachel Blum <groby@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#728365}
-
Sammie Quon authored
Reland of https://crrev.com/c/1970434 with the hotseat enabled this time. Test: added test Bug: 1026962 Change-Id: I72c5a1885cdfbace92af5483361e13378089f54b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986119 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#728364}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1f74351e20ca..f3aa6326b8e2 git log 1f74351e20ca..f3aa6326b8e2 --date=short --first-parent --format='%ad %ae %s' 2020-01-03 peah@webrtc.org Replace the ExperimentalAgc config with the new config format Created with: gclient setdep -r src/third_party/webrtc@f3aa6326b8e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Icef2581eaa390a1ec55b105adebfdbccbce2af19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987036Reviewed-by:
-
James Darpinian authored
conformance2/transform_feedback/switching-objects.html is flaky only on Mac Pro, not other AMD macs. Bug: 1037958 Change-Id: I535d6a322bf8b18671b58a63fad8a0b2c172eef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987280 Auto-Submit: James Darpinian <jdarpinian@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#728362}
-
nancy authored
BUG=1024670 Change-Id: I9e5e2d67bc4b637f29fe0bf19621b85bd5986210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986467Reviewed-by:
-
Ted Choc authored
The issue is that the MotionEvent (ACTION_BUTTON_PRESS) was bleeding through the view hierarchy and being consumed by the underlying web contents, which would request focus away from the omnibox triggering an ACTION_CANCEL to be dispatched. The solution is to have the suggestion list consume any previously unconsumed mouse click events to ensure they do not bleed through to the sibling yet lower in the Z-axis views. BUG=968414 Change-Id: Ic29114419708a1bf4d7b4ccb03b7cd0144d6bcd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987073Reviewed-by:
Ender <ender@google.com> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#728360}
-
Stefan Zager authored
The first attempt at a fix was reverted, because we can't CHECK(!NeedsLayout()) at the end of a lifecycle update: https://chromium-review.googlesource.com/c/chromium/src/+/1972230 BUG=1035029 R=chrishtr@chromium.org Change-Id: I976c46b13c5a6789ca8df1142269c635cdaa1bb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986911Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#728359}
-
Stephen Chenney authored
Move all the web_tests for image-orientation to external/wpt. Update the testing methods to wpt standards. Adjust the test images to be ammenable to ref tests, though fuzzy matching is still required. Round out the test suite for <img> tags, content images and image documents. Bug: 158753 Change-Id: Iff393f350cbecfc66a91811c72b0ee6274289e5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980505 Auto-Submit: Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
Zhuoyu Qian authored
Per the spec [1], the ChooseFileSystemEntriesType should be lowercase, dash-delimited, such as `save-file`. [1]: https://wicg.github.io/native-file-system/#api-choosefilesystementries Bug: 1020715 Change-Id: Iafc02db7344c70589cf007a7d66b9cd3f9dda6a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981515Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#728357}
-
Mason Freed authored
The [1] CL enabled the FormControlsRefresh feature by default for Windows, Linux, and ChromeOS. In the process, many layout tests were disabled, because the form controls have a different appearance with the feature enabled. This is one of several patches rebaselining those disabled tests. [1] http://crrev.com/c/1967608 Bug: 1035582 Change-Id: I6d53990de99466a718bda5bff923b026b2b0c4a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986331 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#728356}
-
Donn Denman authored
Disable all tests in VrBrowserJavaScriptModalDialogTest before Android Oreo, where they are very flaky. They are solid on O+. BUG=1034735 TBR=tedchoc@chromium.org Change-Id: Icf2a34ea2ec2f682484afe5dc1e63af3ccdb5987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986954Reviewed-by:
-
Orin Jaworski authored
This CL adds 'change' and 'create' to synonym lists for two Pedals. To better track changes to this data, the source JSON data is also added for source control. Bug: 893183 Change-Id: I812e1c052b78dc72d7f1b4580ca4eaeb9b0338bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986428Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#728354}
-
Caleb Rouleau authored
Speculative fix. See bug for details. Bug: 1039019 Change-Id: I15ee33cfba36b1896b089147fd8fa6f6cd9e2459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986969 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#728353}
-
meacer authored
IDNSpoofCheckerTest.IDNToUnicodeThese takes a punycode hostname, passes it through url_formatter's IDN conversion logic and checks the output. If the hostname is safe, it expects the conversion result to be equal to the expected unicode value. Otherwise, it expects the result to be equal to the input punycode value. This means that the test doesn't actually use the expected unicode value if the conversion is not safe. As a result, a few invalid values have made it to the expected_unicode field of the tests. This CL adds a sanity check to make sure that the expected_unicode field is indeed the unicode version of the input hostname. It does this by first doing an unsafe conversion disabling the spoof checks. The CL also introduces an enum with an "invalid" result type. This result is used for punycode that fail before coming to the spoof checks. Making this distinction seems important to be able to reason about why some inputs are failing. Bug: 1036523 Change-Id: Id1d2c374e5cb01900f61703418c21512c41b445d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979592 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#728352}
-
Tomasz Wiszkowski authored
ApiCompatibilityUtils.setImageTintList has correct support only for - Android Lollipop and Above, - AppCompatImageView class. Any other imageview will seem to work, but will receive no tint. Bug: 1038497 Change-Id: I7a7fcad80ff7b7ca3fb344448f27c5c093b25156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987266Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#728351}
-
chrome://extensionsToby Huang authored
This disable reason will be used in a downstream CL to force-disable the extension enable toggles when the extension state is BLOCKED. This force-disabling will prevent a regression to crbug/1003014. Bug: 1033687,1032352 Change-Id: I73788620179026f68a2b72ef9fc72429d7ab62ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975456 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ibf6d6684c9b847a51a5e3b19f0906445c1354760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987229Reviewed-by:
-
Peter Kasting authored
Without this, toggling between light/dark mode could produce hard-to-read text. Bug: none Change-Id: Ic61c5d61b2da5dc6d58485dd0c604ab34da7d614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986309 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#728348}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a5b4ab17af94..d3a10a0399c1 git log a5b4ab17af94..d3a10a0399c1 --date=short --first-parent --format='%ad %ae %s' 2020-01-03 hypan@google.com Add support of android app bundles for webview Created with: gclient setdep -r src/third_party/catapult@d3a10a0399c1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:986990 Tbr: sadrul@google.com Change-Id: Icbbe5dae89bc8dfb95f0224f18f48b59ec51e0f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987230Reviewed-by:
-
