- 12 Oct, 2020 40 commits
-
-
adamta authored
Adds the content suggestions collection view to the VC hierarchy from the BVC. The named guide for the Discover feed IPH was not usable since it could not make its way up to the BVC through its view hierarchy. Bug: 1131571 Change-Id: I97d6f4d9e0dc8642b93b040c2c1003f3588f853d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414613 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#816297}
-
Akihiro Ota authored
This is a temporary fix for the blank display name for yue-HK. The reason we were returning a blank string is because we were calling GetDisplayNameForLocale() with the disallow_default parameter. Remove this parameter so we at least get a return value. Please see the bug for more context. readable text label on TTS settings page. Bug: 1136353 Change-Id: I123c05134782e90c8b297fea6c48287e7fc5dd8c AX-Relnotes: Fix an issue where the Yue (Hong Kong) voice had no Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463600 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#816296}
-
Akihiro Ota authored
This change further refines the locale announcement given when switching between locales within the same language. We announce the locale once when switching to more specific locales, e.g. en -> en-us. We never announce the locale when switching to less specific locales, e.g. en-us -> en. Finally, all subsequent switches from en -> en-us will not be announced. The above logic only applies when we stay within the same language. If the language changes e.g. en -> pt, then the above state will reset. This change also adds a test to confirm behavior. We also removed a test since it can be merged into the new test. same language. Bug: 1098548 Change-Id: Ie7015f68bc6c6c747065d815697584f5fd642092 AX-Relnotes: Refine voice switching behavior when switching within the Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466497 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
-
Nathan Zabriskie authored
In OOPR Canvas mode we don't use |skia_canvas_| in the renderer process. This CL skips the DCHECK in CanvasResourceProvider::OnContextDestroyed since we know |skia_canvas_| won't be present. Bug: 1018894 Change-Id: I98a0ba4e4c819912e155e2785dd60354f429e42b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462633Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Cr-Commit-Position: refs/heads/master@{#816294}
-
David Tseng authored
Rename IsEventTypeHandledByAXEventGenerator -> ShouldIgnoreAXEvent to mirror the variant for AX event generator. R=dmazzoni@chromium.org AX-Relnotes: n/a Test: existing tests Change-Id: I5600ac87fb4369330c27c0b52c70ab112958b41a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464981 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#816293}
-
Carlos IL authored
crrev.com/c/2451549 broke the proceed action on interstitials. This adds a tab storage class that stores when we are in the middle of a proceed, and we no longer show an interstitial if that is the case. This also fixes the "reload is proceed" bug (crbug.com/1093955). Bug: 1134466, 1093955 Change-Id: Ibe6f6eab757cf8ea58def940793ffb7a7f68d1f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454387 Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#816292}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602503558-6db36755351afd56b86dda41eeed03adf268112f.profdata to chrome-linux-master-1602525418-afe56390c440c08698d6b71f1c497e873e6a051a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I25942ad772f54767f18ec12dead10be97604b950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466329Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816291}
-
Dmitry Gozman authored
Bug: 1137291 Change-Id: Ic715eccbbbc9bd8b7eb8877df786f21c5f54db94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462091 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#816290}
-
Mugdha Lakhani authored
Currently, we crash. Bug: 1136823 Change-Id: I4570e8edaab9f95d81eaed2ae2f22570444b6659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462262Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#816289}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1da46abbddb6..1e73818c7ac8 2020-10-12 mbonadei@webrtc.org Triggering all the bots. 2020-10-12 eshr@google.com Reland "NV12 support for VP8 simulcast" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Icd6e034911f909a175388d8875154e83920b5b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465580Reviewed-by:
-
Nico Weber authored
Bug: 1137503,1132930,1103490 Change-Id: Ib189602b324508ffded4fdc00e175d56fe6d8903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465067 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#816287}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0f55e3e5d266..336202d7d601 2020-10-12 jmadill@chromium.org Test Runner: Pass batch ID to child processes. 2020-10-12 cnorthrop@google.com FrameCapture: Move compressed texture cache to shared location If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@chromium.org Test: Test: Asphalt 8 MECTest: Test: https://chromium-swarm.appspot.com/task?id=4f2b87c4f8234910 Change-Id: I7074836b4d3dee092c6ec67bed877922513f91cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465867Reviewed-by:
-
Egor Pasko authored
This reverts commit 6c09107f. Reason for revert: in favor of https://chromium-review.googlesource.com/c/chromium/src/+/2466057 Original change's description: > Disable monochrome_apk_checker on bots running with Android emulator > > At least one bot (see crbug.com/1137405) started failing after > crrev.com/814863 with a message: > > 'unrecognized arguments: --avd-config=...' > > Since a few related changes landed on top, I'm not comfortable reverting > it. Rather making the check pass with this configuration. Tested locally > by providing the same command line arguments as on the bot. > > Tbr: dpranke@google.com,agrieve@chromium.org,pkotwicz@chromium.org > Bug: 1137405, 1115604 > Change-Id: I28c9e3179fdbbc36ec515ed6aba8ce12f78a9417 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464270 > Reviewed-by: Egor Pasko <pasko@chromium.org> > Commit-Queue: Egor Pasko <pasko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816171} TBR=pasko@chromium.org,dpranke@google.com,agrieve@chromium.org,pkotwicz@chromium.org Change-Id: Idbf4716df8f967209ff155756186a41e2b6e7a93 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1137405 Bug: 1115604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466423Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#816285}
-
Sunil Kumar authored
Bug: 168739659 Test: CQ Change-Id: Ib08ee3223f32318653b3bd6924fedf718887bb7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453916 Commit-Queue: Sunil Kumar <skx@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#816284}
-
Peter Boström authored
Moves ChromeLayoutProvider::GetDistanceMetric() values of views::DistanceMetric into views::LayoutProvider::GetDistanceMetric(). As ChromeLayoutProvider was effectively always overriding these, the set of constants in views::LayoutProvider were effectively unused. This calls views::LayoutProvider::GetDistanceMetric() for any values defined in views::DistanceMetric. It also (by static_cast<>) ensures that all values of views::DistanceMetric and ChromeDistanceMetric are handled in their respective switches. Finally, DISTANCE_BUBBLE_PREFERRED_WIDTH and DISTANCE_MODAL_DIALOG_PREFERRED_WIDTH are both moved into views:: as they are used (but previously inlined with a TODO) in BubbleDialogModelHost. Bug: None Change-Id: I5d890895eacca02d8a59d20714b8bf56040de97e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461220 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#816283}
-
Stefan Zager authored
BUG=1137432 Change-Id: Id58e5ba66e1ca0c03df0c51fcb4615d2ab1ae3fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465209Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#816282}
-
Pavel Yatsuk authored
InfoBar.java has a native reference to InfoBarAndroid which should be cleared before InfoBarAndroid is destroyed. Calls to java_info_bar_.Reset() without corresponding onNativeDestroyed() or setNativeInfobar() allow scenarios where java InfoBar still has non-null pointer after native object was destroyed. This results in occasional use-after-free. This CL: - renames onNativeDestroyed method to resetNativeInfoBar to indicate that it is not necessarily called when native is destroyed, but in general when native-java association changes. - adds a call to reset native infobar into CloseJavaInfoBar to prevent java infobar from referring potentially destroyed native object. - removes unused ReassignJavaInfoBar(). BUG=1135130 R=mdjones@chromium.org Change-Id: I1329ed6a78cc589d8f23df883a8fcb60689230a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459268Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#816281}
-
Mark Schillaci authored
This CL fixes a bug with nodes that are multiselectable when a user is using a screen reader. Certain multiselectable nodes (pop up buttons, <select>) will double read the number of currently selected items. This CL fixes the bug to only read once. AX-Relnotes: N/A Bug: 1122192 Change-Id: Ife9320ab6de6057fa4436123d2e01a006252152c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463534Reviewed-by:
-
David Benjamin authored
See https://boringssl-review.googlesource.com/c/boringssl/+/42384. Change-Id: Ib427b9a91208395560d1bac292ed13d78ed02636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437928 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#816279}
-
Yifan Luo authored
Drop `config_` and use HashSet for config values instead. Bug: 1116418 Change-Id: I7581614ad2fd0e750b5bf428679242efe362566f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461336 Commit-Queue: Yifan Luo <lyf@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#816278}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/896ca12d..ba88e59b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib89c2d178816166b44bba0f3a3c4e2b4ee5e8b03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466436Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816277}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/109c355900d1..7c7b98f06001 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I00e9f11cda48c06191483103f79c30f2a40f00de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466376Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9213e610ed92..4aa4c6014d56 2020-10-12 adlai@google.com Migrate gpu resource methods to GrDirectContext 2020-10-12 johnstiles@google.com Rename SkTArray::allocCntForTest to capacity. 2020-10-12 adlai@google.com Migrate resource cache methods to GrDirectContext 2020-10-12 bsalomon@google.com Remove SkSurface::MakeFromBackendTextureAsRenderTarget 2020-10-12 adlai@google.com Migrate releaseResourcesAndAbandonContext to GrDirectContext 2020-10-12 johnstiles@google.com Add test for disabling the inliner. 2020-10-12 johnstiles@google.com Clean up SkSL inliner and allow it to be disabled. 2020-10-12 johnstiles@google.com Reland "Remove inliner from IR generation stage." 2020-10-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 3df629c55d89 to 0f55e3e5d266 (62 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Test: Test: Test: CQTest: Test: GLES1ConformanceTest.SpotExpDir/ES1_VulkanTest: Test: TransformFeedbackTest.RecordAndDrawWithScissorTestTest: Test: angle_end2end_tests on OSX 10.15 Change-Id: Ifd3b407f7d0aa50fab30040c80a3fc77c1ad9784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466400Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I7f36bd11efe6121efb8bde066607a8e70bea3ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465868Reviewed-by:
-
Erik Chen authored
Ash now sends, at lacros startup, a map of all crosapi interfaces and their versions to Lacros. Lacros can use this map to synchronously query version info. Bug: 1136652 Change-Id: I14be7f1c9c39709e342c6ab8045587f7d1245e74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454629 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#816273}
-
Tommy Li authored
Currently, when the user has chosen about:blank as their homepage, and Chromium starts up, the location bar is focused, but the URL "about:blank" is NOT selected. This leads to the cursor being at index 0, and the user starts typing BEFORE the existing "about:blank" URL, so typing "foo" leads to: "fooabout:blank". This is surprising behavior, and this CL fixes that, as well as adds a test. We originally tried to fix this in 2019, but this effort had to be reverted because we caused a bug on the NTP: https://chromium-review.googlesource.com/c/chromium/src/+/1559115 This CL preserves the fixed NTP behavior (validated by a test), and also fixes the about:blank behavior, also validated by a new test. Bug: 45260 Change-Id: I8ca57ea10215c297aabc22e51138af7ea21ef677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464202Reviewed-by:
-
Steven Bennetts authored
This API is unused and is being deprecated. See issue for details. BUG=1124419 Change-Id: I4083be1d76c61a95f76c744c26621b14eb9ee651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423749 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#816271}
-
dpapad authored
- Update "on-tap=" to "on-click=" in remaining elements. - Update addEventListener('tap', ...) to addEventListener('click', ...) - Address TODO in JSChecker::TapOnPath() to no longer fire 'tap' events - Remove JSChecker::set_polymer_ui() which becomes obsolete. - Remove EulaTest::NonPolymerOobeJS() which becomes obsolete. - Address TODOs in enable_debugging_browsertest.cc Bug: 812035,949377 Change-Id: Ia57b80f3ac7573fc7f505edfc26c967f2944b4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463546Reviewed-by:Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#816270}
-
Austin Eng authored
Bug: none Change-Id: I6a46219a111f9522183c3f496651a0772229d5d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464427 Commit-Queue: Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#816269}
-
Alexander Cooper authored
Moves ArCoreInstallHelper to components, including supporting classes ArCoreShim(Impl) and ArCoreInstallUtils and XrInstallInfoBar. In order to fully move ArCoreInstallUtils, a ArCoreDeviceUtils class was created to manage the last "init" that comes from the ChromeActivity. Note that this is a remnant of the AR DFM which other embedders likely won't need, and could theoretically be removed from //chrome. In moving the "Install" and "Update" strings, they are made a bit more generic, since nothing in them is unique to ArCore. The ic_ar_core_install install graphic is an identical SVG version of the icon currently being used. As there is a TODO to replace it, a new graphic is used to allow for easier replacing. Bug: 1064073,960542 Change-Id: I96c2be6182a5e6d9f09d268e98dbaef94ce68275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453873 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#816268}
-
Nico Weber authored
This is a reland of 174d9faa For the reland, tolerate explicitly set number of concurrent links in thinlto builds as long as it's explicitly set to 1. This is needed for some cros bots. Original change's description: > build: In LTO links, run just one link at once, but give it all cores > > Normally, we allow running several links in parallel if there's enough > memory, since links tend to be memory- and io-bound, not compute bound. > However, in LTO builds the linker does codegen for every linked > translation unit, which needs a lot of CPU. > > Previously, we used to hardcode 8 threads per link for thinlto builds, > which makes builds needlessly slow on machines with many cores. > > Instead, automatically use all cores for a thinlto link, but only run > one link in parallel at once. > > chromeos-chrome-9999.ebuild in the Chrome OS build and link_jobs_32 in > mb_config.pyl currently manually set the number of threads per lto link > to the number of cores. Once this change here is in, we should stop > explicitly setting the arg there and then we can turn this from a gn arg > to a regular variable that's not settable in args.gn > > Bug: 1132930 > Change-Id: If2fda3e38b2b1827beb2da844f024f52211210db > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464782 > Reviewed-by: Hans Wennborg <hans@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816129} Bug: 1132930 Change-Id: I40840f971e2a87afe33e77f537776ba78cf027a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464913Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#816267}
-
Tal Pressman authored
This mirrors the same APIs on Receiver, that should also exist for associated interfaces. Change-Id: Ie2feef11f86b2597a8b431b2bbbbb8110b54b0f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461981 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#816266}
-
Adlai Holler authored
Change-Id: Iebefeb039768f6d15bc0055ca515defebec7e3ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464099 Auto-Submit: Adlai Holler <adlai@google.com> Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
-
Adam Langley authored
Phone-as-a-security-key uses top-level Activities in two ways: 1) When receiving a cloud message that says that an authentication is being attempted, an Android notification is shown that triggers a specified Activity. 2) When using USB fallback, desktop Chrome will use the AOA protocol over USB to attempt to communicate with Chrome on the phone. For the Android system to wire things up correctly, Chrome needs an Intent filter on a top-level Activity to catch the USB device. Currently SettingsActivity (which allows for an arbitrary Fragment to be specified via arguments) is used for case one, and case two isn't functional. This change wires up case two via a new top-level Activity, designed for the purpose, and also routes case one via that Activity too. BUG=1002262 Change-Id: Id2246eddc20073d0695c9f7f7f2abc63b53b48a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454273 Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:Martin Kreichgauer <martinkr@google.com> Commit-Queue: Ted Choc <tedchoc@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#816264}
-
yilkal authored
This cl launches InlineLoginDialog from OOBE after the family link notice screen exits and before the sync screen is shown. The dialog is a windowless dialog, is the exact same shape of the oobe screens and is modal to the oobe screens. Bug: 1128620 Change-Id: Id8d76e54bfa85b2819d8f80f8ed2801d1f63d48e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410813 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Dan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#816263}
-
Kartik Hegde authored
Switch "of" to "or". BUG=chromium:956783 TEST=unit_tests --gtest_filter=GatewayCanBePingedRoutineTest.* Change-Id: I25a8fdfd7bf168a304a6ee97e285e2b81513a1fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461484Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kartik Hegde <khegde@chromium.org> Cr-Commit-Position: refs/heads/master@{#816262}
-
George Burgess IV authored
This new clang-tidy check complains when param names /*in_comments=*/ don't match up with the actual parameter name they're being passed to. Sometimes this is benign, other times, actual bugs are found. Bug: 1136209 Change-Id: I1fd87d09c51889669dc1fe0e6d95508fcc28f643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458890Reviewed-by:
Rushan Suleymanov <rushans@google.com> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#816261}
-
Morten Stenshorne authored
There should be no need to walk all documents in an inner loop while already doing it in the outer loop. The O(n^2) performance complexity is probably negligible, but what I'm actually trying to fix here is problems when compiling with -Wshadow (the problem here being the various |document| variables). Bug: 294205 Change-Id: Ide1ab566e3b9ddb53d4b4f44c9c03633c90348a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460745Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/69d0c1acc28a..f4f1d8a352ca 2020-10-12 hwguy.siplus@gmail.com SPIR-V: Remove SpvTools.h include from disassemble.cpp (#2417) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com Change-Id: I1151e0ddf3a4c2c8b1cc87b8aa52d608883450e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466322Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7c7b98f06001..a4b8d27d96b7 2020-10-12 treehugger-gerrit@google.com Merge "tp: implement async track set tracker" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I1f5b35689586f207e007095f8ef79983dc56e8a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465866Reviewed-by:
-
