- 02 Apr, 2020 40 commits
-
-
zhaoyangli authored
This test suite sometimes hits 1hr and makes ios-simulator-noncq builder fail with timeout. This change makes the suite run in 2 shards and will accelerate the suite. Bug: 1046369 Change-Id: I1b8a8c99cfd1c78fdc88750d2952a335c8951ec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129228Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#756039}
-
Aaron Krajeski authored
We currently test toblob, but only on the main thread. It looks as though we can be at the mercy of the scheduler here, so it would be worthwhile to at least keep track of it. See: crbug.com/1053477 Bug: 1065481 Change-Id: I42ee1f9ae20dbedea45952e7a79ada10d7f9b19b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124971Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yi Xu <yiyix@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#756038}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I1f2ca5baeb7d1cb29e5c203cf106199d1d084feb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134714Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756037}
-
Julie Jeongeun Kim authored
This CL migrates this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose and renames it to percentage-heights-012.html. Bug: 1063749 Change-Id: I8eb11207d1645bb4931f380dda29bddc4fae4879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133988 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#756036}
-
Livvie Lin authored
Use the same OWNERS as ios/chrome/browser/interstitials, since that code will be moved in to this component. Bug: 1064382 Change-Id: I8a1aaee104b951edb052b5ce202e70cfd9654ff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133208Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#756035}
-
Sadrul Habib Chowdhury authored
The events-metrics passed down from the main-thread should only be handled after the main-thread updates become active (i.e. after the pending-tree becomes active). So instead of pushing down the metrics directly to LayerTreeHostImpl, push it down to the pending LayerTreeImpl. BUG=1059282 Change-Id: I572bafaea213e5121504bf2f2bc6875f2af04587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134857Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#756034}
-
Peter Wen authored
Previously, turbine ran annotation processors, javac ran them, and errorprone also ran them. This CL reuses the files that were generated when turbine ran annotation processors so that javac and errorprone no longer ran annotation processors. Saves 4.6s on Base Java Signature Change (153.6s -> 149.0s). More importantly unlocks javac sharding (since javac now depends on turbine). Bug: 906803 Change-Id: Ia8d7218587244d2f5908a5555a13dff3ed781507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133870 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#756033}
-
Greg Guterman authored
Different configs for branches are handled by the git branches themselves, so branch-specific config keys are not needed. Bug: 1062141 Change-Id: I82832cda02ab798afb77fb26d973f001c53c4bdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133078Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Gregory Guterman <guterman@google.com> Cr-Commit-Position: refs/heads/master@{#756032}
-
Tim Song authored
This reverts commit c939527d. Reason for revert: regressed crbug.com/1065739 Original change's description: > Fixed Bubbles not tracking the NativeTheme of their anchoring Widget > > Currently child windows do not track the themes of their anchoring > widget. This can lead to theme mismatches in spawned bubbles (in > particular icons relying on native theme colors in the profile menu > for linux themes). > > This change follows on from a previous change that fixes the issue > for ThemeProviders in Bubbles. Follow up CLs should address the > issue for the more general case of widgets tracking the themes of > the Widgets that spawned them (see https://crbug.com/948859). > > Bug: 1057962 > Change-Id: Ie3a71208cb920e8bced6a8bb2f42968bad46f403 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121075 > Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753398} TBR=pkasting@chromium.org,tluk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1057962 Change-Id: I16a9cae400f47ba2f5172637b8aefaea74050b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131214Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#756031}
-
David Bertoni authored
One of the tests in this suite is flaky, so this CL splits them up into two different C++ test fixtures, in case the flaky one needs to be disabled. It's currently flaking at about 0.1% in the worst case, so hopefully, this won't affect too many builds. Bug: 1056853 Change-Id: Id7bb0342cbb0b67b61f3bea01fc38601f80ec3b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128466Reviewed-by:
Archana Simha <archanasimha@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#756030}
-
Bruce Dawson authored
When SystemSessionAnalyzerTest.ValidateEvents fails we just know that FAILED was returned which is too vague. This adds more specific error codes to zero in on the problem. Bug: 968440 Change-Id: I50b4667536ed5082e6f2f9f91b25384dbe80b526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132785Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#756029}
-
John Z Wu authored
- This avoids rebuilding the same sources for the framework and test. - Created a stub implementation of ios_web_view::InitializeGlobalState to avoid multiple AtExitManagers in unit tests. Change-Id: Ia1a839f2be06d8a9e2974d2e8edb9cf399e849cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121035 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#756028}
-
Jeffrey Cohen authored
Bug: 1036023 Change-Id: I0a764b488a5c52245ee1e7e7e76e48c63e8f879e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129896Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#756027}
-
Matthew Jones authored
This reverts commit 5644e0dd. Reason for revert: Causing crashes in multiwindow. Original change's description: > Remove TabImpl and #getActivity from ReaderModeInfoBar > > Instead of accessing the ReaderModeManager via Tab and ChromeActivity, > a reference to the manager is passed to the native infobar when it is > created and pulled back up to java when needed. This also allowed for > the removal of the GetTab native method. > > Bug: 952703 > Change-Id: Iaacbbda08e28d013538d44c9b985020c175de1be > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122471 > Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Auto-Submit: Matthew Jones <mdjones@chromium.org> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#754230} TBR=mdjones@chromium.org,wychen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 952703, 1067178, 1067134 Change-Id: Icf33e494eaeff4e3d0b6617aa0a5eb4222c41a1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134859Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#756026}
-
Nnamdi Theodore Johnson-Kanu authored
Before this CL some os and browser routes had the same name. This was a bit confusing. If some c++ code called the route '/search', it is not clear if this url is a chrome or browser subpage. A distinction needed to be made. This CL renames OS specific route SEARCH, which is shared with browser routes to a more distinguishable name OS_SEARCH. Allowing this bug(990169) to be unblocked. Bug: 990169 Change-Id: I9f87f1d3d289c4dc31847cbab4c83e90cb47c16a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128092 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#756025}
-
Ahmed Mehfooz authored
Bug: 1066914 Change-Id: I9b9b0251f296a196271c715792d1c4da0c2120db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134928Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/de6fa1ef2946..04c1b445019e git log de6fa1ef2946..04c1b445019e --date=short --first-parent --format='%ad %ae %s' 2020-04-02 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b2379606..b0ab5b8b (755766:755896) Created with: gclient setdep -r src/third_party/webrtc@04c1b445019e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie3572603b991cca5d489ac390868663081d391a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134946Reviewed-by:
-
Jeffrey Cohen authored
screenshot with new icon https://hsv.googleplex.com/6487380976467968 Bug: 1067090 Change-Id: I8eac773b990d99cf45855d37d526b3a7df7ab8f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134578Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#756022}
-
Evan Stade authored
WebLayer won't implement notifications for now, so notifications code is getting left in //chrome. These dependencies are easy to remove and replace with generic permissions/prefs code, which will ease the componentization of WebsitePreferenceBridge. 1. Use PrefServiceBridge to directly set the quiet notification preference instead of adding a specific jni interface in WebsitePreferenceBridge. 2. Use HostContentSettingsMap to set the notification preference by ContentSettingsType rather than using the (thin) wrapper provided by NotificationPermissionContext Bug: 1058600 Change-Id: I450946b545408dbeb1abec6508b3e13f8effb9bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122914 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#756021}
-
Evan Stade authored
This reverts commit b84a396f. Reason for revert: in-flight conflict with d438f8da leads to compile failure ../../chrome/browser/android/feed/v2/feed_stream_surface.h:27:63: error: only virtual member functions can be marked 'override' void InitialStreamState(const feedui::StreamUpdate& update) override; ^~~~~~~~ 1 error generated. Original change's description: > Add InterestFeedV2 feature flag > > If enabled, the v2 feed stream loading task is kicked off when the NTP > or start surface is created. Not currently user-visible; this is > happening silently while the existing feed is created and shown. > > The binary size increase is mainly due to generated proto code that was > added previously but has not been linked until now. We are generating > the sources with "option optimize_for = LITE_RUNTIME;" which matches the > existing feed library and provides an acceptable speed/size tradeoff. > > Once the v2 feed component is fully launched, we can begin removing the > existing feed library. For a recent measurement of the binary size we > would eliminate by removing the existing feed library, see this CL: > https://chromium-review.googlesource.com/c/chromium/src/+/1829821. > > Binary-Size: The increase is temporary (see above). > Bug: 1044139 > Change-Id: Ic596d28e03300ad617f98f0b725cdf5ed1b0b986 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132648 > Reviewed-by: Dan H <harringtond@chromium.org> > Commit-Queue: Ian Wells <iwells@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756004} TBR=iwells@chromium.org,harringtond@chromium.org Change-Id: I42d29a3d64b655fef99944573784f8ce923de78d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1044139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134962Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#756020}
-
Anders Hartvoll Ruud authored
This CL does some refactoring necessary to reduce the noise in subsequent CLs. Instead of returning a value from ResolveIfSurrogate indicating whether the surrogate should be skipped or not, we first determine if the property is a surrogate, and if so, call ApplySurrogate, and deal with any skip/apply logic inside that function. This CL should have no externally observable behavior change, though it does change one detail internally in the StyleCascade: the now-removed ResolveSurrogate function called LookupAndApply on the original property as a way to ensure that this property was marked as applied. The new function (ApplySurrogate) simply marks it as such, effectively skipping it. For symmetry this also adds MarkUnapplied, although this function is unused at the moment. (It will be needed as part of the work on 'revert'). Bug: 579788 Change-Id: Ic10b341f9d6df3cfaa983e10b67cad0cace48a5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128073 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#756019}
-
Xida Chen authored
This is a re-land of: https://chromium-review.googlesource.com/c/chromium/src/+/2079134 The previous CL had a problem where a tracker may not being terminated. This CL fixes that and tests are added. PS#3 is the same as the original CL, so that the diffs can be easily seen. Bug: 1055844 Change-Id: I62cffba355980013db8fa392fbb66d0ea74749af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122242Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#756018}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7b793647316c..33cc65df59f1 git log 7b793647316c..33cc65df59f1 --date=short --first-parent --format='%ad %ae %s' 2020-04-02 mjackson@microsoft.com Revert "Avoid automatically reloading DevTools on Theme change" 2020-04-02 kayce@google.com Update What's New UI for Chrome 83 2020-04-02 alexei.rudenko@gmail.com Disable expanding the Timings group in Timeline if it's empty 2020-04-02 alexei.rudenko@gmail.com Reposition tooltip if the mouse moves Created with: gclient setdep -r src/third_party/devtools-frontend/src@33cc65df59f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1001549,chromium:1039631,chromium:1066427,chromium:986998 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibcf8bd328d82ea6490ed193e949b2632ea70a36b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134361Reviewed-by:
-
Daniel Murphy authored
This change: * Fixes places where I incorrectly put costan@ instead of pwnall@ * Finds all forgotten metrics from dgrogan@ and assigns them accordingly * Adds mek@ to SessionStorage metrics * Extends all important metrics to M95 R=pwnall@chromium.org,mek@chromium.org Fixed: 1061975, 1063896, 1066094, 972788, 975050, 975174, 975188, 975265, 975513, 975574, 975810, 1037120, 1037136, 1037138, 1037139, 1037276, 1037282, 1037283, 1037322, 1037323, 1037324, 1037501, 1037502, 1037505, 1037506, 1037507, 1037508, 1039325, 1043715, 1053129, 1053163, 1053250, 1053269, 1053270 Change-Id: Ib23969254160ef9392f662fe7bc015cb7858fc49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128827 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#756016}
-
Anastasia Helfinstein authored
Similar to ChromeVox, show a sticky notification when Switch Access is enabled that explains how to disable the feature. Relnotes: N/A Bug: 996351 Change-Id: I56546ddfe0d5a4e76eb07e5e55fcdf88ef6b2a1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131015 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#756015}
-
Nate Chapin authored
This ensures it's accessible even if the detached scheduler needs to be accessed through ExecutionContext. Bug: 1066883 Test: http/tests/broadcastchannel/broadcast-channel-constructor-in-detached-window.html Change-Id: Ia6d42010b4c6660db231b0f0b04c0a13d2dd6e94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132777 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#756014}
-
kylechar authored
This CL moves the implementation of Windows SoftwareOutputDevice class declarations into the header so they can be tested. It also adds unit tests for SoftwareOutputDeviceWinProxy. Change-Id: I2c4173dadc24965f70b4d94663849a5555d8225c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124298 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#756013}
-
Anastasiia Nikolaienko authored
Address comments to UI implementation - update margins and logo size. New screenshots: http://slides/1Trd6FeBKqts4iAfYpE8lzzgpeaB_hE8vL8tTY5YA2PI Bug: 1054798 Change-Id: Ic7bf2d72f5cb6cf07b27b95159b06d838283255b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132398Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
-
Stephen Chenney authored
SVG <image> content always respects image-orientation Meanwhile, we paint oriented images incorrectly due to a failure to size the element correctly and a failure to account for the oriented size when computing the aspect ratio transform. Part of the problem was incorrect inverse mapping of the src rect used in other parts of the code, and a missing orientation argument to SizeAsFloat. The code has been fixed and call sites adjusted, with commentary. The test fails due to a lack of fuzzy matching. Bug: 1066685, 1034283 Change-Id: Ifc7fc71599605c4381a71815b989e974b9516517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131407Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#756011}
-
Etienne Pierre-doray authored
Since old DoWork/DoDelayedWork() was removed completely. Bug: 885371 Change-Id: I3e59d89ace56900859bbb1359d36cb54c7981b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130823Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#756010}
-
rajendrant authored
Could not repro the flakes. But from flake logs tentatively adding a wait for ukm metrics. Fixed: 1050728, 1063736 Change-Id: If494242b4bf0dce8afc472b9100db00f08b42fc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130768 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#756009}
-
Sahel Sharify authored
This cl changes payments::ServiceWorkerPaymentApp::UkmSourceId() to use |installable_web_app_info_->sw_scope| for JIT installable PHs while calculating UkmSourceId. Without this change using |stored_payment_app_info_->scope| for JIT installable PHs would cause browser crash in incognito mode. Please note that explicitly returning InvalidUkmSourceId for incognito mode is not needed since UKM recorder does not record entries in incognito mode. Change-Id: I291d1404c89f5261e97d61ca8b74bbbfa905b229 Bug: 1066199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132944Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#756008}
-
rbpotter authored
Bug: 1026426 Change-Id: I46539fbff2ed19bcfd810235d2f9ec5798f33298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133301Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#756007}
-
Monica Basta authored
This CL adds aria-label for the two external link buttons in the sync section in chrome://settings/syncSetup page. Bug: 1066599 Change-Id: I95ff9149b9e1e3da0dbea25b067a26aa7af6fd0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132452Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#756006}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/5b29904d76bc..2b24fab368ae git log 5b29904d76bc..2b24fab368ae --date=short --first-parent --format='%ad %ae %s' 2020-04-02 cwallez@chromium.org Add enga@chromium.org as OWNER 2020-04-02 cwallez@chromium.org Fix -Wunreachable-code-break 2020-04-02 cwallez@chromium.org Normalize case X : {} break; to case X : { break;} Created with: gclient setdep -r src/third_party/dawn@2b24fab368ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Idae79350a432acb43af9bacc31497e4aa618e9cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134624Reviewed-by:
-
Ian Wells authored
If enabled, the v2 feed stream loading task is kicked off when the NTP or start surface is created. Not currently user-visible; this is happening silently while the existing feed is created and shown. The binary size increase is mainly due to generated proto code that was added previously but has not been linked until now. We are generating the sources with "option optimize_for = LITE_RUNTIME;" which matches the existing feed library and provides an acceptable speed/size tradeoff. Once the v2 feed component is fully launched, we can begin removing the existing feed library. For a recent measurement of the binary size we would eliminate by removing the existing feed library, see this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1829821. Binary-Size: The increase is temporary (see above). Bug: 1044139 Change-Id: Ic596d28e03300ad617f98f0b725cdf5ed1b0b986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132648Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#756004}
-
Ben Pastene authored
This reverts commit 7032611d. Reason for revert: No more BOT_DIEDs? Original change's description: > Move linux-chromeos-chrome's browser_tests into its own swarming pool. > > To prevent it from leaving junk around on the machine that causes > other tests in that same pool to fail. > > Bug: 1039746 > Change-Id: I58a9bc242c56f5d7af196335cdd7d621cdb90a15 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995779 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#730595} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1039746 Change-Id: I488153b4319b162b7f8b4c809469104a0360ee30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133233Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/96e14888195d..2da86adf0fb8 git log 96e14888195d..2da86adf0fb8 --date=short --first-parent --format='%ad %ae %s' 2020-04-02 treehugger-gerrit@google.com Merge "trace-processor stat for data source guardrail." 2020-04-02 treehugger-gerrit@google.com Merge "Poll heapprofd memory and add guardrails." 2020-04-02 treehugger-gerrit@google.com Merge "tp: Add missing cmath include needed for std::isnan." Created with: gclient setdep -r src/third_party/perfetto@2da86adf0fb8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia7ed747315867619fdca6a887f8bf9e9a3eb6c3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134619Reviewed-by:
-
Maks Orlovich authored
This is almost entirely from Aaron Tagliaboschi's work at https://chromium-review.googlesource.com/c/chromium/src/+/2019602 This code also removes the unconditional use of GetFrozenUserAgent in isolated_prerender_tab_helper.cc which looked like a mistake; ::GetUserAgent uses that when the experiment is on. Bug: 955620 Change-Id: Id4b719e0b4b1aada85418a889203bb5a85a3e72b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079466 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#756001}
-
Matt Jones authored
This patch adds a new method for generating a complete drag event in TouchCommon: "performDrag". The difference between this method and the existing ones is that it is a single call for the down/move/up stream and most importantly uses deterministic timing. The existing methods are inherently flaky because they use the system time when generating sequential events. This will confuse gesture detectors and cause them to fire flings or empty events when they otherwise wouldn't. The new method specifies a duration that can be used to simulate a fast or slow drag. Bug: 813584, 882003, 947694 Change-Id: I42ab8e8803c8b4e3c81a2876240c365ffc39f4f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134200 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#756000}
-
