- 31 Aug, 2020 40 commits
-
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I9b268c698d8be0a349867f31d78868fd5e25644c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383018 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#803134}
-
Henrik Boström authored
Nits and misc cleanup as a follow-up to landing Perfect Negotiation and "onsignalingstatechange" patches, some of which were pointed out in earlier code reviews but weren't fixed to avoid excessive rebasing. Changes include: - Now that RTCPeerConnectionHandler::OnSignalingChange only does thing related to the tracker, it is renamed TrackSignalingChange, and it is called after TrackSessionDescriptionCallback to be consistent with the order prior to my patches. - Readability: use of auto, for-each and std::move. - Remove TODOs and introduce a DCHECK. TBR=hta@chromium.org Bug: chromium:1122561 Change-Id: Ie888441e07ad2e5f18a7d72bfacb674a356e1305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385356 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#803133}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /chrome/browser/metrics/process_memory_metrics_emitter_unittest.cc This CL was uploaded by git cl split. R=siggi@chromium.org Bug: 1110266 Change-Id: I9014a8e3003f5dba8151c2599d550441a401d7a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371255Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Sean McAllister <smcallis@google.com> Cr-Commit-Position: refs/heads/master@{#803132}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c23eeb8c78ec..ffd61ca01246 2020-08-31 bsalomon@google.com Simpler SkYUVAPixmapInfo construction If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: I44d8b1ce12eb81def266833d8a3757dc3a2728dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384861Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803131}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/be19a45481cf..4191c5c973ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC gab@google.com,kolos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: gab@google.com,kolos@google.com Change-Id: Ifc5e459ee9379a1f83e36e741af46c8c274e5f06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384862Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803130}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ie1df128b9c677f4b86ea138cb8087cd68285dbbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383012Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803129}
-
Philipp Hancke authored
increases the maximum precision of the graphs drawn to 3 since we can have values like jitter or roundtrip time which are measured in seconds but can have millisecond values BUG=chromium:678292 Change-Id: Ibcde153a518d65d1beae2cfb137f39da602b131c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382837Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#803128}
-
Yuly Novikov authored
Recent regressions. conformance/reading/read-pixels-pack-alignment.html conformance/rendering/clear-after-copyTexImage2D.html conformance/rendering/gl-viewport-test.html conformance/rendering/multisample-corruption.html conformance/textures/misc/tex-image-canvas-corruption.html TBR=bsheedy Bug: swiftshader:154, 1123524 Change-Id: I0cb48304919cfe96065d1bfdecaa22fe5680babf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385595Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#803127}
-
Oriol Brufau authored
The CSSWG resolved in https://github.com/w3c/csswg-drafts/issues/4568 that properties like 'text-indent' that don't apply to ::marker, should not be able to affect the ::marker via inheritance when set to an ancestor. Therefore, this patch sets 'text-indent: 0 !important' in UA origin. Bug: 1031667 TEST=external/wpt/css/css-pseudo/marker-content-023.html TEST=external/wpt/css/css-pseudo/marker-default-styles.html TEST=http/tests/devtools/elements/styles-2/pseudo-elements.js Change-Id: I4dd9e8afd448bd5fe237c084d3c0215e91560dd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382750Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#803126}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /chrome/updater This CL was uploaded by git cl split. R=sorin@chromium.org Bug: 1110266 Change-Id: Ic96765ed15e30fdc5c6c84804c75f4290dcefc8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370289Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Sean McAllister <smcallis@google.com> Cr-Commit-Position: refs/heads/master@{#803125}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I1aa8dc85cdb849382d1dc6ece9b03d0c435cf4ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382852Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803124}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f36682af28e2..59d25cd7ff01 2020-08-31 mathias@chromium.org [ts] Type-check ui/Geometry.js with TypeScript 2020-08-31 szuend@chromium.org [issues] Remove issues tab experiment 2020-08-31 mathias@chromium.org Ensure the SplitWidget is not a scrollable container 2020-08-31 kimanh@chromium.org Sort and merge location ranges on stepOver and stepInto 2020-08-31 kimanh@chromium.org Send skipList on stepOver and stepInto 2020-08-31 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-08-31 patrick.brosset@microsoft.com Layout: Assorted cosmetic changes to the layout pane as per mockups If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1066415,chromium:1072302,chromium:1105765,chromium:1109177 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icc8e2c17044e89f6f8376f4867f9b8d5acc326f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384865Reviewed-by:
-
Mohamed Amir Yosef authored
... 1- SavedPasswordsPresenter 2- CompromisedCredentialsManager Bug: 1108422 Change-Id: I5beccb92538186d3d0958866110d64f3693386cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385276 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#803122}
-
Antonio Sartori authored
This CL implements the part computing the intersection of two sources of the Content Security Policy: Embedded Enforcement subsumption algorithm following https://w3c.github.io/webappsec-cspee/#intersection-source-expressions in the services/network Content Security Policy module. This is part of a series of CL implementing the whole subsumption algorithm according to that spec. Bug: 1094909 Change-Id: I835c42632cacfd884321ee43a2f2a06c31abab8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315687Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#803121}
-
Benoit Lize authored
We get the process creation time on Linux by reading /proc/PID/stat. On Android, this is allowed if PID == "self". Make the code allow that. Change-Id: Ib2d41f3c361c3d632cae450e79c1e3d6bcafa60a Bug: 691874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379743Reviewed-by:
-
adamta authored
Adds UMA histograms for any action taken in the Discover feed header menu. Bug: 1085419, 1122672 Change-Id: Ic9d4612af10b975a084bbb5b8416e23f048f747e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380413Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Cr-Commit-Position: refs/heads/master@{#803119}
-
Aaron Leventhal authored
TBR=dmazzoni@chromium.org NOTRY=true Bug: None Change-Id: Ic4a13ac76e42a2813d2c476c4bd552eb6b46b3a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383690Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#803118}
-
adamta authored
Refactors infinite feed triggering by moving the conditional logic in the VC. Logs an action when user reached the bottom of the current feed, requesting a new set of articles. Bug: 1085419, 1122409 Change-Id: I99c734aaa5912e1d82e2330ec200593648fa8153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363219Reviewed-by:
-
Ewann authored
This CL adds the following actions to the ReadingList Context Menu: - Mark As Read - Mark As Unread - View Offline Version in New Tab Bug: 1093302 Change-Id: Ie17e58417738cbc5cc2c3a345c281464339170b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366799Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#803116}
-
Liquan (Max) Gu authored
Change: * Move calculateWhetherShouldSkipShowingPaymentRequestUi() and mShouldSkipShowingPaymentRequestUi into PaymentUIsManager because they are UI logic. Bug: 1102522 Change-Id: I0f91e56298fb211c55eff1efc5c33871173a5f49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382653Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#803115}
-
Peter Kasting authored
Bug: 1123344, 1123345 Change-Id: Id0433c3defeadc07aaf35d81de1b37f965e0d8aa Tbr: jdonnelly Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385240 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#803114}
-
Sundoo Kim authored
Fix swapping argument to FromVectorIcon() in location bar. Bug: 1123344 Change-Id: Ib2ddcd50b5095d349f9d996f750e9b61f6c52860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385478Reviewed-by:
-
Martin Kreichgauer authored
WebAuthn Level 2 adds an enum-valued |resident_key| property to AuthenticatorSelectionCriteria. When making a credential, the existing boolean |require_resident_key| property indicates whether the browser should create a client-side discoverable (resident) credential. The new enum-valued alternative adds a middle value ("preferred") that yields a resident credential if the user's authenticator supports it, and a non-resident credential otherwise. Web-facing changes in this CL, i.e. the addition of the ResidentKeyRequirement enum as well as the resident_key property in AuthenticatorSelectionCriteria, are guarded by a new Blink feature flag (WebAuthenticationResidentKeyRequirement). Bug: 1117630 Change-Id: I89656a10a977023a4ca60b59ad1de5cd03800f44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376570Reviewed-by:Matthias Körber <koerber@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#803112}
-
Scott Violet authored
The crash is happening because setTranslationY is being called when the InfoBarContainerView's tab is no longer active. This is problematic as when the tab is not active getBrowser().getViewController() returns null. Two fixs: . make SwipableOverlayView cancel the animation when removed. . make InfoBarContainerView handle this situation better. The latter is necessary as setTranslationY() is a public method, and may be called at any time. BUG=1121393 TEST=none (at the moment it's a bit hard to trigger this code path from tests). Change-Id: I95cd82f13efc07f81bec3a00b6c7513472bdbaea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382680Reviewed-by:Dominick Ng <dominickn@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#803111}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I97c18726ba379e806047cbb09e33f2bcf14f7a77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382756 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#803110}
-
Peter Kotwicz authored
This CL updates the docs with function rename in https://chromium-review.googlesource.com/c/chromium/src/+/2350234 Change-Id: Ia08ca3ef4d8b9bafa5b78889a1571bd0ccadce79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384650 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#803109}
-
Kushagra Sinha authored
This is related to https://crrev.com/c/1903365 - with the additional check that |g_browser_process| may be abnormally shutting down without |chrome::IsAttemptingShutdown| being true - which happens only for a clean, user attempted shutdown. Bug: 1121894 Change-Id: I6d4aa7de8998ad0c621f0fc17a17853924cfd342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385437Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#803108}
-
Dylan Cutler authored
- Moves instrumentation to a separate function in an anonymous namespace. - Uses <initializer_list> library and for-range loops to reduce repeated code. Bug: 973801 Change-Id: Icf6df079e351e154ca8fd6f8872488993d6fc97d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381135Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#803107}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I8480e43b27e64c014641a55bcbe6288e4bb94a62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384859Reviewed-by:
-
Jinsuk Kim authored
Overscroll release without preceding pull requests causes null pointer deference in its scene layer when attempting to obtain resource manager instance. This CL prevents the crash by checking such incidence. Bug: 1119713 Change-Id: I83f4376aa2672c166c8ea693a8a4057b17bb44f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382994Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Auto-Submit: Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#803105}
-
chromium-autoroll authored
This is a reland of a0522042 Original change's description: > Roll DevTools Frontend from b6f22fe80638 to f36682af28e2 (1 revision) > > https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b6f22fe80638..f36682af28e2 > > 2020-08-31 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/devtools-frontend-chromium > Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Bug: None > Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com > Change-Id: I36dc0e3b5f615bdce8a95973f1fbfd7ac8c61611 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384520 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#803028} Bug: None Change-Id: Ice6795e1cc4663a7b3c4dcfe8f9aa3b92c66fd1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385076 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#803104}
-
Hoch Hochkeppel authored
Adding a stub implementation of the mojom ShareService. Currently only for the Windows build, but intended to be useable as the central file from which OS-specific implementations can be connected (e.g. a future share_service_imple_win for the Windows-specific implementation). To exercise this code, enable the Web Share flag in chrome://flags, navigate to https://w3c.github.io/web-share/demos/share-files.html, and attempt to Share content. With this change, calls to navigator.share are completed with a cancellation error, rather than crashing the process. Bug: 1035527 Change-Id: Id01c2a49646fc9e64401f34fe886b2527866ebda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378144Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#803103}
-
Victor Hugo Vianna Silva authored
There was a spike in the flakiness of these tests following 2020-08-03. https://findit-for-me.appspot.com/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyagsSBUZsYWtlIl9jaHJvbWl1bUBzeW5jX2ludGVncmF0aW9uX3Rlc3RzQEVuYWJsZURpc2FibGVTaW5nbGVDbGllbnRUZXN0LkZhc3RFbmFibGVEaXNhYmxlRW5hYmxlT25lQXRBVGltZQw&show_all_occurrences=1 https://findit-for-me.appspot.com/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyZAsSBUZsYWtlIlljaHJvbWl1bUBzeW5jX2ludGVncmF0aW9uX3Rlc3RzQEVuYWJsZURpc2FibGVTaW5nbGVDbGllbnRUZXN0LkZhc3RFbmFibGVEaXNhYmxlT25lQXRBVGltZQw&show_all_occurrences=1 Bug: 1111227 Change-Id: Icdb31b999c89c5796bba63330816c44dc6d23a26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383024Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#803102}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ic06815193acc870c4639a700f4726f2cd21e2699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385435Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803101}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Icb54c2f9e02ca7efc89d5674d22daed4ac1f971a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383022Reviewed-by:
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Iecad2dc339be6d352c3cf420a50b3f9c58cbe68f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382594 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#803099}
-
Andrey Zaytsev authored
Bug: 1123075, 1070620 Change-Id: Id3e1a4c13532a846332935c70cdc02059881ccb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385335 Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#803098}
-
Maksim Ivanov authored
Drop std::move() call that has no effect and only triggers the "bugprone-use-after-move" clang-tidy warning. Bug: 1122844 Change-Id: I04d191a6a73964dbd58b61bce722d5885b140c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383021 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#803097}
-
Brandon Jones authored
These were accidentally left over from a removed change in a previous CL Bug: 1121762 Change-Id: Iff01ecbd0c78a96535cc0193d03e18eb04d98042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382115 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#803096}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I0af5f12d7e856ec1f128cbe7d5fd08035de6fe72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383654 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#803095}
-
